Tuesday, 2018-06-12

*** dardelean_ has joined #openstack-containers00:00
*** kbyrne has quit IRC00:38
*** kbyrne has joined #openstack-containers00:41
*** jmlowe has joined #openstack-containers00:41
*** dardelean_ has quit IRC00:42
openstackgerritJim Bach proposed openstack/magnum master: Allow multimaster lb with no floating ip option  https://review.openstack.org/57447600:55
*** dardelean_ has joined #openstack-containers01:05
*** dardelean_ has quit IRC01:10
*** mdnadeem has joined #openstack-containers01:13
*** mdnadeem has quit IRC01:20
*** dave-mccowan has quit IRC01:30
*** mdnadeem has joined #openstack-containers01:33
*** pengdake has joined #openstack-containers01:36
*** hongbin has joined #openstack-containers02:02
*** ricolin__ has joined #openstack-containers02:06
*** rcernin is now known as rcernin|lunch02:35
openstackgerritqingszhao proposed openstack/magnum-tempest-plugin master: fix tox python3 overrides  https://review.openstack.org/57451102:43
*** chhagarw has joined #openstack-containers02:46
*** dave-mccowan has joined #openstack-containers02:52
*** mdnadeem has quit IRC02:53
*** sheel has joined #openstack-containers03:07
*** Nel1x has quit IRC03:19
*** hongbin has quit IRC03:26
openstackgerritFeilong Wang proposed openstack/magnum master: Make etcd loadbalancer optional  https://review.openstack.org/57454003:49
*** ianychoi has joined #openstack-containers03:51
*** udesale has joined #openstack-containers03:52
*** mdnadeem has joined #openstack-containers03:59
*** mdnadeem has quit IRC04:00
*** mdnadeem has joined #openstack-containers04:00
*** dave-mccowan has quit IRC04:05
*** yamamoto has joined #openstack-containers04:08
*** mdnadeem has quit IRC04:08
*** ykarel|away has joined #openstack-containers04:09
*** jmlowe has quit IRC04:10
*** ramishra has joined #openstack-containers04:10
*** mdnadeem has joined #openstack-containers04:11
*** ykarel_ has joined #openstack-containers04:21
*** ricolin__ has quit IRC04:21
*** pengdake has quit IRC04:21
*** ricolin has joined #openstack-containers04:22
*** ykarel|away has quit IRC04:23
*** flwang1 has quit IRC04:52
*** mdnadeem has quit IRC04:57
*** mdnadeem has joined #openstack-containers04:58
*** yasemin has quit IRC05:02
*** yasemin_ has quit IRC05:02
*** yasemin has joined #openstack-containers05:05
*** pengdake has joined #openstack-containers05:20
*** zhubingbing has joined #openstack-containers05:23
*** pcaruana has quit IRC05:24
*** zhubingbing has quit IRC05:28
*** AlexeyAbashkin has joined #openstack-containers05:39
*** pengdake has quit IRC05:39
*** Alexey_Abashkin has joined #openstack-containers05:42
*** Alexey_Abashkin has quit IRC05:42
*** Alexey_Abashkin has joined #openstack-containers05:42
*** AlexeyAbashkin has quit IRC05:43
*** Alexey_Abashkin is now known as AlexeyAbashkin05:43
*** AlexeyAbashkin has quit IRC05:45
*** pengdake has joined #openstack-containers05:54
*** mjura has joined #openstack-containers06:09
*** iranzo has joined #openstack-containers06:11
*** iranzo has joined #openstack-containers06:11
*** udesale has quit IRC06:18
*** udesale has joined #openstack-containers06:18
*** pcaruana has joined #openstack-containers06:27
*** dardelean_ has joined #openstack-containers06:35
*** gsimondon has joined #openstack-containers06:39
*** dardelean_ has quit IRC06:40
*** pengdake has quit IRC06:41
*** AlexeyAbashkin has joined #openstack-containers06:42
openstackgerritXiaojueGuan proposed openstack/python-magnumclient master: Update links in README  https://review.openstack.org/57458306:45
*** pengdake has joined #openstack-containers07:03
*** AlexeyAbashkin has quit IRC07:04
*** vabada has joined #openstack-containers07:07
*** AlexeyAbashkin has joined #openstack-containers07:10
*** rcernin|lunch has quit IRC07:13
*** vabada has quit IRC07:13
*** mago_ has joined #openstack-containers07:14
*** ykarel_ is now known as ykarel07:15
*** zhubingbing has joined #openstack-containers07:25
*** zhubingbing has quit IRC07:29
*** pcaruana has quit IRC07:34
*** serlex has joined #openstack-containers07:40
*** b_bezak has joined #openstack-containers07:42
*** pcaruana has joined #openstack-containers07:49
*** ktibi has joined #openstack-containers07:51
*** janki has joined #openstack-containers07:57
*** pcaruana has quit IRC07:59
*** b_bezak has quit IRC08:03
*** pcaruana has joined #openstack-containers08:15
*** ykarel_ has joined #openstack-containers08:21
*** ykarel has quit IRC08:23
*** ykarel_ is now known as ykarel08:28
*** dardelean_ has joined #openstack-containers08:41
*** vabada has joined #openstack-containers08:51
*** AlexeyAbashkin has quit IRC08:54
*** AlexeyAbashkin has joined #openstack-containers08:58
*** salmankhan has joined #openstack-containers08:59
*** ktibi_ has joined #openstack-containers09:08
openstackgerritMerged openstack/magnum master: fix tox python3 overrides  https://review.openstack.org/57296409:08
*** skyscraper has quit IRC09:10
*** skyscraper has joined #openstack-containers09:10
*** ktibi has quit IRC09:10
vabadaNAMES09:12
*** zhubingbing has joined #openstack-containers09:26
*** flwang1 has joined #openstack-containers09:30
flwang1strigazi: do we have meeting in 30 mins?09:31
*** zhubingbing has quit IRC09:31
strigaziflwang1: yes09:32
flwang1cool09:33
openstackgerritSpyros Trigazis proposed openstack/magnum master: WIP: Add cluster upgrade to the API  https://review.openstack.org/51495909:34
flwang1strigazi: did you ever see this issue https://scanner.heptio.com/95e0e1f080fe77c2a860cff8b2866f83/diagnostics/ ?09:34
strigazinever09:35
flwang1hmm... ok09:35
strigaziI had an error on Sonobuoy only once09:35
flwang1did you run it recently?09:35
strigazibut it was a single error09:35
strigazinot very09:36
strigaziI'll create a cluster and run it09:36
flwang1cool, thanks09:36
flwang1and i have a question about lb09:36
strigazishoot09:37
flwang1if user just create a one master cluster with lb09:37
flwang1then he/she want to scale up to 3 masters09:37
flwang1can the 2 new master nodes be automatically added into the existing lb?09:37
strigaziIt doesn't work, but it a very much desired thing to09:37
strigaziIt doesn't work, but it a very much desired thing to do09:37
strigaziyes09:37
flwang1yes for what?09:38
strigaziinfra wise, the nodes will be added to the lb09:38
strigaziconfig-wise etcd won't work09:38
flwang1because some users may start with a testing/dev cluster but want to keep the possibility to migrate/upgrade to a prod09:38
strigazigot it, makes sense09:39
*** Alexey_Abashkin has joined #openstack-containers09:40
*** AlexeyAbashkin has quit IRC09:40
*** Alexey_Abashkin is now known as AlexeyAbashkin09:40
flwang1ok, i will create a story to track it anyway09:40
strigaziflwang1: I'm not sure if the discovery url can help on adding nodes09:41
flwang1strigazi: we may need a better way for ectd discovery09:41
strigaziflwang1: etcd docs don't mention it for changing the cluster09:41
flwang1i will dig09:41
strigaziflwang1: in magnum you can use your own, --discovery-url09:42
flwang1yes, i know that09:44
strigaziflwang1: I'm also up for multi master without lB09:46
strigaziflwang1: I'm also up for multi master without LB09:46
flwang1ok09:46
strigaziflwang1: does that use case interest you?09:47
flwang1yes, i think it's useful09:47
flwang1but it's not on our MVP now09:47
flwang1the only feature missing now on our MVP list is the cluster upgrade09:48
flwang1but it won't block our beta release09:48
flwang1strigazi: did you see my patch for optional etcd lb https://review.openstack.org/#/c/574540/1/magnum/drivers/common/templates/environments/with_etcd_lb.yaml ? do you think it works?09:50
flwang1i haven't tested09:50
strigaziflwang1: it should09:52
strigaziflwang1: but, I'm not sure that we need one09:52
strigaziflwang1: the apiserver and flannel allow you to define all etcd endpoints09:53
strigaziflwang1: I'm not against it of course09:53
strigaziflwang1: But I'm not sure if it is worth it09:53
flwang1ok, i will test it tomorrow09:54
strigaziflwang1: even with the separate RG you were discussing, we can manage without an LB, but09:54
strigaziflwang1: if you think is easier to manage and it is a desired feature for you +1 from me09:55
flwang1sorry, a little bit confusing, you mean the optional etcd lb patch or the multi master race condition patch?09:56
strigaziI'm talking about the etcd lb patch09:56
flwang1cool, yep, it would be nice if we can make etcd lb optional09:57
strigazioptional vs none at all?09:57
flwang1for public cloud, it means the cost of one k8s cluster could be lower09:57
*** ricolin has quit IRC09:57
flwang1True  mean you will get lb for etcd, False means no LB for etcd09:58
*** ricolin has joined #openstack-containers09:58
strigaziflwang1: for private clouds, LBs mean cores so it also expensive for us09:58
flwang1exactly09:58
flwang1then let's get it done in Rocky09:58
strigazi#startmeeting containers09:58
openstackMeeting started Tue Jun 12 09:58:58 2018 UTC and is due to finish in 60 minutes.  The chair is strigazi. Information about MeetBot at http://wiki.debian.org/MeetBot.09:58
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.09:59
*** openstack changes topic to " (Meeting topic: containers)"09:59
openstackThe meeting name has been set to 'containers'09:59
strigazi#topic Roll Call09:59
*** openstack changes topic to "Roll Call (Meeting topic: containers)"09:59
strigazio/09:59
brtknro/09:59
flwang1o/09:59
strigaziThanks for joining the meeting brtknr flwang1 :)10:00
strigazi#topic Announcements10:00
*** openstack changes topic to "Announcements (Meeting topic: containers)"10:00
ricolin0/10:01
strigaziMagnum is on storyboard \m/10:01
ricolinYay10:01
brtknrstrigazi: Hurrah! Including blueprints>10:01
brtknrs/>/?10:01
strigaziI also moved the bps. Need to reset some statuses10:01
*** iranzo has quit IRC10:02
strigazieg, this was a BP https://storyboard.openstack.org/#!/story/200221010:02
ricolinThat way we can setup cross project task cross Heat and magnum10:02
strigazibrtknr: the problem is that what did was:10:02
strigazibp_status -> story_status -> task_status10:03
strigazibut story_status is implicit and the status info got lost in the way10:03
ricolinHere is an Etherpad I build for Heat most information also apply in magnum as well10:03
ricolinhttps://etherpad.openstack.org/p/Heat-StoryBoard-Migration-Info10:03
strigazistotyboards client is pretty sweet so I'm scripting it again10:04
strigazithanks ricolin10:04
strigaziquestions about story board?10:04
strigazi#topic Blueprints/Bugs/Ideas10:05
*** openstack changes topic to "Blueprints/Bugs/Ideas (Meeting topic: containers)"10:05
strigaziI pushed a patch for uprgades, you can have a a look in the story above10:06
strigazioh, it is not there, I didn't add the task, but here it is:10:07
flwang1strigazi: thanks, but i can see the new api to list the valid versions can be upgraded to10:07
strigazi#topic Blueprints/Bugs/Ideas10:07
*** openstack changes topic to "Blueprints/Bugs/Ideas (Meeting topic: containers)"10:07
strigazi#topic Blueprints/Bugs/Ideas10:07
*** openstack changes topic to "Blueprints/Bugs/Ideas (Meeting topic: containers)"10:07
strigazihttps://review.openstack.org/51495910:07
strigaziflwang1: which api? list versions?10:08
flwang1strigazi: yes10:08
strigaziWe don't have such thing in the spec, users can see versions in cluster templates10:09
flwang1ok, we can discuss it offline10:10
strigaziok, this is the api side10:10
strigazion the driver side,10:10
strigaziI have some issues when replacing nodes10:11
strigaziWe are setting the node name so:10:11
strigazi1. the k8s cloud provider complains that it sees many nodes with the same name10:12
strigazi2. in clouds that the nova name matche dns name, vm creation won't work10:12
strigazidoes these two make sense?10:12
strigazis/does/do10:13
brtknryes10:13
flwang1strigazi: do we have to use the same name?10:14
strigaziSo, we need to change the name if we want heat to do the rolling replacement magic10:14
strigaziflwang1: we don't but right now we do10:15
flwang1ok10:15
strigaziflwang1: and it is more user friendly10:15
flwang1i don't really think it's user friendly10:15
*** salmankhan has quit IRC10:15
ricolinIs that the same thing that we talk about easier?10:15
flwang1it could be confusing10:15
strigazifor users to see <cluster-name>-some-ids10:15
strigaziricolin: yes10:15
*** salmankhan has joined #openstack-containers10:15
strigaziflwang1: you this name is better ku-jamh4gh6zb-0-uwgdrnyx3azd-kube-master-vnzxh43pokl4 than10:17
ricolinI’m thinking maybe we can have a Pre-action before  update replace forSD10:17
strigazithis one strkube-scanner-ne7at5fdzfhy-master-010:17
strigazimy cluster is named strkube-scanner10:17
flwang1no, i mean only change the random id part10:18
flwang1we should still use the cluster name as the prefix10:18
strigaziwe need something random10:18
flwang1we can discuss offline10:18
strigaziricolin: there are two things10:18
strigaziricolin: one is the name issue the other is the SD dependency which I think it is not a problem  in the end, I think it was an issue because of the nameing bug10:19
strigaziI'll propose something in the storyboard we can take it there10:20
strigaziThis is it from me, last week was upgrades and storyboard10:21
* ricolin using my phone so can’t really type fast:)10:21
strigaziflwang1: go next?10:21
flwang1sure10:21
flwang1i'm working on many things recently10:21
strigaziI saw, that is awesome10:22
strigazithanks :)10:22
flwang11. the keystone k8s integration, lingxian has done a great job to support configmap for k8s-keystone-auth10:22
flwang1with that case, we could be more easier to integrate it, i will add more patch sets later10:23
flwang12. I'm still working on the FEK stuff, to support logging, but i may hold it a bit due to limited bandwidth recently10:23
flwang13. the health_status and health_status_reason attributes10:24
flwang1it's going well, and Ricardo left some great questoins10:24
flwang1i will discuss it with strigazi and ricardo10:24
strigazi#link https://review.openstack.org/#/c/570818/10:25
flwang14. deprecate the send_cluster_metrics, it's ready for review10:25
*** ricolin has quit IRC10:25
flwang15. fix the race condition issue when creating multi masters  https://review.openstack.org/57363910:25
flwang1it's ready for review, i have tested it locally, it works fine10:26
flwang16. make the etcd lb optional, see https://review.openstack.org/574540  it's still working in progress10:26
flwang1that's all from my side, thanks10:26
strigazithanks flwang110:27
strigazibrtknr: want to bring up something about cgroups/ docker-ce?10:27
*** AlexeyAbashkin has quit IRC10:28
strigazilet's move to open discussion then10:29
strigazi#topic Open Discussion10:29
*** openstack changes topic to "Open Discussion (Meeting topic: containers)"10:29
strigaziAgain, the meeting time10:29
*** pengdake has quit IRC10:30
flwang1i'd like to discuss the naming convention of those lovely scripts https://review.openstack.org/56245410:31
strigaziRecently a US company showed some interest and started to contrubute and they try to get involved, should we alternate bi-weekly?10:31
brtknrSorry I was AFK briefly10:31
flwang1strigazi: i would prefer to avoid bi-weekly alt10:31
flwang1because based on my experience, it doesn't work well10:32
strigazihow can we get them though? Two weekly meetings?10:32
flwang1people  are always confused10:32
*** ricolin has joined #openstack-containers10:32
flwang1they can popup anytime actually10:32
flwang1it's an IRC channel10:32
flwang1what's their time based on our current meeting time?10:33
strigaziyes, but we are not always online :)10:33
flwang1do you know their tz?10:33
strigazicalifornia10:33
brtknrstrigazi: 3:33 am in california right now10:33
flwang1ok, for that case, we can try bi-weekly alt10:34
strigazior two meetings?10:35
flwang1i don't mind 2 meetings actually10:35
brtknri dont mind 2 meetings either, im probably only going to come to one appropriate to my timezone10:35
strigaziwith two meetings, no one will show up and there won't be a meeting10:35
strigaziwe can 1600 ot 1700 UTC for them10:36
strigaziwe can do 1600 or 1700 UTC for them10:36
brtknrflwang1: where are you now?10:36
flwang1brtknr: NZ10:36
strigazieven 1800 UTC10:36
brtknrso its 10pm there?10:37
flwang110:37PM10:37
brtknrwow true dedication!10:37
brtknr+1 to 1700 UTC10:37
flwang1brtknr: no worries, strigazi will buy me a beer10:38
strigaziflwang1: or many10:38
strigazion berloin10:38
strigazion berlin10:38
flwang1strigazi: ok, logged10:38
ricolinBerlin!!!10:38
strigaziflwang1: 1700 utc for you?10:38
flwang1strigazi: that works for me10:38
brtknrflwang1: thats 5am!10:39
brtknrhow about sunday?10:39
flwang1brtknr: it's true, i generally start up at 5 am10:39
strigaziOk. I can send an email and ask them10:39
brtknrwhats the company called?10:39
strigaziin the ML10:39
strigaziBlizzard10:40
flwang1brtknr: it doesn't work haha, i need to have time with kids10:40
flwang1strigazi: ah, Blizzard10:40
brtknrwow! cool! world of worldcraft blizzard?10:40
flwang1wow10:40
flwang1brtknr: yes, they are using openstack a lot10:40
ricolinYes10:41
brtknri was joking about sunday10:41
flwang1brtknr: i know, no worries10:41
brtknrmaybe friday 5am is best?10:42
flwang1Friday sounds good10:42
strigaziwe can do thursday, friday for flwang110:42
brtknrend of week, enough gap from tuesday10:42
*** mago_ has quit IRC10:42
flwang1yep10:42
strigazilet's see, I'll send an email10:43
strigazibrtknr: want to discuss anything?10:43
brtknri'm still waiting for review10:43
brtknron the two things10:43
brtknrthanks for the earlier comments10:44
flwang1brtknr: your patches on my list, but i need to find a time slot, sorry for that10:44
strigaziflwang1: regarding the script name I'll check the patch, standards are good. We can make them SD as well10:44
strigaziflwang1: since we touch them10:44
strigazibrtknr Do you have time to add docker-ce? is it in your lsit?10:45
brtknrstrigazi: docker-ce is on my list10:45
strigazibrtknr: we can do containerd too10:45
*** ricolin has quit IRC10:45
brtknri'll read up on containerd10:46
strigazibrtknr: What we need is to setup builds for the containers10:46
flwang1strigazi: thanks, pls see my comments in the renaming patch when you have time10:46
brtknrat creation?10:46
brtknrrather than pull image from a source?10:46
strigazibrtknr: no, just a CI10:46
strigazibrtknr: to populate the source10:46
brtknrstrigazi: who will host the source?10:47
strigaziI'll see with the infra team how to setup10:47
*** ricolin has joined #openstack-containers10:47
brtknrstrigazi: cern? docker.io?10:47
strigazibrtknr: now we have docke.io10:47
flwang1strigazi: is cern using a private registry?10:47
strigaziwe can also use quay.io push to both10:47
strigaziflwang1: yes10:47
flwang1what's it?10:48
strigazigitlan10:48
strigazigitlab10:48
strigaziit implement docker registry v210:48
brtknrcern's registry is super fast compared to docker.io10:48
strigaziit implements docker registry v210:48
strigazibrtknr: yes but we can't rely on it as a an OS project10:49
flwang1we're going to use Harbour10:49
brtknrstrigazi: i was making an observation!10:49
flwang1from vmware10:49
strigazibrtknr: let's setup the ci and we can push anywhere we want10:49
brtknrsounds good10:50
strigaziflwang1: is it docker registry v2?10:50
flwang1IIRC, yes10:51
flwang1i will double check10:51
*** mdnadeem has quit IRC10:51
strigaziok, last thing about the registry, should we have a repo for container image builds?10:51
brtknri'm probably going to be learning as i go along so i'll have lots of questions probably10:52
strigaziflwang1: you think it is complicated?10:52
brtknrcould you elaborate the question?10:52
flwang1strigazi: it would be nice to have a repo10:52
strigazibrtknr: have a new repo10:52
flwang1or we can hold it magnum repo initially10:52
strigaziopestack/magnum-containers10:52
flwang1strigazi: it's not complicated10:53
strigazicool10:53
brtknroh okay i see what you mean10:53
strigazilet's start in o/m and we see10:53
ricolinYou can build a periodic job to build it10:53
flwang1it would be nice if we can have a CI to public images automatically10:53
strigaziflwang1: that is the goal10:53
brtknryeah dont see any immediate need to separate repos10:53
strigazibrtknr: +110:54
brtknrstrigazi: although i was wondering if fedora atomic elements are still necessary10:54
brtknrstrigazi: for diskimagebuilder10:54
brtknrstrigazi: since the image works out of the box now10:54
strigazibrtknr: they are not10:54
brtknrstrigazi: should we drop them?10:55
strigazibrtknr: sure10:56
strigaziwe can add them back if someone  needs them10:56
brtknrwhen i got started with magnum, it was quite a distraction as I started building fa27 image using the elements then later realised it wasn't required at all10:57
strigazianyhting else for the meeting?10:57
strigazibrtknr: I have spent quite some time with it10:57
strigazibrtknr: it wasn't funny10:57
flwang1are you talking about this https://github.com/openstack/magnum/tree/master/magnum/drivers/common/image ?10:57
strigaziflwang1: yes /fedora-atomic not the agent10:58
flwang1ok, got10:58
flwang1we don't need it10:58
*** mago_ has joined #openstack-containers10:58
flwang1we may need better tagging for the heat-container-agent btw10:58
flwang1nothing from my side10:59
brtknrokay great10:59
strigaziflwang1: we can iterate when we have builds11:00
flwang1strigazi: cool11:00
strigazicool, thanks guys11:00
strigazi#endmeeting11:00
*** openstack changes topic to "OpenStack Containers Team"11:00
openstackMeeting ended Tue Jun 12 11:00:32 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)11:00
openstackMinutes:        http://eavesdrop.openstack.org/meetings/containers/2018/containers.2018-06-12-09.58.html11:00
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/containers/2018/containers.2018-06-12-09.58.txt11:00
openstackLog:            http://eavesdrop.openstack.org/meetings/containers/2018/containers.2018-06-12-09.58.log.html11:00
brtknrBtw, what is the convention for filing patches now? We first post a story and then reference story in the patch?11:01
strigazibrtknr: yes, story and tasj11:01
strigazibrtknr: yes, story and task11:01
*** ricolin has quit IRC11:03
*** kaiokmo has quit IRC11:04
openstackgerritBharat Kunwar proposed openstack/magnum master: Remove fedora-atomic diskimage-builder element  https://review.openstack.org/57469511:14
openstackgerritBharat Kunwar proposed openstack/magnum master: Remove fedora-atomic diskimage-builder element  https://review.openstack.org/57469511:16
openstackgerritBharat Kunwar proposed openstack/magnum master: Remove fedora-atomic diskimage-builder element  https://review.openstack.org/57469511:17
*** pengdake has joined #openstack-containers11:18
brtknrThat was hard work11:18
*** markguz_ has joined #openstack-containers11:19
*** zhubingbing has joined #openstack-containers11:28
openstackgerritBharat Kunwar proposed openstack/magnum master: Add option to specify Cgroup driver for Kubelet  https://review.openstack.org/57158311:31
*** zhubingbing has quit IRC11:33
*** mago_ has quit IRC11:39
*** mago_ has joined #openstack-containers11:43
*** AlexeyAbashkin has joined #openstack-containers11:45
brtknrI don't understand this error: 'Please write more unit tests, we must maintain our test coverage :('11:46
*** Alexey_Abashkin has joined #openstack-containers11:48
*** AlexeyAbashkin has quit IRC11:50
*** Alexey_Abashkin is now known as AlexeyAbashkin11:50
*** AlexeyAbashkin has quit IRC11:52
*** AlexeyAbashkin has joined #openstack-containers11:53
strigazibrtknr: where?11:58
*** markguz_ has quit IRC11:59
*** vijaykc4 has joined #openstack-containers12:00
*** dave-mccowan has joined #openstack-containers12:04
brtknrstrigazi: when i run tox -e cover12:16
*** salmankhan has quit IRC12:21
*** ykarel_ has joined #openstack-containers12:21
*** ykarel has quit IRC12:24
*** ykarel_ is now known as ykarel12:26
*** ktibi_ is now known as ktibi12:29
strigazibrtknr: it says which line is missing UTs12:30
*** salmankhan has joined #openstack-containers12:37
*** kaiokmo has joined #openstack-containers12:43
*** pengdake has quit IRC12:46
*** pengdake has joined #openstack-containers12:46
*** olivenwk has joined #openstack-containers13:00
*** pcaruana has quit IRC13:00
*** AlexeyAbashkin has quit IRC13:24
brtknrstrigazi: magnum/tests/unit/drivers/test_template_definition.py#L639 why is a swarm test muddled with k8s test?13:24
brtknrhttps://github.com/openstack/magnum/blob/master/magnum/tests/unit/drivers/test_template_definition.py#L63913:26
*** pengdake has quit IRC13:26
brtknrAlso https://github.com/openstack/magnum/blob/master/magnum/tests/unit/drivers/test_template_definition.py#L66513:26
brtknrThey're both inside "class AtomicK8sTemplateDefinitionTestCase"13:27
strigazibrtknr: this is not good :(13:27
*** mdnadeem has joined #openstack-containers13:28
*** zhubingbing has joined #openstack-containers13:29
*** AlexeyAbashkin has joined #openstack-containers13:32
*** zhubingbing has quit IRC13:34
*** salmankhan has quit IRC13:36
*** yamamoto has quit IRC13:36
*** yamamoto has joined #openstack-containers13:37
*** salmankhan has joined #openstack-containers13:38
*** vabada has quit IRC13:40
*** vabada has joined #openstack-containers13:40
brtknrstrigazi: looks like swarm_fedora_atomic_v2 doesnt have many tests13:41
brtknrif any13:42
*** pcaruana has joined #openstack-containers13:46
brtknrdo we want to support both swarm and swarm-mode tests?13:46
*** sheel has quit IRC13:47
strigaziswarm-mode is far more important13:47
brtknryes, swarm-mode doesnt seem to have any tests13:51
*** vabada has quit IRC13:53
*** vabada has joined #openstack-containers13:53
strigazibrtknr: it has functional though13:55
*** vijaykc4 has quit IRC14:09
*** vijaykc4 has joined #openstack-containers14:12
brtknrstrigazi: i don't understand... you mean swarm-mode is currently functional without any tests?14:13
strigazibrtknr: No, I mean that magnum has functional tests, but not unit tests. Functional tests are more important but we need UT too14:15
*** zhubingbing has joined #openstack-containers14:16
openstackgerritBharat Kunwar proposed openstack/magnum master: Support disabling floating IPs in swarm mode  https://review.openstack.org/57120014:25
brtknrI have made a start on some unit tests14:27
brtknrI am not entirely clear on what these outputs mean:14:29
brtknrName                                                                                                   Stmts   Miss Branch BrPart  Cover14:29
brtknr@@ -204 +204 @@14:29
brtknr-magnum/drivers/heat/swarm_mode_template_def.py                                                            61     14     14      7    64%14:29
brtknr+magnum/drivers/heat/swarm_mode_template_def.py                                                            77     36     14      0    45%14:29
brtknr@@ -254 +254 @@14:29
brtknr-TOTAL                                                                                                   7703    676   1264    103    90%14:29
brtknr+TOTAL                                                                                                   7719    698   1264     96    90%y14:29
strigaziyou have (36 - 14) lines without UTs in -magnum/drivers/heat/swarm_mode_template_def.py14:30
strigazi22 lines14:30
*** ramishra has quit IRC14:32
*** dave-mccowan has quit IRC14:35
brtknrhow are the lines calculated? is it one test per function/class14:36
strigaziit using "coverage"14:37
strigaziin magnum/cover you have the report in html14:37
strigaziyou can see which lines are not covered14:37
*** hongbin has joined #openstack-containers14:43
*** gsimondon has quit IRC14:49
*** serlex has quit IRC14:49
*** mdnadeem has quit IRC14:49
*** olivenwk has quit IRC14:52
*** mordred has quit IRC14:55
*** jmlowe has joined #openstack-containers14:57
*** markguz_ has joined #openstack-containers15:00
*** mjura has quit IRC15:02
*** dave-mccowan has joined #openstack-containers15:03
*** markguz_ has quit IRC15:05
*** mordred has joined #openstack-containers15:09
*** dardelean_ has quit IRC15:15
*** dardelean_ has joined #openstack-containers15:16
*** dardelean_ has quit IRC15:21
*** ykarel is now known as ykarel|away15:22
*** vabada has quit IRC15:39
*** yamamoto has quit IRC15:39
*** yamamoto has joined #openstack-containers15:40
*** yamamoto has quit IRC15:45
brtknrthat is very useful, thanks15:46
*** mordred has quit IRC15:48
*** ktibi has quit IRC15:50
*** mordred has joined #openstack-containers15:52
*** gsimondon has joined #openstack-containers15:52
*** dardelean_ has joined #openstack-containers15:53
*** zhubingbing has quit IRC15:54
*** zhubingbing has joined #openstack-containers15:54
*** zhubingbing has quit IRC15:55
*** zhubingbing has joined #openstack-containers15:55
*** zhubingbing has quit IRC15:56
*** zhubingbing has joined #openstack-containers15:56
*** zhubingbing has quit IRC15:56
*** AlexeyAbashkin has quit IRC15:57
openstackgerritBharat Kunwar proposed openstack/magnum master: Support disabling floating IPs in swarm mode  https://review.openstack.org/57120015:57
*** zhubingbing has joined #openstack-containers15:57
brtknrstrigazi: could you have a look at the tests and point me towards why its failing?15:57
*** zhubingbing has quit IRC15:57
strigazibrtknr: UT?15:57
*** zhubingbing has joined #openstack-containers15:58
*** dardelean_ has quit IRC15:58
brtknryes15:58
brtknrhttp://paste.openstack.org/show/723324/15:58
*** zhubingbing has quit IRC15:58
*** zhubingbing has joined #openstack-containers15:58
brtknrI have uploaded the most recent version for review15:58
*** zhubingbing has quit IRC15:59
*** AlexeyAbashkin has joined #openstack-containers16:01
*** mkrai has quit IRC16:08
strigazibrtknr: I couldn't spot it immediately, I'll have a closer look tmr, I have to go, thanks for going through the UTs16:09
brtknrstrigazi: thanks, enjoy your evening16:09
strigazibrtknr: thanks, see you16:10
*** jmlowe has quit IRC16:13
*** ykarel_ has joined #openstack-containers16:22
*** dave-mccowan has quit IRC16:23
*** ykarel|away has quit IRC16:24
*** salmankhan has quit IRC16:33
*** Alexey_Abashkin has joined #openstack-containers16:33
*** Alexey_Abashkin has quit IRC16:35
*** AlexeyAbashkin has quit IRC16:35
*** salmankhan has joined #openstack-containers16:35
*** vijaykc4 has quit IRC16:36
*** mkrai has joined #openstack-containers16:36
*** salmankhan has quit IRC16:42
*** yamamoto has joined #openstack-containers16:42
*** salmankhan has joined #openstack-containers16:46
*** yamamoto has quit IRC16:49
*** salmankhan has quit IRC16:53
*** udesale has quit IRC16:55
*** salmankhan has joined #openstack-containers16:56
*** ykarel_ is now known as ykarel|away16:56
*** flwang1 has quit IRC16:59
*** gsimondon has quit IRC17:04
*** ykarel|away has quit IRC17:05
*** flwang1 has joined #openstack-containers17:06
*** chhagarw has quit IRC17:30
*** vijaykc4 has joined #openstack-containers17:36
*** salmankhan has quit IRC17:38
*** janki has quit IRC17:43
*** gsimondon has joined #openstack-containers17:51
*** dave-mccowan has joined #openstack-containers18:30
*** dave-mccowan has quit IRC18:47
*** yamamoto has joined #openstack-containers18:47
*** vijaykc4 has quit IRC19:12
*** vijaykc4 has joined #openstack-containers19:13
*** flwang1 has quit IRC19:25
*** salmankhan has joined #openstack-containers19:30
*** salmankhan has quit IRC19:34
*** vijaykc4 has quit IRC19:40
*** vijaykc4 has joined #openstack-containers19:49
*** dave-mccowan has joined #openstack-containers20:01
*** zhubingbing has joined #openstack-containers20:01
*** AlexeyAbashkin has joined #openstack-containers20:05
*** zhubingbing has quit IRC20:06
*** Alexey_Abashkin has joined #openstack-containers20:08
*** AlexeyAbashkin has quit IRC20:09
*** Alexey_Abashkin is now known as AlexeyAbashkin20:09
*** dave-mccowan has quit IRC20:10
*** Alexey_Abashkin has joined #openstack-containers20:15
*** dardelean_ has joined #openstack-containers20:16
*** AlexeyAbashkin has quit IRC20:16
*** Alexey_Abashkin is now known as AlexeyAbashkin20:16
*** dardelean_ has quit IRC20:19
*** dardelea_ has joined #openstack-containers20:19
*** yamamoto has quit IRC20:23
*** dardelea_ has quit IRC20:28
*** dardelean_ has joined #openstack-containers20:29
*** vijaykc4 has quit IRC20:29
*** gsimondon has quit IRC20:31
*** dardelean_ has quit IRC20:33
*** markguz_ has joined #openstack-containers20:41
*** markguz_ has quit IRC20:45
*** mkrai has quit IRC20:49
*** markguz_ has joined #openstack-containers20:52
*** AlexeyAbashkin has quit IRC20:52
*** linkmark has joined #openstack-containers20:58
*** pcaruana has quit IRC21:04
*** flwang1 has joined #openstack-containers21:07
*** mkrai has joined #openstack-containers21:10
*** yamamoto has joined #openstack-containers21:24
*** yamamoto has quit IRC21:39
*** dtruong has quit IRC21:41
*** dtruong has joined #openstack-containers21:47
*** dave-mccowan has joined #openstack-containers22:00
*** zhubingbing has joined #openstack-containers22:03
*** zhubingbing has quit IRC22:07
*** vijaykc4 has joined #openstack-containers22:08
*** vijaykc4 has quit IRC22:23
*** dardelean_ has joined #openstack-containers22:28
*** IAMB3NW has quit IRC22:42
*** rcernin has joined #openstack-containers22:44
*** jmlowe has joined #openstack-containers22:55
*** markguz_ has quit IRC23:04
*** markguz_ has joined #openstack-containers23:05
*** hongbin has quit IRC23:15
*** mkrai has quit IRC23:15
*** jmlowe has quit IRC23:17
*** jmlowe has joined #openstack-containers23:18
*** markguz_ has quit IRC23:23
*** jmlowe has quit IRC23:31
*** jmlowe has joined #openstack-containers23:35
*** threestrands has joined #openstack-containers23:36
*** mkrai has joined #openstack-containers23:36
*** dardelean_ has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!