Wednesday, 2017-02-08

*** sdake_ is now known as sdake00:10
*** huzhengchuan has joined #openstack-containers00:10
*** hongbin has quit IRC00:24
*** Drago1 has quit IRC00:24
*** adrian_otto has joined #openstack-containers00:38
*** tovin07 has joined #openstack-containers00:49
*** tonanhngo has quit IRC00:57
*** vijendar1 has joined #openstack-containers00:57
*** vijendar1 has quit IRC00:57
*** mtanino has quit IRC01:00
*** code34 has quit IRC01:04
*** zz_dimtruck is now known as dimtruck01:12
*** dsariel has quit IRC01:15
*** tonanhngo has joined #openstack-containers01:17
*** kevinz has joined #openstack-containers01:20
openstackgerritAdrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance  https://review.openstack.org/43007101:21
*** tonanhngo has quit IRC01:22
openstackgerritAdrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance  https://review.openstack.org/43007101:23
*** sdake has quit IRC01:24
ianychoiadrian_otto, hello. Just a reminder for creating stable/ocata branch for magnum-ui => Would be there other things rather than the last review (string bug change) which block the stable branch creation in magnum-ui?01:25
adrian_ottowill do, thanks ianychoi01:26
adrian_ottothat's the only thing, and it's minot, so not a blocker01:26
adrian_ottos/minot/minor/01:26
ianychoiadrian_otto, I see. Just one thing I commented was that patching po files directly in the repo is not a good idea01:27
ianychoiAfter seeing the patch later, I updated all the translated strings in Zanata - translation platform01:27
ianychoiadrian_otto, to summarize: https://review.openstack.org/#/c/429058/ patched *.po files directly in the repo -> https://review.openstack.org/#/c/429352/ overwrote the result from Zanata -> I updated translated strings in Zanata -> translated strings were finally landed to magnum-ui by https://review.openstack.org/#/c/429513/01:30
*** yamamoto has quit IRC01:34
openstackgerritAdrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance  https://review.openstack.org/43007101:35
*** yamamoto has joined #openstack-containers01:38
openstackgerritAdrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance  https://review.openstack.org/43007101:42
*** yamamoto has quit IRC01:43
adrian_ottoianychoi: okay, so does that mean we should merge all three?01:50
adrian_ottoall three have merged.01:51
adrian_ottoso it's time to branch.01:51
*** vijendar1 has joined #openstack-containers01:56
*** vijendar2 has joined #openstack-containers01:58
*** vijendar1 has quit IRC01:59
*** adisky_ has quit IRC01:59
*** vijendar2 has quit IRC02:00
*** vijendar has joined #openstack-containers02:00
*** vijendar1 has joined #openstack-containers02:02
*** vijendar has quit IRC02:02
*** adrian_otto has quit IRC02:04
*** Syed__ has quit IRC02:15
*** vijendar2 has joined #openstack-containers02:24
*** vijendar1 has quit IRC02:24
*** adrian_otto has joined #openstack-containers02:27
*** vijendar2 has quit IRC02:29
*** sacharya_ has joined #openstack-containers02:34
*** sacharya has quit IRC02:36
*** fragatin_ has joined #openstack-containers02:37
*** sdake has joined #openstack-containers02:39
*** fragatina has quit IRC02:40
*** yamamoto has joined #openstack-containers02:40
*** yamamoto has quit IRC03:01
*** sdake has quit IRC03:01
*** sdake has joined #openstack-containers03:02
openstackgerritCao Xuan Hoang proposed openstack/magnum master: Remove support for py34  https://review.openstack.org/43052203:04
*** mtanino has joined #openstack-containers03:07
*** crazymozart has joined #openstack-containers03:10
*** fragatin_ has quit IRC03:21
*** mtanino has quit IRC03:22
*** fragatina has joined #openstack-containers03:24
*** fragatina has quit IRC03:24
*** fragatina has joined #openstack-containers03:25
*** vimal has joined #openstack-containers03:33
*** fragatin_ has joined #openstack-containers03:33
crazymozartcould anybody tell me why "container" is removed from UI?03:36
*** fragatina has quit IRC03:37
*** fragatin_ has quit IRC03:37
*** adisky_ has joined #openstack-containers03:39
ianychoiadrian_otto, what I meant is that in your patch: https://review.openstack.org/#/c/429058/ => I suggest not to directly update *.po files in the patches, since later "Import from Zanata" will override *.po files stored in translation platform.03:44
adrian_ottoianychoi: Ok, noted. Thanks.03:45
ianychoiadrian_otto, yep since all three have merged it would be nice if magnum-ui will have stable/ocata branch. Thanks!03:45
*** hongbin has joined #openstack-containers03:51
*** sdake_ has joined #openstack-containers03:54
*** ricolin has joined #openstack-containers03:55
*** sdake has quit IRC03:57
*** mdnadeem has joined #openstack-containers04:00
*** vimal has quit IRC04:01
*** fragatina has joined #openstack-containers04:09
*** fragatina has quit IRC04:12
*** fragatina has joined #openstack-containers04:12
*** fragatina has quit IRC04:13
*** fragatina has joined #openstack-containers04:13
*** askb has quit IRC04:24
*** vimal has joined #openstack-containers04:25
*** dimtruck is now known as zz_dimtruck04:26
*** hongbin has quit IRC04:27
*** faizy has joined #openstack-containers04:30
*** askb has joined #openstack-containers04:30
*** huzhengchuan has quit IRC04:39
openstackgerritMerged openstack/magnum master: Trivial: Fix typo in exception message  https://review.openstack.org/42721404:40
*** sacharya has joined #openstack-containers04:43
*** sacharya_ has quit IRC04:43
*** huzhengchuan has joined #openstack-containers04:52
*** sacharya_ has joined #openstack-containers04:56
*** sacharya has quit IRC04:57
*** chhavi has joined #openstack-containers04:58
*** janki has joined #openstack-containers05:12
*** zz_dimtruck is now known as dimtruck05:17
*** tonanhngo has joined #openstack-containers05:25
*** vijendar has joined #openstack-containers05:26
*** vijendar has quit IRC05:27
*** vijendar has joined #openstack-containers05:27
*** vijendar1 has joined #openstack-containers05:29
*** vijendar has quit IRC05:29
*** dimtruck is now known as zz_dimtruck05:29
*** vijendar has joined #openstack-containers05:31
*** vijendar1 has quit IRC05:31
*** vijendar has quit IRC05:32
*** vijendar has joined #openstack-containers05:32
*** huzhengchuan has quit IRC05:34
*** PanFengyun has quit IRC05:34
*** huzhengchuan has joined #openstack-containers05:35
*** zenirc369 has joined #openstack-containers05:36
*** vijendar has quit IRC05:42
*** sacharya_ has quit IRC05:43
*** zenirc369 has quit IRC05:44
*** PanFengyun has joined #openstack-containers05:47
*** zenirc369 has joined #openstack-containers05:56
*** yolanda_ has quit IRC06:02
*** yolanda_ has joined #openstack-containers06:02
*** adrian_otto has quit IRC06:13
*** zz_dimtruck is now known as dimtruck06:20
*** sdake_ is now known as sdake06:27
*** dimtruck is now known as zz_dimtruck06:30
*** huzhengchuan has quit IRC06:34
*** adrian_otto has joined #openstack-containers06:43
*** huzhengchuan has joined #openstack-containers06:48
*** rcernin has joined #openstack-containers06:59
*** hishh has joined #openstack-containers07:10
*** zz_dimtruck is now known as dimtruck07:21
*** sdake_ has joined #openstack-containers07:23
*** tonanhngo has quit IRC07:25
*** sdake has quit IRC07:26
*** pcaruana has joined #openstack-containers07:29
*** dimtruck is now known as zz_dimtruck07:32
*** adrian_otto has quit IRC07:33
*** crazymozart has quit IRC07:36
*** david-lyle_ has joined #openstack-containers07:37
*** yamamoto has joined #openstack-containers07:56
*** yamamoto has quit IRC07:56
*** PanFengyun has quit IRC08:00
*** vijaykc4 has joined #openstack-containers08:02
*** tonanhngo has joined #openstack-containers08:03
*** mloncan has joined #openstack-containers08:04
*** tonanhngo has quit IRC08:04
*** sdake_ is now known as dake08:05
*** pcastets has joined #openstack-containers08:08
*** sdake has joined #openstack-containers08:14
*** dake has quit IRC08:17
*** yamamoto has joined #openstack-containers08:20
*** zz_dimtruck is now known as dimtruck08:23
*** dsariel has joined #openstack-containers08:26
*** yamamoto has quit IRC08:26
*** david-lyle_ has quit IRC08:28
*** mjura has joined #openstack-containers08:28
*** dimtruck is now known as zz_dimtruck08:33
*** vijaykc4 has quit IRC08:36
*** vijaykc4 has joined #openstack-containers08:36
*** vijaykc4 has quit IRC08:37
*** vijaykc4 has joined #openstack-containers08:37
*** vijaykc4 has quit IRC08:38
*** vijaykc4 has joined #openstack-containers08:38
*** vijaykc4 has quit IRC08:38
*** vijaykc4 has joined #openstack-containers08:39
*** huzhengchuan has quit IRC08:39
*** vijaykc4 has quit IRC08:39
*** vijaykc4 has joined #openstack-containers08:40
*** vijaykc4 has quit IRC08:40
*** vijaykc4 has joined #openstack-containers08:40
*** vijaykc4 has quit IRC08:41
openstackgerritMichal Jura proposed openstack/magnum master: Add WSGI script to deploy Magnum behind Apache  https://review.openstack.org/42772308:42
*** prameswar has joined #openstack-containers08:44
*** dsariel has quit IRC08:45
ArchiFleKsstrigazi: Hello, I'm having trouble testing swarm_v2, I copy the folder an change os_distro, but template is not listed in magnum-driver-manage, documentation here seems out of date http://docs.openstack.org/developer/magnum/dev/cluster-type-definition.html08:49
*** huzhengchuan has joined #openstack-containers08:52
*** hishh has quit IRC09:00
strigaziArchiFleKs, you need to add the entrypoint too like https://github.com/strigazi/magnum/blob/swarm_fedora_atomic_v2_inplace/setup.cfg#L6509:11
*** vijaykc4 has joined #openstack-containers09:18
*** zenirc369 has quit IRC09:24
*** zz_dimtruck is now known as dimtruck09:24
*** ricolin has quit IRC09:24
*** fragatina has quit IRC09:30
*** fragatina has joined #openstack-containers09:30
*** hishh has joined #openstack-containers09:31
openstackgerritMichal Jura proposed openstack/magnum master: [suse] Add custom etcd service configuration based on static IPs  https://review.openstack.org/41186209:31
*** openstackgerrit has quit IRC09:34
*** dimtruck is now known as zz_dimtruck09:34
*** swatson__ has joined #openstack-containers09:36
*** zenirc369 has joined #openstack-containers09:38
*** ricolin has joined #openstack-containers09:38
*** crazymozart has joined #openstack-containers09:39
*** chhavi has quit IRC09:42
*** lbragstad_ has joined #openstack-containers09:43
*** dims_ has joined #openstack-containers09:44
*** sahilsinha_ has joined #openstack-containers09:44
*** filler_ has joined #openstack-containers09:44
*** crazymozart has quit IRC09:45
*** chriscaudre has quit IRC09:45
*** huzhengchuan has quit IRC09:45
*** askb has quit IRC09:45
*** swatson_ has quit IRC09:45
*** yasemin has quit IRC09:45
*** dims has quit IRC09:45
*** filler has quit IRC09:45
*** sahilsinha has quit IRC09:45
*** lbragstad has quit IRC09:45
*** filler_ is now known as filler09:45
*** openstackgerrit has joined #openstack-containers09:48
openstackgerritMichal Jura proposed openstack/magnum master: [suse] Remove defaults network from child templates  https://review.openstack.org/41186609:48
openstackgerritMichal Jura proposed openstack/magnum master: [suse] Add custom etcd service configuration based on static IPs  https://review.openstack.org/41186209:48
openstackgerritMichal Jura proposed openstack/magnum master: [suse] Add SERVICE_ACCOUNT_KEY to Kuberneres cluster configuration  https://review.openstack.org/41186309:48
*** vijendar has joined #openstack-containers09:49
*** vijaykc4 has quit IRC09:50
*** vijaykc4 has joined #openstack-containers09:51
*** huzhengchuan has joined #openstack-containers09:51
*** askb has joined #openstack-containers09:52
*** yasemin has joined #openstack-containers09:52
*** vijendar has quit IRC09:53
*** swatson__ has quit IRC09:54
openstackgerritMichal Jura proposed openstack/magnum master: [suse] Add custom docker REGISTRY_URL option  https://review.openstack.org/41186709:56
*** salmankhan has joined #openstack-containers10:00
*** crazymozart has joined #openstack-containers10:00
*** danil has joined #openstack-containers10:03
openstackgerritMichal Jura proposed openstack/magnum master: [suse] Build openSUSE Leap 42.1 OpenStack Magnum image  https://review.openstack.org/39774310:15
*** yamamoto has joined #openstack-containers10:17
openstackgerritMichal Jura proposed openstack/magnum master: [suse] Build openSUSE Leap 42.1 OpenStack Magnum image  https://review.openstack.org/39774310:17
*** kevinz has quit IRC10:17
ArchiFleKsstrigazi: OK thanks i'll test it today ;)10:22
*** yamamoto has quit IRC10:22
*** zz_dimtruck is now known as dimtruck10:25
*** dimtruck is now known as zz_dimtruck10:34
*** vijaykc4 has quit IRC10:36
openstackgerritKevin Lefevre proposed openstack/magnum master: Make request insecure when talking to endpoints  https://review.openstack.org/43075510:45
*** salmankhan has quit IRC10:45
*** salmankhan has joined #openstack-containers10:45
*** hishh1 has joined #openstack-containers10:47
*** hishh has quit IRC10:49
*** hishh1 is now known as hishh10:49
*** dsariel has joined #openstack-containers10:59
*** sdake has quit IRC11:11
*** sdake has joined #openstack-containers11:11
*** vijaykc4 has joined #openstack-containers11:15
*** yamamoto has joined #openstack-containers11:20
*** vijaykc4 has quit IRC11:22
*** vijaykc4 has joined #openstack-containers11:22
*** yamamoto has quit IRC11:26
*** sdake has quit IRC11:43
*** ricolin has quit IRC11:54
*** chhavi has joined #openstack-containers11:54
*** huzhengchuan has quit IRC12:02
*** dave-mccowan has joined #openstack-containers12:08
*** huzhengchuan has joined #openstack-containers12:14
*** faizy has quit IRC12:16
*** hishh has quit IRC12:18
openstackgerritSpyros Trigazis proposed openstack/magnum stable/newton: Fix gate: caused by tempest(removal of "service" param)  https://review.openstack.org/42763012:19
*** huzhengchuan has quit IRC12:25
*** zz_dimtruck is now known as dimtruck12:26
*** salmankhan has quit IRC12:28
*** salmankhan has joined #openstack-containers12:28
*** lilia_ has quit IRC12:30
*** lilia has joined #openstack-containers12:30
*** yamamoto has joined #openstack-containers12:35
*** dimtruck is now known as zz_dimtruck12:36
*** huzhengchuan has joined #openstack-containers12:37
*** chhavi has quit IRC12:44
*** yamamoto has quit IRC12:48
*** huzhengchuan has quit IRC12:51
*** jmckind has joined #openstack-containers12:57
*** askb has quit IRC12:58
*** hishh has joined #openstack-containers12:59
*** yatin_on_leave has quit IRC13:00
*** vimal has quit IRC13:04
*** zenirc369 has quit IRC13:07
*** catintheroof has joined #openstack-containers13:08
*** yatin_on_leave has joined #openstack-containers13:12
*** OGtrilliams has joined #openstack-containers13:19
*** lbragstad_ is now known as lbragstad13:29
*** ricolin has joined #openstack-containers13:36
*** sdake has joined #openstack-containers13:36
*** janki has quit IRC13:38
*** robcresswell has joined #openstack-containers13:39
robcresswellHey magnum/ magnum-ui devs can we get a response on https://review.openstack.org/#/c/429753/ please? There have been several emails but nobody from the Magnum team has responded as far as I can tell.13:39
strigazirobcresswell which reqs must be removed?13:41
strigazithese https://github.com/openstack/magnum-ui/blob/master/requirements.txt#L18-L39 ?13:41
*** AlexeyAbashkin has joined #openstack-containers13:42
*** AlexeyAbashkin has quit IRC13:42
strigazirobcresswell ^^13:42
strigaziIn your mail you said all xstatic packages13:42
robcresswellstrigazi: Yeah; I dont believe you need any of those13:45
robcresswellin your requirements13:45
*** OGtrilliams has quit IRC13:45
robcresswellor any of django requirements either13:45
*** janki has joined #openstack-containers13:46
robcresswellThey should all be there because of Horizon anyway13:46
*** kevinz has joined #openstack-containers13:47
*** chhavi has joined #openstack-containers13:49
*** yamamoto has joined #openstack-containers13:49
*** faizy has joined #openstack-containers13:52
*** yamamoto has quit IRC13:55
*** OGtrilliams has joined #openstack-containers13:58
*** kevinz has quit IRC14:04
*** kevinz has joined #openstack-containers14:05
strigazirobcresswell https://review.openstack.org/430941 Remove Xstatic packages from requirements14:08
robcresswellstrigazi: Could you comment on the review further up please? We need infra to unblock that patch. Its important.14:09
strigaziI was doing so14:10
strigazi:)14:10
robcresswellOr rather, we need whoever is PTL to comment. I dont know who that is atm14:10
robcresswellstrigazi: Thanks :)14:10
*** AlexeyAbashkin has joined #openstack-containers14:13
*** kevinz has quit IRC14:18
*** mdnadeem has quit IRC14:19
*** mjura has quit IRC14:22
*** salmankhan has quit IRC14:23
*** m1dev has joined #openstack-containers14:27
*** zz_dimtruck is now known as dimtruck14:28
*** vijaykc4 has quit IRC14:31
*** mjura has joined #openstack-containers14:34
*** salmankhan has joined #openstack-containers14:37
*** dimtruck is now known as zz_dimtruck14:37
*** vijendar1 has joined #openstack-containers14:40
strigazirobcresswell I'll ping our PTL14:48
strigazidone14:50
*** chris_hultin|AWA is now known as chris_hultin14:55
*** mtanino has joined #openstack-containers14:58
*** chhavi has quit IRC14:58
*** vijendar2 has joined #openstack-containers15:00
*** vijendar1 has quit IRC15:01
*** tonanhngo has joined #openstack-containers15:01
*** vijendar1 has joined #openstack-containers15:02
*** vijendar2 has quit IRC15:02
*** tonanhngo has quit IRC15:02
*** AlexeyAbashkin has quit IRC15:05
*** zz_dimtruck is now known as dimtruck15:05
*** adrian_otto1 has joined #openstack-containers15:05
*** vijendar1 has quit IRC15:07
*** jasond has joined #openstack-containers15:08
*** vijendar1 has joined #openstack-containers15:16
adrian_otto1strigazi: I have a question about https://review.openstack.org/43094115:19
strigazishoot15:19
adrian_otto1are we sure that we don't need those libraries? I have not yet tested to see if everything works without them, so I'm reluctant to vote on it.15:19
*** sacharya has joined #openstack-containers15:20
*** dave-mccowan has quit IRC15:20
*** adrian_otto1 is now known as adrian_otto15:21
adrian_ottoI am willing to merge it if we have at least two people verify that it does not cause a regression. I'm not convinced that we have automated testing that would catch such a regression.15:21
adrian_ottoon that software at least.15:21
strigaziAll these libraries are reuquired by horizon15:22
strigaziand magnum-ui requires horizon, I'm having one more close look15:22
strigaziI'll get back to you in 10'15:23
adrian_ottook, thx15:23
*** hongbin has joined #openstack-containers15:26
*** fragatina has quit IRC15:30
strigaziadrian_otto all xstatic reqs in magnum-ui are in the horizon (exact same version) apart from XStatic-Magic-Search which is taken into horizon. Since magnum-ui is a horizon plugin and they can't live apart, all xstatic magnum-ui reqs will be there. I'm checking again for XStatic-Magic-Search15:30
*** fragatina has joined #openstack-containers15:30
*** EricGonczer_ has joined #openstack-containers15:30
adrian_ottostrigazi: acknowledged15:31
*** huzhengchuan has joined #openstack-containers15:31
*** vijendar1 has quit IRC15:32
*** EricGonc_ has joined #openstack-containers15:34
strigaziIn the last mail by Richard Jones  it's mentioned that  xstatic-magic-search is imported into horizon, shouldn't be a problem15:34
strigaziadrian_otto http://lists.openstack.org/pipermail/openstack-dev/2017-February/111770.html15:35
*** EricGonczer_ has quit IRC15:35
adrian_ottoyes, I saw that last night.15:37
strigaziI think it's safe, the dependencies are the same15:38
*** dave-mccowan has joined #openstack-containers15:38
adrian_ottook15:38
*** vijendar has joined #openstack-containers15:43
*** danil has quit IRC15:45
*** mjura has quit IRC15:46
*** janki has quit IRC15:49
*** mjura has joined #openstack-containers15:50
adrian_ottostrigazi: I replied to the ML thread approving the FFE, and voted to merge the two related patches.15:54
robcresswellthanks for the mailer response adrian_otto15:55
strigaziadrian_otto, thanks. Maybe approve the magnum-ui chnage too?15:55
*** huzhengchuan has quit IRC15:56
adrian_ottostrigazi: can you help me understand the urgency?15:56
adrian_ottoI think I'm missing some of the context of what the release team is doing at this moment15:57
*** adrian_otto has quit IRC15:57
strigaziadrian_otto, In our side is not super urgent since we approved the openstack/requirements change. The problem may arise when packagers will try to package magnum-ui. We can wait for shu-muto to approve as well16:00
*** EricGonc_ has quit IRC16:00
*** vijaykc4 has joined #openstack-containers16:01
*** Drago1 has joined #openstack-containers16:03
*** vijaykc4 has quit IRC16:03
*** Syed__ has joined #openstack-containers16:04
*** zenirc369 has joined #openstack-containers16:05
*** vijendar has quit IRC16:09
*** adrian_otto has joined #openstack-containers16:15
*** vijendar has joined #openstack-containers16:16
strigaziadrian_otto, About these changes https://review.openstack.org/#/q/4c0850731d40c7d42ec1a9e18c43a3614b931558,n,z I think we need to revert and make something it opt-in (or not even that). We should do secure requests by default IMO16:19
strigaziadrian_otto, About these changes https://review.openstack.org/#/q/4c0850731d40c7d42ec1a9e18c43a3614b931558,n,z I think we need to revert and make them opt-in (or not even that). We should do secure requests by default IMO16:19
adrian_ottoyes, I prefer secure by default as the guiding principle16:20
adrian_ottoI expect these were proposed for a reason, but I did not review them, so I'm not sure what that was. Has that reason been eliminated?16:21
strigaziIt's about the requests that the cluster nodes do to magnum. The reason is: "A lot of deployments use self signed certs"16:21
strigazi"Curl breaks in those cases trying to validate certs against known set of CAs"16:22
strigaziThat's the commit message, there is no bug16:22
adrian_ottowe could use letsencrypt certs by default16:22
*** dimtruck is now known as zz_dimtruck16:23
strigaziIt's per deployment I think. eg we have signed certs by some known CA16:24
adrian_ottoor we could still use self signed certificates, and turn off certificate validation in our curl requests16:24
adrian_ottothat's still better than using raw HTTP16:24
*** zz_dimtruck is now known as dimtruck16:24
adrian_ottoin fact, we could have an optional configuration option to disable cert checks in curl requests, and disable that option by default16:25
*** dsariel has quit IRC16:27
*** fragatina has quit IRC16:29
*** fragatina has joined #openstack-containers16:30
*** vijaykc4 has joined #openstack-containers16:31
*** salmankhan has quit IRC16:35
*** dimtruck is now known as zz_dimtruck16:35
*** sdake_ has joined #openstack-containers16:36
*** salmankhan has joined #openstack-containers16:37
*** sdake has quit IRC16:38
strigaziI agree with that ^^16:38
*** rcernin has quit IRC16:39
*** vijaykc4 has quit IRC16:45
*** mjura has quit IRC16:47
*** salmankhan has quit IRC16:49
*** vijaykc4 has joined #openstack-containers16:49
*** ricolin has quit IRC16:50
*** prameswar has quit IRC16:50
*** sacharya has quit IRC16:54
*** sacharya has joined #openstack-containers16:54
*** tonanhngo has joined #openstack-containers16:56
*** tonanhngo has quit IRC16:56
*** EricGonczer_ has joined #openstack-containers16:59
openstackgerritMerged openstack/magnum-ui master: Remove Xstatic packages from requirements  https://review.openstack.org/43094116:59
*** zz_dimtruck is now known as dimtruck17:07
*** hishh has quit IRC17:10
*** chhavi has joined #openstack-containers17:10
*** salmankhan has joined #openstack-containers17:16
*** salmankhan has quit IRC17:23
openstackgerritJason Dunsmore proposed openstack/magnum master: Allow deletion of clusters with unsupported driver  https://review.openstack.org/42843717:23
*** chhavi has quit IRC17:26
*** vijaykc4 has quit IRC17:27
*** EricGonczer_ has quit IRC17:28
*** vijaykc4 has joined #openstack-containers17:30
*** adrian_otto1 has joined #openstack-containers17:39
*** adrian_otto has quit IRC17:42
*** swatson has joined #openstack-containers17:44
*** salmankhan has joined #openstack-containers17:50
*** adrian_otto1 has quit IRC17:51
*** adrian_otto has joined #openstack-containers17:53
*** zenirc369 has quit IRC18:02
*** vijendar has quit IRC18:17
*** EricGonczer_ has joined #openstack-containers18:26
*** jberkus has joined #openstack-containers18:26
*** robcresswell has quit IRC18:35
*** amit213 has quit IRC18:35
*** nikhil has quit IRC18:35
*** janonymous has quit IRC18:35
*** vijendar has joined #openstack-containers18:42
*** serverascode has quit IRC18:45
*** etoews has quit IRC18:45
*** hogepodge has quit IRC18:45
*** tonanhngo has joined #openstack-containers18:45
*** tonanhngo has quit IRC18:47
*** tonanhngo has joined #openstack-containers18:48
*** vijendar has quit IRC18:58
*** vijendar has joined #openstack-containers18:58
*** vijendar1 has joined #openstack-containers19:00
*** vijendar has quit IRC19:00
*** vijendar has joined #openstack-containers19:01
*** vijendar1 has quit IRC19:01
*** vijendar1 has joined #openstack-containers19:02
*** vijendar has quit IRC19:02
*** Drago1 has quit IRC19:07
*** faizy has quit IRC19:08
*** jasond has quit IRC19:18
*** vijendar1 has quit IRC19:18
*** jasond has joined #openstack-containers19:18
*** vijendar1 has joined #openstack-containers19:18
*** vijendar1 has quit IRC19:22
*** vijendar has joined #openstack-containers19:23
*** etoews has joined #openstack-containers19:26
*** jasond has quit IRC19:27
*** jasond has joined #openstack-containers19:27
*** salmankhan has quit IRC19:27
*** dimtruck is now known as zz_dimtruck19:30
*** serverascode has joined #openstack-containers19:31
*** vijaykc4 has quit IRC19:33
openstackgerritVijendar Komalla proposed openstack/python-magnumclient master: Add magnum client support for resource quotas  https://review.openstack.org/42698119:36
*** fragatina has quit IRC19:37
*** fragatina has joined #openstack-containers19:37
*** code34 has joined #openstack-containers19:38
*** juggler has joined #openstack-containers19:39
openstackgerritVijendar Komalla proposed openstack/python-magnumclient master: Add magnum client support for resource quotas  https://review.openstack.org/42698119:43
*** EricGonczer_ has quit IRC19:44
*** EricGonczer_ has joined #openstack-containers19:45
*** salmankhan has joined #openstack-containers19:47
*** sacharya has quit IRC19:47
*** sacharya has joined #openstack-containers19:48
*** tonanhngo has quit IRC19:54
*** robcresswell has joined #openstack-containers19:55
openstackgerritVijendar Komalla proposed openstack/python-magnumclient master: Add magnum client support for resource quotas  https://review.openstack.org/42698119:55
*** sacharya_ has joined #openstack-containers19:56
*** sacharya has quit IRC19:57
*** nikhil has joined #openstack-containers20:03
*** tonanhngo has joined #openstack-containers20:08
*** salmankhan1 has joined #openstack-containers20:09
*** vijendar has quit IRC20:09
*** salmankhan has quit IRC20:09
*** salmankhan1 is now known as salmankhan20:09
*** vijendar has joined #openstack-containers20:10
*** amit213 has joined #openstack-containers20:11
*** janonymous has joined #openstack-containers20:14
*** hogepodge has joined #openstack-containers20:19
*** salmankhan has quit IRC20:20
*** fragatina has quit IRC20:27
*** vijendar has quit IRC20:29
*** vijendar1 has joined #openstack-containers20:29
*** salmankhan has joined #openstack-containers20:34
*** vijendar1 has quit IRC20:34
*** salmankhan has quit IRC20:38
*** pcaruana has quit IRC20:43
*** vijendar1 has joined #openstack-containers20:48
*** sdake has joined #openstack-containers20:54
openstackgerritVijendar Komalla proposed openstack/magnum master: Add micro version and release notes for quotas API  https://review.openstack.org/43116020:55
*** EricGonczer_ has quit IRC20:57
*** sdake_ has quit IRC20:58
*** EricGonczer_ has joined #openstack-containers21:00
*** sacharya_ has quit IRC21:05
*** sacharya has joined #openstack-containers21:06
*** Drago1 has joined #openstack-containers21:06
*** vijendar1 has quit IRC21:10
*** askb has joined #openstack-containers21:15
*** zz_dimtruck is now known as dimtruck21:18
*** dave-mccowan has quit IRC21:26
*** sacharya_ has joined #openstack-containers21:29
*** adrian_otto has quit IRC21:29
*** sacharya has quit IRC21:29
*** vijendar1 has joined #openstack-containers21:32
*** Jeffrey4l has quit IRC21:34
*** Jeffrey4l has joined #openstack-containers21:34
*** dave-mccowan has joined #openstack-containers21:46
*** adrian_otto has joined #openstack-containers21:48
openstackgerritOpenStack Proposal Bot proposed openstack/magnum-ui master: Imported Translations from Zanata  https://review.openstack.org/43007322:01
*** sdake has quit IRC22:02
*** vijendar1 has quit IRC22:02
openstackgerritVijendar Komalla proposed openstack/magnum master: Add micro version and release notes for quotas API  https://review.openstack.org/43116022:02
*** sdake has joined #openstack-containers22:02
*** jmckind has quit IRC22:03
*** vijendar has joined #openstack-containers22:03
*** vijendar has quit IRC22:05
*** vijendar1 has joined #openstack-containers22:05
*** yamamoto has joined #openstack-containers22:10
jasondjvgrant: ping22:15
jvgrantjasond: hi22:16
jasondjvgrant: hey, i was thinking about our microversions discussion the other day after seeing vijendar1's patch https://review.openstack.org/#/c/431160/22:17
jasondjvgrant: i found a couple of examples of a new Nova API with a enforced microversion https://github.com/openstack/nova/commit/fa002925460e70d988d1b4dd1ea594c680a43740#diff-a44099b611598e3071e3a44b04424e7fR138 https://github.com/openstack/nova/commit/c9091d0871948377685feca0eb2e41d8ad38228a#diff-a44099b611598e3071e3a44b04424e7fR3722:17
jasondjvgrant: so i'm just wondering if we should be doing it like that22:18
jvgrantjasond: the problem is pecan which nova doesn't use22:19
jvgrantjasond: i think i might have found a possible fix though. i'm trying out a few things22:19
jasondjvgrant: and if we should be documenting new apis as if they were microversioned22:20
jasondjvgrant: ok, cool22:20
jvgrantjasond: i really want it to work the same way as nova because i agree that we should document them as if they were microversioned22:20
vijendar1jvgrant jasond so, are we going to enforce micro-version like nova?22:21
jvgrantjasond: just trying to figure out how to handle that first call per controller where pecan goes through and enumerates all the methods.22:21
jasondjvgrant: well, if https://review.openstack.org/#/c/427907/ merges, then we are documenting the rotate ca-cert api as if it were microversioned when it's not22:21
jvgrantjasond: that pecan enumeration should always be "latest" but it uses whatever is sent with the first call22:21
jasondjvgrant: same with https://review.openstack.org/#/c/431160/22:22
jasondjvgrant: i see22:22
jvgrantjvgrant: it still is in documentation form, but it is not enforced after that patch22:22
jasondvijendar1: i think we need to fix a bug with pecan before we can do that22:23
jvgrantvijendar1: yeah, until that is fixed a new api should not have the header or the header should be 1.122:24
vijendar1jvgrant jasond what is the point in enforcing micro-version?22:24
vijendar1jvgrant jasond documenting is ok22:24
jasondvijendar1: https://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/api-microversions.html22:24
vijendar1jvgrant jasond but I am still trying to understand if there is any issue if we don't enforce version22:24
vijendar1jasond:  will take a look22:25
jasondvijendar1: it's for backwards incompatible api changes22:25
jvgrantjasond, vijendar1: it helps with backwards compatibility. it allows an API that is changed to still be supported22:25
jasondvijendar1: there isn't, but should we even bump the microversion at all?22:25
jasondjvgrant: ^?22:25
jvgrantjasond, vijendar1: but in the case of a new api which has no different version.... no there really isn't much gained by enforcing micro-versioning22:25
jvgrantthe micro-version documentation bump is nice because it provides a history of overall api changes22:26
jvgrantmicro-versions are accomplishing 2 goals: 1) provide backwards compatibility for changes, 2) provide a scheme for documenting api changes22:27
jvgrantwe are still providing 2) even when we don't enforce it22:27
jvgrantbefore enforcing micorversions there are plenty of examples of still documenting API changes in the code as X.Y22:28
jasondjvgrant: ok, that's what i was wondering22:29
jasondjvgrant: thanks for clarifying22:29
jvgrantjasond, vijendar1: that said I really do want the mirco-version header to work for all cases so I'm going to continue to work on a fix22:29
*** fragatina has joined #openstack-containers22:30
jvgrantfor now though, we will just enforce with the header when there is an actual existing API change22:30
jasondjvgrant: cool, we can add those headers back after that fix is in22:30
*** EricGonczer_ has quit IRC22:30
jvgrantjasond: yes. If I find a fix I'll probably go ahead and add headers to all the APIs just so that is very clear across them all what micro-versions each method supports22:30
jasondjvgrant: sounds good22:31
*** dave-mccowan has quit IRC22:31
*** sdake_ has joined #openstack-containers22:32
vijendar1jvgrant jasond I am still wondering if I should remove enforcement from this patch or not https://review.openstack.org/#/c/391301/22:34
jasondvijendar1: i think so22:34
jasondsame issue as https://review.openstack.org/#/c/427907/22:34
vijendar1jasond:  if I don't remove, first call would fail…right?22:34
vijendar1jasond: ok22:35
vijendar1jasond: will submit my patch now22:35
jasondvijendar1: yeah, see the example in https://bugs.launchpad.net/magnum/+bug/165943122:35
openstackLaunchpad bug 1659431 in Magnum "Unexpected response from microversioned API" [Medium,In progress] - Assigned to Jason Dunsmore (jasondunsmore)22:35
*** sdake has quit IRC22:36
vijendar1jasond: ok..got it.22:36
jvgrantvijendar1: you will see it if you make the call without using "latest" header22:36
jvgrantvijendar1: if you send even 1 call with "latest" to that controller then it will work fine and you won't see the error22:37
vijendar1jvgrant: got it22:37
vijendar1thanks jvgrant jasond22:37
jasondvijendar1: np22:37
openstackgerritVijendar Komalla proposed openstack/magnum master: Don't enforce microversion for stats API  https://review.openstack.org/43121022:38
jvgrantvijendar1: the CLI client always sends the header so if you use that you will never see the bug22:38
vijendar1jvgrant: that's why I didn't encounter this bug when I tested (I believe)22:39
jvgrantvijedar1: correct. Also if you send the correct version header the first call everything works fine as well from then on. You would have had to send a < 1.4 header on the very first call to see the bug22:44
*** vijendar1 has quit IRC22:50
*** huzhengchuan has joined #openstack-containers22:52
*** jasond has quit IRC23:01
*** chris_hultin is now known as chris_hultin|AWA23:03
*** swatson has quit IRC23:04
*** tonanhngo has quit IRC23:12
*** catintheroof has quit IRC23:25
*** huzhengchuan has quit IRC23:26
*** fragatina has quit IRC23:29
*** fragatina has joined #openstack-containers23:30
*** dimtruck is now known as zz_dimtruck23:35
*** code34 has quit IRC23:35
*** Drago1 has quit IRC23:40

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!