| *** hogepodge has quit IRC | 00:02 | |
| *** tonanhngo has quit IRC | 00:03 | |
| *** dimtruck is now known as zz_dimtruck | 00:06 | |
| *** hogepodge has joined #openstack-containers | 00:08 | |
| *** david-lyle has quit IRC | 00:09 | |
| *** Wenzhi has joined #openstack-containers | 00:13 | |
| *** tonanhngo has joined #openstack-containers | 00:14 | |
| *** tonanhngo has quit IRC | 00:18 | |
| *** hogepodge has quit IRC | 00:20 | |
| *** hogepodge has joined #openstack-containers | 00:21 | |
| *** david-lyle has joined #openstack-containers | 00:21 | |
| openstackgerrit | Imran Hayder Malik proposed openstack/python-magnumclient: Add missing options for HTTPClient if auth_token given. https://review.openstack.org/387732 | 00:24 |
|---|---|---|
| *** yolanda has quit IRC | 00:28 | |
| *** mtanino__ has joined #openstack-containers | 00:29 | |
| *** yolanda has joined #openstack-containers | 00:29 | |
| *** david-lyle has quit IRC | 00:29 | |
| *** mtanino has quit IRC | 00:30 | |
| *** david-lyle has joined #openstack-containers | 00:31 | |
| *** huzhengchuan has joined #openstack-containers | 00:33 | |
| *** david-lyle has quit IRC | 00:34 | |
| *** david-lyle has joined #openstack-containers | 00:35 | |
| *** dane_leblanc_ has quit IRC | 00:42 | |
| *** tovin07 has joined #openstack-containers | 00:46 | |
| *** david-lyle has quit IRC | 00:47 | |
| openstackgerrit | Imran Hayder Malik proposed openstack/python-magnumclient: Add missing options for HTTPClient if auth_token given. https://review.openstack.org/387732 | 00:48 |
| *** david-lyle has joined #openstack-containers | 00:48 | |
| *** tonanhngo has joined #openstack-containers | 00:48 | |
| *** tonanhngo has quit IRC | 00:49 | |
| *** EricGonczer_ has quit IRC | 00:51 | |
| *** david-lyle has quit IRC | 00:51 | |
| *** david-lyle has joined #openstack-containers | 00:52 | |
| *** tonanhngo has joined #openstack-containers | 00:57 | |
| *** tonanhngo has quit IRC | 00:58 | |
| *** david-lyle has quit IRC | 00:59 | |
| *** david-lyle has joined #openstack-containers | 01:00 | |
| *** tonanhngo has joined #openstack-containers | 01:05 | |
| *** david-lyle has quit IRC | 01:05 | |
| *** tonanhngo has quit IRC | 01:06 | |
| *** david-lyle has joined #openstack-containers | 01:06 | |
| *** david-lyle has quit IRC | 01:07 | |
| *** david-lyle has joined #openstack-containers | 01:13 | |
| *** david-lyle has quit IRC | 01:14 | |
| *** david-lyle has joined #openstack-containers | 01:15 | |
| *** tonanhngo has joined #openstack-containers | 01:15 | |
| *** hogepodge has quit IRC | 01:16 | |
| *** tonanhngo has quit IRC | 01:16 | |
| *** yolanda has quit IRC | 01:17 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 01:18 | |
| openstackgerrit | fengbeihong proposed openstack/magnum: DIB elements to support dcos for magnum https://review.openstack.org/364696 | 01:19 |
| *** david-lyle has quit IRC | 01:19 | |
| *** david-lyle has joined #openstack-containers | 01:20 | |
| *** david-lyle has quit IRC | 01:21 | |
| *** david-lyle has joined #openstack-containers | 01:23 | |
| *** tonanhngo has joined #openstack-containers | 01:23 | |
| *** yolanda has joined #openstack-containers | 01:23 | |
| *** david-lyle has quit IRC | 01:24 | |
| *** david-lyle has joined #openstack-containers | 01:25 | |
| *** pritesh has quit IRC | 01:27 | |
| *** trananhkma has joined #openstack-containers | 01:30 | |
| *** david-lyle has quit IRC | 01:32 | |
| *** david-lyle has joined #openstack-containers | 01:34 | |
| *** wangqun has joined #openstack-containers | 01:35 | |
| *** hogepodge has joined #openstack-containers | 01:35 | |
| *** david-lyle has quit IRC | 01:37 | |
| *** yee3796 has joined #openstack-containers | 01:38 | |
| *** david-lyle has joined #openstack-containers | 01:38 | |
| *** david-lyle has quit IRC | 01:38 | |
| *** yee379 has quit IRC | 01:39 | |
| *** trananhkma has quit IRC | 01:41 | |
| *** stack_ has quit IRC | 01:41 | |
| *** david-lyle has joined #openstack-containers | 01:44 | |
| *** david-lyle has quit IRC | 01:44 | |
| *** david-lyle has joined #openstack-containers | 01:45 | |
| *** david-lyle has quit IRC | 01:46 | |
| *** david-lyle has joined #openstack-containers | 01:46 | |
| *** david-lyle has quit IRC | 01:47 | |
| *** trananhkma has joined #openstack-containers | 01:51 | |
| *** david-lyle has joined #openstack-containers | 01:56 | |
| *** david-lyle has quit IRC | 01:57 | |
| *** david-lyle has joined #openstack-containers | 01:58 | |
| *** mtanino has joined #openstack-containers | 01:59 | |
| *** david-lyle has quit IRC | 02:00 | |
| *** mtanino__ has quit IRC | 02:00 | |
| *** david-lyle has joined #openstack-containers | 02:01 | |
| *** david-lyle has quit IRC | 02:02 | |
| *** david-lyle has joined #openstack-containers | 02:02 | |
| *** david-lyle has quit IRC | 02:03 | |
| *** david-lyle has joined #openstack-containers | 02:04 | |
| *** david-lyle has quit IRC | 02:04 | |
| *** mtanino has quit IRC | 02:04 | |
| *** david-lyle has joined #openstack-containers | 02:05 | |
| *** david-lyle has quit IRC | 02:05 | |
| openstackgerrit | Murali Allada proposed openstack/magnum: Move cluster delete method to driver https://review.openstack.org/387748 | 02:05 |
| *** david-lyle has joined #openstack-containers | 02:07 | |
| *** david-lyle has quit IRC | 02:08 | |
| *** david-lyle has joined #openstack-containers | 02:10 | |
| *** david-lyle has quit IRC | 02:11 | |
| *** david-lyle has joined #openstack-containers | 02:12 | |
| *** david-lyle has quit IRC | 02:14 | |
| *** david-lyle has joined #openstack-containers | 02:17 | |
| *** david-lyle has quit IRC | 02:18 | |
| *** david-lyle has joined #openstack-containers | 02:18 | |
| *** david-lyle has quit IRC | 02:19 | |
| *** david-lyle has joined #openstack-containers | 02:20 | |
| *** david-lyle has quit IRC | 02:21 | |
| *** zz_dimtruck is now known as dimtruck | 02:23 | |
| *** hongbin_ has joined #openstack-containers | 02:26 | |
| *** david-lyle has joined #openstack-containers | 02:26 | |
| *** dave-mccowan has quit IRC | 02:26 | |
| *** yuanying has quit IRC | 02:29 | |
| *** syed_ has quit IRC | 02:34 | |
| *** hogepodge has quit IRC | 02:40 | |
| *** hongbin_ has quit IRC | 02:41 | |
| *** hongbin_ has joined #openstack-containers | 02:41 | |
| *** mkrai has joined #openstack-containers | 02:44 | |
| *** mkrai_ has joined #openstack-containers | 02:50 | |
| openstackgerrit | fengbeihong proposed openstack/magnum: DIB elements to support dcos for magnum https://review.openstack.org/364696 | 02:51 |
| *** mkrai has quit IRC | 02:52 | |
| *** sheel has joined #openstack-containers | 02:55 | |
| *** muralia has quit IRC | 03:01 | |
| openstackgerrit | rajiv proposed openstack/magnum: Improve security for swarm https://review.openstack.org/352358 | 03:03 |
| *** hogepodge has joined #openstack-containers | 03:04 | |
| openstackgerrit | rajiv proposed openstack/magnum: Heat templates of different drivers contain duplicate code https://review.openstack.org/347858 | 03:15 |
| *** hongbin_ has quit IRC | 03:20 | |
| *** david-lyle has quit IRC | 03:23 | |
| *** david-lyle has joined #openstack-containers | 03:24 | |
| *** david-lyle has quit IRC | 03:25 | |
| *** david-lyle has joined #openstack-containers | 03:26 | |
| *** david-lyle has quit IRC | 03:27 | |
| *** david-lyle has joined #openstack-containers | 03:28 | |
| *** david-lyle has quit IRC | 03:29 | |
| *** david-lyle has joined #openstack-containers | 03:30 | |
| openstackgerrit | fengbeihong proposed openstack/magnum: DIB elements to support dcos for magnum https://review.openstack.org/364696 | 03:32 |
| *** david-lyle has quit IRC | 03:33 | |
| *** david-lyle has joined #openstack-containers | 03:34 | |
| *** david-lyle has quit IRC | 03:36 | |
| *** david-lyle has joined #openstack-containers | 03:46 | |
| *** david-lyle has quit IRC | 03:46 | |
| *** yuanying has joined #openstack-containers | 03:49 | |
| *** david-lyle has joined #openstack-containers | 03:50 | |
| *** david-lyle has quit IRC | 03:51 | |
| *** david-lyle has joined #openstack-containers | 03:53 | |
| *** david-lyle has quit IRC | 03:54 | |
| *** david-lyle has joined #openstack-containers | 03:55 | |
| *** david-lyle has quit IRC | 03:55 | |
| *** david-lyle has joined #openstack-containers | 03:57 | |
| *** david-lyle has quit IRC | 03:57 | |
| *** david-lyle has joined #openstack-containers | 03:58 | |
| *** david-lyle has quit IRC | 03:59 | |
| *** david-lyle has joined #openstack-containers | 04:00 | |
| *** david-lyle has quit IRC | 04:01 | |
| *** david-lyle has joined #openstack-containers | 04:01 | |
| *** david-lyle has quit IRC | 04:04 | |
| *** david-lyle has joined #openstack-containers | 04:04 | |
| *** david-lyle has quit IRC | 04:05 | |
| *** david-lyle has joined #openstack-containers | 04:06 | |
| *** david-lyle has quit IRC | 04:08 | |
| *** david-lyle has joined #openstack-containers | 04:10 | |
| *** david-lyle has quit IRC | 04:11 | |
| *** david-lyle has joined #openstack-containers | 04:12 | |
| *** david-lyle has quit IRC | 04:13 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 04:13 |
| *** david-lyle has joined #openstack-containers | 04:14 | |
| *** david-lyle has quit IRC | 04:15 | |
| *** david-lyle has joined #openstack-containers | 04:15 | |
| *** david-lyle has quit IRC | 04:16 | |
| *** david-lyle has joined #openstack-containers | 04:17 | |
| *** david-lyle has quit IRC | 04:18 | |
| *** david-lyle has joined #openstack-containers | 04:19 | |
| *** david-lyle has quit IRC | 04:20 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 04:20 |
| *** david-lyle has joined #openstack-containers | 04:21 | |
| *** GB21 has joined #openstack-containers | 04:34 | |
| openstackgerrit | Merged openstack/python-magnumclient: Add missing options for HTTPClient if auth_token given. https://review.openstack.org/387732 | 04:40 |
| openstackgerrit | Abhishek Chanda proposed openstack/python-magnumclient: Add missing options for HTTPClient if auth_token given. https://review.openstack.org/387789 | 04:41 |
| *** yuanying has quit IRC | 04:54 | |
| *** yuanying has joined #openstack-containers | 05:00 | |
| *** yuanying has quit IRC | 05:02 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 05:02 |
| *** agireud has quit IRC | 05:17 | |
| *** yamamoto has quit IRC | 05:20 | |
| *** agireud has joined #openstack-containers | 05:26 | |
| *** tonanhngo has quit IRC | 05:37 | |
| *** tonanhngo has joined #openstack-containers | 05:38 | |
| *** eliqiao has joined #openstack-containers | 05:43 | |
| *** wznoinsk has left #openstack-containers | 05:47 | |
| openstackgerrit | Merged openstack/magnum: Fix failure of systemd service kube-ui https://review.openstack.org/320110 | 05:54 |
| *** dimtruck is now known as zz_dimtruck | 05:56 | |
| *** yamamoto has joined #openstack-containers | 05:57 | |
| *** rcernin has joined #openstack-containers | 06:01 | |
| *** yuanying has joined #openstack-containers | 06:01 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 06:12 |
| *** mjura has joined #openstack-containers | 06:15 | |
| *** pcaruana has joined #openstack-containers | 06:18 | |
| *** Oku_OS-away is now known as Oku_OS | 06:20 | |
| *** mjura has quit IRC | 06:22 | |
| *** mjura has joined #openstack-containers | 06:22 | |
| *** hogepodge has quit IRC | 06:30 | |
| *** belmoreira has joined #openstack-containers | 06:47 | |
| *** pcastets has joined #openstack-containers | 06:52 | |
| *** tovin07 has quit IRC | 06:53 | |
| *** tonanhngo_ has joined #openstack-containers | 07:22 | |
| *** tonanhngo has quit IRC | 07:24 | |
| *** tonanhngo_ has quit IRC | 07:32 | |
| *** tonanhngo has joined #openstack-containers | 07:33 | |
| *** tonanhngo has quit IRC | 07:33 | |
| *** belmoreira has quit IRC | 07:34 | |
| *** hogepodge has joined #openstack-containers | 07:40 | |
| *** belmoreira has joined #openstack-containers | 07:52 | |
| *** takashi has joined #openstack-containers | 07:53 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 08:02 |
| *** openstackgerrit has quit IRC | 08:04 | |
| *** openstackgerrit has joined #openstack-containers | 08:05 | |
| *** zenoway has joined #openstack-containers | 08:40 | |
| *** huzhengchuan has quit IRC | 08:47 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum-ui: Imported Translations from Zanata https://review.openstack.org/387256 | 08:52 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum-ui: Imported Translations from Zanata https://review.openstack.org/387866 | 08:53 |
| *** yatinkarel has quit IRC | 08:55 | |
| *** huzhengchuan has joined #openstack-containers | 09:00 | |
| *** GB21 has quit IRC | 09:03 | |
| *** tonanhngo has joined #openstack-containers | 09:03 | |
| *** openstackgerrit has quit IRC | 09:04 | |
| *** openstackgerrit has joined #openstack-containers | 09:04 | |
| *** tonanhngo has quit IRC | 09:05 | |
| *** yatinkarel has joined #openstack-containers | 09:07 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 09:08 |
| *** ArchiFleKs has joined #openstack-containers | 09:12 | |
| *** mjura has quit IRC | 09:14 | |
| *** GB21 has joined #openstack-containers | 09:14 | |
| *** huzhengchuan has quit IRC | 09:18 | |
| *** huzhengchuan has joined #openstack-containers | 09:20 | |
| *** tonanhngo has joined #openstack-containers | 09:24 | |
| *** tonanhngo has quit IRC | 09:25 | |
| *** mjura has joined #openstack-containers | 09:34 | |
| *** ttx has joined #openstack-containers | 09:36 | |
| *** ttx has left #openstack-containers | 09:36 | |
| *** prithiv has joined #openstack-containers | 09:40 | |
| *** zenoway has quit IRC | 09:42 | |
| *** zenoway has joined #openstack-containers | 09:42 | |
| *** wznoinsk_ has joined #openstack-containers | 09:46 | |
| openstackgerrit | fengbeihong proposed openstack/magnum: DIB elements to support dcos for magnum https://review.openstack.org/364696 | 09:46 |
| *** zenoway has quit IRC | 09:47 | |
| *** wznoinsk_ is now known as wznoinsk | 09:47 | |
| *** tonanhngo has joined #openstack-containers | 09:49 | |
| *** tonanhngo has quit IRC | 09:50 | |
| *** wznoinsk has quit IRC | 09:50 | |
| openstackgerrit | Ryosuke Mizuno proposed openstack/magnum-ui: Add javascript tests for ClusterTemplateModel https://review.openstack.org/387336 | 09:58 |
| *** zenoway has joined #openstack-containers | 10:05 | |
| *** zenoway has quit IRC | 10:09 | |
| *** zenoway has joined #openstack-containers | 10:12 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 10:20 |
| *** belmoreira has quit IRC | 10:23 | |
| *** yamamoto has quit IRC | 10:23 | |
| *** zenoway has quit IRC | 10:24 | |
| openstackgerrit | feng.shengqin@zte.com.cn proposed openstack/magnum: add some tests for cluster and clustertemplate api https://review.openstack.org/387782 | 10:26 |
| *** daneyon has quit IRC | 10:26 | |
| *** daneyon has joined #openstack-containers | 10:27 | |
| *** trananhkma has quit IRC | 10:32 | |
| *** wangqun has quit IRC | 10:36 | |
| *** zenoway has joined #openstack-containers | 10:36 | |
| *** huzhengchuan has quit IRC | 10:37 | |
| *** prithiv has quit IRC | 10:40 | |
| *** huzhengchuan has joined #openstack-containers | 10:49 | |
| *** prithiv has joined #openstack-containers | 10:58 | |
| *** zenoway has quit IRC | 11:10 | |
| *** zenoway has joined #openstack-containers | 11:11 | |
| *** prithiv has quit IRC | 11:11 | |
| *** yamamoto has joined #openstack-containers | 11:11 | |
| *** omnipresent has joined #openstack-containers | 11:12 | |
| *** adisky has joined #openstack-containers | 11:15 | |
| *** zenoway has quit IRC | 11:15 | |
| *** omnipresent has quit IRC | 11:16 | |
| *** zenoway has joined #openstack-containers | 11:16 | |
| *** mkrai_ has quit IRC | 11:22 | |
| openstackgerrit | yatin proposed openstack/magnum: Remove pod/svc/container object reference from doc https://review.openstack.org/387367 | 11:25 |
| *** belmoreira has joined #openstack-containers | 11:27 | |
| *** schnidrig has joined #openstack-containers | 11:44 | |
| *** tonanhngo has joined #openstack-containers | 11:45 | |
| *** tonanhngo has quit IRC | 11:46 | |
| *** zul has quit IRC | 11:51 | |
| *** schnidrig has quit IRC | 11:53 | |
| *** srwilkers has joined #openstack-containers | 12:03 | |
| *** EricGonczer_ has joined #openstack-containers | 12:04 | |
| *** zul has joined #openstack-containers | 12:06 | |
| *** EricGonc_ has joined #openstack-containers | 12:10 | |
| *** dave-mccowan has joined #openstack-containers | 12:10 | |
| *** EricGonczer_ has quit IRC | 12:10 | |
| *** askb has quit IRC | 12:12 | |
| *** prithiv has joined #openstack-containers | 12:28 | |
| *** prithiv has quit IRC | 12:36 | |
| *** EricGonc_ has quit IRC | 12:36 | |
| *** vijendar1 has joined #openstack-containers | 12:40 | |
| *** GB21 has quit IRC | 12:41 | |
| *** huzhengchuan has quit IRC | 12:43 | |
| ArchiFleKs | Hi, if someone have the time, could you review this patch https://review.openstack.org/#/c/385461/ | 12:43 |
| *** prithiv has joined #openstack-containers | 12:43 | |
| *** tonanhngo has joined #openstack-containers | 12:44 | |
| *** tonanhngo has quit IRC | 12:44 | |
| *** schnidrig has joined #openstack-containers | 12:49 | |
| *** schnidrig1 has joined #openstack-containers | 12:52 | |
| *** hieulq_ has quit IRC | 12:52 | |
| *** schnidrig has quit IRC | 12:54 | |
| *** rpothier has joined #openstack-containers | 12:57 | |
| *** hieulq_ has joined #openstack-containers | 12:58 | |
| *** strigazi1AFK is now known as strigazi | 12:58 | |
| *** srwilkers has quit IRC | 12:58 | |
| *** srwilkers has joined #openstack-containers | 12:59 | |
| *** prithiv has quit IRC | 13:01 | |
| *** yuanying_ has joined #openstack-containers | 13:02 | |
| *** takashi has quit IRC | 13:08 | |
| *** yuanying_ has quit IRC | 13:09 | |
| *** Wenzhi has quit IRC | 13:09 | |
| *** zz_dimtruck is now known as dimtruck | 13:10 | |
| *** yuanying_ has joined #openstack-containers | 13:10 | |
| *** vijendar1 has left #openstack-containers | 13:16 | |
| *** prithiv has joined #openstack-containers | 13:28 | |
| *** ramishra has joined #openstack-containers | 13:35 | |
| *** yuanying_ has quit IRC | 13:44 | |
| *** ramishra has quit IRC | 13:47 | |
| *** mtanino has joined #openstack-containers | 13:48 | |
| *** yuanying_ has joined #openstack-containers | 13:50 | |
| *** EricGonczer_ has joined #openstack-containers | 13:50 | |
| *** dane_leblanc has joined #openstack-containers | 13:57 | |
| *** EricGonczer_ has quit IRC | 14:00 | |
| *** ramishra has joined #openstack-containers | 14:01 | |
| -openstackstatus- NOTICE: We are away of pycparser failures in the gate and working to address the issue. | 14:04 | |
| *** rlrossit has joined #openstack-containers | 14:07 | |
| *** yuanying_ has quit IRC | 14:12 | |
| *** muralia has joined #openstack-containers | 14:12 | |
| *** tonanhngo has joined #openstack-containers | 14:13 | |
| openstackgerrit | fengbeihong proposed openstack/magnum: Support dcos for magnum https://review.openstack.org/386435 | 14:14 |
| *** mjura has quit IRC | 14:16 | |
| *** yuanying_ has joined #openstack-containers | 14:20 | |
| *** yuanying_ has quit IRC | 14:21 | |
| *** mjura has joined #openstack-containers | 14:28 | |
| *** ramishra has quit IRC | 14:28 | |
| *** ramishra_ has joined #openstack-containers | 14:28 | |
| *** Drago has joined #openstack-containers | 14:32 | |
| *** Drago has quit IRC | 14:32 | |
| *** Drago has joined #openstack-containers | 14:32 | |
| *** prithiv has quit IRC | 14:42 | |
| *** jmckind has joined #openstack-containers | 14:43 | |
| *** chris_hultin|AWA is now known as chris_hultin | 14:43 | |
| openstackgerrit | Mathieu Velten proposed openstack/magnum: Make private network optional https://review.openstack.org/380354 | 14:50 |
| *** jmckind_ has joined #openstack-containers | 14:50 | |
| *** jmckind has quit IRC | 14:52 | |
| *** srwilkers has quit IRC | 14:55 | |
| *** zenoway has quit IRC | 14:59 | |
| *** zenoway has joined #openstack-containers | 15:00 | |
| *** zenoway has quit IRC | 15:00 | |
| *** zenoway has joined #openstack-containers | 15:00 | |
| *** Fengshengqin has joined #openstack-containers | 15:02 | |
| *** mjura has quit IRC | 15:03 | |
| *** anush has joined #openstack-containers | 15:11 | |
| *** EricGonczer_ has joined #openstack-containers | 15:14 | |
| *** EricGonczer_ has quit IRC | 15:15 | |
| *** EricGonczer_ has joined #openstack-containers | 15:15 | |
| *** anush has quit IRC | 15:16 | |
| *** adrian_otto has joined #openstack-containers | 15:16 | |
| *** sheel has quit IRC | 15:20 | |
| *** rlrossit has quit IRC | 15:26 | |
| *** srwilkers has joined #openstack-containers | 15:27 | |
| *** prithiv has joined #openstack-containers | 15:28 | |
| *** syed_ has joined #openstack-containers | 15:29 | |
| *** Fengshengqin has quit IRC | 15:30 | |
| *** Fengshengqin has joined #openstack-containers | 15:42 | |
| *** belmoreira has quit IRC | 15:44 | |
| adrian_otto | Hello team! Our weekly meeting will begin in about 15 minutes in #openstack-meeting-alt at UTC 1600. | 15:48 |
| *** adrian_otto has quit IRC | 15:48 | |
| *** dimtruck is now known as zz_dimtruck | 15:51 | |
| *** anush has joined #openstack-containers | 15:56 | |
| *** adrian_otto has joined #openstack-containers | 15:59 | |
| -openstackstatus- NOTICE: pycparser 2.16 released to fix assertion error from today. | 16:10 | |
| *** prithiv has quit IRC | 16:11 | |
| *** zenoway has quit IRC | 16:27 | |
| *** zenoway has joined #openstack-containers | 16:27 | |
| *** omnipresent has joined #openstack-containers | 16:31 | |
| *** zenoway has quit IRC | 16:31 | |
| *** yuanying_ has joined #openstack-containers | 16:33 | |
| *** omnipresent has quit IRC | 16:35 | |
| *** yuanying_ has quit IRC | 16:37 | |
| *** Fengshengqin has quit IRC | 16:45 | |
| *** mtanino has quit IRC | 16:47 | |
| *** rcernin has quit IRC | 16:51 | |
| *** sheel has joined #openstack-containers | 16:53 | |
| *** pcastets has quit IRC | 16:55 | |
| *** randallburt has joined #openstack-containers | 17:00 | |
| strigazi | adrian_otto, Have we decided on the number of sessions and which sessions we are going to have? | 17:01 |
| Drago | hongbin: Yes, randallburt will actually be proposing a spec that would pull more things into the driver layer, so that if you wanted a driver to do more things than just call a stack update (or not call stack update at all), you would be able to implement the cluster_whatever method with custom logic | 17:02 |
| *** vijendar1 has joined #openstack-containers | 17:02 | |
| adrian_otto | strigazi: I expect to finish that tonight when I reach my hotel. I'm in transit today. | 17:02 |
| adrian_otto | strigazi: do you have input you'd like me to consider? | 17:02 |
| randallburt | oh hi there | 17:02 |
| strigazi | I just want to be sure about the upgrades | 17:02 |
| tonanhngo | adrian_otto: If possible, can you arrange the session on scalability on Wed or Thur? That is, if we decide to have a session on scalability | 17:03 |
| Drago | hongbin: And if you really wanted to, I think that would mean you could create a driver that used a custom agent that accepts push updates | 17:03 |
| randallburt | Drago: yep | 17:03 |
| strigazi | Didn't have time last week to push the spec, I intend to do tomorrow | 17:03 |
| randallburt | Drago: though you wouldn't have to | 17:03 |
| adrian_otto | tonanhngo and strigazi yes, no problem. | 17:03 |
| Drago | randallburt: Point being, the world is your oyster | 17:04 |
| tonanhngo | adrian_otto: We do have a conflict with the Kuryr session for Magnum, Thursday 1:50pm. I guess we can just invite them over, or come to their session | 17:04 |
| *** jberkus has joined #openstack-containers | 17:05 | |
| adrian_otto | tonanhngo: do you have a link to the one in conflict? | 17:05 |
| strigazi | adrian_otto we also want to avoid the overlap with the heat session on scalability | 17:05 |
| adrian_otto | One thing we can do is remove one of our sessions | 17:06 |
| adrian_otto | or make it link to the other. I'd like to give up the room to other projects if we don't need it. | 17:06 |
| randallburt | I will not sign up to write an oyster plugin for magnum | 17:07 |
| tonanhngo | adrian_otto: https://www.openstack.org/summit/barcelona-2016/summit-schedule/events/17010/kuryr-magnum-integration | 17:07 |
| tonanhngo | adrian_otto: now if not everyone in Magnum wants to talk to Kuryr team, then maybe only a few of us needs to join them | 17:08 |
| *** anush has quit IRC | 17:08 | |
| tonanhngo | adrian_otto: myself, maybe Hongbin and others | 17:08 |
| adrian_otto | ok, I will look at the topics now and see if maybe there is one that might interest others. | 17:08 |
| Drago | adrian_otto: Or maybe one that's not too interesting | 17:09 |
| Drago | ;) | 17:10 |
| adrian_otto | maybe Docker on Windows Server 2016 Cluster Driver | 17:10 |
| adrian_otto | but nobody voted for that | 17:10 |
| Drago | Back in a few | 17:16 |
| *** Drago has quit IRC | 17:16 | |
| *** jmckind has joined #openstack-containers | 17:17 | |
| *** jmckind_ has quit IRC | 17:19 | |
| *** tonanhngo has quit IRC | 17:26 | |
| *** tonanhngo has joined #openstack-containers | 17:26 | |
| *** kwazar has quit IRC | 17:33 | |
| *** nikhil has quit IRC | 17:33 | |
| *** flaper87 has quit IRC | 17:33 | |
| *** coreyob has quit IRC | 17:33 | |
| *** redrobot has quit IRC | 17:33 | |
| *** Tahvok has quit IRC | 17:33 | |
| *** jgrassler has quit IRC | 17:33 | |
| *** etoews has quit IRC | 17:33 | |
| *** dims has quit IRC | 17:33 | |
| *** jroll has quit IRC | 17:33 | |
| *** Oku_OS has quit IRC | 17:33 | |
| *** jgrassle1 has joined #openstack-containers | 17:33 | |
| *** dims has joined #openstack-containers | 17:33 | |
| *** Tahvok has joined #openstack-containers | 17:33 | |
| *** Oku__OS has joined #openstack-containers | 17:33 | |
| *** redrobot has joined #openstack-containers | 17:33 | |
| *** kwazar has joined #openstack-containers | 17:33 | |
| *** coreyob has joined #openstack-containers | 17:34 | |
| *** redrobot is now known as Guest41366 | 17:34 | |
| *** jroll has joined #openstack-containers | 17:36 | |
| *** nikhil has joined #openstack-containers | 17:38 | |
| *** etoews has joined #openstack-containers | 17:40 | |
| *** zz_dimtruck is now known as dimtruck | 17:41 | |
| *** tonanhngo has quit IRC | 17:42 | |
| *** achanda has joined #openstack-containers | 17:42 | |
| achanda | Looks like the coe_version param is set to readonly in the api server. Who sets it and what's the default? | 17:45 |
| achanda | sorry, this wasn't obvious to me looking at the code | 17:45 |
| *** srwilkers has quit IRC | 17:47 | |
| *** srwilkers has joined #openstack-containers | 17:48 | |
| *** srwilkers has quit IRC | 17:48 | |
| *** adrian_otto1 has joined #openstack-containers | 17:50 | |
| *** adrian_otto has quit IRC | 17:52 | |
| *** srwilkers has joined #openstack-containers | 17:57 | |
| *** srwilkers has quit IRC | 17:59 | |
| *** jberkus has quit IRC | 18:05 | |
| *** jberkus has joined #openstack-containers | 18:10 | |
| *** Drago has joined #openstack-containers | 18:17 | |
| *** anush has joined #openstack-containers | 18:20 | |
| *** adrian_otto1 has quit IRC | 18:28 | |
| *** mtanino has joined #openstack-containers | 18:29 | |
| *** dane_leblanc has quit IRC | 18:37 | |
| *** dane_leblanc has joined #openstack-containers | 18:38 | |
| achanda | hongbin: ping | 18:38 |
| *** anush has quit IRC | 18:39 | |
| hongbin | achanda: hey | 18:39 |
| achanda | hongbin: trying to figure out the use of the coe_version var in the api | 18:40 |
| achanda | it's set to readonly | 18:40 |
| achanda | how is it calculated? | 18:40 |
| hongbin | achanda: for coe_version, i think you can ping muralia or Drago. i remembered they are the author of the code | 18:40 |
| achanda | ok, thanks | 18:41 |
| muralia | achanda, its hardcoded right now. because the version is tied to the image | 18:41 |
| achanda | ok, so there is no way to specify a different version of k8s? | 18:42 |
| muralia | well, we could implement that, but we didnt because the version is tied to the image and we build it per driver. | 18:44 |
| Drago | achanda: You would actually modify the driver | 18:44 |
| achanda | I see | 18:45 |
| achanda | Thanks all | 18:45 |
| Drago | achanda: The version number in the driver doesn't technically affect anything, we just needed to return the value somehow | 18:45 |
| Drago | hongbin: Did you see my last message to you in this chat? | 18:46 |
| *** flaper87 has joined #openstack-containers | 18:46 | |
| *** flaper87 has quit IRC | 18:46 | |
| *** flaper87 has joined #openstack-containers | 18:46 | |
| achanda | hongbin: me? the last one I saw was pinging Drago and muralia | 18:47 |
| Drago | hongbin: *Last two messages | 18:47 |
| Drago | achanda: No, not you | 18:47 |
| hongbin | Drago: ok, just checked your message | 18:48 |
| hongbin | Drago: sound like you want to use the heat agents? | 18:48 |
| *** chetna has joined #openstack-containers | 18:49 | |
| Drago | hongbin: Yes, I was replying to "true, for example, in trove, there are hooks for operators to do pre-* and post-* operators" | 18:49 |
| hongbin | Drago: i think the trove approach is better, but i am not strong at this | 18:50 |
| hongbin | Drago: we could discuss it more in the summit | 18:51 |
| Drago | hongbin: I don't know of this Trove feature. Can you give me a link so I can read about it? | 18:51 |
| hongbin | this is the design: https://wiki.openstack.org/wiki/Trove | 18:52 |
| Drago | hongbin: trove-guestagent? | 18:52 |
| hongbin | Drago: yes | 18:52 |
| hongbin | it is a rpc based agent | 18:52 |
| Drago | hongbin: Again, that means that the magnum conductor and each node needs to be on the same network | 18:54 |
| hongbin | Drago: or you can assume there are floating ips for each node | 18:54 |
| Drago | hongbin: And for a Cluster with floating IPs turned off? | 18:55 |
| hongbin | Drago: then the conductor should turn it into a polling based approach | 18:55 |
| hongbin | Drago: if agents are reachable, use push, otherwise, use polling | 18:56 |
| *** rajpatel has joined #openstack-containers | 18:58 | |
| Drago | hongbin: You can do this by configuring the Heat transport to be Zaqar | 18:59 |
| randallburt | hongbin: in the end, I think it best to *support* both setups, but operators in the end need to make the choice. Trove's approach doesn't work in all configurations and is from a time before os-*-config | 18:59 |
| hongbin | yes, but the slowness of polling needs to be solved in some ways | 19:00 |
| randallburt | and by default I don't think its a good idea to write a whole new agent when there are generic ones that exist that can do the job in a lot of cases. | 19:00 |
| *** tonanhngo has joined #openstack-containers | 19:00 | |
| hongbin | Drago: i don't think a hard requirement on zaqar is a good idea, a soft requirement is ok | 19:01 |
| randallburt | hongbin: we're deferring the hard requirement to Heat. Heat supports many transports for talking to the agents installed on the vm | 19:01 |
| randallburt | hongbin: zaqar is just the one with the best chance of reducing the polling problem you cite. | 19:01 |
| *** adisky has quit IRC | 19:02 | |
| randallburt | hongbin: and the generic in-instance agents are flexible enough that an operator should be able to customize them should they want or need something special | 19:02 |
| hongbin | randallburt: however, the zaqar is not the default? | 19:02 |
| Drago | hongbin: The default is configurable | 19:03 |
| randallburt | hongbin: no, IIRC, the default is to talk back to Heat directly, however, nobody running at any sort of scale uses it. | 19:03 |
| hongbin | randallburt: agree with you that it is better to have a generic agent, that means heat agents needs to be designed to be very generic and extentible | 19:03 |
| randallburt | Drago: oh, that's right. the operator can configure which one to use if its not specified | 19:03 |
| randallburt | hongbin: Heat only extends and hooks into the generic agents with its own custom handlers. the agents themselves weren't built by the Heat team. | 19:04 |
| hongbin | randallburt: then, the os-* agents are generic, or are specific to softwaredeployment? | 19:05 |
| randallburt | hongbin: the os-* agents are generic. | 19:06 |
| hongbin | Drago: my worry is that, if i want a push-based agent, that means i have to install zaqar, which turns into the same problem of enforcing operators to install barbican, which got a lot of pushback in before | 19:06 |
| randallburt | hongbin: Heat just leverages them to deploy and update the configuration on the instance and adds hooks so you can leverage things like ansible or chef or atomic natively | 19:07 |
| hongbin | randallburt: then, could magnum develop a agent, by extending the os-* agents to perform custom operations? | 19:07 |
| Drago | Custom operations? | 19:08 |
| hongbin | for example, execute a command before/after a lifecycle operation | 19:08 |
| randallburt | hongbin: I'm saying if you want to implement a push-based solution, then I think it would be best to look at the os-* agents and see how you can hook into them to do so. Then you can in the Magnum tree, develop those agent hooks and document how the user can use them and the restrictions they have. I just don' t think they should be the default | 19:08 |
| randallburt | hongbin: you can implement that now by customizing the Heat template Magnum uses | 19:09 |
| Drago | hongbin: The commands in the lifecycle operation are defined in the template, so before/after can just be before/after those commands | 19:09 |
| randallburt | hongbin: Heat lets you specify things to do before and after lifecycle operations | 19:09 |
| hongbin | randallburt: ok, if the heat agents can be used in that way, it seems to be good | 19:10 |
| randallburt | hongbin: though I do agree that if we made those lifecycle methods part of the drive interface, that does give operators more flexibility in their customizations. The default Heat-based driver could ignore them and defer to whatever the template specified | 19:10 |
| hongbin | randallburt: agree | 19:10 |
| Drago | hongbin: I'm confused, could you give me a concrete use-case? Otherwise it sounds like what you want can be achieved by adding commands to the software config like usual | 19:11 |
| hongbin | Drago: for example, do some cleanup before a upgrade of coe | 19:11 |
| hongbin | Drago: or even do some cleanup before a restart | 19:12 |
| randallburt | hongbin: which you could do by adding a software config/deployment that only runs on update | 19:12 |
| Drago | hongbin: And would having that be a part of the software config suffice? | 19:12 |
| Drago | *would suffice | 19:12 |
| hongbin | Drago: for example, ask the loadbalancer to forward traffic to other nodes, if we are restarting this node | 19:12 |
| randallburt | hongbin: or adding a lifecycle hook that runs before as well | 19:13 |
| hongbin | randallburt: yes, if it can be done without touching the magnum-provided template, that is optimal | 19:13 |
| Drago | Well it sounds like what I said earlier covers that: "hongbin: Yes, randallburt will actually be proposing a spec that would pull more things into the driver layer, so that if you wanted a driver to do more things than just call a stack update (or not call stack update at all), you would be able to implement the cluster_whatever method with custom logic" | 19:14 |
| randallburt | hongbin: well , that's where the driver would have to come in so yeah, lets do both. I'm going to submit a spec today or tomorrow to move the rest of the lifecycle stuff into the driver interface rather than having Magnum talk to Heat directly and I'll include this as well | 19:14 |
| hongbin | ok, sounds like a plan | 19:15 |
| randallburt | hongbin: that way, if an operator wants to use Mistral or Senlin to manage the clusters they could do that too | 19:15 |
| hongbin | randallburt: yes | 19:16 |
| Drago | hongbin: For running commands on a node, rely on the Heat agents | 19:16 |
| Drago | Other things can certainly be in the driver code | 19:16 |
| hongbin | Drago: ok | 19:17 |
| randallburt | or a mix of both. Trust me, as an operator of a very large OpenStack cloud, the more flexibility the better | 19:17 |
| hongbin | +1 | 19:17 |
| Drago | The driver will have to be able to use the novaclient to issue a node restart, because I don't know how you would ask heat to do it. randallburt? | 19:18 |
| Drago | randallburt: Sure. With the spec you're proposing, technically the driver can do things however it wants | 19:18 |
| randallburt | Drago: you'd have to use a software deployment that just issues a restart command | 19:19 |
| randallburt | Drago: unless you need a true hard reboot. | 19:19 |
| Drago | What I mean is rely on the Heat agents in the Magnum-provided drivers | 19:19 |
| Drago | randallburt: Ah right, I never use it so I forget that there's a reboot command from within the box | 19:20 |
| randallburt | Drago: sounds reasonable | 19:20 |
| *** daneyon_ has joined #openstack-containers | 19:20 | |
| Drago | hongbin: Does that sound reasonable to you? - Let the operator decide how they want to configure (in Heat) the agent's signal transport. If we want to, we can contribute to os-*-config and Heat to add a non-Zaqar push transport and still have the signal come from Heat | 19:24 |
| *** daneyon has quit IRC | 19:24 | |
| hongbin | Drago: seems to be fine | 19:25 |
| Drago | Thanks hongbin | 19:25 |
| *** schnidrig1 has quit IRC | 19:28 | |
| *** schnidrig has joined #openstack-containers | 19:28 | |
| *** achanda has quit IRC | 19:31 | |
| randallburt | Drago: yeah, you might have to add a transport to Heat but I can help with that hongbin if it comes to it | 19:34 |
| *** rafael__ has joined #openstack-containers | 19:38 | |
| *** daneyon has joined #openstack-containers | 19:48 | |
| *** yuanying_ has joined #openstack-containers | 19:49 | |
| *** daneyon_ has quit IRC | 19:50 | |
| *** yuanying_ has quit IRC | 19:53 | |
| *** ramishra_ has quit IRC | 19:57 | |
| *** ramishra has joined #openstack-containers | 19:59 | |
| *** Drago has quit IRC | 20:00 | |
| *** schnidrig has left #openstack-containers | 20:05 | |
| *** achanda has joined #openstack-containers | 20:07 | |
| *** dave-mccowan has quit IRC | 20:09 | |
| *** askb has joined #openstack-containers | 20:16 | |
| *** vijendar1 has quit IRC | 20:18 | |
| *** ramishra has quit IRC | 20:20 | |
| *** ramishra has joined #openstack-containers | 20:22 | |
| *** Drago has joined #openstack-containers | 20:28 | |
| *** muralia has quit IRC | 20:28 | |
| *** muralia has joined #openstack-containers | 20:29 | |
| *** Drago has quit IRC | 20:29 | |
| *** Drago has joined #openstack-containers | 20:29 | |
| *** jmckind_ has joined #openstack-containers | 20:29 | |
| *** jmckind has quit IRC | 20:30 | |
| openstackgerrit | melissaml proposed openstack/python-magnumclient: Add __ne__ built-in function https://review.openstack.org/388204 | 20:35 |
| *** sheel has quit IRC | 20:40 | |
| *** achanda has quit IRC | 20:43 | |
| *** vijendar has joined #openstack-containers | 20:57 | |
| *** vijendar has quit IRC | 21:01 | |
| *** rpothier has quit IRC | 21:01 | |
| *** chris_hultin is now known as chris_hultin|AWA | 21:03 | |
| openstackgerrit | Stephen Watson proposed openstack/python-magnumclient: Implement Parameter Deprecation https://review.openstack.org/388215 | 21:06 |
| *** ramishra has quit IRC | 21:07 | |
| *** ramishra has joined #openstack-containers | 21:09 | |
| *** vijendar has joined #openstack-containers | 21:11 | |
| *** syed_ has quit IRC | 21:15 | |
| *** syed_ has joined #openstack-containers | 21:16 | |
| openstackgerrit | Stephen Watson proposed openstack/python-magnumclient: Implement Parameter Deprecation https://review.openstack.org/388215 | 21:22 |
| *** vijendar has quit IRC | 21:24 | |
| *** ramishra has quit IRC | 21:27 | |
| *** vijendar has joined #openstack-containers | 21:29 | |
| *** ramishra has joined #openstack-containers | 21:29 | |
| *** daneyon has quit IRC | 21:34 | |
| *** Jeffrey4l has quit IRC | 21:34 | |
| *** Jeffrey4l has joined #openstack-containers | 21:35 | |
| openstackgerrit | Stephen Watson proposed openstack/python-magnumclient: Deprecates *-id parameters https://review.openstack.org/388215 | 21:35 |
| *** vijendar has quit IRC | 21:37 | |
| *** vijendar1 has joined #openstack-containers | 21:43 | |
| swatson_ | My git fu isn't strong, apparently | 21:53 |
| swatson_ | Anyone have any idea why the "git review -d 388215" didn't seem to work on that review? | 21:54 |
| swatson_ | Revisions 1 and 2 on that patch were fine, but rev 3 should have been a separate review... | 21:54 |
| *** vijendar1 has quit IRC | 21:59 | |
| Drago | swatson_: Did you keep the same change ID? | 22:01 |
| swatson_ | I made that first change and then ran the commands from here: http://docs.openstack.org/infra/manual/developers.html | 22:02 |
| swatson_ | "git review -d 388215" | 22:02 |
| swatson_ | then made a dev branch, made changes, amended the commit but only changed the message that described what the patch did | 22:03 |
| Drago | swatson_: You need to add a commit on top | 22:03 |
| Drago | Not amend | 22:03 |
| *** jmckind_ has quit IRC | 22:03 | |
| Drago | swatson_: git commit -a is not the same as --amend | 22:04 |
| *** vijendar1 has joined #openstack-containers | 22:04 | |
| swatson_ | ... | 22:04 |
| swatson_ | Drago: That explains it then | 22:04 |
| swatson_ | Palm, meet face. What's the best course of action from here then? | 22:05 |
| swatson_ | Ideally I want these to be separate reviews. One for the decorator implementation, and another for the deprecation itself | 22:05 |
| *** askb has quit IRC | 22:06 | |
| *** askb has joined #openstack-containers | 22:06 | |
| Drago | swatson_: There's probably a way to get a diff between your two patches and then separate it out as its own commit | 22:07 |
| swatson_ | Drago: Through Gerrit? | 22:07 |
| Drago | swatson_: no | 22:07 |
| *** dimtruck is now known as zz_dimtruck | 22:07 | |
| swatson_ | Drago: I could do what I meant to do earlier and reset back to the point before I committed the extra | 22:08 |
| swatson_ | and "re-commit" from there maybe? | 22:08 |
| Drago | swatson_: Maybe try doing a soft reset to unstage all of your changed files, then stash them, switch to a branch that has your previous patchset, and apply the stash | 22:09 |
| Drago | Might work | 22:09 |
| swatson_ | Drago: So go back to where the original "should" be, commit, then do the "git review -d" stuff as normal | 22:11 |
| *** vijendar1 has quit IRC | 22:11 | |
| Drago | swatson_: One sec | 22:11 |
| Drago | swatson_: https://gist.github.com/dragorosson/08cb8a06c42b3348d2e9c7302f6ebf01 | 22:14 |
| swatson_ | Drago: Oh cool. I'll give this a shot | 22:15 |
| Drago | swatson_: That will give you a branch with what you want, then you can do git checkout -b foo | 22:15 |
| swatson_ | Drago: I'm wondering now what "git review -d $CHANGE_NUMBER" does | 22:17 |
| swatson_ | Or does the fetch accomplish that for me? | 22:17 |
| swatson_ | And the -a is what tells gerrit (via git) about the dependency? | 22:17 |
| Drago | swatson_: No, git commit -a is a normal git flag | 22:19 |
| randallburt | swatson_: git review -d <number> just checks out the change into a new branch and switches to it | 22:19 |
| *** vijendar has joined #openstack-containers | 22:19 | |
| Drago | randallburt: The dependency is in the fact that the second commit lists the first commit as its parent (normal git stuff) | 22:19 |
| *** achanda has joined #openstack-containers | 22:19 | |
| Drago | *swatson_^ | 22:19 |
| randallburt | yep | 22:19 |
| swatson_ | Drago randallburt Got it | 22:20 |
| swatson_ | Thanks for the help! | 22:20 |
| Drago | Welcome | 22:20 |
| randallburt | which makes updating an entire patch chain a chore... | 22:20 |
| *** selena_092 has joined #openstack-containers | 22:21 | |
| openstackgerrit | Stephen Watson proposed openstack/python-magnumclient: Renames *-id parameters https://review.openstack.org/388240 | 22:22 |
| *** achanda has quit IRC | 22:22 | |
| swatson_ | now back to the original patch, can I abandon a specific patch revision? | 22:22 |
| swatson_ | e.g. kill the 3rd revision of https://review.openstack.org/#/c/388215/ so it only goes to the 2nd | 22:23 |
| swatson_ | I see that I can diff between 3 and 2, and within that I can delete specific file changes in the commit. Not sure if that's the right path though | 22:23 |
| Drago | swatson_: Probably not. I would put a message in the gerrit discussion, but it doesn't really matter | 22:24 |
| *** dave-mccowan has joined #openstack-containers | 22:24 | |
| Drago | swatson_: Just push a new revision | 22:24 |
| openstackgerrit | Merged openstack/python-magnumclient: Add missing options for HTTPClient if auth_token given. https://review.openstack.org/387789 | 22:25 |
| Drago | swatson_: In fact, when you push your 2nd commit, that's exactly what it'll do. If you have a number of patches that all depend on each other and modify an earlier one, gerrit will know how to handle it | 22:25 |
| *** rajpatel has quit IRC | 22:27 | |
| swatson_ | Drago: You're saying checkout the 2nd revision, stay on the detached head and do a git review from that? | 22:27 |
| *** selena_092 has quit IRC | 22:28 | |
| Drago | swatson_: Well, after you run the commands in the gist I sent, you'll have a branch that you can directly do git review on | 22:28 |
| swatson_ | Drago: Yeah, that's the patch I just put in up there ^ | 22:29 |
| Drago | swatson_: It'll ask you about the fact that there are two commits | 22:29 |
| Drago | swatson_: Hm, that's interesting… | 22:30 |
| swatson_ | Drago: I don't know if that's a good interesting or a bad one :P | 22:32 |
| Drago | swatson_: I would try to re-push the first commit | 22:32 |
| Drago | swatson_: It's kind of weird that it wouldn't put up a 4th patch set | 22:33 |
| swatson_ | Drago: ? I got mostly the result I was looking for with this except I want to kill that 3rd patch set on my 1st review | 22:34 |
| *** dave-mccowan has quit IRC | 22:34 | |
| swatson_ | So to recap I have the 1st review with 3 patch sets. The 3rd patch set was my botched one. My 2nd review is what I was hoping to achieve instead of that 3rd patch set on the 1st review | 22:34 |
| swatson_ | If that makes sense | 22:35 |
| *** dane_leblanc has quit IRC | 22:36 | |
| Drago | swatson_: Right. Instead of killing the 3rd one, I would have though it'd put up a 4th one identical to the 2nd | 22:37 |
| swatson_ | Drago: Ah. There was only the one commit in that gist you posted so I thought it made sense | 22:37 |
| swatson_ | Drago: Would checkout the 2nd patch and amending the commit there push the 4th set you think? | 22:38 |
| Drago | swatson_: Amending it with what? You could change the commit message slightly and that would be sufficient | 22:38 |
| Drago | It just needs a different sha | 22:39 |
| swatson_ | Drago: I actually do have one small fix to make so an additional edit is no problem | 22:39 |
| Drago | swatson_: perfect | 22:39 |
| openstackgerrit | Stephen Watson proposed openstack/python-magnumclient: Implement Parameter Deprecation https://review.openstack.org/388215 | 22:41 |
| swatson_ | Drago: That did the trick :) | 22:41 |
| swatson_ | Drago: Thanks again for the help! | 22:42 |
| Drago | swatson_: You need to rebase your 2nd commit on the new 1st one | 22:42 |
| swatson_ | Drago: ah, good catch | 22:46 |
| *** kebray has joined #openstack-containers | 22:47 | |
| openstackgerrit | Stephen Watson proposed openstack/python-magnumclient: Renames *-id parameters https://review.openstack.org/388240 | 22:48 |
| swatson_ | Drago: I think that's settled now. Time for me to hit the driving range | 22:50 |
| Drago | Looks good | 22:50 |
| swatson_ | Drago: One of my reviewers just caught that my new patch doesn't depend on the old >_< | 22:54 |
| swatson_ | Can I just add the Depends-on in my commit message? | 22:54 |
| swatson_ | Well, the 2nd is the child of the 1st so that shouldn't matter anyway | 22:55 |
| Drago | swatson_: Except it does. Depends-on is for cross-project dependencies | 22:56 |
| *** randallburt has quit IRC | 22:56 | |
| swatson_ | Drago: OK. Then the parent/child relationship is all that it needs | 22:57 |
| Drago | yes | 22:57 |
| swatson_ | Drago: Cool. Then I'm calling my git work for today done :P Thanks again | 22:57 |
| Drago | Welcome | 22:57 |
| *** Drago has quit IRC | 22:59 | |
| *** EricGonczer_ has quit IRC | 23:02 | |
| *** dave-mccowan has joined #openstack-containers | 23:19 | |
| *** hongbin has quit IRC | 23:23 | |
| *** rafael__ has quit IRC | 23:37 | |
| *** yamamoto has quit IRC | 23:38 | |
| *** chetna has quit IRC | 23:51 | |
| *** ramishra has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!