Tuesday, 2016-08-09

*** daneyon has joined #openstack-containers00:00
*** daneyon has quit IRC00:05
*** adrian_otto has quit IRC00:29
*** eghobo has quit IRC00:30
*** banix has quit IRC00:32
*** syed_ has quit IRC00:32
openstackgerritMerged openstack/magnum: Restricted Magnum service state to 'up' and 'down'  https://review.openstack.org/35037300:39
zhugaoxiaoERROR: Unknown attributes for argument baymodel: master_lb_enabled, docker_storage_driver, fixed_subnet (HTTP 400)00:40
zhugaoxiaosomeone can help me?00:40
tonanhngozhugaoxiao:  I think you want to use "-" instead of "_" in the attributes00:43
*** jwcroppe has joined #openstack-containers00:46
*** hieulq_ has joined #openstack-containers00:47
*** praneshp has quit IRC00:51
*** jwcroppe has quit IRC00:51
*** mtanino has joined #openstack-containers00:54
*** banix has joined #openstack-containers00:54
*** Drago has joined #openstack-containers00:54
*** Drago has quit IRC00:55
*** Drago has joined #openstack-containers00:55
zhugaoxiaomagnum baymodel-create --name k8sbaymodel \00:57
zhugaoxiao                       --image-id fedora-atomic-latest \00:57
zhugaoxiao                       --keypair-id testkey \00:57
zhugaoxiao                       --external-network-id public \00:57
zhugaoxiao                       --dns-nameserver 8.8.8.8 \00:57
zhugaoxiao                       --flavor-id m1.small \00:57
zhugaoxiao                       --docker-volume-size 5 \00:57
zhugaoxiao                       --network-driver flannel \00:57
zhugaoxiao                       --coe kubernetes00:57
zhugaoxiaomitaka version00:59
tonanhngoAh, mitaka version does not have the options master-lb-enabled, docker-storage-driver.01:00
tonanhngoAre you using the latest python client or mitaka python client?01:00
zhugaoxiaono01:00
zhugaoxiaoI am using mitaka python clients01:01
zhugaoxiaostack@ubuntu:~/devstack$ magnum --version01:02
zhugaoxiao2.2.101:02
tonanhngoIt seems there is a version mismatch somewhere in your environment. Those attributes don't even exist in mitaka.01:02
tonanhngo(the ones causing the error)01:02
zhugaoxiaook01:03
zhugaoxiaothank you01:03
tonanhngonp01:03
*** tonanhngo has quit IRC01:03
zhugaoxiaoI will try again,maybe change my version to master01:03
*** tonanhngo has joined #openstack-containers01:04
*** tonanhngo has quit IRC01:09
hieulqhieulq01:13
*** trananhkma has joined #openstack-containers01:17
*** dimtruck is now known as zz_dimtruck01:22
*** rafael_ has quit IRC01:22
*** hieulq_ has quit IRC01:25
*** sdake has quit IRC01:27
*** sdake has joined #openstack-containers01:29
*** sergmelikyan has joined #openstack-containers01:31
*** Drago has quit IRC01:32
*** Drago has joined #openstack-containers01:36
*** hongbin_ has joined #openstack-containers01:36
*** banix has quit IRC01:38
*** amitkqed has quit IRC01:43
*** amitkqed has joined #openstack-containers01:43
*** muralia_ has joined #openstack-containers01:50
*** muralia has quit IRC01:50
*** hongbin has quit IRC01:54
*** Drago has quit IRC01:56
*** sergmelikyan has quit IRC01:59
*** zz_dimtruck is now known as dimtruck02:00
*** sergmelikyan has joined #openstack-containers02:11
*** eghobo has joined #openstack-containers02:29
*** Wenzhi__ has quit IRC02:29
*** Wenzhi has joined #openstack-containers02:29
*** mkrai has joined #openstack-containers02:34
*** sergmelikyan has quit IRC02:41
*** sergmelikyan has joined #openstack-containers02:41
*** daneyon has joined #openstack-containers02:42
*** fragatina has quit IRC02:44
*** sergmelikyan has quit IRC02:46
*** daneyon has quit IRC02:47
*** jwcroppe has joined #openstack-containers02:48
*** kushal has quit IRC02:49
*** Drago1 has joined #openstack-containers02:49
*** Drago1 has quit IRC02:49
*** Drago1 has joined #openstack-containers02:50
*** jwcroppe has quit IRC02:53
*** alexlist has quit IRC02:58
*** Drago1 has quit IRC03:00
*** julim has quit IRC03:00
*** tonanhngo has joined #openstack-containers03:00
openstackgerritrajiv proposed openstack/magnum: Improve security for swarm  https://review.openstack.org/35235803:07
*** Drago1 has joined #openstack-containers03:07
*** eghobo has quit IRC03:09
*** jberkus has quit IRC03:23
*** hongbin_ has quit IRC03:27
*** hongbin has joined #openstack-containers03:28
*** abelur is now known as abelur|lunch03:29
*** vimal has joined #openstack-containers03:31
*** kevinz has joined #openstack-containers03:36
openstackgerritrajiv proposed openstack/magnum: Heat templates of different drivers contain duplicate code  https://review.openstack.org/34785803:38
*** hongbin_ has joined #openstack-containers03:59
*** hongbin has quit IRC04:01
*** hongbin_ has quit IRC04:03
*** kushal has joined #openstack-containers04:05
*** vimal has quit IRC04:11
*** tonanhngo has quit IRC04:12
*** mkrai has quit IRC04:12
*** dave-mccowan has quit IRC04:24
openstackgerritrajiv proposed openstack/magnum: Allow magnum services to be deleted by admin  https://review.openstack.org/34872804:25
*** mkrai has joined #openstack-containers04:28
*** vimal has joined #openstack-containers04:32
*** jwcroppe has joined #openstack-containers04:33
*** jwcroppe has quit IRC04:33
*** jwcroppe has joined #openstack-containers04:33
*** praneshp has joined #openstack-containers04:35
*** abelur|lunch is now known as abelur04:35
openstackgerritrajiv proposed openstack/magnum: Allow disable/enable a magnum service.  https://review.openstack.org/35270004:42
*** tonanhngo has joined #openstack-containers04:46
*** mtanino has quit IRC05:01
*** david-lyle_ has joined #openstack-containers05:11
*** david-lyle has quit IRC05:13
*** sergmelikyan has joined #openstack-containers05:21
*** rcernin has joined #openstack-containers05:21
*** daneyon has joined #openstack-containers05:25
*** eghobo has joined #openstack-containers05:25
*** sdake has quit IRC05:26
*** sdake has joined #openstack-containers05:29
*** daneyon has quit IRC05:30
*** jwcroppe has quit IRC05:42
*** jwcroppe has joined #openstack-containers05:42
*** jwcroppe has quit IRC05:47
*** chandankumar has joined #openstack-containers05:47
*** sergmelikyan has quit IRC05:53
*** yatin has quit IRC05:58
openstackgerritMerged openstack/magnum-ui: Imported Translations from Zanata  https://review.openstack.org/35206906:05
*** maestropandy has joined #openstack-containers06:10
*** praneshp has quit IRC06:25
*** tonanhngo has quit IRC06:35
*** sdake has quit IRC06:38
openstackgerritImran Hayder Malik proposed openstack/magnum-ui: Add insecure/ca-cert option for magnumclient  https://review.openstack.org/35272806:38
*** pcaruana has joined #openstack-containers06:39
*** tonanhngo has joined #openstack-containers06:43
*** jwcroppe has joined #openstack-containers06:43
openstackgerritImran Hayder Malik proposed openstack/magnum-ui: Add insecure/ca-cert option for magnumclient  https://review.openstack.org/35273106:43
*** tonanhngo has quit IRC06:44
*** diga has joined #openstack-containers06:46
*** daneyon_ has quit IRC06:47
*** daneyon has joined #openstack-containers06:47
*** jwcroppe has quit IRC06:48
*** maestropandy has left #openstack-containers06:48
*** diga has quit IRC06:59
*** tonanhngo has joined #openstack-containers07:01
*** belmoreira has joined #openstack-containers07:01
*** tonanhngo has quit IRC07:02
openstackgerritDrago proposed openstack/magnum: [WIP] Add NodeGroup specification  https://review.openstack.org/35273407:06
openstackgerritDrago proposed openstack/magnum: [WIP] Add NodeGroup specification  https://review.openstack.org/35273407:09
*** manikanta_tadi has joined #openstack-containers07:11
*** dimtruck is now known as zz_dimtruck07:11
*** daneyon_ has joined #openstack-containers07:13
*** kushal has quit IRC07:13
*** zenoway has joined #openstack-containers07:16
*** eghobo has quit IRC07:18
*** daneyon_ has quit IRC07:18
*** swatson has quit IRC07:21
*** elo has quit IRC07:31
*** yamamoto has quit IRC07:33
*** mikelk has joined #openstack-containers07:40
*** david-lyle has joined #openstack-containers07:43
*** jwcroppe has joined #openstack-containers07:44
*** david-lyle_ has quit IRC07:46
*** jwcroppe has quit IRC07:49
*** sdake has joined #openstack-containers07:51
*** bunting_ has quit IRC07:54
*** vijaykc4 has joined #openstack-containers08:04
*** sdake has quit IRC08:06
*** ramishra_ has quit IRC08:07
*** daneyon_ has joined #openstack-containers08:08
*** ramishra has joined #openstack-containers08:08
openstackgerritSpyros Trigazis proposed openstack/magnum: Add functional test for k8s ironic  https://review.openstack.org/33643308:11
openstackgerritSpyros Trigazis proposed openstack/magnum: Fix ironic template  https://review.openstack.org/32096808:11
openstackgerritSpyros Trigazis proposed openstack/magnum: Re: Remove dependency of metadata service  https://review.openstack.org/34764608:11
*** daneyon_ has quit IRC08:12
*** manikanta_tadi has quit IRC08:15
*** kushal has joined #openstack-containers08:25
*** yamamoto has joined #openstack-containers08:35
*** vijaykc4 has quit IRC08:41
*** yamamoto has quit IRC08:41
*** yamamoto has joined #openstack-containers08:42
*** vijaykc4 has joined #openstack-containers08:44
*** jwcroppe has joined #openstack-containers08:45
rajiv_For bug: https://bugs.launchpad.net/magnum/+bug/140645708:48
openstackLaunchpad bug 1406457 in Magnum "Add error handling for maximum length of values" [Wishlist,Triaged] - Assigned to rajiv (rajiv-kumar)08:48
*** maestropandy has joined #openstack-containers08:48
rajiv_I want to make following parameters to enum type08:49
rajiv_Network driver08:49
rajiv_cluster distro08:49
rajiv_volume driver08:49
rajiv_server type08:49
rajiv_node address08:49
rajiv_master address08:49
rajiv_magnum service --> binary08:49
rajiv_is there any problem? is it ok to make them enum and restrict there values to enum only?08:49
*** jwcroppe has quit IRC08:49
strigazinode address and master address to enum?08:50
rajiv_node address and master address  to IPv4 address type.08:50
*** chandankumar_ has joined #openstack-containers08:50
rajiv_what do you think spyros?08:51
strigazior IPv608:52
*** yamamoto has quit IRC08:52
*** yamamoto has joined #openstack-containers08:52
*** yamamoto has quit IRC08:52
*** yamamoto has joined #openstack-containers08:53
rajiv_Already IPv4 is used for other fields.08:53
hieulqeliqiao: you around?08:53
rajiv_I am not sure, whether magnum supports IPv6 or not.08:53
*** chandankumar has quit IRC08:54
strigazicluster_distro can't be enum with the current implementation08:54
rajiv_dnsnameserver uses IPv4.08:54
rajiv_we have only some set of distro that magnum supports.08:54
hieulqeliqiao: about bug 1539516, can you explain your case that "Magnum service doesn't work if start multiple m-cond on same host"08:55
openstackbug 1539516 in Magnum "Magnum service doesn't work if start multiple m-cond on same host" [Medium,New] https://launchpad.net/bugs/1539516 - Assigned to Hieu LE (hieulq)08:55
strigaziwhat about contrib drivers? suse wants to add a new on08:55
strigaziwhat about contrib drivers? suse wants to add a new one08:55
strigazicluster_distro must be validated per driver08:55
hieulqeliqiao: I have tested on my devstack environment, in case of running multiple m-cond, I can still create bay, baymodel.. and seems like Magnum can work normally08:55
rajiv_hmm, i got it.08:56
rajiv_do you think, user should be denied to set these values?08:56
hieulqeliqiao: do you mean that magnum service-list must list all m-cond process running?08:56
*** yamamoto has quit IRC08:57
rajiv_I want to make them enum here https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/baymodel.py#L9608:57
*** chandankumar_ is now known as chandankumar08:58
*** maestropandy1 has joined #openstack-containers08:59
strigaziNo, it must not be enum. This change will not allow operators to have custom bay-drivers08:59
*** maestropandy1 has left #openstack-containers08:59
rajiv_ok, i got it. What about other parameters?08:59
*** maestropandy has quit IRC09:00
rajiv_network driver, volume driver, server type and magnum service(binary)09:00
rajiv_magnum service is always going to be magnum-conductor09:01
strigaziThe same applies to network-driver, volume-driver09:01
*** yamamoto has joined #openstack-containers09:01
*** fawadkhaliq has joined #openstack-containers09:01
*** fawadkhaliq has quit IRC09:01
rajiv_ok09:01
strigazichecking for magnum_service09:01
*** zz_dimtruck is now known as dimtruck09:02
rajiv_ok09:09
strigaziI think it can be the binary can be enum, but I'm not sure if we want to be that strict. Instead of that I have to propose two bug that need a lot of work09:09
strigazihttps://bugs.launchpad.net/magnum/+bug/151166709:10
openstackLaunchpad bug 1511667 in Magnum "Increase test coverage to 90% for non-generated code" [Low,In progress] - Assigned to Larry Rensing (lr699s)09:10
rajiv_If you need any help, please let me know. :)09:10
strigaziand https://bugs.launchpad.net/magnum/+bug/149033409:10
openstackLaunchpad bug 1490334 in Magnum "Align k8s CoreOS template with atomic" [Medium,Confirmed] - Assigned to Vilobh Meshram (vilobhmm)09:10
rajiv_which bug, i can work on?09:12
strigaziThe test coverage is the most important IMO and there is work for the whole team there09:12
strigazi151166709:13
rajiv_ok, I will work on it.09:14
rajiv_Can i get help from someone or will someone else will be working on it?09:14
*** yatin has joined #openstack-containers09:14
strigaziLarry was working on it but haven't heard from him recently09:15
rajiv_OK, i will start working on it. Thanks Spyros09:15
strigaziI suggest to pick a file that was coverage over 70%09:15
rajiv_ok09:15
*** dimtruck is now known as zz_dimtruck09:16
strigazihaving test coverage will improve our project significantly09:16
strigaziThanks rajiv_09:16
rajiv_You are welcome. If you want me to work on any other bug with high priority, always feel free to contact :)09:18
strigaziFor me this is very high actually :) Other projects don't accept code that reduces the coverage even 0.01%09:19
strigaziI'll suggest to the team to mark it as high09:19
openstackgerritSpyros Trigazis proposed openstack/magnum: Add functional test for k8s ironic  https://review.openstack.org/33643309:26
openstackgerritSpyros Trigazis proposed openstack/magnum: Fix ironic template  https://review.openstack.org/32096809:26
openstackgerritSpyros Trigazis proposed openstack/magnum: Add functional test for k8s ironic  https://review.openstack.org/33643309:30
openstackgerritSpyros Trigazis proposed openstack/magnum: Fix ironic template  https://review.openstack.org/32096809:30
openstackgerritThomas Goirand proposed openstack/magnum: Makes config file generation reproducible  https://review.openstack.org/35280609:33
rajiv_spyros: i was working on https://bugs.launchpad.net/magnum/+bug/1517218, i think, to some extend it address https://bugs.launchpad.net/magnum/+bug/1490334, I changed a lot of code. I got comment to submit in multiple commit but by mistake there i put "closes-bug" not "Partial bug"  therefore it got merged.09:34
openstackLaunchpad bug 1517218 in Magnum "consolidate heat fragments" [Medium,Fix released] - Assigned to rajiv (rajiv-kumar)09:34
openstackLaunchpad bug 1490334 in Magnum "Align k8s CoreOS template with atomic" [Medium,Confirmed]09:34
rajiv_I have still a patch https://review.openstack.org/#/c/349173/ for this.09:35
strigaziThere is some overlap in these bugs which is ok09:40
strigaziWe can close them even manually later09:40
rajiv_ok09:40
*** tonanhngo has joined #openstack-containers09:42
*** tonanhngo has quit IRC09:44
*** jwcroppe has joined #openstack-containers09:46
*** jwcroppe has quit IRC09:50
*** daneyon_ has joined #openstack-containers09:56
openstackgerritMerged openstack/magnum: Support HA for k8s coreos bay  https://review.openstack.org/34954309:57
*** daneyon_ has quit IRC10:00
*** tonanhngo has joined #openstack-containers10:09
*** tonanhngo has quit IRC10:10
*** Drago1 has quit IRC10:12
*** tonanhngo has joined #openstack-containers10:42
*** tonanhngo has quit IRC10:44
*** jwcroppe has joined #openstack-containers10:47
*** jwcroppe has quit IRC10:52
*** sdake has joined #openstack-containers10:53
*** vijaykc4 has quit IRC10:53
*** vijaykc4 has joined #openstack-containers10:55
*** tonanhngo has joined #openstack-containers11:03
*** tonanhngo has quit IRC11:05
*** sdake has quit IRC11:08
*** maestropandy has joined #openstack-containers11:16
*** mkrai has quit IRC11:18
*** maestropandy has quit IRC11:20
*** yamamoto has quit IRC11:30
*** vijaykc4 has quit IRC11:32
*** vijaykc4 has joined #openstack-containers11:32
*** daneyon_ has joined #openstack-containers11:44
*** julim has joined #openstack-containers11:47
*** jwcroppe has joined #openstack-containers11:47
*** daneyon_ has quit IRC11:49
*** abelur has quit IRC11:50
*** yamamoto has joined #openstack-containers11:51
*** yamamoto has quit IRC11:51
*** jwcroppe has quit IRC11:52
*** yamamoto has joined #openstack-containers12:02
*** vijaykc4 has quit IRC12:04
*** sergmelikyan has joined #openstack-containers12:05
*** sergmelikyan has quit IRC12:06
*** sergmelikyan has joined #openstack-containers12:06
*** yolanda_ has joined #openstack-containers12:11
*** yolanda_ has quit IRC12:15
*** trananhkma has quit IRC12:16
*** mjura has joined #openstack-containers12:17
*** maestropandy has joined #openstack-containers12:23
*** maestropandy has left #openstack-containers12:24
openstackgerritMerged openstack/magnum: Pass missing variables to heat-params  https://review.openstack.org/35261912:24
zhugaoxiaoWhen i create bay,does the vm need connect to internet?12:27
strigaziyes12:27
rajiv_strigazi: how can we get which line is not covered by UT?12:28
*** yamamoto has quit IRC12:29
*** yolanda has quit IRC12:29
zhugaoxiaoIf i use devstack,what should i do for the network configuration?12:30
*** vimal has quit IRC12:36
*** tonanhngo has joined #openstack-containers12:38
*** dave-mccowan has joined #openstack-containers12:39
*** tonanhngo has quit IRC12:39
*** kushal has quit IRC12:39
strigazizhugaoxiao: you install magnum against devstack manually?12:40
strigazizhugaoxiao: you installed magnum against devstack manually?12:40
*** kushal has joined #openstack-containers12:41
*** kushal has quit IRC12:41
*** kushal has joined #openstack-containers12:55
*** yolanda has joined #openstack-containers12:57
openstackgerritThomas Goirand proposed openstack/magnum: Makes config file generation reproducible  https://review.openstack.org/35280613:00
*** jwcroppe has joined #openstack-containers13:00
*** zul_ has quit IRC13:00
*** vimal has joined #openstack-containers13:02
*** kushal has quit IRC13:02
*** zul_ has joined #openstack-containers13:06
*** kushal has joined #openstack-containers13:07
*** sdake has joined #openstack-containers13:08
*** sdake has quit IRC13:08
*** sdake has joined #openstack-containers13:08
*** julim has quit IRC13:14
*** sdake has quit IRC13:17
*** rlrossit has joined #openstack-containers13:19
*** sdake has joined #openstack-containers13:19
zhugaoxiaoyes13:20
zhugaoxiaohere is my local.conf13:22
zhugaoxiao[[local|localrc]]13:22
zhugaoxiaoADMIN_PASSWORD=admin13:22
zhugaoxiaoDATABASE_PASSWORD=$ADMIN_PASSWORD13:22
zhugaoxiaoRABBIT_PASSWORD=$ADMIN_PASSWORD13:22
zhugaoxiaoSERVICE_PASSWORD=$ADMIN_PASSWORD13:22
zhugaoxiaoSERVICE_TOKEN=$ADMIN_PASSWORD13:22
zhugaoxiaodisable_service n-net13:22
zhugaoxiaoenable_service neutron q-svc q-agt q-dhcp q-l3 q-meta13:22
zhugaoxiaoenable_service heat h-api h-api-cfn h-api-cw h-eng13:22
zhugaoxiaoenable_plugin barbican https://git.openstack.org/openstack/barbican  stable/mitaka13:22
zhugaoxiaoenable_plugin magnum https://git.openstack.org/openstack/magnum  stable/mitaka13:22
zhugaoxiaoenable_plugin magnum-ui https://git.openstack.org/openstack/magnum-ui  stable/mitaka13:22
*** sdake_ has joined #openstack-containers13:23
*** sdake has quit IRC13:24
strigazitry to configure iptables like so: https://github.com/openstack/magnum/blob/master/devstack/lib/magnum#L31613:24
zhugaoxiaook,thank you13:25
*** sergmelikyan has quit IRC13:28
*** sergmelikyan has joined #openstack-containers13:28
*** sergmelikyan has quit IRC13:28
*** yamamoto has joined #openstack-containers13:29
*** daneyon_ has joined #openstack-containers13:32
*** sergmelikyan has joined #openstack-containers13:33
*** yamamoto has quit IRC13:37
*** daneyon_ has quit IRC13:37
*** sergmelikyan has quit IRC13:44
*** ramishra has quit IRC13:45
openstackgerrityatin proposed openstack/magnum: Remove Invalid README.md for k8s  https://review.openstack.org/35291113:46
*** jwcroppe_ has joined #openstack-containers13:53
openstackgerrityatin proposed openstack/magnum: Remove Invalid README.md for mesos  https://review.openstack.org/35291313:53
*** jwcroppe has quit IRC13:55
*** julim has joined #openstack-containers13:57
*** tonanhngo has joined #openstack-containers13:57
*** tonanhngo has quit IRC13:58
*** hongbin has joined #openstack-containers13:59
*** anush_ has joined #openstack-containers14:00
*** sergmeli_ has joined #openstack-containers14:01
*** hieulq_ has joined #openstack-containers14:06
*** zz_dimtruck is now known as dimtruck14:06
*** mtanino has joined #openstack-containers14:09
*** syed_ has joined #openstack-containers14:09
strigaziHi hongbin14:13
hongbinstrigazi: hey14:13
strigaziI'd like to propose, setup a *voting* gate job which checks if the submitted patch decreases the test coverage14:14
hongbinsure14:15
strigaziAnd there for not accepting patches that don't have test coverage14:15
hongbinI think there is a non-voting job for that already?14:15
strigaziTrying to find it14:15
strigaziBut couldn't14:15
hongbinmagnum-coverage-ubuntu-xenial14:16
hongbinThis job reported coverage for each run14:16
hongbinIt is a non-voting thought14:17
hongbinI remembered some people proposed a similar idea. If the test coverage drops, mark the gate as failure14:18
strigazilet's discuss it in the meeting and if there is concensus make it voting14:18
hongbinok14:18
*** muralia_ has quit IRC14:19
*** muralia has joined #openstack-containers14:19
*** jwcroppe_ has quit IRC14:20
strigaziI've seen that even it's non voting this job always succeeds14:20
*** jwcroppe has joined #openstack-containers14:21
*** rlrossit has quit IRC14:23
*** muralia has quit IRC14:24
hongbinThis job just for reporting the coverage, not for marking anything to fail14:25
*** banix has joined #openstack-containers14:25
strigaziack14:27
strigaziI added to the agenda14:28
hieulq_Hi strigazi14:29
strigazihi14:30
hieulq_For the bug https://bugs.launchpad.net/magnum/+bug/153951614:30
openstackLaunchpad bug 1539516 in Magnum "Magnum service doesn't work if start multiple m-cond on same host" [Medium,New] - Assigned to Hieu LE (hieulq)14:30
*** sdake_ is now known as sdake14:30
hieulq_I have discussed with eliqiao and seems like this bug is invalid14:30
hieulq_Do you think this is OK strigazi ?14:30
strigaziyes14:31
strigazidone14:31
hieulq_Thank you strigazi14:31
hieulq_I think I will move to the low-hanging-fruit bug: increate the coverage of magnum14:32
hieulq_And I'm deploying prometheus and hipster in my lab as you recommend strigazi14:32
strigazibeware it's not that low hanging, There are many many tests missing14:32
hieulq_And I'm deploying prometheus and hipster in my lab as you recommend strigazi ?14:33
strigazigreat let us know how it goes14:33
hieulq_Sure14:34
hieulq_Do you think there are some bugs that do not have assignee that I can work with, strigazi ?14:34
hieulq_I just want to improve my experience with Magnum more14:34
*** tonanhngo has joined #openstack-containers14:34
strigazitests is the best way, but I'll check again14:35
hieulq_Ok, thanks again strigazi14:35
*** tonanhngo has quit IRC14:35
*** ramishra has joined #openstack-containers14:38
*** vimal has quit IRC14:38
*** subscope has joined #openstack-containers14:39
*** adrian_otto has joined #openstack-containers14:39
*** adrian_otto1 has joined #openstack-containers14:41
*** adrian_otto has quit IRC14:44
strigazimjura: ping14:45
mjuramjura: hi14:45
mjura:)14:45
mjurastrigazi: how is going for you today?14:45
mjurastrigazi: I'm waiting for Magnum meeting14:45
strigazigood, about the suse driver14:45
strigaziCurrently we don't load the drivers dynamically14:46
strigazibut14:46
mjurastrigazi: yes, tell me14:46
strigaziyou can move all the code from  magnum/drivers/k8s_opensuse_v1 to contib/drivers14:47
strigaziand then document in the README14:47
mjurastrigazi: ok,14:47
strigazithat a user must add it in the magnum.conf to use it14:47
mjurastrigazi: yes, but I'm worry about adding driver to magnum/drivers/common/template_def.py14:48
mjuraand to entry14:48
strigaziI think, this can me handled be the congig file14:49
strigaziI think, this can me handled by the congig file14:49
strigaziWe'll have to check14:49
mjurastrigazi: without patching this files, I'm not sure if this will work14:50
strigaziThe idea of bay drivers is exactly this14:50
mjuraand of course there are also some changes to tempest14:50
mjuraok14:50
strigaziTo add new drivers without patching anything14:50
mjurasounds good14:51
strigaziYou are trying to add your driver it in the right time14:51
mjurathank you this make me better14:51
strigaziWe actually now have a contrib driver14:51
*** srwilkers has joined #openstack-containers14:52
strigaziAnd if it's all good we can add it under magnum/drivers just before the release14:52
strigaziand ship it in newton14:52
mjurathen I will move opensuse driver to contrib/drivers/14:53
mjurastrigazi: do you have already idea how to implement this mechanism for dynamically drivers loading from contrib/drivers14:56
mjurastrigazi: I don't know if should think about this also14:56
*** sergmeli_ has quit IRC14:57
strigazimuralia is looking into that, and we want to be able to add new drivers from any directory14:57
mjurastrigazi: btw. how about tests? this should be also loaded from there14:57
*** muralia has joined #openstack-containers14:58
*** sergmelikyan has joined #openstack-containers14:59
*** praneshp has joined #openstack-containers15:01
*** tonanhngo has joined #openstack-containers15:01
*** banix has quit IRC15:01
*** sergmeli_ has joined #openstack-containers15:01
strigaziAt this point in magnum.conf you can add you driver in enabled_definitions15:01
hongbinstrigazi: For the class K8sTemplateDefinition, it is basically duplicated at every k8s drivers. Do you think if it is a good idea to move it to common dir?15:02
*** banix has joined #openstack-containers15:02
*** adrian_otto has joined #openstack-containers15:02
*** adrian_otto1 has quit IRC15:02
*** chandankumar has quit IRC15:03
strigaziI do, I was thinking about it, maybe create drivers/common/base_kubernetes or something like that15:03
*** adrian_otto has quit IRC15:04
hongbinYes, that would be grate15:04
hongbingreat15:04
strigaziWe should have discussed it in the midcycle :(15:05
hongbinThat is fine. This is trivial I think15:05
mjurastrigazi: last question, should I create blueprint even for adding k8s_opensuse driver in contrib/drivers directory?15:05
strigaziI think it's not that important, BUT15:06
*** adrian_otto has joined #openstack-containers15:06
strigaziyou better add some documentation in the README on how to install (when you test it) and what it provides15:07
strigaziit provides the same functionallity with kubernetes15:07
strigazi?15:07
strigaziI mean fedora_kubernetes15:07
strigaziWhat version of k8s in the driver?15:07
strigaziwhat network driver etc15:08
mjurastrigazi: yes, it provides full kubernetes functionality and we would like to develop and add new features too15:08
strigaziIs it comliant with both overlay and devicemapper?15:08
mjurastrigazi: I understood what do you mean15:09
mjurasound good for me15:09
mjurastrigazi: I think that there will be more, when I will adopt changes15:10
*** srwilkers has quit IRC15:11
*** Drago has joined #openstack-containers15:11
*** Drago has quit IRC15:11
*** Drago has joined #openstack-containers15:12
*** adrian_otto has quit IRC15:13
*** adrian_otto has joined #openstack-containers15:14
strigazimjura: Thanks for working on this. It will really help us develop the bay drivers feature15:17
mjurastrigazi: I thank you for answers and help, I'm big fan of K8s and Magnum15:18
*** egonzalez90 has joined #openstack-containers15:19
mjurastrigazi: I hope that I can help more with working on Magnum and other bugs and maybe new features15:19
strigazisure15:19
mjurastrigazi: I will try and join regularly to the Magnum meetings15:20
*** adrian_otto has quit IRC15:20
*** daneyon_ has joined #openstack-containers15:21
*** Drago has quit IRC15:21
egonzalez90Hi there!15:22
egonzalez90Is any specific kubectl version to use with magnum?15:22
egonzalez90As per quickstart docs, is used https://github.com/kubernetes/kubernetes/releases/download/v1.0.1/kubernetes.tar.gz15:23
*** srwilkers has joined #openstack-containers15:23
strigaziuse should use whaever version is in the image you use15:24
strigaziin atomic latest I think is 1.215:24
*** yamamoto has joined #openstack-containers15:25
*** yamamoto has quit IRC15:25
*** daneyon_ has quit IRC15:25
egonzalez90strigazi thanks for clarify me :)15:25
strigazinp15:26
strigazimjura: if you generate a magnum.conf.sample with tox -e genconfig15:27
strigaziyou will see15:27
strigazi# Enabled bay definition entry points. (list value)15:27
strigazi#enabled_definitions = magnum_vm_atomic_k8s,magnum_vm_coreos_k8s,magnum_vm_atomic_swarm,magnum_vm_ubuntu_mesos15:28
mjurastrigazi: ok, so you are saying that to enable this driver I have to it to the list15:28
strigaziI think in a running deployemnt you can add magnum_vm_opensuse_k8s and restart magnum15:28
*** hieulq_ has quit IRC15:29
mjuraand I don't have to modify entry_points15:29
*** kushal has quit IRC15:29
strigaziexactly15:29
mjurasounds perfect to me, I will test it right now15:29
strigazithis was working with heat_templates, maybe it works with drivers in the same way15:30
*** yamamoto has joined #openstack-containers15:31
*** banix has quit IRC15:32
*** chandankumar has joined #openstack-containers15:33
*** Drago has joined #openstack-containers15:33
*** banix has joined #openstack-containers15:35
*** belmoreira has quit IRC15:36
*** yamamoto has quit IRC15:36
*** yamamoto has joined #openstack-containers15:37
*** sergmeli_ has quit IRC15:41
*** sergmelikyan has joined #openstack-containers15:41
*** sergmelikyan has quit IRC15:46
*** pcaruana has quit IRC15:48
*** yamamoto has quit IRC15:48
*** vipulnayyar has joined #openstack-containers15:50
*** rcernin has quit IRC15:50
*** adrian_otto has joined #openstack-containers15:50
*** yamamoto has joined #openstack-containers15:50
*** fragatina has joined #openstack-containers15:51
*** adrian_otto has quit IRC15:51
*** adrian_otto has joined #openstack-containers15:51
*** adrian_otto has quit IRC15:52
*** mikelk has quit IRC15:53
*** yamamoto has quit IRC15:53
*** manikanta_tadi has joined #openstack-containers15:56
*** yamamoto has joined #openstack-containers15:56
*** hieulq_ has joined #openstack-containers15:57
*** adrian_otto has joined #openstack-containers15:57
hongbinAll team meeting will start in a minute15:59
*** mkrai has joined #openstack-containers16:00
*** yamamoto has quit IRC16:01
*** swatson has joined #openstack-containers16:01
*** eghobo has joined #openstack-containers16:02
*** banix has quit IRC16:02
*** daneyon_ has joined #openstack-containers16:03
*** adrian_otto has quit IRC16:04
*** kebray has joined #openstack-containers16:04
*** adrian_otto has joined #openstack-containers16:05
*** daneyon has quit IRC16:06
*** banix has joined #openstack-containers16:07
*** banix has quit IRC16:13
*** adrian_otto has quit IRC16:14
*** daneyon has joined #openstack-containers16:19
*** daneyon_ has quit IRC16:21
*** egonzalez90 has left #openstack-containers16:28
*** zenoway has quit IRC16:31
*** zenoway has joined #openstack-containers16:32
*** hieulq_ has quit IRC16:34
*** zenoway has quit IRC16:36
*** banix has joined #openstack-containers16:37
*** jmckind has joined #openstack-containers16:37
*** fragatin_ has joined #openstack-containers16:38
*** hieulq_ has joined #openstack-containers16:40
*** fragatina has quit IRC16:41
*** banix has quit IRC16:41
*** sergmelikyan has joined #openstack-containers16:46
*** adrian_otto has joined #openstack-containers16:46
*** subscope has quit IRC16:51
*** adrian_otto has quit IRC16:52
*** sergmeli_ has joined #openstack-containers16:55
*** hieulq_ has quit IRC16:57
*** sergmelikyan has quit IRC16:59
*** yamamoto has joined #openstack-containers16:59
*** anush_ has quit IRC17:00
*** manikanta_tadi has quit IRC17:00
strigazitonanhngo: you can see the untested lines in the cover dir17:00
strigazifor example: (finding the link)17:01
*** Drago has quit IRC17:01
tonanhngostrigazi:  I just wonder if we would get some pointers to where to fix by adding tests17:01
*** Drago has joined #openstack-containers17:01
strigazihttp://logs.openstack.org/28/348728/6/check/magnum-coverage-ubuntu-xenial/e32fb93/cover/magnum_api_controllers_v1_magnum_services_py.html17:01
*** Drago has quit IRC17:02
strigazithis change misses tests https://review.openstack.org/#/c/348728/17:02
*** tcammann has joined #openstack-containers17:02
*** Drago has joined #openstack-containers17:02
strigaziit can't be more clear :)17:02
*** yatin_ has joined #openstack-containers17:02
tonanhngook, so if I have some new codes, then the section needing more tests would be highlighted17:03
strigaziyes17:03
tonanhngoHow does it look now with the current code?17:03
tonanhngoa lot of gap?17:03
strigazibad :(17:03
*** yamamoto has quit IRC17:03
strigazithat file is 100%17:04
*** mkrai has quit IRC17:04
strigazibut in general we miss a lot17:04
DragoAt least it can't get any worse17:04
strigaziI can modify the job like in rally17:04
strigazito compare with the master branch17:04
strigaziand report both17:04
tonanhngoAnd this only covers python code, right?17:04
strigaziyes17:05
strigaziBut we can extend it, with some effort17:05
strigazito the shell scripts17:05
strigaziwhich are not tested at all17:05
tonanhngoyeah shell scripts would be hard to test17:05
tonanhngoso many way for them to fail17:05
strigaziDrago: is heat testsing their tempates somehow?17:06
strigaziDrago: is heat testing their templates somehow?17:06
*** Drago has quit IRC17:06
*** Drago1 has joined #openstack-containers17:07
*** Drago1 has quit IRC17:07
tonanhngoI think it's a good idea.  Maybe to make the switch not too abrupt, we can start with the review by giving -1 on patches with poor coverage.17:07
*** Drago has joined #openstack-containers17:07
DragoWow internet17:08
tonanhngoThis would help make it easier for reviewers in looking at unit tests17:08
Dragostrigazi: They don't really have templates to test, since they don't leverage themselves17:08
strigazitonanhngo: I'll modify the job to report fail but non-voting17:08
strigaziand in a month or two reconcider17:08
Dragostrigazi: but they test template snippets to make heat responds appropriately17:08
strigaziDrago: ack17:08
tonanhngo+117:08
*** eghobo has quit IRC17:09
strigaziDrago "they test template snippets", do you have an example?17:09
Drago*to make sure heat responds17:09
Dragosure, sec17:09
strigazimjura: around?17:11
Dragostrigazi: This is just the first example I found. I don't think it really applies to Magnum https://github.com/openstack/heat/blob/master/heat/tests/engine/service/test_stack_resources.py#L34-L5317:12
strigaziit doesn't, maybe a yaml parser to check that there are no syntax errors could be useful17:14
tonanhngoThe template validation in Heat should cover these in the functional tests.17:15
Dragostrigazi: Syntax validation doesn't get us much...17:16
Dragotonanhngo: +117:16
strigazitrue17:17
DragoPerhaps we could have some sort of unit tests that inspect the template files and ensure that particular resources, parameters, outputs, and configuration exist17:19
*** fragatin_ has quit IRC17:19
tcammannrewrite heat...17:20
tcammannFunctional tests should cover this, if they don't then that should be fixed17:20
DragoTo catch errors like this maybe https://review.openstack.org/#/c/352622/17:21
DragoYes, functional tests would catch that as well17:21
strigazi+1 to functional17:21
strigazicoreos has any?17:22
DragoI am just trying to find an analogue to unit tests in code17:22
strigazican't look right not it's 19h00 here17:22
*** tonanhngo has quit IRC17:23
strigazisee you tomorrow17:23
DragoBye strigazi17:24
*** zul_ has quit IRC17:30
*** yatin_ has quit IRC17:33
*** tcammann has quit IRC17:33
*** mkrai has joined #openstack-containers17:34
*** zul has joined #openstack-containers17:34
*** JoseMello has joined #openstack-containers17:35
*** zul has quit IRC17:40
*** pcaruana has joined #openstack-containers17:44
*** Drago has quit IRC17:46
*** Drago has joined #openstack-containers17:46
*** vipulnayyar has quit IRC17:50
*** mikelk has joined #openstack-containers17:51
*** zul has joined #openstack-containers17:53
*** mkrai has quit IRC17:53
*** mikelk has quit IRC17:54
Dragojvgrant: Hey17:55
jvgrantDrago: Hi17:56
Dragojvgrant: Want to talk about the NodeGroup spec today?17:56
jvgrantDrago: Sure, i could use a break from search and replace hell at some point :)17:57
Dragojvgrant: Okay. I'm finishing up lunch and will be free until 2, then 3-4:30 or so17:57
jvgrantDrago: i'll be heading out to lunch in a little bit(2 hours behind in AZ), 3 pm your time should work for me17:58
Dragojvgrant: Oh, I'll keep that in mind. AZ is Pacific time?17:59
jvgrantjvgrant: yep, for now, we match up with PST17:59
jvgrantjvgrant: AZ doesn't have daylight savings time, so we switch timezones when everyone else changes18:00
jvgrantjvgrant: but until Oct. we are aligned with PST18:00
DragoAhhh18:01
openstackgerritMurali Allada proposed openstack/magnum: Remove unused Pod, Service and Container references  https://review.openstack.org/35304818:03
*** daneyon_ has joined #openstack-containers18:03
*** daneyon_ has quit IRC18:08
*** sergmeli_ has quit IRC18:09
*** sergmelikyan has joined #openstack-containers18:11
*** fragatina has joined #openstack-containers18:16
*** sergmelikyan has quit IRC18:23
*** eghobo has joined #openstack-containers18:25
*** fragatina has quit IRC18:29
*** fragatina has joined #openstack-containers18:30
*** achanda has joined #openstack-containers18:34
*** sergmelikyan has joined #openstack-containers18:36
*** sergmelikyan has quit IRC18:39
*** sergmelikyan has joined #openstack-containers18:39
*** david-lyle has quit IRC18:41
*** david-lyle has joined #openstack-containers18:42
*** sergmeli_ has joined #openstack-containers18:42
*** sergmelikyan has quit IRC18:42
*** sergmeli_ has quit IRC18:43
*** ihm has joined #openstack-containers18:45
ihmcan someone from magnum-ui team please review my patch ? https://review.openstack.org/#/c/352728/ this fixes the SSL error when trying to connect to magnumclient over https18:46
*** rcernin has joined #openstack-containers18:51
*** Drago has quit IRC19:01
*** Drago has joined #openstack-containers19:01
*** eghobo has quit IRC19:07
*** tonanhngo has joined #openstack-containers19:11
*** achanda has quit IRC19:19
*** chandankumar has quit IRC19:27
*** srwilkers has quit IRC19:37
*** david-lyle_ has joined #openstack-containers19:41
*** david-lyle has quit IRC19:43
*** shubhams has quit IRC19:47
*** eghobo has joined #openstack-containers19:50
*** daneyon_ has joined #openstack-containers19:52
*** daneyon_ has quit IRC19:56
*** achanda has joined #openstack-containers20:04
Dragojvgrant: ping20:04
*** kebray has quit IRC20:05
jvgrantDrago: hi20:07
Dragojvgrant: Want to jump on vidyo?20:08
jvgrantDrago: sure, send me the link20:08
Dragojvgrant: Sent in a direct message20:09
jvgrantDrago: thanks, calling in20:10
*** julim has quit IRC20:11
*** david-lyle_ is now known as david-lyle20:12
*** dfflanders has joined #openstack-containers20:35
*** muralia has quit IRC20:40
*** muralia has joined #openstack-containers20:40
*** tonanhngo has quit IRC20:43
*** eghobo has quit IRC20:51
*** tonanhngo has joined #openstack-containers20:53
*** tonanhngo has quit IRC20:53
*** tonanhngo has joined #openstack-containers20:53
*** abelur has joined #openstack-containers20:55
*** yamamoto has joined #openstack-containers21:09
*** yamamoto has quit IRC21:13
*** yamamoto has joined #openstack-containers21:13
*** yamamoto has quit IRC21:13
*** yamamoto has joined #openstack-containers21:15
*** yamamoto has quit IRC21:15
*** eghobo has joined #openstack-containers21:27
*** zigo has quit IRC21:32
*** ihm has quit IRC21:33
*** zigo has joined #openstack-containers21:35
*** achanda has quit IRC21:37
*** muralia has quit IRC21:37
*** julim has joined #openstack-containers21:40
*** jmckind has quit IRC21:41
*** sdake has quit IRC21:57
*** yamamoto has joined #openstack-containers21:59
*** rcernin has quit IRC22:02
*** dimtruck is now known as zz_dimtruck22:06
harlowjaqq, does anyone know where (which TZ) kfox1111 is in?22:07
*** dave-mccowan has quit IRC22:08
*** muralia has joined #openstack-containers22:22
*** Drago has quit IRC22:29
*** sdake has joined #openstack-containers22:30
*** sdake has quit IRC22:30
*** sdake has joined #openstack-containers22:30
*** fragatin_ has joined #openstack-containers22:33
*** sdake_ has joined #openstack-containers22:33
*** daneyon_ has joined #openstack-containers22:34
*** sdake has quit IRC22:34
*** fragatina has quit IRC22:36
*** daneyon_ has quit IRC22:38
*** sdake_ is now known as sdake22:38
*** eghobo has quit IRC22:52
*** yamamoto has quit IRC22:52
*** eghobo has joined #openstack-containers22:53
*** eghobo has quit IRC22:59
*** JoseMello has quit IRC23:00
*** yamamoto has joined #openstack-containers23:05
*** yamamoto has quit IRC23:05
*** yamamoto has joined #openstack-containers23:07
*** yamamoto has quit IRC23:11
*** yamamoto has joined #openstack-containers23:11
*** yamamoto has quit IRC23:11
*** yamamoto has joined #openstack-containers23:15
*** david-lyle has quit IRC23:20
*** yamamoto has quit IRC23:20
*** spedione is now known as spedione|AWAY23:26
*** yamamoto has joined #openstack-containers23:27
*** yamamoto has quit IRC23:27
*** swatson_ has joined #openstack-containers23:38
*** david-lyle has joined #openstack-containers23:38
*** sdake has quit IRC23:45

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!