| *** eghobo has quit IRC | 00:01 | |
| *** achanda_ has joined #openstack-containers | 00:02 | |
| *** adrian_otto has quit IRC | 00:05 | |
| *** eghobo has joined #openstack-containers | 00:05 | |
| *** achanda has quit IRC | 00:06 | |
| *** achanda_ has quit IRC | 00:08 | |
| Tango | sdake: I can scp to fedora now, uploading the image. Thanks Steve. | 00:09 |
|---|---|---|
| *** Qiming has quit IRC | 00:17 | |
| *** daneyon_ has quit IRC | 00:19 | |
| *** harshs has joined #openstack-containers | 00:21 | |
| *** jruano has quit IRC | 00:23 | |
| *** suro-patz has quit IRC | 00:24 | |
| *** vilobhmm_11 has quit IRC | 00:29 | |
| *** vilobhmm_11 has joined #openstack-containers | 00:29 | |
| *** vilobhmm_11 has quit IRC | 00:33 | |
| *** annegentle has joined #openstack-containers | 00:34 | |
| *** Tango has quit IRC | 00:34 | |
| *** dims_ has joined #openstack-containers | 00:38 | |
| *** banix has joined #openstack-containers | 00:40 | |
| *** david-lyle has quit IRC | 00:40 | |
| *** jruano has joined #openstack-containers | 00:42 | |
| *** juggler_ has joined #openstack-containers | 00:43 | |
| *** dims_ has quit IRC | 00:43 | |
| *** dims_ has joined #openstack-containers | 00:43 | |
| *** david-lyle has joined #openstack-containers | 00:44 | |
| *** juggler_ has quit IRC | 00:45 | |
| *** juggler_ has joined #openstack-containers | 00:45 | |
| *** juggler_ has quit IRC | 00:48 | |
| *** juggler has joined #openstack-containers | 00:49 | |
| *** juggler has quit IRC | 00:50 | |
| *** hongbin has joined #openstack-containers | 00:58 | |
| *** juggler has joined #openstack-containers | 01:02 | |
| *** banix has quit IRC | 01:02 | |
| *** erkules_ has joined #openstack-containers | 01:05 | |
| *** erkules has quit IRC | 01:08 | |
| *** ganeshna has joined #openstack-containers | 01:10 | |
| *** annegentle has quit IRC | 01:10 | |
| *** wenchma has quit IRC | 01:18 | |
| *** banix has joined #openstack-containers | 01:18 | |
| *** Qiming has joined #openstack-containers | 01:21 | |
| *** ganeshna has quit IRC | 01:22 | |
| *** banix has quit IRC | 01:24 | |
| *** apuimedo has quit IRC | 01:25 | |
| *** shuquan has joined #openstack-containers | 01:25 | |
| *** dims_ has quit IRC | 01:27 | |
| *** sthillma has quit IRC | 01:27 | |
| *** dims_ has joined #openstack-containers | 01:29 | |
| *** lyanchih has joined #openstack-containers | 01:36 | |
| *** dims_ has quit IRC | 01:37 | |
| *** zz_dimtruck is now known as dimtruck | 01:43 | |
| *** julim has joined #openstack-containers | 01:45 | |
| *** gangil1 has quit IRC | 01:45 | |
| *** unicell has quit IRC | 01:46 | |
| *** puranamr has joined #openstack-containers | 02:07 | |
| *** suro-patz has joined #openstack-containers | 02:09 | |
| *** sdake_ has joined #openstack-containers | 02:09 | |
| *** banix has joined #openstack-containers | 02:13 | |
| *** sdake has quit IRC | 02:13 | |
| openstackgerrit | Hua Wang proposed openstack/magnum: Code refactor for keystoneclient https://review.openstack.org/218699 | 02:19 |
| *** eghobo has quit IRC | 02:22 | |
| *** suro-patz has quit IRC | 02:23 | |
| *** jruano has quit IRC | 02:27 | |
| *** achanda has joined #openstack-containers | 02:28 | |
| openstackgerrit | Hua Wang proposed openstack/magnum: Add registry to template https://review.openstack.org/223526 | 02:28 |
| *** zhenguo has joined #openstack-containers | 02:28 | |
| *** hongbin has quit IRC | 02:31 | |
| *** jruano has joined #openstack-containers | 02:32 | |
| *** humble_ has joined #openstack-containers | 02:33 | |
| *** humble__ has quit IRC | 02:37 | |
| *** suro-patz has joined #openstack-containers | 02:38 | |
| *** ganeshna has joined #openstack-containers | 02:40 | |
| *** gangil has joined #openstack-containers | 02:42 | |
| *** julim has quit IRC | 02:43 | |
| *** deepthi has joined #openstack-containers | 02:56 | |
| *** harshs has quit IRC | 02:59 | |
| *** lyanchih has quit IRC | 03:00 | |
| *** yuanying_ has joined #openstack-containers | 03:02 | |
| *** lyanchih has joined #openstack-containers | 03:06 | |
| *** shuquan has quit IRC | 03:15 | |
| *** ganeshna has quit IRC | 03:18 | |
| *** ganeshna has joined #openstack-containers | 03:19 | |
| *** dims_ has joined #openstack-containers | 03:22 | |
| *** fawadkhaliq has joined #openstack-containers | 03:26 | |
| *** achanda has quit IRC | 03:27 | |
| *** sdake has joined #openstack-containers | 03:28 | |
| *** dims_ has quit IRC | 03:28 | |
| *** sthillma has joined #openstack-containers | 03:32 | |
| *** sdake_ has quit IRC | 03:32 | |
| *** harshs has joined #openstack-containers | 03:33 | |
| *** sthillma_ has joined #openstack-containers | 03:34 | |
| *** sthillma has quit IRC | 03:36 | |
| *** sthillma_ is now known as sthillma | 03:36 | |
| *** sdake_ has joined #openstack-containers | 03:38 | |
| *** sdake_ has quit IRC | 03:39 | |
| *** sdake_ has joined #openstack-containers | 03:40 | |
| *** sdake_ has quit IRC | 03:40 | |
| *** sdake_ has joined #openstack-containers | 03:40 | |
| *** VikasC has joined #openstack-containers | 03:41 | |
| *** sdake has quit IRC | 03:41 | |
| *** suro-patz has quit IRC | 03:42 | |
| *** puranamr has quit IRC | 03:45 | |
| *** jruano has quit IRC | 03:48 | |
| *** sdake_ is now known as sdake | 03:48 | |
| *** madhuri has joined #openstack-containers | 03:49 | |
| *** yuanying_ has quit IRC | 03:54 | |
| *** unicell has joined #openstack-containers | 03:57 | |
| *** eghobo has joined #openstack-containers | 04:00 | |
| *** EricGonczer_ has joined #openstack-containers | 04:01 | |
| *** eghobo_ has joined #openstack-containers | 04:02 | |
| openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Functional tests with Tempest - BayModel CRUD https://review.openstack.org/224170 | 04:02 |
| *** EricGonczer_ has quit IRC | 04:03 | |
| *** eghobo has quit IRC | 04:05 | |
| *** gangil has quit IRC | 04:05 | |
| *** yuanying_ has joined #openstack-containers | 04:06 | |
| *** Tango has joined #openstack-containers | 04:07 | |
| openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Functional tests with Tempest - BayModel CRUD https://review.openstack.org/224170 | 04:08 |
| *** sthillma has quit IRC | 04:13 | |
| *** lyanchih has quit IRC | 04:15 | |
| *** tbh has joined #openstack-containers | 04:16 | |
| *** puranamr has joined #openstack-containers | 04:16 | |
| *** yuanying_ has quit IRC | 04:19 | |
| *** yuanying_ has joined #openstack-containers | 04:20 | |
| *** puranamr has quit IRC | 04:20 | |
| *** harshs has quit IRC | 04:29 | |
| *** banix has quit IRC | 04:35 | |
| *** vimal has joined #openstack-containers | 04:37 | |
| *** dimtruck is now known as zz_dimtruck | 04:39 | |
| *** chandankumar has joined #openstack-containers | 04:40 | |
| *** achanda has joined #openstack-containers | 04:40 | |
| *** tbh has quit IRC | 04:43 | |
| *** tbh has joined #openstack-containers | 04:44 | |
| *** yuanying_ has quit IRC | 04:45 | |
| *** fawadkhaliq has quit IRC | 04:50 | |
| *** yuanying_ has joined #openstack-containers | 04:52 | |
| *** harshs has joined #openstack-containers | 04:55 | |
| *** lyanchih has joined #openstack-containers | 04:55 | |
| *** tbh has quit IRC | 04:56 | |
| *** sthillma has joined #openstack-containers | 04:59 | |
| *** lyanchih has quit IRC | 05:00 | |
| *** tbh has joined #openstack-containers | 05:05 | |
| *** vimal has quit IRC | 05:06 | |
| *** yuanying_ has quit IRC | 05:15 | |
| *** fawadkhaliq has joined #openstack-containers | 05:17 | |
| *** harshs has quit IRC | 05:22 | |
| *** coolsvap|holiday is now known as coolsvap | 05:28 | |
| *** vimal has joined #openstack-containers | 05:28 | |
| *** ganeshna has quit IRC | 05:29 | |
| *** ganeshna has joined #openstack-containers | 05:29 | |
| *** Marga_ has quit IRC | 05:30 | |
| *** openstackgerrit has quit IRC | 05:31 | |
| *** openstackgerrit has joined #openstack-containers | 05:31 | |
| *** Qiming has quit IRC | 05:31 | |
| *** muralia has quit IRC | 05:37 | |
| *** muralia has joined #openstack-containers | 05:39 | |
| *** sthillma has quit IRC | 05:41 | |
| *** klindgren has quit IRC | 05:45 | |
| *** lyanchih has joined #openstack-containers | 05:45 | |
| *** klindgren has joined #openstack-containers | 05:45 | |
| *** vilobhmm_11 has joined #openstack-containers | 05:48 | |
| *** Marga_ has joined #openstack-containers | 05:48 | |
| *** sdake has quit IRC | 05:49 | |
| *** Marga_ has quit IRC | 05:49 | |
| *** puranamr has joined #openstack-containers | 05:59 | |
| *** klindgren has quit IRC | 06:02 | |
| *** eghobo has joined #openstack-containers | 06:04 | |
| *** puranamr has quit IRC | 06:04 | |
| *** eghobo_ has quit IRC | 06:07 | |
| *** klindgren has joined #openstack-containers | 06:07 | |
| *** Marga_ has joined #openstack-containers | 06:10 | |
| *** Marga_ has quit IRC | 06:16 | |
| *** Marga_ has joined #openstack-containers | 06:17 | |
| *** tbh has quit IRC | 06:27 | |
| madhuri | apmelton: there? | 06:28 |
| *** Tango has quit IRC | 06:38 | |
| *** tbh has joined #openstack-containers | 06:40 | |
| *** curx1 has joined #openstack-containers | 06:44 | |
| *** yuanying_ has joined #openstack-containers | 06:47 | |
| *** achanda has quit IRC | 06:57 | |
| *** Marga_ has quit IRC | 06:59 | |
| *** Marga_ has joined #openstack-containers | 07:00 | |
| *** tbh has quit IRC | 07:12 | |
| *** Marga_ has quit IRC | 07:14 | |
| *** VikasC has quit IRC | 07:20 | |
| *** ganeshna has quit IRC | 07:30 | |
| *** fawadkhaliq has quit IRC | 07:30 | |
| *** ganeshna has joined #openstack-containers | 07:30 | |
| *** yuanying_ has quit IRC | 07:33 | |
| *** Marga_ has joined #openstack-containers | 07:35 | |
| *** Marga_ has quit IRC | 07:35 | |
| *** Marga_ has joined #openstack-containers | 07:35 | |
| *** fawadkhaliq has joined #openstack-containers | 07:36 | |
| *** erkules_ is now known as erkules | 07:51 | |
| *** erkules has joined #openstack-containers | 07:51 | |
| *** eghobo has quit IRC | 07:54 | |
| *** chandankumar has quit IRC | 07:57 | |
| *** VikasC has joined #openstack-containers | 07:59 | |
| *** tbh has joined #openstack-containers | 07:59 | |
| *** vilobhmm_11 has quit IRC | 08:04 | |
| *** lyanchih has quit IRC | 08:16 | |
| *** tbh has quit IRC | 08:20 | |
| *** tbh has joined #openstack-containers | 08:21 | |
| *** alex_klimov has joined #openstack-containers | 08:27 | |
| *** alex_klimov has quit IRC | 08:30 | |
| *** alex_klimov has joined #openstack-containers | 08:30 | |
| *** dims_ has joined #openstack-containers | 08:30 | |
| *** dims_ has quit IRC | 08:34 | |
| *** VikasC has quit IRC | 08:39 | |
| *** diga has joined #openstack-containers | 08:42 | |
| openstackgerrit | James Page proposed openstack/python-magnumclient: Add support for python >= 3.4 https://review.openstack.org/224565 | 08:45 |
| *** lyanchih has joined #openstack-containers | 08:52 | |
| *** yuanying_ has joined #openstack-containers | 08:55 | |
| *** yuanying_ has quit IRC | 08:59 | |
| *** ganeshna has quit IRC | 09:04 | |
| *** shuquan has joined #openstack-containers | 09:05 | |
| *** ganeshna has joined #openstack-containers | 09:06 | |
| *** yuanying_ has joined #openstack-containers | 09:13 | |
| *** yuanying_ has quit IRC | 09:19 | |
| *** yuanying_ has joined #openstack-containers | 09:21 | |
| *** diga has quit IRC | 09:21 | |
| *** curx1 has left #openstack-containers | 09:24 | |
| *** meehanman has joined #openstack-containers | 09:27 | |
| *** dims_ has joined #openstack-containers | 09:32 | |
| *** dims_ has quit IRC | 09:36 | |
| *** madhuri has quit IRC | 09:38 | |
| *** tbh has quit IRC | 09:39 | |
| *** yuanying_ has quit IRC | 09:41 | |
| *** tbh has joined #openstack-containers | 09:46 | |
| *** dims_ has joined #openstack-containers | 09:50 | |
| *** zhenguo has quit IRC | 09:50 | |
| *** shuquan has quit IRC | 09:54 | |
| *** lyanchih has quit IRC | 09:57 | |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Fix H405 and E131 ignored pep8 rules https://review.openstack.org/224183 | 09:59 |
| *** tbh has quit IRC | 09:59 | |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Use --max-complexity flake8 rule https://review.openstack.org/224184 | 10:02 |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Fix E251 unnecessarily ignored pep8 rule https://review.openstack.org/224198 | 10:02 |
| *** yuanying_ has joined #openstack-containers | 10:09 | |
| *** tbh has joined #openstack-containers | 10:10 | |
| *** fawadkhaliq has quit IRC | 10:15 | |
| *** alex_klimov has quit IRC | 10:24 | |
| *** lyanchih has joined #openstack-containers | 10:32 | |
| *** tbh has quit IRC | 10:32 | |
| *** tbh has joined #openstack-containers | 10:37 | |
| *** lyanchih has quit IRC | 10:48 | |
| *** yuanying_ has quit IRC | 10:48 | |
| *** tbh has quit IRC | 10:51 | |
| *** fawadkhaliq has joined #openstack-containers | 10:55 | |
| *** alex_klimov has joined #openstack-containers | 10:59 | |
| *** mfalatic has quit IRC | 11:00 | |
| *** meehanman has quit IRC | 11:01 | |
| *** tbh has joined #openstack-containers | 11:03 | |
| *** mfalatic has joined #openstack-containers | 11:06 | |
| *** tbh has quit IRC | 11:08 | |
| *** alex_klimov has quit IRC | 11:09 | |
| *** alex_klimov has joined #openstack-containers | 11:09 | |
| *** lyanchih has joined #openstack-containers | 11:20 | |
| *** lyanchih has quit IRC | 11:25 | |
| *** ganeshna has quit IRC | 11:25 | |
| *** tbh has joined #openstack-containers | 11:27 | |
| *** klindgren has quit IRC | 11:36 | |
| *** klindgren has joined #openstack-containers | 11:43 | |
| *** tbh has quit IRC | 11:48 | |
| *** rpothier has joined #openstack-containers | 12:00 | |
| *** kebray has joined #openstack-containers | 12:00 | |
| *** yuanying_ has joined #openstack-containers | 12:01 | |
| *** puranamr has joined #openstack-containers | 12:02 | |
| *** deepthi has quit IRC | 12:04 | |
| *** puranamr has quit IRC | 12:06 | |
| *** yuanying_ has quit IRC | 12:20 | |
| *** banix has joined #openstack-containers | 12:28 | |
| openstackgerrit | Merged openstack/magnum: Fix naming of variables/classes in tests https://review.openstack.org/224291 | 12:29 |
| openstackgerrit | Merged openstack/magnum: Refactors Heat templates for Container Networking Model https://review.openstack.org/214762 | 12:30 |
| openstackgerrit | Merged openstack/python-magnumclient: Updated from global requirements https://review.openstack.org/224674 | 12:30 |
| openstackgerrit | Merged openstack/magnum: Adds network_driver Support of Container Network Model https://review.openstack.org/214909 | 12:32 |
| *** zz_dimtruck is now known as dimtruck | 12:39 | |
| *** julim has joined #openstack-containers | 12:39 | |
| *** rpothier has quit IRC | 12:40 | |
| openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Functional tests with Tempest - BayModel CRUD https://review.openstack.org/224170 | 12:40 |
| *** fawadkhaliq has quit IRC | 12:50 | |
| *** alex_klimov has quit IRC | 12:50 | |
| *** rlrossit has joined #openstack-containers | 12:52 | |
| *** dimtruck is now known as zz_dimtruck | 12:55 | |
| *** fawadkhaliq has joined #openstack-containers | 12:59 | |
| *** puranamr has joined #openstack-containers | 13:03 | |
| *** alex_klimov has joined #openstack-containers | 13:06 | |
| *** puranamr has quit IRC | 13:07 | |
| *** zz_dimtruck is now known as dimtruck | 13:20 | |
| *** banix has quit IRC | 13:21 | |
| *** banix has joined #openstack-containers | 13:22 | |
| *** harshs has joined #openstack-containers | 13:25 | |
| rlrossit | dimtruck: here's an example for doing abstract base classes https://github.com/openstack/nova/blob/master/nova/conductor/tasks/base.py#L31-L32 | 13:28 |
| rlrossit | I always have to look it up too | 13:28 |
| dimtruck | :) rlrossit that's what i did hahah...took me forever | 13:28 |
| rlrossit | we need to use six to add the metaclass or else pep8 (or hacking) gets mad at us | 13:28 |
| dimtruck | https://review.openstack.org/#/c/224170/15/magnum/tests/functional/common/client.py | 13:29 |
| *** dimtruck is now known as zz_dimtruck | 13:39 | |
| *** kebray has quit IRC | 13:42 | |
| *** zhenguo has joined #openstack-containers | 13:43 | |
| *** _navneet has joined #openstack-containers | 13:44 | |
| *** openstackgerrit has quit IRC | 13:46 | |
| *** openstackgerrit has joined #openstack-containers | 13:46 | |
| *** hongbin has joined #openstack-containers | 13:49 | |
| *** zz_dimtruck is now known as dimtruck | 13:55 | |
| *** rpothier has joined #openstack-containers | 13:58 | |
| *** kebray has joined #openstack-containers | 13:59 | |
| *** davhou has joined #openstack-containers | 14:00 | |
| dimtruck | rlrossit: so are you cool with the other assertion that basically checks if the error has been raised or are you thinking that both should just check on assertRaises? | 14:15 |
| *** fawadkhaliq has quit IRC | 14:15 | |
| dimtruck | what i'm thinking is i can just remove those 2 assert_exception messages altogether and like you mentioned, just do assertRaises and check the exception type | 14:15 |
| *** eghobo has joined #openstack-containers | 14:16 | |
| *** eghobo has quit IRC | 14:17 | |
| *** dims_ has quit IRC | 14:20 | |
| *** dims_ has joined #openstack-containers | 14:21 | |
| *** sdake has joined #openstack-containers | 14:27 | |
| *** banix has quit IRC | 14:29 | |
| *** Qiming has joined #openstack-containers | 14:30 | |
| *** adrian_otto has joined #openstack-containers | 14:30 | |
| *** david-lyle has quit IRC | 14:31 | |
| *** agireud has quit IRC | 14:35 | |
| *** agireud has joined #openstack-containers | 14:37 | |
| *** kebray has quit IRC | 14:40 | |
| *** banix has joined #openstack-containers | 14:42 | |
| openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Functional tests with Tempest - BayModel CRUD https://review.openstack.org/224170 | 14:42 |
| *** alex_klimov has quit IRC | 14:42 | |
| *** hongbin has quit IRC | 14:45 | |
| *** hongbin_ has joined #openstack-containers | 14:45 | |
| *** adrian_otto has quit IRC | 14:47 | |
| *** adrian_otto has joined #openstack-containers | 14:47 | |
| *** zhenguo has quit IRC | 14:48 | |
| *** adrian_otto has quit IRC | 14:48 | |
| *** adrian_otto has joined #openstack-containers | 14:48 | |
| *** kebray has joined #openstack-containers | 14:52 | |
| *** harshs has quit IRC | 14:54 | |
| *** kebray has quit IRC | 14:54 | |
| *** harshs has joined #openstack-containers | 14:55 | |
| *** kebray has joined #openstack-containers | 14:55 | |
| *** ganeshna has joined #openstack-containers | 14:56 | |
| *** manjeets has joined #openstack-containers | 14:57 | |
| openstackgerrit | Merged openstack/python-magnumclient: Adds Container Network Model network_driver support https://review.openstack.org/222749 | 14:59 |
| openstackgerrit | Merged openstack/python-magnumclient: Adds Labels Support https://review.openstack.org/215260 | 14:59 |
| *** dims_ is now known as dimsum__ | 15:03 | |
| *** harshs has quit IRC | 15:03 | |
| *** Drago has joined #openstack-containers | 15:03 | |
| *** Drago has quit IRC | 15:03 | |
| *** Drago has joined #openstack-containers | 15:04 | |
| *** eghobo has joined #openstack-containers | 15:05 | |
| rlrossit | dimtruck: After looking at it, what I would like to see is asserting the exception type and check the return code, not the message | 15:06 |
| rlrossit | it would be nice to see when return codes are changing | 15:06 |
| dimtruck | so in tempest.exceptions exception type matches the return code 1 to 1 | 15:06 |
| dimtruck | so would we be cool with just checking the exception type then? | 15:07 |
| dimtruck | since exception.NOT_FOUND would always equal 404 | 15:07 |
| rlrossit | so wait, how are return codes determined when they are raised? | 15:08 |
| rlrossit | because while not found will always be 404, I want to be sure we are seeing when something changes from like a 408 to a 406 (totally made up) | 15:08 |
| dimtruck | I changed it to self.assertRaises(NotFound, magnum_api_call) | 15:09 |
| dimtruck | that way if it's a 409, for exampl,e it would raise Conflict | 15:09 |
| dimtruck | so assertRaises would fail | 15:10 |
| *** Tango has joined #openstack-containers | 15:10 | |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: Docs update for new fedora atomic 1.0.4 https://review.openstack.org/221504 | 15:11 |
| openstackgerrit | Merged openstack/magnum: Updated from global requirements https://review.openstack.org/224622 | 15:15 |
| *** Drago has quit IRC | 15:16 | |
| *** fawadkhaliq has joined #openstack-containers | 15:16 | |
| *** alex_klimov has joined #openstack-containers | 15:20 | |
| *** fawadkhaliq has quit IRC | 15:20 | |
| *** fawadkhaliq has joined #openstack-containers | 15:27 | |
| *** Drago has joined #openstack-containers | 15:35 | |
| *** harshs has joined #openstack-containers | 15:44 | |
| *** tbh has joined #openstack-containers | 15:45 | |
| *** vimal has quit IRC | 15:47 | |
| *** Marga_ has quit IRC | 15:48 | |
| *** vimal has joined #openstack-containers | 15:51 | |
| *** banix has quit IRC | 15:52 | |
| *** gangil has joined #openstack-containers | 15:52 | |
| *** EricGonczer_ has joined #openstack-containers | 16:00 | |
| *** EricGonczer_ has quit IRC | 16:00 | |
| *** vimal has quit IRC | 16:01 | |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: WIP: Add Functional Tests for mesos cluster https://review.openstack.org/225212 | 16:03 |
| *** ganeshna has quit IRC | 16:05 | |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: WIP: Add Functional Tests for mesos cluster https://review.openstack.org/225212 | 16:05 |
| *** puranamr has joined #openstack-containers | 16:05 | |
| *** ganeshna has joined #openstack-containers | 16:06 | |
| *** Qiming has quit IRC | 16:07 | |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: WIP: Add Functional Tests for mesos cluster https://review.openstack.org/225212 | 16:08 |
| *** unicell has quit IRC | 16:09 | |
| *** ganeshna has quit IRC | 16:09 | |
| *** ganeshna has joined #openstack-containers | 16:09 | |
| *** alex_klimov has quit IRC | 16:09 | |
| *** EricGonczer_ has joined #openstack-containers | 16:10 | |
| *** Marga_ has joined #openstack-containers | 16:17 | |
| *** mfalatic has quit IRC | 16:17 | |
| *** puranamr has quit IRC | 16:18 | |
| *** EricGonczer_ has quit IRC | 16:18 | |
| sdake | Tango ping | 16:20 |
| Tango | sdake: Hi Steve | 16:20 |
| sdake | tango did you manage to get your credentials sorted out? | 16:20 |
| *** mfalatic has joined #openstack-containers | 16:20 | |
| Tango | sdake: yep it worked, just took some time | 16:20 |
| sdake | wer eou able to upload? | 16:21 |
| Tango | sdake: Yes I uploaded the new image | 16:21 |
| sdake | after you upload you generally have to chmod 664 the image | 16:21 |
| sdake | rather 644 the image | 16:21 |
| Tango | sdake: ah ok, let me do that. Should we clean up the old ones? | 16:21 |
| sdake | no please dont do that | 16:21 |
| sdake | we should keep all old images because people may sitll be loading them | 16:22 |
| *** ganeshna_ has joined #openstack-containers | 16:22 | |
| sdake | also if we could follow a basic atomic-1/atomic-2/atomic-3 and not have extra stuff int he image name that might be helpful | 16:22 |
| sdake | when i see extra stuff in the image name its confusing | 16:22 |
| Tango | ok, I am debating whether to just replace the #5 | 16:22 |
| Tango | instead of naming the new one 5-LB | 16:23 |
| sdake | ideally we want to be in a world where we only provide implementations against the latet image | 16:23 |
| sdake | is the current 5 doa? | 16:23 |
| sdake | I'd just call it -6 :) | 16:23 |
| Tango | We have been testing against 5 and it works fine | 16:23 |
| sdake | think of images like a tag in a repo - undeleteable ;) | 16:23 |
| sdake | the lb works fine? | 16:23 |
| sdake | or the image works | 16:23 |
| *** ganeshna has quit IRC | 16:24 | |
| Tango | #5 has k8s version 1.0.4 and it works fine, but the LB part doesn't work because of bugs | 16:24 |
| sdake | fantastic ;) | 16:24 |
| *** suro-patz has joined #openstack-containers | 16:24 | |
| sdake | hey suro-patz | 16:24 |
| Tango | the new one also is same as #5 except the LB part works | 16:24 |
| sdake | oh nice they finally go thte lb working ? | 16:25 |
| sdake | nice job sticking with it tango :) | 16:25 |
| sdake | just to clarify, is image building still busted in some subtle way? | 16:25 |
| Tango | There are still issues to work through, but at least the basic functionality works | 16:25 |
| Tango | So now we can do wordpress :) | 16:25 |
| sdake | sweet - we have arrived | 16:25 |
| *** mfalatic_ has joined #openstack-containers | 16:26 | |
| Tango | So let me ask your thought on this one issue | 16:26 |
| *** ganeshna has joined #openstack-containers | 16:26 | |
| sdake | shoot | 16:27 |
| Tango | The k8s backend uses Rackspace gophercloud to talk to OpenStack | 16:27 |
| suro-patz | sdake:hello | 16:27 |
| sdake | what is gophercloud | 16:27 |
| Tango | It's a code repo that wraps OpenStack with additional functionalities | 16:28 |
| *** ganeshna_ has quit IRC | 16:28 | |
| sdake | so magnum is dependent on gophercloud now? | 16:28 |
| Tango | https://github.com/rackspace/gophercloud/ | 16:28 |
| *** fawadkhaliq has quit IRC | 16:28 | |
| Tango | Kubernetes does | 16:29 |
| *** Marga_ has quit IRC | 16:29 | |
| Tango | it's built into k8s binaries | 16:29 |
| sdake | oh got it | 16:29 |
| sdake | i just ooked at hte repo | 16:29 |
| sdake | ok that dep looks fine to me, no issues | 16:29 |
| sdake | I thought we somehow slipped an entire new dependency into magnum :) | 16:30 |
| Tango | So the gophercloud code autenticates with OpenStack by using credentials from a config file that we have to set up | 16:30 |
| *** mfalatic has quit IRC | 16:30 | |
| sdake | i recall that | 16:30 |
| Tango | username, auth_url, password | 16:30 |
| Tango | The sticking point is the password | 16:30 |
| Tango | I haven't figured out a good way to handle this yet | 16:30 |
| Tango | the rest can be pulled from the context, so they are ok | 16:31 |
| Tango | I already coded them up | 16:31 |
| sdake | the password isn't in the api context? | 16:31 |
| Tango | I don't see it | 16:31 |
| sdake | you may have to add it although that wont work for situations in which people only specify the token | 16:32 |
| sdake | can't gophercloud work with a token? | 16:32 |
| sdake | that would be teh best way to approach this problem | 16:32 |
| *** ganeshna has quit IRC | 16:33 | |
| Tango | So we pass along the token from the api context? I haven't looked at the gophercloud code to see if they support this option. | 16:33 |
| Tango | If they do, we have to change the plugin code in k8s to handle the token | 16:33 |
| sdake | i am not sure if we have the token in the api context but it can eaisly be stored somewhere int he context | 16:33 |
| sdake | token would be the way I'd go with an implementation | 16:34 |
| sdake | password is insecure | 16:34 |
| Tango | I see something in the context that looks like a token | 16:34 |
| sdake | jamming the password around seems less then ideal | 16:34 |
| Tango | Yeah that's what I am worried about | 16:34 |
| Tango | The thing about the token is that it's temporary, right? | 16:35 |
| Tango | So we will have to pass it along on every request | 16:35 |
| Tango | we can't store it in a config file like the way they do it now | 16:35 |
| sdake | https://github.com/rackspace/gophercloud/blob/master/provider_client.go#L55 | 16:35 |
| sdake | token ca nchange yes | 16:36 |
| *** Marga_ has joined #openstack-containers | 16:36 | |
| sdake | I think its on a timer but not certain precisely how it works | 16:36 |
| sdake | it may be per requet | 16:36 |
| Tango | The password stored in a config file also has the same problem, it can change | 16:36 |
| *** EricGonczer_ has joined #openstack-containers | 16:36 | |
| sdake | the idea of a token is it is generated to match a password/user id | 16:36 |
| sdake | so token is secure and temporary | 16:37 |
| sdake | if a password leaks, bad things happen | 16:37 |
| sdake | if a token leaks, it only leaks for a limited period | 16:37 |
| sdake | this is why we use tokens over the wire vs passwords in most cases | 16:37 |
| sdake | tokens also hae a performance benefit | 16:37 |
| sdake | not that we care about that | 16:37 |
| *** mfalatic_ is now known as mfalatic | 16:37 | |
| sdake | (just explaining for the sake of completeness:) | 16:38 |
| Tango | right. So to solve this problem will require change in k8s upstream. | 16:38 |
| sdake | if it can be done, we should tr yto get it done correctly | 16:38 |
| sdake | i think from now forward, we need to be very demanding of security implications in magnum | 16:39 |
| sdake | magnum has reached the point where it is secure | 16:40 |
| sdake | or is closing in | 16:40 |
| sdake | we dont want to leak credentials or authentication stuff around | 16:40 |
| sdake | being secure is more important then having features | 16:40 |
| *** EricGonczer_ has quit IRC | 16:40 | |
| Tango | So the way k8s works right now to support LB is that their service kube-controller-manager reads the config file on start up, which contains the OpenStack credential. | 16:41 |
| * sdake groans | 16:42 | |
| Tango | That credential is actually not even per user, since it's read only once | 16:42 |
| Tango | it has to be some kind of service credential | 16:42 |
| Tango | Then it uses it to talk to OpenStack and make request | 16:42 |
| sdake | using a token in that case sounds extremely painful to implement then | 16:43 |
| sdake | as in requiring alot of upstream k8s work | 16:43 |
| Tango | it will require work | 16:43 |
| sdake | so what do you need me to do, swallow it ? :) | 16:44 |
| Tango | can we have a special service credential with limted scope? | 16:44 |
| sdake | tango I was thinking of this - you mean add a user in the same domain with less creds | 16:45 |
| Tango | Right. | 16:45 |
| sdake | I dont know how to do that but that seems feasible | 16:45 |
| Tango | just enough to talk to Neutron and create LB pool, members, VIP, monitor | 16:45 |
| *** unicell has joined #openstack-containers | 16:45 | |
| Tango | Adrian mentioned about this some time ago | 16:46 |
| sdake | still this user shoudl us etokens rather then passwords ;) | 16:46 |
| sdake | so that is an orthogonal issue | 16:46 |
| sdake | basically we shold be doing both of those things | 16:46 |
| sdake | we need to turn the knobs up on security | 16:47 |
| sdake | going forward | 16:47 |
| Tango | Yeah, that's that sticking point I have come to | 16:48 |
| Tango | How do we handle service credential for services to talk to each other? | 16:49 |
| openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Functional tests with Tempest - BayModel CRUD https://review.openstack.org/224170 | 16:52 |
| sdake | securely is the answer ;) | 16:53 |
| Tango | OK, let me write this up on the whiteboard and see how we want to work this out | 16:54 |
| *** fawadkhaliq has joined #openstack-containers | 16:56 | |
| *** vilobhmm_11 has joined #openstack-containers | 16:57 | |
| *** harshs_ has joined #openstack-containers | 16:58 | |
| *** suro-patz has quit IRC | 17:00 | |
| apmelton | yuanying: you aren't still around are you? | 17:01 |
| *** achanda has joined #openstack-containers | 17:01 | |
| *** harshs has quit IRC | 17:01 | |
| *** harshs_ is now known as harshs | 17:01 | |
| *** suro-patz has joined #openstack-containers | 17:01 | |
| openstackgerrit | Andrew Melton proposed openstack/magnum: Add TLS to Docker-Swarm Template https://review.openstack.org/212598 | 17:06 |
| apmelton | ^^ could use some eyes if any reviewers are around | 17:06 |
| *** kebray has quit IRC | 17:06 | |
| *** absubram has joined #openstack-containers | 17:09 | |
| *** eghobo_ has joined #openstack-containers | 17:12 | |
| *** adrian_otto has quit IRC | 17:12 | |
| *** eghobo has quit IRC | 17:15 | |
| *** Drago has quit IRC | 17:17 | |
| *** vilobhmm_11 has quit IRC | 17:18 | |
| *** sthillma has joined #openstack-containers | 17:19 | |
| *** achanda has quit IRC | 17:30 | |
| *** fawadkhaliq has quit IRC | 17:33 | |
| *** fawadkhaliq has joined #openstack-containers | 17:33 | |
| *** tbh has quit IRC | 17:39 | |
| *** gangil1 has joined #openstack-containers | 17:41 | |
| *** gangil has quit IRC | 17:42 | |
| *** suro-patz has quit IRC | 17:50 | |
| *** achanda has joined #openstack-containers | 17:52 | |
| *** suro-patz has joined #openstack-containers | 17:53 | |
| *** suro-patz has joined #openstack-containers | 17:53 | |
| *** muralia has quit IRC | 17:57 | |
| *** muralia has joined #openstack-containers | 17:57 | |
| *** harlowja has quit IRC | 17:58 | |
| *** harlowja has joined #openstack-containers | 17:58 | |
| *** suro-patz has quit IRC | 18:01 | |
| *** rlrossit has quit IRC | 18:02 | |
| *** vilobhmm_11 has joined #openstack-containers | 18:02 | |
| *** rlrossit has joined #openstack-containers | 18:03 | |
| *** fawadkhaliq has quit IRC | 18:04 | |
| *** suro-patz has joined #openstack-containers | 18:05 | |
| *** gangil has joined #openstack-containers | 18:06 | |
| *** gangil1 has quit IRC | 18:06 | |
| manjeets | ._. | 18:09 |
| *** vilobhmm_11 has quit IRC | 18:22 | |
| *** vilobhmm_11 has joined #openstack-containers | 18:23 | |
| openstackgerrit | Dimitry Ushakov proposed openstack/magnum: Functional tests with Tempest - BayModel CRUD https://review.openstack.org/224170 | 18:26 |
| *** kebray has joined #openstack-containers | 18:33 | |
| openstackgerrit | Manjeet Singh Bhatia proposed openstack/magnum: WIP: Add Functional Tests for mesos cluster https://review.openstack.org/225212 | 18:34 |
| *** kebray has quit IRC | 18:35 | |
| *** unicell has quit IRC | 18:37 | |
| *** annegentle has joined #openstack-containers | 18:39 | |
| *** unicell has joined #openstack-containers | 18:40 | |
| *** kebray has joined #openstack-containers | 18:45 | |
| *** kebray has quit IRC | 18:45 | |
| *** kebray has joined #openstack-containers | 18:46 | |
| *** banix has joined #openstack-containers | 18:47 | |
| hongbin_ | vilobhmm_11: you there? | 18:52 |
| vilobhmm_11 | hey hongbin : ping | 18:53 |
| hongbin_ | vilobhmm_11: Remember you asked me a question yesterday | 18:53 |
| vilobhmm_11 | yes | 18:54 |
| hongbin_ | It is about the rpc api change | 18:54 |
| vilobhmm_11 | ok | 18:54 |
| hongbin_ | In general, you just need to update the rpc api in tests | 18:54 |
| vilobhmm_11 | rpc api for rc_update/ rc_delete etc you mean | 18:55 |
| vilobhmm_11 | if you can point to some code that would be great in fact I did change some | 18:55 |
| vilobhmm_11 | let me point you to some code | 18:55 |
| hongbin_ | I will walk it thought | 18:55 |
| hongbin_ | In here, https://review.openstack.org/#/c/213368/8/magnum/conductor/api.py | 18:55 |
| hongbin_ | you change the rpc api of replication controller | 18:56 |
| *** harshs has quit IRC | 18:56 | |
| vilobhmm_11 | yes so i did change here https://github.com/openstack/magnum/blob/master/magnum/tests/unit/conductor/test_rpcapi.py#L156 | 18:56 |
| hongbin_ | Then, you need to update this file magnum/tests/unit/conductor/test_rpcapi.py | 18:56 |
| vilobhmm_11 | yes I did that in my local changes | 18:56 |
| vilobhmm_11 | yesterday | 18:56 |
| vilobhmm_11 | still i see the problem | 18:56 |
| vilobhmm_11 | i pasted in IRC | 18:56 |
| vilobhmm_11 | i changed it for all the interfaces I modified | 18:57 |
| *** achanda has quit IRC | 18:57 | |
| vilobhmm_11 | because failure in magnum.tests.unit.conductor.test_rpcapi.RPCAPITestCase.test_rc_update | 18:57 |
| hongbin_ | OK, I show you something | 18:57 |
| vilobhmm_11 | itself suggested me that something is wrong with rpc layer changes | 18:57 |
| vilobhmm_11 | sure | 18:57 |
| vilobhmm_11 | that will help | 18:57 |
| hongbin_ | Here is the change I made to fix a test http://paste.openstack.org/show/468319/ | 18:58 |
| hongbin_ | Apply a similar fix to the rest of the test, it should work | 18:59 |
| vilobhmm_11 | with the above fix 'magnum.tests.unit.conductor.test_rpcapi.RPCAPITestCase.test_rc_update' should work I agree but magnum.tests.unit.api.controllers.v1.test_replicationcontroller.TestPatch.test_replace_with_manifest still fails | 19:00 |
| hongbin_ | OK, let me try that test locally | 19:01 |
| vilobhmm_11 | hongbin : hold on my bad | 19:01 |
| vilobhmm_11 | I did not include a empty manifest | 19:01 |
| vilobhmm_11 | let me try again | 19:01 |
| vilobhmm_11 | please hold on | 19:01 |
| hongbin_ | sure | 19:01 |
| vilobhmm_11 | hongbin : now complaining like this http://paste.openstack.org/show/468329/ | 19:06 |
| vilobhmm_11 | thats why in the test_rpcapi apart from giving bay_uuid, rc_ident, manifest = '{"key" : "value"}' | 19:06 |
| hongbin_ | k. Let me try it | 19:07 |
| vilobhmm_11 | it expects a special format for manifest | 19:07 |
| vilobhmm_11 | hongbin : sure thanks ! since in https://review.openstack.org/#/c/213368/8/magnum/conductor/handlers/k8s_conductor.py #184 body=manifest manifest can't be empty | 19:09 |
| hongbin_ | np. Looking that the API test | 19:10 |
| hongbin_ | Looking into | 19:10 |
| vilobhmm_11 | sure thanks | 19:11 |
| vilobhmm_11 | hongbin : if we compare it with https://review.openstack.org/#/c/213368/8/magnum/api/controllers/v1/replicationcontroller.py #307 manifest was explicitly set to 'None' as its a mandatory field in rc object https://github.com/openstack/magnum/blob/master/magnum/objects/replicationcontroller.py#L40 I my changes for patch ( https://review.openstack.org/#/c/213368/8/magnum/api/controllers/v1/replicationcontroller.py #307 ) first o | 19:18 |
| hongbin_ | It looks the processing of manifest is removed in your patch. Let me check carefully | 19:20 |
| vilobhmm_11 | sure | 19:20 |
| *** dimtruck is now known as zz_dimtruck | 19:22 | |
| *** annegentle has quit IRC | 19:25 | |
| *** vilobhmm_11 has quit IRC | 19:27 | |
| *** vilobhmm_11 has joined #openstack-containers | 19:28 | |
| *** suro-patz has quit IRC | 19:30 | |
| *** adrian_otto has joined #openstack-containers | 19:32 | |
| *** adrian_otto has quit IRC | 19:34 | |
| *** absubram has quit IRC | 19:40 | |
| *** fawadkhaliq has joined #openstack-containers | 19:43 | |
| vilobhmm_11 | hongbin : you yhink i have missed something with manifest processing ? | 19:43 |
| hongbin_ | vilobhmm_11: sort of | 19:44 |
| *** sthillma_ has joined #openstack-containers | 19:44 | |
| hongbin_ | vilobhmm_11: remember you asked me yesterday for the _get_manifest things | 19:45 |
| vilobhmm_11 | hongbin : yes | 19:45 |
| hongbin_ | That is the problem | 19:45 |
| *** sdake has quit IRC | 19:46 | |
| hongbin_ | So, the problem is how to get manifest without an DB object | 19:46 |
| hongbin_ | need some walkaround | 19:46 |
| vilobhmm_11 | yup | 19:46 |
| vilobhmm_11 | without a db object | 19:46 |
| vilobhmm_11 | in rc controller a sample manifest is parsed | 19:47 |
| *** sthillma has quit IRC | 19:47 | |
| *** sthillma_ is now known as sthillma | 19:47 | |
| hongbin_ | yes, need something to figure out a solution | 19:47 |
| vilobhmm_11 | as part of https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/replicationcontroller.py#L291 | 19:47 |
| vilobhmm_11 | is there some common place where we have these manifest stored like the templates | 19:48 |
| *** sdake has joined #openstack-containers | 19:53 | |
| *** annegentle has joined #openstack-containers | 19:55 | |
| hongbin_ | vilobhmm_11: No, manifest is not persisted, it is parsed on the fly | 19:56 |
| vilobhmm_11 | hmm | 19:56 |
| vilobhmm_11 | the k8s API will need manifest as its body …https://review.openstack.org/#/c/213368/8/magnum/conductor/handlers/k8s_conductor.py #184 | 19:57 |
| *** suro-patz has joined #openstack-containers | 20:01 | |
| *** apuimedo has joined #openstack-containers | 20:20 | |
| vilobhmm_11 | hongbin : away for lunch for few min will be back soon | 20:21 |
| hongbin_ | vilobhmm_11: ack | 20:22 |
| *** rlrossit has left #openstack-containers | 20:23 | |
| *** eghobo_ has quit IRC | 20:32 | |
| *** suro-patz has quit IRC | 20:32 | |
| *** eghobo has joined #openstack-containers | 20:36 | |
| *** fawadkhaliq has quit IRC | 20:44 | |
| hongbin_ | vilobhmm_11: this change will make the API test work http://paste.openstack.org/show/468436/ | 20:44 |
| *** fawadkhaliq has joined #openstack-containers | 20:45 | |
| hongbin_ | vilobhmm_11: when I was testing your patch, I find out a new issue which I am going to comment on your review | 20:47 |
| *** fawadkhaliq has quit IRC | 20:48 | |
| hongbin_ | vilobhmm_11: basically, your patch is better to divide into two | 20:49 |
| hongbin_ | vilobhmm_11: one of them add 'bay_uuid' to the API, the other do the rest of the job | 20:49 |
| hongbin_ | vilobhmm_11: then we can debate those two changes separately. | 20:51 |
| vilobhmm_11 | hongbin : just back from lunch…will check the paste | 21:05 |
| hongbin_ | vilobhmm_11: ack | 21:15 |
| *** harshs has joined #openstack-containers | 21:15 | |
| vilobhmm_11 | hongbin : it works ! :) http://paste.openstack.org/show/468494/ | 21:17 |
| hongbin_ | vilobhmm_11: good to know | 21:17 |
| vilobhmm_11 | i guess i missed magnum/tests/unit/objects/utils.py | 21:17 |
| hongbin_ | vilobhmm_11: I haven't tested it in devstack though | 21:17 |
| vilobhmm_11 | part of setting manifest here | 21:17 |
| vilobhmm_11 | ok | 21:18 |
| vilobhmm_11 | let me getting all the test working and then we can see if we still need to split the patches | 21:18 |
| vilobhmm_11 | also will need to submit cli changes to make bay-uuid as mandatory param | 21:19 |
| hongbin_ | sure | 21:19 |
| vilobhmm_11 | for k8s operations | 21:19 |
| vilobhmm_11 | hongbin : thanks again for all the help ! :) | 21:19 |
| hongbin_ | np | 21:19 |
| *** manjeets has quit IRC | 21:20 | |
| *** suro-patz has joined #openstack-containers | 21:21 | |
| *** dims_ has joined #openstack-containers | 21:29 | |
| *** sthillma_ has joined #openstack-containers | 21:30 | |
| *** eghobo has quit IRC | 21:30 | |
| *** sthillma has quit IRC | 21:32 | |
| *** sthillma_ is now known as sthillma | 21:32 | |
| *** dimsum__ has quit IRC | 21:32 | |
| *** annegentle has quit IRC | 21:34 | |
| *** alex_klimov has joined #openstack-containers | 21:47 | |
| *** vilobhmm_11 has quit IRC | 22:01 | |
| *** vilobhmm_11 has joined #openstack-containers | 22:02 | |
| *** alex_klimov has quit IRC | 22:38 | |
| *** hongbin_ has quit IRC | 22:39 | |
| *** sdake_ has joined #openstack-containers | 22:39 | |
| *** sdake has quit IRC | 22:43 | |
| *** openstackgerrit has quit IRC | 22:46 | |
| *** openstackgerrit has joined #openstack-containers | 22:46 | |
| *** sdake has joined #openstack-containers | 22:48 | |
| *** sdake_ has quit IRC | 22:51 | |
| *** achanda has joined #openstack-containers | 22:52 | |
| *** dims_ has quit IRC | 22:56 | |
| *** kebray has quit IRC | 23:09 | |
| *** banix has quit IRC | 23:10 | |
| *** banix has joined #openstack-containers | 23:11 | |
| *** dimsum__ has joined #openstack-containers | 23:23 | |
| *** rpothier has quit IRC | 23:33 | |
| vilobhmm_11 | balajin : api2.ostk.cl3.prod.gq1.yahoo.com | 23:35 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!