Tuesday, 2015-07-07

*** sdake_ has joined #openstack-containers00:00
*** eghobo has quit IRC00:00
*** adrian_otto has quit IRC00:00
*** dims has joined #openstack-containers00:01
*** sdake has quit IRC00:02
*** eghobo has joined #openstack-containers00:08
*** sdake has joined #openstack-containers00:09
*** suro-patz has quit IRC00:11
*** sdake_ has quit IRC00:13
*** manjeets has joined #openstack-containers00:22
*** SourabhP has quit IRC00:27
*** SourabhP has joined #openstack-containers00:31
*** dims has quit IRC00:50
*** ameybhide has quit IRC00:51
*** fawadkhaliq has joined #openstack-containers00:53
*** wanghua has joined #openstack-containers00:53
*** diga5 has joined #openstack-containers00:55
*** fawadkhaliq has quit IRC00:56
*** diga5 has quit IRC00:58
*** ybathia has quit IRC00:58
*** dims has joined #openstack-containers00:58
*** wanghua has quit IRC00:59
*** wanghua has joined #openstack-containers00:59
*** humble_ has joined #openstack-containers01:00
openstackgerritMerged openstack/magnum: Docker container-create fails with Unicode is not supported  https://review.openstack.org/19891601:01
*** zhenguo has joined #openstack-containers01:03
*** wanghua has quit IRC01:03
*** manjeets has quit IRC01:04
*** daneyon has joined #openstack-containers01:06
*** manjeets has joined #openstack-containers01:06
*** Tango has joined #openstack-containers01:09
*** achanda has joined #openstack-containers01:13
*** SourabhP has quit IRC01:24
*** erkules has joined #openstack-containers01:25
*** erkules_ has quit IRC01:28
*** manjeets has quit IRC01:29
*** sthillma has quit IRC01:42
*** eghobo has quit IRC01:43
*** kan__ has joined #openstack-containers01:49
*** harshs has quit IRC01:51
*** skoar has quit IRC02:03
*** daneyon has quit IRC02:08
*** daneyon has joined #openstack-containers02:08
openstackgerritEli Qiao proposed openstack/magnum: Add periodic task to sync up bay status  https://review.openstack.org/19451402:09
openstackgerritHongbin Lu proposed openstack/magnum: Fix minion registration failure  https://review.openstack.org/19893902:14
*** skoar has joined #openstack-containers02:15
*** dboik_ has joined #openstack-containers02:24
*** dboik_ has quit IRC02:31
openstackgerritMerged openstack/magnum: Remove duplicated definition of class "APIBase"  https://review.openstack.org/19850902:34
*** skoar has quit IRC02:42
*** daneyon has quit IRC02:45
*** kebray has joined #openstack-containers02:56
*** kebray has quit IRC02:57
*** kebray has joined #openstack-containers02:58
openstackgerritMerged openstack/magnum: Fix sample link in magnum/api/controllers/link.py  https://review.openstack.org/19850703:13
*** skoar has joined #openstack-containers03:15
*** julim has joined #openstack-containers03:31
*** hongbin has quit IRC03:32
sdakemadhuri ping03:34
sdakemadhuri if you are around today ping me when you can03:35
sdakeits important (see inbox)03:35
sdakeatleast important to me :)03:35
*** dims has quit IRC03:39
*** eghobo has joined #openstack-containers03:50
*** suro-patz has joined #openstack-containers03:51
madhurisdake, Hi03:53
madhuriI read your mail03:53
madhuriWill share all the details03:53
sdakeany inside tips you could provide would be higly valuable03:53
sdakeplease keep me on the cc03:53
madhuriSure03:54
sdakeand please keep private ;)03:54
madhuriOk :)03:54
*** skoar has left #openstack-containers03:59
*** harshs has joined #openstack-containers04:10
*** julim has quit IRC04:19
madhurisdake, ping04:30
*** Marga_ has joined #openstack-containers04:32
*** Marga_ has quit IRC04:32
*** Marga_ has joined #openstack-containers04:33
*** dims has joined #openstack-containers04:40
*** dims_ has joined #openstack-containers04:41
*** adrian_otto has joined #openstack-containers04:43
*** dims has quit IRC04:45
*** dims_ has quit IRC04:46
*** adrian_otto has quit IRC04:48
*** suro-patz has quit IRC04:56
*** nihilifer has joined #openstack-containers04:59
*** SourabhP has joined #openstack-containers05:04
*** SourabhP_ has joined #openstack-containers05:09
*** SourabhP has quit IRC05:11
*** SourabhP_ is now known as SourabhP05:11
*** Marga_ has quit IRC05:18
*** Marga_ has joined #openstack-containers05:19
*** achanda has quit IRC05:23
*** yuanying_ has joined #openstack-containers05:40
eliqiaohi madhuri05:42
openstackgerritEli Qiao proposed openstack/magnum: Add periodic task to sync up bay status  https://review.openstack.org/19451405:42
*** harshs has quit IRC05:43
*** yuanying has quit IRC05:44
*** unicell has joined #openstack-containers05:44
*** yuanying_ has quit IRC05:44
*** juggler_ has joined #openstack-containers05:46
*** juggler has quit IRC05:49
*** yuanying has joined #openstack-containers05:51
*** ig0r_ has joined #openstack-containers05:52
*** wanghua has joined #openstack-containers05:52
*** humble_ has quit IRC05:53
*** harshs has joined #openstack-containers05:53
*** humble_ has joined #openstack-containers05:55
*** ig0r__ has quit IRC05:55
*** unicell has quit IRC05:56
*** wanghua has quit IRC05:58
*** unicell has joined #openstack-containers05:58
*** j___ has joined #openstack-containers05:59
*** suro-patz has joined #openstack-containers06:00
*** dane_leblanc has quit IRC06:02
*** yuanying has quit IRC06:04
humble_hi all, can we use container-create in k8sbay?06:07
*** yuanying has joined #openstack-containers06:10
Kennanhi humble_ i don't think you can use that06:14
*** yuanying has quit IRC06:14
*** suro-patz has quit IRC06:15
humble_Kennan: why we don't forbid it in the codes06:15
*** yuanying has joined #openstack-containers06:16
Kennanhumble_ I think k8s default mininal container unit is pods06:17
Kennannot containers06:17
eliqiaohi Kennan, can I ask a question?06:19
Kennanhi eliqiao:06:19
humble_Kennan: yes, we only can use container-create in swarm bay. So i think we should return forbidden action when a user use container-create in k8s bay.06:19
Kennanhumble_: I think it was this fix https://review.openstack.org/#/c/198456/06:21
eliqiaoI see from code that when calling container-list will query all containers by docker client_api , but if one of them fails, container-list will report exception without any results06:21
eliqiaoKennan: this is too bad, user can do nothing on that containers, how about we ignor the exceptions and set it to error state?06:22
eliqiaoKennan: I found this patch #link https://review.openstack.org/#/c/180384/, but seems in some cases, it can not work well06:23
Kennaneliqiao: what do you mean if one of them fails ?   what's the failure case06:26
Kennanand for the last question06:26
Kennanwhat's case for it not work well?06:26
eliqiaoI got this exception "image or container param is undefined", it is reported by docker client06:27
Kennaneliqiao: what's the error msg in docker side? what image or container param undefined?06:29
eliqiao Kennan: hmm... can you tell how can I get such message?06:33
Kennanhi eliqiao: the docker backend finally got from docker python client06:33
Kennanfound the image which hit issue06:33
Kennanand use docker-py directly from python06:34
Kennanexecute that and found what's the root cause06:34
Kennaneliqiao: check this https://docker-py.readthedocs.org/en/latest/api/06:34
eliqiaoKennan: thx, okay let me try, ttl06:34
Kennanit could help you06:34
eliqiaoKennan: got it,thx06:35
*** belmoreira has joined #openstack-containers06:43
madhurihi eliqiao06:44
eliqiaooh hi madhuri, I just see you around that time, I am looking for you to help merge patch06:46
eliqiaomadhuri:  appreciate if if you have time to help on https://review.openstack.org/#/c/180384/06:46
eliqiaomadhuri, thank in advance06:47
madhuriThis patch is already merged eliqiao06:48
openstackgerritKai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side  https://review.openstack.org/19898406:48
eliqiaosorry for wrong link should be this one, https://review.openstack.org/#/c/194514/ jay and hong bin have +2 on it06:49
madhuriOk sure I will take a look on it06:50
eliqiaomagnum are going to support baremetal ?06:52
*** j___ has quit IRC06:52
*** eghobo has quit IRC06:52
openstackgerritKai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side  https://review.openstack.org/19898406:54
openstackgerritKai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side  https://review.openstack.org/19898406:58
*** BertrandN has joined #openstack-containers07:03
*** Marga__ has joined #openstack-containers07:03
openstackgerritKai Qiang Wu(Kennan) proposed openstack/python-magnumclient: Add platform support in client side  https://review.openstack.org/19898807:03
*** Marga_ has quit IRC07:06
*** j___ has joined #openstack-containers07:06
*** SourabhP has quit IRC07:07
*** SourabhP has joined #openstack-containers07:09
*** madhuri has quit IRC07:21
*** juggler_ is now known as juggler07:23
eliqiaoKennan: I found the root cause why container-list failed07:24
juggleris Kennan here?07:25
Kennaneliqiao: what's the issue07:25
Kennanjuggler: what's up07:25
*** belmoreira has quit IRC07:26
eliqiaoKennan:  quite simliar with https://bugs.launchpad.net/magnum/+bug/144987207:26
openstackLaunchpad bug 1449872 in Magnum "Container create failed on docker but still saved in magnum" [Undecided,In progress] - Assigned to Lan Qi song (lqslan)07:26
jugglerRegarding: https://review.openstack.org/#/c/189584/2/doc/source/dev/dev-quickstart.rst , I am puzzled by the comment.07:26
jugglerThe URL was included as an aid...07:27
jugglerto direct the user to additional information to configure their devstack.07:27
eliqiao Kennan: here is how I reproduce it http://paste.openstack.org/show/351079/07:27
jugglerA newcomer to the dev-quickstart document...07:27
Kennanjuggler: what can I help you?07:28
jugglerwould have no idea where that dev-manual-devstack.rst is located.07:28
Kennanjuggler:07:29
Kennanhttps://github.com/openstack/magnum/blob/master/doc/source/dev/dev-quickstart.rst07:29
Kennancheck above link07:29
juggleryou might help in explaining why the repeat -1's07:29
*** BertrandN has quit IRC07:29
juggleryes, I know what that document is.07:29
Kennanjuggler: if you want to fix the devstack detailed configuration07:29
Kennanyou should refer to devstack official link07:30
Kennaninstead of manual guide link07:30
Kennanin magnum07:30
jugglerI do not want to fix the devstack detailed configuration. That was never the bug's intent.07:30
jugglerThis is an issue of assuring that the dev-quickstart.rst mentions the EXISTENCE/LOCATION of the dev-manual-devstack.rst07:32
jugglerWithout that key information, a newcomer has no idea what  a "devstack guide" is and will spend extra cycles asking around07:32
*** harshs has quit IRC07:32
*** kebray has quit IRC07:33
*** Tango has quit IRC07:33
Kennanjuggler: I did not know what's not clear for here07:35
KennanYou need to make customized setting according to your environment requirement, refer devstack guide for details07:35
Kennanit is said user need to refer devstack guide07:35
Kennanit is not manual magnum guide07:36
jugglerit is believed that the intent of current development is to to refer to the dev-manual-devstack.rst document07:39
*** dims has joined #openstack-containers07:43
*** BertrandN has joined #openstack-containers07:45
*** dims has quit IRC07:48
jugglerKennan you there?07:51
Kennanhi just come, had some issue07:51
juggleroh ok07:52
*** SourabhP has quit IRC07:55
Kennanhi juggler: I did not think it was intent to refer manual guide. it was for devstack customizaton, as many customization not explained in manual-devstack guide07:56
Kennanit was in devstack official guide07:56
*** macjack has joined #openstack-containers07:56
Kennanand devstack have more than that, it is there to get understood what can configuration07:56
Kennanlike ovs and etc.07:57
jugglerok...so how are newcomers going to know of the existence of the https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-manual-devstack.rst then? it's my gathering from channel chats here that this is an important piece in the puzzle07:58
*** SourabhP has joined #openstack-containers07:58
Kennanhi juggler: if you really want to link manual guide from dev-qucik guide08:00
KennanI suggest you can refer what did in manual guide (ref to manual guide)08:04
Kennanhttps://github.com/openstack/magnum/blob/master/doc/source/dev/dev-manual-devstack.rst08:04
Kennanjuggler usually I think if user can find dev quick guide, it is easy for him to find manul guide. As it is targeted for developers(from github)08:05
juggler"what did"? sorry I do not follow08:05
*** j___ has quit IRC08:05
*** SourabhP has quit IRC08:06
Kennansince that link is source code, it could finally published magnum dev  wiki with tox -e docs08:06
Kennanit woudl have index.html08:06
*** erkules has quit IRC08:06
*** erkules has joined #openstack-containers08:06
Kennanlike this08:07
KennanIf you are getting started with Magnum it is recommended you follow the :ref:`dev-quickstart` t08:07
*** SourabhP has joined #openstack-containers08:12
jugglerthe doc/source/dev/dev-quickstart.rst file does not use wiki syntax, though08:12
openstackgerritEli Qiao proposed openstack/magnum: API: don't query Error state containers from docker_client  https://review.openstack.org/19900708:15
*** SourabhP_ has joined #openstack-containers08:15
*** SourabhP has quit IRC08:16
*** SourabhP_ is now known as SourabhP08:16
jugglerwell, Kennan, it is late here. i plan to be at the meeting this morning if you have additional comments/feedback.08:18
jugglerbottom line is that without including this URL in that document, it makes it harder to find for newcomers.08:19
jugglerperhaps adrian_otto may have additional feedback on the review08:20
*** j___ has joined #openstack-containers08:20
Kennanjuggler: Still usually newcomers not need to check manual-install guide, it is too details(more is about devsstack itself)08:20
Kennanit not help anything about magnum08:20
juggleri beg to differ08:25
jugglerlet's consult adrian_otto then for guidance08:30
Kennanhi, juggler, you may can inovlve other reviers options about that, As I said, it is use tox to produce finally guide, many projects follow that08:31
Kennanquick-guide is for new comers to start, they not to worry so many devstack configuration at the first time08:31
*** SourabhP has quit IRC08:36
juggleras a newcomer reading that, i had no idea where to go next. leaving that person in the dark is not good.08:44
juggleri would hope one of our goals is to make this easier for people08:45
Kennanhi eliqiao: you can open a bug for that, I did not remember clearly, it was introduced by new code?08:46
jugglerlater Kennan. tty at the meeting, or next time08:46
Kennanyou'd better involve more reviewers options about it. As I said :)08:47
openstackgerritKai Qiang Wu(Kennan) proposed openstack/python-magnumclient: Add platform support in client side  https://review.openstack.org/19898808:49
eliqiaoKennan: #link https://launchpad.net/bugs/147213208:50
openstackLaunchpad bug 1472132 in Magnum "container-list fails after container-create fail with 500" [Undecided,In progress] - Assigned to Eli Qiao (taget-9)08:50
Kennanok eliqiao: I tried that case before, not hit that. maybe  regression issue08:52
Kennandid that container exist in docker swarm? eliqiao: ?08:53
KennanI think it only exist in magnum side08:53
eliqiaoKennan: you are right08:53
eliqiaoKennan: post() create an container object in db, then call conductor to create container in swarm, but failed08:54
eliqiaoKennan:  #link https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/container.py#L36408:55
KennanHi eliqiao:08:56
Kennanyes, but when you call container-list08:57
Kennanit would loop call container-show in docker-conductor08:57
Kennanit had08:57
Kennanexcept errors.APIError as api_error08:57
Kennanif '404' in error_message:08:57
eliqiaoKennan: by checking the status in magnum DB, that container's status is "ERROR" , and then if we do container-list, it will first _find_container_by_name, but got {}, then with {} , call  result = docker.inspect_container(docker_id)08:57
Kennanyes, wouldn't it hit exception and catch by08:58
eliqiaoI don't get errors.APIError08:58
Kennanoh, I think it was docker-py new changes,08:58
Kennanbefore it would fall to exception08:58
Kennanand check return code is 40408:58
Kennanand set error08:58
KennanI remembered before08:59
Kennanwhat did the  docker.inspect_container(docker_id) return then ?08:59
eliqiaodon't think so, I never update my docker-py08:59
eliqiaoKennan:  check this http://paste.openstack.org/show/351373/09:01
*** j___ has quit IRC09:02
Kennanyou can check our docker-py before docker-py>=1.1.0, right now, I found the env is 1.2.309:02
Kennanas devstack install magnum, would finally fetch latest docker-py09:03
eliqiao{} is returned by https://github.com/openstack/magnum/blob/master/magnum/conductor/handlers/docker_conductor.py#L15909:03
Kennanpip freeze | grep -i docker-py09:03
Kennangot 1.2.3 in my env09:03
eliqiaome too docker-py==1.2.309:04
eliqiaotaget@taget-ThinkStation-P300:/opt/stack/magnum$ pip list | grep docker-py09:04
eliqiaodocker-py (1.2.3)09:04
eliqiaoKennan: if so, this should be a critical bug ?09:05
eliqiaoKennan: or high09:05
Kennanyes, I think it is critical bug,09:05
Kennanbut let's first invetigate09:05
Kennanwe should also need make it work in 1.2.309:06
Kennanas we not need to update 1.2.3 in requirements if it is not must09:06
eliqiaoinvetigate in which version docker-py change the behavior?09:07
Kennannot sure if it is this case09:08
Kennanhttps://github.com/docker/docker-py/commit/de2f58d818565dd09:08
Kennanbut I think let's change magnum code to support that 1.2.3 also09:08
Kennanis better09:08
Kennanseems not09:08
Kennanit is inspect_images09:08
eliqiaoKennan: Sorry , not feling well, should go home, I have patch on  https://review.openstack.org/#/c/199007/, leave comments if you have any idea. thanks09:09
Kennanok eliqiao: take care09:09
eliqiaoKennan: BTW, where is your location ? BJ/Xi'an09:09
KennanBJ09:10
eliqiaoKennan: cool, actually I am ibmer later year , hehe...09:10
eliqiao Kennan: I should go , thx09:10
Kennanwcl09:11
*** j___ has joined #openstack-containers09:21
*** dims has joined #openstack-containers09:44
*** dims_ has joined #openstack-containers09:45
*** dims__ has joined #openstack-containers09:46
*** dims has quit IRC09:48
*** dims_ has quit IRC09:50
*** dims__ has quit IRC09:50
openstackgerritMerged openstack/magnum: Swith auth_uri to use v2.0  https://review.openstack.org/19786509:52
openstackgerritMerged openstack/magnum: Remove unused fields "from_*" from API controller  https://review.openstack.org/19850509:55
*** yuanying_ has joined #openstack-containers09:57
*** yuanying has quit IRC10:00
openstackgerritKai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side  https://review.openstack.org/19898410:02
*** yuanying_ has quit IRC10:07
*** yuanying has joined #openstack-containers10:07
*** madhuri has joined #openstack-containers10:08
madhurieliqiao, ping10:08
Kennanyuanying: there?10:17
yuanyinghi10:17
Kennanhi yuanying: I am not sure what do you mean add wait contditon for master10:18
Kennanwhere should we add that?10:18
yuanyingkubecluster.yaml use it for master10:19
yuanyingoh10:19
yuanyingchange to master_wc_notify10:19
*** diga has quit IRC10:20
Kennanyuanying: could you specify it ?10:20
yuanyingwait a moment10:20
Kennanwith paste for what change should like10:20
yuanyingkubecluster.yaml has master_wait_handle10:21
yuanyinghttps://github.com/openstack/magnum/blob/master/magnum/templates/heat-kubernetes/kubecluster.yaml#L9610:21
yuanyinghttps://github.com/openstack/magnum/blob/master/magnum/templates/heat-kubernetes/kubecluster.yaml#L22810:22
yuanyingif script is finished, that status is notified to heat10:23
yuanyingI think master_wait_handle is needed to track finishing the kubernetes install script10:24
yuanyingwhen software_deploymen was used, software deployment notified that to heat10:25
KennanI not sure if it is needed, all resource becase creation_compleate finally even not with that10:26
Kennanyuanying: you said that was for notifying heat to become compleate-finished?10:27
Kennanto update heat stack status?10:27
yuanyingwhen stack status is creation_complete, kubernetes can be used by user, it means all script should be finished10:27
yuanyingKennan: yes10:28
yuanyingif there is no master_wc_notify, stack status will be creation_complete but script will not be finished10:29
Kennanok yuanying: let me try that10:29
Kennanyuanying: do you think we need master_wait_condition ?10:31
yuanyingI think we need it10:32
Kennanyuanying: kube_minions now depend on kube_master10:33
Kennanin ironic templates10:33
Kennanso if it need depend on master_wait_condition?10:33
yuanyingkube_minion can request to kube_master, when kubernetes service doesn't finished setup?10:34
KennanI am not sure if wc_notify issue, just 30 mins ago, I tried to add depends on master_wait_condition for kube_minions10:36
Kennanit just have one master setup10:36
Kennanand node would not setup10:36
yuanyingI think it's better that minion node depends on master_wait_condition10:36
Kennanmaster_wait_condition always in create_in_progress10:37
Kennanand never ends10:37
yuanyingreally?10:37
yuanyinghmm10:37
Kennanyes, I tried that (without wc_notify)10:37
KennanI think wc_notfiy has nothing with that wait_condition10:37
Kennanright? becasue from templates I not find it have depends on that10:38
yuanyingwc_notify is needed10:38
KennanOK. I would try again with (as before)10:38
Kennan    depends_on:10:39
Kennan      - kube_master10:39
Kennan      - master_wait_condition10:39
KennanI not think it could success10:39
Kennanbut let me try first10:39
* Kennan leave for supper10:43
*** dims has joined #openstack-containers10:46
*** dims has quit IRC10:51
*** Marga__ has quit IRC11:00
*** Marga_ has joined #openstack-containers11:02
*** Marga_ has quit IRC11:15
*** Marga_ has joined #openstack-containers11:17
*** humble_ has quit IRC11:20
*** eliqiao has quit IRC11:25
*** eliqiao has joined #openstack-containers11:27
*** j___ has quit IRC11:53
*** j___ has joined #openstack-containers11:53
*** dims has joined #openstack-containers12:02
*** diga has joined #openstack-containers12:03
*** j___ has quit IRC12:04
*** dims has quit IRC12:07
*** j___ has joined #openstack-containers12:15
*** diga_ has joined #openstack-containers12:16
*** diga has quit IRC12:20
*** hongbin has joined #openstack-containers13:01
*** dane_leblanc has joined #openstack-containers13:01
*** jruano has joined #openstack-containers13:03
*** dane_leblanc has quit IRC13:07
*** dims has joined #openstack-containers13:19
*** dboik has joined #openstack-containers13:20
*** wanghua has joined #openstack-containers13:20
*** nihilifer has quit IRC13:23
*** julim has joined #openstack-containers13:24
*** yuanying-alt has joined #openstack-containers13:25
*** jruano has quit IRC13:27
*** jruano has joined #openstack-containers13:27
*** jjlehr has joined #openstack-containers13:28
*** dane_leblanc has joined #openstack-containers13:30
*** hongbin has quit IRC13:45
*** j___ has quit IRC13:47
*** jruano_ has joined #openstack-containers13:49
*** jruano has quit IRC13:50
*** adrian_otto has joined #openstack-containers13:50
*** nihilifer has joined #openstack-containers13:51
*** jruano_ is now known as jruano13:52
*** kan__ has quit IRC13:57
*** jruano has quit IRC13:58
*** hongbin has joined #openstack-containers14:01
*** jruano has joined #openstack-containers14:02
*** Kennan2 has joined #openstack-containers14:03
*** zhenguo has quit IRC14:03
*** Kennan has quit IRC14:03
*** jruano has quit IRC14:06
*** j___ has joined #openstack-containers14:09
*** sdake has quit IRC14:14
*** sdake has joined #openstack-containers14:14
*** j___ has quit IRC14:21
*** wwallnrr__ has joined #openstack-containers14:21
*** yuanying-alt has quit IRC14:23
*** Drago has joined #openstack-containers14:38
*** Drago has quit IRC14:43
*** Drago has joined #openstack-containers14:43
*** adrian_otto has quit IRC14:55
*** bradjones|away is now known as bradjones14:56
*** achanda has joined #openstack-containers14:56
*** BertrandN has quit IRC15:00
*** adrian_otto has joined #openstack-containers15:02
*** achanda has quit IRC15:02
*** rpothier has joined #openstack-containers15:04
*** adrian_otto has quit IRC15:05
*** adrian_otto has joined #openstack-containers15:05
*** adrian_otto has quit IRC15:09
*** adrian_otto has joined #openstack-containers15:09
*** adrian_otto has quit IRC15:13
*** adrian_otto has joined #openstack-containers15:13
*** dims has quit IRC15:16
*** adrian_otto has quit IRC15:17
*** kebray has joined #openstack-containers15:17
*** jruano has joined #openstack-containers15:19
*** SourabhP has joined #openstack-containers15:21
*** jruano has quit IRC15:22
*** SourabhP_ has joined #openstack-containers15:23
*** SourabhP has quit IRC15:26
*** SourabhP_ is now known as SourabhP15:26
*** dims has joined #openstack-containers15:43
*** nihilifer has quit IRC15:47
*** sdake_ has joined #openstack-containers15:48
*** adrian_otto has joined #openstack-containers15:48
*** sdake has quit IRC15:48
*** jjfreric has joined #openstack-containers15:48
*** unicell has quit IRC15:49
adrian_ottoThe Containers Team meeting will begin in 10 minutes in #openstack-meeting-alt so I look forward to seeing you all there!15:50
*** j___ has joined #openstack-containers15:52
*** eghobo has joined #openstack-containers15:57
*** sthillma has joined #openstack-containers15:58
*** kebray has quit IRC15:59
*** Tango has joined #openstack-containers15:59
*** daneyon has joined #openstack-containers16:00
*** mfalatic has joined #openstack-containers16:01
*** kebray has joined #openstack-containers16:01
*** suro-patz has joined #openstack-containers16:05
*** gnep has joined #openstack-containers16:12
*** gnep has quit IRC16:13
*** manjeets has joined #openstack-containers16:14
*** fawadkhaliq has joined #openstack-containers16:15
*** absubram has joined #openstack-containers16:16
*** unicell has joined #openstack-containers16:23
*** SourabhP has quit IRC16:26
*** manjeets has quit IRC16:27
*** unicell has quit IRC16:28
*** unicell has joined #openstack-containers16:28
*** sdake_ is now known as sdae16:35
*** sdae is now known as sdake16:39
*** harshs has joined #openstack-containers16:53
*** Tango has quit IRC17:04
*** vahidh has joined #openstack-containers17:10
*** david-lyle has quit IRC17:19
*** sthillma has quit IRC17:19
*** Tango has joined #openstack-containers17:20
*** pradk has joined #openstack-containers17:21
openstackgerritTom Cammann proposed openstack/magnum: Check for Python 2 when using unicode builtin  https://review.openstack.org/19918917:23
*** achanda has joined #openstack-containers17:25
*** manjeets has joined #openstack-containers17:40
*** SourabhP has joined #openstack-containers17:42
*** j___ has quit IRC17:46
*** SourabhP has quit IRC17:48
*** SourabhP has joined #openstack-containers17:48
*** adrian_otto has quit IRC17:50
*** adrian_otto has joined #openstack-containers17:51
*** jjfreric has quit IRC17:57
*** jjfreric has joined #openstack-containers17:57
*** manjeets has quit IRC17:58
*** harshs has quit IRC18:02
*** adrian_otto has quit IRC18:02
*** dane_leblanc has quit IRC18:03
*** julim_ has joined #openstack-containers18:03
*** sthillma has joined #openstack-containers18:03
*** jjfreric has quit IRC18:04
*** coolsvap|away is now known as coolsvap18:04
*** julim has quit IRC18:05
*** jjfreric has joined #openstack-containers18:07
*** adrian_otto has joined #openstack-containers18:08
*** ybathia has joined #openstack-containers18:11
*** dane_leblanc has joined #openstack-containers18:11
*** adrian_otto has quit IRC18:12
*** harshs has joined #openstack-containers18:12
*** adrian_otto has joined #openstack-containers18:12
openstackgerritMartin Falatic proposed openstack/magnum: Updated Magnum documentation  https://review.openstack.org/19921218:25
*** adrian_otto has quit IRC18:32
*** adrian_otto has joined #openstack-containers18:33
*** adrian_otto has quit IRC18:35
*** adrian_otto has joined #openstack-containers18:35
*** sdake has quit IRC18:36
*** adrian_otto has quit IRC18:51
*** achanda has quit IRC18:51
*** sdake has joined #openstack-containers18:52
*** dims has quit IRC18:53
*** gordc has joined #openstack-containers18:55
*** gordc has left #openstack-containers18:55
*** sdake_ has joined #openstack-containers18:56
*** dims has joined #openstack-containers18:58
*** sdake has quit IRC19:00
*** kebray has quit IRC19:02
*** harlowja_ has joined #openstack-containers19:02
*** harlowja has quit IRC19:03
*** ybathia has quit IRC19:06
*** ybathia has joined #openstack-containers19:06
*** harshs has quit IRC19:08
openstackgerritHongbin Lu proposed openstack/magnum: Add documentation for smart scale down feature  https://review.openstack.org/19879919:21
openstackgerritHongbin Lu proposed openstack/magnum: Implement bay smart scale down  https://review.openstack.org/19652619:21
*** sthillma has quit IRC19:24
*** harshs has joined #openstack-containers19:30
openstackgerritMartin Falatic proposed openstack/magnum: Updated Magnum documentation  https://review.openstack.org/19921219:31
mfalaticjjlehr - Thanks for the helpful feedback on my submission! I've resubmitted with updates.19:33
mfalaticAlso, is there something you ran that automated the doc check? Also, do any build jobs run automatically when we submit work for Magnum or is that something I need to run manually (I notice nothing had run yet for my initial submission)19:33
*** achanda has joined #openstack-containers19:37
openstackgerritHongbin Lu proposed openstack/magnum: Remove unreachable code in API utils  https://review.openstack.org/19804019:39
*** kebray has joined #openstack-containers19:40
openstackgerritHongbin Lu proposed openstack/magnum: Validate bay type on creating resources  https://review.openstack.org/19845619:41
*** skoar has joined #openstack-containers19:42
openstackgerritHongbin Lu proposed openstack/magnum: Eliminate mutable default arguments  https://review.openstack.org/19846519:45
*** dims has quit IRC19:48
*** jruano has joined #openstack-containers19:49
*** kebray has quit IRC19:50
*** david-lyle has joined #openstack-containers19:50
*** adrian_otto has joined #openstack-containers19:59
*** adrian_otto has quit IRC20:00
*** wshao has joined #openstack-containers20:00
*** adrian_otto has joined #openstack-containers20:01
*** kebray has joined #openstack-containers20:04
*** manjeets has joined #openstack-containers20:12
*** fawadkhaliq has quit IRC20:15
*** kebray has quit IRC20:17
jjlehrmfalatic: No problem! The trailing whitespaces and unused indents are highlighted in red by gerrit. I would think the pep8 tests would catch those. You can run the pep8 tests by following the testing instructions in the quickstart guide.20:18
jjlehrhttps://github.com/openstack/magnum/blob/master/doc/source/dev/dev-quickstart.rst#setup-dev-environment20:18
*** kebray has joined #openstack-containers20:18
jjlehrUsually Jenkins automatically runs build jobs and tests when you submit a change for review. Perhaps it doesn't run them if no actual code changes are made, but I don't know. Perhaps someone else could answer that better.20:19
*** daneyon has quit IRC20:26
*** skoar has quit IRC20:28
*** coolsvap is now known as coolsvap|away20:39
mfalaticjjlehr - I wouldn't have considered pep8 to be appropriate for docs in general, but the main question was whether you ran a tool specifically for checking docs (and evidently there's not one). I will pay closer attention to such potential bugs in the future though, I just could've sworn I squashed them on the first pass! :-D20:41
mfalatic(I should've caught most of them in my usual editor anyway)20:42
mfalaticjjlehr Most importantly, thank you again for catching that!20:43
*** sthillma has joined #openstack-containers20:46
jjlehrmfalatic: Oh duh, of course pep8 wouldn't be appropriate....silly me :)20:46
mfalaticWell, strictly speaking it might work, but it's not the first thing I'd reach for...20:48
jjlehrLooks like Jenkins got around to your change after all20:59
mfalaticIndeed!20:59
*** jjfreric has quit IRC21:01
*** wshao has quit IRC21:03
*** julim_ has quit IRC21:04
*** daneyon has joined #openstack-containers21:10
*** dims has joined #openstack-containers21:13
*** wshao has joined #openstack-containers21:13
*** kebray has quit IRC21:16
*** skoar has joined #openstack-containers21:19
*** sdake_ is now known as sdake21:20
*** kebray has joined #openstack-containers21:21
*** dboik has quit IRC21:25
*** dims has quit IRC21:30
*** pradk has quit IRC21:32
*** ameybhide has joined #openstack-containers21:34
*** dims has joined #openstack-containers21:35
*** dims has quit IRC21:35
*** Guest7393 has joined #openstack-containers21:35
*** dane_leblanc has quit IRC21:41
*** manjeets_ has joined #openstack-containers21:41
*** manjeets has quit IRC21:43
*** rpothier has quit IRC21:44
*** sdake_ has joined #openstack-containers21:48
*** wshao has quit IRC21:51
*** sdake has quit IRC21:52
*** jjlehr has quit IRC21:55
*** Drago has quit IRC22:00
*** wshao has joined #openstack-containers22:05
*** Drago has joined #openstack-containers22:07
*** unicell has quit IRC22:10
*** unicell has joined #openstack-containers22:10
suro-patzjjlehr: mfalatic: our tox.ini excludes 'doc/' for target pep8/flake8, but 'tox -edocs' should be good for testing the doc changes - https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-quickstart.rst#building-developer-documentation22:12
suro-patzhttps://github.com/openstack/magnum/blob/master/tox.ini#L6122:14
*** wshao has quit IRC22:20
*** fawadkhaliq has joined #openstack-containers22:22
openstackgerritTon Ngo proposed openstack/magnum: Instruction for building Fedora Atomic image  https://review.openstack.org/19614522:24
*** Tango has quit IRC22:31
*** daneyon has quit IRC22:34
*** adrian_otto has quit IRC22:44
*** jruano has quit IRC22:58
*** fawadkhaliq has quit IRC23:02
*** hongbin has quit IRC23:06
*** absubram has quit IRC23:11
*** zhenguo has joined #openstack-containers23:14
*** Tango has joined #openstack-containers23:15
mfalaticsdake - can I get your input on https://review.openstack.org/199212 ?23:19
*** manjeets_ has quit IRC23:19
openstackgerritTon Ngo proposed openstack/magnum: Instruction for building Fedora Atomic image  https://review.openstack.org/19614523:33
*** yuanying_ has joined #openstack-containers23:53
*** kebray has quit IRC23:56
*** yuanying has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!