| *** chandan_kumar has joined #openstack-climate | 05:00 | |
| *** bauzas has joined #openstack-climate | 07:21 | |
| bauzas | DinaBelova: hi, today's Climate day for me :) | 08:35 |
|---|---|---|
| DinaBelova | bauzas :D | 08:38 |
| DinaBelova | heh)) | 08:38 |
| DinaBelova | nice) | 08:38 |
| bauzas | DinaBelova: I was looking at the devstack error | 08:39 |
| DinaBelova | yes? | 08:39 |
| bauzas | have you seen the error by itself yet ? | 08:39 |
| bauzas | http://logs.openstack.org/10/89910/1/check/gate-climate-devstack-dsvm/7e9c822/logs/devstacklog.txt.gz | 08:39 |
| bauzas | 2014-04-23 19:00:36.841 | Creating nova aggregate used as freepool for Climate Host Reservation | 08:39 |
| bauzas | 2014-04-23 19:00:36.842 | ++ create_climate_aggregate_freepool | 08:39 |
| bauzas | 2014-04-23 19:00:36.844 | ++ nova aggregate-create freepool | 08:39 |
| bauzas | 2014-04-23 19:00:37.412 | ERROR (NotFound): Not found (HTTP 404) | 08:39 |
| bauzas | hence the error | 08:39 |
| bauzas | so I'm approving changes that are not related to this | 08:41 |
| DinaBelova | heh, yes | 08:50 |
| DinaBelova | strange error | 08:50 |
| DinaBelova | probably we need to investigate where it's from | 08:50 |
| DinaBelova | as that's bad :( | 08:51 |
| bauzas | yup | 08:53 |
| openstackgerrit | A change was merged to stackforge/climate: Fixes the problem of tenant_id key error https://review.openstack.org/89910 | 08:54 |
| openstackgerrit | A change was merged to stackforge/python-climateclient: Updated from global requirements https://review.openstack.org/89255 | 09:37 |
| openstackgerrit | A change was merged to stackforge/python-climateclient: Add sort-by option for climateclient list commands https://review.openstack.org/87949 | 09:50 |
| openstackgerrit | A change was merged to stackforge/climate: Added V2 API auth configuration to devstack https://review.openstack.org/89418 | 10:02 |
| DinaBelova | bauzas, Nikolay_1t, scroiset_ - I've wrote letter to dev ML | 10:11 |
| DinaBelova | about nominating Pablo Andres Fuente for the Climate core reviewers team | 10:11 |
| DinaBelova | so please leave your +1/-1 there)) | 10:11 |
| bauzas | sure | 10:11 |
| *** chandan_kumar has quit IRC | 11:45 | |
| *** cmart has joined #openstack-climate | 12:59 | |
| cmart | hello! | 13:01 |
| bauzas | cmart: hi | 13:03 |
| cmart | bauzas: thanks for all your comments.. they're really helpful! | 13:04 |
| cmart | however, there are some of those that I didn´t understand.. | 13:04 |
| bauzas | cmart: sure, let me know | 13:04 |
| cmart | Most of them, related to https://review.openstack.org/#/c/89833/ | 13:05 |
| cmart | what do you mean with amend APIv2 tests? Is just to add tests that check that a new parameter is coming? | 13:06 |
| bauzas | no | 13:06 |
| bauzas | I mean, there is a fake_lease() method in the tests | 13:06 |
| bauzas | which is reproducing a lease | 13:06 |
| bauzas | you should add your own field in there | 13:06 |
| bauzas | and you also missed to amend the WSME complex type for a lease | 13:07 |
| cmart | Oh.. I see.. | 13:07 |
| bauzas | you have to define a new attribute for the Lease object | 13:07 |
| bauzas | in the leases.py module | 13:07 |
| bauzas | and set it to a WSME type | 13:07 |
| bauzas | and also modify the sample() method | 13:07 |
| bauzas | to add it | 13:07 |
| cmart | I didn´t know about that | 13:08 |
| bauzas | if no, it won't generate the autodoc for it | 13:08 |
| bauzas | yey | 13:08 |
| cmart | OK.. Will work on that.. | 13:08 |
| bauzas | WSME requires to define static types | 13:08 |
| bauzas | for API objects | 13:08 |
| bauzas | but the good thing is that allows to do input validation at the API level | 13:09 |
| bauzas | so, if someone is not passing a datetime as param, it will raise an Exception | 13:09 |
| bauzas | before even the API controller | 13:09 |
| cmart | Do you have idea if we could use that not only to check the object type but the format date? | 13:10 |
| bauzas | I don't understand | 13:10 |
| bauzas | take the end_date WSME type | 13:10 |
| bauzas | end_date = types.Datetime(service.LEASE_DATE_FORMAT) | 13:10 |
| cmart | that's it! | 13:11 |
| cmart | nevermind | 13:11 |
| bauzas | that's defined in climate.api.v2.controllers.types | 13:11 |
| cmart | that line answers my question hehe | 13:11 |
| bauzas | don't forget the sample() method | 13:11 |
| bauzas | that allows to autogenerate API document | 13:12 |
| bauzas | documentation I mean | 13:12 |
| cmart | yes! That's the last working item I have.. | 13:12 |
| bauzas | https://github.com/stackforge/climate/blob/master/climate/api/v2/controllers/types.py#L118 | 13:12 |
| cmart | will work on that as soon as I finished the changes that people requested on my patch | 13:12 |
| bauzas | here is the code for validating the format | 13:13 |
| cmart | (y) | 13:13 |
| bauzas | you can amend it if you wish | 13:13 |
| bauzas | but you're sure to have this check | 13:13 |
| bauzas | that should not be done at the manager level | 13:13 |
| bauzas | you can backport your validation code from the manager to API v1 | 13:14 |
| bauzas | that's safier | 13:14 |
| cmart | OK | 13:14 |
| bauzas | as it prevents to go thru RPC | 13:14 |
| bauzas | before being checked | 13:14 |
| cmart | One last thing: could you please take a look at https://review.openstack.org/#/c/87352/? Is the tempest stuff I worked on a couple of weeks ago... It will be great to have your feedback | 13:14 |
| bauzas | yey, I know | 13:14 |
| bauzas | I have 2 more big patches to review | 13:15 |
| bauzas | the one for tempest and the one for PR using trusts | 13:15 |
| bauzas | both are really huge | 13:15 |
| cmart | OK.. No problem | 13:15 |
| bauzas | now I'm reviewing Nova code, these ones are definitely bigger to review :) | 13:15 |
| cmart | :D | 13:16 |
| bauzas | DinaBelova: you there ? | 13:16 |
| DinaBelova | yep | 13:16 |
| bauzas | cool | 13:16 |
| DinaBelova | :D | 13:17 |
| bauzas | DinaBelova: nevermind | 13:17 |
| *** casanch1 has joined #openstack-climate | 13:22 | |
| casanch1 | hi | 13:26 |
| casanch1 | what is the problem you have with devstack | 13:26 |
| DinaBelova | casanch1, you may take a look on the logs of some changes | 13:28 |
| DinaBelova | dvsm job is failing :? | 13:28 |
| DinaBelova | with no climate tabs started | 13:28 |
| DinaBelova | [12:39:31] <bauzas> http://logs.openstack.org/10/89910/1/check/gate-climate-devstack-dsvm/7e9c822/logs/devstacklog.txt.gz | 13:28 |
| DinaBelova | [12:39:52] <bauzas> 2014-04-23 19:00:36.841 | Creating nova aggregate used as freepool for Climate Host Reservation | 13:28 |
| DinaBelova | [12:39:52] <bauzas> 2014-04-23 19:00:36.842 | ++ create_climate_aggregate_freepool | 13:28 |
| DinaBelova | [12:39:52] <bauzas> 2014-04-23 19:00:36.844 | ++ nova aggregate-create freepool | 13:28 |
| DinaBelova | [12:39:52] <bauzas> 2014-04-23 19:00:37.412 | ERROR (NotFound): Not found (HTTP 404) | 13:28 |
| cmart | bauzas, are you there? | 13:40 |
| bauzas | cmart: up | 13:40 |
| bauzas | yup | 13:40 |
| cmart | quick question.. regarding the WSME stuff.. this new param is optional. What would happen if I add the stuff you asked but the request don't contains the parameter? | 13:41 |
| bauzas | that's not mandatory | 13:42 |
| bauzas | see the update method for the lease | 13:42 |
| bauzas | we define the body as a Lease | 13:42 |
| bauzas | but when updating, only a few attributes are given | 13:42 |
| *** pafuent has joined #openstack-climate | 13:45 | |
| cmart | Oh I see.. thanks! | 13:45 |
| pafuent | Hi. Regarding the gate-climate-devstack-dsvm failures, something weird is happening to Keystone (http://logs.openstack.org/33/89833/3/check/gate-climate-devstack-dsvm/804400b/logs/screen-key.txt.gz) | 13:51 |
| pafuent | I'm checking if I could reproduce this thing locally | 13:51 |
| cmart | that happened to me yesterday | 13:52 |
| cmart | just one time.. and once I restarted the all stack, it was fixed | 13:52 |
| cmart | I didn´t update the keystone module.. but I can try if you want to.. | 13:52 |
| pafuent | cmart: Please, try it again (four eyes is better than two) | 13:54 |
| cmart | I'll update the keystone module and let you know... new core reviewer... :):) | 13:55 |
| pafuent | :-D | 13:55 |
| cmart | bauzas: are you still there? | 14:05 |
| bauzas | yes | 14:05 |
| cmart | https://review.openstack.org/#/c/87684/3/climateclient/v1/leases.py | 14:06 |
| cmart | your comments around the way we are parsing the params.. | 14:06 |
| cmart | you pointed out the oslo timeutils module to do this, but I'm not sure how | 14:07 |
| cmart | I mean, it makes sense to use some of the methods on that module, but the "switch" that we have seems good to me | 14:08 |
| cmart | I have two patches around that and I could refactor the all thing.. | 14:09 |
| cmart | and since we don´t have tests for that, I could also work on the https://review.openstack.org/#/c/73574/... | 14:10 |
| cmart | (which are client tests) | 14:10 |
| cmart | for the stuff related to the client params, I suggest that we have a method that can convert an elapsed time that matches a regex into a seconds. | 14:11 |
| cmart | smth like seconds = elapsed_time_to_seconds(elapsed_time_expression, regex) | 14:12 |
| cmart | and inside that, use some of the timeutils methods you mentioned | 14:12 |
| cmart | any comments? | 14:18 |
| cmart | cd .. | 14:20 |
| cmart | ls | 14:20 |
| cmart | sorry! wrong window | 14:20 |
| pafuent | hahaha | 14:20 |
| bauzas | sorry, was aeound | 14:31 |
| cmart | bauzas: np | 14:38 |
| *** chandan_kumar has joined #openstack-climate | 15:04 | |
| *** pafuent has quit IRC | 15:04 | |
| *** pafuent has joined #openstack-climate | 15:10 | |
| *** chandan_kumar has quit IRC | 15:16 | |
| *** pafuent has left #openstack-climate | 15:17 | |
| *** pafuent has joined #openstack-climate | 15:18 | |
| *** pafuent has quit IRC | 16:01 | |
| *** pafuent has joined #openstack-climate | 16:03 | |
| *** bauzas has quit IRC | 16:12 | |
| *** chandan_kumar has joined #openstack-climate | 16:25 | |
| *** pafuent has left #openstack-climate | 16:44 | |
| *** pafuent has joined #openstack-climate | 16:47 | |
| *** chandan_kumar has quit IRC | 17:19 | |
| *** chandan_kumar has joined #openstack-climate | 17:19 | |
| *** casanch1 has quit IRC | 17:31 | |
| openstackgerrit | Pablo Andres Fuente proposed a change to stackforge/climate: API returns project/user/trust ids without dashes https://review.openstack.org/89412 | 17:51 |
| *** casanch1 has joined #openstack-climate | 18:30 | |
| pafuent | I found why our devstack is failing | 18:37 |
| pafuent | Devstack commit 3317437caca5eb769ab4c6d3ea7c5d3e062517e2 | 18:37 |
| pafuent | "No need to set osapi_compute_extension and volume_api_class to there default values." | 18:38 |
| pafuent | I'll fill a bug for it, and submit a patch | 18:40 |
| pafuent | We need that default value, because our devstack is overriding the default value, so no default nova extensions are loaded | 18:41 |
| *** chandan_kumar has quit IRC | 18:52 | |
| DinaBelova | pafuent, cool, thanks! | 19:12 |
| *** chandan_kumar has joined #openstack-climate | 19:16 | |
| pafuent | DinaBelova: :) | 19:20 |
| *** chandan_kumar has quit IRC | 19:23 | |
| openstackgerrit | Pablo Andres Fuente proposed a change to stackforge/climate: Set osapi_compute_extensions default value https://review.openstack.org/90206 | 19:45 |
| openstackgerrit | Christian Martinez proposed a change to stackforge/climate: API Support for before_end param configuration https://review.openstack.org/89833 | 20:16 |
| *** casanch1_ has joined #openstack-climate | 20:32 | |
| *** casanch1 has quit IRC | 20:36 | |
| *** cmart has quit IRC | 20:36 | |
| *** casanch1_ has quit IRC | 21:05 | |
| *** casanch1 has joined #openstack-climate | 21:05 | |
| *** pafuent has left #openstack-climate | 21:22 | |
| *** casanch1 has quit IRC | 21:30 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!