*** f_rossigneux has joined #openstack-climate | 00:40 | |
*** f_rossigneux has quit IRC | 01:46 | |
*** chandankumar has joined #openstack-climate | 04:15 | |
*** chandankumar has quit IRC | 05:00 | |
*** chandankumar has joined #openstack-climate | 05:01 | |
*** SergeyLukjanov has joined #openstack-climate | 05:29 | |
*** YorikSar has quit IRC | 05:31 | |
*** SergeyLukjanov has quit IRC | 06:31 | |
*** SergeyLukjanov has joined #openstack-climate | 07:28 | |
openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Add utils to work with openstack components https://review.openstack.org/52296 | 07:43 |
---|---|---|
*** DinaBelova has joined #openstack-climate | 08:18 | |
*** f_rossigneux has joined #openstack-climate | 08:22 | |
bauzas | Nikolay_St: oops, made comment about unittest missing on your patch while you were putting the CR as WIP :D | 08:29 |
Nikolay_St | bauzas: :D | 08:30 |
Nikolay_St | bauzas: don't mind. Just +1 if you agree with changes I've done | 08:31 |
bauzas | unfortunately not :( | 08:31 |
bauzas | I made some comments about the clients | 08:31 |
bauzas | I think we should have possbility to pass thru **kwargs the python-%service params | 08:32 |
bauzas | including the version | 08:32 |
bauzas | and also the context | 08:32 |
bauzas | for example, I have an usecase with the host reservation side | 08:33 |
bauzas | when as admin, I want to create a freepool | 08:33 |
bauzas | the freepool creation is done at startup when initializing plugins | 08:33 |
bauzas | and there, we don't have a context :) | 08:33 |
bauzas | I also saw that client params change for Nova depending on the version | 08:34 |
bauzas | that's why I think using **kwargs loose visibility but is more flexible | 08:34 |
bauzas | and then either you choose to parse **kwargs for readability or direct pass it when calling the client | 08:35 |
Nikolay_St | yeap, I get it. Loosing this poin of view yesterday | 08:37 |
bauzas | Nikolay_St: no pb ;) | 08:41 |
Nikolay_St | why don't you think that we haven't context when freepool is creating? | 08:49 |
Nikolay_St | bauzas: why don't you think that we haven't context when freepool is creating? | 08:49 |
bauzas | Nikolay_St: sorry, was afk | 09:17 |
bauzas | Nikolay_St: freepool is created when we startup the Manager | 09:17 |
bauzas | there is call to setup() | 09:17 |
bauzas | on that moment, there is no context created in the current thread stack | 09:18 |
bauzas | as it's done when receiving an API call | 09:18 |
bauzas | where we get the headers from the request | 09:18 |
bauzas | there is also a second case where some actions could be done decorrelated from the user requests | 09:19 |
bauzas | like when using _event() for instance | 09:19 |
Nikolay_St | bauzas: wow | 09:21 |
bauzas | Nikolay_St: wow what ? :D | 09:23 |
*** DinaBelova has quit IRC | 09:23 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 09:28 | |
*** _SergeyLukjanov has quit IRC | 09:29 | |
*** SergeyLukjanov has joined #openstack-climate | 09:53 | |
openstackgerrit | A change was merged to stackforge/climate: Implement primary support for i18n messages shown to user https://review.openstack.org/59986 | 10:18 |
*** f_rossigneux has quit IRC | 10:18 | |
*** YorikSar has joined #openstack-climate | 10:37 | |
*** DinaBelova has joined #openstack-climate | 11:10 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 11:13 | |
openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Add utils to work with openstack components https://review.openstack.org/52296 | 11:13 |
*** _SergeyLukjanov has quit IRC | 11:13 | |
*** SergeyLukjanov has joined #openstack-climate | 12:03 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 12:03 | |
*** _SergeyLukjanov has quit IRC | 12:05 | |
*** SergeyLukjanov has joined #openstack-climate | 12:09 | |
*** chandankumar_ has joined #openstack-climate | 12:25 | |
*** chandankumar is now known as ciypro | 12:29 | |
*** DinaBelova has quit IRC | 12:41 | |
*** f_rossigneux has joined #openstack-climate | 12:44 | |
openstackgerrit | François Rossigneux proposed a change to stackforge/climate: Physical host reservation https://review.openstack.org/54285 | 12:52 |
openstackgerrit | François Rossigneux proposed a change to stackforge/climate: Physical host reservation https://review.openstack.org/54285 | 13:15 |
*** DinaBelova has joined #openstack-climate | 14:06 | |
*** YorikSar has quit IRC | 14:08 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 14:11 | |
*** _SergeyLukjanov has quit IRC | 14:12 | |
*** SergeyLukjanov has joined #openstack-climate | 14:16 | |
*** DinaBelova has quit IRC | 14:27 | |
*** DinaBelova has joined #openstack-climate | 14:27 | |
*** chandankumar_ has quit IRC | 14:38 | |
DinaBelova | bauzas, you here? | 15:54 |
bauzas | DinaBelova: yup | 15:54 |
DinaBelova | I'm about sending my cr to climate-nova | 15:55 |
DinaBelova | and i found one interestinf line | 15:55 |
DinaBelova | interesting* | 15:55 |
DinaBelova | https://github.com/stackforge/climate-nova/blob/master/climate/filters/host_reservation.py#L19 | 15:55 |
DinaBelova | really here will be conflict | 15:55 |
DinaBelova | because of climate-nova openstack-common | 15:55 |
DinaBelova | and the same for nova | 15:56 |
DinaBelova | i just try to understand | 15:56 |
DinaBelova | why we may not use here openstack-common from nova | 15:56 |
DinaBelova | like from nova.openstack.common import log as logging | 15:56 |
DinaBelova | not from climate.openstack.common import log as logging | 15:56 |
DinaBelova | because we still install nova | 15:56 |
DinaBelova | with all openstack.common file | 15:57 |
DinaBelova | files* | 15:57 |
bauzas | I'm currently editing this file :) | 15:57 |
DinaBelova | :D | 15:57 |
bauzas | there is no way to import climate | 15:57 |
bauzas | in the filter code | 15:57 |
bauzas | because it will be run on Nova side | 15:57 |
DinaBelova | i'm saying about importing nova | 15:57 |
DinaBelova | now there is climate.openstack.common import log as logging | 15:58 |
bauzas | yeah | 15:58 |
bauzas | lemme be clear | 15:58 |
DinaBelova | climate as internal module for climate-nova | 15:58 |
bauzas | noooo | 15:58 |
bauzas | it shouldn't | 15:58 |
bauzas | lemme explain | 15:58 |
DinaBelova | ok | 15:58 |
bauzas | this code is basically a filter for Nova | 15:58 |
DinaBelova | yep | 15:58 |
bauzas | running on Nova scheduler | 15:58 |
DinaBelova | yep | 15:58 |
bauzas | so, there is no reasons to have climate as a dependency for nova | 15:59 |
bauzas | the scheduler can be on a separate host | 15:59 |
DinaBelova | there is no such dependency right now 0_0 | 15:59 |
DinaBelova | look here https://github.com/stackforge/climate-nova | 15:59 |
DinaBelova | there is just directory | 15:59 |
DinaBelova | called climate | 15:59 |
bauzas | yep, this whole repo sucks | 15:59 |
DinaBelova | it's not dependency :) | 15:59 |
bauzas | to be honest | 15:59 |
DinaBelova | :D | 15:59 |
bauzas | I mean, we did that for exporting the Nova stuff | 16:00 |
bauzas | but what is part of Nova should be part of Nova | 16:00 |
DinaBelova | I just propose remove whole climate-nova/climate/openstack | 16:00 |
DinaBelova | because we may use nova/nova/openstack/common | 16:00 |
DinaBelova | as it is anyway installed here | 16:00 |
bauzas | well, from my POV, after thinking about this repo this day, I ended up thinking it should ony contain references to Nova | 16:01 |
DinaBelova | +1 | 16:01 |
DinaBelova | +! | 16:01 |
bauzas | we should even put that code into Nova.contrib | 16:01 |
bauzas | like nova.scheduler.contrib | 16:01 |
DinaBelova | mmm, in nova repo itself? | 16:01 |
DinaBelova | don't think it's a good idea, if i caught it right | 16:01 |
bauzas | but until we get incubated and are enough old to speak with Nova guys, we can leave this repo | 16:02 |
DinaBelova | yep | 16:02 |
DinaBelova | ok | 16:02 |
DinaBelova | understood you | 16:02 |
DinaBelova | let's leave climate-nova repo | 16:02 |
bauzas | yep | 16:02 |
DinaBelova | with only dependencies to nova | 16:02 |
bauzas | but chase any import climate.* deps :) | 16:02 |
DinaBelova | and test things | 16:02 |
bauzas | yep | 16:02 |
DinaBelova | okay | 16:02 |
bauzas | I'll send a draft tonight | 16:02 |
DinaBelova | will you do that? | 16:02 |
DinaBelova | ok | 16:02 |
DinaBelova | great | 16:02 |
bauzas | I'm now finishing up to move the exceptions apart | 16:03 |
DinaBelova | I just was frustrated | 16:03 |
DinaBelova | seeing that today | 16:03 |
DinaBelova | ok, so I'll publish my cr | 16:03 |
bauzas | that's necessary for fixing the bug about Manager raising errors500 to API | 16:03 |
bauzas | yup | 16:03 |
DinaBelova | with only my small things | 16:03 |
bauzas | we'll coordinate later | 16:03 |
DinaBelova | and let you do all other :) | 16:03 |
DinaBelova | ok | 16:03 |
bauzas | sure thing | 16:03 |
*** DinaBelova has quit IRC | 16:21 | |
openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Fix Manager exceptions rendering for end-users https://review.openstack.org/63445 | 16:21 |
*** bauzas has quit IRC | 16:35 | |
*** f_rossigneux has quit IRC | 16:44 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 17:00 | |
*** _SergeyLukjanov has quit IRC | 17:00 | |
*** ciypro has quit IRC | 17:25 | |
*** f_rossigneux has joined #openstack-climate | 17:46 | |
*** SergeyLukjanov has joined #openstack-climate | 18:34 | |
*** chandankumar_ has joined #openstack-climate | 21:32 | |
*** f_rossigneux has quit IRC | 22:18 | |
*** SergeyLukjanov has quit IRC | 22:22 | |
*** f_rossigneux has joined #openstack-climate | 22:31 | |
*** f_rossigneux has quit IRC | 22:48 | |
*** chandankumar_ has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!