| opendevreview | jayaanand borra proposed openstack/cinder master: [NetApp] LUN space allocation support for iSCSI https://review.opendev.org/c/openstack/cinder/+/893106 | 11:33 |
|---|---|---|
| opendevreview | Brian Rosmaita proposed openstack/cinderlib master: Use openstack-tox-py311 https://review.opendev.org/c/openstack/cinderlib/+/893368 | 13:10 |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Quiet Fungible invalid UUID warnings https://review.opendev.org/c/openstack/cinder/+/893373 | 13:51 |
| happystacker | hey good morning there! It's been a while, vacation and military duty are now done, I need to get back to work and sync up with you | 14:29 |
| opendevreview | Jay Faulkner proposed openstack/cinder stable/2023.1: Add default to read_deleted in context's from_dict https://review.opendev.org/c/openstack/cinder/+/893255 | 14:31 |
| opendevreview | Jay Faulkner proposed openstack/cinder stable/zed: Add default to read_deleted in context's from_dict https://review.opendev.org/c/openstack/cinder/+/893258 | 14:32 |
| opendevreview | Jay Faulkner proposed openstack/cinder stable/yoga: Add default to read_deleted in context's from_dict https://review.opendev.org/c/openstack/cinder/+/893259 | 14:32 |
| opendevreview | Jay Faulkner proposed openstack/cinder stable/xena: Add default to read_deleted in context's from_dict https://review.opendev.org/c/openstack/cinder/+/893382 | 14:32 |
| opendevreview | Jay Faulkner proposed openstack/cinder master: Update bindep.txt for bookworm to fix 3.11 tests https://review.opendev.org/c/openstack/cinder/+/893402 | 14:50 |
| JayF | Hello Cinder friends o/ I'm sorry but an oslo.messaging fix broke notifications for you all, patches exist to fix here: https://review.opendev.org/c/openstack/cinder/+/893200 (and backported through), if they could get core reviews | 14:53 |
| JayF | I backported through xena, which is as far as the oslo.messaging change was backported. | 14:53 |
| *** dviroel_ is now known as dviroel | 14:59 | |
| whoami-rajat | thanks rosmaita , it's merged now so I've updated the release patch | 15:46 |
| zaitcev | rosmaita: Thanks for the tip, I was able to import the XS Review from ical file. | 17:29 |
| zaitcev | (for every third Friday 14:00 UTC) | 17:30 |
| opendevreview | Jay Faulkner proposed openstack/cinder master: Add default to read_deleted in context https://review.opendev.org/c/openstack/cinder/+/893429 | 18:53 |
| JayF | ^ is an alternate version of the fix from https://review.opendev.org/c/openstack/cinder/+/893200 as suggested by vasyl | 18:55 |
| JayF | I do not care which one lands, but I'd like to get cinder fixed before FF since I broke it :( | 18:55 |
| jbernard | JayF: reponded, i perfer the first version | 19:44 |
| jbernard | JayF: left a +2, will revisit tomorrow if someone doesn't weight in on one fo them by then | 19:45 |
| JayF | Yeah, I have no preference but I am the author of the oslo.messaging fix that broke you all so I'm trying to get everyone fixed | 19:45 |
| jbernard | JayF: appreciated | 19:45 |
| JayF | I have backports all the way to xena as well, so if you land that please take a look at least at the first step | 19:45 |
| jbernard | JayF: i saw, also thanks, that's helpful | 19:45 |
| JayF | I abandoned the oslo.messaging fix further back as I know Cinder doesn't play in the oldest branches | 19:45 |
| jbernard | JayF: once we have a consensus on master, we'll get the backports sorted asap | 19:46 |
| JayF | ack; sounds good. The manila fix already hit master there so hopefully they'll land the backports soon, too. | 19:46 |
| jbernard | JayF: i would have added +A, but I'm a newer core and want to make sure one of the others gets a say | 19:47 |
| JayF | BTW, we are working on a better version of this fix for moving-forward, let me link it up | 19:47 |
| jbernard | JayF: please | 19:47 |
| JayF | jbernard: once https://review.opendev.org/c/openstack/oslo.context/+/891608 lands and is in requirements, we'll update oslo.messaging to use this method instead of filtering itself | 19:48 |
| JayF | jbernard: this would allow cinder, for instance, to decide that their redacted_copy should include a faithful copy of read_deleted (it probably should TBH) | 19:48 |
| jbernard | JayF: how can we best /not/ loose this information in the next cycle? Maybe I can add myself as reviewer to the oslo update... | 19:49 |
| JayF | yeah it's the moving forward oslo fix for it long term | 19:50 |
| jbernard | JayF: or will you push out changes to the effected projects? | 19:50 |
| JayF | Well, this is a backwards compatible move (with oslo.context + oslo.messaging) that enables customization (right now nothing Cinder code can do to pass read_deleted value to notification) | 19:50 |
| jbernard | I'll make a note to revisit once https://review.opendev.org/c/openstack/oslo.context/+/891608 lands | 19:50 |
| JayF | I don't think it's my intent to do that customization in each project | 19:51 |
| JayF | because I don't have the needed (pun not intended) context on them | 19:51 |
| jbernard | lol | 19:51 |
| JayF | but I'm happy to review such changes :) | 19:51 |
| jbernard | ok cool, thanks for the patches! | 19:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!