| opendevreview | Ghanshyam proposed openstack/cinder-tempest-plugin master: Update stable jobs on master gate https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/885669 | 03:34 |
|---|---|---|
| opendevreview | Alexander Deiter proposed openstack/cinder stable/wallaby: Fix Infinidat driver to return all iSCSI portals https://review.opendev.org/c/openstack/cinder/+/871906 | 11:12 |
| sfv880_ | Hello, could you please help me ? My pull request has been successfully reviewed (https://review.opendev.org/c/openstack/cinder/+/871906), but it cannot be merged due to known issue with zuul job. I submitted another change for cinder stable/wallaby to fix this issue. Could you please review: https://review.opendev.org/c/openstack/cinder/+/885448 ? Thank you very much! | 13:59 |
| whoami-rajat | Cinder festival of spec reviews | 14:02 |
| whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin adiare happystacker dosaboy hillpd | 14:02 |
| whoami-rajat | Meeting link: https://meet.google.com/juc-wgcw-kvo?authuser=0 | 14:02 |
| whoami-rajat | Etherpad: https://etherpad.opendev.org/p/cinder-2023-2-bobcat-specs | 14:02 |
| tosky | sfv880_: the change with the job should be probably fixed in the job definition itself, on cinder-tempest-plugin | 14:04 |
| tosky | uhm | 14:05 |
| tosky | no | 14:05 |
| tosky | you are right | 14:05 |
| sfv880_ | tosky: Thank you! I already tested this change on my local env. | 14:05 |
| tosky | I mean, the change may be correct, but my objection was that it may not have been the cleanest solution | 14:06 |
| sfv880_ | got it - thank you! | 14:06 |
| tosky | yeah, looking more at the issue, I suspect it should be moved to cinder-tempest-plugin | 14:06 |
| sfv880_ | tosky: Thank you for the review! Please let me move it to cinder-tempest-plugin. | 14:19 |
| opendevreview | Alexander Deiter proposed openstack/cinder-tempest-plugin master: Fixed cinder-tempest-plugin-lvm-lio-barbican job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/885770 | 14:27 |
| sfv880_ | tosky: done - https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/885770 - please review, thank you very much! | 14:28 |
| tosky | do you want to test your other cinder patch with a depends-on on the cinder-tempest-plugin patch? | 14:31 |
| sfv880_ | yes - if it possible! | 14:35 |
| tosky | but the review should be changed | 14:35 |
| opendevreview | Toheeb Oyekola proposed openstack/cinder master: Automate generation of backups api-ref samples https://review.opendev.org/c/openstack/cinder/+/885765 | 14:44 |
| opendevreview | Alexander Deiter proposed openstack/cinder-tempest-plugin master: Fixed cinder-tempest-plugin-lvm-lio-barbican job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/885770 | 14:50 |
| *** geguileo is now known as Guest2586 | 14:53 | |
| *** Guest2586 is now known as geguileo | 14:53 | |
| sfv880_ | tosky: Thank you very much for the review and detailed explanations! fixed by patch set #2. Please review - thank you! | 14:53 |
| tosky | sfv880_: I still think a review which depends-on both your original review and the cinder-tempest-plugin one would provide useful information to approve the change | 15:04 |
| ganso | rosmaita, whoami-rajat: hi! one more +2 needed for this backport, if you could please take a quick look when you have a minute. thanks in advance! https://review.opendev.org/c/openstack/cinder/+/885255 | 15:04 |
| rosmaita | ganso: ack | 15:05 |
| sfv880_ | tosky: sure - please let me try! | 15:06 |
| whoami-rajat | ganso, sorry haven't been able to pay attention to it, approved | 15:07 |
| whoami-rajat | rosmaita, ^ no need to look, i approved it :D | 15:07 |
| rosmaita | race condition! | 15:07 |
| whoami-rajat | it's a common thing in cinder | 15:08 |
| sfv880_ | Hello, could you please review another backport for Zed: 868179: Fix Infinidat driver generic volume migration | https://review.opendev.org/c/openstack/cinder/+/868179 ? One more +2 please! Thank you very much!!! | 15:10 |
| opendevreview | Alexander Deiter proposed openstack/cinder stable/wallaby: WIP: test for 871906 and 885770 https://review.opendev.org/c/openstack/cinder/+/885771 | 15:15 |
| opendevreview | Alexander Deiter proposed openstack/cinder stable/wallaby: WIP: test for 871906 and 885770 https://review.opendev.org/c/openstack/cinder/+/885771 | 15:24 |
| opendevreview | Tony Saad proposed openstack/os-brick master: Dell Powerflex: Add new VOLUME_ALREADY_MAPPED_ERROR https://review.opendev.org/c/openstack/os-brick/+/885772 | 17:23 |
| sfv880_ | tosky: Hello, please review the test results: https://review.opendev.org/c/openstack/cinder/+/885771 and dependent review - https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/885770 - thank you very much! | 19:13 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!