| opendevreview | Merged openstack/cinder stable/wallaby: Check VMDK subformat against an allowed list https://review.opendev.org/c/openstack/cinder/+/871627 | 02:06 |
|---|---|---|
| opendevreview | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/871919 | 02:13 |
| opendevreview | Merged openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/871919 | 04:01 |
| opendevreview | Hao Wang proposed openstack/cinder master: Support multiple filters together for volume time comparison filter https://review.opendev.org/c/openstack/cinder/+/740146 | 07:13 |
| whoami-rajat | simondodsley, hey, any reason why pure FC CI is failing and non-voting? | 10:40 |
| whoami-rajat | pure-devstack-cinder-tempest-fc-aio http://openstack-logs.purestorage.com/60/855060/13/thirdparty-check/pure-devstack-cinder-tempest-fc-aio/421180d/ : FAILURE in 1h 55m 31s (non-voting) | 10:40 |
| *** dviroel|uot is now known as dviroel|rover | 11:30 | |
| rosmaita | stable cores (other than sean): can I get a second +2 on my CVE patch backport to victoria, please? | 12:53 |
| rosmaita | https://review.opendev.org/c/openstack/cinder/+/871628 | 12:53 |
| rosmaita | e0ne eharney enriquetaso geguileo hemna jungleboyj whoami-rajat ^^ | 12:53 |
| LarsErikP | hi! I wonder if anything was done with this? https://specs.openstack.org/openstack/cinder-specs/specs/yoga/optimize-upload-volume-to-rbd-store.html | 12:54 |
| LarsErikP | I.. would really like it to be implemented :p | 12:54 |
| whoami-rajat | rosmaita, the conflicts keep increasing every release :D | 13:44 |
| rosmaita | whoami-rajat: on the plus side, it does mean that we've introduced some new features/improvements in the code over the past few cycles! | 13:57 |
| whoami-rajat | yeah, that's an good perspective on it! | 13:58 |
| whoami-rajat | s/an/a | 13:58 |
| whoami-rajat | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:59 |
| whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin adiare happystacker | 13:59 |
| opendevreview | Jean-Sébastien Bevilacqua proposed openstack/cinder master: Add cinder Driver for Lustre https://review.opendev.org/c/openstack/cinder/+/853785 | 14:04 |
| opendevreview | Jean-Sébastien Bevilacqua proposed openstack/cinder master: Add cinder Driver for Lustre https://review.opendev.org/c/openstack/cinder/+/853785 | 14:10 |
| opendevreview | Jean-Sébastien Bevilacqua proposed openstack/os-brick master: Add Lustre support in remote fs https://review.opendev.org/c/openstack/os-brick/+/853787 | 14:11 |
| opendevreview | Jean-Sébastien Bevilacqua proposed openstack/cinder master: Add cinder Driver for Lustre https://review.opendev.org/c/openstack/cinder/+/853785 | 14:20 |
| opendevreview | Eric Harney proposed openstack/os-brick master: Bump hacking to 4.1.0 https://review.opendev.org/c/openstack/os-brick/+/872137 | 14:46 |
| opendevreview | Merged openstack/cinder master: Dell PowerStore: Volume caching exception support https://review.opendev.org/c/openstack/cinder/+/867753 | 14:48 |
| dosaboy | hi folks, we've had a patch up for a little while that is impacting us quite badly and i was wondering if anyone could help with reviews | 14:49 |
| dosaboy | the patch is at https://review.opendev.org/c/openstack/cinder/+/868485 | 14:50 |
| dosaboy | (and thanks!) | 14:52 |
| eharney | dosaboy: do you know if large metadata values were previously allowed there? | 14:53 |
| dosaboy | eharney: iiuc they were always constrained to small values but i dont know if there was a reason behind that | 14:54 |
| dosaboy | i.e. there were using https://github.com/openstack/cinder/blob/master/cinder/api/validation/parameter_types.py#L150 | 14:55 |
| dosaboy | with 255 char limit | 14:55 |
| eharney | i was thinking before we added the validation layer | 14:55 |
| eharney | but thanks, seems like a significant one to review and sort out | 14:56 |
| dosaboy | ack | 14:56 |
| ganso | whoami-rajat: hi! could you please re-review https://review.opendev.org/c/openstack/cinder/+/812685/ when you have a minute? it addresses your previous concerns and rosmaita has +2'ed it | 15:02 |
| whoami-rajat | ganso, i already reviewed it, ok i see, the W+1 was removed due to a rebase | 15:03 |
| whoami-rajat | ganso, done | 15:03 |
| ganso | whoami-rajat: thanks! | 15:04 |
| whoami-rajat | np | 15:04 |
| enriquetaso | okay | 15:04 |
| enriquetaso | bug meeting | 15:04 |
| enriquetaso | #startmeeting cinder_bs | 15:05 |
| opendevmeet | Meeting started Wed Feb 1 15:05:07 2023 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:05 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:05 |
| opendevmeet | The meeting name has been set to 'cinder_bs' | 15:05 |
| whoami-rajat | hi | 15:05 |
| enriquetaso | Today we have 4 bugs | 15:05 |
| enriquetaso | hello | 15:05 |
| enriquetaso | #topic Quotas rollback error when retype failed | 15:05 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2004239 | 15:05 |
| enriquetaso | If admin tenants do retype to a volume owned by other tenants, and it fails for some reason, quota rollback will fail. Because it will try to find reservations with the admin tenant's project_id but not the volume owner's. | 15:05 |
| *** dviroel|rover is now known as dviroel|rover|lunch | 15:06 | |
| enriquetaso | i forget to ask the cinder version the reporter is using | 15:06 |
| enriquetaso | but looks like something cinder should fix soon | 15:06 |
| whoami-rajat | maybe it's addressed in geguileo quota work but that might take some time to merge | 15:08 |
| enriquetaso | oh, true, i'll check and add a comment for that then | 15:09 |
| enriquetaso | moving on | 15:09 |
| enriquetaso | #topic Hitachi: Cinder scheduler is down if backend is down | 15:09 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2004140 | 15:10 |
| enriquetaso | When the backend is down, the Cinder scheduler is also down with a key error, | 15:10 |
| enriquetaso | because Hitachi driver doesn't return all required keys in update_volume_stats(). | 15:10 |
| enriquetaso | Fix proposed to master: | 15:10 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/871269 | 15:10 |
| enriquetaso | i left a comment on the patch, needs update | 15:10 |
| eharney | if the bug report is correct, we need a fix for the scheduler, not just the hitachi driver, which is what is proposed | 15:10 |
| enriquetaso | moving on | 15:10 |
| eharney | that fix misses the actual problem | 15:11 |
| enriquetaso | good point | 15:11 |
| enriquetaso | im not sure how other drivers deal with the same problem | 15:12 |
| enriquetaso | if confirmed, we would need a new bug report for the scheduler along | 15:12 |
| enriquetaso | i'll left a comment and try to reproduce if nobody volunteers to do it | 15:13 |
| enriquetaso | okay.. last two bugs | 15:17 |
| enriquetaso | #topic [doc] Update 'Introduction to the Block Storage service in cinder' | 15:17 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2004419 | 15:17 |
| enriquetaso | The documentation states that "With the Block Storage service, you can attach a device to only one instance." However, Cinder multiattach was introduced in Queens, as described here https://docs.openstack.org/cinder/latest/admin/volume-multiattach.html. Please update the documentation to reflect that multiattach is possible in some scenarios. | 15:17 |
| enriquetaso | This could be a potential intern first contribution for Outreachy potential intern | 15:18 |
| rosmaita | good idea! | 15:18 |
| whoami-rajat | +1 | 15:18 |
| enriquetaso | :D cool | 15:19 |
| enriquetaso | last one | 15:19 |
| enriquetaso | #topic Replace plain Mock() calls with autospec=True or Mock(spec) | 15:19 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2004174 | 15:19 |
| enriquetaso | this is intended for potential Outreachy interns too | 15:19 |
| enriquetaso | Cinder has some tests with assertion typo's or plain calls to Mock() or MagicMock() resulting in those tests not testing code correctly. | 15:19 |
| enriquetaso | "The refactored code would replace plain Mock() calls with Mock(spec) calls | 15:19 |
| enriquetaso | or you can either pass autospec=True to patch() / patch.object() or use the create_autospec() function to create a mock with a spec. We want stronger mocks by using specs, do the right thing where needed to get this." | 15:19 |
| enriquetaso | okay! | 15:21 |
| eharney | i have one other bug to mention | 15:21 |
| opendevreview | Merged openstack/cinder stable/victoria: Check VMDK subformat against an allowed list https://review.opendev.org/c/openstack/cinder/+/871628 | 15:21 |
| enriquetaso | sure eharney | 15:21 |
| opendevreview | Merged openstack/cinder master: [Pure Storage] Add support for 3-site, trisync, replication. https://review.opendev.org/c/openstack/cinder/+/862365 | 15:21 |
| eharney | i just wrote https://bugs.launchpad.net/cinder/+bug/2004484 - rosmaita might be interested in this one | 15:21 |
| eharney | tox4 isn't showing useful output that tox3 did, we should fix it somehow | 15:21 |
| enriquetaso | #topic list dependencies with tox4 | 15:21 |
| eharney | because this is annoying | 15:22 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2004484 | 15:22 |
| enriquetaso | sounds fine | 15:22 |
| eharney | previously we logged all packages used in the env, now it doesn't unless you pass in an env variable | 15:22 |
| rosmaita | we do have pip freeze output on the ci jobs, though | 15:22 |
| eharney | oh, well that's good i guess | 15:22 |
| rosmaita | i'm just being a jerk because i didn't think of it | 15:23 |
| enriquetaso | like tox -e pipfreeze? | 15:23 |
| rosmaita | no, more like .tox/envname/bin/pip freeze | 15:23 |
| rosmaita | use the pip from the testenv | 15:23 |
| eharney | i didn't see an obvious way to set something in tox.ini to just make it do this, but it would be good for local developers to have it IMO | 15:24 |
| rosmaita | eharney: are you talking about the list of stuff that's all in one line just before the tests run? | 15:24 |
| eharney | rosmaita: yeah | 15:24 |
| rosmaita | ok, i always ignore it as hard to read and grep the pip freeze output | 15:24 |
| rosmaita | yeah, if you find the output useful, i don't object to adding the CI=1 | 15:25 |
| eharney | right, but i don't know how to add that for the local developer case :) | 15:25 |
| rosmaita | i think just in the setenv= in the testenv definition? | 15:26 |
| rosmaita | i can try it out later if you don't have time | 15:26 |
| eharney | i think that sets it too late for it to do anything | 15:26 |
| eharney | i tested it and didn't work, anyway | 15:26 |
| rosmaita | ok, well i am all out of ideas then | 15:26 |
| eharney | anyway, i wrote a bug because i wanted to do something else today, no need to figure it out now | 15:26 |
| rosmaita | ok, cool | 15:27 |
| rosmaita | i have one | 15:27 |
| rosmaita | https://review.opendev.org/c/openstack/cinder/+/871976 | 15:27 |
| rosmaita | enriquetaso: i asked on the patch to file a new bug | 15:27 |
| rosmaita | it can be a public security bug, it's a "hardening opportunity" | 15:27 |
| enriquetaso | oh okay | 15:27 |
| rosmaita | just want to give you a heads-up so you don't freak out when you see it | 15:28 |
| eharney | looks like a nice hardening patch | 15:28 |
| enriquetaso | thanks rosmaita | 15:28 |
| enriquetaso | sounds good then | 15:28 |
| rosmaita | yeah, i think it's worth doing, just object to it being snuck in as related to the latest CVE bug | 15:28 |
| enriquetaso | okay, do we have more bugs? | 15:29 |
| enriquetaso | let's close for today's | 15:29 |
| enriquetaso | thank you for joining!! | 15:29 |
| rosmaita | thanks enriquetaso | 15:29 |
| enriquetaso | #endmeeting | 15:29 |
| opendevmeet | Meeting ended Wed Feb 1 15:29:39 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:29 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2023/cinder_bs.2023-02-01-15.05.html | 15:29 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2023/cinder_bs.2023-02-01-15.05.txt | 15:29 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2023/cinder_bs.2023-02-01-15.05.log.html | 15:29 |
| opendevreview | Merged openstack/cinder master: [Pure Storage] Fix issue with loss of replicated array https://review.opendev.org/c/openstack/cinder/+/855060 | 15:43 |
| opendevreview | Simon Dodsley proposed openstack/cinder stable/zed: [Pure Storage] Fix issue with loss of replicated array https://review.opendev.org/c/openstack/cinder/+/872307 | 15:44 |
| *** dviroel|rover|lunch is now known as dviroel|rover | 15:57 | |
| rosmaita | stable cores: could use reviews on this to unblock the ussuri gate: https://review.opendev.org/c/openstack/cinder/+/871792 | 16:12 |
| opendevreview | Jean-Sébastien Bevilacqua proposed openstack/cinder master: Add cinder Driver for Lustre https://review.opendev.org/c/openstack/cinder/+/853785 | 16:59 |
| opendevreview | Sofia Enriquez proposed openstack/devstack-plugin-nfs master: Runs all encrypted scenario tests https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/742905 | 17:45 |
| *** dviroel_ is now known as dviroel|rover_ | 18:36 | |
| *** dviroel|rover_ is now known as dviroel|rover | 18:38 | |
| *** dviroel_ is now known as dviroel|rover | 19:51 | |
| hemna | mep | 19:57 |
| jungleboyj | boop | 20:17 |
| opendevreview | Merged openstack/cinder master: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/812685 | 21:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!