| *** dviroel|rover|bbl is now known as dviroel|rover | 00:05 | |
| *** dviroel|rover is now known as dviroel|rover|out | 00:38 | |
| *** dviroel|rover|out is now known as dviroel|holiday | 00:38 | |
| whoami-rajat | haleema[m], I'm not sure about that | 05:53 |
|---|---|---|
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804035 | 06:42 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for backup os-reset_status https://review.opendev.org/c/openstack/cinder/+/778193 | 06:42 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group-snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804757 | 06:42 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status https://review.opendev.org/c/openstack/cinder/+/804735 | 06:42 |
| whoami-rajat | rosmaita, eharney hey, I looked at one of the reset state patches and I'm not sure about few things which I've mentioned in my review. I went through the spec and it also briefly describes the changes, I think it would be a good idea to document this somewhere https://review.opendev.org/c/openstack/cinder/+/804035 | 07:16 |
| *** elodilles_pto is now known as elodilles | 07:41 | |
| *** amoralej|off is now known as amoralej | 08:31 | |
| sfv880_ | Hello reviewers, I replied and fixed on https://review.opendev.org/c/openstack/cinder/+/850320 - could you please review? Thank you very much! | 11:04 |
| opendevreview | Vladut BUTNARU proposed openstack/cinder stable/zed: backups: Use the most recent available backup for incrementals https://review.opendev.org/c/openstack/cinder/+/863273 | 11:41 |
| opendevreview | Alexa Ștefan proposed openstack/cinder stable/yoga: Bugfix: Account for consumed space better https://review.opendev.org/c/openstack/cinder/+/863276 | 11:52 |
| opendevreview | Dragos Neagu proposed openstack/cinder stable/yoga: Fix volume caching in PowerFlex driver https://review.opendev.org/c/openstack/cinder/+/863277 | 11:52 |
| opendevreview | Georgian Voda proposed openstack/cinder stable/yoga: Hitachi: fix to output resource lock message correctly https://review.opendev.org/c/openstack/cinder/+/863278 | 11:53 |
| *** amoralej is now known as amoralej|lunch | 12:04 | |
| *** elodilles is now known as elodilles_afk | 12:44 | |
| *** elodilles_afk is now known as elodilles | 13:15 | |
| opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Add support for 3-site, trisync, replication. https://review.opendev.org/c/openstack/cinder/+/862365 | 13:31 |
| opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Add support for 3-site, trisync, replication. https://review.opendev.org/c/openstack/cinder/+/862365 | 13:45 |
| *** amoralej|lunch is now known as amoralej | 13:45 | |
| whoami-rajat | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:59 |
| whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin adiare | 13:59 |
| rosmaita | whoami-rajat: ty | 13:59 |
| whoami-rajat | np | 13:59 |
| ogo | D/msg | 14:08 |
| ogo | 'hello' | 14:08 |
| ogo | 'I am handling bug #1746223' | 14:10 |
| ogo | 'Am I meant to comment out the specified output and add a test for it' | 14:12 |
| ogo | 'I am a newbie to this and I feel lost, please bear with me' | 14:12 |
| ogo | 'I need some sort of direction' | 14:13 |
| whoami-rajat | no bug squad meeting as Sofia is not around | 15:01 |
| rosmaita | we can have a bug-free week! | 15:01 |
| whoami-rajat | :D | 15:03 |
| rosmaita | ogo: looks like someone has already proposed a patch for that bug: https://review.opendev.org/c/openstack/cinder/+/860209 | 15:09 |
| rosmaita | so to answer your question, the fix would be to remove the computation from the driver code (like that patch does) | 15:10 |
| rosmaita | i guess the next step would be checking the tests for cinder/volume/manager.py to make sure it always populates that field | 15:11 |
| rosmaita | so you might not have to add any tests | 15:12 |
| rosmaita | ogo: i was going to say, looks like the toyou driver has the same issue, but looks like tushar has that covered too: https://bugs.launchpad.net/cinder/+bug/1991634 and https://review.opendev.org/c/openstack/cinder/+/860212 | 15:15 |
| rosmaita | you could review those patches, the thing to check is to make sure that there isn't a special reason why either driver is doing the calculation themselves | 15:16 |
| rosmaita | (if there was, there should be some kind of comment in the code about it, so if there's nothing there, probably nothing to worry about) | 15:16 |
| opendevreview | Merged openstack/cinder stable/train: Don't destroy existing backup by mistake on import https://review.opendev.org/c/openstack/cinder/+/860036 | 16:42 |
| ogovekwueme | wq | 17:02 |
| ogovekwueme | wq | 17:02 |
| *** amoralej is now known as amoralej|off | 17:38 | |
| opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Add support for 3-site, trisync, replication. https://review.opendev.org/c/openstack/cinder/+/862365 | 19:49 |
| opendevreview | Brian Rosmaita proposed openstack/cinder-tempest-plugin master: Don't test EOL cinderlib branches https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/863442 | 22:16 |
| opendevreview | Brian Rosmaita proposed openstack/cinder stable/ussuri: [ussuri only] Don't test EOL cinderlib branch https://review.opendev.org/c/openstack/cinder/+/863443 | 22:21 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!