| opendevreview | melanie witt proposed openstack/cinder master: NFS update volume attachment format during volume snapshot https://review.opendev.org/c/openstack/cinder/+/857528 | 00:02 |
|---|---|---|
| *** bhagyashris_ is now known as bhagyashris|ruck | 05:51 | |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: rbd: Fix snapshot delete when the source volume doesn't exist https://review.opendev.org/c/openstack/cinder/+/824149 | 06:46 |
| sfv880_ | Hello rosmaita and whoami-rajat: replied and fixed on https://review.opendev.org/c/openstack/cinder/+/849846 - thank you very much! | 07:12 |
| whoami-rajat | sfv880_, infinidat CI hasn't run on the new PS | 07:18 |
| sfv880_ | whoami-rajat, done - results available, thank you! | 07:30 |
| whoami-rajat | sfv880_, ack, +2ed | 07:40 |
| sfv880_ | whoami-rajat, thank you very much! | 07:45 |
| harshailani | Hello reviewers, can you please give a +2 on the patch : https://review.opendev.org/c/openstack/cinder/+/850310 | 07:47 |
| harshailani | the code has been verified and tested by the customer and reviewed by other reviewers as well. | 07:47 |
| whoami-rajat | harshailani, so we had the portset config option but we didn't use it anywhere? | 07:51 |
| harshailani | whoami-rajat, yes the portset option was provided in config but it wasn't used during initialization because of which by default it was selecting the portset value as portset0 even if customer was passing the value from config. | 07:59 |
| harshailani | hence i pushed this patch to correct this mistake during driver initialization so that the customer can now use its own portset | 07:59 |
| harshailani | by defining in the cinder.conf file | 08:00 |
| whoami-rajat | harshailani, it is strange that there were no tests affected, don't we check the initialization in UTs? | 08:01 |
| harshailani | in the existing UTs it was picking up the default portset hence it didnt fail | 08:03 |
| whoami-rajat | harshailani, but we need another test that overrides the config option and then check | 08:04 |
| whoami-rajat | I've left a comment | 08:05 |
| harshailani | unfortunately our IBM CI is down. the physical server is having hardware problems which might take time to be replaced. hence i couldnt add the new UT on this patch. | 08:05 |
| whoami-rajat | hmm | 08:05 |
| harshailani | Is it possible that the fix gets merged and i can add the UTs in a different upcoming review once the CI is passed? | 08:06 |
| whoami-rajat | harshailani, ok, please add a comment on the review stating the same and I will revote | 08:06 |
| harshailani | I am requesting this because the customer has already tested on their environment and the code fixes this bug. | 08:07 |
| harshailani | awesome. thankyou so much | 08:07 |
| harshailani | done. i have added the note on the review. | 08:08 |
| whoami-rajat | done, but remember, for any bugfix/feature, proper UTs and releasenote are always required | 08:10 |
| harshailani | yes, in this case i had to wait for the customer approval. but by the time they came back our CI server went down. | 08:11 |
| harshailani | don't worry, i will keep a tab on this and as soon as the CI is fixed i will upload the patch for the UTs | 08:11 |
| whoami-rajat | sounds good, thanks | 08:13 |
| harshailani | thank you for your +2. | 08:13 |
| harshailani | Please can someone else also provide a +2 so that the fix can be merged ? | 08:13 |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: rbd: Fix snapshot delete when the source volume doesn't exist https://review.opendev.org/c/openstack/cinder/+/824149 | 09:42 |
| opendevreview | Takashi Kajinami proposed openstack/cinder master: rbd: Fix snapshot delete when the source volume doesn't exist https://review.opendev.org/c/openstack/cinder/+/824149 | 10:14 |
| *** bhagyashris is now known as bhagyashris|ruck | 10:59 | |
| TusharTgite_ | hi team need areview on this patch https://review.opendev.org/c/openstack/cinder/+/855350 | 11:25 |
| *** dviroel|afk is now known as dviroel | 11:31 | |
| hemna | geguileo, rosmaita https://review.opendev.org/c/openstack/cinder/+/826510 | 12:15 |
| opendevreview | Walt proposed openstack/cinder master: Fix tracking allocated_capacity_gb https://review.opendev.org/c/openstack/cinder/+/836083 | 12:15 |
| rosmaita | hemna: ack | 12:17 |
| geguileo | hemna: done | 12:17 |
| rosmaita | even better | 12:17 |
| harshailani | Hi team, requesting a +2 on the review: https://review.opendev.org/c/openstack/cinder/+/850310 | 13:21 |
| harshailani | Customer has approved the fix. | 13:22 |
| whoami-rajat | rosmaita, hey, can you take another look at this patch? CI has passed now https://review.opendev.org/c/openstack/cinder/+/801354 | 13:22 |
| rosmaita | sure | 13:22 |
| rosmaita | done | 13:23 |
| TusharTgite_ | hi team already have a +2 on this patches can anyone merge it? https://review.opendev.org/c/openstack/cinder-specs/+/854982 https://review.opendev.org/c/openstack/cinder/+/855350 | 13:24 |
| harshailani | rosmiata, could you please take a look at https://review.opendev.org/c/openstack/cinder/+/850310 ? | 13:26 |
| opendevreview | Takashi Natsume proposed openstack/cinder master: Fix wrong assertion methods https://review.opendev.org/c/openstack/cinder/+/856971 | 13:26 |
| rosmaita | harshailani: looking | 13:28 |
| harshailani | :) | 13:28 |
| hemna | geguileo thank you | 13:33 |
| geguileo | np | 13:33 |
| sfv880_ | Hello rosmaita, I replied and fixed all comments on https://review.opendev.org/c/openstack/cinder/+/849846 - thank you very much! | 13:34 |
| harshailani | Thankyou rosmiata :) | 13:39 |
| akawai | Hello cores: pls review "Update docs forHello core reviewers. Hitachi driver | https://review.opendev.org/c/openstack/cinder/+/809534" for Zed. | 13:58 |
| akawai | The patch has already got +1*6 and +2*1 is just fixed driver doc. | 13:58 |
| opendevreview | Jean Pierre Roquesalane proposed openstack/cinder master: PowerMax Driver - Allow for retype to _DEFAULT__ VT https://review.opendev.org/c/openstack/cinder/+/803773 | 14:26 |
| opendevreview | Eric Harney proposed openstack/cinder master: RBD: Flattening of child volumes during deletion https://review.opendev.org/c/openstack/cinder/+/835384 | 15:06 |
| opendevreview | Merged openstack/cinder master: PowerMax Driver - Fix for renaming GVG https://review.opendev.org/c/openstack/cinder/+/801354 | 15:13 |
| opendevreview | Merged openstack/cinder master: [SVf]: Incorrect portset value during driver intialization https://review.opendev.org/c/openstack/cinder/+/850310 | 15:14 |
| opendevreview | Luigi Toscano proposed openstack/cinder-tempest-plugin master: zuul: new LVM/nvmet job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/855576 | 15:23 |
| *** dviroel is now known as dviroel|lunch | 15:59 | |
| opendevreview | Merged openstack/cinder master: HPE 3PAR: Fix umanaged volumes & snapshots missing https://review.opendev.org/c/openstack/cinder/+/850836 | 16:48 |
| *** dviroel|lunch is now known as dviroel | 17:09 | |
| opendevreview | Merged openstack/cinder master: Fix volume caching in PowerFlex driver https://review.opendev.org/c/openstack/cinder/+/806605 | 19:25 |
| opendevreview | Merged openstack/cinder master: Update docs for Hitachi driver https://review.opendev.org/c/openstack/cinder/+/809534 | 21:32 |
| *** dviroel is now known as dviroel|out | 21:45 | |
| opendevreview | Merged openstack/cinder master: Fix Infinidat driver to use TLS/SSL communication https://review.opendev.org/c/openstack/cinder/+/849846 | 23:00 |
| melwitt | geguileo: I dunno if you saw but the running of volume extend tempests tests in the nova-next job got reverted recently https://review.opendev.org/c/openstack/nova/+/854132 due to very frequent failures, if you were interested in taking a look | 23:36 |
| opendevreview | melanie witt proposed openstack/cinder master: NFS update volume attachment format during volume snapshot https://review.opendev.org/c/openstack/cinder/+/857528 | 23:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!