| opendevreview | chenwei proposed openstack/cinder master: Fix: base64.encodestring() which no longer exists in Python 3.9 https://review.opendev.org/c/openstack/cinder/+/850015 | 01:34 |
|---|---|---|
| opendevreview | chenwei proposed openstack/cinder master: Fix: base64.encodestring() which no longer exists in Python 3.9 https://review.opendev.org/c/openstack/cinder/+/850015 | 05:30 |
| opendevreview | YuehuiLei proposed openstack/cinder master: RemoteFs:Ensure cinder can create mount directory https://review.opendev.org/c/openstack/cinder/+/850142 | 07:34 |
| opendevreview | YuehuiLei proposed openstack/cinder master: RemoteFs:Ensure cinder can create mount directory https://review.opendev.org/c/openstack/cinder/+/850142 | 07:44 |
| opendevreview | YuehuiLei proposed openstack/cinder master: RemoteFs:Ensure cinder can create mount directory https://review.opendev.org/c/openstack/cinder/+/850142 | 07:48 |
| *** sfinucan is now known as stephenfin | 11:30 | |
| *** dviroel_ is now known as dviroel | 11:35 | |
| opendevreview | Alexander Deiter proposed openstack/cinder master: Fix Infinidat driver to use SSL options https://review.opendev.org/c/openstack/cinder/+/849846 | 13:25 |
| opendevreview | Alexander Malashenko proposed openstack/cinder master: Add Cinder NFS driver for Dell PowerStore https://review.opendev.org/c/openstack/cinder/+/797608 | 13:34 |
| opendevreview | Merged openstack/cinder master: db: Remove irrelevant TODO https://review.opendev.org/c/openstack/cinder/+/849498 | 13:38 |
| opendevreview | Merged openstack/cinder master: db: Remove resolved TODO https://review.opendev.org/c/openstack/cinder/+/837546 | 13:39 |
| opendevreview | Merged openstack/cinder master: tests: Fix invalid test https://review.opendev.org/c/openstack/cinder/+/846171 | 13:39 |
| opendevreview | Alexander Malashenko proposed openstack/cinder master: Cinder displays the volume size provided by the driver, when creating the volume with enabled cache. https://review.opendev.org/c/openstack/cinder/+/836973 | 14:12 |
| *** dviroel is now known as dviroel|lunch | 15:08 | |
| opendevreview | Brian Rosmaita proposed openstack/cinderlib master: Don't use yum to install ceph https://review.opendev.org/c/openstack/cinderlib/+/849432 | 15:32 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: tests: Address UserWarning in tests https://review.opendev.org/c/openstack/cinder/+/846172 | 15:45 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Fix up some API signatures, other style issues https://review.opendev.org/c/openstack/cinder/+/837542 | 15:45 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Move helpers to cinder.db.sqlalchemy.api https://review.opendev.org/c/openstack/cinder/+/837543 | 15:45 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Use cinder.db.api directly https://review.opendev.org/c/openstack/cinder/+/846173 | 15:45 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Remove unnecessary sqlalchemy abstraction https://review.opendev.org/c/openstack/cinder/+/813229 | 15:45 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: LUKS: Support extending host attached volumes https://review.opendev.org/c/openstack/os-brick/+/836059 | 16:04 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: NVMe-oF: Consolidate code paths https://review.opendev.org/c/openstack/os-brick/+/836060 | 16:04 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: NVMe-oF: Disconnect subsystems https://review.opendev.org/c/openstack/os-brick/+/836062 | 16:04 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: Support shared_targets tristate value https://review.opendev.org/c/openstack/os-brick/+/836063 | 16:04 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: WIP: Add luks2 boot cloned encrypted volume test https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/850243 | 16:15 |
| *** dviroel_ is now known as dviroel | 16:15 | |
| *** geguileo is now known as Guest5387 | 16:18 | |
| *** Guest5387 is now known as geguileo | 16:19 | |
| opendevreview | Simon Dodsley proposed openstack/cinder master: Add Pure Storage NVMe-RoCE driver https://review.opendev.org/c/openstack/cinder/+/799871 | 16:19 |
| geguileo | simondodsley: don't know if you saw that I updated the os-brick patches | 16:20 |
| geguileo | whoami-rajat: ^ | 16:20 |
| whoami-rajat | ack | 16:20 |
| geguileo | eharney: ^ the "NVMe-oF: Consolidate code paths" enables mypy for the nvmeof.py file (what a pain ;-) ) | 16:20 |
| simondodsley | geguileo: retrying now | 16:21 |
| eharney | geguileo: very nice! | 16:21 |
| geguileo | simondodsley: I updated the "good patchset" not the DNM I created the other day | 16:22 |
| simondodsley | yep - got it | 16:22 |
| geguileo | eharney: I notices that it is really painful, but it makes weird cases (things that take different values) clearer in the code | 16:22 |
| geguileo | s/notices/noticed | 16:22 |
| simondodsley | geguileo: did you see the issue with hyphens in the NGUID? | 16:22 |
| geguileo | simondodsley: no, didn't see that one | 16:23 |
| simondodsley | in the private messages | 16:23 |
| simondodsley | geguileo: `Jul 15 15:04:24.411110 dsvm-focal-NVME-ROCE-aio-0000007081 cinder-volume[92746]: DEBUG os_brick.initiator.connectors.nvmeof [None req-659118cd-e13d-4f1b-89af-ebff53c137f3 tempest-ServersTestBootFromVolume-1633085493 None] Block /sys/class/nvme-fabrics/ctl/nvme2/nvme0c2n1 is not the one we look for (00cfcf68-abd2-8490-24a9-3729000cfeef != 00cfcf68abd2849024a93729000cfeef) {{(pid=92746) | 16:24 |
| simondodsley | get_device_by_propert` | 16:24 |
| simondodsley | the compare is incorrect | 16:24 |
| simondodsley | you need to remove the hyphens | 16:24 |
| geguileo | simondodsley: nop, nop, nop | 16:25 |
| geguileo | that is what sysfs says is there | 16:25 |
| geguileo | nguid and uuid both have the hyphens | 16:26 |
| simondodsley | yes - but the nguid format everywhere else does not have hyphens, eg in the multipath output | 16:26 |
| simondodsley | and the RFC as well if I remember correctly | 16:26 |
| geguileo | his is what the kernel and nvme driver say | 16:27 |
| simondodsley | i can always change or driver | 16:27 |
| simondodsley | also can you check out this https://review.opendev.org/c/openstack/cinder/+/849690 as it's NVMe related | 16:27 |
| geguileo | simondodsley: I'm looking into the hyphens thingy, to see what would be needed to support both formats and what current code actually supports | 16:34 |
| geguileo | simondodsley: I don't think we should create those variants | 16:34 |
| geguileo | but I have to double check | 16:34 |
| geguileo | the implications | 16:34 |
| opendevreview | Eric Harney proposed openstack/os-brick master: mypy: initiator https://review.opendev.org/c/openstack/os-brick/+/786732 | 16:36 |
| opendevreview | Eric Harney proposed openstack/os-brick master: mypy: lvm.py https://review.opendev.org/c/openstack/os-brick/+/786733 | 16:37 |
| opendevreview | Eric Harney proposed openstack/os-brick master: mypy: privileged/nvmeof.py https://review.opendev.org/c/openstack/os-brick/+/849017 | 16:37 |
| geguileo | simondodsley: I can confirm, current os-brick and Cinder drivers only support hypens | 16:37 |
| opendevreview | Eric Harney proposed openstack/os-brick master: mypy: improve utils.py coverage, update format https://review.opendev.org/c/openstack/os-brick/+/849018 | 16:37 |
| geguileo | simondodsley: Cinder side https://github.com/openstack/cinder/blob/master/cinder/volume/targets/nvmet.py#L124 | 16:38 |
| opendevreview | Eric Harney proposed openstack/os-brick master: Bump mypy version to 0.960 https://review.opendev.org/c/openstack/os-brick/+/849019 | 16:38 |
| geguileo | simondodsley: brick side https://github.com/openstack/os-brick/blob/a944ffc48a307231026a323e62adbfdc3ca33e8a/os_brick/initiator/connectors/nvmeof.py#L210-L213 | 16:38 |
| geguileo | so it would not be a regression | 16:38 |
| opendevreview | Eric Harney proposed openstack/os-brick master: mypy: privileged/rbd.py https://review.opendev.org/c/openstack/os-brick/+/849020 | 16:38 |
| geguileo | simondodsley: though it definitely highlights that at the very least the documentation HAS to state the expected format | 16:39 |
| opendevreview | Eric Harney proposed openstack/os-brick master: mypy: initiator/connectors/rbd.py https://review.opendev.org/c/openstack/os-brick/+/849021 | 16:39 |
| opendevreview | Eric Harney proposed openstack/os-brick master: Move mypy job to check queue (non-voting) https://review.opendev.org/c/openstack/os-brick/+/849840 | 16:39 |
| simondodsley | geguileo: OK, I'll change our driver to use hyphens | 16:40 |
| geguileo | simondodsley: no, no, give me a minute to evaluate what it would take to do it in os-brick | 16:40 |
| simondodsley | ok | 16:40 |
| *** akekane_ is now known as abhishekk | 16:41 | |
| opendevreview | Eric Harney proposed openstack/cinder master: Bump mypy version to 0.960 https://review.opendev.org/c/openstack/cinder/+/844879 | 16:41 |
| geguileo | simondodsley: I think I can do it just changing 4 LOC, I'll send a patch in a couple of minutes (unit tests always take longer) | 16:42 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: cinder/cmd/[api,backup,scheduler,status,volume] https://review.opendev.org/c/openstack/cinder/+/842541 | 16:43 |
| opendevreview | Alexander Malashenko proposed openstack/cinder master: PowerFlex - cinder displays the volume size provided by the driver, when creating the volume with enabled cache. https://review.opendev.org/c/openstack/cinder/+/836973 | 16:54 |
| geguileo | 125 failings tests with that UUID change lol | 16:57 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: cmd/manage.py https://review.opendev.org/c/openstack/cinder/+/842542 | 16:58 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: NVMe-oF: Consolidate code paths https://review.opendev.org/c/openstack/os-brick/+/836060 | 17:14 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: NVMe-oF: Disconnect subsystems https://review.opendev.org/c/openstack/os-brick/+/836062 | 17:14 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: Support shared_targets tristate value https://review.opendev.org/c/openstack/os-brick/+/836063 | 17:14 |
| geguileo | simondodsley: that should work with or without hyphens | 17:14 |
| simondodsley | geguileo: ok - I'll give it a try. I have been checking and the NVMe spec does not specify hyphens so I don't know why they are in the sysfs requirement | 17:15 |
| geguileo | simondodsley: the NVMe spec probably won't mention anything, because the uuid has multiple formats and iirc they are all binary formats | 17:16 |
| geguileo | so all comes down to how those are represented in "text format" | 17:17 |
| geguileo | and then is where it probably diverges | 17:17 |
| geguileo | sysfs uses hyphens | 17:17 |
| geguileo | but nvme id-ns doesn't | 17:17 |
| geguileo | though it prefixes with the actual format | 17:18 |
| geguileo | iirc | 17:18 |
| geguileo | anyway, both should be supported now, and they should be case insensitive as well | 17:18 |
| opendevreview | Brian Rosmaita proposed openstack/cinderlib master: Update deprecated zuul syntax https://review.opendev.org/c/openstack/cinderlib/+/849409 | 18:08 |
| opendevreview | Merged openstack/cinder master: tests: Address UserWarning in tests https://review.opendev.org/c/openstack/cinder/+/846172 | 18:10 |
| pengo_ | Hello I would like use external ceph cinder as backend for glance images. I dont have config ready for it. But uploading images to glance just gets stuck. I can see the images gets created along with volume but stays in `saving` status all the time similarly volume stays in attaching status. I found some `keystone_authtoken` issue in logs so i found some fix for it https://review.opendev.org/c/openstack/glance/+/795772 but | 18:40 |
| pengo_ | its already applied to my glance. Is there any other way to fix this issue Please? | 18:40 |
| pengo_ | https://www.irccloud.com/pastebin/XQSJsnQf/ | 18:41 |
| pengo_ | *I mean i do have my glance config ready sorry for type | 18:43 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: NFS Backup: Remove leftover dirs https://review.opendev.org/c/openstack/cinder/+/804603 | 18:45 |
| geguileo | jbernard: I have updated the nvmeof devstack patch with the nvmetcli dependency and referenced your patch | 18:47 |
| amalashenko | geguileo: hi! are you around? could you please take a look at this patch https://review.opendev.org/c/openstack/cinder/+/836973. We discussed with happystacker about driver should never return size and I updated commit message and remove places where driver returns sizes. | 19:37 |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: Set default value for MANILA_CEPH_GANESHA_RADOS_STORE https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/850250 | 19:37 |
| *** tosky_ is now known as tosky | 19:45 | |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: Set default value for MANILA_CEPH_GANESHA_RADOS_STORE https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/850250 | 19:47 |
| opendevreview | Eric Harney proposed openstack/cinder master: NFS: Use Volume attr instead of dict compat for lock https://review.opendev.org/c/openstack/cinder/+/850251 | 19:54 |
| *** dviroel is now known as dviroel|out | 21:39 | |
| opendevreview | Merged openstack/cinder master: Add a check for virtual_size at API layer https://review.opendev.org/c/openstack/cinder/+/847335 | 23:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!