| *** dviroel|rover is now known as dviroel|out | 00:14 | |
| opendevreview | Vladislav Belogrudov proposed openstack/cinder master: Initial commit for Yadro Tatlin.UNIFIED driver https://review.opendev.org/c/openstack/cinder/+/825492 | 08:54 |
|---|---|---|
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: No volume_id needed for backup-create from snapshot https://review.opendev.org/c/openstack/cinder/+/849800 | 09:27 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Include volume type constraints in internal API https://review.opendev.org/c/openstack/cinder/+/846146 | 10:09 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Update volume_type_project bogus column https://review.opendev.org/c/openstack/cinder/+/822821 | 10:12 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Use self volume_type_id while backup restore. https://review.opendev.org/c/openstack/cinder/+/848938 | 10:12 |
| geguileo | whoami-rajat: if you have a minute, this is the backport of the os-brick RBD fix https://review.opendev.org/c/openstack/os-brick/+/849718 | 10:38 |
| whoami-rajat | geguileo, done | 10:48 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: HPE3PAR: Correct volume name in ERROR log https://review.opendev.org/c/openstack/cinder/+/849803 | 10:49 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: Support independent file lock path https://review.opendev.org/c/openstack/os-brick/+/849324 | 11:09 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick stable/xena: RBD: Fix disconnect_volume for encrypted volumes https://review.opendev.org/c/openstack/os-brick/+/849805 | 11:12 |
| geguileo | whoami-rajat: thanks, ^ that's the xena backport of the same fix | 11:13 |
| olegnest | Hello, I have a small question. We are implementing an NVMe driver for our DEMC storage and want to add the constants.NVMEOF parameter to the storage_protocol option. Can we do this directly in our patch or for that firstly a simple basic NVMe driver like FС/ISER/ISCSI should be implemented? | 11:15 |
| *** dviroel__ is now known as dviroel|rover | 11:15 | |
| geguileo | olegnest: do you mean you want the driver to report constants.NVMEOF in its capabilities? | 11:17 |
| olegnest | We want to remove our extra option from config file and put the definition of the protocol will be used (and the driver accordingly) to base 'storage_protocol' option | 11:23 |
| raghavendrat | hi whoami-rajat: are you around ? | 11:42 |
| whoami-rajat | geguileo, cool, will take a look once CI passes | 11:44 |
| whoami-rajat | raghavendrat, hi | 11:44 |
| raghavendrat | if you get time it would be great if you can look at below patch. | 11:46 |
| raghavendrat | https://review.opendev.org/c/openstack/cinder/+/820628 | 11:46 |
| raghavendrat | It has one +2. Thanks. | 11:46 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: WIP: make ceph job voting (sometimes) https://review.opendev.org/c/openstack/os-brick/+/849759 | 11:55 |
| raghavendrat | Thank you whoami-rajat: for quick feedback. | 12:00 |
| whoami-rajat | raghavendrat, np, can you take a look at this patch and see if it makes sense? https://review.opendev.org/c/openstack/cinder/+/849803 | 12:01 |
| geguileo | olegnest: that configuration option is for drivers that have a common class for all their protocols, so then they can do the right thing depending on it | 12:26 |
| geguileo | So there are 2 cases: | 12:27 |
| geguileo | 1- Use the same value in volume_driver and use storage_protocol for the driver to do the right thing | 12:27 |
| geguileo | 2- Use a different value for volume_driver depending on the protocol | 12:28 |
| geguileo | in the second case the storage_protocol is not necessary | 12:28 |
| geguileo | afaik | 12:28 |
| stephenfin | eharney: whoami-rajat: Think one of you folks could look at https://review.opendev.org/c/openstack/cinder/+/837165/ to unblock the next few patches above it? | 12:33 |
| stephenfin | and geguileo: I addressed your concerns on https://review.opendev.org/c/openstack/cinder/+/837167/ in https://review.opendev.org/c/openstack/cinder/+/849498/ so I think both are good to go now? | 12:34 |
| whoami-rajat | stephenfin, done | 12:37 |
| stephenfin | whoami-rajat: 🙏 thanks | 12:38 |
| olegnest | geogileo: yep, we had FC and iSCSI protocols for one volume_driver and storage_protocol decided what to do, but it doesn't work for NVMe cause option doesn't include nvmeof =( so i understand we can't insert it, thanks | 12:41 |
| opendevreview | Merged openstack/os-brick stable/yoga: RBD: Fix disconnect_volume for encrypted volumes https://review.opendev.org/c/openstack/os-brick/+/849718 | 12:43 |
| geguileo | whoami-rajat: patch has +V https://review.opendev.org/c/openstack/os-brick/+/849805 | 13:05 |
| geguileo | stephenfin: makes sense, merging it now | 13:07 |
| whoami-rajat | geguileo, +2ed | 13:08 |
| stephenfin | geguileo: thanks | 13:08 |
| geguileo | whoami-rajat: thanks! | 13:08 |
| whoami-rajat | np, let me know when wallaby patch is up | 13:09 |
| opendevreview | Simon Dodsley proposed openstack/cinder master: Add Pure Storage NVMe-RoCE driver https://review.opendev.org/c/openstack/cinder/+/799871 | 13:16 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: DNM: ceph-related change https://review.opendev.org/c/openstack/os-brick/+/849858 | 13:27 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: DNM: non-ceph-related change https://review.opendev.org/c/openstack/os-brick/+/849859 | 13:27 |
| opendevreview | Walt proposed openstack/cinder master: Fix and unify capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 14:38 |
| hemna | just rebasing it to keep it current as it's still sitting there.... | 14:38 |
| opendevreview | Walt proposed openstack/cinder master: Bugfix: Account for consumed space better https://review.opendev.org/c/openstack/cinder/+/826510 | 14:44 |
| hemna | same thing ^^ | 14:44 |
| opendevreview | Eric Harney proposed openstack/cinder master: DataCore: Add note about unique CHAP storage paths https://review.opendev.org/c/openstack/cinder/+/849869 | 14:58 |
| elodilles | whoami-rajat: hi, i have a release management related question: our consistency check showed that rbd-iscsi-client is not amongst zed's deliverables (as it was not part of yoga and before). does the team want to release it in Zed cycle? | 15:09 |
| elodilles | whoami-rajat: in the past i got the answer (@ yoga cycle) from rosmaita that there were some CI problems that still need to be resolved before it could be released | 15:09 |
| elodilles | whoami-rajat: is that maybe fixed? | 15:10 |
| rosmaita | elodilles: not sure the CI is fixed yet | 15:11 |
| elodilles | whoami-rajat: (and just for the record, according to IRC logs it is aimed to be in 'independent' release model) | 15:11 |
| rosmaita | was hoping that you would not notice that no release had happened yet | 15:11 |
| rosmaita | so much for that plan | 15:11 |
| elodilles | :D | 15:12 |
| elodilles | don't blame me, it was our consistency check script o:) | 15:12 |
| amalashenko | eharney: hi, are you around? could you please take a look on nfs driver, zuul and CI passed. https://review.opendev.org/c/openstack/cinder/+/797608 | 15:14 |
| elodilles | whoami-rajat rosmaita : of course, if it is not ready for delivery around this cycle, then it's no need to force it. we'll get back to it in next cycle (when our consistency check should run again :)) if not before | 15:15 |
| rosmaita | elodilles: ok, thanks ... this is a good reminder though that we need to not forget about it | 15:18 |
| whoami-rajat | elodilles, thanks for raising it, as rosmaita said, I don't think it is ready for release until we've a green CI ensuring the code works, will take a look at it's current state | 15:19 |
| elodilles | ack, thanks! let me know if things changes and it can be added to the release repository | 15:21 |
| sfernand | whoami-rajat: drivers will be granted one or two weeks exception? Some files have 15k lines so it will take some time to review | 15:24 |
| rosmaita | sfernand: i suggest prioritizing reviews based on whether the CI is running and you can see the results | 15:27 |
| rosmaita | (some drivers are using CIs that run multiple jobs) | 15:28 |
| sfernand | yes that makes sense | 15:29 |
| sfernand | my idea initially was to try focusing on drivers that we don't have cores looking for it yet so I would be able to antecipate their work | 15:29 |
| sfernand | a bit | 15:29 |
| sfernand | since I can't give 2+ but can give as many -1 as I want to :P | 15:30 |
| sfernand | and I believe cores are currently working in drivers that CI is running and have more chances to get merged | 15:31 |
| sfernand | if I undestand correctly what you said | 15:31 |
| rosmaita | yeah, that's the basic idea, but i don't know that we got 2 core adoption on all the patches yet | 15:34 |
| sfernand | yep | 15:35 |
| rosmaita | so your +1 will also be helpful | 15:35 |
| rosmaita | particularly because you are very knowledgeable about drivers | 15:35 |
| sfernand | do you suggest any patch for me to start looking on it? | 15:36 |
| amalashenko | powerstore nfs driver :P | 15:36 |
| sfernand | hahahhaha I was expecting that | 15:36 |
| amalashenko | haha even better | 15:37 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: WIP: make ceph job voting (sometimes) https://review.opendev.org/c/openstack/os-brick/+/849759 | 16:02 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: WIP: make ceph job voting (sometimes) https://review.opendev.org/c/openstack/os-brick/+/849759 | 16:05 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: Make ceph job voting (sometimes) https://review.opendev.org/c/openstack/os-brick/+/849759 | 16:09 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: DNM: non-ceph-related change https://review.opendev.org/c/openstack/os-brick/+/849859 | 16:12 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: DNM: ceph-related change https://review.opendev.org/c/openstack/os-brick/+/849858 | 16:12 |
| opendevreview | Merged openstack/os-brick stable/xena: RBD: Fix disconnect_volume for encrypted volumes https://review.opendev.org/c/openstack/os-brick/+/849805 | 16:31 |
| *** dviroel|rover is now known as dviroel|rover|brb | 16:35 | |
| whoami-rajat | sfernand, as rosmaita is already answering all doubts and queries, i will just add to it, it would be good to check if the driver matches our checklist points rather than going line by line for every driver (which we all know we can't review in the given time frame) https://docs.openstack.org/cinder/latest/contributor/new_driver_checklist.html | 16:42 |
| whoami-rajat | sfernand, also regarding the driver merge deadline, yes it is extended to 29th july https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029550.html | 16:42 |
| whoami-rajat | s/is already answering/ has already answered -- don't know why i wrote it in present instead of past tense | 16:43 |
| whoami-rajat | dc_arun, hi | 16:45 |
| whoami-rajat | dc_arun, not sure if you saw my topic in the cinder meeting agenda but here it is https://etherpad.opendev.org/p/cinder-zed-meetings#L124 | 16:45 |
| whoami-rajat | dc_arun, basically I've a concern regarding datacore reusing the same env ^ | 16:46 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: DEMC: Add support for trim/discard https://review.opendev.org/c/openstack/cinder/+/849890 | 16:51 |
| sfernand | whoami-rajat: thanks rajat! | 16:52 |
| whoami-rajat | np | 17:09 |
| opendevreview | Merged openstack/cinder stable/ussuri: 3PAR: Allow iSCSI driver to be enabled for Primera 4.2 onwards. https://review.opendev.org/c/openstack/cinder/+/820628 | 17:27 |
| *** dviroel|rover|brb is now known as dviroel|rover | 17:35 | |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: DNM: NVMe-oF temporary change for CI's to use https://review.opendev.org/c/openstack/os-brick/+/849891 | 17:54 |
| geguileo | simondodsley: ^ that should do the trick | 17:54 |
| opendevreview | Simon Dodsley proposed openstack/cinder master: Add Pure Storage NVMe-RoCE driver https://review.opendev.org/c/openstack/cinder/+/799871 | 18:04 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: DNM: NVMe-oF temporary change for CI's to use https://review.opendev.org/c/openstack/os-brick/+/849891 | 18:04 |
| opendevreview | Gorka Eguileor proposed openstack/os-brick master: DNM: NVMe-oF temporary change for CI's to use https://review.opendev.org/c/openstack/os-brick/+/849891 | 18:06 |
| geguileo | ^ And that's my cue to stop working for today... | 18:07 |
| opendevreview | Merged openstack/cinder master: models: Remove implicit coercion of SELECT to scalar subquery https://review.opendev.org/c/openstack/cinder/+/837164 | 18:36 |
| opendevreview | Merged openstack/cinder master: db: Pass case.whens as positionals, not a list https://review.opendev.org/c/openstack/cinder/+/837165 | 18:36 |
| opendevreview | Merged openstack/cinder master: Resolve invalid UUID warning https://review.opendev.org/c/openstack/cinder/+/837353 | 18:36 |
| rosmaita | eharney: Gorka addressed your point on https://review.opendev.org/c/openstack/os-brick/+/849324/ if you want to re-review | 18:45 |
| opendevreview | Merged openstack/cinder master: db: Don't pass strings to Connection.execute https://review.opendev.org/c/openstack/cinder/+/837166 | 18:46 |
| opendevreview | Merged openstack/cinder master: db: Don't use strings to indicate column, relationship paths https://review.opendev.org/c/openstack/cinder/+/837167 | 18:46 |
| opendevreview | Simon Dodsley proposed openstack/cinder master: Add Pure Storage NVMe-RoCE driver https://review.opendev.org/c/openstack/cinder/+/799871 | 19:34 |
| opendevreview | Brian Rosmaita proposed openstack/os-brick master: Support independent file lock path https://review.opendev.org/c/openstack/os-brick/+/849324 | 21:51 |
| *** dviroel|rover is now known as dviroel|rover|afk | 21:59 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!