| opendevreview | Masayuki Igawa proposed openstack/cinder master: Doc: Fix way to update default quota value for a new project https://review.opendev.org/c/openstack/cinder/+/845069 | 00:23 |
|---|---|---|
| opendevreview | Masayuki Igawa proposed openstack/cinder master: Doc: Fix way to update default quota value for a new project https://review.opendev.org/c/openstack/cinder/+/845069 | 00:45 |
| opendevreview | Gorka Eguileor proposed openstack/cinderlib master: DNM: use centos-9-stream node for py39 https://review.opendev.org/c/openstack/cinderlib/+/845167 | 08:10 |
| opendevreview | Gorka Eguileor proposed openstack/cinderlib master: DNM: use centos-9-stream node for py39 https://review.opendev.org/c/openstack/cinderlib/+/845167 | 08:56 |
| HappyStacker | good morning guys | 09:05 |
| HappyStacker | first time in IRC, newbie in contributing | 09:05 |
| whoami-rajat | HappyStacker, welcome! | 09:17 |
| opendevreview | Gorka Eguileor proposed openstack/cinderlib master: DNM: use centos-9-stream node for py39 https://review.opendev.org/c/openstack/cinderlib/+/845167 | 09:26 |
| opendevreview | Gorka Eguileor proposed openstack/cinderlib master: DNM: use centos-9-stream node for py39 https://review.opendev.org/c/openstack/cinderlib/+/845167 | 10:11 |
| opendevreview | Gorka Eguileor proposed openstack/cinderlib master: DNM: use centos-9-stream node for py39 https://review.opendev.org/c/openstack/cinderlib/+/845167 | 10:35 |
| rosmaita | geguileo: https://review.opendev.org/c/openstack/cinderlib/+/845170 | 10:43 |
| geguileo | rosmaita: good morning | 10:44 |
| rosmaita | hello | 10:44 |
| geguileo | rosmaita: btw, I'm still scared about the failures we have running it the other way... | 10:48 |
| geguileo | rosmaita: sqlite3 is NOT deleting rows when we ask it to when using In-Memory database | 10:49 |
| rosmaita | yeah, i think that's going to be a Zed problem, doesn't seem to happen if we pin everything to stable/yoga | 10:50 |
| whoami-rajat | rosmaita, hey, can you take a look at these two patches (context based session related) | 10:52 |
| whoami-rajat | 1) https://review.opendev.org/c/openstack/cinder/+/837538/ -- maybe you missed reviewing it in the series | 10:52 |
| whoami-rajat | 2) https://review.opendev.org/c/openstack/cinder/+/837540/3 -- stephenfin has addressed your comments in a followup | 10:52 |
| rosmaita | there were like 5 patches i either didn't look at or left -1s on | 10:52 |
| rosmaita | ok, will hit those when i get in to work | 10:53 |
| rosmaita | in the meantime, can you look at https://review.opendev.org/c/openstack/cinderlib/+/845170 | 10:53 |
| rosmaita | i think there's still a real problem that geguileo is running down, but looks like it doesn't affect the cinderlib yoga release | 10:53 |
| whoami-rajat | there are other patches in the series that address additional things but the above two patches will mark the work complete | 10:53 |
| whoami-rajat | sure, will take a look | 10:54 |
| geguileo | rosmaita: I'm dying over the other issue... | 10:54 |
| whoami-rajat | rosmaita, i thought cinderlib-lvm-functional was also breaking but maybe i don't remember correctly | 10:56 |
| rosmaita | it was | 10:57 |
| rosmaita | it inherits from cinderlib-functional, where i made the change | 10:57 |
| whoami-rajat | ah ok | 10:57 |
| rosmaita | yeah, the change is made even for the jobs that were passing, i think it was more luck than planning | 10:58 |
| rosmaita | i didn't look at os-brick-src-tempest-lvm-lio-barbican, though (it's defined in os-brick) | 10:59 |
| rosmaita | i'll look at that later | 11:00 |
| whoami-rajat | does it run cinderlib tests? | 11:00 |
| whoami-rajat | or just failing for some reason | 11:00 |
| rosmaita | not sure what it does, but it's been passing, so i didn't worry about it | 11:00 |
| rosmaita | (yet) | 11:00 |
| whoami-rajat | if it ain't broke, don't fix it :D | 11:01 |
| rosmaita | yep (for now, anyway) | 11:02 |
| opendevreview | Gorka Eguileor proposed openstack/cinderlib master: DNM: use centos-9-stream node for py39 https://review.opendev.org/c/openstack/cinderlib/+/845167 | 11:04 |
| geguileo | whoami-rajat: please don't merge the cinderlib patch yet | 11:04 |
| geguileo | mmmm, too late | 11:04 |
| geguileo | I wanted to try to debug it a bit more | 11:04 |
| geguileo | whoami-rajat: rosmaita is it ok if I block it for a couple more hourse? | 11:05 |
| whoami-rajat | i can stop it ... | 11:05 |
| geguileo | s/hourse/hours | 11:05 |
| geguileo | whoami-rajat: let's see if rosmaita thinks it's ok | 11:05 |
| whoami-rajat | as rosmaita says | 11:05 |
| geguileo | I removed the -W since I can't figure out what's going on there... sqlite in-memory doesn't seem to work on the CI | 11:21 |
| *** dviroel|afk is now known as dviroel | 11:25 | |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Deleting a volume in 'downloading' state https://review.opendev.org/c/openstack/cinder/+/826607 | 11:25 |
| geguileo | whoami-rajat rosmaita easy backport review https://review.opendev.org/c/openstack/os-brick/+/829047 | 11:33 |
| geguileo | it's needed to backport https://review.opendev.org/q/I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68 | 11:33 |
| whoami-rajat | geguileo, done | 12:07 |
| yuval | Hey, sorry for missing the meeting yesterday. invite emails is a good idea | 12:07 |
| yuval | I can advice new vendor with some CI help if they want but now probably datacore is more updated than me | 12:08 |
| hemna | good morning | 12:12 |
| opendevreview | Jean Pierre Roquesalane proposed openstack/cinder master: WIP: Add Cinder NFS driver for Dell EMC PowerStore https://review.opendev.org/c/openstack/cinder/+/797608 | 12:26 |
| geguileo | whoami-rajat: thanks | 12:27 |
| opendevreview | Vladislav Belogrudov proposed openstack/cinder master: Initial commit for Yadro Tatlin.UNIFIED driver https://review.opendev.org/c/openstack/cinder/+/825492 | 13:04 |
| rosmaita | does anyone remember why we run os-brick-src-tempest-lvm-lio-barbican in cinderlib check & gate? I guess just to make sure the os-brick cinderlib is using from source in the other jobs doesn't contain any breaking changes? | 13:08 |
| rosmaita | because that job doesn't use cinderlib at all | 13:08 |
| rosmaita | tosky: geguileo: whoami-rajat: ^^ | 13:09 |
| rosmaita | i'm also worried that we release cinderlib without testing it against the latest released cinder and os-brick | 13:11 |
| rosmaita | i wonder whether we should add a gate job that uses cinder, os-brick from pypi instead of source | 13:11 |
| tosky | rosmaita: I don't remember now but I think there was a reason which should be visibile in the commit message | 13:11 |
| rosmaita | tosky: why didn't i think of that | 13:11 |
| geguileo | rosmaita: you sure it doesn't run cinderlib tests? | 13:16 |
| rosmaita | pretty sure | 13:17 |
| tosky | rosmaita: https://review.opendev.org/c/openstack/cinderlib/+/744680/ | 13:17 |
| rosmaita | yeah, but that doesn't address why we run it at all | 13:18 |
| tosky | rosmaita: they are executed | 13:18 |
| tosky | rosmaita: see https://839feff776bfe4f1adc3-f7a49d4a5f62d330ee9836bbb15f5662.ssl.cf2.rackcdn.com/845170/3/check/os-brick-src-tempest-lvm-lio-barbican/c125723/testr_results.html | 13:18 |
| tosky | rosmaita: I see two cinderlib.tests.functional.test_basic.* lines | 13:18 |
| rosmaita | ok, i guess that's from the parent job in cinder-tempest-plugin | 13:19 |
| tosky | rosmaita: correct, it's basically the same job as its parent but it uses os-brick from sources | 13:19 |
| rosmaita | i hate all this indirection, you have to look in 10 places to figure anything out | 13:19 |
| tosky | you can see the expanded configuration in the logs | 13:20 |
| rosmaita | ok, thanks | 13:20 |
| tosky | rosmaita: https://839feff776bfe4f1adc3-f7a49d4a5f62d330ee9836bbb15f5662.ssl.cf2.rackcdn.com/845170/3/check/os-brick-src-tempest-lvm-lio-barbican/c125723/zuul-info/inventory.yaml | 13:20 |
| rosmaita | yeah, and there's the "View job documentation" link in the zuul results page | 13:21 |
| rosmaita | we're going to have to subclass that job in cinderlib anyway, it needs to run against os-brick from stable/yoga | 13:23 |
| tosky | oh, in master? | 13:24 |
| rosmaita | yeah, because cinderlib master is still yoga development | 13:24 |
| rosmaita | tosky: is there a way to run that job using everything from stable/yoga, and override-checkout for cinderlib to use master? That job installs, cinder, glance, keystone, neutron, nova, placement, swift, devstack, barbican, cinderlib, and probably some other stuff i'm missing | 13:29 |
| rosmaita | i don't think there's a way for us to change zuul.branch in a job, and it will be 'master' since we're running out of cinderlib master | 13:29 |
| tosky | rosmaita: we do override branches, for example for branch-specific jobs in cinder-tempest-plugin | 13:31 |
| tosky | oh, you mean per-component | 13:31 |
| rosmaita | yeah, we want to run cinderlib master code against all stable/yoga components | 13:31 |
| rosmaita | i could just list them all, but was wondering if there's something more elegant | 13:32 |
| tosky | it should be possible to do it, at least listing all of them, if I read https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.required-projects.override-checkout correctly | 13:33 |
| rosmaita | i wonder if i just override-checkout: stable/yoga on devstack, if it would install everything it uses from stable/yoga | 13:33 |
| tosky | is this going to be a new job? | 13:33 |
| rosmaita | yeah, define in cinderlib .zuul.yaml, just extend os-brick-src-tempest-lvm-lio-barbican to add all the overrides | 13:33 |
| tosky | is it to test cinderlib master against stable/yoga? | 13:34 |
| rosmaita | yes | 13:34 |
| tosky | but right now there is no stable/yoga branch of cinderlib, isn'it it? | 13:34 |
| rosmaita | no, it's a trailing release, that's why cinderlib master == yoga development branch | 13:34 |
| tosky | right now, if you run a job in the stable/yoga branch, zuul checks out cinderlib from master | 13:35 |
| tosky | so you just need to override-checkout: stable/yoga, and let zuul fall back to master when stable/yoga is not defined | 13:35 |
| rosmaita | ok, but since we're running the actual job from cinderlib master, won't zuul.branch still be 'master'? | 13:37 |
| opendevreview | Merged openstack/os-brick stable/train: multipath/iscsi: iSCSI connections are not reinitiated after reboot https://review.opendev.org/c/openstack/os-brick/+/829047 | 13:38 |
| tosky | rosmaita: yes, so you need to create a new job from any job which runs in cinderlib master and add the override-checkout parameter | 13:39 |
| tosky | rosmaita: basically something like this (minus the nodeset line): https://opendev.org/openstack/cinder-tempest-plugin/src/branch/master/.zuul.yaml#L174 | 13:39 |
| rosmaita | tosky: thanks! that's exactly what i'm looking for | 13:40 |
| opendevreview | Brian Rosmaita proposed openstack/cinderlib master: Use stable/yoga override for CI jobs (conclusion) https://review.opendev.org/c/openstack/cinderlib/+/845272 | 13:56 |
| opendevreview | Merged openstack/cinderlib master: Use stable/yoga override for CI jobs https://review.opendev.org/c/openstack/cinderlib/+/845170 | 14:25 |
| *** dviroel is now known as dviroel|lunch | 15:01 | |
| whoami-rajat | tosky, hey, can you take another look at this patch, I've addressed your comments (it's been open for so long that just want to get it in) https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/795753 | 15:09 |
| whoami-rajat | and thanks enriquetaso for the review | 15:10 |
| enriquetaso | :) | 15:11 |
| rosmaita | whoami-rajat: geguileo: zuul is OK with the conclusion to the cinderlib gate change: https://review.opendev.org/c/openstack/cinderlib/+/845272 ... i have no idea why that job was working when all the others were broken | 15:47 |
| rosmaita | my theory is that since it derives ultimately from devstack-tempest, devstack is doing the setup instead of zuul | 15:47 |
| opendevreview | Eric Harney proposed openstack/cinder master: RBD: flatten child volumes on delete https://review.opendev.org/c/openstack/cinder/+/835384 | 16:16 |
| *** dviroel|lunch is now known as dviroel | 16:19 | |
| opendevreview | Merged openstack/cinder master: db: Migrate 'purge_deleted_rows' to enginefacade https://review.opendev.org/c/openstack/cinder/+/837538 | 16:46 |
| opendevreview | Merged openstack/cinder master: db: Final cleanup for context-based enginefacade https://review.opendev.org/c/openstack/cinder/+/837539 | 16:48 |
| opendevreview | Merged openstack/cinder master: db: Remove final users of 'get_session' https://review.opendev.org/c/openstack/cinder/+/837540 | 17:04 |
| opendevreview | Merged openstack/cinder master: db: Remove unused API https://review.opendev.org/c/openstack/cinder/+/837541 | 17:04 |
| enriquetaso | Hello, feel free to review this RBD minimal CI patch https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/782624/ | 17:34 |
| opendevreview | Walt proposed openstack/cinder-specs master: WIP: Add new volume transaction tracking https://review.opendev.org/c/openstack/cinder-specs/+/845176 | 19:53 |
| opendevreview | Vladislav Belogrudov proposed openstack/cinder master: Initial commit for Yadro Tatlin.UNIFIED driver https://review.opendev.org/c/openstack/cinder/+/825492 | 20:00 |
| hemna | who creates the request_id and global_request_id ? | 20:04 |
| rosmaita | hemna: i think it's created by middleware when a request hits the API ... we have a cinder class that is configured in api-paste | 20:46 |
| rosmaita | gorka fixed a bug (actually several) where request_ids weren't behaving correctly, i think the fix is in yoga | 20:46 |
| rosmaita | "Fix request id mess on Cinder-API" https://review.opendev.org/c/openstack/cinder/+/827860 | 20:47 |
| opendevreview | Harsh Ailani proposed openstack/cinder master: [SVf] : Fix multiple SVC CLI calls for rc-relationship operations https://review.opendev.org/c/openstack/cinder/+/844140 | 20:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!