opendevreview | Merged openstack/cinder-tempest-plugin master: Cap cinder-tempest-plugin version for stable/ussuri|victoria https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843319 | 01:25 |
---|---|---|
opendevreview | Alan Bishop proposed openstack/cinder master: Prepare unit test request contexts for secure RBAC https://review.opendev.org/c/openstack/cinder/+/828805 | 02:20 |
opendevreview | Alan Bishop proposed openstack/cinder master: Update deprecated policies and rules for Zed https://review.opendev.org/c/openstack/cinder/+/828806 | 02:20 |
opendevreview | Alan Bishop proposed openstack/cinder master: WIP: Add release note for policy changes in Zed https://review.opendev.org/c/openstack/cinder/+/828807 | 02:20 |
opendevreview | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/843361 | 02:28 |
dc_arunkv | Hello Core Reviewers, please review the patch: https://review.opendev.org/c/openstack/cinder/+/836996. Thank you. | 03:28 |
*** bhagyashris is now known as bhagyashris|ruck | 05:08 | |
opendevreview | Lucian Petrut proposed openstack/os-brick master: Avoid volume extension errors caused by multipath-tools version https://review.opendev.org/c/openstack/os-brick/+/762776 | 07:48 |
opendevreview | Vladislav Belogrudov proposed openstack/cinder master: Initial commit for Yadro Tatlin.UNIFIED driver https://review.opendev.org/c/openstack/cinder/+/825492 | 08:34 |
opendevreview | Alexander Malashenko proposed openstack/cinder master: WIP: Add Cinder NFS driver for Dell EMC PowerStore https://review.opendev.org/c/openstack/cinder/+/797608 | 08:50 |
geguileo | whoami-rajat: tosky did we change the zull status URL: I usually looked at http://status.openstack.org/zuul/ | 08:56 |
whoami-rajat | geguileo, I use https://zuul.openstack.org/ | 08:56 |
geguileo | whoami-rajat: thanks, that one works | 08:57 |
whoami-rajat | geguileo, yep, not sure about the one you're using, maybe an old one | 08:57 |
geguileo | yeah, most likely a really, really old one | 08:58 |
whoami-rajat | :D | 08:58 |
tosky | geguileo, whoami-rajat : http://lists.openstack.org/pipermail/openstack-discuss/2022-April/028279.html | 09:02 |
geguileo | tosky: thanks! | 09:03 |
whoami-rajat | tosky, that explains it, thanks | 09:04 |
opendevreview | Rajat Dhasmana proposed openstack/cinder stable/wallaby: Fix: nfs format info limitation https://review.opendev.org/c/openstack/cinder/+/843593 | 10:03 |
opendevreview | Rajat Dhasmana proposed openstack/cinder stable/wallaby: Fix: nfs format info limitation https://review.opendev.org/c/openstack/cinder/+/843593 | 10:18 |
*** dviroel|out is now known as dviroel | 11:15 | |
opendevreview | Benny Kopilov proposed openstack/cinder-tempest-plugin master: Refactor rbac cinder tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/842954 | 11:38 |
opendevreview | Matheus Andrade proposed openstack/cinder master: Fix NetApp NFS storage migration between backends https://review.opendev.org/c/openstack/cinder/+/843018 | 12:56 |
*** dviroel is now known as dviroel|afk | 13:07 | |
rosmaita | whoami-rajat__: could use your opinion on whether my -1 on https://review.opendev.org/c/openstack/cinder/+/768105 is justified | 13:24 |
whoami-rajat | please join festival of XS reviews! jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin https://meetpad.opendev.org/cinder-festival-of-reviews | 14:02 |
whoami-rajat | I'm running 5 minutes late | 14:02 |
geguileo | I won't be able to join. I'm on another meeting | 14:02 |
rosmaita | whoami-rajat: i lost power at home and am at a coffee shop, will not join meetpad, but i am here | 14:02 |
whoami-rajat | sure, np | 14:03 |
whoami-rajat | rosmaita, ack np | 14:03 |
whoami-rajat | as long as people are doing reviews! | 14:03 |
whoami-rajat | not mandatory to join :) | 14:03 |
rosmaita | don't say that out loud! | 14:03 |
rosmaita | oh, you meant meetpad | 14:03 |
rosmaita | meetpad is optional, festival is mandatory | 14:04 |
whoami-rajat | yes, meetpad = optional, reviews = mandatory! | 14:08 |
whoami-rajat | rosmaita, do we start the meeting here? sorry It's my first time :/ | 14:10 |
rosmaita | yes, though we haven't been consistent about it | 14:10 |
whoami-rajat | ok, i will start it just to make sure we have the festival | 14:10 |
rosmaita | probably good to start the meeting so we can at least get a roll call | 14:10 |
rosmaita | eharney: enriquetaso: what do you think of https://review.opendev.org/c/openstack/cinder/+/843309 ? I am afraid to look at anything about RBD deletion until y'all have gotten our current troubles worked out | 14:12 |
whoami-rajat | #startmeeting cinder_reviewfest | 14:14 |
opendevmeet | Meeting started Fri May 27 14:14:03 2022 UTC and is due to finish in 60 minutes. The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:14 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:14 |
opendevmeet | The meeting name has been set to 'cinder_reviewfest' | 14:14 |
eharney | rosmaita: the theory is plausible but i'd need to go do some live testing to see if that really makes sense, hard to say at a glance. definitely shouldn't just merge it | 14:14 |
whoami-rajat | rosmaita, any reason we use meetpad? it's having some audio problems (as always) | 14:14 |
whoami-rajat | I'm thinking of using google meet from next time (or from now also) | 14:15 |
rosmaita | well, it allows you to see more participants than bluejeans | 14:15 |
whoami-rajat | hmm, we're 3 people right now there so maybe not a priority to see more people :D | 14:15 |
jbernard | i cant hear anything | 14:15 |
rosmaita | whoami-rajat: note the time and symptoms and send a bug report to clarkb or fungi in #opendev ... they try to keep meetpad working, and say that they need specific incidents to track | 14:16 |
rosmaita | jbernard: what browser are you using? | 14:16 |
jbernard | firefox | 14:16 |
rosmaita | firefox treats meetpad as spam, you have to enable autoplay or something | 14:16 |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: cinder/cmd/[api,backup,scheduler,status,volume] https://review.opendev.org/c/openstack/cinder/+/842541 | 14:16 |
rosmaita | give me a minute i hvae the details somewhere | 14:17 |
rosmaita | jbernard: lines 7-8 on https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:17 |
whoami-rajat | eharney, can you hear me or jbernard? | 14:18 |
whoami-rajat | rosmaita, ack | 14:18 |
eharney | whoami-rajat: i hadn't tried since this thing rarely works well for me, let me actually try to turn it on | 14:18 |
whoami-rajat | eharney, i can hear you but maybe you can't | 14:19 |
jbernard | nope | 14:19 |
jbernard | disabled autoplay, still no audio | 14:20 |
rosmaita | do you mean "enabled" ? | 14:20 |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: cmd/manage.py https://review.opendev.org/c/openstack/cinder/+/842542 | 14:20 |
jbernard | right | 14:20 |
rosmaita | bummer | 14:21 |
jbernard | changed from block to allow audio and video | 14:21 |
jbernard | ok, its working | 14:21 |
rosmaita | \o/ | 14:22 |
jbernard | the setting doesnt apply to existing tabs, i needed to close and re-open it | 14:22 |
rosmaita | ok, good to know | 14:23 |
fungi | whoami-rajat: what browser are you using with meetpad? chromium? chrome? firefox? jitsi mobile client? something else? | 14:26 |
whoami-rajat | fungi, chrome | 14:27 |
whoami-rajat | so currently the problem was jbernard was using firefox and now we are able to hear everyone | 14:27 |
fungi | there are also play audio permissions in chrome though they were not as hard for me to find as the ones in firefox (which are thoroughly buried in the privacy settings) | 14:28 |
fungi | oh, if it was jbernard having to allow "auto play audio" in firefox to get webrtc to work, yes i too have observed that changing that requires a restart of firefox | 14:28 |
whoami-rajat | but the general experience with meetpad and audio issues dates back to several meetings ... | 14:28 |
whoami-rajat | though we will keep in mind your suggestions if someone faces similar issues | 14:29 |
fungi | so far we haven't come across any audio problems we're able to confirm in meetpad which didn't boil down to either the browser blocking audio, the browser getting overwhelmed by too many video streams, or firewalls blocking webrtc connections in one direction | 14:30 |
whoami-rajat | hmm, we recently used meetpad for our PTG photo with around 25-30 people where around half were able to hear me | 14:32 |
opendevreview | Merged openstack/cinder master: PowerMax Docs - Known issues section https://review.opendev.org/c/openstack/cinder/+/843118 | 14:32 |
whoami-rajat | but maybe they had trivial issues, but again they didn't face similar issues with google meet | 14:33 |
fungi | apparently jitsi-meet choosing to build on top of the media streaming support in browsers was a great idea, until web sites also started using those same browser features to spam visitors relentlessly, resulting in browsers now basically crippling that functionality. platforms which rolled their own a/v work around that by bypassing the browsers' features | 14:33 |
fungi | continue to work as before | 14:34 |
rosmaita | that's why we can't have nice things | 14:36 |
fungi | but yeah, the jitsi-meet mobile client seems to work for everyone i know who's tried it. chrome/chromium work for most people if they haven't adjusted the privacy settings or added extensions which may auto-block it, or are on office networks where the security folks have decided webrtc connections are dangerous. modern versions of firefox work for almost nobody unless they can find | 14:37 |
fungi | the hidden toggle to allow auto-play audio and then restart their browser | 14:37 |
rosmaita | i'd prefer to use an open solution if possible (though i must admit, i use bluejeans when we are recording a meeting, because that's easy and seems to work well) | 14:39 |
fungi | https://github.com/jitsi/jitsi-meet/issues/1221 | 14:40 |
fungi | this is the similar report for chrom*, but apparently it's a little smarter about things: https://github.com/jitsi/jitsi-meet/issues/9528 | 14:44 |
fungi | it's possible adding a pre-join screen as suggested there will help in some cases | 14:45 |
fungi | i'll look into that more | 14:45 |
enriquetaso | rosmaita, eharney (regarding 843309): It looks like it could work. I think the best thing to do is test it with the patch that flats the children when the volume is deleted to see what happens. | 14:45 |
rosmaita | enriquetaso: thanks ... maybe put a note on the review so someone doesn't prematurely approve it | 14:49 |
whoami-rajat | rosmaita, replied on the powermax patch, I agree with you on that and from the commit message, looks like maybe they're trying to fix multiple things in a single patch | 14:50 |
whoami-rajat | but let's see | 14:50 |
rosmaita | whoami-rajat: thanks for looking | 14:51 |
whoami-rajat | np | 14:51 |
rosmaita | btw, tosky said he may join late, and i think jungleboyj had a conflict | 14:55 |
jungleboyj | Yes, apologies. I have conflicts today. | 14:56 |
whoami-rajat | sure, I see 5 people (including me) in the meet as of now | 14:59 |
whoami-rajat | If anyone wants to discuss anything regarding any patch, you can ask here or in the meetpad meeting | 14:59 |
whoami-rajat | dashboard link | 15:00 |
whoami-rajat | #link http://tiny.cc/cinder-reviewfest | 15:00 |
whoami-rajat | enriquetaso, would you like you upgrade your vote here? https://review.opendev.org/c/openstack/cinder/+/793267 | 15:03 |
enriquetaso | sure whoami-rajat | 15:10 |
whoami-rajat | thanks | 15:10 |
opendevreview | Merged openstack/cinder master: Tests: Extend RBD deferred deletion interval https://review.opendev.org/c/openstack/cinder/+/843151 | 15:10 |
opendevreview | Merged openstack/cinder master: tox.ini: combine functional-py* envs https://review.opendev.org/c/openstack/cinder/+/843153 | 15:11 |
whoami-rajat | I will be leaving meetpad now but will continue review and will be available here on IRC | 15:19 |
jungleboyj | If there is anything that people need me to take a look at feel free to ping me here. | 15:19 |
opendevreview | Eric Harney proposed openstack/cinder master: Groups: remove unneeded "status" variable https://review.opendev.org/c/openstack/cinder/+/840493 | 15:21 |
enriquetaso | Do you know anyone on the Tempest team I could write to for this patch? I think it's important for us to continue testing the backup restore feature. | 15:21 |
enriquetaso | https://review.opendev.org/c/openstack/tempest/+/843542 | 15:21 |
eharney | https://review.opendev.org/c/openstack/cinder/+/835635 fixes a bug reported on the openstack mailing list a bit ago, would be good to review it | 15:23 |
whoami-rajat | enriquetaso, you can ask gmann or kopecmartin in #openstack-qa channel for reviews | 15:26 |
enriquetaso | thanks whoami-rajat, added them to cc on the patch | 15:28 |
whoami-rajat | np | 15:28 |
gmann | whoami-rajat: enriquetaso: will review | 15:30 |
whoami-rajat | thanks gmann ! | 15:30 |
enriquetaso | thanks gmann ! | 15:38 |
gmann | enriquetaso: np! | 15:38 |
rosmaita | whoami-rajat: you can do gmann a return favor on https://review.opendev.org/c/openstack/cinder/+/843092 | 15:45 |
whoami-rajat | looking | 15:47 |
whoami-rajat | gmann, left one comment here, if you would like to followup https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843319 | 15:53 |
whoami-rajat | minor change but description needs to be correct | 15:53 |
gmann | whoami-rajat: ah sure, will push as followup | 15:54 |
whoami-rajat | thanks! | 15:54 |
whoami-rajat | we're towards the end of festival of XS reviews. Thanks everyone for joining and you can continue reviewing not just XS but any patch! | 16:00 |
whoami-rajat | have a great weekend ahead | 16:00 |
whoami-rajat | #endmeeting | 16:00 |
opendevmeet | Meeting ended Fri May 27 16:00:21 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_reviewfest/2022/cinder_reviewfest.2022-05-27-14.14.html | 16:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_reviewfest/2022/cinder_reviewfest.2022-05-27-14.14.txt | 16:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_reviewfest/2022/cinder_reviewfest.2022-05-27-14.14.log.html | 16:00 |
rosmaita | thanks! | 16:00 |
*** dviroel|afk is now known as dviroel | 16:08 | |
enriquetaso | o/ | 16:15 |
enriquetaso | thanks! | 16:15 |
opendevreview | Merged openstack/cinder master: Fix QOS computation https://review.opendev.org/c/openstack/cinder/+/815560 | 16:51 |
opendevreview | Merged openstack/cinder master: Modify manner of retrieving volume_ref https://review.opendev.org/c/openstack/cinder/+/793267 | 17:46 |
opendevreview | Merged openstack/cinder master: Remove extra volume_type DB fetch on volume manage https://review.opendev.org/c/openstack/cinder/+/834918 | 17:47 |
dc_arunkv | Hello Core Reviewers, please review the patch: https://review.opendev.org/c/openstack/cinder/+/836996. Thank you. | 17:55 |
opendevreview | Merged openstack/cinder master: Scheduler Evaluator: raise recursion limit https://review.opendev.org/c/openstack/cinder/+/835635 | 18:32 |
opendevreview | Merged openstack/cinder master: docs: update release cycle tasks https://review.opendev.org/c/openstack/cinder/+/842633 | 18:32 |
opendevreview | Merged openstack/cinder master: mypy: cinder/volume/volume_types.py https://review.opendev.org/c/openstack/cinder/+/835881 | 18:32 |
opendevreview | Rico Lin proposed openstack/cinder master: Add image_conversion_disable config https://review.opendev.org/c/openstack/cinder/+/839793 | 18:42 |
*** dviroel is now known as dviroel|afk | 19:50 | |
opendevreview | Ghanshyam proposed openstack/cinder-tempest-plugin master: Fixing job description for stable branch job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843685 | 20:21 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!