| opendevreview | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add multiattach tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/791921 | 07:37 |
|---|---|---|
| opendevreview | Francesco Pantano proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 09:23 |
| opendevreview | OpenStack Release Bot proposed openstack/cinder stable/yoga: Update .gitreview for stable/yoga https://review.opendev.org/c/openstack/cinder/+/833541 | 09:30 |
| opendevreview | OpenStack Release Bot proposed openstack/cinder stable/yoga: Update TOX_CONSTRAINTS_FILE for stable/yoga https://review.opendev.org/c/openstack/cinder/+/833542 | 09:30 |
| opendevreview | OpenStack Release Bot proposed openstack/cinder master: Update master for stable/yoga https://review.opendev.org/c/openstack/cinder/+/833543 | 09:30 |
| opendevreview | OpenStack Release Bot proposed openstack/cinder master: Add Python3 zed unit tests https://review.opendev.org/c/openstack/cinder/+/833544 | 09:30 |
| opendevreview | Mounika Sreeram proposed openstack/cinder master: [SVf] Delete volume issue in reverse replication https://review.opendev.org/c/openstack/cinder/+/831776 | 09:59 |
| opendevreview | Francesco Pantano proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 10:08 |
| opendevreview | Merged openstack/cinder master: Update master for stable/yoga https://review.opendev.org/c/openstack/cinder/+/833543 | 11:10 |
| opendevreview | Merged openstack/cinder stable/yoga: Update .gitreview for stable/yoga https://review.opendev.org/c/openstack/cinder/+/833541 | 11:11 |
| *** dviroel is now known as dviroel|ruck | 11:14 | |
| opendevreview | Mounika Sreeram proposed openstack/cinder master: [SVf] Delete volume issue in reverse replication https://review.opendev.org/c/openstack/cinder/+/831776 | 11:58 |
| hemna | morning | 12:39 |
| hemna | so for logging in cinder LOG.info("something", resource=volume_ref). what is expected to happen in the log ? | 13:17 |
| hemna | for example, https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2033-L2034 | 13:18 |
| hemna | I get. INFO cinder.volume.manager [req-80f40566-6958-49f1-ac25-9dbc7fb274a3 greq-8f738b1a-0210-449b-a29f-9a623fd637f9 f0256222bf1b5893da6f8935c96abbacbf464b9b9c6ad4d854819b3bf1a5a54d 75c66a47a77a484ebad71210eca82c4b - 91812622ef084279a6daa53089e9c0f4 91812622ef084279a6daa53089e9c0f4] Terminate volume connection completed successfully. | 13:19 |
| hemna | none of which is a volume id | 13:19 |
| opendevreview | Merged openstack/cinder master: Add Python3 zed unit tests https://review.opendev.org/c/openstack/cinder/+/833544 | 13:42 |
| yuval | hemna - I think its a bug | 13:55 |
| yuval | should be something like: LOG.info("Terminate volume connection completed successfully. %s", dict(resource=volume_ref)) | 13:55 |
| yuval | or: LOG.info("Terminate volume connection completed successfully. %(resource)s", dict(resource=volume_ref)) | 13:55 |
| hemna | hrmm ok | 14:09 |
| hemna | I thought it was supposed to get added to the log header, the [ req-.....] section | 14:10 |
| hemna | every reference to logging in the volume manager is the same for resource= | 14:28 |
| eharney | look at the oslo log code which looks for the resource object being passed in | 14:36 |
| eharney | https://opendev.org/openstack/oslo.log/src/branch/master/oslo_log/log.py#L170 | 14:36 |
| eharney | it appears to look for the name, i.e. not a bug in cinder's usage of it | 14:36 |
| eharney | hemna: ^ | 14:36 |
| hemna | so it looks like that resource= has no effect in the logs | 14:37 |
| hemna | I even changed a log entry to say resource={'type': 'volume', 'id': volume.id} | 14:39 |
| hemna | no effect | 14:39 |
| hemna | │Mar 14 10:41:32 devstack-train cinder-volume[9999]: INFO cinder.volume.manager [None req-2fc2c177-95dd-457c-8b1e-8af300a26582 admin None] Created volume successfully. │ | 14:41 |
| hemna | │Mar 14 10:41:32 devstack-train cinder-volume[9999]: INFO cinder.volume.manager [None req-2fc2c177-95dd-457c-8b1e-8af300a26582 admin None] Created volume successfully2. | 14:41 |
| hemna | LOG.info("Created volume successfully.", resource=volume) | 14:42 |
| hemna | + LOG.info("Created volume successfully2.", resource={'type': 'volume', 'id': volume.id}) | 14:42 |
| hemna | can someone test this on master ? | 14:42 |
| hemna | if this does nothing, then why is it all over the volume manager and elsewhere | 14:42 |
| *** hemna0 is now known as hemna | 15:03 | |
| yuval | maybe there was a field resource in the "context" and it was removed | 15:14 |
| *** dviroel|ruck is now known as dviroel|ruck|lunch | 15:36 | |
| *** melwitt_ is now known as melwitt | 16:14 | |
| *** dviroel|ruck|lunch is now known as dviroel|ruck | 16:22 | |
| *** dviroel|ruck is now known as dviroel|ruck|afjk | 20:50 | |
| *** dviroel|ruck|afjk is now known as dviroel|ruck|afk | 20:50 | |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 22:24 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 23:19 |
| *** dviroel|ruck|afk is now known as dviroel|ruck | 23:49 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!