| opendevreview | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/818037 | 02:39 |
|---|---|---|
| *** brinzhang_ is now known as brinzhang | 07:44 | |
| *** akekane_ is now known as abhishekk | 07:52 | |
| opendevreview | Rajat Dhasmana proposed openstack/cinder-specs master: Add volume reimage spec https://review.opendev.org/c/openstack/cinder-specs/+/809622 | 08:59 |
| opendevreview | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Manage host attachment using portsets https://review.opendev.org/c/openstack/cinder/+/817351 | 09:03 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Add default types info in admin docs https://review.opendev.org/c/openstack/cinder/+/818528 | 10:14 |
| opendevreview | Mounika Sreeram proposed openstack/cinder master: [SVF] Fix Retype issue of mirror volume https://review.opendev.org/c/openstack/cinder/+/816324 | 12:48 |
| opendevreview | Mounika Sreeram proposed openstack/cinder master: [SVF] Fix Retype issue of mirror volume https://review.opendev.org/c/openstack/cinder/+/816324 | 12:52 |
| opendevreview | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Manage host attachment using portsets https://review.opendev.org/c/openstack/cinder/+/817351 | 12:54 |
| opendevreview | Niklas Schwarz proposed openstack/cinder-specs master: Spec to introduce additional task status field https://review.opendev.org/c/openstack/cinder-specs/+/818551 | 13:10 |
| nschwarz | rosmaita: May I ask you to mark my 'old' BP (https://blueprints.launchpad.net/cinder/+spec/volume-status-for-server-migration) with the new BP (https://blueprints.launchpad.net/cinder/+spec/move-task-status-to-dedicated-field). | 13:20 |
| rosmaita | nschwarz: ack | 13:21 |
| nschwarz | rosmaita: Thanks | 13:21 |
| rosmaita | Cinder Festival of Reviews today, 1400-1600 UTC | 13:56 |
| rosmaita | join us in meetpad: https://meetpad.opendev.org/cinder-festival-of-reviews | 13:56 |
| rosmaita | or go directly to the etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 13:56 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira ^^ | 13:56 |
| rosmaita | (i am having bandwidth issues and won't be in meetpad, so communicate with me here) | 13:57 |
| rosmaita | #startmeeting cinder_reviewfest | 14:00 |
| opendevmeet | Meeting started Fri Nov 19 14:00:42 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder_reviewfest' | 14:00 |
| rosmaita | hello everyone! | 14:00 |
| rosmaita | you can join in meetpad, or just hang out here | 14:01 |
| rosmaita | https://meetpad.opendev.org/cinder-festival-of-reviews | 14:01 |
| rosmaita | and here is the etherpad link: | 14:01 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:01 |
| rosmaita | we have some slightly modified rules for today | 14:02 |
| rosmaita | each attendee may nominate a patch to be reviewed on the etherpad | 14:02 |
| rosmaita | (you must be present to win!) | 14:02 |
| rosmaita | also, if you have a docs-only patch, please list it (they tend to be bigger than 10 LOC, but not hard to review) | 14:03 |
| rosmaita | here's the festival review query (you have to be logged in to gerrit for it to work): | 14:04 |
| rosmaita | #link https://review.opendev.org/q/(project:openstack/cinder+OR+project:openstack/os-brick+OR+project:openstack/python-cinderclient+OR+project:openstack/python-brick-cinderclient-ext+OR+project:openstack/cinderlib+OR+project:openstack/rbd-iscsi-client)+AND+status:open+AND+size:%253C%253D10+AND+NOT+owner%3Aself+AND+is%3Amergeable+AND+NOT+label%3AWorkflow%3C%3D-1+AND+label%3AVerified%3E%3D1+AND+NOT+reviewedby%3Aself+AND+ | 14:04 |
| rosmaita | %3ACode-Review%3C%3D-1 | 14:04 |
| rosmaita | happy reviewing! | 14:05 |
| * enriquetaso gooing | 14:08 | |
| rosmaita | https://review.opendev.org/c/openstack/cinder/+/694140 has one +2 | 14:08 |
| enriquetaso | ok, no meetpad | 14:08 |
| rosmaita | enriquetaso: you can do meetpad, i just won't be there to entertain everyone | 14:09 |
| enriquetaso | 694140 looks right and test passed | 14:11 |
| rosmaita | This has one +2 and is a no-brainer (though the commit message is slightly misleading): https://review.opendev.org/c/openstack/cinder/+/805916 | 14:20 |
| rosmaita | This one also has one +2: https://review.opendev.org/c/openstack/cinder/+/801633 | 14:31 |
| jungleboyj | Sorry. My start time was off by an hour. Yay time change. Will join when I can. | 14:59 |
| rosmaita | jungleboyj: :D | 14:59 |
| jungleboyj | I will have to fix that. Not that it makes a difference as I have meetings all morning, every morning. | 15:01 |
| rosmaita | it's kind of funny for me, some meetings i am still on time for, and some i keep missing ... i guess i have only half-adjusted to normal time | 15:03 |
| enriquetaso | This is a simple one https://review.opendev.org/c/openstack/cinder/+/810785 | 15:04 |
| *** dviroel is now known as dviroel|lunch | 15:20 | |
| opendevreview | Merged openstack/cinder master: RBD: Check for OSError before using errno https://review.opendev.org/c/openstack/cinder/+/694140 | 16:01 |
| rosmaita | ok, we are officially out of time ... but feel free to continue reviewing! | 16:02 |
| rosmaita | thanks for attending, everyone | 16:02 |
| rosmaita | #endmeeting | 16:02 |
| opendevmeet | Meeting ended Fri Nov 19 16:02:38 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:02 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_reviewfest/2021/cinder_reviewfest.2021-11-19-14.00.html | 16:02 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_reviewfest/2021/cinder_reviewfest.2021-11-19-14.00.txt | 16:02 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_reviewfest/2021/cinder_reviewfest.2021-11-19-14.00.log.html | 16:02 |
| opendevreview | Merged openstack/cinder master: Erroneous log message args location causes a misconception https://review.opendev.org/c/openstack/cinder/+/790014 | 16:05 |
| opendevreview | Merged openstack/cinder master: Modify erroneous annotation https://review.opendev.org/c/openstack/cinder/+/805916 | 16:05 |
| opendevreview | Merged openstack/cinder master: Fix extra_capabilities https://review.opendev.org/c/openstack/cinder/+/801633 | 16:09 |
| opendevreview | Merged openstack/cinder master: Add reviewing section to release notes doc https://review.opendev.org/c/openstack/cinder/+/810729 | 16:09 |
| opendevreview | Luciano Lo Giudice proposed openstack/cinder master: Fix QOS computation https://review.opendev.org/c/openstack/cinder/+/815560 | 16:28 |
| opendevreview | Merged openstack/cinder master: Clarify conditional_update return types https://review.opendev.org/c/openstack/cinder/+/817229 | 16:30 |
| rosmaita | whoami-rajat__: nice work on all the __DEFAULT__-related changes! I went ahead and ninja-approved them, because there's no point having them sit around in gerrit when users could be reading the content. | 16:41 |
| rosmaita | anyway, my point is, it would be good for you to do a quick update at the midcycle | 16:41 |
| rosmaita | just pointing out the changes, and if people have suggestions for improvements, they can put up followup patches | 16:42 |
| enriquetaso | oops rosmaita double workflow https://review.opendev.org/c/openstack/python-cinderclient/+/816188 | 16:47 |
| rosmaita | enriquetaso: well, at least we agree! | 16:48 |
| *** dviroel|lunch is now known as dviroel | 16:54 | |
| enriquetaso | Do we need an update regarding https://review.opendev.org/c/openstack/cinder/+/768458 ? | 17:06 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Update release cycle tasks https://review.opendev.org/c/openstack/cinder/+/810785 | 17:07 |
| fabiooliveira | hello, we need some reviews on https://review.opendev.org/c/openstack/cinder/+/798208, already has some +1s there and its a driver related bugfix | 17:09 |
| fabiooliveira | CI is ok | 17:09 |
| rosmaita | enriquetaso: that looks like a kind of important patch ... i can email the author to see if they are willing to update it or let someone else complete it | 17:10 |
| rosmaita | (i think that's why you were asking?) | 17:10 |
| rosmaita | fabiooliveira: i will take a look | 17:10 |
| fabiooliveira | thank you :) | 17:10 |
| whoami-rajat__ | rosmaita, sure, will do. thanks for all the approvals and suggestions on the patches! | 17:12 |
| rosmaita | fabiooliveira: it's kind of concerning that the CI failed so much on that patch | 17:15 |
| fabiooliveira | rosmaita: our FCP test was with some issues due to an ontap device unhealthy, none was passing, but we got it fixed | 17:20 |
| rosmaita | ok, i was hoping it was something like that | 17:21 |
| enriquetaso | thanks rosmaita | 17:40 |
| *** whoami-rajat__ is now known as whoami-rajat | 17:42 | |
| opendevreview | Merged openstack/python-cinderclient master: Improve help text of volume create command https://review.opendev.org/c/openstack/python-cinderclient/+/816188 | 18:37 |
| opendevreview | Merged openstack/cinder master: Add info about __DEFAULT__ in install docs https://review.opendev.org/c/openstack/cinder/+/816187 | 19:03 |
| opendevreview | Merged openstack/cinder master: api-ref: Add info regarding default types https://review.opendev.org/c/openstack/cinder/+/816184 | 19:05 |
| opendevreview | Merged openstack/cinder master: Add default types info in admin docs https://review.opendev.org/c/openstack/cinder/+/818528 | 19:07 |
| opendevreview | Merged openstack/cinder master: Update release cycle tasks https://review.opendev.org/c/openstack/cinder/+/810785 | 19:07 |
| opendevreview | Merged openstack/cinder stable/xena: [Pure Storage] Add missing DB values when performing create CG from CG snap https://review.opendev.org/c/openstack/cinder/+/815884 | 20:04 |
| opendevreview | Merged openstack/cinder master: Tests: Fix missing RBD delete_volume test case https://review.opendev.org/c/openstack/cinder/+/807933 | 20:04 |
| opendevreview | Simon Dodsley proposed openstack/cinder stable/wallaby: [Pure Storage] Add missing DB values when performing create CG from CG snap https://review.opendev.org/c/openstack/cinder/+/818579 | 20:05 |
| opendevreview | Merged openstack/cinder master: NetApp ONTAP: Fix sub-clone zapi call https://review.opendev.org/c/openstack/cinder/+/798208 | 20:08 |
| opendevreview | Merged openstack/cinder master: Remove broken tempest-full-py3-opensuse15 job https://review.opendev.org/c/openstack/cinder/+/816573 | 20:28 |
| opendevreview | Merged openstack/cinder master: Fix misspelled get_time_comparsion_operators method name https://review.opendev.org/c/openstack/cinder/+/818002 | 20:28 |
| opendevreview | Merged openstack/cinder master: pylint: Update to 2.11.1 https://review.opendev.org/c/openstack/cinder/+/817573 | 20:28 |
| *** dviroel is now known as dviroel|out | 20:37 | |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: [rbd] Fix creating encrypted volume from unencrypted image https://review.opendev.org/c/openstack/cinder/+/801522 | 21:16 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!