| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status https://review.opendev.org/c/openstack/cinder/+/804735 | 03:36 |
|---|---|---|
| opendevreview | Raghavendra Tilay proposed openstack/cinder master: HPE 3PAR: Add HPE Alletra 9k related information https://review.opendev.org/c/openstack/cinder/+/805796 | 05:17 |
| *** akekane__ is now known as abhishekk | 05:54 | |
| zenkuro | hay! please check this driver bug fix, it is short and recommendations where addressed https://review.opendev.org/c/openstack/cinder/+/806191/3 | 07:34 |
| opendevreview | Seena Fallah proposed openstack/cinder master: snapshot: allow revert to any point for rbd driver https://review.opendev.org/c/openstack/cinder/+/806807 | 08:33 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: Online migration for volume_use_quota_online_data_migration https://review.opendev.org/c/openstack/cinder/+/807083 | 09:10 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: Online migration for volume_use_quota_online_data_migration https://review.opendev.org/c/openstack/cinder/+/807083 | 09:21 |
| zenkuro | smcginnis: please give your opinion regarding small bugfix https://review.opendev.org/c/openstack/cinder/+/806191/3 | 09:39 |
| raghavendrat | hi geguileo: this is regarding yesterday's code review https://review.opendev.org/c/openstack/cinder/+/805796 | 09:57 |
| raghavendrat | updated release note. Can you please check. Thanks. | 09:58 |
| venkatakrishnat | Hi eharney, geguileo, whoami-rajat: could you please have a look at this simple patch https://review.opendev.org/c/openstack/cinder/+/788782 | 10:01 |
| whoami-rajat | venkatakrishnat, left a comment | 10:11 |
| manoj_katari | ^whoami-rajat: could you please review this change https://review.opendev.org/c/openstack/cinder/+/791281 | 10:51 |
| manoj_katari | comments from brian are addressed already. | 10:51 |
| *** dviroel|out is now known as dviroel|ruck | 11:19 | |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Support volume re-image https://review.opendev.org/c/openstack/cinder/+/606346 | 12:25 |
| opendevreview | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Update rccg details for mirror volumes https://review.opendev.org/c/openstack/cinder/+/788782 | 12:29 |
| raghavendrat | hi jungleboyj: below patch was reviewed by you in last week. Made minor changes & added release note. | 12:32 |
| raghavendrat | Can you please check. Thanks. | 12:32 |
| raghavendrat | https://review.opendev.org/c/openstack/cinder/+/805796 | 12:32 |
| *** dviroel|ruck is now known as dviroel | 12:48 | |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 13:11 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 13:15 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 13:32 |
| rosmaita | final patch before we can release brick-cinderclient-ext: https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/806983 | 13:34 |
| rosmaita | e0ne eharney geguileo hemna jungleboyj smcginnis whoami-rajat enriquetaso ^^ | 13:34 |
| whoami-rajat | done | 13:37 |
| rosmaita | whoami-rajat: ty, still need 1 more ^^ | 13:38 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Add W503 to flake8 ignores https://review.opendev.org/c/openstack/python-cinderclient/+/807152 | 13:50 |
| jungleboyj | rosmaita: Done. | 13:58 |
| rosmaita | jungleboyj: ty! | 13:58 |
| zenkuro | Small bug fix in driver is looking for a reviewers https://review.opendev.org/c/openstack/cinder/+/806191 | 14:06 |
| zenkuro | Small bug fix in driver is looking for reviewers https://review.opendev.org/c/openstack/cinder/+/806191 | 14:06 |
| venkatakrishnat | Hi corereviewers, In your free time, could you please review this patch https://review.opendev.org/c/openstack/cinder/+/784140 which is to fix Mirror volumes extend operation issues | 14:28 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 14:41 |
| sfernand | zenkuro: are you Andrei? | 14:55 |
| sfernand | zenkuro: I've added a few more comments to your patch. Please don't be mad at me. | 14:57 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Update requirements for Xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/806983 | 14:58 |
| rosmaita | whoami-rajat: if you have a minute, can you verify the hash on https://review.opendev.org/c/openstack/releases/+/807167 ? thanks | 15:07 |
| whoami-rajat | rosmaita, sure | 15:07 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: Implement project personas for groups https://review.opendev.org/c/openstack/cinder/+/759955 | 15:14 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: Implement project personas for group_actions https://review.opendev.org/c/openstack/cinder/+/759955 | 15:14 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 15:15 |
| zenkuro | sfernand: thanks, for review! | 15:21 |
| zenkuro | sfernand: regarding super() and exceptions -> pep complains if I not add this fixes | 15:23 |
| sfernand | so you could move that stuff to your naming and code style fixes patch and put the fix on top of it | 15:23 |
| zenkuro | hm, some of cinder tests will fail without it | 15:28 |
| zenkuro | and I think critical fixes should go first | 15:28 |
| zenkuro | sfernand: I will revert naming, but I think that it is reasonable to leave the order the same | 15:35 |
| sfernand | zenkuro: ok! I would like to understand why we need the super and exceptions for passing pep. Is it faling in flake8 ? | 15:40 |
| zenkuro | sfernand: In my local tests --> yes | 15:41 |
| zenkuro | sfernand: for supper -> cinder/volume/drivers/open_e/iscsi.py:55:8: R1725: Consider using Python 3 style super() without arguments (super-with-arguments) | 15:48 |
| knomura | Hi core-reviewers, if you have a time, please take a look this patch for GVG supports in Hitachi driver. https://review.opendev.org/c/openstack/cinder/+/782910 | 15:49 |
| knomura | I planed the target of this patch is Xena-3, but not reviewed yet. I wait for reviews from core-reviewers. thanks. | 15:49 |
| zenkuro | sfernand: for exception as/from -> cinder/volume/drivers/open_e/iscsi.py:531:12: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from) | 15:52 |
| sfernand | isnt this pylint? | 15:52 |
| zenkuro | oh, yes my bad. It is pylint | 15:53 |
| sfernand | I've reverted your changes and tox -e pep8 gave me a success | 15:53 |
| zenkuro | ok, I will remove code improvements | 15:54 |
| sfernand | pylint is a non-voting and shouldn't be a problem, you can address them in a separate patch | 15:54 |
| sfernand | zenkuro: ok many thanks | 15:55 |
| zenkuro | sfernand: just dont go to far away, I will send update in 5-10 minutes =) | 15:56 |
| sfernand | this doc have some explanations on why we ask for splitting | 15:56 |
| sfernand | https://docs.openstack.org/contributors/code-and-documentation/patch-best-practices.html#structural-split-of-changes | 15:56 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: fix iscsi target recovery function https://review.opendev.org/c/openstack/cinder/+/806191 | 16:02 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: fix iscsi target recovery function https://review.opendev.org/c/openstack/cinder/+/806191 | 16:05 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: RBD: Fix _show_msg_check_clone_v2_api https://review.opendev.org/c/openstack/cinder/+/777031 | 16:09 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: fix iscsi target recovery function https://review.opendev.org/c/openstack/cinder/+/806191 | 16:09 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: fix iscsi target recovery function https://review.opendev.org/c/openstack/cinder/+/806191 | 16:11 |
| zenkuro | sorry to chat, that was a bit messy | 16:13 |
| zenkuro | sfernand: can you please recheck. And thanks for link, I need to renew my memory related to code style and processes. | 16:14 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: add multiattach support https://review.opendev.org/c/openstack/cinder/+/806726 | 16:19 |
| zenkuro | sfernand: please take a look at https://review.opendev.org/c/openstack/cinder/+/806726 as wekk | 16:19 |
| opendevreview | Alan Bishop proposed openstack/cinder master: Implement user visible extra specs https://review.opendev.org/c/openstack/cinder/+/806260 | 16:22 |
| sfernand | zenkuro: sure will do | 16:23 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: Fix restore Ceph backups to no-RBD volumes https://review.opendev.org/c/openstack/cinder/+/750782 | 16:40 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: Fix restore Ceph backups to no-RBD volumes https://review.opendev.org/c/openstack/cinder/+/750782 | 16:40 |
| opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807182 | 17:03 |
| opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807183 | 17:03 |
| opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext master: Update master for stable/xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807184 | 17:03 |
| opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807185 | 17:04 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: Fix restore Ceph backups to no-RBD volumes https://review.opendev.org/c/openstack/cinder/+/750782 | 17:33 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807182 | 17:56 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Update master for stable/xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807184 | 18:09 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807183 | 18:09 |
| zenkuro | jungleboyj: Ive addressed recommendations from sfernand, so can you give + to this patch again plz -> https://review.opendev.org/c/openstack/cinder/+/806191 | 18:12 |
| zenkuro | sfernand: Ive addressed your recommendations, can you please vote for https://review.opendev.org/c/openstack/cinder/+/806191 | 18:13 |
| zenkuro | hay core reviewers I have a feature patch that have some positive feedback and fixed recommendations -> https://review.opendev.org/c/openstack/cinder/+/806726/6 | 18:14 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/807185 | 18:34 |
| abishop | rosmaita: thanks for 2nd review of user visible extra specs patch; would it be better for me to clean up release note now? | 18:54 |
| rosmaita | abishop: i think leave it ... otherwise it will be without a Zuul +1 for two hours, which gives people an excuse not to review it | 18:55 |
| abishop | ack | 18:56 |
| rosmaita | i'm hoping someone will look this afternoon or early tomorrow so you don't need to ask for an FFE | 18:56 |
| zenkuro | rosmaita: sorry for bothering you, but can you please check my patches, they've beep reviewed many times and had some positive feedback | 18:57 |
| abishop | yes, that would be good | 18:57 |
| zenkuro | also Ive addressed most of requests | 18:57 |
| rosmaita | zenkuro: you are next on my list after sfernand (he goes first because he has been helpfully reviewing patches this week) | 18:58 |
| zenkuro | rosmaita: thanks, yah... I need to do things for a team as well. | 18:59 |
| sfernand | rosmaita: :D | 19:06 |
| opendevreview | mitya-eremeev-2 proposed openstack/cinder master: Fix simultaneous volume creation error in multiattach mode. https://review.opendev.org/c/openstack/cinder/+/805072 | 19:31 |
| sfernand | rosmaita: is this patch supposed to be merged today? https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 19:36 |
| rosmaita | sfernand: yes | 19:37 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: RBD: Call trash operation when plain deletion fails https://review.opendev.org/c/openstack/cinder/+/805887 | 20:24 |
| enriquetaso | yoctozepto o/ do you mind checking https://review.opendev.org/c/openstack/cinder/+/807083 for the online database schema migrations to Xena failure, thanks | 20:29 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Empty port info response https://review.opendev.org/c/openstack/cinder/+/807215 | 20:36 |
| *** dviroel is now known as dviroel|out | 21:01 | |
| sfernand | rosmaita: https://review.opendev.org/c/openstack/python-cinderclient/+/806817 patch looks good to me, tested it just in case and provided a +1 | 21:18 |
| rosmaita | sfernand: ty! | 21:18 |
| sfernand | perhaps enriquetaso and jungleboyj could take a look and add a +2 | 21:19 |
| rosmaita | sfernand: thanks for those pastes, you actually caught a mistake in the exception message (logic is good, though) | 21:37 |
| * enriquetaso looking | 21:38 | |
| sfernand | cool | 21:38 |
| rosmaita | it's this one, line 2 | 21:39 |
| rosmaita | https://paste.openstack.org/show/808554/ | 21:39 |
| rosmaita | should be: 'force' argument is not allowed after microversion 3.65. | 21:40 |
| enriquetaso | oh | 21:40 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 21:47 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 22:50 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Prepare for Xena cinderclient release https://review.opendev.org/c/openstack/python-cinderclient/+/807219 | 22:54 |
| sfernand | rosmaita: thanks a lot for the review! | 22:59 |
| rosmaita | np | 22:59 |
| rosmaita | zenkuro: just a few minor things on https://review.opendev.org/c/openstack/cinder/+/806559 and https://review.opendev.org/c/openstack/cinder/+/806726, otherwise they look fine | 23:51 |
| rosmaita | i think https://review.opendev.org/c/openstack/cinder/+/806191 has already been approved | 23:51 |
| opendevreview | Merged openstack/cinder master: Remove extraneous space from error message https://review.opendev.org/c/openstack/cinder/+/806945 | 23:52 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!