opendevreview | Jorhson Deng proposed openstack/python-cinderclient master: Remove the unused tool scripts https://review.opendev.org/c/openstack/python-cinderclient/+/788121 | 01:50 |
---|---|---|
*** abhishekk is now known as akekane|home | 03:55 | |
*** akekane|home is now known as abhishekk | 03:55 | |
*** akekane_ is now known as abhishekk | 06:01 | |
opendevreview | Gorka Eguileor proposed openstack/cinder master: 3PAR: Fix race in concurrent attachments https://review.opendev.org/c/openstack/cinder/+/756711 | 09:42 |
opendevreview | Helen Walsh proposed openstack/cinder stable/train: PowerMax Driver - Fix for create snapshot https://review.opendev.org/c/openstack/cinder/+/806132 | 10:18 |
venkatakrishnat | Hi whoami-rajat, eharney, jungleboyj: Could you please review https://review.opendev.org/c/openstack/cinder/+/786524 which got one CR +2 and waiting for workflow +2 | 10:40 |
*** dviroel|out is now known as dviroel|ruck | 11:14 | |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Expose volume_attachments in Volume OVO https://review.opendev.org/c/openstack/cinder/+/779576 | 11:34 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Fix: Nova thinks deleted volume is attached https://review.opendev.org/c/openstack/cinder/+/801913 | 11:35 |
opendevreview | Takashi Kajinami proposed openstack/cinder master: DNM: Debugging the error in the parent patch https://review.opendev.org/c/openstack/cinder/+/806140 | 11:35 |
opendevreview | Takashi Kajinami proposed openstack/cinder master: DNM: Debugging the error in 799663 https://review.opendev.org/c/openstack/cinder/+/806141 | 11:36 |
*** dviroel|ruck is now known as dviroel|ruck|brb | 11:58 | |
*** dviroel|ruck|brb is now known as dviroel|ruck | 12:20 | |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Expose volume & snapshot use_quota field https://review.opendev.org/c/openstack/cinder/+/786386 | 12:37 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: RBD: Don't flatten temporary resources https://review.opendev.org/c/openstack/cinder/+/790492 | 12:37 |
opendevreview | Merged openstack/cinder master: Update snapshot api microversion docs and tests https://review.opendev.org/c/openstack/cinder/+/791240 | 13:08 |
hemna | rosmaita, geguileo was thinking about adding a new cinder table to track volume actions. nova has an instance actions logging table. | 13:59 |
hemna | we have so many issues of volume attachment inconsistencies, it would be nice to have a history of create/delete/attach/detach requests logged in the db | 13:59 |
rosmaita | i'm not against the idea, would be a good topic for the ptg | 14:00 |
hemna | coolio | 14:02 |
geguileo | hemna: sounds good, we would have to have some kind of policy to clean them, but sounds good | 14:02 |
geguileo | hemna: I guess it would be similar to the notification system we have but in the DB | 14:03 |
hemna | yah I think that's fine. I'll see if I can find out what nova does with theirs. | 14:03 |
opendevreview | Andrei proposed openstack/cinder master: Fix iscsi target recovery for ensure-export https://review.opendev.org/c/openstack/cinder/+/806191 | 14:03 |
hemna | we have a process that cleans out deleted entries after a set time | 14:03 |
hemna | https://github.com/openstack/nova/blob/master/nova/objects/instance_action.py nova's object | 14:04 |
zenkuro | hemna: hi, can you please check https://review.opendev.org/c/openstack/cinder/+/806191 that is a separation of a bigger patch -> https://review.opendev.org/c/openstack/cinder/+/794962 | 14:14 |
zenkuro | in particulart it is a separate bug fix, can you please comment on that one. At lease to know of the general "form" is corretc? | 14:15 |
zenkuro | rosmaita: hi, extracted bug fix from big patch ^. Is it addresed properly? https://bugs.launchpad.net/cinder/+bug/1941746 | 14:18 |
rosmaita | zenkuro: thanks for separating those out ... in a meeting now, but will look soon-ish | 14:18 |
zenkuro | rosmaita: \>_</ huray! =) | 14:22 |
venkatakrishnat | Hi core reviewers, Waiting for workflow +2 for the patch https://review.opendev.org/c/openstack/cinder/+/786524 which is to manage Global mirror change volumes on separate storage pools on IBM SVC cinder driver. | 14:55 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Improve quota usage for temporary resources https://review.opendev.org/c/openstack/cinder/+/786385 | 15:25 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Expose volume & snapshot use_quota field https://review.opendev.org/c/openstack/cinder/+/786386 | 15:25 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: RBD: Don't flatten temporary resources https://review.opendev.org/c/openstack/cinder/+/790492 | 15:25 |
whoami-rajat | geguileo, sorry I'm late with the second part of review, but i think we need the nit changes in releasenote https://review.opendev.org/c/openstack/cinder/+/786385/ | 15:58 |
rosmaita | geguileo: question for you on https://review.opendev.org/c/openstack/cinder/+/786385/10/cinder/db/sqlalchemy/models.py#762 | 15:59 |
rosmaita | whoami-rajat: i completely missed the incorrect tense in the release note | 16:01 |
whoami-rajat | rosmaita, i also wouldn't have caught that after reviewing 25 files, that's why i broke down the review in 2 parts :P | 16:02 |
*** akekane_ is now known as abhishekk | 16:18 | |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Improve quota usage for temporary resources https://review.opendev.org/c/openstack/cinder/+/786385 | 17:04 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Expose volume & snapshot use_quota field https://review.opendev.org/c/openstack/cinder/+/786386 | 17:04 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: RBD: Don't flatten temporary resources https://review.opendev.org/c/openstack/cinder/+/790492 | 17:04 |
sfernand | zenkuro: I've just added a few comments to your patch | 17:25 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: WIP Try regular delete for snapshot or deferred deletion https://review.opendev.org/c/openstack/cinder/+/805887 | 17:25 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement user visible extra specs https://review.opendev.org/c/openstack/cinder/+/806260 | 18:02 |
amar___ | jungleboyj: rosmaita: Addressed all your comments https://review.opendev.org/c/openstack/cinder/+/790910 really need it get merged in xena, CI is also green | 18:09 |
opendevreview | Andrei proposed openstack/cinder master: JovianDSS: fix iscsi target recovery function https://review.opendev.org/c/openstack/cinder/+/806191 | 18:13 |
opendevreview | Eric Harney proposed openstack/devstack-plugin-ceph master: Initialize RBD pool https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/806264 | 19:26 |
sfernand | amar___: I've just added a few comments to you patch but there is only a single point that made me give a -1. It is actually a question and I'm may be wrong since I'm making a lot of assumptions in drivers code. So if I'm wrong just tell and I drop the -1 | 19:56 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement user visible extra specs https://review.opendev.org/c/openstack/cinder/+/806260 | 20:41 |
opendevreview | Merged openstack/cinder master: Fix notifications of migration temp volume https://review.opendev.org/c/openstack/cinder/+/786383 | 21:58 |
*** dviroel|ruck is now known as dviroel|out | 22:18 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!