| opendevreview | Keigo Noha proposed openstack/cinder stable/wallaby: Add libcgroup related packages in bindep.txt https://review.opendev.org/c/openstack/cinder/+/801236 | 00:22 |
|---|---|---|
| -opendevstatus- NOTICE: The maintenance of the review.opendev.org Gerrit service is now complete and service has been restored. Please alert us in #opendev if you have any issues. Thank you | 03:26 | |
| opendevreview | Girish Chilukuri proposed openstack/cinder master: [SVF]:Fix multiple lshost calls during attach. https://review.opendev.org/c/openstack/cinder/+/772623 | 07:02 |
| *** akekane_ is now known as abhishekk | 07:07 | |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Doc: api-ref doc update https://review.opendev.org/c/openstack/cinder/+/793386 | 08:43 |
| zoharm | Hi geguileo and all! | 10:02 |
| zoharm | I would like to double check if it is ok to move nvmeof connector "replicated+" methods into os_brick/privileged/nvmeof.py - replacing self._execute() with rootwrap.custom_execute() - as part of upcoming "addition of nvmeof agent" review that I will submit? | 10:02 |
| geguileo | zoharm: sorry, I'm a bit out of touch with that. Why is there a need to move the methods? | 10:04 |
| zoharm | geguileo: for the nvmeof agent (a console script) to be able to import and use them | 10:05 |
| geguileo | zoharm: but is that new code or existing code? why can't the script import the code if it's not there? | 10:06 |
| zoharm | geguileo: those methods do "self._execute()" which requires a "self" object first param with a "_execute" method which i could not figure out how to do from the console script in an "openstack way" | 10:08 |
| zoharm | other users of os-brick are openstack services which pass the correct object | 10:09 |
| zoharm | the methods i want to move are the "new" nvmeof code from the last cycle | 10:10 |
| zoharm | the code i added back then with all your help :) | 10:11 |
| geguileo | is all that code privileged? | 10:11 |
| zoharm | i will only move the priviliged code | 10:11 |
| zoharm | all the nvmeof stuff that needs to be accessed by the connector or agent is priviliged | 10:12 |
| geguileo | zoharm: moving it sounds reasonable to me | 10:14 |
| geguileo | thanks for the clarification | 10:14 |
| zoharm | geguileo: thank you! all those methods only do "self._execute()" (only priviliged) which just ends up doing the rootwrap thing anyway. additionally, i would like to treat those "sub" methods as a library, and leave only the "top level API" of the connector (ie. connect/disconnect/extend) | 10:18 |
| zoharm | so it cleans up a lot for me too, i got the inspiration from your /etc/nvme/hostnqn fix :) | 10:18 |
| walshh_ | Hi all, could someone take a look at https://review.opendev.org/c/openstack/cinder/+/778907 when they get a chance. Its a small change with clean CI. Thank you | 15:14 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Fix for renaming GVG https://review.opendev.org/c/openstack/cinder/+/801354 | 16:36 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Remove 'db_driver' option https://review.opendev.org/c/openstack/cinder/+/800695 | 16:49 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Remove 'db' argument from various managers https://review.opendev.org/c/openstack/cinder/+/800696 | 16:49 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: WIP: db: Remove 'self.db' from most code paths https://review.opendev.org/c/openstack/cinder/+/800697 | 16:49 |
| simondodsley | Can I get a +2 and +W for https://review.opendev.org/c/openstack/cinder/+/798672 | 18:14 |
| simondodsley | I'm also looking for some +2s on https://review.opendev.org/c/openstack/cinder/+/798879 | 18:14 |
| opendevreview | Merged openstack/cinder master: [Pure Storage] Fix CG cloning crash when very long volume names https://review.opendev.org/c/openstack/cinder/+/801065 | 19:40 |
| opendevreview | Simon Dodsley proposed openstack/cinder stable/wallaby: [Pure Storage] Fix CG cloning crash when very long volume names https://review.opendev.org/c/openstack/cinder/+/801321 | 19:54 |
| rosmaita | simondodsley: left a question for you on https://review.opendev.org/c/openstack/cinder/+/798879 | 21:22 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!