| *** bhagyashris|ruck is now known as bhagyashris|out | 05:53 | |
| opendevreview | Merged openstack/cinder master: NetApp ONTAP: Fix QoS lost after moving volume https://review.opendev.org/c/openstack/cinder/+/766296 | 12:42 |
|---|---|---|
| opendevreview | Luigi Toscano proposed openstack/cinder stable/wallaby: NetApp ONTAP: Fix QoS lost after moving volume https://review.opendev.org/c/openstack/cinder/+/800220 | 12:44 |
| opendevreview | Luigi Toscano proposed openstack/cinder stable/victoria: NetApp ONTAP: Fix QoS lost after moving volume https://review.opendev.org/c/openstack/cinder/+/800228 | 13:14 |
| opendevreview | Luigi Toscano proposed openstack/cinder stable/ussuri: NetApp ONTAP: Fix QoS lost after moving volume https://review.opendev.org/c/openstack/cinder/+/800229 | 13:15 |
| opendevreview | Luigi Toscano proposed openstack/cinder stable/train: NetApp ONTAP: Fix QoS lost after moving volume https://review.opendev.org/c/openstack/cinder/+/800231 | 13:17 |
| hemna | eharney are you around? | 13:17 |
| eharney | hemna: yes | 13:17 |
| hemna | can you explain this line https://review.opendev.org/c/openstack/cinder/+/788363/5/cinder/image/cache.py#36 | 13:17 |
| hemna | I am not sure I understand the typing there | 13:17 |
| opendevreview | Merged openstack/cinder master: Move require_driver_initialized / log_unsupp to volume_utils https://review.opendev.org/c/openstack/cinder/+/775250 | 13:18 |
| hemna | looks like a string literal but the string value is pointing to an object? | 13:19 |
| tosky | geguileo: backported your QoS/NetApp fixes, hopefully the conflict resultion was right | 13:19 |
| hemna | I wrote a simple py script that mimicks that thinking it would fail unless I passed in that object, but it doesn't | 13:20 |
| hemna | so I don't understand the typing | 13:20 |
| geguileo | tosky: I wrote the patch 7 months ago... I'll probably have a hard time remembering how it all worked lol | 13:20 |
| hemna | http://paste.openstack.org/show/807334/ | 13:21 |
| tosky | geguileo: I hope netapp people will chime in too | 13:21 |
| geguileo | tosky: I'll add sfernand to the reviewers | 13:22 |
| eharney | hemna: looking | 13:22 |
| tosky | geguileo: oh, right, thanks | 13:22 |
| eharney | hemna: so the string pointing to a type is a way to refer to a class if mypy etc can't successfully scan the file yet (cinder.volume.api) -- but it looks like here just using the class directly works now so i'd rather change it to not be the string reference | 13:28 |
| eharney | hemna: i'm not sure i follow your test script, it won't do anything at run time, it will check when you run mypy on it | 13:28 |
| hemna | ok, so it will only validate if you run mypy on the code, never at runtime | 13:29 |
| eharney | right | 13:30 |
| hemna | for some reason I thought it was enforced at runtime as well | 13:30 |
| hemna | so is the idea then that we create a ci job that runs mypy after this is all in place ? | 13:30 |
| eharney | yes, we already have an experimental job https://review.opendev.org/c/openstack/cinder/+/736857 | 13:32 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: image cache https://review.opendev.org/c/openstack/cinder/+/788363 | 13:34 |
| opendevreview | Merged openstack/cinder master: mypy: image_utils https://review.opendev.org/c/openstack/cinder/+/774286 | 13:36 |
| hemna | eharney ok thanks for the clarification. I didn't want to -1 the patch as I didn't understand it, but I think your update looks better. | 13:47 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: create_volume flows https://review.opendev.org/c/openstack/cinder/+/780933 | 13:56 |
| opendevreview | Merged openstack/os-brick master: zuul: add mypy experimental job https://review.opendev.org/c/openstack/os-brick/+/786881 | 14:19 |
| opendevreview | Eric Harney proposed openstack/cinder stable/wallaby: Abort volume creation when encryption spec is invalid https://review.opendev.org/c/openstack/cinder/+/800268 | 14:37 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: create_volume flows https://review.opendev.org/c/openstack/cinder/+/780933 | 14:57 |
| opendevreview | Merged openstack/cinder master: Abort volume creation when encryption spec is invalid https://review.opendev.org/c/openstack/cinder/+/789602 | 15:00 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Reject bad img formats for uploaded encrypted vols https://review.opendev.org/c/openstack/cinder/+/800272 | 15:12 |
| rosmaita | hemna: if you have a minute, i left a response on https://review.opendev.org/c/openstack/cinder/+/792299 | 15:57 |
| hemna | ok let me check | 16:11 |
| hemna | ok cool thanks for the remarks. | 16:12 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Run cinder-mypy job in the check https://review.opendev.org/c/openstack/cinder/+/792642 | 17:20 |
| *** melwitt is now known as Guest322 | 17:31 | |
| *** melwitt_ is now known as melwitt | 17:57 | |
| *** melwitt is now known as jgwentworth | 17:58 | |
| *** TheJulia is now known as needssleep | 18:04 | |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Reject bad img formats for uploaded encrypted vols https://review.opendev.org/c/openstack/cinder/+/800272 | 18:55 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Add installation of mypy stubs packages https://review.opendev.org/c/openstack/cinder/+/800306 | 20:02 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Run cinder-mypy job in the check https://review.opendev.org/c/openstack/cinder/+/792642 | 20:05 |
| opendevreview | Andrei proposed openstack/cinder master: Open-E JovianDSS: Addes multi-attach support https://review.opendev.org/c/openstack/cinder/+/794962 | 21:31 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!