Monday, 2021-03-08

*** zzzeek has quit IRC00:17
*** zzzeek has joined #openstack-cinder00:18
*** enriquetaso has joined #openstack-cinder00:27
*** tosky has quit IRC00:42
*** ricolin has quit IRC00:46
*** ricolin has joined #openstack-cinder00:50
*** benj_ has joined #openstack-cinder00:54
*** benj_ has quit IRC01:01
*** benj_ has joined #openstack-cinder01:02
*** rcernin has quit IRC01:12
*** rcernin_ has joined #openstack-cinder01:12
*** carloss has quit IRC01:17
*** benj_ has quit IRC01:17
*** benj_ has joined #openstack-cinder01:17
*** zenkuro has quit IRC01:40
*** rratnaka has joined #openstack-cinder02:05
*** benj_ has quit IRC02:06
*** benj_ has joined #openstack-cinder02:07
*** zzzeek has quit IRC02:44
*** enriquetaso has quit IRC02:45
*** zzzeek has joined #openstack-cinder02:47
*** vishalmanchanda has joined #openstack-cinder03:00
*** caiqilong has joined #openstack-cinder03:02
*** zzzeek has quit IRC03:10
*** zzzeek has joined #openstack-cinder03:12
*** rratnaka has quit IRC03:13
*** rcernin_ has quit IRC03:14
openstackgerritAlan Bishop proposed openstack/python-cinderclient master: Bump API max version  https://review.opendev.org/c/openstack/python-cinderclient/+/77123603:17
*** rcernin_ has joined #openstack-cinder03:21
*** psachin has joined #openstack-cinder03:41
*** rratnaka has joined #openstack-cinder03:59
*** zzzeek has quit IRC04:02
*** zzzeek has joined #openstack-cinder04:04
*** caiqilong has quit IRC04:33
*** udesale has joined #openstack-cinder04:34
*** GirishChilukuri has joined #openstack-cinder04:37
*** ajitha has joined #openstack-cinder05:26
*** zzzeek has quit IRC05:26
*** zzzeek has joined #openstack-cinder05:29
*** zzzeek has quit IRC06:03
*** zzzeek has joined #openstack-cinder06:05
openstackgerritOpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/cinder/+/77682206:13
*** venkatakrishnath has joined #openstack-cinder06:35
*** m75abrams has joined #openstack-cinder06:36
*** rcernin_ has quit IRC07:14
*** lpetrut has joined #openstack-cinder07:24
*** fnordahl has joined #openstack-cinder07:39
*** GirishChilukuri has quit IRC07:53
*** rratnaka has quit IRC07:54
*** GirishChilukuri has joined #openstack-cinder08:00
*** rpittau|afk is now known as rpittau08:23
*** whoami-rajat_ has joined #openstack-cinder08:26
*** rratnaka has joined #openstack-cinder08:32
*** tosky has joined #openstack-cinder08:34
*** brinzhang has joined #openstack-cinder08:34
*** ircuser-1 has joined #openstack-cinder08:35
*** brinzhang0 has quit IRC08:36
*** martinkennelly has joined #openstack-cinder08:50
*** udesale has quit IRC08:57
openstackgerritOpenStack Release Bot proposed openstack/os-brick stable/wallaby: Update .gitreview for stable/wallaby  https://review.opendev.org/c/openstack/os-brick/+/77918309:18
openstackgerritOpenStack Release Bot proposed openstack/os-brick stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby  https://review.opendev.org/c/openstack/os-brick/+/77918409:18
openstackgerritOpenStack Release Bot proposed openstack/os-brick master: Update master for stable/wallaby  https://review.opendev.org/c/openstack/os-brick/+/77918509:18
openstackgerritOpenStack Release Bot proposed openstack/os-brick master: Add Python3 xena unit tests  https://review.opendev.org/c/openstack/os-brick/+/77918609:18
*** nautik has joined #openstack-cinder09:19
openstackgerritGirish Chilukuri proposed openstack/cinder stable/train: [SVF]:Fix clone fcmap not being deleted in cleanup  https://review.opendev.org/c/openstack/cinder/+/77914109:23
openstackgerritLuigi Toscano proposed openstack/cinder-tempest-plugin master: Ceph jobs: re-enable a few c-bak tests, add more jobs  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77776609:26
*** ociuhandu has joined #openstack-cinder09:27
*** venkatakrishnath has quit IRC09:29
*** Luzi has joined #openstack-cinder09:31
*** udesale has joined #openstack-cinder09:31
*** ociuhandu has quit IRC09:44
*** ociuhandu has joined #openstack-cinder09:44
*** ociuhandu has quit IRC09:50
*** ociuhandu has joined #openstack-cinder09:51
openstackgerritRajat Dhasmana proposed openstack/cinder master: Support format info in fs type drivers  https://review.opendev.org/c/openstack/cinder/+/76115209:52
*** venkatakrishnath has joined #openstack-cinder09:55
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add project validation to volume type access  https://review.opendev.org/c/openstack/cinder/+/77757409:56
openstackgerritGirish Chilukuri proposed openstack/cinder master: [SVF]:Bulk create Hyperswap volume is failing.  https://review.opendev.org/c/openstack/cinder/+/77919410:05
*** caiqilong has joined #openstack-cinder10:05
*** carloss has joined #openstack-cinder10:56
*** ociuhandu has quit IRC11:04
*** ociuhandu has joined #openstack-cinder11:06
*** ociuhandu has quit IRC11:10
*** venkatakrishnath has quit IRC11:32
*** ociuhandu has joined #openstack-cinder11:36
*** rratnaka has quit IRC11:39
*** ociuhandu has quit IRC11:47
*** ociuhandu has joined #openstack-cinder11:56
*** ociuhandu has quit IRC11:56
*** ociuhandu has joined #openstack-cinder11:58
*** ociuhandu has quit IRC11:58
openstackgerritGirish Chilukuri proposed openstack/cinder stable/train: [SVF]:Fix clone fcmap not being deleted in cleanup  https://review.opendev.org/c/openstack/cinder/+/77914111:58
*** ociuhandu has joined #openstack-cinder11:58
*** ociuhandu has quit IRC11:58
*** ociuhandu has joined #openstack-cinder12:00
openstackgerritkiran pawar proposed openstack/cinder master: Parallelize the cinder backup process.  https://review.opendev.org/c/openstack/cinder/+/77923312:02
*** ociuhandu has quit IRC12:06
*** ociuhandu has joined #openstack-cinder12:13
*** ociuhandu has quit IRC12:22
*** enriquetaso has joined #openstack-cinder12:26
*** rosmaita has quit IRC12:39
*** lpetrut has quit IRC12:44
*** ociuhandu has joined #openstack-cinder12:52
*** rosmaita has joined #openstack-cinder12:53
*** ociuhandu has quit IRC12:56
ajitha@corereviewers: Please review this patch https://review.opendev.org/c/openstack/cinder/+/77888613:02
*** lpetrut has joined #openstack-cinder13:09
*** psachin has quit IRC13:10
*** manoj_katari has joined #openstack-cinder13:19
*** __ministry1 has joined #openstack-cinder13:26
*** ociuhandu has joined #openstack-cinder13:29
*** zoharm has joined #openstack-cinder13:33
*** ociuhandu has quit IRC13:34
*** rratnaka has joined #openstack-cinder13:35
hemnagood morning13:36
*** ociuhandu has joined #openstack-cinder13:39
GirishChilukuri@core reviewers,13:41
GirishChilukuriPlease review this changes, these are minor changes waiting for +2 approvals from long time.13:41
GirishChilukurihttps://review.opendev.org/c/openstack/cinder/+/75313413:41
GirishChilukurihttps://review.opendev.org/c/openstack/cinder/+/77178313:41
GirishChilukurihttps://review.opendev.org/c/openstack/cinder/+/76506013:41
*** sfernand has joined #openstack-cinder13:56
*** mnaser has joined #openstack-cinder14:03
openstackgerritEric Harney proposed openstack/python-cinderclient master: Remove more python2 compat code  https://review.opendev.org/c/openstack/python-cinderclient/+/77927014:07
*** __ministry1 has quit IRC14:16
*** venkatakrishnath has joined #openstack-cinder14:17
venkatakrishnath@corereviewers, please review the following patches about IBM Storwize SVC driver targeting W-Release.14:18
venkatakrishnathhttps://review.opendev.org/c/openstack/cinder/+/75019914:18
venkatakrishnathhttps://review.opendev.org/c/openstack/cinder/+/76515414:18
openstackgerritLee Yarwood proposed openstack/devstack-plugin-ceph master: nova: Make configure_ceph_nova multinode compatible  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/75632314:26
openstackgerritLee Yarwood proposed openstack/devstack-plugin-ceph master: zuul: Introduce a multinode ceph job  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/71162514:26
openstackgerritLee Yarwood proposed openstack/devstack-plugin-ceph master: tempest: Use a more appropriate name for the skip list  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/77090614:27
*** venkatakrishnath has quit IRC14:27
*** jv_ has quit IRC14:30
hemnacan someone refresh my memory on the difference between provider_id, provider_location ?14:35
hemnaare those only used in reference to volume replication ?14:35
*** jv_ has joined #openstack-cinder14:42
*** Luzi has quit IRC14:49
openstackgerritGirish Chilukuri proposed openstack/cinder master: [Storwize]: Volume name is not validated for host  https://review.opendev.org/c/openstack/cinder/+/75313414:54
openstackgerritJonCui proposed openstack/cinder master: Fix incorrect percentage for volume-backup progress notification  https://review.opendev.org/c/openstack/cinder/+/77927914:57
*** manoj_katari has quit IRC15:01
*** zzzeek has quit IRC15:19
*** zzzeek has joined #openstack-cinder15:21
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - RDF checks  https://review.opendev.org/c/openstack/cinder/+/76810515:25
*** GirishChilukuri has quit IRC15:26
*** lpetrut has quit IRC15:32
*** udesale has quit IRC15:33
*** ociuhandu has quit IRC15:37
*** ociuhandu has joined #openstack-cinder15:37
*** ociuhandu has quit IRC15:43
*** ociuhandu has joined #openstack-cinder15:47
*** ociuhandu has quit IRC15:47
*** ociuhandu has joined #openstack-cinder15:48
*** m75abrams has quit IRC15:50
openstackgerritJonCui proposed openstack/cinder master: Fix incorrect percentage for volume-backup progress notification  https://review.opendev.org/c/openstack/cinder/+/77927915:52
*** ociuhandu has quit IRC15:53
*** ociuhandu has joined #openstack-cinder15:54
*** rratnaka has quit IRC15:54
*** TusharTgite has joined #openstack-cinder15:58
*** gmann is now known as gmann_afk16:01
openstackgerritMerged openstack/python-cinderclient master: Remove all usage of six library  https://review.opendev.org/c/openstack/python-cinderclient/+/75516416:03
*** ajitha has quit IRC16:15
openstackgerritEric Harney proposed openstack/python-cinderclient master: Add flake8-import-order extension  https://review.opendev.org/c/openstack/python-cinderclient/+/73301416:15
*** zoharm has quit IRC16:24
openstackgerritEric Harney proposed openstack/cinder master: mypy: image_utils  https://review.opendev.org/c/openstack/cinder/+/77428616:24
TusharTgite@core reviewers: Please review below code changes, which needs +2 approvals. Got Verified +1 from Zuul and Code-Review +116:31
TusharTgitehttps://review.opendev.org/c/openstack/os-brick/+/77584016:31
TusharTgitehttps://review.opendev.org/c/openstack/python-cinderclient/+/77157116:32
TusharTgitehttps://review.opendev.org/c/openstack/cinderlib/+/77156916:32
TusharTgitehttps://review.opendev.org/c/openstack/cinderlib/+/77488216:32
TusharTgitehttps://review.opendev.org/c/openstack/cinderlib/+/77583916:32
TusharTgitehttps://review.opendev.org/c/openstack/cinder/+/77157216:32
TusharTgitehttps://review.opendev.org/c/openstack/cinder/+/77533116:32
TusharTgitehttps://review.opendev.org/c/openstack/cinder/+/77583116:32
openstackgerritEric Harney proposed openstack/cinder master: Bump mypy to 0.800  https://review.opendev.org/c/openstack/cinder/+/77428716:41
*** ajitha has joined #openstack-cinder16:41
eharneyi'm looking at our api-ref doc a bit and have a question or two16:48
eharneythis says creating a volume takes a volume object as a request parameter16:48
eharneyhttps://docs.openstack.org/api-ref/block-storage/v3/index.html#create-a-volume16:48
eharneysame thing in creating a snapshot:16:48
eharneyhttps://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=create-a-snapshot-detail#create-a-snapshot16:48
eharneywhy is a volume/snapshot object a request parameter?  am i missing something here?16:48
eharneydoes "object" just mean "json dict with all the other parameters inside of it"?16:49
*** TusharTgite has quit IRC16:50
eharneyi guess listing that as the second item in the table w/ all the other fields is just kind of odd looking16:51
eharneyyet, the volume transfer API shows an "accept" object in the request example but doesn't list one in the table16:54
rosmaitaeharney: yes, it's talking about a JSON object (technically, JSON doesn't have a dictionary data type)16:55
rosmaitai think it's a limitation of the api-ref syntax that makes it hard to talk about the individual fields of the json object16:56
rosmaitathe example is supposed to help you figure it out16:56
rosmaitabut i agree that it could be improved16:57
eharneyso i think the transfer API should have an entry added for "accept"16:57
eharneyalso, i found one API (backup create) that documents "500 - Internal Server Error" as a return code... surely we shouldn't have that in the api-ref?16:57
rosmaitamaybe we expect it to happen a lot ?  :P16:57
eharneyunless we return that on purpose?16:58
eharneyin which case the api-ref should probably explain why16:58
rosmaitai think you are probably right about the transfer API accept call16:59
rosmaitaand i also think you are right that we need to review the return codes ... the 5xx shouldn't have to be listed, they're always possible (unless it's some kind of weird case)17:01
rosmaitai suspect it's a matter of multiple people working on the api-ref17:01
rosmaitaso some inconsistencies slip in17:02
openstackgerritLee Yarwood proposed openstack/devstack-plugin-ceph master: zuul: Introduce a multinode ceph job  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/71162517:03
openstackgerritLee Yarwood proposed openstack/devstack-plugin-ceph master: tempest: Use a more appropriate name for the skip list  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/77090617:03
openstackgerritEric Harney proposed openstack/cinder master: api-ref: Fix "id" parameter  https://review.opendev.org/c/openstack/cinder/+/77930517:10
openstackgerritEric Harney proposed openstack/cinder master: api-ref: Fix "id" parameter  https://review.opendev.org/c/openstack/cinder/+/77930517:10
*** hamalq has joined #openstack-cinder17:29
hamalqhi review https://review.opendev.org/c/openstack/cinder/+/77876817:30
*** rratnaka has joined #openstack-cinder17:35
openstackgerritVenkata krishna Thumu proposed openstack/cinder master: [SVF] Set volume IOPS based on volume size  https://review.opendev.org/c/openstack/cinder/+/76480417:35
*** manoj_katari has joined #openstack-cinder17:40
*** rratnaka has quit IRC18:01
rm_workHey all, we would love to get the mTLS client fix into a release soon -- I know the client freeze is upon us and I'm guessing releases will be going out shortly, so reviews would be very appreciated! I can confirm it does fix our issues when applied locally. https://review.opendev.org/c/openstack/python-cinderclient/+/77631118:15
*** rpittau is now known as rpittau|afk18:16
*** ociuhandu has quit IRC18:20
*** ociuhandu has joined #openstack-cinder18:22
*** ociuhandu has quit IRC18:27
*** ociuhandu has joined #openstack-cinder18:51
*** manoj_katari has quit IRC18:53
*** ociuhandu has quit IRC18:56
*** zenkuro has joined #openstack-cinder19:07
*** stand has quit IRC19:15
*** stand has joined #openstack-cinder19:22
*** ociuhandu has joined #openstack-cinder19:30
*** gmann_afk is now known as gmann19:32
*** ociuhandu has quit IRC19:43
*** whoami-rajat_ is now known as whoami-rajat19:44
*** zenkuro has quit IRC20:12
*** zenkuro has joined #openstack-cinder20:12
lbragstado/ hey folks - i'm looking for some documentation on https://github.com/openstack/cinder/blob/master/cinder/policies/volumes.py#L16820:43
lbragstadis that in the API reference somewhere?20:44
lbragstadi see a bunch of docs for the encryption_type bits, but nothing for getting the encryption key for a specific volume20:44
eharneylbragstad: as of https://review.opendev.org/c/openstack/cinder/+/771081 the encryption_key_id is shown in the volume details20:47
*** vishalmanchanda has quit IRC20:47
eharneybefore that it would be shown as part of the connection info when creating volume attachments  (since it's needed to attach a volume)20:47
lbragstadeharney ok - cool20:51
lbragstadi noticed the tempest volume client doesn't have an implementation for getting a volumes encryption metadata20:52
*** ociuhandu has joined #openstack-cinder20:53
lbragstadso i threw this into my local copy of tempest http://paste.openstack.org/raw/803358/20:53
lbragstadand that seems work work, assuming {'encryption_key_id': None} is a valid response in that case (my volume isn't encrypted and i'm just trying to test "volume_extension:volume_encryption_metadata"20:54
eharneyyes, it's None for volumes that aren't encrypted20:55
lbragstadok - good deal20:56
lbragstadand https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_encryption_metadata.py#L32-L33 looks like the only place it's used20:57
eharneyi'm unsure about your show_volume_encryption() code there20:57
lbragstadso any encryption metadata in /volumes/{volume_id}/detail would be the same as what's available through that API?20:57
eharney /volumes/{volume_id}/detail will only have the key id20:58
lbragstadok - so any additional encryption metadata needs to come out of the volume/{volume_id}/encryption endpoint?20:59
eharneyi'm not sure what comes out of there tbh20:59
lbragstadencrypted volumes return this20:59
lbragstad{'encryption_key_id': None}21:00
eharneyunencrypted volumes, you mean?21:00
lbragstadyes- sorry21:00
lbragstadunencrypted* volumes21:00
eharneyright21:01
*** ociuhandu has quit IRC21:01
lbragstadlooks like devstack deploys a conf key manager with a fixed key21:06
eharneyi think so, unless you enable the barbican devstack plugin21:06
lbragstadlooks like i need to create a new volume types to create an encrypted volume21:06
eharneyyes, or at least an encrypted type on top of an existing volume type21:06
lbragstadok - let me see if i can do that quick - i image the jsonschema for volume encryption metadata has a lot more properties when the volume is encrypted21:07
lbragstadimagine*21:07
eharneywell i didn't realize that this was even here, but there should 4 or 5 properties21:07
eharneyi'm not entirely sure what this is useful for or why we have it21:08
lbragstadok - i do see some of those properties in the volume detail response21:09
lbragstadso i wonder if they are just duplicated for a separate endpoint21:09
lbragstadi started looking at this deeper because i noticed cinder has a separate policy for controlling access to that endpoint (but the policy value isn't different from GET /volumes/{volume_id})21:10
lbragstadso - i'm wondering if there is a usecase for enforcing a separate non-default policy for encryption metadata over just regular volume metadata/properties21:11
eharneythe volume detail response just has the key_id right?21:12
lbragstadlet me check quick21:13
lbragstadso - based on what i have setup locally, volumes just return an encrypted attribute, which is a boolean21:15
eharneyoh, the patch to let python-cinderclient support a new enough microversion (3.64) to show the key hasn't landed yet21:16
lbragstadah...21:16
eharneymakes sense21:16
lbragstadi'm testing with the tempest clients, so i assume we'll need a similar patch there21:16
eharneybut to your question, i'm not too sure if there is a good use case for that21:17
lbragstada good use case for a separate API endpoint for volume encryption metadata, or a separate policy for access to the endpoint (or both?)21:17
eharneyboth / either21:18
* lbragstad nods21:18
lbragstadok21:18
lbragstadwell - i'll just write a relatively straight-forward test then21:18
openstackgerritLance Bragstad proposed openstack/cinder master: trivial: Fix note indendataion in volume-encryption docs  https://review.opendev.org/c/openstack/cinder/+/77936721:26
openstackgerritLance Bragstad proposed openstack/cinder master: trivial: Fix note indentation in volume-encryption docs  https://review.opendev.org/c/openstack/cinder/+/77936721:27
lbragstadthanks for the hand eharney21:33
eharneysure!21:33
*** enriquetaso has quit IRC21:51
*** rcernin has joined #openstack-cinder21:54
*** sfernand has quit IRC21:56
*** ociuhandu has joined #openstack-cinder22:01
*** ociuhandu has quit IRC22:06
*** whoami-rajat has quit IRC22:06
*** zenkuro has quit IRC22:08
*** zenkuro has joined #openstack-cinder22:09
*** ajitha has quit IRC22:35
*** ociuhandu has joined #openstack-cinder22:38
*** ociuhandu has quit IRC22:44
lbragstadeharney do you know if the volume type encryption API has gone through any significant changes with microversions? i'm not seeing any here https://docs.openstack.org/cinder/rocky/contributor/api_microversion_history.html22:52
lbragstadbut i'm just double checking because this is what i get http://paste.openstack.org/raw/803361/ when i create a new encrypted volume type22:53
lbragstadand the volume_type_id there is actually the id of the encrypted volume type reference, right?22:54
eharneyi think it hasn't really changed22:54
lbragstadi'm wondering what the difference is between that ID and encryption_id22:54
eharneyyes22:54
lbragstadhttps://docs.openstack.org/api-ref/block-storage/v3/index.html22:55
eharneyhmmm22:55
lbragstadi have two cleanup steps in my test to clean up the volume type and the encrypted volume type, but cinder consistently gives me a 400 saying the VolumeType is still i nuse22:56
lbragstadin use*22:56
eharneyso encryption_id is the id of the encryption type in the cinder.encryption table vs. the volume type that it's attached to22:57
* lbragstad nods22:57
lbragstadso - when i clean up the encrypted volume type, which one should i use? the volume_type_id?22:57
eharneyyes, the volume type id22:58
lbragstadstrange... that's what i'm using23:00
lbragstadi must have my order of operations mixed up somewhere23:00
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: WIP: Additional volume protection tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77938323:02
eharneyis it trying to delete the types while the volume still exists?23:03
lbragstadoh - potentially23:04
lbragstadlet me add some waiters there23:04
lbragstadgah - yeah, good call eharney23:08
*** zzzeek has quit IRC23:08
*** zzzeek has joined #openstack-cinder23:12
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77835723:17
lbragstadeharney cleaned up and reproposed in ^ thanks!23:18
eharneyawesome23:20
*** martinkennelly has quit IRC23:21
*** martinkennelly has joined #openstack-cinder23:23
toskylbragstad: about https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915 - have you seen my comment about adding a skip in the base test class if enforce_scope.cinder is not defined?23:26
lbragstadyeah - we can do that23:27
toskyotherwise the RBAC tests are executed on all jobs which cinder-tempest-plugin23:28
lbragstadyeah - i don't have a problem skipping the tests by default and just running them in a single job23:28
lbragstadi added it as an explicit comment23:31
*** ociuhandu has joined #openstack-cinder23:54
*** ociuhandu has quit IRC23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!