| openstackgerrit | Merged openstack/cinder master: PowerMax Driver - Extend replicated volume https://review.opendev.org/c/openstack/cinder/+/767172 | 00:02 |
|---|---|---|
| *** tosky has quit IRC | 00:11 | |
| *** yoctozepto has quit IRC | 00:13 | |
| *** yoctozepto has joined #openstack-cinder | 00:13 | |
| *** hamalq has quit IRC | 00:26 | |
| *** carloss has quit IRC | 00:48 | |
| *** ajitha has joined #openstack-cinder | 00:51 | |
| *** brinzhang0 has joined #openstack-cinder | 00:54 | |
| *** brinzhang_ has quit IRC | 00:57 | |
| *** amar7ibm_ has quit IRC | 01:24 | |
| *** rratnaka has joined #openstack-cinder | 01:31 | |
| *** rratnaka14 has joined #openstack-cinder | 01:37 | |
| *** rratnaka has quit IRC | 01:41 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 01:43 | |
| openstackgerrit | Merged openstack/os-brick master: Move os-brick to new hacking 4.0.0 https://review.opendev.org/c/openstack/os-brick/+/774883 | 01:44 |
| *** knomura has joined #openstack-cinder | 01:47 | |
| *** masterpe has quit IRC | 01:48 | |
| *** knomura has quit IRC | 01:48 | |
| *** knomura has joined #openstack-cinder | 01:49 | |
| *** knomura has quit IRC | 02:01 | |
| *** caiqilong has joined #openstack-cinder | 02:03 | |
| openstackgerrit | Brian Rosmaita proposed openstack/os-brick master: Update requirements for wallaby release https://review.opendev.org/c/openstack/os-brick/+/778807 | 02:04 |
| *** rratnaka14 has quit IRC | 02:07 | |
| *** masterpe has joined #openstack-cinder | 02:20 | |
| *** zenkuro has quit IRC | 02:23 | |
| *** enriquetaso has quit IRC | 02:25 | |
| *** enriquetaso has joined #openstack-cinder | 02:25 | |
| *** rratnaka14 has joined #openstack-cinder | 02:38 | |
| openstackgerrit | Brian Rosmaita proposed openstack/os-brick master: Add release note for nvmeof connector https://review.opendev.org/c/openstack/os-brick/+/778810 | 02:38 |
| *** martinkennelly has quit IRC | 02:42 | |
| *** irclogbot_0 has quit IRC | 02:52 | |
| *** rratnaka has joined #openstack-cinder | 02:53 | |
| *** irclogbot_2 has joined #openstack-cinder | 02:54 | |
| *** rratnaka14 has quit IRC | 02:55 | |
| *** ircuser-1 has quit IRC | 03:11 | |
| *** psachin has joined #openstack-cinder | 03:36 | |
| *** ircuser-1 has joined #openstack-cinder | 03:51 | |
| *** enriquetaso has quit IRC | 04:06 | |
| *** enriquetaso has joined #openstack-cinder | 04:07 | |
| *** knomura has joined #openstack-cinder | 04:13 | |
| *** knomura has quit IRC | 04:18 | |
| *** venkatakrishnath has joined #openstack-cinder | 04:20 | |
| *** ircuser-1 has quit IRC | 04:24 | |
| *** ircuser-1 has joined #openstack-cinder | 04:28 | |
| *** enriquetaso has quit IRC | 04:36 | |
| *** dviroel has quit IRC | 05:10 | |
| *** sfernand has quit IRC | 05:20 | |
| openstackgerrit | Merged openstack/cinder master: Update secure RBAC check strings with descriptions https://review.opendev.org/c/openstack/cinder/+/763195 | 05:29 |
| openstackgerrit | Merged openstack/cinder master: Properly handle InvalidScope exceptions https://review.opendev.org/c/openstack/cinder/+/775931 | 05:30 |
| *** dsariel has joined #openstack-cinder | 05:43 | |
| *** udesale has joined #openstack-cinder | 05:55 | |
| *** rcernin has quit IRC | 06:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/776822 | 06:09 |
| *** rratnaka14 has joined #openstack-cinder | 06:18 | |
| *** venkatakrishnath has quit IRC | 06:18 | |
| *** rratnaka has quit IRC | 06:21 | |
| *** vishalmanchanda has joined #openstack-cinder | 06:24 | |
| *** felipe_rodrigues has quit IRC | 06:25 | |
| *** manoj_katari has joined #openstack-cinder | 06:26 | |
| *** knomura has joined #openstack-cinder | 07:14 | |
| *** knomura has quit IRC | 07:18 | |
| *** e0ne has joined #openstack-cinder | 07:32 | |
| *** e0ne has quit IRC | 07:42 | |
| *** zzzeek has quit IRC | 07:52 | |
| *** zzzeek has joined #openstack-cinder | 07:53 | |
| *** lpetrut has joined #openstack-cinder | 08:00 | |
| *** zzzeek has quit IRC | 08:08 | |
| *** zzzeek has joined #openstack-cinder | 08:09 | |
| openstackgerrit | Merged openstack/cinder master: [SVF] Update volume replication properties https://review.opendev.org/c/openstack/cinder/+/771563 | 08:09 |
| GirishChilukuri_ | @core reviewers: Please review this changes, These are minor changes and waiting for +2 from long time. | 08:16 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/753134 | 08:16 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/771783 | 08:16 |
| GirishChilukuri_ | https://review.opendev.org/c/openstack/cinder/+/765060 | 08:16 |
| *** rpittau|afk is now known as rpittau | 08:21 | |
| *** zzzeek has quit IRC | 08:40 | |
| *** zzzeek has joined #openstack-cinder | 08:41 | |
| *** zzzeek has quit IRC | 08:42 | |
| *** zzzeek has joined #openstack-cinder | 08:43 | |
| *** ociuhandu has joined #openstack-cinder | 08:44 | |
| *** rratnaka has joined #openstack-cinder | 08:46 | |
| *** rratnaka14 has quit IRC | 08:49 | |
| *** venkatakrishnath has joined #openstack-cinder | 09:21 | |
| *** tosky has joined #openstack-cinder | 09:23 | |
| *** Underknowledge has quit IRC | 09:48 | |
| *** Underknowledge1 has joined #openstack-cinder | 09:49 | |
| *** Underknowledge1 is now known as Underknowledge | 09:49 | |
| *** rratnaka14 has joined #openstack-cinder | 10:11 | |
| *** rratnaka has quit IRC | 10:14 | |
| *** venkatakrishnath has quit IRC | 10:17 | |
| *** zoharm has joined #openstack-cinder | 10:17 | |
| *** dviroel has joined #openstack-cinder | 10:18 | |
| zoharm | geguileo hi and thank you for the review! do you have a moment to discuss some of your comments here in irc? | 10:19 |
| geguileo | zoharm: sure :-) | 10:19 |
| zoharm | regarding dead code, the reason it is there is: | 10:19 |
| zoharm | it follows the new connector spec, whereas with the old+new connector merge, the old (non volume_replicas) follows a different API spec | 10:20 |
| zoharm | so, yes that dead code never gets hit, but it is in line with the spec, which is funny but could be useful in in later changes | 10:20 |
| zoharm | i can definitely remove it | 10:21 |
| zoharm | even throughout the connector (including other such cases) | 10:21 |
| zoharm | but i think it will also cause a bigger change overall given the current state, which is ok, but maybe better avoidable due to the "spec difference" reason described above | 10:22 |
| geguileo | zoharm: but when would that be hit in the future? considering that we are executing the old code for that | 10:22 |
| zoharm | if we work with SPDK driver (which I believe is only consumer of the connector) and propose a new unified spec (which may also solve some issues of old connector) | 10:23 |
| geguileo | I don't remember the spec, but it should be about the connector itself, not a specific method, right? | 10:23 |
| zoharm | the spec is about the connection information | 10:23 |
| zoharm | the old connector expects different dict than the new, and we decide to use the new based on a key in the dict | 10:24 |
| geguileo | but backward compatibility won't go away | 10:24 |
| zoharm | i see your point | 10:24 |
| geguileo | mmmmm, now that I think about it | 10:25 |
| zoharm | ok, then the preference is to reduce code now while keeping backaward compat indefinitely | 10:25 |
| zoharm | or is it? | 10:25 |
| geguileo | it won't go away on disconnect, but on connect it could go away... | 10:25 |
| zoharm | hmmm | 10:26 |
| geguileo | zoharm: in my experience we tend to have code in Cinder that stays there for years without being used | 10:26 |
| geguileo | and when looking at the code to figure out things it makes it harder to understand | 10:26 |
| geguileo | so in general I'm against adding code that doesn't have a plan to be used | 10:27 |
| geguileo | if there's a plan (even if that plan never happens) I'm ok keeping the code | 10:27 |
| zoharm | there is a plan, the only issue is backward compat for SPDK driver as you brought up | 10:28 |
| openstackgerrit | pcaruana proposed openstack/cinder stable/victoria: PowerMax Driver - Fix assign SRP during promotion retype https://review.opendev.org/c/openstack/cinder/+/778877 | 10:29 |
| zoharm | ok, we can get back to deciding on this, i can always remove that code when needed | 10:30 |
| zoharm | regarding those small cosmetic changes, is it not ok to keep them? i can of course revert them | 10:31 |
| geguileo | zoharm: one question, why can't your _connect_volume_replicated be used with the SPDK driver? | 10:32 |
| zoharm | the only core reason is that the new connector requires a volume uuid to identify the volume | 10:33 |
| geguileo | oh, I missed that | 10:33 |
| zoharm | SPDK only passes a target and assumes only one device per target | 10:33 |
| geguileo | then shouldn't we select your connect method based on that? | 10:34 |
| zoharm | and it still has a bit of concurrency issues :) | 10:34 |
| zoharm | that is a great idea | 10:34 |
| geguileo | in that case your code could keep that dead code I'm saying now | 10:34 |
| geguileo | and it would allow without changing the connector to support SPDK using it | 10:34 |
| geguileo | right? | 10:34 |
| zoharm | yes | 10:35 |
| zoharm | its basically the same thing as now but better :) | 10:35 |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Refactor: move project validation to api_utils https://review.opendev.org/c/openstack/cinder/+/752431 | 10:35 |
| zoharm | i was hoping to have the day off today, but gonna try this out now haha | 10:35 |
| geguileo | zoharm: ok, if you use that as the decider I'm ok keeping that code | 10:36 |
| zoharm | geguileo thank you! | 10:36 |
| geguileo | zoharm: sorry about your day off :-( | 10:36 |
| zoharm | im just joking around ;) | 10:36 |
| zoharm | geguileo also regarding the mkdir comment, thank you for that catch! what do you think i should use there? -m 600 ? | 10:42 |
| zoharm | oops 666 i think for read write by all | 10:44 |
| geguileo | zoharm: in that case we wound't be able to chdir into it | 10:45 |
| zoharm | so 777 | 10:46 |
| geguileo | zoharm: honestly, I would create it with 755 and then do the writing in a privsep method | 10:46 |
| geguileo | or change the method itself to be executed in privsep | 10:46 |
| geguileo | and then the writing won't have any problems | 10:47 |
| zoharm | geguileo thank you for that, i still dont understand how to use privsep mode differently than the self._execute() | 10:47 |
| zoharm | also, why is privsep not baked into connector_class._execute() ? | 10:47 |
| geguileo | zoharm: the _execute code ends up calling os_brick.privileged.rootwrap.execute (iirc) | 10:48 |
| zoharm | i think considering how many different execute calls there are in this connector, maybe i should do a thorough privsep change passthrough in a followup patch | 10:48 |
| geguileo | and that's the one that does the privsep thingy if it's a root call | 10:48 |
| zoharm | oh, well i think i saw the word privsep in the logs while connector methods were executing | 10:49 |
| geguileo | zoharm: yeah, I was not suggesting changing everything now, I was just saying that that was an option to solve the writing issue on that method | 10:49 |
| zoharm | im just not that aware of it especially implementation-wise | 10:49 |
| zoharm | so currently _execute() does not do privsep? (in that case, i hope doing 777 mode is ok until the whole privsep migration patch) | 10:50 |
| geguileo | zoharm: _execute does privsep when asked to do root | 10:50 |
| zoharm | then it does privsep in that case | 10:51 |
| geguileo | zoharm: but it creates a subprocess, which is more expensive than just running the python code | 10:51 |
| zoharm | geguileo ok i think im understanding your point about that specific code, the writing is not done in privsep (it just uses open) | 10:51 |
| geguileo | so _execute('cat somethin') is more expensive than running a python method in privsep that opens the file and reads it | 10:52 |
| zoharm | i see | 10:52 |
| geguileo | zoharm: exactly | 10:52 |
| zoharm | so what is better for now, 777 or change the open to a _execute('cat')? | 10:52 |
| geguileo | and I don't know what restrictions are set on the parent directory | 10:52 |
| geguileo | even if we create it with 777, what if it already exists? | 10:53 |
| zoharm | and also the writing should be _execute(['echo', var, '>', 'filename']) ? | 10:53 |
| geguileo | zoharm: that's a quick/dirty option, yes | 10:53 |
| zoharm | im not sure either, this will vary from system to system | 10:53 |
| geguileo | zoharm: if you do it that way, please add a todo to move that to privsep | 10:53 |
| zoharm | ok, so i will add -m 777 for now, and add a todo comment saying "change open() calls to use privsep" - ok? | 10:54 |
| geguileo | zoharm: mmmm, I thin it's more secure to do 755 and do the echo and then set the file permissions to 644 | 10:56 |
| geguileo | now that I think about it, forget the last setting of permissions | 10:57 |
| geguileo | mmmmm, no we cannot forget it :-( because the echo creates it as root and we wouldn't be able to read it | 10:57 |
| zoharm | sounds good, im going through the comments now and replying, then will start working on the code changes | 10:57 |
| geguileo | so directory 755 and file 644 | 10:58 |
| zoharm | but we not doing echo yet right? | 10:58 |
| zoharm | keeping open() as non-privsep | 10:58 |
| geguileo | doing echo | 10:58 |
| zoharm | and add todo to make it privsep (ie. use cat and echo) | 10:58 |
| zoharm | ok | 10:58 |
| geguileo | no, no | 10:58 |
| geguileo | the read with open | 10:58 |
| geguileo | the write with echo and then setting permissions to 644 | 10:59 |
| geguileo | that way anyone can read it | 10:59 |
| *** udesale has quit IRC | 10:59 | |
| zoharm | ok | 10:59 |
| geguileo | if I understand correctly what we are writing there is not sensitive info, right? | 10:59 |
| *** udesale has joined #openstack-cinder | 10:59 | |
| geguileo | it's like the iscsi initiator name | 10:59 |
| geguileo | people can read it, we just don't want non-admins changing it | 10:59 |
| zoharm | btw can you do all shell syntax like: _execute(['cmd1', 'arg', '&&', 'cmd2', 'arg']) ? | 11:00 |
| zoharm | yep its exactly the iqn | 11:00 |
| zoharm | for host (iscsi client) | 11:00 |
| geguileo | zoharm: you should be able to do && if you pass shell=True, right? | 11:01 |
| geguileo | oh, forget that | 11:01 |
| geguileo | we can't pass shell=True | 11:02 |
| zoharm | ok, so can't use '&&' or ';' ? | 11:03 |
| zoharm | also one more question, you have a comment asking to use self.method() instead of CLASSNAME.method() for static methods (reason for why they static methods is because of assumptions of nvmeof agent using it, for now we just keep those that are static) | 11:05 |
| zoharm | now, this behavior of using CLASSNAME.method() is all over the new connector code | 11:05 |
| zoharm | i think i may as well just go through it all now right? rather than just change that one case? | 11:05 |
| zoharm | or can that be left to a later patch to minimize shock levels on this one haha | 11:06 |
| geguileo | if it's all over the connector then leave it as it is | 11:06 |
| zoharm | thank you | 11:06 |
| geguileo | just reply to my comment with "it's consistent with the connector code" | 11:06 |
| zoharm | ok last thing, there is this small cosmetic change that crept in, it is better practice to revert it? | 11:06 |
| geguileo | I don't like it, but it's acceptable to leave it consistent | 11:06 |
| geguileo | you mean the line break and moving the arguments of a call to the next line? | 11:07 |
| zoharm | yep | 11:07 |
| geguileo | if that's the case then I added that as a nit, so it's optional | 11:07 |
| geguileo | in general I downvote those because they may break other existing patches | 11:08 |
| zoharm | ok, will keep it this way, it helped me read some important better so i hope it will be helpful for others | 11:08 |
| zoharm | good point | 11:08 |
| geguileo | but since there is not much work besides what you are doing on that specific connector I assume it won't mess anybody else's patch | 11:08 |
| zoharm | i suppose not too many people are patching nvmeof connector so i hope we are safe :) | 11:09 |
| geguileo | and I don't think it will create merge conflicts with backport or anything | 11:09 |
| zoharm | submitting comments now, and then starting on code | 11:09 |
| geguileo | thanks | 11:09 |
| *** e0ne has joined #openstack-cinder | 11:15 | |
| *** jv_ has quit IRC | 11:15 | |
| *** ociuhandu has quit IRC | 11:16 | |
| *** ociuhandu has joined #openstack-cinder | 11:17 | |
| *** ociuhandu has quit IRC | 11:17 | |
| *** ociuhandu has joined #openstack-cinder | 11:18 | |
| zoharm | geguileo: one more quick thing regarding reading/writing in /etc/nvme/ - if we are converting the open() write to echo, then may as well just convert the open() read to cat too? | 11:19 |
| geguileo | zoharm: no. I'm ok for now doing the write with echo because, even if it's expensive, we only do it once | 11:21 |
| geguileo | zoharm: the read happens on every connection | 11:22 |
| geguileo | so we want to keep it as cheap as possible | 11:22 |
| geguileo | that's why we have to set the file to 644 | 11:22 |
| zoharm | interesting, the reason i proposed this is that on a system where /etc/nvme already exists and is not accessible to os-brick service user | 11:22 |
| *** rratnaka has joined #openstack-cinder | 11:23 | |
| zoharm | if we are the ones always creating /etc/nvme and writing to it then that wont be necessary as you explained | 11:23 |
| *** carloss has joined #openstack-cinder | 11:23 | |
| zoharm | i think we just did not hit the case of /etc/nvme exist and not accessible by openstack yet, that is why its this way :) but im not sure if preemptively "fixing" this while potentially breaking/shocking things is worth it, it was really just a thought, so i will leave it this way for now | 11:24 |
| *** rratnaka14 has quit IRC | 11:24 | |
| zoharm | thank you for the input! | 11:24 |
| zoharm | geguileo: ok this is really last thing i think: will using | in _execute() work? (i want to reduce and simplify the execute calls by doing: nvme gen-hostnqn | tee /etc/nvme/hostnqn) | 11:27 |
| *** ociuhandu has quit IRC | 11:29 | |
| openstackgerrit | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Set volume IOPS based on volume size https://review.opendev.org/c/openstack/cinder/+/764804 | 11:30 |
| *** ociuhandu has joined #openstack-cinder | 11:31 | |
| geguileo | zoharm: you can try, but I think it won't | 11:31 |
| zoharm | interesting, but > should work? | 11:31 |
| zoharm | (because > is needed for the echo) | 11:32 |
| geguileo | now that I think about it, I think | may work | 11:35 |
| geguileo | zoharm: but you should just try | 11:36 |
| openstackgerrit | ajitha proposed openstack/cinder master: Add support for consistency groups in the Nimble Storage iSCSI drivers https://review.opendev.org/c/openstack/cinder/+/778886 | 11:39 |
| openstackgerrit | Zohar Mamedov proposed openstack/os-brick master: NVMeOF connector driver connection information compatibility fix https://review.opendev.org/c/openstack/os-brick/+/777086 | 11:47 |
| zoharm | ok, it seems to work on my testing setup, but it does not cover all cases of missing/existing /etc/nvme with different permissions | 11:48 |
| zoharm | i uploaded the patch and going to run kioxia CI on it and wait for SPDK CI result too | 11:48 |
| *** enriquetaso has joined #openstack-cinder | 11:52 | |
| zoharm | quick a quick note, the whole volume_alias thing is legacy as far as i am concerned, i think a better way is to simply reuse (and if necessary do a hash) of vol_uuid | 11:52 |
| *** caiqilong has quit IRC | 11:53 | |
| zoharm | that is why vol_alias is not in the new spec while vol_uuid is | 11:53 |
| *** ociuhandu has quit IRC | 11:54 | |
| *** e0ne has quit IRC | 11:54 | |
| *** ociuhandu has joined #openstack-cinder | 11:56 | |
| *** ociuhandu has quit IRC | 12:00 | |
| *** venkatakrishnath has joined #openstack-cinder | 12:08 | |
| *** knomura has joined #openstack-cinder | 12:08 | |
| *** felipe_rodrigues has joined #openstack-cinder | 12:10 | |
| *** knomura has quit IRC | 12:12 | |
| *** e0ne has joined #openstack-cinder | 12:17 | |
| *** zenkuro has joined #openstack-cinder | 12:24 | |
| *** tkajinam has quit IRC | 12:35 | |
| *** tkajinam has joined #openstack-cinder | 12:35 | |
| *** GirishChilukuri has joined #openstack-cinder | 12:36 | |
| *** GirishChilukuri_ has quit IRC | 12:39 | |
| *** zenkuro has quit IRC | 12:49 | |
| *** zenkuro has joined #openstack-cinder | 12:49 | |
| GirishChilukuri | @core reviewers: Please review this changes, These are minor changes and waiting for +2 from long time. | 12:50 |
| GirishChilukuri | https://review.opendev.org/c/openstack/cinder/+/753134 | 12:50 |
| GirishChilukuri | https://review.opendev.org/c/openstack/cinder/+/771783 | 12:50 |
| GirishChilukuri | https://review.opendev.org/c/openstack/cinder/+/765060 | 12:50 |
| *** venkatakrishnath has quit IRC | 12:54 | |
| *** whoami-rajat has joined #openstack-cinder | 12:58 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Fix for legacy PowerMax OS around generations https://review.opendev.org/c/openstack/cinder/+/778907 | 12:58 |
| whoami-rajat | zoharm: hey, did you see my comments on the review? would be great if you could update (if required) before zuul passes to save time | 12:59 |
| zoharm | whoami-rajat: yes, thank you! i just responded, please take a look and see if you still think changes are necessary? | 12:59 |
| *** ociuhandu has joined #openstack-cinder | 13:06 | |
| *** manoj_katari has quit IRC | 13:22 | |
| openstackgerrit | Zohar Mamedov proposed openstack/os-brick master: NVMeOF connector driver connection information compatibility fix https://review.opendev.org/c/openstack/os-brick/+/777086 | 13:23 |
| *** ociuhandu has quit IRC | 13:26 | |
| *** ociuhandu has joined #openstack-cinder | 13:26 | |
| *** ociuhandu has quit IRC | 13:31 | |
| *** e0ne has quit IRC | 13:33 | |
| *** e0ne has joined #openstack-cinder | 13:39 | |
| rosmaita | zoharm: can you rebase that patch on master? you are about 10 commits behind, and it would be good to make sure there are no surprises when we try to merge later | 13:40 |
| openstackgerrit | Lee Yarwood proposed openstack/devstack-plugin-ceph master: nova: Make configure_ceph_nova multinode compatible https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/756323 | 13:41 |
| openstackgerrit | Lee Yarwood proposed openstack/devstack-plugin-ceph master: zuul: Introduce a multinode ceph job https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/711625 | 13:41 |
| openstackgerrit | Lee Yarwood proposed openstack/devstack-plugin-ceph master: tempest: Use a more appropriate name for the skip list https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/770906 | 13:41 |
| rosmaita | zoharm: while you're at it, feel free to steal the release note from https://review.opendev.org/c/openstack/os-brick/+/778810 and include it in your patch, and i'll abandon mine | 13:44 |
| whoami-rajat | zoharm: ah, since it's the original code i don't have further concerns | 13:50 |
| *** zenkuro has quit IRC | 13:56 | |
| *** zenkuro has joined #openstack-cinder | 13:57 | |
| *** e0ne has quit IRC | 14:06 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Fix for deleting replication group https://review.opendev.org/c/openstack/cinder/+/778930 | 14:11 |
| *** e0ne has joined #openstack-cinder | 14:14 | |
| rosmaita | tkajinam: what time zone are you in? | 14:14 |
| *** ociuhandu has joined #openstack-cinder | 14:16 | |
| zoharm | rosmaita whoami-rajat thank you, apologies for the late reply, im back on for a bit | 14:20 |
| zoharm | ok, so, rebase patch and copy over release note, thats it, right? | 14:20 |
| rosmaita | zoharm: np, sorry to bother you on your day off | 14:20 |
| rosmaita | exactly | 14:20 |
| rosmaita | that way it will all be together, and also we can make sure none of the prior merged changes will cause a conflict later | 14:21 |
| zoharm | ok, working on it | 14:21 |
| openstackgerrit | Zohar Mamedov proposed openstack/os-brick master: NVMeOF connector driver connection information compatibility fix https://review.opendev.org/c/openstack/os-brick/+/777086 | 14:23 |
| openstackgerrit | Zohar Mamedov proposed openstack/os-brick master: NVMeOF connector driver connection information compatibility fix https://review.opendev.org/c/openstack/os-brick/+/777086 | 14:25 |
| zoharm | i think it is done, latest changes should not affect Kioxia CI so as long as SPDK CI is passing i think we are good for merge on this | 14:28 |
| *** ociuhandu has quit IRC | 14:33 | |
| *** zenkuro has quit IRC | 14:35 | |
| *** zenkuro has joined #openstack-cinder | 14:36 | |
| *** e0ne has quit IRC | 14:38 | |
| *** ociuhandu has joined #openstack-cinder | 14:39 | |
| rosmaita | ty | 14:43 |
| *** smekala has joined #openstack-cinder | 14:51 | |
| *** smekala has quit IRC | 14:56 | |
| *** lpetrut has quit IRC | 15:03 | |
| *** rpittau is now known as rpittau|afk | 15:03 | |
| whoami-rajat | rosmaita: can you take another look at the victoria release patch? i did an update with Herve's comments https://review.opendev.org/c/openstack/releases/+/778231 | 15:10 |
| rosmaita | ok | 15:10 |
| whoami-rajat | also, if you get some free time, take a look at ussuri open patches, all of them have a +2 https://etherpad.opendev.org/p/stable-releases-review-tracker-22-02-2021 | 15:13 |
| rosmaita | whoami-rajat: +1 -- thanks for staying on top of it | 15:13 |
| rosmaita | ack | 15:13 |
| whoami-rajat | thank you! | 15:13 |
| openstackgerrit | Simon Dodsley proposed openstack/cinder master: [Pure] Add missing FC host personality support https://review.opendev.org/c/openstack/cinder/+/775948 | 15:14 |
| openstackgerrit | Eric Harney proposed openstack/devstack-plugin-ceph master: Set rbd default features in ceph.conf https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/778960 | 15:15 |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Refactor: move project validation to api_utils https://review.opendev.org/c/openstack/cinder/+/752431 | 15:19 |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder stable/ussuri: NetApp SolidFire: Fix duplicate volume when API response is lost https://review.opendev.org/c/openstack/cinder/+/764274 | 15:22 |
| openstackgerrit | Luigi Toscano proposed openstack/cinder-tempest-plugin master: WIP Revert "Skip a few c-bak tests broken by the new ceph" https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/777766 | 15:24 |
| *** ociuhandu has quit IRC | 15:29 | |
| *** ociuhandu has joined #openstack-cinder | 15:33 | |
| *** ociuhandu has quit IRC | 15:36 | |
| *** ociuhandu has joined #openstack-cinder | 15:36 | |
| *** rratnaka14 has joined #openstack-cinder | 15:39 | |
| *** rratnaka has quit IRC | 15:40 | |
| *** udesale has quit IRC | 15:43 | |
| *** venkatakrishnath has joined #openstack-cinder | 15:53 | |
| venkatakrishnath | Hi Rajat, modified UT based on your comments for https://review.opendev.org/c/openstack/cinder/+/750199. Could you please review. | 15:54 |
| openstackgerrit | Merged openstack/os-brick master: Update requirements for wallaby release https://review.opendev.org/c/openstack/os-brick/+/778807 | 15:56 |
| *** jv_ has joined #openstack-cinder | 15:57 | |
| *** zoharm has quit IRC | 15:58 | |
| openstackgerrit | Luigi Toscano proposed openstack/devstack-plugin-ceph master: Stable jobs: run the tests on victoria, remove stein https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/778981 | 16:08 |
| openstackgerrit | pcaruana proposed openstack/cinder stable/victoria: Add ports filtering support to Dell EMC XtremIO driver https://review.opendev.org/c/openstack/cinder/+/778982 | 16:10 |
| openstackgerrit | Luigi Toscano proposed openstack/cinder-tempest-plugin master: DNM test ceph on CentOS 8 https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/729766 | 16:16 |
| *** psachin has quit IRC | 16:17 | |
| *** ociuhandu has quit IRC | 16:29 | |
| *** ociuhandu has joined #openstack-cinder | 16:32 | |
| *** ociuhandu has quit IRC | 16:36 | |
| *** ociuhandu has joined #openstack-cinder | 16:42 | |
| *** rratnaka14 has quit IRC | 17:01 | |
| openstackgerrit | Merged openstack/os-brick stable/ussuri: ScaleIO: More connection info backward compatibility https://review.opendev.org/c/openstack/os-brick/+/778224 | 17:12 |
| *** smekala has joined #openstack-cinder | 17:31 | |
| *** smekala has left #openstack-cinder | 17:31 | |
| *** rratnaka14 has joined #openstack-cinder | 17:38 | |
| *** ociuhandu_ has joined #openstack-cinder | 17:39 | |
| *** ociuhandu_ has quit IRC | 17:40 | |
| *** ociuhandu has quit IRC | 17:40 | |
| *** ociuhandu has joined #openstack-cinder | 17:41 | |
| *** rratnaka14 has quit IRC | 17:42 | |
| *** GirishChilukuri has quit IRC | 17:43 | |
| *** jawad_axd has joined #openstack-cinder | 17:50 | |
| openstackgerrit | Merged openstack/cinder stable/ussuri: [SVF]:Fix clone fcmap not being deleted in cleanup https://review.opendev.org/c/openstack/cinder/+/767334 | 17:55 |
| *** irclogbot_2 has quit IRC | 18:03 | |
| *** venkatakrishnath has quit IRC | 18:04 | |
| *** irclogbot_3 has joined #openstack-cinder | 18:04 | |
| *** irclogbot_3 has quit IRC | 18:24 | |
| *** irclogbot_3 has joined #openstack-cinder | 18:27 | |
| *** ociuhandu has quit IRC | 18:42 | |
| openstackgerrit | Sri Harsha mekala proposed openstack/python-cinderclient master: Support passing client certificates for server version requests https://review.opendev.org/c/openstack/python-cinderclient/+/776311 | 18:42 |
| *** jawad_axd has quit IRC | 18:44 | |
| openstackgerrit | Merged openstack/devstack-plugin-ceph master: Update ceph default version to octopus https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/777232 | 18:51 |
| *** ociuhandu has joined #openstack-cinder | 18:54 | |
| *** ociuhandu has quit IRC | 18:58 | |
| openstackgerrit | Sri Harsha mekala proposed openstack/python-cinderclient master: Support passing client certificates for server version requests https://review.opendev.org/c/openstack/python-cinderclient/+/776311 | 19:03 |
| *** jawad_axd has joined #openstack-cinder | 19:05 | |
| *** rratnaka has joined #openstack-cinder | 19:06 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder stable/train: Correct group:reset_group_snapshot_status policy https://review.opendev.org/c/openstack/cinder/+/778998 | 19:09 |
| *** elod has quit IRC | 19:12 | |
| *** takamatsu has quit IRC | 19:13 | |
| *** elod has joined #openstack-cinder | 19:13 | |
| openstackgerrit | Sri Harsha mekala proposed openstack/python-cinderclient master: Support passing client certificates for mTLS connections https://review.opendev.org/c/openstack/python-cinderclient/+/776311 | 19:14 |
| *** takamatsu has joined #openstack-cinder | 19:27 | |
| *** rratnaka has quit IRC | 19:36 | |
| *** rratnaka has joined #openstack-cinder | 19:39 | |
| rratnaka | Hi guys.. Could you please have a look at https://review.opendev.org/c/openstack/cinder/+/774463 and provide review comments? | 19:42 |
| rratnaka | Would like to have feedback on the changes. Thanks | 19:45 |
| *** jv_ has quit IRC | 19:46 | |
| *** jv_ has joined #openstack-cinder | 19:46 | |
| *** rratnaka has quit IRC | 19:49 | |
| *** jawad_axd has quit IRC | 19:52 | |
| *** jawad_axd has joined #openstack-cinder | 19:57 | |
| openstackgerrit | Ivan Pchelintsev proposed openstack/cinder master: Add OpenStack volume replication v2.1 support in PowerStore driver https://review.opendev.org/c/openstack/cinder/+/773854 | 20:12 |
| openstackgerrit | Ivan Pchelintsev proposed openstack/cinder master: Add OpenStack volume replication v2.1 support in PowerStore driver https://review.opendev.org/c/openstack/cinder/+/773854 | 20:39 |
| *** jv_ has quit IRC | 20:46 | |
| *** jawad_axd has quit IRC | 20:55 | |
| *** hoonetorg has quit IRC | 20:57 | |
| *** jv_ has joined #openstack-cinder | 21:01 | |
| *** hoonetorg has joined #openstack-cinder | 21:01 | |
| *** hamalq has joined #openstack-cinder | 21:14 | |
| openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Implement basic protection testing jobs https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915 | 21:15 |
| openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357 | 21:15 |
| *** jawad_axd has joined #openstack-cinder | 21:17 | |
| *** ajitha has quit IRC | 21:18 | |
| *** jawad_axd has quit IRC | 21:31 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix: Extend fails after blockRebase https://review.opendev.org/c/openstack/cinder/+/763181 | 21:42 |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Support format info in fs type drivers https://review.opendev.org/c/openstack/cinder/+/761152 | 21:42 |
| *** dsariel has quit IRC | 21:45 | |
| openstackgerrit | Eric Harney proposed openstack/cinder master: WIP: LVM: retry lvs command in get_lv_info https://review.opendev.org/c/openstack/cinder/+/779053 | 21:50 |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Refactor: move project validation to api_utils https://review.opendev.org/c/openstack/cinder/+/752431 | 22:02 |
| openstackgerrit | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Implement FlexGroup pool https://review.opendev.org/c/openstack/cinder/+/776713 | 22:07 |
| openstackgerrit | Eric Harney proposed openstack/python-cinderclient master: Add flake8-import-order extension https://review.opendev.org/c/openstack/python-cinderclient/+/733014 | 22:08 |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix: show volume by name for non-admins https://review.opendev.org/c/openstack/cinder/+/778373 | 22:09 |
| openstackgerrit | Merged openstack/os-brick master: Avoid unhandled exceptions during connecting to iSCSI portals https://review.opendev.org/c/openstack/os-brick/+/775545 | 22:29 |
| openstackgerrit | Merged openstack/os-brick master: NVMeOF connector driver connection information compatibility fix https://review.opendev.org/c/openstack/os-brick/+/777086 | 23:14 |
| *** elod has quit IRC | 23:25 | |
| openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357 | 23:32 |
| *** hamalq has quit IRC | 23:44 | |
| openstackgerrit | Luigi Toscano proposed openstack/cinder stable/stein: [stable-only] Set IPv6 params to fix tempest-slow-py3 https://review.opendev.org/c/openstack/cinder/+/778476 | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!