Wednesday, 2021-03-03

*** enriquetaso has quit IRC00:07
*** whoami-rajat has quit IRC00:15
*** enriquetaso has joined #openstack-cinder00:16
*** johanssone has quit IRC00:16
*** tosky has quit IRC00:17
*** johanssone has joined #openstack-cinder00:19
*** martinkennelly has quit IRC00:50
*** Underknowledge has quit IRC01:08
*** Underknowledge has joined #openstack-cinder01:08
*** Underknowledge2 has joined #openstack-cinder01:51
*** Underknowledge has quit IRC01:54
*** Underknowledge2 is now known as Underknowledge01:54
*** rcernin has quit IRC02:00
*** enriquetaso has quit IRC02:05
*** rratnaka has joined #openstack-cinder02:11
*** rratnaka14 has joined #openstack-cinder02:16
*** rratnaka has quit IRC02:20
*** hamalq has quit IRC02:25
*** rcernin has joined #openstack-cinder02:29
*** rcernin has quit IRC02:29
*** enriquetaso has joined #openstack-cinder02:30
*** rcernin has joined #openstack-cinder02:30
*** rratnaka14 has quit IRC02:33
*** Underknowledge has quit IRC02:38
*** Xuchu_ has joined #openstack-cinder02:43
*** rcernin has quit IRC02:44
*** Xuchu has quit IRC02:46
*** rcernin has joined #openstack-cinder03:16
*** dasp has quit IRC03:34
*** rratnaka has joined #openstack-cinder03:35
*** enriquetaso has quit IRC03:37
*** dasp has joined #openstack-cinder03:45
*** psachin has joined #openstack-cinder03:50
*** caiqilong has quit IRC03:53
*** GirishChilukuri has joined #openstack-cinder04:04
*** venkatakrishnath has joined #openstack-cinder04:13
*** zzzeek has quit IRC04:17
*** zzzeek has joined #openstack-cinder04:17
*** GirishChilukuri has quit IRC04:18
*** zzzeek has quit IRC04:22
*** GirishChilukuri has joined #openstack-cinder04:23
*** zzzeek has joined #openstack-cinder04:23
*** rratnaka14 has joined #openstack-cinder04:35
*** udesale has joined #openstack-cinder04:35
*** rratnaka has quit IRC04:38
*** dviroel has quit IRC04:55
openstackgerritMerged openstack/os-brick stable/ussuri: FC: Fix not flushing on detach  https://review.opendev.org/c/openstack/os-brick/+/77740804:56
*** whoami-rajat has joined #openstack-cinder04:58
*** vishalmanchanda has joined #openstack-cinder05:27
*** m75abrams has joined #openstack-cinder05:35
openstackgerritGirish Chilukuri proposed openstack/cinder stable/ussuri: [SVF]:Fix clone fcmap not being deleted in cleanup  https://review.opendev.org/c/openstack/cinder/+/76733405:36
*** brinzhang has joined #openstack-cinder05:41
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Implement basic protection testing jobs  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77291505:43
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Implement protection testing for capabilities API  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77589405:43
openstackgerritLance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77835705:43
lbragstadrosmaita ^ those are some example protection tests using the volumes API05:44
lbragstadit doesn't use the new default policies for project-member and project-reader, but you'll see that when the project-reader tests fail (since they're creating things)05:44
lbragstadif you pull that down and run in against https://review.opendev.org/c/openstack/cinder/+/760199 it should work05:45
lbragstadbut - i guess the test bits would follow that general pattern is that's what cinder wants to do05:46
lbragstadit's all using the tempest clients, so it should be relatively straight forward for folks to hop in and start writing some more tests05:47
lbragstadwhich would really help05:47
*** ajitha has joined #openstack-cinder05:48
*** zzzeek has quit IRC06:06
openstackgerritOpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/cinder/+/77682206:14
*** Xuchu_ has quit IRC06:22
*** Xuchu has joined #openstack-cinder06:22
*** rratnaka has joined #openstack-cinder06:35
*** rratnaka14 has quit IRC06:38
openstackgerritXuan Yandong proposed openstack/os-brick master: Remove six  https://review.opendev.org/c/openstack/os-brick/+/75459806:41
*** zzzeek has joined #openstack-cinder06:41
openstackgerritRajat Dhasmana proposed openstack/cinder master: Fix: show volume by name for non-admins  https://review.opendev.org/c/openstack/cinder/+/77837307:13
whoami-rajatfrickler:  ^^ , i thought it was being removed for all APIs at a later stage but those are some custom cases who do not support resource filtering07:15
*** rratnaka14 has joined #openstack-cinder07:34
*** rratnaka has quit IRC07:38
*** rratnaka has joined #openstack-cinder07:39
*** rratnaka14 has quit IRC07:39
*** rcernin has quit IRC07:44
*** rpittau|afk is now known as rpittau07:52
*** ociuhandu has joined #openstack-cinder08:13
fricklerwhoami-rajat: great, thx08:27
*** ociuhandu has quit IRC08:30
*** tosky has joined #openstack-cinder08:34
*** ociuhandu has joined #openstack-cinder08:35
*** jdillaman has quit IRC08:44
*** jdillaman has joined #openstack-cinder08:45
*** Underknowledge has joined #openstack-cinder09:11
*** venkatakrishnath has quit IRC09:11
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - Extend replicated volume  https://review.opendev.org/c/openstack/cinder/+/76717209:17
*** ociuhandu has quit IRC09:39
*** Xuchu has quit IRC09:43
*** ociuhandu has joined #openstack-cinder10:04
*** lpetrut has joined #openstack-cinder10:22
*** ociuhandu has quit IRC10:28
*** ociuhandu has joined #openstack-cinder10:37
*** carloss has joined #openstack-cinder10:49
*** dviroel has joined #openstack-cinder11:05
*** venkatakrishnath has joined #openstack-cinder11:09
*** whoami-rajat__ has joined #openstack-cinder11:11
*** zoharm has joined #openstack-cinder11:11
*** bhagyashris is now known as bhagyashris|rove11:30
*** bhagyashris|rove is now known as bhagyashri|rover11:30
*** ociuhandu has quit IRC11:41
openstackgerritXuan Yandong proposed openstack/cinder-specs master: Add xena directory for specs  https://review.opendev.org/c/openstack/cinder-specs/+/77843611:41
openstackgerritXuan Yandong proposed openstack/cinder-specs master: WIP Update original volume az  https://review.opendev.org/c/openstack/cinder-specs/+/77843711:43
*** dsariel has joined #openstack-cinder11:51
*** udesale_ has joined #openstack-cinder11:57
*** udesale has quit IRC12:00
*** legochen has quit IRC12:00
openstackgerritTakashi Kajinami proposed openstack/os-brick master: Avoid unhandled exceptions during connecting to iSCSI portals  https://review.opendev.org/c/openstack/os-brick/+/77554512:11
*** ociuhandu has joined #openstack-cinder12:12
openstackgerritMerged openstack/os-brick stable/train: Improve error handling on target query  https://review.opendev.org/c/openstack/os-brick/+/77740612:15
*** ociuhandu has quit IRC12:17
*** martinkennelly has joined #openstack-cinder12:18
openstackgerritLuigi Toscano proposed openstack/cinder-tempest-plugin master: WIP no cinderlib before train  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77844812:32
*** ociuhandu has joined #openstack-cinder12:37
*** legochen has joined #openstack-cinder12:38
*** legochen_ has joined #openstack-cinder12:42
*** legochen has quit IRC12:43
*** legochen_ is now known as legochen12:43
*** rratnaka has quit IRC12:48
*** psachin has quit IRC13:01
*** rratnaka has joined #openstack-cinder13:26
*** rratnaka14 has joined #openstack-cinder13:27
*** rratnaka has quit IRC13:31
*** e0ne has joined #openstack-cinder13:45
*** enriquetaso has joined #openstack-cinder13:50
*** amar7ibm_ has joined #openstack-cinder13:51
*** almir-okato has joined #openstack-cinder13:52
*** jv_ has quit IRC13:55
rosmaitaCourtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC13:56
rosmaitajungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso hemna atmark ^^13:56
geguileorosmaita: thanks :-)13:56
whoami-rajatthanks rosmaita13:57
jungleboyjMorning.13:57
*** ociuhandu has quit IRC13:58
*** ociuhandu has joined #openstack-cinder13:59
*** jv_ has joined #openstack-cinder14:00
openstackgerritZohar Mamedov proposed openstack/os-brick master: Add NVMeOF monitoring and healing agent  https://review.opendev.org/c/openstack/os-brick/+/76857614:00
*** thgcorrea has joined #openstack-cinder14:02
*** sfernand has joined #openstack-cinder14:04
*** ociuhandu has quit IRC14:04
*** ociuhandu has joined #openstack-cinder14:07
*** felipe_rodrigues has joined #openstack-cinder14:13
*** takamatsu has joined #openstack-cinder14:17
*** jdillaman has quit IRC14:18
*** jdillaman has joined #openstack-cinder14:18
openstackgerritEric Harney proposed openstack/os-brick master: Fix import order in exception.py  https://review.opendev.org/c/openstack/os-brick/+/77847014:25
*** ociuhandu has quit IRC14:27
*** ociuhandu has joined #openstack-cinder14:28
*** ociuhandu has quit IRC14:33
*** jv_ has quit IRC14:33
*** jv_ has joined #openstack-cinder14:34
*** ociuhandu has joined #openstack-cinder14:40
openstackgerritEric Harney proposed openstack/os-brick master: Fix import order of libraries  https://review.opendev.org/c/openstack/os-brick/+/77847014:40
openstackgerritLuigi Toscano proposed openstack/cinder stable/stein: WIP [stable-only] Set IPv6 params to fix tempest-slow-py3  https://review.opendev.org/c/openstack/cinder/+/77847614:44
*** zoharm has quit IRC14:47
whoami-rajatgeguileo: isn't that an bug with using multiple schedulers? should we have that data centralized or sync before requests, although I don't have much experience with cinder scheduler14:55
geguileowhoami-rajat: in an ideal world we would, but reality is that makes us have a dependency on an external service we don't have14:56
geguileowhoami-rajat: so each scheduler has different data and they sync when they receive reports from the backend14:57
*** zoharm has joined #openstack-cinder14:57
*** jv_ has quit IRC14:59
*** jdillaman has quit IRC15:00
whoami-rajatgeguileo: ah, makes sense15:01
* enriquetaso thinking15:01
geguileowhoami-rajat: it's not perfect, but it protects the system in a way ;-)15:01
eharneykeep in mind that bugs about "i scheduled 3 volumes and they didn't go where i'd like" are kind of tricky -- it's a lot more useful to think about what happens when scheduling 1000 of them instead15:02
toskyregarding that cinder-tempest-plugin item on the agenda, I just wanted to ask if there are any objections about tagging a new cinder-tempest-release (the change I've mentioned is on the way of being merged),15:05
toskyso please comment on the etherpad if you are for/against it and/or if you want to have specific changes included (but please note another tag won't be far away)15:06
rosmaitatosky: i think let's just propose the release and we can release again later15:06
rosmaitabecause if we don't the release team will anyway15:07
toskyI can do that as soon as that patch lands (which may take a while, there is a long queue in the gate job)15:07
*** jv_ has joined #openstack-cinder15:07
rosmaitatosky: ty, i'm not sure if cinder-tempest-plugin is in deliverables/wallaby or deliverables/independent, you may have to sort that out15:09
toskyI know that part :)15:09
*** lpetrut has quit IRC15:09
GirishChilukuriregarding: Run cinder tempest plugin in third party CI, This "https://review.opendev.org/c/openstack/cinder/+/773937" patch adds functionality for revert to snapshot for IBM driver but isn't running any revert to snapshot tests as they reside in cinder_tempest_plugin15:10
toskythen it should be nice to run them :)15:11
whoami-rajattosky: i left a question on the etherpad15:11
*** happyhemant has joined #openstack-cinder15:13
rosmaitawhoami-rajat: btw, i left some questions for the release team on your victoria releases patch, just not sure about some of the version numbers15:13
toskywhoami-rajat: answered there, but basically we can re-release anytime15:13
rosmaitabut everything else looked fine, thanks for proposing the patch15:13
whoami-rajatrosmaita: smcginnis  replied and I've updated the patch15:13
whoami-rajatunless you left few more comments just now15:14
rosmaitatosky: you pay the most attention out of all of us to tempest events (i.e., you have > 0 awareness), so i think we should do whatever you suggest15:14
rosmaitawhoami-rajat: thanks, i will look and +115:14
whoami-rajattosky: thanks15:14
enriquetasotosky++15:15
whoami-rajatno new comments after my update so it's good15:15
whoami-rajatrosmaita: thanks for adding the reply on my topic, i wasn't sure cinder-tempest-plugin is a hard requirement to run in CI but that patch for revert to snapshot feature should surely run it (since revert to snapshot tests exist in cinder-tempest-plugin)15:16
rosmaitayeah, i was looking for the statement about that for GirishChilukuri it's either in the all about driver page in cinder docs or the 3rd party ci stuff on the wiki15:17
rosmaitawe could probably use a doc update, the idea is that you should always run cinder-tempest-plugin, but you turn off the features you don't support as part of the tempest config15:17
whoami-rajatseems like the best approach, GirishChilukuri  ^15:18
*** rratnaka has joined #openstack-cinder15:21
*** rratnaka14 has quit IRC15:23
toskyyou need to explicitly enable revert to snapshot tests by setting a key in tempest.conf (volume-feature-enabled.volume-revert=True)15:24
rosmaitatosky: thanks, so i have it backwards: you have to turn ON the features that you DO support15:25
whoami-rajatoh yeah the defaults are false, although i mentioned on the review to turn it on so they should do it the right way15:26
GirishChilukuriyeah I got it now, Thanks rosmaita whoami-rajat tosky15:29
rosmaitanp15:29
*** hemna has quit IRC15:39
*** hemna has joined #openstack-cinder15:40
*** GirishChilukuri_ has joined #openstack-cinder15:43
*** GirishChilukuri has quit IRC15:46
*** zoharm has quit IRC15:55
*** rratnaka14 has joined #openstack-cinder16:04
*** rratnaka has quit IRC16:08
*** takamatsu has quit IRC16:11
*** ociuhandu has quit IRC16:15
*** smcginnis has quit IRC16:25
*** ociuhandu has joined #openstack-cinder16:31
*** smcginnis has joined #openstack-cinder16:34
*** ChanServ sets mode: +o smcginnis16:34
*** e0ne has quit IRC16:37
*** m75abrams has quit IRC16:48
*** udesale_ has quit IRC16:52
*** hemna has quit IRC17:01
*** jv_ has quit IRC17:01
*** hoonetorg has quit IRC17:01
*** n-saito has quit IRC17:01
*** stand has quit IRC17:01
*** lifeless_ has quit IRC17:01
*** JohnnyRa1 has quit IRC17:01
*** hack-char has quit IRC17:01
*** openstackgerrit has quit IRC17:02
*** stand has joined #openstack-cinder17:05
*** hemna has joined #openstack-cinder17:07
*** jv_ has joined #openstack-cinder17:07
*** hoonetorg has joined #openstack-cinder17:07
*** n-saito has joined #openstack-cinder17:07
*** lifeless_ has joined #openstack-cinder17:07
*** JohnnyRa1 has joined #openstack-cinder17:07
*** hack-char has joined #openstack-cinder17:07
*** e0ne has joined #openstack-cinder17:13
*** venkatakrishnath has quit IRC17:14
GirishChilukuri_tosky: Do we need to install cinder-tempest-plugin module, since this module is installed while devstack is installed and revert to snapshot test cases are part of this module.17:21
*** ociuhandu_ has joined #openstack-cinder17:21
toskyGirishChilukuri_: that's the idea, yes17:23
toskyGirishChilukuri_: that module is not installed by devstack automatically; you need to install it and tell devstack to configure it by listing the local checkout in the TEMPEST_PLUGINS variable17:24
*** ociuhandu has quit IRC17:25
toskyGirishChilukuri_: if your CI uses Zuul v3 the process is easier (you can copy one of the jobs we use in cinder-tempest-plugin)17:25
*** ociuhandu_ has quit IRC17:26
*** e0ne has quit IRC17:26
GirishChilukuri_tosky: Zuul version is 2.5.117:28
*** whoami-rajat__ has quit IRC17:29
toskyerm, then you don't have all the shiny feature of the newest zuul17:30
toskybut anyway, what I've written still applies: you need to make sure your job clones cinder-tempest-plugin as well, and devstack is provided the path of that local checkout through TEMPEST_PLUGINS17:31
*** ociuhandu has joined #openstack-cinder17:32
*** manoj_katari has joined #openstack-cinder17:35
GirishChilukuri_tosky: after installing cinder tempest plugin module, we need to export the "TEMPEST_PLUGINS" variable with the path where the module is installed. Is my understanding is correct.17:36
*** ociuhandu has quit IRC17:37
toskyGirishChilukuri_: it's been a while since I've done that without zuul v3, but yes, that should be it17:37
toskyGirishChilukuri_: you can check how the zuul v3 jobs on opendev.org generates the local.conf configuration file for devstack17:38
toskyGirishChilukuri_: for example (just one of the builds) https://191b3b2e56a0631260e6-9a2bdf79ebc3dafe7919d3415a023c8b.ssl.cf5.rackcdn.com/777074/1/check/cinder-tempest-plugin-lvm-lio-barbican/27eb541/controller/logs/local_conf.txt17:39
GirishChilukuri_tosky: TEMPEST_PLUGINS="/opt/stack/cinder-tempest-plugin" this is how we need to set17:41
toskyof course the path depends on how you clone the repository in your job17:43
*** e0ne has joined #openstack-cinder17:43
toskybut yeah17:43
toskyhopefully that should work17:43
GirishChilukuri_tosky: LIBS_FROM_GIT=barbican,cinder,cinder-tempest-plugin,cinderlib,devstack,glance,keystone,neutron,nova,placement,requirements,swift,tempest, do we need to update this variable also17:43
*** e0ne has quit IRC17:43
toskyGirishChilukuri_: if you set it, I'd say yet: that way, the latest commit of cinder-tempest-plugin will be installed; otherwise it will be installed from pip17:45
toskybut you want to use the last commit17:45
toskyso yes, please add cinder-tempest-plugin to that list17:45
*** e0ne has joined #openstack-cinder17:59
*** rpittau is now known as rpittau|afk18:11
GirishChilukuri_Thanks tosky we will try and get back to you If any clarification is needed18:14
toskysure18:16
geguileoenriquetaso: apparently wu.chunyang had already proposed a fix for the wrong notification on detach https://review.opendev.org/c/openstack/cinder/+/72317918:25
geguileoenriquetaso: though in my opinion it is the wrong approach, I didn't know about it, so I proposed my own: https://review.opendev.org/c/openstack/cinder/+/77853418:26
*** GirishChilukuri_ has quit IRC18:26
geguileo(while fixing some stuff around that part of the code)18:26
*** lpetrut has joined #openstack-cinder18:38
*** zenkuro has joined #openstack-cinder18:43
*** rratnaka14 has quit IRC18:44
*** manoj_katari has quit IRC18:44
*** lpetrut has quit IRC18:49
*** whoami-rajat has quit IRC19:50
enriquetasothanks geguileo, let me add both tho the bug report i guess19:52
*** lifeless_ is now known as lifeless19:56
*** openstackgerrit has joined #openstack-cinder20:00
openstackgerritMerged openstack/cinder-tempest-plugin master: Use the embedded scenario manager instead of tempest one  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77707420:00
*** happyhemant has quit IRC20:13
*** rcernin has joined #openstack-cinder20:46
openstackgerritLuigi Toscano proposed openstack/cinder-tempest-plugin master: Refactor the *lvm-lio* job(s) with a no cinderlib variant  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/77844820:49
openstackgerritLuigi Toscano proposed openstack/cinder stable/stein: [stable-only] Set IPv6 params to fix tempest-slow-py3  https://review.opendev.org/c/openstack/cinder/+/77847620:59
openstackgerritLuigi Toscano proposed openstack/cinder stable/stein: Port several legacy tempest jobs to Zuul v3  https://review.opendev.org/c/openstack/cinder/+/75121120:59
openstackgerritFernando Ferraz Silva proposed openstack/cinder stable/ussuri: NetApp SolidFire: Fix duplicate volume when API response is lost  https://review.opendev.org/c/openstack/cinder/+/76427421:04
*** rcernin has quit IRC21:17
*** e0ne has quit IRC21:23
*** gary_perkins has joined #openstack-cinder21:27
openstackgerritEric Harney proposed openstack/os-brick master: Fix import order of libraries  https://review.opendev.org/c/openstack/os-brick/+/77847021:30
openstackgerritEric Harney proposed openstack/os-brick master: Enforce import order with flake8-import-order  https://review.opendev.org/c/openstack/os-brick/+/77858321:31
*** irclogbot_0 has quit IRC21:33
*** ianw has quit IRC21:33
*** abishop has quit IRC21:33
*** Reepicheep has quit IRC21:33
*** amotoki has quit IRC21:33
*** atmark has quit IRC21:33
*** Mr_Freezeex has quit IRC21:33
*** atmark has joined #openstack-cinder21:34
*** irclogbot_0 has joined #openstack-cinder21:34
*** ianw has joined #openstack-cinder21:34
*** abishop has joined #openstack-cinder21:34
*** Reepicheep has joined #openstack-cinder21:34
*** amotoki has joined #openstack-cinder21:34
*** Mr_Freezeex has joined #openstack-cinder21:34
eharneyrosmaita: it would be good to get 778583 ^ on the radar before req freeze21:37
rosmaitaok, thanks21:38
*** e0ne has joined #openstack-cinder21:38
*** zzzeek has quit IRC21:44
openstackgerritEric Harney proposed openstack/cinder master: Move require_driver_initialized / log_unsupp to volume_utils  https://review.opendev.org/c/openstack/cinder/+/77525021:44
*** zzzeek has joined #openstack-cinder21:45
*** rcernin has joined #openstack-cinder22:05
*** rcernin has quit IRC22:11
*** rcernin has joined #openstack-cinder22:11
openstackgerritMerged openstack/os-brick master: Changed minversion in tox to 3.18.0  https://review.opendev.org/c/openstack/os-brick/+/77156822:14
*** ajitha has quit IRC22:23
*** smekala has joined #openstack-cinder22:27
smekalaHello, Can I get some help with https://review.opendev.org/c/openstack/python-cinderclient/+/77631122:31
smekalaThis proposed changes will address the bug22:32
smekalahttps://bugs.launchpad.net/python-cinderclient/+bug/191599622:32
openstackLaunchpad bug 1915996 in python-cinderclient "Fetching server version fails to support passing client certificates" [Medium,New] - Assigned to Sri Harsha mekala (harshayahoo)22:32
*** e0ne has quit IRC22:42
*** smekala has quit IRC22:55
*** rcernin has quit IRC22:56
*** rcernin has joined #openstack-cinder23:01
*** thgcorrea has quit IRC23:01
openstackgerritMerged openstack/os-brick stable/train: FC: Fix not flushing on detach  https://review.opendev.org/c/openstack/os-brick/+/77740923:16
*** rcernin has quit IRC23:26
openstackgerritMerged openstack/python-cinderclient master: Bump pylint to 2.6.0  https://review.opendev.org/c/openstack/python-cinderclient/+/74670523:39
*** zzzeek has quit IRC23:40
*** zzzeek has joined #openstack-cinder23:42
lbragstadrosmaita did you happen to get my ping from last night on the cinder tests?23:42
rosmaitalbragstad: i did, will be looking at them a bit later23:43
lbragstadok - that's the basic template23:43
rosmaitameant to ack but got sidetracked23:43
lbragstadand it's still using the cinderlib bits - which i don't think i'm supposed to be using according to tosky and geguileo23:43
rosmaitaok, i'll ignore the cinderlib parts23:44
*** vishalmanchanda has quit IRC23:44
lbragstadwell - i think it just means we have a missing piece23:44
lbragstadwe need to have something setup config for cinder and tempest to do things properly for 1.) cinder to enforce the new defaults 2.) have tempest execute the right tests23:45
lbragstadand i'm not sure where that something should live (in .zuul.conf)?23:45
lbragstador in devstack directly?23:45
toskylbragstad: how did you solve the problem for nova? I though the only devstack configuration for nova happens in devstack itself23:45
toskysame for neutron and glance23:45
lbragstadi didn't solve the problem for nova23:45
tosky... so devstack :)23:45
rosmaitatosky never sleeps23:45
lbragstadgmann did - but i'll let him weight in23:46
lbragstadfor glance i used the glance-tempest-plugin23:46
lbragstadfor keystone i used the keystone-tempest-plugin23:46
rosmaitathere is a cinder-tempest-plugin23:46
toskythat's for tempest23:46
toskyI guess the question is the glance part23:46
toskyI mean, that's the problem with the former "core" projects: while newer projects have their own devstack plugin, the core ones generally rely on devstack23:47
rosmaitawe live a privileged life as part of the "dirty six"23:47
lbragstadso - these tests are for tempest?23:48
toskyno23:48
toskythe tests are for cinder-tempest-plugin23:48
lbragstadthey are technically protection tests implemented using tempest23:48
lbragstadbut yea - they live in cinder-tempest-plugin23:48
toskyok23:49
toskyso the problem is: how to configure cinder to enforce the new defaults? The only place is devstack23:49
toskythe problem is not point 2.) from your list above, just point 1.)23:49
lbragstadok - so just configuring cinder to enforce scope23:50
lbragstadif i can do that in .zuul.conf with test-config in devstack hooks, is that fine?23:50
toskyif you add code to devstack, you don't need any changes to the jobs23:50
lbragstadand that would live in openstack/cinder's .zuul.yaml file?23:50
lbragstadi'm not convinced i need to add anything to devstack, yet23:51
toskyso why did you try to change cinderlib?23:51
lbragstadbecause i was investigating things :)23:51
toskythis is the change: https://review.opendev.org/c/openstack/cinderlib/+/772770/3/devstack/plugin.sh23:52
lbragstadi've started looking at things more closely after your comments, but i want to make sure the approach i take is agreed upon23:52
toskyI guess gmann and masayukig need to chime in23:53
toskyif it was up to me, I would add some central configuration to devstack to enable the "policy enforcement mode" (part of configure_protection_tests is really common for most of the services)23:55
lbragstadtosky to be clear - it doesn't really matter to me where it lives, i'd just like to get some testing in place is all (i certainly don't want to me mistaken for saying it must live in cinderlib because that's where I proposed the first patch)23:55
toskyand configure_enforce_scope may be a function defined for each service, whose implementation should live in devstack for the 6 and on each devstack plugin for the others23:55
rosmaitai think tosky is right, that kind of stuff you have in the cinderlib patch is usually seen in lib/cinder in devstach23:56
lbragstadok23:56
rosmaitabut he's also right that gmann and masayukig are probably the best references here23:57
lbragstadok - i'll see if i can hack something in to place and get something working, but i imagine it'll change23:57
lbragstadi just don't really want to wait anymore to get some tests written23:57
lbragstadespecially this late in the cycle23:57
rosmaitaagreed23:57
rosmaitai have to grab dinner and do an errand, will look over your patches in cinder later23:58
toskysure; but then just through that cinderlib patch directly into devstack, even if it's a WIP and it's going to change23:58
lbragstadyep - makes sense23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!