| *** brinzhang has joined #openstack-cinder | 00:14 | |
| *** sorrison has joined #openstack-cinder | 00:20 | |
| openstackgerrit | Sofia Enriquez proposed openstack/cinder master: RBD: Fix _show_msg_check_clone_v2_api https://review.opendev.org/c/openstack/cinder/+/777031 | 00:31 |
|---|---|---|
| *** tosky has quit IRC | 00:38 | |
| *** xinliang has joined #openstack-cinder | 01:19 | |
| *** __ministry has joined #openstack-cinder | 01:21 | |
| *** hamalq has quit IRC | 01:26 | |
| openstackgerrit | Ghanshyam proposed openstack/cinder-tempest-plugin master: Copy scenario manager and avoid using the Tempest unstable interface https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/777040 | 01:26 |
| openstackgerrit | Ghanshyam proposed openstack/cinder-tempest-plugin master: Copy scenario manager and avoid using the Tempest unstable interface https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/777040 | 01:38 |
| *** benfelin has quit IRC | 01:50 | |
| *** benj_ has quit IRC | 01:53 | |
| *** benj_ has joined #openstack-cinder | 01:54 | |
| openstackgerrit | Xuan Yandong proposed openstack/cinder master: Remove six https://review.opendev.org/c/openstack/cinder/+/768837 | 02:24 |
| openstackgerrit | Xuan Yandong proposed openstack/cinder master: Correct the rest api url of export_recore and import_record of backup https://review.opendev.org/c/openstack/cinder/+/759169 | 02:40 |
| *** GirishChilukuri has joined #openstack-cinder | 02:43 | |
| *** GirishChilukuri has quit IRC | 02:54 | |
| *** enriquetaso has quit IRC | 03:04 | |
| *** ricolin has quit IRC | 03:15 | |
| *** ricolin has joined #openstack-cinder | 03:30 | |
| *** psachin has joined #openstack-cinder | 03:36 | |
| *** xinliang has quit IRC | 04:05 | |
| *** udesale has joined #openstack-cinder | 04:08 | |
| *** GirishChilukuri has joined #openstack-cinder | 04:21 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 04:24 | |
| *** GirishChilukuri has quit IRC | 04:27 | |
| *** martinkennelly has quit IRC | 04:29 | |
| *** venkatakrishnath has joined #openstack-cinder | 04:42 | |
| *** __ministry has quit IRC | 04:45 | |
| *** GirishChilukuri has joined #openstack-cinder | 04:46 | |
| *** __ministry has joined #openstack-cinder | 04:47 | |
| *** GirishChilukuri_ has quit IRC | 04:48 | |
| openstackgerrit | Tushar Trambak Gite proposed openstack/cinder master: Fix in api-ref https://review.opendev.org/c/openstack/cinder/+/775331 | 05:09 |
| *** rcernin has quit IRC | 05:15 | |
| *** rcernin has joined #openstack-cinder | 05:22 | |
| *** udesale_ has joined #openstack-cinder | 06:08 | |
| *** udesale has quit IRC | 06:11 | |
| *** m75abrams has joined #openstack-cinder | 06:20 | |
| *** vishalmanchanda has joined #openstack-cinder | 06:24 | |
| *** zzzeek has quit IRC | 06:45 | |
| *** zzzeek has joined #openstack-cinder | 06:46 | |
| *** xinliang has joined #openstack-cinder | 07:03 | |
| *** GirishChilukuri has quit IRC | 07:09 | |
| *** GirishChilukuri has joined #openstack-cinder | 07:09 | |
| *** brinzhang has quit IRC | 07:13 | |
| *** rcernin has quit IRC | 07:15 | |
| *** udesale__ has joined #openstack-cinder | 07:26 | |
| *** udesale_ has quit IRC | 07:30 | |
| *** smcginnis has quit IRC | 07:30 | |
| *** smcginnis has joined #openstack-cinder | 07:30 | |
| *** ChanServ sets mode: +o smcginnis | 07:30 | |
| *** hoonetorg has quit IRC | 07:38 | |
| *** zzzeek has quit IRC | 07:39 | |
| *** zzzeek has joined #openstack-cinder | 07:40 | |
| *** GirishChilukuri has quit IRC | 07:48 | |
| *** rcernin has joined #openstack-cinder | 07:49 | |
| *** udesale__ has quit IRC | 08:00 | |
| *** rcernin has quit IRC | 08:06 | |
| *** rcernin has joined #openstack-cinder | 08:09 | |
| *** rcernin has quit IRC | 08:23 | |
| *** e0ne has joined #openstack-cinder | 08:27 | |
| *** rpittau|afk is now known as rpittau | 08:28 | |
| *** zoharm has joined #openstack-cinder | 08:30 | |
| e0ne | zoharm: hi. could you please ping me when you have a time to discuss nvme connector? | 08:34 |
| zoharm | e0ne: yes, i am available now | 08:34 |
| e0ne | zoharm: I read you comment in gerrit. can we implement the fix without nova changes? | 08:40 |
| zoharm | e0ne: as far as i can see there are two options: 1. add compatibility code in the same connector, 2. split the connectors. #2 requires changes to nova, otherwise it won't be able to use the new connector | 08:42 |
| e0ne | I see. let me look into the nova side how it's working | 08:45 |
| zoharm | I did a review, I am pretty sure the only two changes needed in nova are the ones I mentioned in the comment (add libvirt volume driver, and associate it with a volume type) | 08:48 |
| *** tosky has joined #openstack-cinder | 08:50 | |
| e0ne | zoharm: we need to remember that we've got only two weeks before feature freeze to get it merged in nova | 08:52 |
| *** GirishChilukuri has joined #openstack-cinder | 08:54 | |
| zoharm | e0ne: yes, that is why we need to make a decision as soon as possible. i think that adding compatibility in the same connector is better for not needing to touch nova code, but if we decide that we have to split the connectors up, then it is unavoidable | 08:57 |
| zoharm | so, what do you think? is it ok to do the compatibility change i proposed previously, or do we need to split and make the nova changes? | 08:58 |
| e0ne | splitting code into several connectors looks better | 08:58 |
| e0ne | but priority is to fix the issue in this release | 08:58 |
| *** ociuhandu has joined #openstack-cinder | 08:59 | |
| e0ne | how much time will it take to implement both options? | 08:59 |
| zoharm | definitely priority is fixing the regression of existing driver using nvmeof, which will be fixed in either option, however, do we have enough time to merge into nova? | 09:00 |
| zoharm | i think i could submit the nova change by tomorrow | 09:00 |
| zoharm | hopefully together with the os-brick (and small cinder driver change) to follow up | 09:01 |
| zoharm | the compatibility change is definitely easier, it will be all in-one change to the connector and thats it | 09:01 |
| e0ne | I think we can ask nova team to review patch since it's blocker for a release | 09:02 |
| e0ne | but to do it we need to merge os-brick connector and do a new release | 09:02 |
| e0ne | zoharm: if you think that compatibility change is easy and fast to implement, let's try it as a workaround and make refactoring without a rush | 09:03 |
| zoharm | ok, so then we deciding on this option? | 09:03 |
| *** ociuhandu has quit IRC | 09:04 | |
| zoharm | oh hmm | 09:04 |
| zoharm | you mean make refactoring without a rush as in the split into two connectors? | 09:04 |
| e0ne | yes | 09:04 |
| e0ne | we can do it in a next release or in the current one | 09:04 |
| zoharm | ok, as you are suggesting and ultimately it is a matter of priority, if it is ok to do the compatibility change now i will work on that first thing now | 09:05 |
| zoharm | i will try to submit something in a few hours | 09:05 |
| e0ne | cool. let me know if you need any help | 09:06 |
| *** udesale has joined #openstack-cinder | 09:06 | |
| zoharm | ok, so lets go with that first | 09:06 |
| zoharm | the only thing i need is about the system uuid | 09:06 |
| zoharm | there is a method for generating systemuuid in the original nvmeof connector, is it ok to change that? (the method we used is generate id from root filesystem) | 09:07 |
| zoharm | if not, it could simply be a new connector property that will live side-by-side (old and new host uuid) | 09:07 |
| *** psachin has quit IRC | 09:11 | |
| *** martinkennelly has joined #openstack-cinder | 09:11 | |
| *** ociuhandu has joined #openstack-cinder | 09:12 | |
| e0ne | zoharm: any backward compatible change should be ok | 09:13 |
| *** udesale has quit IRC | 09:17 | |
| *** ociuhandu has quit IRC | 09:24 | |
| *** ociuhandu has joined #openstack-cinder | 09:24 | |
| *** noonedeadpunk has quit IRC | 09:26 | |
| *** xinliang has quit IRC | 09:27 | |
| *** ociuhandu has quit IRC | 09:28 | |
| openstackgerrit | Luigi Toscano proposed openstack/cinder-tempest-plugin master: Use the embedded scenario manager instead of tempest one https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/777074 | 09:28 |
| *** ociuhandu has joined #openstack-cinder | 09:28 | |
| *** noonedeadpunk has joined #openstack-cinder | 09:29 | |
| *** venkatakrishnath has quit IRC | 09:29 | |
| *** lpetrut has joined #openstack-cinder | 09:35 | |
| *** GirishChilukuri has quit IRC | 09:43 | |
| openstackgerrit | Luigi Toscano proposed openstack/devstack-plugin-nfs master: Update the branch-specific jobs (+victoria, -stein) https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/777078 | 09:43 |
| *** GirishChilukuri has joined #openstack-cinder | 09:43 | |
| zoharm | e0ne: i think i went through the logical compatibility changes basically starting off with the original connector, and only using the new connector when necessary. i am working on testing it now but i think logic-wise it is almost done. | 09:46 |
| zoharm | however, this breaks both original and new unit tests :) | 09:46 |
| e0ne | :) | 09:46 |
| zoharm | this might be a bit of a headache to get them both to work, do you have any suggestions here? can we cut some tests out? | 09:46 |
| *** udesale has joined #openstack-cinder | 09:53 | |
| openstackgerrit | Zohar Mamedov proposed openstack/os-brick master: NVMeOF connector compatibility fix https://review.opendev.org/c/openstack/os-brick/+/777086 | 10:00 |
| zoharm | e0ne: pushed the change up to gerrit, could you run a test with it and see if it resolves the regression? https://review.opendev.org/c/openstack/os-brick/+/777086 | 10:02 |
| *** udesale has quit IRC | 10:05 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 10:14 | |
| *** GirishChilukuri has quit IRC | 10:16 | |
| e0ne | zoharm: let me test it. I can't run CI but will test it manually | 10:16 |
| zoharm | e0ne: sounds good, thank you very much! | 10:17 |
| e0ne | np | 10:17 |
| *** ajitha has joined #openstack-cinder | 10:35 | |
| *** ociuhandu has quit IRC | 10:45 | |
| *** ociuhandu has joined #openstack-cinder | 10:46 | |
| *** ociuhandu has quit IRC | 10:47 | |
| *** ociuhandu has joined #openstack-cinder | 10:47 | |
| *** rpittau is now known as rpittau|bbl | 11:00 | |
| *** Luzi has joined #openstack-cinder | 11:13 | |
| openstackgerrit | Luigi Toscano proposed openstack/os-brick stable/victoria: FC: Fix not flushing on detach https://review.opendev.org/c/openstack/os-brick/+/777092 | 11:14 |
| *** smcginnis has quit IRC | 11:19 | |
| *** __ministry has quit IRC | 11:24 | |
| *** smcginnis has joined #openstack-cinder | 11:26 | |
| *** ChanServ sets mode: +o smcginnis | 11:26 | |
| *** ociuhandu has quit IRC | 11:40 | |
| *** brinzhang has joined #openstack-cinder | 11:43 | |
| tosky | ok, that's weird: devstack-plugin-nfs jobs works on all branches but ussuri, and the failure is consistent | 11:45 |
| tosky | do we miss any NFS-related patch in ussuri? | 11:45 |
| *** brinzhang has quit IRC | 11:45 | |
| tosky | see the last failures here: https://review.opendev.org/q/project:openstack/devstack-plugin-nfs+status:open | 11:46 |
| tosky | errors in | 11:47 |
| tosky | - setDownClass(tempest.api.volume.test_volumes_snapshots.VolumesSnapshotTestJSON) | 11:47 |
| tosky | - tempest.api.volume.test_volumes_snapshots.VolumeSnapshotTestJSON.test_snapshot_create_delete_with_volume_in_use | 11:48 |
| tosky | ussuri-only | 11:48 |
| *** GirishChilukuri_ has quit IRC | 11:49 | |
| *** jv_ has quit IRC | 11:52 | |
| *** ociuhandu has joined #openstack-cinder | 11:56 | |
| *** smcginnis has quit IRC | 12:01 | |
| *** ociuhandu has quit IRC | 12:01 | |
| *** jv_ has joined #openstack-cinder | 12:05 | |
| *** smcginnis has joined #openstack-cinder | 12:07 | |
| *** ChanServ sets mode: +o smcginnis | 12:07 | |
| *** ociuhandu has joined #openstack-cinder | 12:11 | |
| *** ociuhandu has quit IRC | 12:16 | |
| *** manoj_katari has joined #openstack-cinder | 12:20 | |
| *** jv_ has quit IRC | 12:24 | |
| *** zenkuro has quit IRC | 12:26 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 12:27 | |
| *** zenkuro has joined #openstack-cinder | 12:28 | |
| *** ociuhandu has joined #openstack-cinder | 12:29 | |
| hemna | morning | 12:31 |
| *** ociuhandu has quit IRC | 12:42 | |
| *** manoj_katari has quit IRC | 12:45 | |
| *** zenkuro has quit IRC | 12:51 | |
| *** zenkuro has joined #openstack-cinder | 12:52 | |
| e0ne | zoharm: your fix work with SPDKDriver and nvmet | 12:58 |
| e0ne | zoharm: let me look into the code | 12:58 |
| *** rosmaita has quit IRC | 12:59 | |
| zoharm | e0ne: thank you! there are some fixes i (for the new mode of operation) i havent pushed in yet, i will push it in together with the unit test fixes to pass the gates | 13:00 |
| *** rosmaita has joined #openstack-cinder | 13:00 | |
| *** rpittau|bbl is now known as rpittau | 13:01 | |
| zoharm | e0ne: ok i think i will just push in the logical changes now, and wait for the unit tests to be done later, just in case | 13:07 |
| zoharm | these fixes only affect the new mode of operation so i think it wont change anything on your end but just bringing this up | 13:08 |
| openstackgerrit | Zohar Mamedov proposed openstack/os-brick master: NVMeOF connector compatibility fix https://review.opendev.org/c/openstack/os-brick/+/777086 | 13:09 |
| *** GirishChilukuri_ has quit IRC | 13:14 | |
| *** ociuhandu has joined #openstack-cinder | 13:35 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 13:36 | |
| *** ociuhandu has quit IRC | 13:39 | |
| *** ociuhandu has joined #openstack-cinder | 13:40 | |
| *** ociuhandu has quit IRC | 13:40 | |
| *** enriquetaso has joined #openstack-cinder | 13:42 | |
| *** ociuhandu has joined #openstack-cinder | 13:42 | |
| *** GirishChilukuri has joined #openstack-cinder | 13:44 | |
| *** GirishChilukuri_ has quit IRC | 13:46 | |
| *** ociuhandu has quit IRC | 13:49 | |
| *** ociuhandu has joined #openstack-cinder | 13:53 | |
| *** ociuhandu has quit IRC | 13:57 | |
| *** ociuhandu has joined #openstack-cinder | 13:57 | |
| openstackgerrit | Simon Dodsley proposed openstack/cinder master: [Pure] Fix failing consistency group tempest tests https://review.opendev.org/c/openstack/cinder/+/775944 | 13:59 |
| *** udesale has joined #openstack-cinder | 14:07 | |
| *** abishop_ is now known as abishop | 14:28 | |
| *** vishalmanchanda has quit IRC | 14:33 | |
| tosky | jungleboyj: can I please bother you for another vote on this clean backport which fixes an error with backups over NFS? https://review.opendev.org/c/openstack/cinder/+/769797/ | 14:49 |
| *** jv_ has joined #openstack-cinder | 14:58 | |
| *** udesale has quit IRC | 14:59 | |
| *** udesale has joined #openstack-cinder | 15:00 | |
| *** GirishChilukuri has quit IRC | 15:13 | |
| *** Luzi has quit IRC | 15:15 | |
| *** ociuhandu has quit IRC | 15:20 | |
| *** ociuhandu has joined #openstack-cinder | 15:21 | |
| *** benfelin has joined #openstack-cinder | 15:21 | |
| *** TusharTgite has joined #openstack-cinder | 15:24 | |
| *** ociuhandu has quit IRC | 15:25 | |
| *** ociuhandu has joined #openstack-cinder | 15:29 | |
| caiqilong | rosmaita: Hi, There's a new patch for previous issues about "TOYOU ACS5000" driver. Maybe it need some further review when you have time. | 15:35 |
| rosmaita | caiqilong: ack | 15:36 |
| caiqilong | rosmaita: Thanks, I will response tomorrow because of the time region. | 15:41 |
| e0ne | zoharm: | 15:47 |
| e0ne | zoharm: I trigerred CI | 15:47 |
| e0ne | and I'll review your change later today | 15:48 |
| *** benfelin has quit IRC | 16:05 | |
| *** benfelin has joined #openstack-cinder | 16:07 | |
| openstackgerrit | Tushar Trambak Gite proposed openstack/python-cinderclient master: Doc: Functional Tests in python-cinderclient https://review.opendev.org/c/openstack/python-cinderclient/+/767520 | 16:07 |
| *** GirishChilukuri has joined #openstack-cinder | 16:10 | |
| openstackgerrit | Tushar Trambak Gite proposed openstack/cinderlib master: Move cinderlib to new hacking 4.0.0 https://review.opendev.org/c/openstack/cinderlib/+/774882 | 16:26 |
| openstackgerrit | Tushar Trambak Gite proposed openstack/os-brick master: Move os-brick to new hacking 4.0.0 https://review.opendev.org/c/openstack/os-brick/+/774883 | 16:27 |
| openstackgerrit | Tushar Trambak Gite proposed openstack/python-cinderclient master: Move cinderclient to new hacking 4.0.0 https://review.opendev.org/c/openstack/python-cinderclient/+/776590 | 16:27 |
| *** jdillaman has quit IRC | 16:28 | |
| *** GirishChilukuri_ has joined #openstack-cinder | 16:30 | |
| *** lpetrut has quit IRC | 16:32 | |
| *** GirishChilukuri has quit IRC | 16:33 | |
| *** benfelin has quit IRC | 16:34 | |
| *** benfelin has joined #openstack-cinder | 16:36 | |
| *** m75abrams has quit IRC | 16:39 | |
| *** zoharm has quit IRC | 16:47 | |
| *** udesale has quit IRC | 17:03 | |
| *** rratnaka has joined #openstack-cinder | 17:22 | |
| *** ociuhandu_ has joined #openstack-cinder | 17:24 | |
| *** ociuhandu has quit IRC | 17:28 | |
| *** ociuhandu_ has quit IRC | 17:28 | |
| *** rpittau is now known as rpittau|afk | 17:41 | |
| *** e0ne has quit IRC | 17:48 | |
| *** e0ne has joined #openstack-cinder | 17:49 | |
| *** TusharTgite has quit IRC | 17:58 | |
| *** lpetrut has joined #openstack-cinder | 18:34 | |
| openstackgerrit | Ratnakaram Rajesh proposed openstack/cinder master: Update code layout and missing Zadara features https://review.opendev.org/c/openstack/cinder/+/774463 | 18:35 |
| *** GirishChilukuri_ has quit IRC | 18:38 | |
| *** lpetrut has quit IRC | 18:40 | |
| *** rratnaka has quit IRC | 18:51 | |
| *** gmann is now known as gmann_lunch | 19:47 | |
| *** gmann_lunch is now known as gmann | 20:07 | |
| *** caiqilong has quit IRC | 20:13 | |
| *** zenkuro has quit IRC | 20:24 | |
| *** zzzeek has quit IRC | 20:29 | |
| *** hamalq has joined #openstack-cinder | 20:30 | |
| *** zzzeek has joined #openstack-cinder | 20:31 | |
| *** rcernin has joined #openstack-cinder | 20:44 | |
| *** rajinir has quit IRC | 21:01 | |
| *** rcernin has quit IRC | 21:01 | |
| *** rajinir has joined #openstack-cinder | 21:02 | |
| *** knikolla has quit IRC | 21:11 | |
| *** knikolla has joined #openstack-cinder | 21:11 | |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Update ceph default version to octopus https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/777232 | 21:23 |
| *** ajitha has quit IRC | 21:24 | |
| *** rcernin has joined #openstack-cinder | 21:46 | |
| *** rcernin has quit IRC | 21:57 | |
| *** rcernin has joined #openstack-cinder | 21:57 | |
| openstackgerrit | Merged openstack/cinder master: TOYOU: Abandon the target parameter and Report SAN driver options https://review.opendev.org/c/openstack/cinder/+/773844 | 22:40 |
| openstackgerrit | Merged openstack/cinder master: PowerMax Docs - Incorrect property set on volume group https://review.opendev.org/c/openstack/cinder/+/744738 | 22:43 |
| *** Corwin has quit IRC | 22:46 | |
| *** dansmith has quit IRC | 22:46 | |
| *** Corwin has joined #openstack-cinder | 22:48 | |
| *** dansmith has joined #openstack-cinder | 22:48 | |
| *** tkajinam has joined #openstack-cinder | 22:51 | |
| *** e0ne has quit IRC | 22:53 | |
| *** tobias-urdin has quit IRC | 23:22 | |
| *** tkajinam has quit IRC | 23:40 | |
| *** tkajinam has joined #openstack-cinder | 23:40 | |
| *** e0ne has joined #openstack-cinder | 23:53 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!