| *** tosky has quit IRC | 00:02 | |
| *** baojg has quit IRC | 00:18 | |
| *** baojg has joined #openstack-cinder | 00:19 | |
| *** enriquetaso has quit IRC | 00:31 | |
| *** brinzhang has joined #openstack-cinder | 00:38 | |
| *** benj_- has joined #openstack-cinder | 00:53 | |
| *** benj_ has quit IRC | 00:54 | |
| *** benj_- is now known as benj_ | 00:54 | |
| lseki | geguileo: indeed it requires implementing update_migrated_volume, too | 01:07 |
|---|---|---|
| lseki | now the QoS policy group is associated to the correct file name | 01:08 |
| *** thgcorrea has quit IRC | 01:29 | |
| *** user_19173783170 has joined #openstack-cinder | 01:44 | |
| *** user_19173783170 has left #openstack-cinder | 02:16 | |
| *** user_19173783170 has joined #openstack-cinder | 02:16 | |
| *** priteau has quit IRC | 03:03 | |
| *** openstackgerrit has quit IRC | 03:22 | |
| *** psachin has joined #openstack-cinder | 03:44 | |
| *** hamalq_ has quit IRC | 03:45 | |
| *** amar7ibm_ has joined #openstack-cinder | 03:53 | |
| *** dave-mccowan has quit IRC | 03:54 | |
| *** rosmaita has left #openstack-cinder | 03:57 | |
| *** openstackgerrit has joined #openstack-cinder | 04:28 | |
| openstackgerrit | Masahiro Okuri proposed openstack/cinder master: created s3 cinder backup driver https://review.opendev.org/c/openstack/cinder/+/746561 | 04:28 |
| *** sapd1 has joined #openstack-cinder | 04:55 | |
| *** zzzeek has quit IRC | 05:06 | |
| *** zzzeek has joined #openstack-cinder | 05:08 | |
| *** dasp has quit IRC | 05:18 | |
| *** sharathkacham has joined #openstack-cinder | 05:26 | |
| *** user_19173783170 has quit IRC | 05:26 | |
| *** udesale has joined #openstack-cinder | 05:30 | |
| *** dasp has joined #openstack-cinder | 05:34 | |
| *** user_19173783170 has joined #openstack-cinder | 05:38 | |
| *** user_19173783170 has quit IRC | 05:42 | |
| *** rpittau|afk has quit IRC | 06:11 | |
| *** mnaser has quit IRC | 06:11 | |
| *** mnaser has joined #openstack-cinder | 06:11 | |
| *** rpittau|afk has joined #openstack-cinder | 06:12 | |
| *** sapd1 has quit IRC | 06:15 | |
| *** zzzeek has quit IRC | 06:17 | |
| *** haixin has joined #openstack-cinder | 06:17 | |
| *** zzzeek has joined #openstack-cinder | 06:18 | |
| *** pcaruana has joined #openstack-cinder | 06:19 | |
| *** zenkuro has joined #openstack-cinder | 06:31 | |
| *** GirishChilukuri has joined #openstack-cinder | 06:40 | |
| *** GirishChilukuri has quit IRC | 06:45 | |
| *** lpetrut has joined #openstack-cinder | 07:00 | |
| *** rcernin has quit IRC | 07:10 | |
| *** rcernin has joined #openstack-cinder | 07:29 | |
| *** zenkuro has quit IRC | 07:58 | |
| *** zenkuro has joined #openstack-cinder | 07:58 | |
| *** hamalq has joined #openstack-cinder | 08:06 | |
| *** rcernin has quit IRC | 08:07 | |
| *** rpittau|afk is now known as rpittau | 08:17 | |
| *** e0ne has joined #openstack-cinder | 08:23 | |
| *** zzzeek has quit IRC | 08:36 | |
| *** zzzeek has joined #openstack-cinder | 08:39 | |
| *** tosky has joined #openstack-cinder | 08:47 | |
| *** zenkuro has quit IRC | 08:49 | |
| *** zenkuro has joined #openstack-cinder | 08:49 | |
| *** spatel has joined #openstack-cinder | 08:52 | |
| *** spatel has quit IRC | 08:56 | |
| *** rcernin has joined #openstack-cinder | 08:56 | |
| *** dsariel has joined #openstack-cinder | 09:01 | |
| *** haixin has quit IRC | 09:12 | |
| *** rcernin has quit IRC | 09:13 | |
| *** martinkennelly has joined #openstack-cinder | 09:16 | |
| *** zzzeek has quit IRC | 09:32 | |
| *** zzzeek has joined #openstack-cinder | 09:33 | |
| *** udesale_ has joined #openstack-cinder | 10:05 | |
| *** hamalq has quit IRC | 10:07 | |
| *** udesale has quit IRC | 10:08 | |
| *** zzzeek has quit IRC | 10:13 | |
| *** zzzeek has joined #openstack-cinder | 10:14 | |
| openstackgerrit | Lucian Petrut proposed openstack/os-brick master: Update requirements https://review.opendev.org/c/openstack/os-brick/+/766442 | 10:26 |
| *** zzzeek has quit IRC | 10:39 | |
| *** ociuhandu has joined #openstack-cinder | 10:40 | |
| *** zzzeek has joined #openstack-cinder | 10:41 | |
| *** ociuhandu has quit IRC | 10:54 | |
| *** rcernin has joined #openstack-cinder | 10:57 | |
| *** sumanshaw1 has joined #openstack-cinder | 11:04 | |
| *** hamalq has joined #openstack-cinder | 11:09 | |
| *** hamalq has quit IRC | 11:14 | |
| sumanshaw1 | geguileo: Hello | 11:17 |
| *** ociuhandu has joined #openstack-cinder | 12:02 | |
| *** ociuhandu has quit IRC | 12:03 | |
| *** ociuhandu has joined #openstack-cinder | 12:03 | |
| *** sumanshaw1 has quit IRC | 12:03 | |
| *** GirishChilukuri has joined #openstack-cinder | 12:13 | |
| *** rcernin has quit IRC | 12:13 | |
| *** zzzeek has quit IRC | 12:14 | |
| *** zzzeek has joined #openstack-cinder | 12:17 | |
| *** ociuhandu has quit IRC | 12:23 | |
| *** lxkong has quit IRC | 12:26 | |
| *** hamalq has joined #openstack-cinder | 12:28 | |
| *** ociuhandu has joined #openstack-cinder | 12:31 | |
| *** hamalq has quit IRC | 12:33 | |
| *** TusharTgite has joined #openstack-cinder | 12:33 | |
| *** zzzeek has quit IRC | 12:40 | |
| *** GirishChilukuri has quit IRC | 12:40 | |
| *** zzzeek has joined #openstack-cinder | 12:41 | |
| *** baojg has quit IRC | 12:46 | |
| *** baojg has joined #openstack-cinder | 12:47 | |
| *** ociuhandu has quit IRC | 12:55 | |
| *** dave-mccowan has joined #openstack-cinder | 12:57 | |
| *** benfelin has joined #openstack-cinder | 12:59 | |
| *** rosmaita has joined #openstack-cinder | 13:04 | |
| *** ociuhandu has joined #openstack-cinder | 13:05 | |
| *** priteau has joined #openstack-cinder | 13:10 | |
| *** ociuhandu has quit IRC | 13:15 | |
| openstackgerrit | Lucian Petrut proposed openstack/os-brick master: Update requirements https://review.opendev.org/c/openstack/os-brick/+/766442 | 13:20 |
| *** hemna has quit IRC | 13:28 | |
| *** _pewp_ has quit IRC | 13:29 | |
| *** _pewp_ has joined #openstack-cinder | 13:30 | |
| *** hemna has joined #openstack-cinder | 13:31 | |
| *** zenkuro has quit IRC | 13:35 | |
| *** zenkuro has joined #openstack-cinder | 13:36 | |
| *** _erlon_ has joined #openstack-cinder | 13:50 | |
| *** zigo has joined #openstack-cinder | 13:51 | |
| *** ociuhandu has joined #openstack-cinder | 13:52 | |
| rosmaita | lpetrut: thank you!!! | 13:54 |
| lpetrut | rosmaita: no problem, I hope I got it right this time :) | 13:55 |
| lpetrut | rosmaita: we'll probably have to improve the tooling around lower constraints at some point | 13:56 |
| rosmaita | lpetrut: or eliminate them altogether -- i'm not sure what kind of value they are providing | 13:56 |
| rosmaita | (other than that they forced us to update all our requirements, some of which were extremely out of date) | 13:57 |
| lpetrut | I guess there's value in ensuring that both upper as well as the lower constraints work, otherwise the services might fail at runtime due to invalid dependencies | 13:58 |
| lpetrut | I'm not sure though if indirect dependencies should be set in the lower constraints file | 13:58 |
| lpetrut | the docs aren't very clear on that either | 13:59 |
| *** sapd1 has joined #openstack-cinder | 13:59 | |
| *** sapd1 has quit IRC | 14:00 | |
| rosmaita | yes, there was some discussion on that back when the lower-constraints job was introduced, but i don't remember the reasoning any more | 14:00 |
| *** sapd1 has joined #openstack-cinder | 14:01 | |
| *** enriquetaso has joined #openstack-cinder | 14:03 | |
| *** ociuhandu has quit IRC | 14:06 | |
| *** ociuhandu has joined #openstack-cinder | 14:09 | |
| *** ociuhandu has quit IRC | 14:13 | |
| *** ociuhandu has joined #openstack-cinder | 14:15 | |
| *** ociuhandu has quit IRC | 14:19 | |
| *** psachin has quit IRC | 14:28 | |
| *** ociuhandu has joined #openstack-cinder | 14:28 | |
| *** hamalq has joined #openstack-cinder | 14:29 | |
| *** hamalq_ has joined #openstack-cinder | 14:32 | |
| *** hamalq has quit IRC | 14:34 | |
| *** hamalq_ has quit IRC | 14:36 | |
| *** tobberydberg has quit IRC | 14:38 | |
| *** tobberydberg has joined #openstack-cinder | 14:39 | |
| smcginnis | Yes, indirect dependencies should be there. The idea was to capture and constrain the whole set of dependencies that get installed to make sure we could convey an accurate description of the range of versions expected to work when packaged together. | 14:47 |
| rosmaita | smcginnis: i guess that means we should occasionally review the l-c file as some indirect dependencies are dropped & added? | 14:49 |
| rosmaita | is pip freeze on a testenv the best way to figure that out? | 14:49 |
| *** ociuhandu has quit IRC | 14:57 | |
| smcginnis | rosmaita: Yeah, I guess so. | 14:58 |
| smcginnis | Recognizing when to bump up an l-c is a little trickier. You need to pay attention to when something needs to be raised for a given feature. | 14:58 |
| smcginnis | But indirect dependencies and whether to clean out things is a fairly easy check I think. | 14:59 |
| rosmaita | well, i bumped them all the way up to our requirements minimums | 14:59 |
| smcginnis | You can do "tox -re lower-constraints --notest; .tox/lower-constraints/bin/pip freeze > logfile" and compare the contents of logfile with lower-constraints.txt. | 14:59 |
| rosmaita | some of them were 2-3 major versions behind | 15:00 |
| smcginnis | And that's after one or two patches to bring them at least sort of up to date. I'm sure the stable branch versions for something like train are probably pretty bad. | 15:01 |
| rosmaita | smcginnis: yeah, that's basically what i did | 15:01 |
| rosmaita | i can only imagine! | 15:01 |
| rosmaita | i haven't looked to see the state of our victoria gate | 15:01 |
| smcginnis | From the amount of emails I've been getting from nightly stable jobs, I think every stable branch is broken right now. | 15:02 |
| *** andrebeltrami has joined #openstack-cinder | 15:02 | |
| *** ociuhandu has joined #openstack-cinder | 15:05 | |
| *** e0ne has quit IRC | 15:07 | |
| *** e0ne has joined #openstack-cinder | 15:08 | |
| *** ociuhandu has quit IRC | 15:10 | |
| *** ociuhandu has joined #openstack-cinder | 15:11 | |
| e0ne | geguileo: hi Gorka. are you around? | 15:11 |
| geguileo | e0ne: yup, on a meeting, so slow response | 15:12 |
| e0ne | I'm curious how to reproduce this https://bugs.launchpad.net/cinder/+bug/1801958 issue | 15:13 |
| openstack | Launchpad bug 1801958 in Cinder "Service down and errors in log during image related operations" [Undecided,Fix released] - Assigned to Jay Bryant (jsbryant) | 15:13 |
| e0ne | geguileo: with your fix 8GB image download process takes 10 minutes instead of 2-3 | 15:14 |
| *** ociuhandu has quit IRC | 15:15 | |
| geguileo | e0ne: if we can fix the eventlet bug with logging we could get it down back to 2-3 | 15:15 |
| geguileo | e0ne: but we cannot log in a native thread from the pool :-( | 15:16 |
| geguileo | e0ne: I can't tell in which specific cases the I/O has the problem | 15:16 |
| geguileo | e0ne: I've seen it happen, and using native threads fix it | 15:17 |
| e0ne | geguileo: it's true, but your change doesn't do anything with logs. it spawns threads during file read/write | 15:17 |
| e0ne | geguileo: I can't reproduce the original issue now | 15:18 |
| geguileo | e0ne: I meant that if that bug didn't exist I wouldn't need to call tpool.execute for each _verify_image call | 15:18 |
| geguileo | e0ne: I could just run the whol verify_glance_image_signature method in a native pool | 15:18 |
| geguileo | s/pool/thread | 15:18 |
| geguileo | but if we call the whole verify_glance_image_signature in a native thread, it will eventually block and hang forever | 15:19 |
| geguileo | e0ne: if we could fix the logging issue we could improve Cinder's performance considerably :-( | 15:20 |
| *** ociuhandu has joined #openstack-cinder | 15:20 | |
| e0ne | geguileo: we're talking about different things | 15:21 |
| geguileo | e0ne: how so? | 15:22 |
| e0ne | geguileo: I agree with an issue with verify_glance_image_signature (I didn't verify it, but that sounds reasonable) | 15:22 |
| e0ne | geguileo: https://review.opendev.org/c/openstack/cinder/+/615934/2/cinder/image/image_utils.py - line #377 | 15:23 |
| e0ne | tpool.Proxy(image_file)) | 15:23 |
| e0ne | it will spawn a new thread each time we write image chunk to file | 15:23 |
| e0ne | and there is no logging in this call | 15:23 |
| geguileo | e0ne: same thing, if we could use logs on a native thread we would not need to proxy the object and we could just proxy the whole fetch | 15:24 |
| pots | Hi all. The Dell EMC PowerVault ME driver is passing CI and ready for reviews: https://review.opendev.org/c/openstack/cinder/+/758684. Should be an easy one as this is it just inherits all its classes from an existing driver. Thanks! | 15:25 |
| e0ne | geguileo: but why do we need to spawn process per each write call here https://github.com/openstack/cinder/blob/master/cinder/image/glance.py#L380-L381? | 15:25 |
| geguileo | e0ne: that needs to be called on a native thread to prevent it from blocking other greethreads | 15:26 |
| e0ne | why? | 15:26 |
| e0ne | eventlet should patch such I/O operations | 15:26 |
| geguileo | e0ne: because sometimes I/O calls don't switch | 15:26 |
| openstackgerrit | Walt proposed openstack/cinder master: Add ceph iscsi volume driver https://review.opendev.org/c/openstack/cinder/+/662829 | 15:27 |
| geguileo | e0ne: it should, but it some cases it doesn't seem to behave that way | 15:27 |
| geguileo | e0ne: which is the problem that patch tries to solve | 15:27 |
| e0ne | geguileo: do you know how to reproduce such issue? | 15:27 |
| geguileo | those weird cases | 15:27 |
| geguileo | e0ne: unfortunately no | 15:27 |
| e0ne | :( | 15:28 |
| geguileo | e0ne: I didn't like it, but that's why I had to write "in some cases block greenthreads" in the commit message and couldn't say which cases those were | 15:28 |
| geguileo | e0ne: iirc I think swift had found a way to work around the logging issue | 15:29 |
| e0ne | geguileo: it's very strange that evenlet blocks on such I/O tasks | 15:29 |
| e0ne | it's not related to logging | 15:30 |
| geguileo | e0ne: but if we can fix the problem of logging into a native thread when using greenthreads our performance issue would be resolved | 15:31 |
| hemna | rosmaita thanks for fixing the lower-constraints mess | 15:31 |
| e0ne | geguileo: actually, there is an issue with performance which coud be fixed now, I'll propose a patch | 15:31 |
| rosmaita | hemna: thanks for kicking off the process! | 15:31 |
| geguileo | e0ne: nice!! | 15:33 |
| *** TusharTgite has quit IRC | 15:43 | |
| *** sapd1 has quit IRC | 15:52 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Image download: do not write to file in a native thread https://review.opendev.org/c/openstack/cinder/+/766501 | 15:57 |
| e0ne | geguileo: here is it ^^^ | 15:57 |
| *** lpetrut has quit IRC | 15:57 | |
| geguileo | e0ne: I think we cannot do that... | 15:59 |
| e0ne | why? | 15:59 |
| geguileo | e0ne: because for RBD we will get a handle, which is handled by C code | 16:00 |
| geguileo | and it will block | 16:00 |
| geguileo | iirc | 16:00 |
| e0ne | rbd? | 16:00 |
| geguileo | os-brick's rbd connector returns a file handle, right? | 16:00 |
| geguileo | wait, maybe I'm mixing things | 16:01 |
| e0ne | no | 16:01 |
| *** sapd1 has joined #openstack-cinder | 16:01 | |
| geguileo | I'll have a better look at the patch | 16:01 |
| e0ne | it's two lines above | 16:01 |
| e0ne | thanks | 16:01 |
| * geguileo is still in the never-ending meeting | 16:01 | |
| *** sapd1 has quit IRC | 16:07 | |
| *** pcaruana has quit IRC | 16:10 | |
| tosky | geguileo: sorry :/ | 16:13 |
| *** e0ne has quit IRC | 16:28 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: mypy - cinder driver.py https://review.opendev.org/c/openstack/cinder/+/765810 | 16:29 |
| *** hamalq has joined #openstack-cinder | 16:30 | |
| *** ociuhandu has quit IRC | 16:31 | |
| *** ociuhandu has joined #openstack-cinder | 16:36 | |
| *** ociuhandu has quit IRC | 16:48 | |
| *** ociuhandu has joined #openstack-cinder | 16:53 | |
| *** ociuhandu_ has joined #openstack-cinder | 16:59 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Add cinder permissions matrix https://review.opendev.org/c/openstack/cinder/+/763306 | 17:00 |
| *** gksk has joined #openstack-cinder | 17:03 | |
| *** ociuhandu has quit IRC | 17:03 | |
| gksk | To the core reviewers please review the below feature related to revert to snapshot | 17:04 |
| gksk | https://review.opendev.org/c/openstack/cinder/+/751837 | 17:04 |
| *** sharathkacham has quit IRC | 17:05 | |
| geguileo | tosky: lol, not your fault, it's the job XD | 17:05 |
| *** manoj_kumar_kata has joined #openstack-cinder | 17:05 | |
| *** gksk has quit IRC | 17:09 | |
| *** dave-mccowan has quit IRC | 17:33 | |
| *** hamalq has quit IRC | 17:34 | |
| *** dave-mccowan has joined #openstack-cinder | 17:34 | |
| *** udesale_ has quit IRC | 17:34 | |
| *** dave-mccowan has quit IRC | 17:39 | |
| *** ociuhandu_ has quit IRC | 17:42 | |
| *** ociuhandu has joined #openstack-cinder | 17:54 | |
| *** ociuhandu has quit IRC | 17:58 | |
| *** hamalq has joined #openstack-cinder | 18:03 | |
| *** rpittau is now known as rpittau|afk | 18:04 | |
| *** hamalq_ has joined #openstack-cinder | 18:07 | |
| *** hamalq has quit IRC | 18:10 | |
| *** CeeMac has joined #openstack-cinder | 18:34 | |
| *** _pewp_ has quit IRC | 19:20 | |
| *** _pewp_ has joined #openstack-cinder | 19:21 | |
| *** _pewp_ has quit IRC | 19:31 | |
| *** _pewp_ has joined #openstack-cinder | 19:31 | |
| *** benfelin has quit IRC | 19:43 | |
| *** martinkennelly has quit IRC | 20:06 | |
| *** benfelin has joined #openstack-cinder | 20:07 | |
| *** martinkennelly has joined #openstack-cinder | 20:10 | |
| openstackgerrit | Rafael Weingartner proposed openstack/cinder master: Introduces MV to add volume type ID in volumes details https://review.opendev.org/c/openstack/cinder/+/666886 | 20:10 |
| *** martinkennelly has quit IRC | 20:19 | |
| *** amar7ibm_ has quit IRC | 20:20 | |
| *** rcernin has joined #openstack-cinder | 20:21 | |
| *** martinkennelly has joined #openstack-cinder | 20:27 | |
| openstackgerrit | Alan Bishop proposed openstack/python-cinderclient master: Update requirements and lower-constraints https://review.opendev.org/c/openstack/python-cinderclient/+/766544 | 20:43 |
| eharney | is "ERROR Failed to update project None in 5s" a known issue on our CI jobs? | 20:53 |
| eharney | has happened a few times on https://review.opendev.org/c/openstack/cinder/+/733621 | 20:53 |
| openstackgerrit | Alan Bishop proposed openstack/python-cinderclient master: Update requirements and lower-constraints https://review.opendev.org/c/openstack/python-cinderclient/+/766544 | 20:53 |
| clarkb | eharney: yes, the tldr is that at least one of the zuul executors failed to clone nova properly (due to timeouts that were too aggressive) which led it to being unable to configure jobs with nova in them | 20:53 |
| clarkb | eharney: we've since fixed that | 20:53 |
| eharney | clarkb: ahh ok, thanks | 20:53 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: annotate image/glance.py https://review.opendev.org/c/openstack/cinder/+/766064 | 21:00 |
| *** lxkong has joined #openstack-cinder | 21:02 | |
| openstackgerrit | Tom Barron proposed openstack/devstack-plugin-ceph master: Tweak ganesha repo cleanup https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/766550 | 21:13 |
| *** rcernin has quit IRC | 21:31 | |
| *** rcernin has joined #openstack-cinder | 21:34 | |
| *** eharney has quit IRC | 21:38 | |
| *** ociuhandu has joined #openstack-cinder | 21:40 | |
| *** rcernin has quit IRC | 21:51 | |
| *** rcernin has joined #openstack-cinder | 21:53 | |
| *** eharney has joined #openstack-cinder | 22:02 | |
| *** andrebeltrami has quit IRC | 22:11 | |
| *** rosmaita has left #openstack-cinder | 22:13 | |
| *** enriquetaso has quit IRC | 22:39 | |
| *** martinkennelly has quit IRC | 22:48 | |
| *** ociuhandu has quit IRC | 22:59 | |
| openstackgerrit | Alan Bishop proposed openstack/python-cinderclient master: Update requirements and lower-constraints https://review.opendev.org/c/openstack/python-cinderclient/+/766544 | 23:00 |
| *** smcginnis has quit IRC | 23:16 | |
| *** baojg has quit IRC | 23:22 | |
| *** baojg has joined #openstack-cinder | 23:25 | |
| *** smcginnis has joined #openstack-cinder | 23:42 | |
| *** ChanServ sets mode: +o smcginnis | 23:42 | |
| *** smcginnis has quit IRC | 23:49 | |
| openstackgerrit | Sam Morrison proposed openstack/cinder master: Make availability zone type exception easier to understand. https://review.opendev.org/c/openstack/cinder/+/764875 | 23:51 |
| *** baojg has quit IRC | 23:52 | |
| *** baojg has joined #openstack-cinder | 23:53 | |
| *** tosky has quit IRC | 23:53 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!