Friday, 2020-11-13

*** martinkennelly has joined #openstack-cinder00:13
*** rouk has quit IRC00:20
*** rcernin has quit IRC00:42
*** rcernin has joined #openstack-cinder00:43
*** zenkuro has quit IRC01:03
openstackgerritwu.shiming proposed openstack/cinder master: Replace deprecated UPPER_CONSTRAINTS_FILE variable  https://review.opendev.org/76260001:07
*** martinkennelly has quit IRC01:26
*** spatel has joined #openstack-cinder01:37
*** spatel has quit IRC01:42
*** rcernin has quit IRC01:58
*** tinwood has quit IRC02:10
*** tinwood has joined #openstack-cinder02:13
*** rcernin has joined #openstack-cinder02:57
*** benfelin has quit IRC03:09
*** rcernin has quit IRC03:38
*** rcernin has joined #openstack-cinder04:05
*** udesale has joined #openstack-cinder04:40
*** thonic has quit IRC04:47
*** psachin has joined #openstack-cinder04:52
*** ajitha has joined #openstack-cinder04:52
*** sorrison has joined #openstack-cinder04:57
*** rm_work has quit IRC04:58
*** rm_work has joined #openstack-cinder04:58
*** zzzeek has quit IRC05:34
*** baojg has quit IRC05:34
*** baojg has joined #openstack-cinder05:35
*** zzzeek has joined #openstack-cinder05:36
*** thonic has joined #openstack-cinder05:36
*** rcernin has quit IRC05:39
*** ociuhandu has joined #openstack-cinder05:40
*** rcernin has joined #openstack-cinder05:42
*** ociuhandu has quit IRC06:00
openstackgerritMerged openstack/cinder stable/train: NEC driver: fix a snapshot detach error  https://review.opendev.org/75660906:07
*** tosky has joined #openstack-cinder06:24
*** elod has joined #openstack-cinder06:45
*** rcernin_ has joined #openstack-cinder06:53
*** rcernin has quit IRC06:54
*** rcernin_ has quit IRC06:59
*** ociuhandu has joined #openstack-cinder07:13
*** ociuhandu has quit IRC07:13
*** ociuhandu has joined #openstack-cinder07:14
*** ociuhandu has quit IRC07:17
*** rpittau|afk is now known as rpittau07:20
*** zenkuro has joined #openstack-cinder07:20
*** pcaruana has joined #openstack-cinder07:52
*** tkajinam has quit IRC08:08
*** tkajinam has joined #openstack-cinder08:12
*** zenkuro has quit IRC08:21
*** zenkuro has joined #openstack-cinder08:21
*** udesale_ has joined #openstack-cinder08:25
*** udesale has quit IRC08:28
*** zenkuro has quit IRC08:29
*** zenkuro has joined #openstack-cinder08:29
*** CeeMac has joined #openstack-cinder08:55
*** ociuhandu has joined #openstack-cinder08:58
*** thonic has quit IRC08:59
*** ociuhandu has quit IRC09:08
*** JaySee has quit IRC09:21
*** jawad_axd has joined #openstack-cinder09:22
*** kaisers has joined #openstack-cinder09:27
*** martinkennelly has joined #openstack-cinder09:39
*** ociuhandu has joined #openstack-cinder09:48
*** whoami-rajat__ has quit IRC09:48
*** thonic has joined #openstack-cinder09:54
*** ociuhandu has quit IRC09:58
*** benfelin has joined #openstack-cinder10:00
*** thonic has quit IRC10:11
*** baojg has quit IRC10:15
*** brinzhang_ has quit IRC10:16
*** michael-mcaleer has joined #openstack-cinder10:20
*** dsariel has quit IRC10:28
*** icey has quit IRC10:30
*** sfernand has joined #openstack-cinder10:35
*** icey has joined #openstack-cinder10:36
*** n-saito has quit IRC10:48
*** jawad_axd has quit IRC11:01
*** ociuhandu has joined #openstack-cinder11:03
*** ociuhandu has quit IRC11:27
openstackgerritSharath Kacham proposed openstack/cinder master: [SVF]:Fix in change_vdisk_iogrp during retype  https://review.opendev.org/75524111:29
*** zenkuro has quit IRC11:31
*** zenkuro has joined #openstack-cinder11:32
*** takamatsu has quit IRC11:33
*** takamatsu has joined #openstack-cinder11:33
*** e0ne has joined #openstack-cinder11:35
*** dsariel has joined #openstack-cinder11:36
*** sharathkacham has joined #openstack-cinder11:39
*** zenkuro has quit IRC11:41
*** ociuhandu has joined #openstack-cinder11:44
*** dsariel has quit IRC11:48
*** GirishChilukuri has joined #openstack-cinder11:54
*** baojg has joined #openstack-cinder12:03
*** udesale__ has joined #openstack-cinder12:26
*** udesale_ has quit IRC12:29
*** sharathkacham has quit IRC12:44
*** sfernand has quit IRC12:44
*** digvijay has joined #openstack-cinder13:14
*** ociuhandu_ has joined #openstack-cinder13:21
*** ociuhandu has quit IRC13:25
*** sfernand has joined #openstack-cinder13:25
*** udesale_ has joined #openstack-cinder13:29
*** udesale__ has quit IRC13:32
hemnamep13:35
*** digvijay has quit IRC13:35
*** martinkennelly has quit IRC13:41
sfernandrosmaita if you have time please take a look at the changes I’ve made to address your comments https://review.opendev.org/#/c/756184/13:52
rosmaitasfernand: acl13:52
rosmaitai mean, "ack"13:52
rosmaita:)13:52
sfernand:)13:52
*** venkatakrishnath has joined #openstack-cinder13:57
*** baojg has quit IRC13:58
*** baojg has joined #openstack-cinder13:59
*** michael-mcaleer has quit IRC14:39
*** ociuhandu_ has quit IRC14:42
*** dsariel has joined #openstack-cinder14:42
*** ociuhandu has joined #openstack-cinder14:43
*** lpetrut has joined #openstack-cinder14:49
*** rpittau is now known as rpittau|afk14:49
*** hemna has quit IRC14:50
*** hemna has joined #openstack-cinder14:51
openstackgerritBrian Rosmaita proposed openstack/cinder master: doc: restrict supported Ceph versions  https://review.opendev.org/76259215:05
*** ociuhandu has quit IRC15:06
venkatakrishnath@core reviewers, please review https://review.opendev.org/#/c/75708215:08
*** ociuhandu has joined #openstack-cinder15:08
*** lpetrut has quit IRC15:12
*** udesale_ has quit IRC15:22
*** udesale__ has joined #openstack-cinder15:22
*** ociuhandu has quit IRC15:24
*** ianychoi has joined #openstack-cinder15:30
*** ajitha has quit IRC15:52
*** udesale__ has quit IRC15:52
hemnashould we add @utils.trace to every driver's volume manager -> driver API interface ?15:54
hemnasure would be nice to have that on every driver15:54
hemnamaybe not get_volume_stats15:56
hemnathen again that's handy when debugging as well15:56
eharneydo we have docs on what people are using that for?  i'm aware of it vaguely but have never really looked into it15:56
hemnait's very handy15:56
hemnait basically outputs the entry into the function, all of it's params, as well as the return of the function, how long it took and the return value.15:58
hemnait dumps only when debug mode is on15:59
hemna==> get_volume_stats: call "{'self': <cinder.volume.drivers.vmware.vmdk.VMwar16:00
hemna<== get_volume_stats: return (0ms) {'volume_backend_name': 'vmware_silver',16:00
eharneyseems like it should be done from the manager rather than adding it in driver code16:01
hemnato make it universal yah16:01
*** ociuhandu has joined #openstack-cinder16:02
hemnawould be nice if debug wansn't enabled, that it would just print out the call and the return with timing but w/o params16:03
hemnamaybe that's too much16:03
*** ociuhandu has quit IRC16:09
*** pcaruana has quit IRC16:09
smcginnisMaybe introduce another config option to just enable that?16:10
*** takamatsu has quit IRC16:15
clarkbhemna: is that the decorator that does profiling for calls under it? If so we had to disbale some neutron log indexing for using it16:16
clarkbit explodes the size of the logs if you get it on a function that is called often16:16
hemnait's not profiling16:18
hemnajust a debug level only entry point w/ params and exit point with timing and return value16:18
hemnaI rely on it for tracking down problems in production16:19
hemnaand dev for that matter16:19
clarkbutils.timecost() is what neutron did16:19
clarkbwhich I thought was from oslo but maybe not16:21
clarkbanyway just a warning that profiling at all times with output to debug logs hasbeenn a problem in some cases16:21
smcginnisLooks like that's something they did in neutron itself: https://opendev.org/openstack/neutron/src/branch/master/neutron/common/utils.py#L97816:22
hemnayah it's not profiling16:22
smcginnisBut they are using timeutils from oslo.utils16:23
*** baojg has quit IRC16:28
*** baojg has joined #openstack-cinder16:30
*** digvijay has joined #openstack-cinder16:31
*** jdillaman has quit IRC16:38
*** takamatsu has joined #openstack-cinder16:46
*** ociuhandu has joined #openstack-cinder16:51
*** hemna has quit IRC16:58
*** hemna has joined #openstack-cinder16:59
*** digvijay has quit IRC17:04
*** hemna has quit IRC17:08
*** hemna has joined #openstack-cinder17:09
*** ociuhandu_ has joined #openstack-cinder17:15
*** ociuhandu has quit IRC17:17
*** ociuhandu_ has quit IRC17:19
*** ociuhandu has joined #openstack-cinder17:26
*** ociuhandu has quit IRC17:31
*** e0ne has quit IRC17:36
*** venkatakrishnath has quit IRC17:42
*** psachin has quit IRC17:44
*** sfernand has quit IRC19:24
*** lifeless has quit IRC19:31
*** lifeless has joined #openstack-cinder19:47
openstackgerritAde Lee proposed openstack/cinder master: Replace md5 with oslo version  https://review.opendev.org/75384821:01
*** ociuhandu has joined #openstack-cinder21:19
*** rcernin has joined #openstack-cinder21:19
*** ociuhandu has quit IRC21:45
*** jmlowe has quit IRC21:49
*** hamalq has joined #openstack-cinder22:30
openstackgerritBrian Rosmaita proposed openstack/cinder master: Add intersphinx support for release notes  https://review.opendev.org/76272022:51
*** hemna has quit IRC23:19
*** hemna has joined #openstack-cinder23:20
*** hamalq has quit IRC23:37
*** hamalq has joined #openstack-cinder23:38
*** tosky has quit IRC23:43

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!