| *** vishakha has quit IRC | 00:02 | |
| *** hamalq_ has quit IRC | 00:05 | |
| *** deiter has quit IRC | 00:19 | |
| *** rcernin has quit IRC | 00:34 | |
| *** rcernin has joined #openstack-cinder | 00:39 | |
| *** zhanglong has joined #openstack-cinder | 01:01 | |
| *** Lucas_Gray has quit IRC | 01:04 | |
| *** Liang__ has joined #openstack-cinder | 01:10 | |
| *** yaawang has quit IRC | 01:33 | |
| *** yaawang has joined #openstack-cinder | 01:33 | |
| *** yaawang has quit IRC | 01:59 | |
| *** yaawang has joined #openstack-cinder | 02:02 | |
| *** markvoelker has joined #openstack-cinder | 02:13 | |
| *** markvoelker has quit IRC | 02:18 | |
| *** zhanglong has quit IRC | 02:21 | |
| *** zhanglong has joined #openstack-cinder | 02:22 | |
| *** sapd__x has joined #openstack-cinder | 02:23 | |
| *** zhanglong has quit IRC | 02:39 | |
| *** zhanglong has joined #openstack-cinder | 02:41 | |
| *** psachin has joined #openstack-cinder | 03:37 | |
| *** zhanglong has quit IRC | 03:47 | |
| *** markvoelker has joined #openstack-cinder | 03:48 | |
| *** markvoelker has quit IRC | 03:53 | |
| *** vishalmanchanda has joined #openstack-cinder | 04:01 | |
| openstackgerrit | Xinliang Liu proposed openstack/cinder master: Add ceph-iscsci CI job https://review.opendev.org/667108 | 04:18 |
|---|---|---|
| *** rcernin has quit IRC | 04:47 | |
| *** Liang__ has quit IRC | 04:54 | |
| *** KeithMnemonic has quit IRC | 04:55 | |
| *** Liang__ has joined #openstack-cinder | 04:55 | |
| *** rcernin has joined #openstack-cinder | 04:57 | |
| *** rcernin has quit IRC | 04:57 | |
| *** udesale has joined #openstack-cinder | 04:57 | |
| *** rcernin has joined #openstack-cinder | 04:57 | |
| *** Liang__ has quit IRC | 05:01 | |
| *** Liang__ has joined #openstack-cinder | 05:02 | |
| *** yaawang has quit IRC | 05:04 | |
| *** yaawang has joined #openstack-cinder | 05:05 | |
| *** rcernin has quit IRC | 05:12 | |
| *** suryasingh has joined #openstack-cinder | 05:18 | |
| *** rcernin has joined #openstack-cinder | 05:19 | |
| *** zhanglong has joined #openstack-cinder | 05:44 | |
| *** yaawang has quit IRC | 05:45 | |
| *** yaawang has joined #openstack-cinder | 05:46 | |
| *** Liang__ has quit IRC | 05:47 | |
| *** Liang__ has joined #openstack-cinder | 05:48 | |
| *** markvoelker has joined #openstack-cinder | 05:49 | |
| *** markvoelker has quit IRC | 05:54 | |
| openstackgerrit | futaotao proposed openstack/cinder master: Due to Fusionstorage rename to OceanStor 100D, there is a necessary to support OceanStor 100D with Fusionstorage Cinder Driver.(dsware) https://review.opendev.org/741579 | 06:16 |
| *** baojg has quit IRC | 06:18 | |
| *** rcernin has quit IRC | 06:19 | |
| *** baojg has joined #openstack-cinder | 06:19 | |
| *** rcernin has joined #openstack-cinder | 06:32 | |
| *** yaawang has quit IRC | 06:32 | |
| *** yaawang has joined #openstack-cinder | 06:33 | |
| openstackgerrit | futaotao proposed openstack/cinder master: Due to Fusionstorage rename to OceanStor 100D, there is a necessary to support OceanStor 100D with Fusionstorage Cinder Driver.(dsware) https://review.opendev.org/741579 | 06:36 |
| openstackgerrit | futaotao proposed openstack/cinder master: Fusionstorage Cinder Driver Support OceanStor 100D Storage.(dsware) https://review.opendev.org/741579 | 06:39 |
| *** rcernin has quit IRC | 06:46 | |
| *** rcernin has joined #openstack-cinder | 06:52 | |
| *** zhanglong has quit IRC | 07:04 | |
| *** yaawang has quit IRC | 07:04 | |
| *** yaawang has joined #openstack-cinder | 07:05 | |
| *** zhanglong has joined #openstack-cinder | 07:05 | |
| *** rcernin has quit IRC | 07:06 | |
| *** udesale has quit IRC | 07:17 | |
| *** deiter has joined #openstack-cinder | 07:21 | |
| *** Liang__ has quit IRC | 07:25 | |
| *** brinzhang0 has joined #openstack-cinder | 07:26 | |
| *** brinzhang_ has quit IRC | 07:29 | |
| *** tosky has joined #openstack-cinder | 07:33 | |
| *** rcernin has joined #openstack-cinder | 07:34 | |
| *** rcernin has quit IRC | 07:42 | |
| *** rcernin has joined #openstack-cinder | 07:46 | |
| openstackgerrit | Luigi Toscano proposed openstack/cinder stable/ussuri: zuul: collect cinderlib logs from tempest node(s) only https://review.opendev.org/741591 | 07:46 |
| *** baojg has quit IRC | 07:47 | |
| *** zhanglong has quit IRC | 07:50 | |
| *** rcernin has quit IRC | 07:50 | |
| *** zhanglong has joined #openstack-cinder | 07:51 | |
| *** udesale has joined #openstack-cinder | 07:57 | |
| *** brinzhang_ has joined #openstack-cinder | 07:59 | |
| *** brinzhang0 has quit IRC | 08:02 | |
| *** Lucas_Gray has joined #openstack-cinder | 08:03 | |
| *** ociuhandu has joined #openstack-cinder | 08:08 | |
| *** baojg has joined #openstack-cinder | 08:10 | |
| openstackgerrit | Naoki Saito proposed openstack/cinder master: NEC driver: fix a snapshot detach error https://review.opendev.org/741597 | 08:11 |
| *** brinzhang0 has joined #openstack-cinder | 08:47 | |
| *** spatel has joined #openstack-cinder | 08:49 | |
| *** brinzhang_ has quit IRC | 08:49 | |
| openstackgerrit | Naoki Saito proposed openstack/cinder master: NEC driver: fix live-migration failure with FC https://review.opendev.org/741602 | 08:51 |
| *** spatel has quit IRC | 08:53 | |
| *** zhanglong has quit IRC | 09:04 | |
| *** zhanglong has joined #openstack-cinder | 09:05 | |
| *** brinzhang_ has joined #openstack-cinder | 09:09 | |
| *** brinzhang0 has quit IRC | 09:12 | |
| *** sapd__x has quit IRC | 09:12 | |
| *** martinkennelly has joined #openstack-cinder | 09:14 | |
| *** zhanglong has quit IRC | 09:14 | |
| *** zhanglong has joined #openstack-cinder | 09:17 | |
| *** sapd1 has joined #openstack-cinder | 09:18 | |
| *** martinkennelly has quit IRC | 09:19 | |
| *** rcernin has joined #openstack-cinder | 09:29 | |
| *** zhanglong has quit IRC | 09:30 | |
| *** zhanglong has joined #openstack-cinder | 09:31 | |
| *** Liang__ has joined #openstack-cinder | 09:36 | |
| *** Liang__ has quit IRC | 09:41 | |
| *** raghavendrat has joined #openstack-cinder | 09:42 | |
| raghavendrat | hi geguileo: are you online ? | 09:45 |
| geguileo | raghavendrat: hi | 09:45 |
| raghavendrat | this is regarding backport of "Kaminario: Fix unique_fqdn_network option" | 09:46 |
| raghavendrat | https://review.opendev.org/#/c/741428/ | 09:47 |
| raghavendrat | whenever you have time, it would be great if you can have a look. Thanks. | 09:47 |
| geguileo | ok | 09:47 |
| *** rcernin has quit IRC | 09:48 | |
| *** baojg has quit IRC | 09:49 | |
| *** tkajinam has quit IRC | 09:52 | |
| *** e0ne has joined #openstack-cinder | 09:53 | |
| *** udesale_ has joined #openstack-cinder | 10:01 | |
| *** yaawang has quit IRC | 10:02 | |
| *** zhanglong has quit IRC | 10:02 | |
| *** zhanglong has joined #openstack-cinder | 10:03 | |
| *** udesale has quit IRC | 10:04 | |
| *** yaawang has joined #openstack-cinder | 10:04 | |
| *** yaawang has quit IRC | 10:14 | |
| *** zhanglong has quit IRC | 10:15 | |
| *** yaawang has joined #openstack-cinder | 10:21 | |
| *** brinzhang0 has joined #openstack-cinder | 10:22 | |
| *** brinzhang_ has quit IRC | 10:25 | |
| *** brinzhang0 has quit IRC | 10:30 | |
| *** baojg has joined #openstack-cinder | 10:56 | |
| *** martinkennelly has joined #openstack-cinder | 10:57 | |
| *** sapd1 has quit IRC | 10:57 | |
| *** martinkennelly has quit IRC | 11:01 | |
| *** raghavendrat has quit IRC | 11:04 | |
| *** pcaruana has quit IRC | 11:33 | |
| *** pcaruana has joined #openstack-cinder | 11:44 | |
| *** raghavendrat has joined #openstack-cinder | 12:05 | |
| *** vishakha has joined #openstack-cinder | 12:11 | |
| *** baojg has quit IRC | 12:35 | |
| *** raghavendrat has quit IRC | 12:46 | |
| rosmaita | whoami-rajat: left a response for you on https://review.opendev.org/#/c/733555/ | 12:48 |
| *** spatel has joined #openstack-cinder | 12:50 | |
| *** spatel has quit IRC | 12:55 | |
| openstackgerrit | Ivan Pchelintsev proposed openstack/cinder master: Add Cinder driver for Dell EMC PowerStore https://review.opendev.org/741158 | 13:14 |
| *** Lucas_Gray has quit IRC | 13:25 | |
| *** Lucas_Gray has joined #openstack-cinder | 13:29 | |
| whoami-rajat__ | rosmaita: yep saw it, so for volume create, the response cannot be changed now right? | 13:30 |
| rosmaita | no, i don't think so | 13:31 |
| rosmaita | i guess we could microversion it, but i don't see the point | 13:31 |
| rosmaita | so 2 ways to look at this: return 404 to be consistent but wrong, or return 409 and be inconsistent, but with the idea that (a) this has its own microversion, and (b) it's got a different URL structure /v3/resource vs /v3/{project_id}/resource, so you could arguably expect it to behave differently | 13:31 |
| whoami-rajat__ | yeah, it's been like that since a long time | 13:31 |
| rosmaita | that's why i'm being a PITA about this ... we will be stuck with whatever we come up with for eternity | 13:32 |
| whoami-rajat__ | rosmaita: i think for project id not accessible, we've HTTPUnauthorized or HTTPForbidden | 13:35 |
| rosmaita | yes, but this new api is a bit different because of where the project_id occurs in the URL | 13:36 |
| rosmaita | i mean, if you make the policies admin-only, then a non admin will get 401 if keystone doesn't validate the request token, or 403 if the token is OK but the policy rejects the request | 13:38 |
| rosmaita | so you can still get Unauthorized or Forbidden | 13:38 |
| rosmaita | in this case, an admin passes the token and policy checks, and then the only issue left is whether the project_id in /v3/default-types/{project_id} matches an existing project | 13:39 |
| whoami-rajat__ | rosmaita: hmm, but in both cases a project id is being validated, first it's the context and second it's the passed project_id | 13:41 |
| rosmaita | well, the way to look at this is what is the response telling me to do? 401 - i need to get a new token, 403 - i need to contact someone about getting my permissions elevated, 404 - resource described in the URL is not found | 13:43 |
| whoami-rajat__ | rosmaita: so if the user doesn't has access to the requested project, keystone sends a unauthorized back, what should we do in this case? and if the context project isn't a parent or root of the given project_id then the response is forbidden, what to do there | 13:43 |
| whoami-rajat__ | 404 is correct | 13:44 |
| whoami-rajat__ | but for this case, i'm not sure about 401 and 403 | 13:44 |
| whoami-rajat__ | because we've 2 validations here | 13:44 |
| rosmaita | those are handled by the middleware and policies | 13:44 |
| whoami-rajat__ | rosmaita: i'm talking about the code part | 13:45 |
| whoami-rajat__ | the target project validation | 13:46 |
| rosmaita | so you mean the project_id in /v3/default-types/{project_id} ? | 13:46 |
| whoami-rajat__ | yep | 13:46 |
| whoami-rajat__ | https://review.opendev.org/#/c/737707/5/cinder/api/v3/default_types.py | 13:46 |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax Driver - sync_check_snapshot_delete_fix https://review.opendev.org/741639 | 13:47 |
| whoami-rajat__ | rosmaita: one thing i want to mention, geguileo has enough details mentioned on the spec that i usually don't see in specs, is there a possibility to merge that and finalize the discussion on the implementation? | 13:49 |
| whoami-rajat__ | i mean we can't expect the specs to have 100% detail about the implementation, it already has a lot | 13:51 |
| rosmaita | geguileo wrote a great spec, but as far as API changes go, we need to know exactly how they are defined | 13:51 |
| rosmaita | i'm not arguing about how it gets implemented, i'm arguing about what the API should be like | 13:51 |
| whoami-rajat__ | yep i agree | 13:53 |
| rosmaita | if we don't get this settled up front, then you wind up with the weirdnesses that we currently have | 13:53 |
| whoami-rajat__ | that's also true, it's an important part since it's a unique one | 13:54 |
| rosmaita | but to answer your earlier question, once the policy check is done, i think you can assume that the caller is authorized to set a default-type | 13:55 |
| rosmaita | so then it's just a matter of does that project_id exist in keystone or not | 13:55 |
| *** tobias-urdin is now known as tobias-urdin|pto | 13:55 | |
| whoami-rajat__ | rosmaita: there are a lot of cases in that | 13:56 |
| whoami-rajat__ | rosmaita: the policy can be changed and can be set to non-admins as well, so the keystone project get command can fail | 13:56 |
| whoami-rajat__ | rosmaita: if the user is admin, does it has access to the target project | 13:57 |
| whoami-rajat__ | rosmaita: does the target project come under the hierarchy of the context project | 13:57 |
| whoami-rajat__ | i think the second one might be not a case | 13:58 |
| whoami-rajat__ | but the other 2 are valid cases | 13:58 |
| rosmaita | whoami-rajat__: ok, so what are the open questions at this point? | 14:02 |
| whoami-rajat__ | rosmaita: the question is, there are total 2 validations for 401 and 403, two are done by the middleware and two are done inside the API code | 14:07 |
| whoami-rajat__ | rosmaita: so we should respond with the same error codes, we can have different messages for both cases | 14:07 |
| whoami-rajat__ | rosmaita: or should we handle the second case and return a different response | 14:08 |
| rosmaita | i think you don't need to worry about 401 internally, because at that point you have an authenticated user | 14:08 |
| rosmaita | only question is are they authorized | 14:09 |
| rosmaita | but i also think you need to check the extent to which that juno spec was implemented in keystone | 14:09 |
| whoami-rajat__ | rosmaita: i think i can note down all the possible cases in an etherpad, then we can discuss on that? | 14:11 |
| rosmaita | that would be helpful | 14:11 |
| whoami-rajat__ | ok | 14:11 |
| whoami-rajat__ | rosmaita: basic cases i've added here, please add any case which i missed https://etherpad.opendev.org/p/default_type_overrides | 14:21 |
| rosmaita | will do, thanks | 14:21 |
| *** baojg has joined #openstack-cinder | 14:27 | |
| *** enriquetaso has joined #openstack-cinder | 14:47 | |
| *** pcaruana has quit IRC | 14:58 | |
| *** Lucas_Gray has quit IRC | 15:03 | |
| *** pcaruana has joined #openstack-cinder | 15:11 | |
| *** Lucas_Gray has joined #openstack-cinder | 15:13 | |
| *** ociuhandu_ has joined #openstack-cinder | 15:20 | |
| *** ociuhandu has quit IRC | 15:24 | |
| *** ociuhandu_ has quit IRC | 15:24 | |
| *** udesale_ has quit IRC | 15:37 | |
| *** hamalq has joined #openstack-cinder | 15:45 | |
| *** hamalq_ has joined #openstack-cinder | 15:47 | |
| *** hamalq has quit IRC | 15:50 | |
| *** laurent\ has quit IRC | 15:51 | |
| hemna | rosmaita, smcginnis so since the ceph-iscsi driver seems be working and we are trying to get it to land in cinder, should we also make the rest client I wrote, another cinder project in gerrit? | 15:51 |
| hemna | https://github.com/hemna/rbd-iscsi-client | 15:51 |
| hemna | that one | 15:51 |
| smcginnis | I wonder long term if that makes sense for this team to own, or if it would be better to keep that separate. | 15:51 |
| hemna | the ceph-iscsi driver uses it to talk to the rbd-target-api | 15:51 |
| rosmaita | hemna: in a meeting, will look later | 15:52 |
| hemna | the downside to keeping it where it is, is doing fixes/updates to it. | 15:52 |
| hemna | I guess we can always pull that in under the cinder umbrella whenever. | 15:52 |
| smcginnis | Would the ceph community want to adopt that? Seems like something they would want to help promote. | 15:53 |
| hemna | I would hope so, I even point it out in several issues I filed against ceph-iscsi | 15:54 |
| hemna | I wouldn't be opposed to it, but we would still need to be able to make fixes, etc | 15:54 |
| hemna | anyway, food for thought. | 15:55 |
| smcginnis | Yeah, probably good to get a good home for it. | 15:56 |
| *** psachin has quit IRC | 16:00 | |
| *** e0ne has quit IRC | 16:02 | |
| *** martinkennelly has joined #openstack-cinder | 16:06 | |
| *** kklimonda has quit IRC | 16:20 | |
| *** kklimonda has joined #openstack-cinder | 16:20 | |
| *** laurent\ has joined #openstack-cinder | 16:29 | |
| *** xyang has quit IRC | 16:50 | |
| *** xyang has joined #openstack-cinder | 16:51 | |
| *** Lucas_Gray has quit IRC | 16:56 | |
| *** markvoelker has joined #openstack-cinder | 16:59 | |
| *** vishalmanchanda has quit IRC | 17:20 | |
| *** andrebeltrami has joined #openstack-cinder | 17:27 | |
| *** martinkennelly has quit IRC | 17:52 | |
| *** NobodyCam has quit IRC | 18:12 | |
| *** NobodyCam has joined #openstack-cinder | 18:12 | |
| *** TheJulia has quit IRC | 18:22 | |
| *** TheJulia has joined #openstack-cinder | 18:23 | |
| *** johnsom has quit IRC | 18:24 | |
| *** johnsom has joined #openstack-cinder | 18:24 | |
| *** sonivi has joined #openstack-cinder | 18:48 | |
| *** baojg has quit IRC | 18:56 | |
| *** baojg has joined #openstack-cinder | 18:57 | |
| *** masayukig has quit IRC | 18:58 | |
| *** masayukig has joined #openstack-cinder | 18:59 | |
| openstackgerrit | Merged openstack/cinder stable/train: Disable siblings for the cinderlib functional tests https://review.opendev.org/740263 | 19:30 |
| *** sonivi has quit IRC | 19:40 | |
| openstackgerrit | Rajini Karthik proposed openstack/cinder master: Rebranding of VxFlex OS driver to PowerFlex https://review.opendev.org/740522 | 19:51 |
| *** geguileo has quit IRC | 19:54 | |
| *** geguileo has joined #openstack-cinder | 19:55 | |
| *** hemna has quit IRC | 19:59 | |
| *** hemna has joined #openstack-cinder | 19:59 | |
| *** Lucas_Gray has joined #openstack-cinder | 20:11 | |
| *** jv_ has quit IRC | 20:22 | |
| *** spatel has joined #openstack-cinder | 20:34 | |
| *** spatel has quit IRC | 20:34 | |
| *** markvoelker has quit IRC | 20:42 | |
| *** vishakha has quit IRC | 20:48 | |
| openstackgerrit | Merged openstack/cinder stable/ussuri: Kaminario: Fix unique_fqdn_network option https://review.opendev.org/741428 | 20:59 |
| *** baojg has quit IRC | 21:12 | |
| *** baojg has joined #openstack-cinder | 21:21 | |
| *** hamalq has joined #openstack-cinder | 21:28 | |
| *** hamalq_ has quit IRC | 21:31 | |
| *** baojg has quit IRC | 21:34 | |
| *** baojg has joined #openstack-cinder | 21:35 | |
| *** melwitt is now known as jgwentworth | 21:49 | |
| *** deiter has quit IRC | 22:14 | |
| *** baojg has quit IRC | 22:15 | |
| *** baojg has joined #openstack-cinder | 22:17 | |
| *** markvoelker has joined #openstack-cinder | 22:22 | |
| *** markvoelker has quit IRC | 22:27 | |
| *** ociuhandu has joined #openstack-cinder | 22:39 | |
| *** ociuhandu has quit IRC | 22:44 | |
| *** deiter has joined #openstack-cinder | 22:46 | |
| *** markvoelker has joined #openstack-cinder | 22:47 | |
| *** markvoelker has quit IRC | 22:52 | |
| *** tosky_ has joined #openstack-cinder | 22:52 | |
| *** tosky has quit IRC | 22:53 | |
| *** tosky_ is now known as tosky | 23:01 | |
| *** deiter has quit IRC | 23:15 | |
| *** andrebeltrami has quit IRC | 23:37 | |
| *** tosky has quit IRC | 23:38 | |
| *** hamalq has quit IRC | 23:38 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!