| *** rmcall has quit IRC | 00:06 | |
| *** knomura has joined #openstack-cinder | 00:54 | |
| *** akrog has joined #openstack-cinder | 00:58 | |
| *** geguileo has quit IRC | 00:58 | |
| *** knomura has quit IRC | 00:58 | |
| openstackgerrit | wanwencong proposed openstack/cinder master: Avoid rbd import operation to reduce encryption volume creation time https://review.opendev.org/740931 | 01:29 |
|---|---|---|
| *** xinliang has joined #openstack-cinder | 01:32 | |
| *** spatel has joined #openstack-cinder | 02:10 | |
| *** sapd__x has joined #openstack-cinder | 02:20 | |
| *** rmcall has joined #openstack-cinder | 02:31 | |
| *** spatel has quit IRC | 02:49 | |
| *** rcernin has quit IRC | 02:56 | |
| *** rcernin has joined #openstack-cinder | 02:57 | |
| *** ociuhandu has joined #openstack-cinder | 03:01 | |
| *** ociuhandu has quit IRC | 03:06 | |
| *** brinzhang0 has joined #openstack-cinder | 03:15 | |
| openstackgerrit | Merged openstack/cinder stable/stein: PowerMax Driver - Snapshot restore payload fix https://review.opendev.org/738474 | 03:17 |
| *** brinzhang_ has quit IRC | 03:18 | |
| *** brinzhang has joined #openstack-cinder | 03:19 | |
| *** spatel has joined #openstack-cinder | 03:22 | |
| *** spatel has quit IRC | 03:22 | |
| *** brinzhang0 has quit IRC | 03:22 | |
| *** spatel has joined #openstack-cinder | 03:23 | |
| *** spatel has quit IRC | 03:23 | |
| *** spatel has joined #openstack-cinder | 03:30 | |
| *** spatel has quit IRC | 03:30 | |
| *** redrobot has quit IRC | 03:36 | |
| *** psachin has joined #openstack-cinder | 03:38 | |
| *** brinzhang_ has joined #openstack-cinder | 03:41 | |
| *** brinzhang has quit IRC | 03:44 | |
| *** xinliang has quit IRC | 04:01 | |
| *** brinzhang0 has joined #openstack-cinder | 04:03 | |
| *** brinzhang_ has quit IRC | 04:05 | |
| *** yaawang has quit IRC | 04:10 | |
| *** markvoelker has joined #openstack-cinder | 04:11 | |
| *** yaawang has joined #openstack-cinder | 04:11 | |
| *** sapd__x has quit IRC | 04:12 | |
| *** markvoelker has quit IRC | 04:15 | |
| openstackgerrit | Kazufumi Noto proposed openstack/cinder master: Support modern compression algorithms in cinder backup https://review.opendev.org/726765 | 04:27 |
| *** sonivi has joined #openstack-cinder | 04:35 | |
| *** vishalmanchanda has joined #openstack-cinder | 04:50 | |
| openstackgerrit | wanwencong proposed openstack/cinder master: Avoid rbd import operation to reduce encryption volume creation time https://review.opendev.org/740931 | 04:53 |
| *** sonivi has quit IRC | 04:58 | |
| *** sapd__x has joined #openstack-cinder | 04:58 | |
| *** markvoelker has joined #openstack-cinder | 05:01 | |
| *** markvoelker has quit IRC | 05:05 | |
| *** sonivi has joined #openstack-cinder | 05:15 | |
| *** raghavendrat has joined #openstack-cinder | 05:15 | |
| *** brinzhang_ has joined #openstack-cinder | 05:16 | |
| *** yaawang has quit IRC | 05:16 | |
| *** abdysn has joined #openstack-cinder | 05:16 | |
| sonivi | Hi Team, I have python code which consumes third party API | 05:16 |
| *** yaawang has joined #openstack-cinder | 05:16 | |
| sonivi | wanted to write unit test cases for python code which consumes API | 05:16 |
| sonivi | Please suggest lib and links to follow | 05:17 |
| *** brinzhang0 has quit IRC | 05:18 | |
| *** brinzhang0 has joined #openstack-cinder | 05:21 | |
| *** udesale has joined #openstack-cinder | 05:22 | |
| *** brinzhang_ has quit IRC | 05:24 | |
| *** whoami-rajat has joined #openstack-cinder | 05:34 | |
| *** brinzhang_ has joined #openstack-cinder | 05:40 | |
| *** brinzhang0 has quit IRC | 05:43 | |
| *** udesale has quit IRC | 06:07 | |
| raghavendrat | hi whoami-rajat: are you online ? | 06:11 |
| whoami-rajat | raghavendrat, hey | 06:11 |
| raghavendrat | regarding https://review.opendev.org/#/c/739033/ yesterday you provided +2 | 06:12 |
| raghavendrat | later e0ne also provided +2. i am waiting for +W | 06:13 |
| whoami-rajat | oh | 06:13 |
| whoami-rajat | not sure why he didn't approve | 06:13 |
| whoami-rajat | raghavendrat, done | 06:13 |
| whoami-rajat | raghavendrat, i hope this parameter is tested out in the HPE CI | 06:14 |
| raghavendrat | thanks whomai-rajat: for quick approval | 06:14 |
| *** udesale has joined #openstack-cinder | 06:20 | |
| raghavendrat | a UT has been added in code review. Let me double check from HPE CI | 06:20 |
| *** yaawang has quit IRC | 06:26 | |
| *** yaawang has joined #openstack-cinder | 06:27 | |
| *** takamatsu has quit IRC | 06:59 | |
| *** rcernin has quit IRC | 07:07 | |
| *** ociuhandu has joined #openstack-cinder | 07:17 | |
| *** rcernin has joined #openstack-cinder | 07:17 | |
| *** ociuhandu_ has joined #openstack-cinder | 07:28 | |
| *** ociuhandu has quit IRC | 07:31 | |
| *** tosky has joined #openstack-cinder | 07:46 | |
| *** udesale has quit IRC | 07:47 | |
| *** raghavendrat has quit IRC | 07:47 | |
| *** udesale has joined #openstack-cinder | 07:47 | |
| *** elod_off is now known as elod | 07:51 | |
| *** e0ne has joined #openstack-cinder | 08:06 | |
| *** markvoelker has joined #openstack-cinder | 08:12 | |
| *** markvoelker has quit IRC | 08:17 | |
| *** yaawang has quit IRC | 08:24 | |
| *** rcernin has quit IRC | 08:27 | |
| *** yaawang has joined #openstack-cinder | 08:31 | |
| *** sonivi has quit IRC | 08:32 | |
| *** ociuhandu_ has quit IRC | 08:33 | |
| *** ociuhandu has joined #openstack-cinder | 08:33 | |
| *** bhagyashris is now known as bhagyashris|lunc | 08:43 | |
| *** Lucas_Gray has joined #openstack-cinder | 08:45 | |
| *** rcernin has joined #openstack-cinder | 08:48 | |
| *** xinliang has joined #openstack-cinder | 08:50 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: DNR. Add cinder-plugin-ceph-tempest-mn-aa job https://review.opendev.org/741125 | 09:10 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: DNR. Add cinder-plugin-ceph-tempest-mn-aa job https://review.opendev.org/741125 | 09:12 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: DNR. Add cinder-plugin-ceph-tempest-mn-aa job https://review.opendev.org/741125 | 09:14 |
| *** rcernin has quit IRC | 09:17 | |
| *** martinkennelly has joined #openstack-cinder | 09:17 | |
| openstackgerrit | Luigi Toscano proposed openstack/cinderlib master: WIP functional tests: directly set PATH https://review.opendev.org/741061 | 09:17 |
| *** xinliang has quit IRC | 09:27 | |
| *** akrog is now known as geguileo | 09:41 | |
| openstackgerrit | Dirk Mueller proposed openstack/cinder master: Switch from unittest2 compat methods to Python 3.x methods https://review.opendev.org/741136 | 10:19 |
| *** yaawang has quit IRC | 10:24 | |
| *** yaawang has joined #openstack-cinder | 10:25 | |
| tosky | geguileo: hi! I didn't notice the other nick. We have a problem with cinderlib tests in the lio-lvm-barbican test, have you seen yesterday night discussion? | 10:32 |
| *** mvkr has quit IRC | 10:34 | |
| *** bhagyashris|lunc is now known as bhagyashris | 10:37 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: RBD: Fix error on disconnect https://review.opendev.org/738226 | 10:41 |
| *** sonivi has joined #openstack-cinder | 10:48 | |
| *** martinkennelly has quit IRC | 10:51 | |
| *** tosky has quit IRC | 11:05 | |
| *** martinkennelly has joined #openstack-cinder | 11:07 | |
| *** rcernin has joined #openstack-cinder | 11:09 | |
| *** tosky has joined #openstack-cinder | 11:10 | |
| geguileo | tosky: I saw you saying you would ping me today... | 11:12 |
| geguileo | tosky: and I saw you proposing a patch to remove the PATH workaround in tox.ini | 11:12 |
| geguileo | but the tests hadn't finished when I checked a bit ago | 11:13 |
| geguileo | not finished yet | 11:13 |
| *** rcernin has quit IRC | 11:13 | |
| geguileo | tosky: what I don't get is why LIO barbican is failing... | 11:13 |
| smcginnis | geguileo: Do you recall why https://opendev.org/openstack/cinderlib/src/branch/master/tox.ini#L51 was added, and if there is a tox bug somewhere tracking that? | 11:14 |
| geguileo | I mean, it worked, and now it fails? | 11:14 |
| tosky | geguileo: we were not totally sure yet, the guess was about something related to using the wrong stestr or so | 11:14 |
| tosky | smcginnis: removing the PATH workaround worked, in the way the the failure is exactly the same :) | 11:15 |
| tosky | so it's probably not the same issue | 11:15 |
| smcginnis | Ah, ok. At least that eliminates one possibility. | 11:15 |
| rosmaita | tosky: so it still can't find ddt? | 11:15 |
| tosky | rosmaita: it can't | 11:15 |
| tosky | geguileo: the discussion is here: http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/%23openstack-cinder.2020-07-14.log.html#t2020-07-14T21:39:30 | 11:15 |
| smcginnis | So just need to figure out why the system stestr is being called and not the tox stestr. | 11:15 |
| geguileo | smcginnis: I remember some commands not being found because only the ones in the venv were found | 11:16 |
| geguileo | smcginnis: I think it was for the Ceph backend | 11:16 |
| geguileo | In theory I appended the system paths so that venv paths had priority | 11:16 |
| smcginnis | Got it. | 11:17 |
| tosky | smcginnis: it's worth noting that the functional tox environment is an open one (use the system packages), so stestr seems to be correctly used from /usr/local | 11:17 |
| geguileo | tosky: thanks | 11:17 |
| tosky | geguileo: the venv path was already there technically (~/.tox/functional) | 11:17 |
| *** martinkennelly has quit IRC | 11:18 | |
| tosky | but again the tox environment has sitepackages=True, so that doesn't matter | 11:18 |
| smcginnis | Maybe because stestr is in whitelist_externals? | 11:19 |
| smcginnis | Or I suppose we could be explicit and change the command to "{envbindir}/stestr" | 11:21 |
| tosky | smcginnis: I tried to remove it from whitelist_externals in the last patch stuck in the queue | 11:21 |
| tosky | but I suspect {envbindir} will still point to the external stestr, because it's already found there thanks to sitepackages=True | 11:22 |
| *** sonivi has quit IRC | 11:22 | |
| tosky | I mean, it should just work™ | 11:22 |
| *** sapd__x has quit IRC | 11:22 | |
| smcginnis | {envbindir} shouldn't find the site package first. That would be explictly pointing to the one in the venv. | 11:23 |
| openstackgerrit | Ivan Pchelintsev proposed openstack/cinder master: Add Cinder driver for Dell EMC PowerStore https://review.opendev.org/741158 | 11:23 |
| rosmaita | tox docs say when sitepackages=true, "In cases where a command line tool is also installed globally you have to make sure that you use the tool installed in the virtualenv by using python -m <command line tool> (if supported by the tool) or {envbindir}/<command line tool>." | 11:24 |
| smcginnis | Ah, well there you go. | 11:24 |
| tosky | but there is no stestr in the venv with sitepackages=True! | 11:24 |
| smcginnis | Don't we have stestr in our test-requirements? | 11:25 |
| rosmaita | yep | 11:25 |
| smcginnis | Then it should be there. | 11:25 |
| smcginnis | Otherwise we've got bigger issues. | 11:26 |
| smcginnis | Just ran "tox -e functional --notest" and confirmed stestr is installed in the venv. | 11:29 |
| *** rcernin has joined #openstack-cinder | 11:31 | |
| geguileo | smcginnis: but you don't have stestr out of the venv, right? | 11:31 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Add ceph iscsi volume driver https://review.opendev.org/662829 | 11:31 |
| *** udesale_ has joined #openstack-cinder | 11:31 | |
| *** Lucas_Gray has quit IRC | 11:32 | |
| smcginnis | geguileo: I do not have it globally installed, no. But apparently the test node does. The failure we saw indicated it installed our packages in the venv, but then failed to find ddt because it was using the system installed stestr instead of the one in our venv. | 11:32 |
| geguileo | smcginnis: that's because using sitepackages it won't install stestr in the venv since it's already present on the host | 11:33 |
| smcginnis | So based on what rosmaita found in the docs, it does appear the issue is we need to use {envbindir}/stestr since we are using sitepackages=True | 11:33 |
| geguileo | smcginnis: but I believe it won't work even with that | 11:33 |
| geguileo | because it won't be installed in the venv (like tosky was saying) | 11:33 |
| smcginnis | I thought it would still install it. Just that setting would allow the use of packages outside of the venv. | 11:34 |
| geguileo | nop | 11:34 |
| *** udesale has quit IRC | 11:34 | |
| geguileo | afaik it won't install packages that are already in the host | 11:34 |
| geguileo | but shouldn't stestr be smart enough to know it's running on a venv | 11:34 |
| geguileo | ? | 11:34 |
| smcginnis | I saw it getting installed in the venv, but that was the tempest one. | 11:37 |
| smcginnis | Under the functional test run: Requirement already satisfied: stestr>=1.0.0 in /usr/local/lib/python3.6/dist-packages | 11:37 |
| smcginnis | So I think if we did "{envbindir}/python -m pip install stestr" we could work around that. | 11:37 |
| geguileo | I think this is an stestr bug | 11:37 |
| smcginnis | How so? | 11:37 |
| geguileo | because it's not using the venv python executable | 11:38 |
| smcginnis | Not sure it can since we are calling an executable outside of our venv. | 11:38 |
| jkulik | if it's installed via debian package, then it probably got patched to use /usr/bin/python3 instead of /usr/bin/env python3 | 11:39 |
| geguileo | smcginnis: it can check VIRTUAL_ENV | 11:39 |
| smcginnis | Thanks jkulik, that's probably it. | 11:39 |
| smcginnis | geguileo: I guess it could. But I don't think that's normal for every python command to do its own check for running in a virtual env. | 11:40 |
| geguileo | smcginnis: you are probably right on that one | 11:41 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: [vmware] ensure datastores exist while fetching stats https://review.opendev.org/726222 | 11:41 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: [vmware] validate storage profile at startup https://review.opendev.org/726180 | 11:41 |
| geguileo | oooooooh, I think I found the problem!! going to check now | 11:43 |
| smcginnis | I wonder if install_command should actually be added to the functional environment. | 11:43 |
| smcginnis | Basically the same as the default install command defined in [testenv], but instead of "pip install" do "{envbindir}/pip install" | 11:44 |
| geguileo | smcginnis: tosky found the problem | 11:44 |
| * smcginnis waits to see the patch | 11:45 | |
| geguileo | or not... | 11:45 |
| *** Lucas_Gray has joined #openstack-cinder | 11:46 | |
| *** rcernin has quit IRC | 11:47 | |
| hemna | geguileo ping | 11:47 |
| geguileo | yup, that's the problem | 11:47 |
| hemna | so https://review.opendev.org/#/c/736404/ | 11:47 |
| geguileo | smcginnis: tosky the problem is that the stestr file in the host has hardcoded the location of the python binary | 11:48 |
| geguileo | smcginnis: tosky instead of using /usr/bin/env python it uses #!/usr/bin/python3.7 | 11:48 |
| geguileo | smcginnis: tosky so it doesn't use the virtual environment :-( | 11:48 |
| smcginnis | As jkulik pointed out. :) | 11:48 |
| geguileo | smcginnis: oh, I missed that XDXD | 11:49 |
| hemna | would it be ok to instead add the az to the request_spec['availability_zones'] list as a single entry if the az isn't in the type? | 11:49 |
| hemna | I presume of the volume type has a list of az's in it, then don't add the volume's az to the list, since the volume type's list of az's should be used instead. | 11:50 |
| openstackgerrit | Sean McGinnis proposed openstack/cinderlib master: WIP: Testing installing site packages in vevn https://review.opendev.org/741160 | 11:50 |
| rosmaita | smcginnis: i think i must have misread that warning: https://tox.readthedocs.io/en/latest/config.html#conf-sitepackages | 11:52 |
| smcginnis | rosmaita: I think it still applies. Since we have stestr in whitelist_externals, we don't get that same warning message. I think. | 11:53 |
| geguileo | hemna: That would add unnecessary code in my opinion | 11:54 |
| tosky | jkulik, smcginnis, geguileo : but if it's installed in /usr/local, it's not the Debian package | 11:54 |
| geguileo | hemna: if you think that the request_spec should be fully formed at the API level you can set 'resource_properties': volume | 11:54 |
| hemna | and copy the entire volume properties in there? | 11:55 |
| hemna | that seemed to be way overkill just to get the az | 11:55 |
| hemna | that's worse than what I'm doing already I think. | 11:55 |
| geguileo | hemna: you don't need to copy anything | 11:55 |
| geguileo | hemna: you just set the reference in the API | 11:55 |
| geguileo | though when serializing it will get copied | 11:56 |
| geguileo | but the concept is that those 2 keys should contain the same values | 11:56 |
| hemna | yup, since it's sent over rpc, it will get copied and serialized | 11:56 |
| geguileo | that's why I was saying to do it on the other end | 11:56 |
| geguileo | after all it's not new data, it's just that we need it in both places for backward compatibility | 11:57 |
| hemna | so what I'm doing already is more efficient, since that's all it needs | 11:57 |
| hemna | then later we can migrate to the ovo and be done with it | 11:57 |
| geguileo | hemna: but if there's another driver that uses resource_properties we'll have another bug | 11:57 |
| hemna | but this will be backwards compatible/backportable for now | 11:57 |
| geguileo | hemna: and if there isn't another driver we can just fix that driver | 11:57 |
| geguileo | that wasn't updated when we imported it from oslo.incubator | 11:57 |
| geguileo | tosky: 'i have checked my devstack and my stestr is in /usr/local/bin/stestr | 11:58 |
| geguileo | tosky: and it has #!/usr/bin/python3.7 | 11:58 |
| *** Lucas_Gray has quit IRC | 11:58 | |
| hemna | I was a bit afraid to touch the azfilter since it's been around forever | 11:58 |
| *** Lucas_Gray has joined #openstack-cinder | 11:59 | |
| geguileo | hemna: that's reasonable, then we can just add 'resource_properties': request_spec['volume_properties'] | 11:59 |
| geguileo | on the scheduler reception of the request | 11:59 |
| hemna | that seems hackish to me | 11:59 |
| geguileo | request_spec['resource_properties'] = request_spec['volume_properties'] | 11:59 |
| hemna | instead of passing the az in the request spec | 12:00 |
| hemna | altering the request in the scheduler :( | 12:00 |
| geguileo | we are already doing it | 12:00 |
| hemna | yah I saw that, not that it seems right to do | 12:00 |
| geguileo | and you only alter it to add backward compatibility | 12:00 |
| geguileo | I'm more inclined to just fix the filter that we didn't fix in 2015 when we imported the filter | 12:01 |
| hemna | makes me think we have a mess on our hands if the scheduler is altering requests coming from the api | 12:01 |
| geguileo | yeah, because we didn't import the filter as we should | 12:01 |
| tosky | geguileo: but shouldn't we see the same issue all around? tempest runs from a venv | 12:01 |
| rosmaita | geguileo: tosky: why do we need sitepackages=true for the functional testenv? | 12:01 |
| geguileo | hemna: and then we hacked our way around it | 12:01 |
| geguileo | hemna: so yes, it's a hack, but yours is one as well | 12:01 |
| geguileo | hemna: In my mind the right approach would be to fix the filter, second best to set resource to volume | 12:02 |
| hemna | not sure I agree that this is a hack, as it adds a missing property to the request spec | 12:02 |
| geguileo | tosky: Cinder set sitepackages to false | 12:02 |
| geguileo | hemna: the missing property is the whole resource_properties | 12:03 |
| geguileo | hemna: not a single field in that key | 12:03 |
| hemna | the azfilter is looking for 2 places currently for the az, spec.get('availability_zones') and resource_properties['availability_zone'] | 12:03 |
| geguileo | rosmaita: iirc it's for ceph | 12:03 |
| geguileo | rosmaita: because we install ceph-common on the host which provides ceph libraries | 12:03 |
| rosmaita | that's what i was thinking | 12:03 |
| geguileo | rosmaita: and the only existing ceph libraries in PyPi are outdated and fail to load | 12:04 |
| tosky | in a venv I installed tempest and the stestr's shebang points to the python inside the venv | 12:04 |
| *** Lucas_Gray has quit IRC | 12:04 | |
| rosmaita | too bad sitepackages isn't (True|False|Maybe) | 12:04 |
| geguileo | hemna: it's loooking at resource_properties because we messed the import of that filter | 12:04 |
| geguileo | tosky: but that's because you installed it in the venv | 12:05 |
| geguileo | tosky: but if your system had stestr in the host | 12:05 |
| hemna | rosmaita, I'm not sure why but, it seems that ceph doesn't put some of their libs even in pypi. they have them in github and leave them there for distros to create packages for them | 12:05 |
| geguileo | tosky: then the venv wouldn't install it | 12:05 |
| hemna | ceph-iscsi is one, tcmu-runner | 12:05 |
| geguileo | hemna: so true, they don't push to PyPi :-( | 12:05 |
| hemna | ceph-iscsi is pure python, and could go in pypi | 12:05 |
| hemna | :( | 12:06 |
| hemna | geguileo, so the more long term fix for this is what? we look into the request_spec['volume'] ovo for the fields ? | 12:06 |
| hemna | you would think that az would be in the same spot accross all API request_specs | 12:07 |
| rosmaita | tosky: so what do we do? leave sitepackages=true but pip-install the stestr we want into the virtualenv? | 12:07 |
| geguileo | hemna: the long term fix is using OVOs, and for this particular bug we can either make sure "resource_properties" is set, or fix the filter itself | 12:08 |
| geguileo | rosmaita: I think that's probably the easiest solution | 12:08 |
| geguileo | rosmaita: though I think we'll have to force install it | 12:08 |
| hemna | ok that's what my patch does...adds the az to the resource_properties. :) | 12:08 |
| geguileo | hemna: but we must add the whole resource_properties, not just a single field | 12:08 |
| hemna | ok so add the entire volume entry then | 12:09 |
| hemna | :( | 12:09 |
| geguileo | hemna: because resource_properties and volume_properties are the same thing | 12:09 |
| geguileo | hemna: but maybe I'm the only one thinking this way | 12:09 |
| tosky | rosmaita, geguileo: or try to use `python3 stestr...` explicitly? | 12:09 |
| tosky | rosmaita, geguileo: or python -m ... as suggested by smcginnis ? | 12:10 |
| geguileo | hemna: I'm not going to veto the patch, it's just my opinion | 12:10 |
| tosky | so that the right version of python would be used | 12:10 |
| rosmaita | tosky: i think you are right that if sitepackages=True, stestr is not installed in the virtualenv | 12:10 |
| geguileo | tosky: smcginnis's python -m could work and it's a lot cleaner | 12:10 |
| tosky | the forced interpreter should override the default from shebang | 12:10 |
| geguileo | tosky: give me a sec to confirm it works | 12:10 |
| geguileo | tosky: the -m works | 12:13 |
| geguileo | tosky: it directly bypassed the whole /usr/local/bin/stestr file and goes directly to stestr.cli.main | 12:14 |
| tosky | oh! | 12:14 |
| tosky | as expected, at least this time | 12:14 |
| geguileo | so sys.executable points to the right python interpreter | 12:14 |
| geguileo | I think that's the nicest solution | 12:14 |
| tosky | do we need a separate patch, or can we fold it inside https://review.opendev.org/#/c/741060/ ? | 12:15 |
| geguileo | tosky: I'm ok to include it in that one | 12:15 |
| rosmaita | tosky: make sure you have a comment about doing this because of the debian stestr distro | 12:16 |
| *** baojg has quit IRC | 12:17 | |
| tosky | rosmaita: I'm still not sure why the executable under /usr/local is related to debian packages | 12:17 |
| *** baojg has joined #openstack-cinder | 12:17 | |
| tosky | it should be under /usr/bin; I think that's the stestr installed by devstack | 12:19 |
| tosky | yep | 12:19 |
| tosky | 2020-07-14 22:15:00.850603 | controller | Downloading https://mirror.bhs1.ovh.opendev.org/pypifiles/packages/a7/10/dd793c81a703a3c08944d4651217ad08a7f2cbd20943398705e575421376/stestr-3.0.1-py3-none-any.whl (117 kB) | 12:19 |
| rosmaita | tosky: ok, well be cagy about it ... say something about we want to call the module directly because some scripts in some distros may not use the env python and we are using sitepackages | 12:19 |
| tosky | "installed outside the venv" | 12:21 |
| tosky | geguileo: should I also keep the removal of bash -i -c ? I think it makes sense to remove it, see https://review.opendev.org/741061 | 12:22 |
| *** enriquetaso has joined #openstack-cinder | 12:23 | |
| *** tkajinam has quit IRC | 12:24 | |
| *** martinkennelly has joined #openstack-cinder | 12:26 | |
| *** Lucas_Gray has joined #openstack-cinder | 12:30 | |
| *** vapjes has joined #openstack-cinder | 12:35 | |
| *** sonivi has joined #openstack-cinder | 12:49 | |
| *** martinkennelly has quit IRC | 12:53 | |
| sonivi | Hi, I want to write a unit test cases for python code which consumes third party API | 12:53 |
| sonivi | Any suggestion are welcome on which lib/link to use | 12:54 |
| rosmaita | sonivi: how about some context? is this for a new driver or something? | 12:55 |
| sonivi | yes its new driver but not for OpenStack. | 12:56 |
| *** whoami-rajat has quit IRC | 12:56 | |
| rosmaita | sonivi: some of our drivers use third party APIs, you could see what they do | 12:56 |
| sonivi | its similar to what we have in cinder | 12:56 |
| sonivi | rosmaita: yes.. thats good idea | 12:57 |
| rosmaita | look for drivers that have a rest client | 12:57 |
| sonivi | I have seen one client code HPE3parclient code, in which flask is used to host the APIs which returns the expected response | 12:58 |
| *** whoami-rajat has joined #openstack-cinder | 12:58 | |
| hemna | sonivi I wrote that one | 12:58 |
| sonivi | yes walter, even I was a part of it later to you | 12:59 |
| hemna | the flask server is just help test the client calls | 12:59 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: DNR. Add cinder-plugin-ceph-tempest-mn-aa job https://review.opendev.org/741125 | 12:59 |
| hemna | so it didn't have to talk to an actual 3par on the backend for CI. | 13:00 |
| hemna | flask worked well for that | 13:00 |
| sonivi | hemna: yes flask worked well for it | 13:00 |
| rosmaita | e0ne: "Do Not Resuscitate" ? | 13:01 |
| e0ne | rosmaita: it's a good option : | 13:01 |
| e0ne | :) | 13:01 |
| rosmaita | that's my plan for stable/pike! | 13:01 |
| *** whoami-rajat has quit IRC | 13:03 | |
| *** whoami-rajat has joined #openstack-cinder | 13:04 | |
| hemna | geguileo so, looking at the request_spec for volume create. it looks like the api flow creates a request spec with 'availability_zones' which is a list of 1 entry in this case for create | 13:07 |
| hemna | the azfilter looks for availability_zones | 13:07 |
| sonivi | hemna: from where these variable is coming from | 13:08 |
| sonivi | https://github.com/hpe-storage/python-3parclient/blob/master/tox.ini#L9 | 13:08 |
| hemna | I kinda think that retype should use that | 13:08 |
| hemna | sonivi shouldn't be using nose anymore. I created a PR for migrating away from that last year. https://github.com/hpe-storage/python-3parclient/pull/66 | 13:10 |
| hemna | there are other PR's up there that should be merged as well, from geguileo | 13:11 |
| openstackgerrit | Sean McGinnis proposed openstack/cinderlib master: WIP: Testing running stestr through venv python https://review.opendev.org/741160 | 13:14 |
| sonivi | <hemna>:ok..I am not aware much on tox. I will go through it | 13:16 |
| tosky | smcginnis: did you remove the stestr run --serial {posargs}" on purpose? | 13:16 |
| smcginnis | Haha, oops. Nope. | 13:16 |
| openstackgerrit | Sean McGinnis proposed openstack/cinderlib master: WIP: Testing running stestr through venv python https://review.opendev.org/741160 | 13:17 |
| *** brinzhang_ has quit IRC | 13:17 | |
| *** whoami-rajat has quit IRC | 13:25 | |
| *** whoami-rajat has joined #openstack-cinder | 13:25 | |
| *** baojg has quit IRC | 13:33 | |
| *** sonivi has quit IRC | 13:42 | |
| *** Guest14648 has joined #openstack-cinder | 13:43 | |
| *** rcernin has joined #openstack-cinder | 13:44 | |
| *** Guest14648 is now known as redrobot | 13:45 | |
| *** rcernin has quit IRC | 13:48 | |
| openstackgerrit | Luigi Toscano proposed openstack/cinderlib master: Fix and improve cross-project functional testing https://review.opendev.org/741060 | 13:52 |
| rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:58 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso ^^ | 13:58 |
| hemna | man the more I look into the filtering and request specs, it's really a mess | 13:58 |
| whoami-rajat | rosmaita, thanks | 13:59 |
| *** Liang__ has joined #openstack-cinder | 13:59 | |
| enriquetaso | thanks | 13:59 |
| *** Liang__ is now known as LiangFang | 13:59 | |
| hemna | lots of duplicated data, some data in one place, other data in other places, some filters use 1 location, another filter looks in a separate location... | 14:00 |
| hemna | nonsensical | 14:00 |
| *** sfernand has joined #openstack-cinder | 14:04 | |
| *** whoami-rajat has quit IRC | 14:04 | |
| geguileo | hemna: sooooooo true | 14:05 |
| geguileo | it's a bit of a mess | 14:05 |
| *** whoami-rajat__ has joined #openstack-cinder | 14:06 | |
| *** whoami-rajat___ has joined #openstack-cinder | 14:07 | |
| *** abdysn has quit IRC | 14:26 | |
| hemna | https://pasteboard.co/JhMaTxK.png | 14:39 |
| hemna | the base of the filter_properties is automatically added to every request to the scheduler basically here: | 14:41 |
| hemna | https://github.com/openstack/cinder/blob/cdfee5608b725e6be35d85f5b04cf51dc756cac5/cinder/scheduler/filter_scheduler.py#L53-L63 | 14:41 |
| hemna | which contains duplicated data from the request_spec which is also added to the filter_properties at the API level | 14:43 |
| hemna | just smells like the request_spec should be a separate dict from the filter_properties | 14:43 |
| *** dave-mccowan has quit IRC | 14:43 | |
| hemna | so for retype, I think the API should just populate the request_spec['availability_zones'] if they don't exist in the volume type | 14:47 |
| *** dave-mccowan has joined #openstack-cinder | 14:47 | |
| hemna | geguileo like this: https://gist.github.com/hemna/f9159d33e039cde4e3827b1e05dc1103 | 14:49 |
| hemna | so I think that'd work: if the volume type you are changing to has AZ's set, it will use those to filter against the backends, else it will use the existing volume's az | 14:50 |
| hemna | so if someone wants to force an AZ(s) on a volume type, they still can by setting them in the type extra specs. | 14:51 |
| geguileo | hemna: I think that would replace the one from the volume_type | 14:51 |
| hemna | if the volume type has the az set, it will use those | 14:52 |
| hemna | hence the else | 14:52 |
| geguileo | oh, sorry | 14:52 |
| geguileo | I'm ok with fixing this bug like this | 14:53 |
| geguileo | and I'll propose a patch to fix the AZ filter | 14:53 |
| hemna | ok I'll update my patch with that | 14:53 |
| hemna | at some time we should revisit how the request_spec and filter_properties are used and populated | 14:54 |
| hemna | it's a mess | 14:54 |
| geguileo | hemna: because AZ cannot be None, right? | 14:54 |
| hemna | correct. The AZ should be part of the request_spec for retype | 14:54 |
| hemna | otherwise you can get a volume being retyped to an AZ you don't want. | 14:54 |
| hemna | and won't find a backend to take the request, which is the original bug I found that this patch is trying to fix. | 14:55 |
| hemna | it basically picks a backend in another az that can't accept the request, and then retype pukes. | 14:55 |
| hemna | a retype should stay in the same AZ unless the type specifies an AZ | 14:56 |
| geguileo | what I was asking is if we could have a volume without an AZ, and looking at the code we won't | 14:57 |
| hemna | I think there is always an AZ set | 14:59 |
| smcginnis | Looks like actual bandit run time is about 3 minutes. The whole job is just over 7 usually. So more than 50% overhead running it as a separate job. | 15:00 |
| smcginnis | But then, I doubt it is useful at all on stable branches. | 15:01 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Fix volume retype with AZ https://review.opendev.org/736404 | 15:01 |
| *** knomura has joined #openstack-cinder | 15:02 | |
| eharney | fyi, i was chasing around lio-barbican failures and saw some weird things where it looks like nova-compute gets stuck for a bit. experimenting with https://review.opendev.org/#/c/741042/ now but it's kind of a shot in the dark | 15:02 |
| rosmaita | eharney: thanks for looking into that | 15:03 |
| eharney | i think the service gets blocked up for 90-100+ seconds and then starts timing out amqp requests, but i'm not really sure why | 15:04 |
| LiangFang | I encountered failure of this job, but recheck passed | 15:04 |
| tosky | resources? | 15:04 |
| LiangFang | rosmaita: Thanks rosmaita and Jay reviewed volume local cache patches, I have updated the patches this week. https://review.opendev.org/#/c/663549/ os-brick https://review.opendev.org/#/c/700799/ cinder | 15:05 |
| eharney | tosky: i didn't find anything in the logs that pointed to any obvious resource shortage, maybe will look for that specifically again | 15:05 |
| eharney | tosky: ooh.... in the mysql log: 2020-07-14T17:19:02.735148Z 0 [Note] InnoDB: page_cleaner: 1000ms intended loop took 125377ms. The settings might not be optimal. (flushed=201 and evicted=0, during the time.) | 15:07 |
| eharney | (at the time of failure) | 15:07 |
| eharney | interesting | 15:07 |
| rosmaita | LiangFang: will take a look at your revisions today | 15:10 |
| *** LiangFang has quit IRC | 15:10 | |
| hemna | geguileo thanks for the help man | 15:10 |
| rosmaita | eharney: i like that error message -- taking 125x longer than it should does indeed indicate that something sub-optimal is going on | 15:12 |
| eharney | rosmaita: it looks like there are a handful of knobs we can turn in mysql to remedy this kind of problem, may take a swing at a devstack patch and see what happens | 15:13 |
| eharney | mysql also reported an error "writing communication packets" back to nova_cell1 with that error, so it fits | 15:14 |
| rosmaita | that is really promising | 15:14 |
| geguileo | hemna: thank you for your patience and for fixing the issue :-) | 15:14 |
| *** whoami-rajat__ has quit IRC | 15:15 | |
| *** whoami-rajat___ is now known as whoami-rajat__ | 15:15 | |
| openstackgerrit | Eric Harney proposed openstack/cinder-tempest-plugin master: WIP: Test workaround for lio-barbican failures https://review.opendev.org/741042 | 15:27 |
| *** hamalq has joined #openstack-cinder | 15:31 | |
| *** hamalq_ has joined #openstack-cinder | 15:34 | |
| *** hamalq has quit IRC | 15:38 | |
| *** martinkennelly has joined #openstack-cinder | 15:40 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder stable/ussuri: Move non-voting jobs to experimental https://review.opendev.org/741255 | 15:41 |
| *** rosmaita has left #openstack-cinder | 15:54 | |
| *** rosmaita has joined #openstack-cinder | 15:57 | |
| *** baojg has joined #openstack-cinder | 16:28 | |
| *** ociuhandu_ has joined #openstack-cinder | 16:36 | |
| *** udesale_ has quit IRC | 16:38 | |
| *** ociuhandu has quit IRC | 16:39 | |
| *** ociuhandu_ has quit IRC | 16:40 | |
| *** e0ne has quit IRC | 16:46 | |
| *** e0ne has joined #openstack-cinder | 16:47 | |
| *** baojg has quit IRC | 16:49 | |
| *** baojg has joined #openstack-cinder | 16:50 | |
| *** psachin has quit IRC | 16:58 | |
| openstackgerrit | Ivan Pchelintsev proposed openstack/cinder master: Add Cinder driver for Dell EMC PowerStore https://review.opendev.org/741158 | 17:18 |
| *** senrique_ has joined #openstack-cinder | 17:22 | |
| *** enriquetaso has quit IRC | 17:24 | |
| *** Lucas_Gray has quit IRC | 17:41 | |
| *** geguileo has quit IRC | 17:41 | |
| openstackgerrit | Ivan Pchelintsev proposed openstack/cinder master: Add Cinder driver for Dell EMC PowerStore https://review.opendev.org/741158 | 17:42 |
| *** geguileo has joined #openstack-cinder | 17:42 | |
| *** e0ne has quit IRC | 18:00 | |
| *** senrique__ has joined #openstack-cinder | 18:05 | |
| *** senrique_ has quit IRC | 18:07 | |
| *** martinkennelly has quit IRC | 18:08 | |
| *** larsks has joined #openstack-cinder | 18:14 | |
| *** vishalmanchanda has quit IRC | 18:20 | |
| *** tosky has quit IRC | 18:25 | |
| *** tosky has joined #openstack-cinder | 18:25 | |
| *** knomura has quit IRC | 18:25 | |
| *** knomura has joined #openstack-cinder | 18:27 | |
| *** knomura has quit IRC | 18:32 | |
| *** baojg has quit IRC | 18:38 | |
| *** baojg has joined #openstack-cinder | 18:39 | |
| *** ociuhandu has joined #openstack-cinder | 18:46 | |
| *** ociuhandu has quit IRC | 18:50 | |
| *** jdillaman has joined #openstack-cinder | 18:53 | |
| *** KeithMnemonic has joined #openstack-cinder | 19:12 | |
| *** rmcall has quit IRC | 19:22 | |
| *** rmcall has joined #openstack-cinder | 19:23 | |
| *** rmcallis has joined #openstack-cinder | 19:25 | |
| *** rmcall has quit IRC | 19:28 | |
| *** rmcallis__ has joined #openstack-cinder | 19:28 | |
| *** rmcallis has quit IRC | 19:31 | |
| tosky | it passed! | 19:48 |
| tosky | https://review.opendev.org/#/c/741060/ | 19:48 |
| rosmaita | just saw taht | 19:53 |
| rosmaita | ok, soon as that merges we can have a recheck party | 19:54 |
| tosky | thanks all for the suggestions! | 19:56 |
| tosky | now we need to work on devstack-plugin-nfs :) | 19:57 |
| *** sfernand has quit IRC | 20:13 | |
| *** senrique__ has quit IRC | 20:35 | |
| *** hamalq_ has quit IRC | 20:46 | |
| *** hamalq has joined #openstack-cinder | 20:48 | |
| *** hamalq has quit IRC | 20:52 | |
| *** hamalq has joined #openstack-cinder | 20:52 | |
| *** rmcall has joined #openstack-cinder | 21:27 | |
| *** rmcallis__ has quit IRC | 21:28 | |
| *** rmcall has quit IRC | 21:30 | |
| *** rmcall has joined #openstack-cinder | 21:31 | |
| *** rmcall has quit IRC | 21:35 | |
| *** rmcallis has joined #openstack-cinder | 21:36 | |
| *** rmcallis has quit IRC | 21:42 | |
| openstackgerrit | Lucio Seki proposed openstack/cinder master: [NetApp] Adding support for Adaptive QoS in NetApp driver. https://review.opendev.org/741327 | 21:49 |
| *** logan- has quit IRC | 22:17 | |
| *** rcernin has joined #openstack-cinder | 22:18 | |
| *** logan- has joined #openstack-cinder | 22:19 | |
| *** rcernin has quit IRC | 22:20 | |
| *** rcernin has joined #openstack-cinder | 22:21 | |
| *** spatel has joined #openstack-cinder | 22:29 | |
| *** vapjes has quit IRC | 22:33 | |
| *** spatel has quit IRC | 22:34 | |
| *** hamalq has quit IRC | 22:35 | |
| openstackgerrit | Merged openstack/cinderlib master: Fix and improve cross-project functional testing https://review.opendev.org/741060 | 22:35 |
| *** baojg has quit IRC | 22:43 | |
| *** baojg has joined #openstack-cinder | 22:44 | |
| *** tosky has quit IRC | 22:48 | |
| openstackgerrit | Merged openstack/cinder-specs master: Support modern compression algorithms in cinder backup https://review.opendev.org/726307 | 22:50 |
| *** tkajinam has joined #openstack-cinder | 22:55 | |
| *** tkajinam has quit IRC | 22:55 | |
| *** tkajinam has joined #openstack-cinder | 22:58 | |
| *** markvoelker has joined #openstack-cinder | 23:11 | |
| *** markvoelker has quit IRC | 23:15 | |
| *** knomura has joined #openstack-cinder | 23:38 | |
| *** knomura has quit IRC | 23:42 | |
| *** baojg has quit IRC | 23:58 | |
| *** baojg has joined #openstack-cinder | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
