Thursday, 2020-03-19

*** sfernand has quit IRC00:10
*** n-saito has joined #openstack-cinder00:15
*** martinkennelly has quit IRC00:48
*** tosky has quit IRC00:50
*** brinzhang has joined #openstack-cinder00:52
*** brinzhang has quit IRC00:57
*** brinzhang has joined #openstack-cinder00:57
*** Liang__ has joined #openstack-cinder01:15
*** brinzhang_ has joined #openstack-cinder01:20
*** brinzhang has quit IRC01:23
openstackgerritzhaoleilc proposed openstack/cinder master: Fix error of checking lun id for infortrend driver  https://review.opendev.org/71376901:29
*** vishalmanchanda has joined #openstack-cinder01:33
*** ianychoi_ has joined #openstack-cinder01:38
*** ianychoi has quit IRC01:40
*** sapd1 has joined #openstack-cinder01:50
openstackgerritzhaoleilc proposed openstack/cinder master: Add configuration item for infortrend document  https://review.opendev.org/71377102:01
*** ociuhandu has joined #openstack-cinder02:04
*** ociuhandu has quit IRC02:09
*** zhanglong has joined #openstack-cinder02:28
*** psachin has joined #openstack-cinder02:30
openstackgerritrenminmin proposed openstack/cinder master: RBD: Fix volume delete error for missed parent  https://review.opendev.org/70934202:56
*** raunak12 has quit IRC03:07
openstackgerritLiang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul  https://review.opendev.org/71377203:12
*** raunak12 has joined #openstack-cinder03:55
*** udesale has joined #openstack-cinder04:32
*** baojg has quit IRC04:42
*** dave-mccowan has quit IRC05:10
*** raunak12 has quit IRC05:11
*** raunak12 has joined #openstack-cinder05:14
*** zhanglong has quit IRC05:57
*** zhanglong has joined #openstack-cinder05:57
openstackgerritLiang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul  https://review.opendev.org/71377206:11
*** yedongcan has joined #openstack-cinder06:47
*** dpawlik has joined #openstack-cinder06:53
*** raunak12 has quit IRC06:58
openstackgerritOpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/71379107:17
*** ociuhandu has joined #openstack-cinder07:28
*** ociuhandu has quit IRC07:33
*** tesseract has joined #openstack-cinder07:51
*** jawad_axd has joined #openstack-cinder07:51
*** threestrands has quit IRC08:01
*** xyang has quit IRC08:08
*** lxkong has quit IRC08:08
*** carloss has quit IRC08:08
*** guilhermesp has quit IRC08:09
*** carloss has joined #openstack-cinder08:09
*** lxkong has joined #openstack-cinder08:10
*** mnaser has quit IRC08:10
*** xyang has joined #openstack-cinder08:10
*** mnaser has joined #openstack-cinder08:11
*** guilhermesp has joined #openstack-cinder08:11
*** tkajinam has quit IRC08:12
openstackgerritLiang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul  https://review.opendev.org/71377208:12
*** e0ne has joined #openstack-cinder08:16
e0negeguileo: hi. could you please review https://review.opendev.org/#/c/713649/?08:16
*** lpetrut has joined #openstack-cinder08:18
*** tosky has joined #openstack-cinder08:21
*** zhanglong has quit IRC08:22
*** zhanglong has joined #openstack-cinder08:27
openstackgerritLiang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul  https://review.opendev.org/71377208:44
*** psachin has quit IRC09:01
*** psachin has joined #openstack-cinder09:02
*** yoctozepto has quit IRC09:07
*** ociuhandu has joined #openstack-cinder09:10
*** yoctozepto0 has joined #openstack-cinder09:16
openstackgerritRaghavendra Tilay proposed openstack/cinder master: HPE 3PAR: Support duplicated FQDN in network  https://review.opendev.org/71380309:19
*** ociuhandu has quit IRC09:22
*** yoctozepto9 has joined #openstack-cinder09:27
*** yoctozepto0 has quit IRC09:27
*** e0ne has quit IRC09:36
*** e0ne has joined #openstack-cinder09:36
openstackgerritLiang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul  https://review.opendev.org/71377209:38
*** zhanglong has quit IRC09:42
*** Liang__ has quit IRC09:45
*** ociuhandu has joined #openstack-cinder09:54
*** Xuchu has quit IRC09:55
*** vishalmanchanda has quit IRC10:03
*** kaisers_ has joined #openstack-cinder10:16
*** vishalmanchanda has joined #openstack-cinder10:22
*** Xuchu has joined #openstack-cinder10:23
*** tesseract has quit IRC10:36
*** yoctozepto9 is now known as yoctozepto10:37
*** tesseract has joined #openstack-cinder10:42
*** tesseract has quit IRC10:46
*** enriquetaso has joined #openstack-cinder10:47
*** tesseract has joined #openstack-cinder10:48
*** n-saito has quit IRC10:48
e0negeguileo: thanks for the review!10:54
geguileoe0ne: np, thank you for working on the bug :-)10:54
e0negeguileo: you're en expert in A/A, so I'll be bothering you on this area10:55
geguileoe0ne: sure, feel free to ping me10:56
*** ociuhandu has quit IRC10:58
*** tesseract-RH has joined #openstack-cinder11:00
*** tesseract-RH has left #openstack-cinder11:01
e0negeguile: could you please poing me on code where we set host to the volume group?11:02
e0ne_create_group_from_group_snapshot and _create_group_from_source_group are called after scheduler verifies a host, so it's not so easy for me to find the right place11:03
*** tesseract has quit IRC11:03
*** ociuhandu has joined #openstack-cinder11:03
geguileoe0ne: I thought I had added the links to the code in the comments... r:-??11:04
e0negeguileo: it's not the right place https://opendev.org/openstack/cinder/src/branch/master/cinder/group/api.py#L250-L26311:04
*** ociuhandu has quit IRC11:04
* geguileo facepalms...11:05
*** ociuhandu has joined #openstack-cinder11:05
e0negeguileo: you dropped a link where volume.host is being set11:05
geguileoe0ne: https://opendev.org/openstack/cinder/src/branch/master/cinder/group/api.py#L34211:05
e0nebut we need to set a group.host11:05
geguileoe0ne: https://opendev.org/openstack/cinder/src/branch/master/cinder/group/api.py#L42511:05
*** sapd1 has quit IRC11:05
e0negeguileo: it's not I'm talking about11:06
geguileoe0ne: the group should already have the host and the cluster_name, if it doesn't, then we have a bug somewhere else11:06
e0ne*not what I'm talking about11:06
e0negeguileo: "the group should already have the host and the cluster_name" it does, but I can't find where we do it11:06
*** dviroel has joined #openstack-cinder11:11
*** Lucas_Gray has joined #openstack-cinder11:13
*** pck has joined #openstack-cinder11:16
*** pck is now known as pckizer11:16
geguileoe0ne: https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/driver.py#L6211:17
geguileoe0ne: that's where we set the values11:17
geguileoe0ne: and we call that from https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/filter_scheduler.py#L8311:18
e0negeguileo: thanks!11:18
geguileonp11:18
*** andrebeltrami has joined #openstack-cinder11:21
openstackgerritIvan Kolodyazhny proposed openstack/cinder master: WIP. FilterScheduler uses backend.host instead backend.id now  https://review.opendev.org/71364911:32
*** pcaruana has quit IRC11:35
*** pcaruana has joined #openstack-cinder11:48
*** ociuhandu has quit IRC11:50
*** dave-mccowan has joined #openstack-cinder11:52
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder master: Vmware: Revert the volume stats revert.  https://review.opendev.org/70273012:07
openstackgerritSean McGinnis proposed openstack/cinder master: Skip common tests on translation files  https://review.opendev.org/71385812:12
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder master: Adds support for min/max volume size on vol_type  https://review.opendev.org/71371012:13
*** udesale_ has joined #openstack-cinder12:19
*** udesale has quit IRC12:20
*** e0ne_ has joined #openstack-cinder12:20
*** e0ne has quit IRC12:21
*** ociuhandu has joined #openstack-cinder12:22
*** ociuhandu has quit IRC12:28
openstackgerritMerged openstack/python-brick-cinderclient-ext master: Correct typo in title  https://review.opendev.org/71108312:35
hemnamornin12:43
*** Wryhder has joined #openstack-cinder12:51
openstackgerritRajat Dhasmana proposed openstack/cinder master: Backup: Limit number of concurent operations  https://review.opendev.org/71029712:52
*** Lucas_Gray has quit IRC12:53
*** Wryhder is now known as Lucas_Gray12:53
openstackgerritMerged openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/71379112:53
openstackgerritMerged openstack/cinder master: [Unity] Fix TypeError for test case test_delete_host_wo_lock  https://review.opendev.org/71321712:53
*** psachin has quit IRC13:21
e0ne_hemna: mornint13:21
e0ne_hemna: morning13:21
e0ne_geguileo: in which cases we should use backend_id instead of host?13:24
geguileoe0ne_: in general always13:26
geguileoe0ne_: it's how we determine the ID of a backend13:26
geguileoif it's an A/P deployment it will return the host, if it's A/A it will return the cluster_name13:26
geguileothat's important for sending RPCs13:27
geguileofor filtering13:27
e0ne_I understand how it works wirh RPC13:27
geguileowith filtering is similar13:27
geguileothe dict with the stats is using that as a key13:28
e0ne_here is what I've got in my devstack http://paste.openstack.org/show/790894/13:28
e0ne_I've got a regular devstack + ceph setup with 'cluster=ceph-cluster' in my cinder.conf13:29
geguileoe0ne_: the problem is that I forgot to report the cluster name in the volumes  :-(13:29
geguileoso you cannot see it with the API13:29
geguileoif you select the volume with mysql you should see the cluster_name field13:29
e0ne_ok, I see it13:31
geguileoe0ne_: that's something we should probably fix with a new microversion... Reporting the cluster_name on the volumes13:32
geguileobecause it's painful not seeing it13:32
* e0ne_ hates microversions13:32
*** Lucas_Gray has quit IRC13:56
*** udesale_ has quit IRC14:00
*** Lucas_Gray has joined #openstack-cinder14:00
openstackgerritMerged openstack/cinder master: QNAP: Fix login on Python3  https://review.opendev.org/67226514:03
openstackgerritMerged openstack/cinder master: Extend remove_version_from_href support  https://review.opendev.org/63599514:03
openstackgerritMerged openstack/cinder master: Enable mutate for cinder scheduler  https://review.opendev.org/67705314:03
openstackgerritBrian Rosmaita proposed openstack/cinder master: Update weekly meeting location  https://review.opendev.org/71389514:51
*** jvisser has quit IRC15:09
*** lpetrut has quit IRC15:23
*** jv has joined #openstack-cinder15:28
openstackgerritIvan Kolodyazhny proposed openstack/cinder master: Set cluster name for volume groups  https://review.opendev.org/71364915:30
*** jawad_axd has quit IRC15:31
*** jawad_axd has joined #openstack-cinder15:42
*** vishalmanchanda has quit IRC15:43
*** jgriffith has quit IRC15:44
*** jgriffith has joined #openstack-cinder15:46
*** spatel has joined #openstack-cinder15:48
*** spatel has quit IRC15:51
*** Lucas_Gray has quit IRC15:59
*** ociuhandu has joined #openstack-cinder16:04
*** ociuhandu has quit IRC16:06
*** ociuhandu_ has joined #openstack-cinder16:06
*** Lucas_Gray has joined #openstack-cinder16:08
*** raunak12 has joined #openstack-cinder16:08
*** yedongcan has left #openstack-cinder16:15
*** sebnet has joined #openstack-cinder16:18
*** sebnet has left #openstack-cinder16:18
*** Lucas_Gray has quit IRC16:21
*** Lucas_Gray has joined #openstack-cinder16:24
openstackgerritGorka Eguileor proposed openstack/cinderlib master: Fix test_set_snapshot  https://review.opendev.org/71393116:43
geguileowhoami-rajat: ^ could you review that one? is a trivial fix that blocks the cinderli gate and it was and after effect of your patch that forbids snapshot's volume_type_id to be null16:44
*** adrianc_ has quit IRC17:06
*** adrianc has joined #openstack-cinder17:06
whoami-rajatgeguileo, sure, let me take a look17:11
geguileowhoami-rajat: it's a one-liner XD17:12
geguileowhoami-rajat: thanks!17:12
whoami-rajatgeguileo, sorry got distracted17:16
geguileolol17:16
whoami-rajatgeguileo, since it's so small should we just merge it?17:17
whoami-rajatthe commit msg is lot longer than the fix :D17:17
geguileowhoami-rajat: Yeah, I think it's OK to just merge it17:17
geguileowhoami-rajat: it's a really silly thing fixing a test17:17
whoami-rajatgeguileo, done17:19
geguileowhoami-rajat: thanks!17:19
whoami-rajatgeguileo, i was remembering i added the default vol type support in cinderlib and what did i miss17:20
whoami-rajatgeguileo, and then i saw this was the migration patch which merged this cycle17:20
geguileowhoami-rajat: you didn't miss anything17:20
geguileowhoami-rajat: yeah, that merged like 3 weeks ago XD17:20
geguileowhoami-rajat: and the problem is in the unit tests, because real usage won't have that issue17:20
geguileocinderlib functional tests passed on your patch just fine :-)17:21
whoami-rajatgeguileo, great. so there we've persistence plugin which uses ram and dbms plugin which uses db. forgive me if i'm forgetting the concepts17:24
whoami-rajatgeguileo, i'm getting a little confused with the point of persistence plugin but i will better read the docs17:24
geguileowhoami-rajat: yeah, and the dbms also can store things in memory using sqlite17:24
geguileowhoami-rajat: persistence plugin is basically the mechanism to be able to store the things we store in the Cinder DB anywhere we want17:25
geguileowhoami-rajat: for example Ember-CSI stores it in kuberntes etcd using CRDs17:25
whoami-rajatgeguileo, oh ok. got it. thanks for the short and very good explanation. :)17:29
geguileonp17:30
*** ociuhandu_ has quit IRC17:42
*** ociuhandu has joined #openstack-cinder17:42
*** ociuhandu has quit IRC17:48
*** ociuhandu has joined #openstack-cinder18:01
jungleboyjI now appreicate just how much more productive I have been working from home.  Now that I have other people here interrupting me the day is going super fast and I am not getting nearly as much done.18:12
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder master: Vmware: Revert the volume stats revert.  https://review.opendev.org/70273018:12
geguileojungleboyj: lol18:13
smcginnishemna: What's going on with ignoring comments on that? I'm getting confused.18:13
hemnanot doing it on purpose, just didn't see them18:13
hemnagetting senile I guess18:14
jungleboyjhttps://gph.is/g/ajWp6mj18:14
smcginnishemna: Another patch coming for the release note?18:14
smcginnisHah!18:14
hemnayah18:15
smcginnishemna: Cool, thanks. Just wasn't sure if it meant you didn't agree and were just going to ignore it, or if it was just missed. ;)18:16
hemnaso we don't use a features section for release notes at all?18:16
hemnano, I just missed them18:16
smcginnisWe do, but it's really when we add some new functionality that someone would want to use with Cinder.18:16
hemnaok I guess it's debateable then for adding a new feature to a driver then.18:17
smcginnisI think this makes sense as upgrade so they know what to expect and that something has changed before they decide to upgrade the code, and Fixes so they are aware some issue they may have run into has been addressed.18:17
smcginnisIt's really an internal detail of the driver, not new functionality.18:17
hemnacool18:17
hemnaI'll update the scheduler comment18:17
smcginnisThanks!18:18
hemnaas it does effectively break scheduling properly18:18
hemnaespecially when other drivers for different backends are enabled18:18
*** Lucas_Gray has quit IRC18:25
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder master: Vmware: Revert the volume stats revert.  https://review.opendev.org/70273018:26
hemnaok18:27
hemnaI hope I addressed everything18:27
hemnayou know me, if I don't agree I'll speak up about it (for better or for worse)18:27
*** ociuhandu has quit IRC18:27
hemnaw i t f18:28
*** ociuhandu has joined #openstack-cinder18:28
hemnaarg18:28
hemnajungleboyj nice gif18:29
jungleboyjI had been looking for that one.  Finally saw it.18:30
*** ociuhandu has quit IRC18:33
openstackgerritGorka Eguileor proposed openstack/cinderlib master: NotLocal exception after refresh  https://review.opendev.org/71396418:58
openstackgerritGorka Eguileor proposed openstack/cinderlib master: DBMS: Fix volume deletion with MySQL  https://review.opendev.org/71396518:59
openstackgerritGorka Eguileor proposed openstack/cinderlib master: DBMS: Fix db_sync between N and N+1 releases  https://review.opendev.org/71396618:59
*** jawad_axd has quit IRC19:04
*** andrebeltrami has quit IRC19:10
whoami-rajatgeguileo, there seems to be some problem with SQLAlchemy and centos8, you patch is failing lvm functional tests job :(19:25
whoami-rajathttp://paste.openstack.org/show/790909/19:25
openstackgerritSimon O'Donovan proposed openstack/cinder master: PowerMax Driver - Support of Multiple Replication  https://review.opendev.org/70966919:53
*** Lucas_Gray has joined #openstack-cinder20:20
*** e0ne_ has quit IRC21:04
*** e0ne has joined #openstack-cinder21:08
*** e0ne has quit IRC21:22
*** ociuhandu has joined #openstack-cinder21:33
*** enriquetaso has quit IRC21:58
*** ociuhandu has quit IRC22:09
*** ociuhandu has joined #openstack-cinder22:10
*** ociuhandu has quit IRC22:15
*** zigo has quit IRC22:22
*** zigo has joined #openstack-cinder22:30
*** Lucas_Gray has quit IRC22:31
*** dpawlik has quit IRC22:38
*** CeeMac has quit IRC22:50
*** raunak12 has quit IRC23:14
*** raunak12 has joined #openstack-cinder23:31
*** spatel has joined #openstack-cinder23:42
*** rosmaita has quit IRC23:43
*** spatel has quit IRC23:46
*** CeeMac has joined #openstack-cinder23:49
*** rosmaita has joined #openstack-cinder23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!