Friday, 2019-11-29

*** tkajinam has joined #openstack-cinder00:03
*** brinzhang_ has joined #openstack-cinder00:06
*** brinzhang has quit IRC00:09
*** baojg has quit IRC00:10
*** tosky has quit IRC00:14
*** brinzhang has joined #openstack-cinder00:19
*** brinzhang_ has quit IRC00:22
*** ociuhandu has joined #openstack-cinder00:38
*** ociuhandu has quit IRC00:43
*** brinzhang_ has joined #openstack-cinder00:58
*** brinzhang has quit IRC01:02
*** brinzhang_ has quit IRC01:04
*** brinzhang_ has joined #openstack-cinder01:05
*** Xuchu has quit IRC01:08
*** ociuhandu has joined #openstack-cinder01:17
openstackgerritMerged openstack/cinder-tempest-plugin master: Update README.md for running cinder tests in tempest  https://review.opendev.org/68885301:26
*** ociuhandu has quit IRC01:26
*** nanzha has joined #openstack-cinder01:29
*** ociuhandu has joined #openstack-cinder01:31
*** whfnst has joined #openstack-cinder01:35
*** ociuhandu has quit IRC01:36
*** nanzha has quit IRC02:03
*** nanzha has joined #openstack-cinder02:04
*** dasp has joined #openstack-cinder02:26
*** dasp_ has quit IRC02:29
*** ociuhandu has joined #openstack-cinder02:44
*** ociuhandu has quit IRC02:51
*** ociuhandu has joined #openstack-cinder03:04
*** ociuhandu has quit IRC03:08
*** ociuhandu has joined #openstack-cinder03:09
*** ociuhandu has quit IRC03:14
*** awalende has joined #openstack-cinder03:18
openstackgerritYong Huang proposed openstack/cinder master: [Unity] Cross-arrays storage-assisted migration support  https://review.opendev.org/65145003:20
*** awalende has quit IRC03:22
*** ociuhandu has joined #openstack-cinder03:32
*** ociuhandu has quit IRC03:46
*** brinzhang_ has quit IRC03:51
*** brinzhang_ has joined #openstack-cinder03:51
*** brinzhang has joined #openstack-cinder04:19
*** brinzhang_ has quit IRC04:23
*** bhagyashris has joined #openstack-cinder04:23
*** brinzhang_ has joined #openstack-cinder04:24
*** brinzhang has quit IRC04:28
*** udesale has joined #openstack-cinder04:54
*** ociuhandu has joined #openstack-cinder05:30
*** ociuhandu has quit IRC05:35
*** brinzhang has joined #openstack-cinder05:37
*** brinzhang_ has quit IRC05:40
*** bhagyashris has quit IRC05:51
*** n-saito has joined #openstack-cinder05:53
*** yaawang has quit IRC06:04
*** yaawang has joined #openstack-cinder06:04
*** Luzi has joined #openstack-cinder06:04
*** udesale has quit IRC06:07
*** bhagyashris has joined #openstack-cinder06:09
*** brinzhang_ has joined #openstack-cinder06:23
*** brinzhang_ has quit IRC06:25
*** brinzhang_ has joined #openstack-cinder06:26
*** brinzhang has quit IRC06:26
*** awalende has joined #openstack-cinder06:27
*** brinzhang_ has quit IRC06:27
*** brinzhang_ has joined #openstack-cinder06:27
*** udesale has joined #openstack-cinder06:37
*** udesale has quit IRC06:39
*** udesale has joined #openstack-cinder06:39
*** udesale has quit IRC06:42
*** nanzha has quit IRC06:44
*** nanzha has joined #openstack-cinder06:47
*** udesale has joined #openstack-cinder06:52
*** awalende has quit IRC06:56
*** bhagyashris_ has joined #openstack-cinder06:57
*** bhagyashris has quit IRC06:59
*** udesale has quit IRC07:13
*** udesale has joined #openstack-cinder07:13
*** rcernin has quit IRC07:24
*** lpetrut has joined #openstack-cinder07:28
*** bhagyashris_ has quit IRC07:31
*** bhagyashris has joined #openstack-cinder07:34
*** brinzhang has joined #openstack-cinder07:49
*** brinzhang_ has quit IRC07:53
*** nanzha has quit IRC07:53
*** nanzha has joined #openstack-cinder08:05
*** ociuhandu has joined #openstack-cinder08:22
*** ociuhandu has quit IRC08:22
*** ociuhandu has joined #openstack-cinder08:23
*** tesseract has joined #openstack-cinder08:24
*** brinzhang_ has joined #openstack-cinder08:24
*** brinzhang has quit IRC08:28
*** udesale has quit IRC08:28
*** ociuhandu has quit IRC08:28
*** udesale has joined #openstack-cinder08:28
*** udesale has quit IRC08:29
*** udesale has joined #openstack-cinder08:30
*** whoami-rajat has joined #openstack-cinder08:37
*** udesale has quit IRC08:42
*** udesale has joined #openstack-cinder08:43
*** do3meli has joined #openstack-cinder08:43
*** tkajinam has quit IRC08:43
*** n-saito has quit IRC08:43
*** tosky has joined #openstack-cinder08:46
*** trident has quit IRC08:55
*** trident has joined #openstack-cinder08:56
*** brinzhang has joined #openstack-cinder08:58
*** brinzhang_ has quit IRC09:02
*** awalende has joined #openstack-cinder09:03
*** martinkennelly has joined #openstack-cinder09:09
*** Dinesh_Bhor has quit IRC09:11
*** ociuhandu has joined #openstack-cinder09:22
*** ociuhandu has quit IRC09:28
*** ociuhandu has joined #openstack-cinder09:31
*** udesale has quit IRC09:32
*** udesale has joined #openstack-cinder09:33
*** ociuhandu has quit IRC09:35
*** ociuhandu has joined #openstack-cinder09:36
*** ociuhandu has quit IRC09:37
*** ociuhandu has joined #openstack-cinder09:38
*** bhagyashris has quit IRC09:40
*** ociuhandu has quit IRC09:40
*** mvkr has quit IRC09:41
*** mvkr has joined #openstack-cinder09:41
*** ociuhandu has joined #openstack-cinder09:41
*** mns96 has joined #openstack-cinder09:51
openstackgerritRajat Dhasmana proposed openstack/cinder master: Fix: Purge volume record when attachment exists  https://review.opendev.org/69667609:51
*** ociuhandu has quit IRC09:55
*** ociuhandu has joined #openstack-cinder09:56
*** brinzhang_ has joined #openstack-cinder09:56
*** brinzhang has quit IRC09:59
*** Roamer` has joined #openstack-cinder10:01
*** ociuhandu has quit IRC10:19
*** ociuhandu has joined #openstack-cinder10:20
*** ociuhandu has quit IRC10:21
*** ociuhandu has joined #openstack-cinder10:22
*** ociuhandu has quit IRC10:24
*** ociuhandu has joined #openstack-cinder10:24
*** ociuhandu has quit IRC10:26
*** ociuhandu has joined #openstack-cinder10:27
*** brinzhang_ has quit IRC10:28
*** rcernin has joined #openstack-cinder10:31
openstackgerritPeter Penchev proposed openstack/os-brick master: StorPool: parse the output of `blockdev` correctly.  https://review.opendev.org/69668010:33
Roamer`^^^ do I feel stupid now...10:34
*** ociuhandu has quit IRC10:34
*** pcaruana has joined #openstack-cinder10:36
*** davidsha has joined #openstack-cinder10:37
*** e0ne has joined #openstack-cinder10:40
*** rcernin has quit IRC10:49
*** lennyb has joined #openstack-cinder10:52
*** udesale has quit IRC10:52
*** udesale has joined #openstack-cinder10:53
*** psachin has joined #openstack-cinder11:26
lyarwoodgeguileo: https://review.opendev.org/#/c/695564/ - would you mind taking a look at this today if you have a second, trying to avoid issues in slow CI envs.11:28
*** awalende has quit IRC11:28
geguileolyarwood: any chance we can just fix Nova?11:31
geguileoto stop replacing the path provided by os-brick?11:31
geguileothat way we wouldn't even need to return a symlink11:31
lyarwoodgeguileo: nova isn't the issue, it's the original encryptors.11:34
lyarwoodgeguileo: We should natively decrypt LUKS volumes  now11:35
lyarwoodgeguileo: dmcrypt plain volumes are the only thing we need to remove to remove this11:35
geguileohow is the original encryptors the issue?11:35
geguileonova replaces the symlink that os-brick provides with the decrypted dm11:35
lyarwoodgeguileo: that's os-brick isn't it11:35
lyarwoodgeguileo: that code was in nova11:36
lyarwoodgeguileo: but we moved it into os-brick a while ago11:36
geguileolyarwood: but it's because Nova doesn't do the right thing...11:36
geguileoit stores the info and then doesn't update it after the encryption is done11:36
geguileoit should be that os-brick returns a real device when attaching11:37
geguileoand when we decrypt we return a new path11:37
geguileoand that's the one that should be used by Nova11:37
lyarwoodhmm I see11:37
geguileobut since Nova stores the path first, and will use that for the VM11:37
geguileowe have to replace the first path11:37
lyarwoodI've always blamed the encryptors for this but I see your point11:37
geguileoyou can check upstream bug #170395411:38
openstackbug 1703954 in OpenStack Compute (nova) "Attach/Detach encrypted volume problems with real paths" [Undecided,Incomplete] https://launchpad.net/bugs/170395411:38
geguileoI broke encryption when I started returning real paths without knowing about this flow11:38
lyarwoodokay let me hackaround this afternoon, it shouldn't be that hard to update the path in the connection_info before we build the config11:39
lyarwoodor maybe it is and that's why we haven't yet11:39
geguileomaybe11:39
geguileoanyway, once you've had to suffer through my complains, let me review the patch  XD11:39
lyarwood\o/ will do man, thanks again11:40
*** ociuhandu has joined #openstack-cinder11:41
*** ociuhandu has quit IRC11:42
geguileolyarwood: reviewed11:53
geguileoI downvoted because I believe we need to call the number of calls11:54
geguileoto the mocks11:54
lyarwoodack, I'll repsin shortly11:55
geguileolyarwood: thanks for the fix :-)11:56
*** ociuhandu has joined #openstack-cinder11:57
*** dpawlik has quit IRC12:05
*** lennyb has quit IRC12:07
*** lennyb has joined #openstack-cinder12:12
*** whoami-rajat has quit IRC12:17
*** ociuhandu has quit IRC12:21
*** lennyb has quit IRC12:25
*** do3meli has quit IRC12:26
*** dpawlik has joined #openstack-cinder12:28
*** rcernin has joined #openstack-cinder12:29
*** do3meli has joined #openstack-cinder12:30
openstackgerritLee Yarwood proposed openstack/os-brick master: WIP encryptors: Return the realpath to dm-crypt devices if requested  https://review.opendev.org/69669412:30
openstackgerritLee Yarwood proposed openstack/os-brick master: WIP iscsi: Remove encryption workaround  https://review.opendev.org/69669512:30
*** lennyb has joined #openstack-cinder12:31
*** awalende has joined #openstack-cinder12:33
*** lennyb has quit IRC12:41
openstackgerritLee Yarwood proposed openstack/os-brick master: WIP Remove workaround for bug #1633518  https://review.opendev.org/69669612:43
openstackbug 1633518 in os-brick "The passphrase used to encrypt or decrypt volumes was mangled prior to Newton" [High,Fix released] https://launchpad.net/bugs/1633518 - Assigned to Lee Yarwood (lyarwood)12:43
*** ociuhandu has joined #openstack-cinder12:57
*** dpawlik has quit IRC12:58
openstackgerritLee Yarwood proposed openstack/os-brick master: iscsi: Add _get_device_link retry when waiting for /dev/disk/by-id/ to populate  https://review.opendev.org/69556413:07
*** whoami-rajat has joined #openstack-cinder13:10
*** nanzha has quit IRC13:22
*** nanzha has joined #openstack-cinder13:25
*** dpawlik has joined #openstack-cinder13:25
*** enriquetaso has joined #openstack-cinder13:30
*** spsurya has joined #openstack-cinder13:57
openstackgerritSofia Enriquez proposed openstack/cinder master: NFS encrypted volume support  https://review.opendev.org/59714813:58
*** awalende has quit IRC14:01
*** ociuhandu has quit IRC14:07
*** ociuhandu has joined #openstack-cinder14:08
*** dave-mccowan has joined #openstack-cinder14:10
*** ociuhandu has quit IRC14:13
*** Luzi has quit IRC14:23
*** awalende has joined #openstack-cinder14:24
*** ociuhandu has joined #openstack-cinder14:29
*** nanzha has quit IRC14:38
*** awalende has quit IRC14:39
*** nanzha has joined #openstack-cinder14:49
Roamer`hm, has anybody seen os-brick's remove_scsi_device() fail because blockdev --flushbufs says "no such device"?  Case in point: we're about to add an option to export StorPool volumes via iSCSI, I tested it on an unrelated review, and see first the several lines following15:07
Roamer`https://spfactory.storpool.com/logs/38/696438/1/silent/cinder-storpool-tempest-exp/0fa49af/controller/logs/screen-n-cpu.txt.gz#_Nov_28_18_46_53_967021 and then, the very next log message for this request, suddenly https://spfactory.storpool.com/logs/38/696438/1/silent/cinder-storpool-tempest-exp/0fa49af/controller/logs/screen-n-cpu.txt.gz#_Nov_28_18_49_50_50388915:07
*** dpawlik has quit IRC15:08
*** ociuhandu has quit IRC15:13
*** ociuhandu has joined #openstack-cinder15:14
*** ociuhandu has quit IRC15:19
geguileolyarwood: I'm reviewing your updated patch, but I don't see any comment/change regarding the counting of calls, which was the reason for my downvote15:20
geguileolyarwood: also, I'm thinking that we could just decide to create/delete our own symlink instead of waiting for one from the system15:20
lyarwoodgeguileo: looking at the wrong PS? https://review.opendev.org/#/c/695564/2..3/os_brick/tests/initiator/connectors/test_iscsi.py15:24
geguileolyarwood: nop, that's the one15:24
geguileolyarwood: if you have more calls that assert will still say it's ok15:24
geguileoafaik15:24
geguileoiirc: if listdir_mock.assert_has_calls(3 * [mock.call('/dev/disk/by-id/')]) succeeds15:25
lyarwoodgeguileo: ah sorry I missed that15:25
geguileoit means that listdir_mock.assert_has_calls(2 * [mock.call('/dev/disk/by-id/')])15:25
geguileowill also15:25
lyarwoodgeguileo: I'll add that now, apologies.15:25
geguileolyarwood: oh, no worries  :-)15:25
geguileolyarwood: should we explore the faster solution?15:25
geguileocreate our own symlink?15:26
geguileoinstead of reusing one?15:26
geguileowe create it when we create the decrypted dm15:26
geguileoand we remove it after we remove the dm15:26
geguileothat way we wouldn't have to wait for udev rules to execute15:26
lyarwoodgeguileo: I'm trying to remove the workaround entirely with encrypted volumes by returning the normal decrypted dm path15:27
geguileolyarwood: thanks!! you are my hero!!!  :-)15:27
lyarwoodgeguileo: np, the issue with this is it isn't going to be backportable obviously15:28
lyarwoodgeguileo: https://review.opendev.org/#/q/topic:remove-iscsi-encryption-workaround+(status:open+OR+status:merged)15:28
lyarwoodgeguileo: I'll get that passing later once I've finished up with another bug15:29
geguileolyarwood: awesome!!15:29
*** martinkennelly has quit IRC15:29
geguileolyarwood: feel free to ping me once the os-brick code is ready, as I'll be happy to review it15:30
*** martinkennelly has joined #openstack-cinder15:31
*** e0ne has quit IRC15:34
*** enriquetaso has quit IRC15:40
*** jcosmao has joined #openstack-cinder15:42
*** martinkennelly has quit IRC15:49
*** udesale has quit IRC15:49
*** lpetrut has quit IRC15:52
*** martinkennelly has joined #openstack-cinder15:53
openstackgerritHelen Walsh proposed openstack/cinder stable/train: PowerMax Driver - QoS calculation failure  https://review.opendev.org/69672515:59
*** dave-mccowan has quit IRC16:01
*** ociuhandu has joined #openstack-cinder16:02
*** ociuhandu has quit IRC16:08
*** sapd1 has joined #openstack-cinder16:11
*** sfernand has quit IRC16:11
*** lpetrut has joined #openstack-cinder16:17
openstackgerritLee Yarwood proposed openstack/os-brick master: iscsi: Add _get_device_link retry when waiting for /dev/disk/by-id/ to populate  https://review.opendev.org/69556416:23
*** whoami-rajat has quit IRC16:28
*** nanzha has quit IRC16:33
openstackgerritHelen Walsh proposed openstack/cinder stable/stein: PowerMax Driver - PowerMax Formatted Vols Fix  https://review.opendev.org/69673416:36
*** do3meli has quit IRC17:01
*** spsurya has quit IRC17:05
*** mns96 has quit IRC17:13
*** lpetrut has quit IRC17:16
*** davidsha has quit IRC17:26
*** lpetrut has joined #openstack-cinder17:33
*** ociuhandu has joined #openstack-cinder17:33
*** psachin has quit IRC17:34
*** ociuhandu has quit IRC17:38
*** benfelin has joined #openstack-cinder17:39
*** ociuhandu has joined #openstack-cinder17:43
*** tosky has quit IRC17:50
*** baojg has joined #openstack-cinder17:54
*** enriquetaso has joined #openstack-cinder18:17
*** ociuhandu has quit IRC18:31
*** ociuhandu has joined #openstack-cinder19:09
*** ociuhandu has quit IRC19:15
openstackgerritErlon R. Cruz proposed openstack/cinder master: Fix DriverFilter string evaluations  https://review.opendev.org/69675619:16
*** tosky has joined #openstack-cinder19:36
*** martinkennelly has quit IRC19:52
*** jmlowe has quit IRC19:56
*** tesseract has quit IRC20:00
*** jmlowe has joined #openstack-cinder20:12
*** dklyle has quit IRC20:12
*** whfnst has quit IRC20:15
*** e0ne has joined #openstack-cinder20:17
*** e0ne has quit IRC20:40
*** dklyle has joined #openstack-cinder20:42
*** ociuhandu has joined #openstack-cinder20:50
*** jmlowe has quit IRC20:53
*** ociuhandu has quit IRC20:55
*** enriquetaso has quit IRC21:10
*** enriquetaso has joined #openstack-cinder21:13
openstackgerritSofia Enriquez proposed openstack/cinder master: Fix service-get-log to respect server filters  https://review.opendev.org/68600021:20
*** jmlowe has joined #openstack-cinder21:50
*** martinkennelly has joined #openstack-cinder21:53
*** e0ne has joined #openstack-cinder21:58
*** pcaruana has quit IRC22:03
*** e0ne has quit IRC22:10
*** enriquetaso has quit IRC22:52
*** ociuhandu has joined #openstack-cinder23:09
*** ociuhandu has quit IRC23:14
*** rcernin has quit IRC23:18
*** martinkennelly has quit IRC23:19
*** jcosmao has left #openstack-cinder23:26
*** baojg has quit IRC23:50
*** baojg has joined #openstack-cinder23:50
*** sapd1 has quit IRC23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!