Wednesday, 2019-05-29

*** Liang__ has joined #openstack-cinder00:16
*** enriquetaso has quit IRC00:22
*** Liang__ has quit IRC00:27
*** brinzhang has joined #openstack-cinder00:27
*** dave-mccowan has joined #openstack-cinder00:32
*** markvoelker has quit IRC00:33
*** dave-mccowan has quit IRC00:35
*** itlinux has joined #openstack-cinder00:55
*** baojg has joined #openstack-cinder00:58
*** baojg has quit IRC01:03
*** minmin has joined #openstack-cinder01:07
*** enriquetaso has joined #openstack-cinder01:21
openstackgerritMerged openstack/cinder master: move dothill exceptions  https://review.opendev.org/65786601:22
*** ruffian_sheep has joined #openstack-cinder01:31
ruffian_sheepwhoami-rajat:Hi,do u know how can i abandon a commit  and make updates to the existing patch.01:35
*** itlinux has quit IRC01:37
*** itlinux has joined #openstack-cinder01:44
*** boxiang has joined #openstack-cinder01:45
ruffian_sheephttps://review.opendev.org/#/c/661200/601:52
ruffian_sheepwhoami-rajat:Sean McGinnis asked me to abandon this commit and make changes on the previous commit. But I have already cleaned up the previous ones. I don't know how to switch to the previous commit now.01:54
*** itlinux has quit IRC01:56
*** Spencer_Yu has joined #openstack-cinder01:57
rosmaitaruffian_sheep: if i am reading Sean's comment correctly, he wants you to do the work on this review: https://review.opendev.org/#/c/61231101:57
rosmaitais your question, "how do i get the code from review 612311 into my git working tree?"01:58
ruffian_sheep<rosmaita>:But this submission was not submitted by me, and I don't have his account password. Https://review.opendev.org/#/c/61231102:01
rosmaitaruffian_sheep: that's ok, you can still get the code02:02
ruffian_sheep<rosmaita>:Sean McGinnis: Some comments, but please abandon this and make updates to the existing patch.  https://review.opendev.org/#/c/643519/202:02
ruffian_sheep<rosmaita>:I think he wants me to switch to a previous commit and continue to modify. I have submitted it before.02:03
rosmaitaruffian_sheep: what you can do is go to your personal cinder code repository02:03
ruffian_sheep<rosmaita>:So I think I need to switch to the previous commit now, and then change the commit of the code on that basis.02:04
rosmaitaif you do 'git review -d 612311' , it will download the current patch set for you and create a branch in your personal repo02:04
ruffian_sheepBut the last personal cinder code repository I have cleaned up. . .02:05
rosmaitathat's ok, git review -d will create the branch for you02:05
ruffian_sheep<rosmaita>:Thx!let me try02:05
rosmaitajust remember that after you make changes, do 'git commit --amend' and then do 'git review'02:06
rosmaitathat will put a new patch set into that gerrit review02:06
ruffian_sheep<rosmaita>:Yes, I just cleaned up the previous environment. I can't append changes with git commit --amend. Should I git review -d 643519? This is what I submitted.02:08
rosmaitaruffian_sheep: give me a minute to look at 64351902:09
rosmaitaruffian_sheep: still looking02:14
ruffian_sheep<rosmaita>:Get02:14
*** itlinux has joined #openstack-cinder02:25
rosmaitaruffian_sheep: ok, i think i have something for you02:27
rosmaitado git review -d 61231102:27
rosmaitait will create branch review/wuchongyao/train-drivers02:28
rosmaitathen do git review -d 64351902:28
rosmaitait will create branch review/hjy/train-drivers02:29
rosmaitathen checkout review/wuchongyao/train-drivers02:29
rosmaitathen to get your changes, do this for each of the files you changed:02:30
rosmaitagit checkout review/hjy/train-drivers cinder/tests/unit/test_macrosan_drivers.py02:30
rosmaitayou can do 'git diff --cached' to see the changes02:30
rosmaitaand when you are done, you can do 'git commit --amend'02:31
rosmaitathere are probably other ways to do it, but i think the above will work02:31
*** markvoelker has joined #openstack-cinder02:34
ruffian_sheepThat is very sorry. . . I am not very skilled with git, and the way gerrit is used is also very strange. Look at the online information about git in this is not very clear.02:39
ruffian_sheep<rosmaita>:http://paste.openstack.org/show/752200/02:40
ruffian_sheepIs it wrong with me?02:40
rosmaitaruffian_sheep: i have not seen that one before, you may have an old .git/config file02:43
rosmaitawhat happens when you do 'git review -s' ?02:43
ruffian_sheep<rosmaita>:give me a minute,I am cloning a new cinder repo02:49
*** m75abrams has joined #openstack-cinder02:53
ruffian_sheep<rosmaita> :http://paste.openstack.org/show/752202/02:54
ruffian_sheep<rosmaita> :Didn't react for that02:55
rosmaitalooking02:55
ruffian_sheep<rosmaita> :Should I pass the cmd git add . and git commit?02:56
rosmaitado you still have the repo around that you used to post 643519 ?02:58
ruffian_sheep<rosmaita> :Not,I think it have been cleared all02:59
rosmaitaok03:00
rosmaitain your new repo, in .git/config, what does it have for [remote "gerrit"] ?03:00
ruffian_sheepurl = https://lol@review.openstack.org/openstack/cinder.git fetch = +refs/heads/*:refs/remotes/gerrit/*03:01
ruffian_sheep<rosmaita> :http://paste.openstack.org/show/752203/03:04
rosmaitaruffian_sheep: i am not sure what's going on.  you can try replacing 'review.openstack.org' with 'review.opendev.org' and see if that helps03:06
rosmaitaotherwise, you might want to ask in #openstack-infra for someone who knows a lot about gerrit03:06
*** markvoelker has quit IRC03:08
ruffian_sheep<rosmaita> :Ok, maybe. . . I submit again? Is this operation allowed?03:08
rosmaitai am not sure what you mean03:09
ruffian_sheepI created another submission, not in 643519 nor in 612311.03:10
rosmaitai'm not sure that would help, those pastes show that you're having trouble connecting to gerrit to upload your patch03:11
rosmaitaruffian_sheep: i am leaving, good luck!03:22
ruffian_sheep<rosmaita> :Thx!:)I will try to solve it!03:22
*** enriquetaso has quit IRC03:26
*** threestrands has joined #openstack-cinder03:31
*** altlogbot_2 has quit IRC03:44
*** altlogbot_1 has joined #openstack-cinder03:45
*** psachin has joined #openstack-cinder03:48
*** minmin has quit IRC03:49
*** markvoelker has joined #openstack-cinder04:05
*** sapd1_x has joined #openstack-cinder04:17
*** tejdeep has joined #openstack-cinder04:20
tejdeepZuul is failing at tempest-slow-py3 check. it is failing in the test case tempest.scenario.test_network_advanced_server_ops.TestNetworkAdvancedServerOps, AssertionError: False is not true : Public network connectivity check failed04:23
tejdeepTimed out waiting for 172.24.5.224 to become reachable04:23
tejdeepis there any network issue in the Zuul infra?04:23
*** whoami-rajat has joined #openstack-cinder04:31
whoami-rajatruffian_sheep: Hi04:32
*** boxiang has quit IRC04:35
*** markvoelker has quit IRC04:37
whoami-rajatruffian_sheep: which version of python do you use to run CI?04:37
*** altlogbot_1 has quit IRC04:38
*** altlogbot_3 has joined #openstack-cinder04:39
*** trident has quit IRC04:39
*** altlogbot_3 has quit IRC04:40
*** altlogbot_3 has joined #openstack-cinder04:41
*** trident has joined #openstack-cinder04:41
*** baojg has joined #openstack-cinder04:48
*** sapd1_x has quit IRC05:00
*** pcaruana has joined #openstack-cinder05:15
*** tejdeep has quit IRC05:23
*** brinzhang has quit IRC05:27
*** boxiang has joined #openstack-cinder05:33
*** psachin has quit IRC05:34
*** markvoelker has joined #openstack-cinder05:34
ruffian_sheep<whoami-rajat>:python 2.7.605:36
*** baojg has quit IRC05:40
whoami-rajatruffian_sheep: hmm, the current requirement is py3 (specifically 3.7). could you test it against py37 and confirm the behavior ?05:42
*** yaawang has quit IRC05:48
*** yaawang has joined #openstack-cinder05:48
ruffian_sheep<whoami-rajat>:Let me try it. I used py35 and py36 to perform unit tests.05:53
*** boxiang has quit IRC05:53
ruffian_sheepbefore05:53
*** boxiang has joined #openstack-cinder05:57
*** rcernin has quit IRC06:01
*** rcernin has joined #openstack-cinder06:01
*** dpawlik has joined #openstack-cinder06:03
*** markvoelker has quit IRC06:08
whoami-rajatruffian_sheep:  okay. the team approves the CI (after py37 testing), so when can we expect to see it running on cinder gate jobs?06:12
*** brinzhang has joined #openstack-cinder06:18
*** lpetrut has joined #openstack-cinder06:23
*** brinzhang has quit IRC06:32
*** baojg has joined #openstack-cinder06:32
*** brinzhang has joined #openstack-cinder06:33
*** takamatsu has joined #openstack-cinder06:48
*** rcernin has quit IRC06:52
*** tesseract has joined #openstack-cinder07:05
*** markvoelker has joined #openstack-cinder07:05
*** tejdeep has joined #openstack-cinder07:06
*** tejdeep has quit IRC07:11
*** awalende has joined #openstack-cinder07:13
*** minmin has joined #openstack-cinder07:15
*** tejdeep has joined #openstack-cinder07:15
*** markvoelker has quit IRC07:37
*** tejdeep has quit IRC07:42
*** itlinux has quit IRC07:42
*** helenafm has joined #openstack-cinder07:51
*** takamatsu has quit IRC07:52
*** tstrul has joined #openstack-cinder07:56
*** e0ne has joined #openstack-cinder07:59
*** takamatsu has joined #openstack-cinder08:00
*** tkajinam has quit IRC08:10
*** sahid has joined #openstack-cinder08:12
ruffian_sheep<whoami-rajat>:i am not sure what you mean when can we expect to see it running on cinder gate jobs?08:23
openstackgerritYachika_Ralhan proposed openstack/cinder master: Add new OSNEXUS Quantastor Cinder driver  https://review.opendev.org/61750308:25
*** baojg has quit IRC08:29
*** baojg has joined #openstack-cinder08:30
*** ociuhandu has quit IRC08:31
*** lixiaoy1 has joined #openstack-cinder08:34
*** markvoelker has joined #openstack-cinder08:34
*** ociuhandu has joined #openstack-cinder08:35
lixiaoy1hemna: Hi Walter, could you help to review RSD driver https://review.opendev.org/#/c/621465/ ? Currently the CI is  ready and patch is updated based on your comments08:35
*** takamatsu has quit IRC08:52
*** lixiaoy1 has quit IRC08:55
ruffian_sheep<whoami-rajat>:http://paste.openstack.org/show/752221/ Is this right?08:58
*** boxiang has quit IRC08:59
*** strigazi has joined #openstack-cinder09:04
*** markvoelker has quit IRC09:08
*** baojg has quit IRC09:18
*** baojg has joined #openstack-cinder09:20
*** davidsha has joined #openstack-cinder09:51
*** threestrands has quit IRC09:54
*** m75abrams has quit IRC09:57
*** markvoelker has joined #openstack-cinder10:05
*** baojg has quit IRC10:05
*** baojg has joined #openstack-cinder10:06
*** dave-mccowan has joined #openstack-cinder10:31
*** dave-mccowan has quit IRC10:37
*** markvoelker has quit IRC10:37
openstackgerritMichael McAleer proposed openstack/cinder master: PowerMax Driver - Metro ODE Support  https://review.opendev.org/66046010:38
whoami-rajatruffian_sheep: like Other Vendor CI's running on every patch pushed in Cinder. when can we except to see your CI running ?10:40
whoami-rajatruffian_sheep: ah, that is for driver tests, i was referring to running tempest tests with py3710:41
openstackgerritMichael McAleer proposed openstack/cinder master: PowerMax Driver - Metro ODE Support  https://review.opendev.org/66046010:43
ruffian_sheep<whoami-rajat>:It's almost ok, now compile the shell script that collects conf and log. Test cases have been tuned.10:49
ruffian_sheep<whoami-rajat>: what.....Are you saying that I have to pass the py37 tempest test?:(10:51
*** carloss has joined #openstack-cinder11:00
*** markvoelker has joined #openstack-cinder11:34
*** brinzhang has quit IRC11:35
*** brinzhang has joined #openstack-cinder11:36
*** redrobot has quit IRC11:39
*** dviroel has joined #openstack-cinder11:46
*** Spencer_Yu has quit IRC11:52
*** tesseract has quit IRC11:53
*** tesseract has joined #openstack-cinder11:53
*** markvoelker has quit IRC11:54
*** markvoelker has joined #openstack-cinder11:54
*** m75abrams has joined #openstack-cinder11:56
*** jrubenst has joined #openstack-cinder11:59
*** helenafm has quit IRC12:05
*** e0ne has quit IRC12:16
*** redrobot has joined #openstack-cinder12:23
*** udesale has joined #openstack-cinder12:25
*** jrubenst has quit IRC12:27
*** jrubenst has joined #openstack-cinder12:28
*** Spencer_Yu has joined #openstack-cinder12:30
*** brinzhang has quit IRC12:39
*** whoami-rajat has quit IRC12:51
*** gmann has quit IRC12:53
*** helenafm has joined #openstack-cinder12:55
*** baojg has quit IRC12:55
*** kaisers has quit IRC13:01
*** kaisers has joined #openstack-cinder13:02
*** Spencer_Yu has quit IRC13:15
*** raghavendrat has quit IRC13:16
*** mriedem has joined #openstack-cinder13:20
*** eharney has joined #openstack-cinder13:20
*** e0ne has joined #openstack-cinder13:24
rajinirhemna: smcginnis I'll contact the CI guys on the DellEMC_PowerMAX failure13:36
smcginnisrajinir: Thanks!13:39
*** sahid has quit IRC13:40
*** sahid has joined #openstack-cinder13:42
openstackgerritEric Harney proposed openstack/cinder master: Bump hacking version to 1.1.x  https://review.opendev.org/65270313:49
*** lseki has joined #openstack-cinder13:51
*** mmethot_ has joined #openstack-cinder13:53
*** awalende has quit IRC13:53
*** mmethot has quit IRC13:54
*** awalende has joined #openstack-cinder13:54
*** m75abrams has quit IRC13:55
*** awalende_ has joined #openstack-cinder13:57
*** awalende has quit IRC13:58
*** enriquetaso has joined #openstack-cinder14:01
*** awalende_ has quit IRC14:02
*** whoami-rajat has joined #openstack-cinder14:03
*** gmann has joined #openstack-cinder14:10
*** itlinux has joined #openstack-cinder14:11
*** kaisers has quit IRC14:20
*** mrch_ has quit IRC14:20
*** kaisers has joined #openstack-cinder14:22
*** awalende has joined #openstack-cinder14:22
rosmaitaChangeMe14:24
rosmaitaall my secrets are revealed14:24
smcginnis:D14:26
smcginnisrosmaita: Switch it to ChangeM314:26
rosmaitathat would be too hard to remember14:26
smcginnisPassword123? ;)14:26
*** awalende has quit IRC14:27
rosmaita:)14:27
jbernardthat's the same combination on my luggage!14:27
smcginnishaha14:28
openstackgerritEric Harney proposed openstack/cinder master: Make py37 unit tests voting  https://review.opendev.org/66199614:29
*** lpetrut has quit IRC14:30
*** abishop has joined #openstack-cinder14:31
*** vishalmanchanda has joined #openstack-cinder14:32
*** abishop has quit IRC14:35
*** itlinux has quit IRC14:41
*** martinkennelly has joined #openstack-cinder14:53
hemnamep15:09
hemnajungleboyj: ping15:09
jungleboyjhemna:  Kind of pong.15:09
hemnakind of hi15:09
hemnaany word on the ceph-iscsi stuffs.15:10
hemnaI'm starting to take a look at it15:10
jungleboyjOh cool.15:10
hemnagoing to try and get some cycles from my mgr to work on it15:10
jungleboyjOk.  Can you make the meeting today?  Could we chat then?15:10
hemnasure15:10
jungleboyjThanks.  In another meeting now.15:11
*** tejdeep has joined #openstack-cinder15:12
*** tejdeep has quit IRC15:34
*** altlogbot_3 has quit IRC15:35
*** altlogbot_0 has joined #openstack-cinder15:35
*** irclogbot_0 has quit IRC15:36
*** irclogbot_0 has joined #openstack-cinder15:37
*** tesseract has quit IRC15:44
*** tstrul has quit IRC15:47
*** helenafm has quit IRC15:49
*** itlinux has joined #openstack-cinder15:54
*** _erlon_ has joined #openstack-cinder16:04
*** lpetrut has joined #openstack-cinder16:06
*** lpetrut has quit IRC16:14
*** martinkennelly has quit IRC16:14
openstackgerritMerged openstack/cinder master: move Dell EMC SC driver exceptions  https://review.opendev.org/66128816:19
openstackgerritMerged openstack/cinder master: [VNX] Fix test case issue  https://review.opendev.org/65970116:19
*** radeks__ has joined #openstack-cinder16:27
*** sahid has quit IRC16:31
*** dave-mccowan has joined #openstack-cinder16:40
*** davidsha has quit IRC16:53
*** kmalloc_away is now known as kmalloc16:55
*** tejdeep has joined #openstack-cinder16:55
whoami-rajatjungleboyj: smcginnis may i have your reviews on https://review.opendev.org/#/c/658974/ . it is also kind-of blocking my main work on the bp16:57
*** e0ne has quit IRC16:58
hemnawhoami-rajat: the ci failures are caused by not passing a volume type during creation requests?17:02
whoami-rajathemna: yep.17:05
hemnaurl?17:06
hemnaisn't the entire point of the default volume type creation is to take care of that exact use case?17:07
hemnasuch that if a volume type isn't passed, the default is automatically used17:07
whoami-rajathemna: yes but tests call sqlalchemy functions directly to create a volume/snapshot, i've handled the same in API17:08
whoami-rajathemna: i still have to take a look at tempest tests17:08
whoami-rajathttps://review.opendev.org/#/c/639180/17:08
whoami-rajats/in API/ at API level17:09
*** jcosmao has left #openstack-cinder17:12
hemnadamn ci17:13
smcginniswhoami-rajat: Can these unit test volume create calls be refactored to all call a common helper method in the base test case that takes care of all the necessary things to create a test volume in the DB?17:30
whoami-rajatsmcginnis: yes, i was thinking of creating a common parameterized func to handle most of the cases after fixing all the tests. funny though, there are multiple similar methods defined at different places in tests having same code. was thinking of removing the duplicacy too after the first step is done17:36
smcginniswhoami-rajat: That would be great. Good opportunity to clean up some redundancy that has sneaked in over the years.17:37
whoami-rajatsmcginnis: ++17:39
openstackgerritRajat Dhasmana proposed openstack/cinder master: Fix volume type quota defaults in quotas tests  https://review.opendev.org/65897417:50
*** awalende has joined #openstack-cinder17:55
openstackgerritEric Harney proposed openstack/cinder master: Bump hacking version to 1.1.x  https://review.opendev.org/65270317:57
*** ociuhandu has quit IRC17:57
*** awalende has quit IRC17:59
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add py37 entry in setup.cfg  https://review.opendev.org/66205918:30
eharneywhoami-rajat: only the py37 unit test job is voting... i'm starting to think we need some criteria written down for when we want to say things like "we now support Python 3.7"18:33
smcginniseharney: That would be a good question to pose to the mailing list. I've seen a really wide variety of stances on that from different projects.18:34
smcginnisWould be good to try to get some community concensus.18:34
eharneywe could just leave the setup.cfg classifier as "3"...18:36
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add py37 entry in setup.cfg  https://review.opendev.org/66205918:37
eharneyhttps://governance.openstack.org/tc/resolutions/20181024-python-update-process.html seems to indicate that running the unit test jobs is sufficient to go mark it supported in the pypi classifier18:39
eharneyi was also probably supposed to use the "openstack-python3-train-jobs" template in our zuul config, oops18:40
whoami-rajateharney: was just gonna mention the same https://review.opendev.org/#/c/657949/2/.zuul.yaml18:43
whoami-rajateharney: should i make the change in my patch?18:43
eharneywhoami-rajat: sure, it will functionally be the same as the change i made, but, good to document it properly18:45
whoami-rajateharney: agreed.18:46
*** sapd1_x has joined #openstack-cinder19:06
*** ociuhandu has joined #openstack-cinder19:18
*** dklyle has quit IRC19:21
*** dklyle has joined #openstack-cinder19:29
openstackgerritEric Harney proposed openstack/os-brick stable/rocky: Improve iSCSI device detection speed  https://review.opendev.org/66207619:45
*** mriedem has quit IRC19:48
*** mriedem has joined #openstack-cinder19:55
*** imacdonn has quit IRC19:56
*** imacdonn has joined #openstack-cinder19:56
*** ociuhandu has quit IRC19:58
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax docs - known issues with metro  https://review.opendev.org/65677020:16
*** ociuhandu has joined #openstack-cinder20:35
*** sapd1_x has quit IRC20:41
*** rosmaita has quit IRC20:43
*** ociuhandu has quit IRC20:45
*** rosmaita has joined #openstack-cinder20:48
openstackgerritMerged openstack/cinder master: Remove driver requirements of removed drivers  https://review.opendev.org/65777720:59
*** jrubenst has quit IRC21:01
*** radeks__ has quit IRC21:02
*** itlinux has quit IRC21:05
*** itlinux has joined #openstack-cinder21:13
*** whoami-rajat has quit IRC21:13
*** vishalmanchanda has quit IRC21:13
*** pcaruana has quit IRC21:23
*** mriedem has quit IRC21:36
*** udesale has quit IRC21:43
openstackgerritMerged openstack/cinder master: Make py37 unit tests voting  https://review.opendev.org/66199621:45
*** eharney has quit IRC21:48
openstackgerritSofia Enriquez proposed openstack/cinder master: Support Incremental Backup Completion In RBD  https://review.opendev.org/62794122:05
tejdeepeharney: I have enabled cinder_tempest_plugin in the CI and addressed  latest code review comments https://review.opendev.org/#/c/621465/44. if everything looks good can I get approval for merge?22:20
*** enriquetaso has quit IRC22:23
*** ianychoi has quit IRC22:32
*** ianychoi has joined #openstack-cinder22:33
*** tkajinam has joined #openstack-cinder22:54
*** enriquetaso has joined #openstack-cinder22:58
*** tejdeep has quit IRC22:59
*** awalende has joined #openstack-cinder23:00
*** _erlon_ has quit IRC23:03
*** awalende has quit IRC23:05
*** rcernin has joined #openstack-cinder23:06
*** rcernin has quit IRC23:07
*** rcernin has joined #openstack-cinder23:07
*** enriquetaso has quit IRC23:24
*** enriquetaso has joined #openstack-cinder23:24
*** tejdeep has joined #openstack-cinder23:52
*** tejdeep has quit IRC23:53
*** tejdeep_ has joined #openstack-cinder23:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!