| *** lseki has quit IRC | 00:20 | |
| *** carloss has quit IRC | 00:28 | |
| *** lixiaoy1 has joined #openstack-cinder | 00:38 | |
| *** mmethot has quit IRC | 01:12 | |
| *** gkadam has joined #openstack-cinder | 01:16 | |
| *** baojg has joined #openstack-cinder | 01:22 | |
| *** gkadam has quit IRC | 01:40 | |
| *** brinzhang has joined #openstack-cinder | 01:44 | |
| *** mmethot has joined #openstack-cinder | 01:55 | |
| *** ianychoi has joined #openstack-cinder | 02:00 | |
| *** whoami-rajat has joined #openstack-cinder | 02:12 | |
| *** enriquetaso has quit IRC | 02:31 | |
| openstackgerrit | Yong Huang proposed openstack/cinder master: [VNX] Fix test case issue https://review.opendev.org/659701 | 02:48 |
|---|---|---|
| *** minmin has joined #openstack-cinder | 03:00 | |
| *** awalende has joined #openstack-cinder | 03:13 | |
| *** awalende has quit IRC | 03:17 | |
| *** anks2k has joined #openstack-cinder | 03:20 | |
| anks2k | whoami-rajat: jungleboyj: hemna_: Would appreciate a review on https://review.opendev.org/617503 | 03:22 |
| *** gkadam has joined #openstack-cinder | 03:23 | |
| *** gkadam has quit IRC | 03:23 | |
| *** gaoyan has joined #openstack-cinder | 03:28 | |
| *** anks2k has quit IRC | 03:36 | |
| *** anks2k has joined #openstack-cinder | 03:39 | |
| *** psachin has joined #openstack-cinder | 03:41 | |
| openstackgerrit | Simon Dodsley proposed openstack/cinder master: Pure Storage FlashArray iSCSI driver target CIDR support https://review.opendev.org/659178 | 03:42 |
| *** ianychoi has quit IRC | 03:49 | |
| *** ianychoi has joined #openstack-cinder | 03:49 | |
| *** ianychoi has quit IRC | 03:52 | |
| *** ianychoi has joined #openstack-cinder | 03:52 | |
| *** gaoyan has quit IRC | 04:31 | |
| *** udesale has joined #openstack-cinder | 04:34 | |
| *** bhagyashris has joined #openstack-cinder | 04:55 | |
| *** gaoyan has joined #openstack-cinder | 05:14 | |
| *** pcaruana has joined #openstack-cinder | 05:20 | |
| *** brinzhang has quit IRC | 05:21 | |
| *** brinzhang has joined #openstack-cinder | 05:22 | |
| *** gaoyan has quit IRC | 05:29 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix volume type quota defaults in quotas tests https://review.opendev.org/658974 | 05:40 |
| *** radeks has joined #openstack-cinder | 05:50 | |
| *** Luzi has joined #openstack-cinder | 05:52 | |
| *** vishalmanchanda has joined #openstack-cinder | 05:54 | |
| *** ruffian_sheep has joined #openstack-cinder | 05:54 | |
| ruffian_sheep | jungleboyj|smcginnis|whoami-rajat:I modified my original environment and now I can generate an error-free html file. This is the content of the execution script volume_test and HTMLTestRunner files used. Does this meet the requirements for joining the main line of cinder? | 05:59 |
| ruffian_sheep | jungleboyj|smcginnis|whoami-rajat: volume_test http://paste.openstack.org/show/751496/ HTMLTestRunner http://paste.openstack.org/show/751497/ | 06:01 |
| *** baojg has quit IRC | 06:01 | |
| whoami-rajat | ruffian_sheep: Hi, could you provide the link to your driver patch? | 06:02 |
| ruffian_sheep | jungleboyj|smcginnis|whoami-rajat: This result has to trouble you to get a text to open the view, thank you very much. result http://paste.openstack.org/show/751495/ | 06:02 |
| ruffian_sheep | Yes, but I have not updated the submission yet. Can it be before? | 06:04 |
| *** lpetrut has joined #openstack-cinder | 06:05 | |
| whoami-rajat | ruffian_sheep: not updated? you've pushed a patch for your driver right? | 06:05 |
| whoami-rajat | ruffian_sheep: also i see some of the tests skipped like test_reset_group_snapshot_status , may i know the reason? | 06:06 |
| *** faizy98 has quit IRC | 06:07 | |
| ruffian_sheep | <whoami-rajat>：Yes, I have submitted a driver before, on the branch.https://review.opendev.org/#/c/643519/ | 06:09 |
| *** sapd1_x has joined #openstack-cinder | 06:10 | |
| ruffian_sheep | <whoami-rajat>：Later, I learned more about the CI process, set up the CI and debug the errors. This is an earlier one, and has not been updated after debugging. | 06:10 |
| whoami-rajat | ruffian_sheep: okay, i remember we discussed regarding this in the PTG, IMO updating the driver constantly to make it work should be the first priority else setting up the CI for a "unready" driver isn't worth | 06:12 |
| *** raghavendrat has quit IRC | 06:14 | |
| ruffian_sheep | <whoami-rajat>：Because we are already using our own developed cinder driver, we provide it directly for user. So we went directly to build CI | 06:15 |
| ruffian_sheep | <whoami-rajat>：http://paste.openstack.org/show/751498/ This is my configuration file, I did not find the settings for the group. In addition, the driver does not support group operations for the time being, and I see that the use cases are used to do group related operations. | 06:17 |
| whoami-rajat | ruffian_sheep: so you've a ready driver in your environment, then i would recommend to update the driver patch ASAP | 06:19 |
| whoami-rajat | ruffian_sheep: hmm, so consistency group isn't supported by your driver? | 06:20 |
| ruffian_sheep | <whoami-rajat>：Yes, I am currently planning to debug the use case after passing the tempest and then update the branch. So I want to confirm if there are any shortages. | 06:20 |
| ruffian_sheep | <whoami-rajat>：Yes, it is not supported now. It was tested first based on most of the features required by the driver. Is the consistency group necessarily done? I see the documentation showing that this is optional. | 06:22 |
| ruffian_sheep | https://docs.openstack.org/cinder/latest/contributor/drivers.html? | 06:22 |
| whoami-rajat | ruffian_sheep: okay, but you can just update the driver and CI and then we can review both on gerrit, easier than sending html's for the result :) | 06:24 |
| whoami-rajat | ruffian_sheep: yes, it is optional, i was just querying. | 06:25 |
| *** sahid has joined #openstack-cinder | 06:25 | |
| whoami-rajat | ruffian_sheep: also that will allow reviewers in different TZ's to view your driver progress, i think i'm only one currently aware of the state of it. | 06:26 |
| ruffian_sheep | Emmm my company let me first pass the use case and then provide the CI environment, we have to get a separate network to the community. There is an extra charge, so let me start the pre-work and then open the network. | 06:27 |
| ruffian_sheep | <whoami-rajat>: I also think: (But the work environment cannot be directly connected to the community, so the implementation plan needs to consider the cost. | 06:29 |
| *** baojg has joined #openstack-cinder | 06:36 | |
| ruffian_sheep | jungleboyj|smcginnis|whoami-rajat:I am not very clear about the last problem remaining in debugging. This is my profile confidence. I didn't set up a keypair here, and the settings used to create the network are private or shared. But the way he authenticates is keypair, and the network used to build the instance is public, which I am not very clear about. | 06:36 |
| ruffian_sheep | jungleboyj|smcginnis|whoami-rajat: /opt/stack/tempest/etc/tempest.conf http://paste.openstack.org/show/751498/ log http://paste.openstack.org/show/751499/ | 06:37 |
| ruffian_sheep | jungleboyj|smcginnis|whoami-rajat: log from the cmd : tox -e all -- volume --concurrency=1| | 06:39 |
| whoami-rajat | ruffian_sheep: are your referring to test_volume_boot_pattern failing? | 06:44 |
| ruffian_sheep | <whoami-rajat>: yes,it didn't follow my setting ing the configration to use the password. | 06:46 |
| whoami-rajat | ruffian_sheep: i think that test has also caused problems in other CI's. most of the CI's currently are ignoring that test AFAIK | 06:54 |
| whoami-rajat | ruffian_sheep: also your driver doesn't currently support retyping right? | 06:55 |
| ruffian_sheep | <whoami-rajat>: support retyping {0} tempest.api.volume.admin.test_volume_retype.VolumeRetypeWithoutMigrationTest.test_available_volume_retype [8.479916s] ... ok | 06:56 |
| whoami-rajat | ruffian_sheep: i mean retype with migration | 06:57 |
| whoami-rajat | ruffian_sheep: anyways that's also not important. if you skip/disable the test_volume_boot_pattern test, your CI would be functioning correctly right? | 06:59 |
| openstackgerrit | pengyuesheng proposed openstack/python-cinderclient master: Add Python 3.7 to tox https://review.opendev.org/659725 | 06:59 |
| ruffian_sheep | <whoami-rajat>: I think this is the case, I want to confirm whether the passed use cases meet the criteria for joining the main line. | 07:00 |
| ruffian_sheep | If it is not enough, I will debug and add the required test cases. The retype with migration you said should be that I only used one backend to operate. I can try to turn this feature on. Try it again. | 07:01 |
| whoami-rajat | ruffian_sheep: I won't be able to decide that alone. will need smcginnis and jungleboyj to take a look. but as far as i can tell, it looks ready to me. | 07:03 |
| ruffian_sheep | <whoami-rajat>:That is really great! (づ ̄3 ̄)づ╭❤~Love you | 07:04 |
| whoami-rajat | ruffian_sheep: oh yeah, i saw multi-backend was commented in tempest.conf so associated tests skipped. i don't think that is much needed so you can leave it. | 07:05 |
| whoami-rajat | ruffian_sheep: oh i missed some cases | 07:08 |
| *** tesseract has joined #openstack-cinder | 07:08 | |
| whoami-rajat | ruffian_sheep: the backup tests are being skipped | 07:09 |
| *** awalende has joined #openstack-cinder | 07:11 | |
| *** awalende has quit IRC | 07:13 | |
| ruffian_sheep | <whoami-rajat>:Backup is what needs to be added ? | 07:15 |
| whoami-rajat | ruffian_sheep: no, multi-attach, backup and multi-backend functionality isn't required, i'm finding some cases missing in image_test ... still checking | 07:16 |
| *** awalende has joined #openstack-cinder | 07:17 | |
| whoami-rajat | ruffian_sheep: http://paste.openstack.org/show/751501/ these are some tests in compute directory that are missed by your regex | 07:19 |
| *** rcernin has quit IRC | 07:19 | |
| whoami-rajat | ruffian_sheep: there are 2 tests in tempest.scenarios but they are going to be skipped anyway. so adding the above tests i mentioned will cover all cases. | 07:36 |
| *** mcgigglier has joined #openstack-cinder | 07:50 | |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax driver - changing from 9.0 to 9.1 REST endpoints https://review.opendev.org/653786 | 08:07 |
| *** lpetrut has quit IRC | 08:09 | |
| openstackgerrit | pengyuesheng proposed openstack/python-cinderclient master: Add Python 3.7 to tox https://review.opendev.org/659725 | 08:13 |
| ruffian_sheep | <whoami-rajat>:Maybe I should change the path to /opt/stack/tempest/tempest | 08:15 |
| whoami-rajat | ruffian_sheep: and what will be the regex then? | 08:16 |
| *** sapd1_x has quit IRC | 08:21 | |
| *** awalende has quit IRC | 08:24 | |
| *** wxy-xiyuan has left #openstack-cinder | 08:27 | |
| *** lixiaoy1 has quit IRC | 08:28 | |
| ruffian_sheep | <whoami-rajat>:what about use the regex of test*?I use it to run the cmd tox -e all -- volume --concurrency=1 | 08:29 |
| *** lpetrut has joined #openstack-cinder | 08:29 | |
| *** awalende has joined #openstack-cinder | 08:37 | |
| ruffian_sheep | <whoami-rajat>:tempest.api.compute.servers.test_device_tagging&&tempest.scenario.test_volume_boot_pattern&&tempest.scenario.test_volume_migrate_attached right? | 08:40 |
| *** tkajinam has quit IRC | 08:44 | |
| openstackgerrit | pengyuesheng proposed openstack/python-cinderclient master: Add Python 3.7 to tox https://review.opendev.org/659725 | 08:45 |
| *** baojg has quit IRC | 08:45 | |
| openstackgerrit | Liang Fang proposed openstack/python-cinderclient master: upload-to-image returns NoneType error https://review.opendev.org/659749 | 08:46 |
| ruffian_sheep | <whoami-rajat>:I think the log of executing the tox output should include what you said. I have one use case left and I don't know how to solve it. When he wants to ssh my instance, it doesn't depend on my configuration file, it uses the keypair which I have not configured. | 08:46 |
| *** baojg has joined #openstack-cinder | 08:50 | |
| *** davidsha has joined #openstack-cinder | 08:52 | |
| openstackgerrit | yenai proposed openstack/cinder master: Speed up starting cinder-backup https://review.opendev.org/657543 | 08:55 |
| openstackgerrit | Merged openstack/os-brick stable/queens: Fix FC case sensitive scanning https://review.opendev.org/659281 | 09:01 |
| *** baojg has quit IRC | 09:06 | |
| *** baojg has joined #openstack-cinder | 09:07 | |
| *** sapd1_x has joined #openstack-cinder | 09:13 | |
| *** raghavendrat has joined #openstack-cinder | 09:14 | |
| ruffian_sheep | <whoami-rajat>:Is it that tox can only use keypair to ssh instance? | 09:14 |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax driver - add 'target_array_model' to metadata https://review.opendev.org/644620 | 09:16 |
| *** e0ne has joined #openstack-cinder | 09:17 | |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax driver - clone improvements https://review.opendev.org/653469 | 09:19 |
| openstackgerrit | Trent Lloyd proposed openstack/cinder master: RBD: Add 512e/4k disk geometry configuration https://review.opendev.org/658283 | 09:19 |
| openstackgerrit | Trent Lloyd proposed openstack/cinder master: RBD: Add 512e/4k disk geometry configuration https://review.opendev.org/658283 | 09:22 |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax driver - locking improvements https://review.opendev.org/653717 | 09:22 |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax driver - Rapid TDEV Deallocation https://review.opendev.org/658830 | 09:24 |
| *** baojg has quit IRC | 09:32 | |
| *** bhagyashris has quit IRC | 09:36 | |
| *** sapd1_x has quit IRC | 09:36 | |
| openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax driver - Rapid TDEV Deallocation https://review.opendev.org/658830 | 09:42 |
| *** awalende has quit IRC | 09:49 | |
| *** sapd1_x has joined #openstack-cinder | 09:49 | |
| *** awalende has joined #openstack-cinder | 09:49 | |
| *** rcernin has joined #openstack-cinder | 09:50 | |
| *** minmin has quit IRC | 09:50 | |
| *** awalende has quit IRC | 09:50 | |
| *** awalende has joined #openstack-cinder | 09:50 | |
| *** minmin has joined #openstack-cinder | 09:51 | |
| *** minmin has quit IRC | 09:52 | |
| *** sapd1_x has quit IRC | 09:59 | |
| openstackgerrit | ya.wang proposed openstack/cinder master: WIP: Ceph: Cinder volume revert to snapshot support https://review.opendev.org/659768 | 10:07 |
| openstackgerrit | Sneha Rai proposed openstack/cinder master: HPE 3PAR-Added support for multiattach feature in hpe3par cinder driver https://review.opendev.org/659443 | 10:09 |
| *** awalende has quit IRC | 10:24 | |
| *** brinzhang has quit IRC | 10:28 | |
| *** whoami-rajat has quit IRC | 10:42 | |
| *** vishalmanchanda has quit IRC | 10:44 | |
| *** awalende has joined #openstack-cinder | 10:48 | |
| *** baojg has joined #openstack-cinder | 11:02 | |
| *** henriqueof has joined #openstack-cinder | 11:06 | |
| *** jcosmao has joined #openstack-cinder | 11:18 | |
| *** awalende has quit IRC | 11:23 | |
| *** rcernin has quit IRC | 11:36 | |
| *** awalende has joined #openstack-cinder | 11:39 | |
| *** awalende has quit IRC | 12:03 | |
| *** awalende has joined #openstack-cinder | 12:05 | |
| *** dviroel has joined #openstack-cinder | 12:09 | |
| pcaruana | Hi, this one is needing some workflow love https://review.opendev.org/651184/ | 12:18 |
| *** mchlumsky has joined #openstack-cinder | 12:24 | |
| *** udesale has quit IRC | 12:30 | |
| *** udesale has joined #openstack-cinder | 12:31 | |
| *** dklyle has joined #openstack-cinder | 12:50 | |
| *** enriquetaso has joined #openstack-cinder | 13:03 | |
| raghavendrat | Hi core reviewers, It would be great if anyone can have a look at https://review.opendev.org/#/c/657585/ and review | 13:07 |
| *** jmlowe has quit IRC | 13:11 | |
| *** awalende has quit IRC | 13:15 | |
| *** enriquetaso has quit IRC | 13:17 | |
| *** mriedem has joined #openstack-cinder | 13:21 | |
| *** lseki has joined #openstack-cinder | 13:22 | |
| *** raghavendrat has quit IRC | 13:45 | |
| *** mmethot has quit IRC | 13:50 | |
| *** jmlowe has joined #openstack-cinder | 14:00 | |
| *** enriquetaso has joined #openstack-cinder | 14:05 | |
| *** lpetrut has quit IRC | 14:06 | |
| *** mmethot has joined #openstack-cinder | 14:13 | |
| *** baojg has quit IRC | 14:16 | |
| *** baojg has joined #openstack-cinder | 14:16 | |
| *** baojg has quit IRC | 14:16 | |
| *** baojg has joined #openstack-cinder | 14:17 | |
| *** baojg has quit IRC | 14:17 | |
| *** baojg has joined #openstack-cinder | 14:18 | |
| *** baojg has quit IRC | 14:19 | |
| *** baojg has joined #openstack-cinder | 14:19 | |
| *** baojg has quit IRC | 14:19 | |
| *** baojg has joined #openstack-cinder | 14:21 | |
| *** baojg has quit IRC | 14:21 | |
| *** baojg has joined #openstack-cinder | 14:22 | |
| *** baojg has quit IRC | 14:23 | |
| *** baojg has joined #openstack-cinder | 14:23 | |
| *** baojg has quit IRC | 14:23 | |
| *** baojg has joined #openstack-cinder | 14:24 | |
| *** baojg has quit IRC | 14:24 | |
| *** dpawlik has quit IRC | 14:24 | |
| *** baojg has joined #openstack-cinder | 14:25 | |
| *** Luzi has quit IRC | 14:25 | |
| *** baojg has quit IRC | 14:25 | |
| *** baojg has joined #openstack-cinder | 14:25 | |
| *** baojg has quit IRC | 14:26 | |
| *** baojg has joined #openstack-cinder | 14:26 | |
| *** baojg has quit IRC | 14:27 | |
| *** baojg has joined #openstack-cinder | 14:27 | |
| *** baojg has quit IRC | 14:27 | |
| *** baojg has joined #openstack-cinder | 14:28 | |
| *** baojg has quit IRC | 14:28 | |
| *** baojg has joined #openstack-cinder | 14:28 | |
| *** baojg has quit IRC | 14:29 | |
| *** baojg has joined #openstack-cinder | 14:29 | |
| *** baojg has quit IRC | 14:30 | |
| *** baojg has joined #openstack-cinder | 14:31 | |
| *** baojg has quit IRC | 14:31 | |
| *** baojg has joined #openstack-cinder | 14:32 | |
| *** baojg has quit IRC | 14:32 | |
| *** baojg has joined #openstack-cinder | 14:32 | |
| *** baojg has quit IRC | 14:33 | |
| *** baojg has joined #openstack-cinder | 14:33 | |
| *** baojg has quit IRC | 14:34 | |
| *** baojg has joined #openstack-cinder | 14:34 | |
| *** baojg has quit IRC | 14:34 | |
| *** baojg has joined #openstack-cinder | 14:35 | |
| *** baojg has quit IRC | 14:35 | |
| *** baojg has joined #openstack-cinder | 14:36 | |
| *** baojg has quit IRC | 14:36 | |
| *** baojg has joined #openstack-cinder | 14:36 | |
| *** baojg has quit IRC | 14:37 | |
| *** baojg has joined #openstack-cinder | 14:37 | |
| *** baojg has quit IRC | 14:38 | |
| *** baojg has joined #openstack-cinder | 14:38 | |
| *** baojg has quit IRC | 14:38 | |
| *** baojg has joined #openstack-cinder | 14:39 | |
| *** baojg has quit IRC | 14:39 | |
| openstackgerrit | Merged openstack/cinder stable/queens: NetApp: Return all iSCSI targets-portals https://review.opendev.org/651184 | 14:39 |
| *** baojg has joined #openstack-cinder | 14:40 | |
| *** baojg has quit IRC | 14:41 | |
| *** baojg has joined #openstack-cinder | 14:41 | |
| *** jmlowe has quit IRC | 14:41 | |
| *** baojg has quit IRC | 14:42 | |
| *** baojg has joined #openstack-cinder | 14:42 | |
| *** baojg has quit IRC | 14:42 | |
| *** baojg has joined #openstack-cinder | 14:43 | |
| *** baojg has quit IRC | 14:43 | |
| *** kmalloc is now known as kmalloc_away | 14:47 | |
| *** carloss has joined #openstack-cinder | 14:54 | |
| *** jmlowe has joined #openstack-cinder | 14:58 | |
| *** mcgigglier has quit IRC | 15:05 | |
| smcginnis | jungleboyj, hemna_: I've noticed we have a lot more little things that new driver developers are just supposed to somehow know. | 15:14 |
| jungleboyj | smcginnis: Morning. Was just about to ping you. | 15:14 |
| smcginnis | I plan on adding docs to our actually docs instead of our wiki, but started putting together a sort of checklist of things they can go through and make sure they are ready. | 15:14 |
| jungleboyj | Looking at the Quantastor driver. | 15:14 |
| *** qqmber has joined #openstack-cinder | 15:14 | |
| smcginnis | Would like to group source that into a good list | 15:14 |
| smcginnis | Started here: https://etherpad.openstack.org/p/cinder-driver-reviews | 15:14 |
| jungleboyj | smcginnis: ++ Cool. | 15:15 |
| qqmber | nope.. there is errors.. but I don't understand them... i guess | 15:15 |
| qqmber | forget last line | 15:15 |
| smcginnis | :) | 15:16 |
| qqmber | hi everyone... I'm using Cinder, no Ceph for anything... everything is "Dockerized" (kolla-ansible). In tgtd log appears a LOOOOOOT this: | 15:16 |
| jungleboyj | :-) | 15:16 |
| qqmber | {"log":"tgtd: iscsi_noop_out_rx_start(1694) ffffffff 31 0\n","stream":"stderr","time":"2019-05-17T15:05:33.718926452Z"} | 15:16 |
| qqmber | 600GB of logs with this in 3 days | 15:16 |
| jungleboyj | hemna_: ^^^ | 15:16 |
| woojay | smcginnis: I'll be happy to add details to your guide. | 15:18 |
| jungleboyj | woojay: ++ | 15:18 |
| smcginnis | Great! | 15:18 |
| smcginnis | jungleboyj: What does "A failed run should include the information for rerunning." mean? | 15:18 |
| jungleboyj | That the CI should post the information for doing a recheck. | 15:19 |
| smcginnis | We have a required third party recheck trigger, why would we need that? | 15:20 |
| jungleboyj | I really appreciate CIs that do that so I can just copy and paste it and not worry about getting it right. | 15:20 |
| jungleboyj | And because I always forget the the recheck trigger is and have to go look it up. | 15:20 |
| smcginnis | Prepending "run-" to a copy paste of their name is so hard. :{ | 15:20 |
| smcginnis | :P | 15:20 |
| jungleboyj | You have to go look up the name as well. | 15:21 |
| *** sapd1_x has joined #openstack-cinder | 15:21 | |
| smcginnis | ? | 15:21 |
| smcginnis | You can read text that includes the recheck trigger in the comment but not read the name on the comment? | 15:21 |
| jungleboyj | Lenovo Storage CI is not the name to do the retrigger. | 15:22 |
| smcginnis | It better be, that's are documented required recheck trigger. | 15:22 |
| * smcginnis gets unsupported patch ready. | 15:22 | |
| smcginnis | hehe :) | 15:22 |
| smcginnis | s/are/our/ | 15:22 |
| jungleboyj | No. Am I stupid here? | 15:23 |
| jungleboyj | For example Dell EMC ScaleIO CI | 15:23 |
| jungleboyj | To re run you have to do run-dell-emc-vxflexos to retrigger. | 15:23 |
| smcginnis | According to what we documented as required, that should be "run-Dell EMC ScaleIO CI" | 15:23 |
| smcginnis | And even though I keep commented on their patches to stop using that form, they still do. | 15:23 |
| jungleboyj | The name of the CI Account is not the same as the CI Account. | 15:23 |
| smcginnis | Haven't checked if they support both, which would be fine. | 15:23 |
| smcginnis | Right | 15:24 |
| smcginnis | We say the name of the CI, not the user id. | 15:24 |
| smcginnis | And documented an example showing so. | 15:24 |
| jungleboyj | So you are saying that run-Lenovo Storage CI should trigger it? | 15:24 |
| smcginnis | Yes | 15:24 |
| smcginnis | And if we find any that don't, we should make them fix that. Which is why I added it to the checklist. | 15:25 |
| jungleboyj | Huh. I didn't know that was the case. | 15:25 |
| jungleboyj | So many CIs are not doing that. | 15:25 |
| jungleboyj | I don't think. | 15:25 |
| jungleboyj | Ok. I retract my comment then. | 15:25 |
| smcginnis | It's only been like three years that we declared and documented that that was the requirement. | 15:26 |
| jungleboyj | I bet if we go and test it a lot of CIs aren't going to work. | 15:26 |
| smcginnis | https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#How_do_I_trigger_my_CI_to_rerun_on_gerrit_comments.3F | 15:26 |
| smcginnis | Probably. Which is an issue, but not one big enough that's motivated me to start really pushing. | 15:26 |
| smcginnis | I just want to make sure new drivers are correct. | 15:26 |
| jungleboyj | Ok. Now I know. :-) | 15:26 |
| jungleboyj | Yeah, something to go back and look at. | 15:26 |
| smcginnis | Really wish more CIs would follow that last part of the documentation too about not running unless zuul gives +1. | 15:27 |
| woojay | I totally missed that until you told me about it... 8-) | 15:29 |
| *** jmlowe has quit IRC | 15:38 | |
| qqmber | what this log line means? {"log":"tgtd: iscsi_noop_out_rx_start(1694) ffffffff 31 0\n","stream":"stderr","time":"2019-05-17T15:05:33.718926452Z"} | 15:42 |
| qqmber | I'm not iscsi expert... | 15:43 |
| smcginnis | qqmber: Not sure what that would be from. It doesn't happen in non-containerized deployments. Have you tried asking the kolla folks if that's a know issue? | 15:46 |
| qqmber | yes, I'm there | 15:47 |
| qqmber | smcginnis: thanks | 15:47 |
| jungleboyj | qqmber: https://www.spinics.net/lists/linux-stgt/msg03806.html | 15:48 |
| jungleboyj | Sounds like a timeout might be getting exceeded? | 15:48 |
| qqmber | jungleboyj: the thing is.. I'm not having hanging... weird... | 15:49 |
| jungleboyj | Oh, so things are working ok but you are getting tons of logging? | 15:50 |
| qqmber | jungleboyj: exactly | 15:50 |
| smcginnis | How's performance? Maybe it is needing to continually reset the session? | 15:51 |
| jungleboyj | That is odd. I wonder if they just have the logging set too high? | 15:51 |
| qqmber | smcginnis: I don't know, because this is a new installation... I don't have anything to compare to... | 15:56 |
| *** sahid has quit IRC | 15:57 | |
| qqmber | jungleboyj: I thought the same.. but.. that's an error message | 15:57 |
| jungleboyj | Are you seeing dropped packets on the interface that iSCSI is using? | 15:57 |
| qqmber | this is only localhost traffic (not all of them, but 90%+++) | 15:58 |
| qqmber | I configure it to have in the sam ehost the volumes and the instances.. | 15:59 |
| qqmber | because this are very read/write intensive | 15:59 |
| jungleboyj | Interesting. That would not be a standard configuration. | 16:02 |
| jungleboyj | Wonder if you are hitting a bug in tgtd then? | 16:03 |
| qqmber | {"log":"tgtd: iscsi_noop_out_rx_start(1694) ffffffff 31 0\n","stream":"stderr","time":"2019-05-17T15:05:33.718926452Z"} | 16:06 |
| qqmber | but that line... tells you anything? | 16:06 |
| qqmber | besides there is a stderr? | 16:06 |
| jungleboyj | qqmber: Trying to get a clue from the tgtd code but don't really understand. | 16:15 |
| qqmber | :( | 16:15 |
| jungleboyj | It is one of the Opcode values . It is in iscsi_task_rx_start . | 16:16 |
| jungleboyj | It gets send to iscsi_noop_out_rx_start | 16:16 |
| jungleboyj | https://github.com/fujita/tgt/blob/master/usr/iscsi/iscsid.c#L1696 | 16:16 |
| jungleboyj | That is where the printf is coming from. | 16:16 |
| *** enriquetaso has quit IRC | 16:17 | |
| *** tesseract has quit IRC | 16:17 | |
| *** psachin has quit IRC | 16:17 | |
| *** tesseract has joined #openstack-cinder | 16:18 | |
| jungleboyj | I wonder if it is because you are using localhost it is going down the noop path. | 16:18 |
| jungleboyj | Not sure though. | 16:19 |
| *** whoami-rajat has joined #openstack-cinder | 16:20 | |
| *** jcosmao has left #openstack-cinder | 16:31 | |
| qqmber | jungleboyj: thanks! I'll investigate that... | 16:43 |
| *** davidsha has quit IRC | 16:48 | |
| *** sapd1_x has quit IRC | 16:48 | |
| *** mriedem is now known as mriedem_away | 16:49 | |
| qqmber | jungleboyj: I don't think is because I'm using localhost (is not configured to 127.0.0.1 but the local em1 IP!), because I have this exact issue in an older deployment, where not everything is in localhost.. | 16:55 |
| *** tesseract has quit IRC | 16:58 | |
| hemna_ | doink | 16:58 |
| hemna_ | what's up | 16:59 |
| *** tesseract has joined #openstack-cinder | 16:59 | |
| *** carloss has quit IRC | 17:03 | |
| *** enriquetaso has joined #openstack-cinder | 17:14 | |
| *** udesale has quit IRC | 17:15 | |
| *** tesseract has quit IRC | 17:17 | |
| *** e0ne has quit IRC | 17:17 | |
| jungleboyj | qqmber: Hmmm, strange. | 17:20 |
| jungleboyj | hemna_: qqmber is seeing lots and lots of logging from iSCSI. You have more experience with iSCSI under the covers than I. So thought you might have thoughts. | 17:20 |
| hemna_ | I've never seen that before | 17:24 |
| hemna_ | https://www.spinics.net/lists/linux-stgt/msg03806.html | 17:24 |
| hemna_ | seems related | 17:24 |
| jungleboyj | hemna_: :-) I shared that earlier too. | 17:24 |
| hemna_ | maybe a networking issue | 17:25 |
| hemna_ | containerd networking... | 17:25 |
| hemna_ | https://github.com/fujita/tgt/blob/master/usr/iscsi/iscsid.c#L1690 | 17:28 |
| hemna_ | it's not an error | 17:30 |
| hemna_ | it's just from the dprintf on line 1696 | 17:30 |
| jungleboyj | Yeah, I didn't think so either. | 17:30 |
| *** enriquetaso has quit IRC | 17:32 | |
| *** enriquetaso has joined #openstack-cinder | 17:34 | |
| hemna_ | qqmber: I'd check to see how tgtd is getting launched. My guess is that there is a -d <number> on the command line enabling debug logging | 17:34 |
| hemna_ | which is causing that to get constantly logged | 17:34 |
| hemna_ | qqmber:https://manpages.ubuntu.com/manpages/bionic/man8/tgtd.8.html | 17:35 |
| *** jdillaman has quit IRC | 17:56 | |
| smcginnis | hemna_: If you didn't see it, would love your input on https://etherpad.openstack.org/p/cinder-driver-reviews | 18:21 |
| *** mriedem_away is now known as mriedem | 18:23 | |
| hemna_ | smcginnis:ok checking | 18:35 |
| smcginnis | Cool, thanks. | 18:35 |
| *** itlinux has joined #openstack-cinder | 18:38 | |
| *** whoami-rajat has quit IRC | 18:39 | |
| *** mvkr has joined #openstack-cinder | 18:49 | |
| hemna_ | so all drivers have to be apache 2 license? | 19:00 |
| hemna_ | not lgpl or other OSS based licenses? | 19:00 |
| *** swegener has quit IRC | 19:01 | |
| smcginnis | hemna_: Yeah, libs can be different OSI licenses, but any code we accept in tree absolutely has to be Apache 2. | 19:02 |
| *** jmlowe has joined #openstack-cinder | 19:03 | |
| hemna_ | I think drivers should also be required to have a version specified in them | 19:03 |
| hemna_ | and the version history in the driver comment block too | 19:04 |
| smcginnis | Line 18? | 19:04 |
| smcginnis | Version history hasn't been a requirement, but I do like having that too. | 19:04 |
| hemna_ | ah yah line 18 | 19:04 |
| hemna_ | it's not much effort to have that version history | 19:05 |
| smcginnis | Yeah | 19:05 |
| hemna_ | and it's really helpful to see | 19:05 |
| smcginnis | Feel free to throw that in there. | 19:05 |
| hemna_ | ok added | 19:05 |
| smcginnis | I'm mainly trying to capture all the little things we end up downvoting new driver patches on that really the contributors don't have much chance of knowing they even need to do. So whatever we can put in here that helps, hopefully that will result in new drivers needing so many revisions. | 19:06 |
| hemna_ | yah it's a great idea | 19:06 |
| smcginnis | *not needing | 19:06 |
| hemna_ | and this should get converted into documentation for driver devs? | 19:06 |
| hemna_ | not just captured in the etherpad? | 19:06 |
| smcginnis | Yeah, after we iterate on this, then I want to add something to our actual docs, not just our wiki. | 19:07 |
| hemna_ | sweet | 19:07 |
| hemna_ | should state what minimum CI tests should be run | 19:09 |
| hemna_ | and how to document any that are skipped | 19:09 |
| hemna_ | and why | 19:09 |
| hemna_ | I added a few things | 19:09 |
| hemna_ | looks good | 19:09 |
| smcginnis | Yeah, that would be good. And including our tempest plugin. | 19:09 |
| hemna_ | how about, driver required libraries need to be python 3 compliant, and in global requirements | 19:10 |
| hemna_ | any the pypi based driver requirements need to be in setup.cfg (once my patch lands) https://review.opendev.org/#/c/656724/ | 19:12 |
| hemna_ | as well as any binary dependencies need to be OSS licensed and placed in bindep | 19:13 |
| smcginnis | Added a few more things. | 19:14 |
| smcginnis | Wow, there really is a lot we expect new driver developers to know. | 19:15 |
| hemna_ | yah, it's a lot | 19:16 |
| hemna_ | should we add some info about supporting older release, and how to do that? | 19:17 |
| hemna_ | backporting a fix the entire chain of releases back to the target release... | 19:17 |
| hemna_ | what's allowed to backport, and what's not | 19:18 |
| smcginnis | I was thinking this was targeted just at new drivers, so backporting wouldn't apply yet. | 19:18 |
| hemna_ | ok | 19:18 |
| smcginnis | But we could add a note so they know what to expect going forward I guess. | 19:18 |
| smcginnis | Or explicitly state that the new driver can't be backported, since that question has been asked a few times. | 19:18 |
| smcginnis | rosmaita: If you're around, it might be nice to get eyes on https://etherpad.openstack.org/p/cinder-driver-reviews from someone new to needing to review new drivers. | 19:19 |
| hemna_ | also, when a driver reports it's usage stats it needs to be associated with a pool, even if they only have 1 pool (or no pools) | 19:20 |
| rosmaita | smcginnis: ack | 19:21 |
| smcginnis | rosmaita: Thanks | 19:21 |
| smcginnis | hemna_: I didn't think that was the case if they didn't support multiple pools. Been a long time since I've thought about that area though. :) | 19:21 |
| hemna_ | I think they just need to report up via some poolname | 19:22 |
| hemna_ | because it's part of the hostname from what I remember | 19:22 |
| hemna_ | foo@bar#pool | 19:22 |
| smcginnis | Have we had new drivers doing that part wrong? | 19:22 |
| hemna_ | no idea... | 19:22 |
| smcginnis | Eh, add a note with some details if you think it's something important to watch out for. | 19:23 |
| hemna_ | also, we should raise the _init_vendor_properties() usage as well | 19:23 |
| smcginnis | I started by looking at things we've actually downvoted on recent driver patches to try to get the most common issues. | 19:23 |
| smcginnis | Oh right. | 19:23 |
| hemna_ | I think I might put an info log message in the base driver.py's implementation of _init_vendor_properties() | 19:24 |
| hemna_ | saying that driver isn't reporting properties....but should | 19:24 |
| hemna_ | :P | 19:24 |
| *** enriquetaso has quit IRC | 19:24 | |
| smcginnis | That could actually be very useful. | 19:24 |
| hemna_ | ok I'll put that up | 19:24 |
| smcginnis | ++ | 19:24 |
| hemna_ | I see why it's a _init_vendor_properties() and not init_vendor_properties call now | 19:25 |
| hemna_ | it's called from init_capabilities | 19:25 |
| smcginnis | So it's "private" to within the driver? | 19:25 |
| hemna_ | but I think we should all be implementing that now | 19:25 |
| smcginnis | Cool | 19:25 |
| hemna_ | https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L754 | 19:26 |
| smcginnis | Yeah, that makes sense. | 19:27 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: LOG _init_vendor_properites https://review.opendev.org/659872 | 19:30 |
| hemna_ | it's not required now, but it should be "soon" | 19:31 |
| smcginnis | ++ | 19:31 |
| hemna_ | maybe even warning, but info is probably ok for now? | 19:32 |
| woojay | smcginnis: I'm adding some URL references right now but obviously feel free to edit them for readability. | 19:32 |
| smcginnis | It is possible a driver doesn't have anything to add. I think there's a few that don't have anything. | 19:32 |
| smcginnis | woojay: Thanks! | 19:32 |
| smcginnis | hemna_: Looks like you accidentally picked up some RBD driver exception move things with that patch. | 19:33 |
| hemna_ | crap | 19:33 |
| hemna_ | git stash..... | 19:33 |
| hemna_ | always have too much going on | 19:34 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: LOG _init_vendor_properites https://review.opendev.org/659872 | 19:35 |
| hemna_ | lunch....brb | 19:35 |
| qqmber | hemna_: I jussy come back from lunch and just read your messages. | 19:45 |
| *** imacdonn has quit IRC | 19:45 | |
| qqmber | hemna_: Is not only a lot of messages.. is this one that bothers me the most: {"log":"tgtd: iscsi_noop_out_rx_start(1694) ffffffff 31 0\n","stream":"stderr","time":"2019-05-17T15:05:33.718926452Z"} | 19:45 |
| qqmber | that appears... a LOOOOTTTTTT | 19:45 |
| qqmber | 600GB in three days | 19:45 |
| hemna_ | qqmber: not sure why it's dumping that out that much | 19:46 |
| hemna_ | it's not an error | 19:46 |
| hemna_ | it's just an info message that they left in for whatever reason | 19:46 |
| hemna_ | can you track down how tgtd is getting launched? | 19:46 |
| hemna_ | maybe dial down the -d <number> if it's on | 19:46 |
| qqmber | hemna_: even though there is a "stderr" in there? | 19:46 |
| hemna_ | yah I don't think that's an error | 19:47 |
| qqmber | I can ask kolla-ansible people... | 19:47 |
| hemna_ | can you get in the container and ps -ef |grep tgtd ? | 19:47 |
| qqmber | the question would be "tgtd is being launch with the -d flag?" | 19:47 |
| *** mchlumsky has quit IRC | 19:47 | |
| qqmber | sure | 19:47 |
| qqmber | hold on | 19:47 |
| hemna_ | yah I think it might be | 19:47 |
| * hemna_ is just guessing though from looking at the tgtd code | 19:48 | |
| qqmber | hemna_: this is in the host (not container): tgtd -d 1 -f --iscsi portal=172.16.230.18:3260 | 19:48 |
| qqmber | now I'll go to the container | 19:48 |
| hemna_ | hrmm | 19:48 |
| hemna_ | nuke the -d option | 19:49 |
| hemna_ | :P | 19:49 |
| qqmber | what is the -d option? | 19:49 |
| hemna_ | debug logging | 19:49 |
| qqmber | holly crap | 19:49 |
| smcginnis | Doesn't seem like something you would want on by default. | 19:49 |
| qqmber | not... at ALL | 19:49 |
| qqmber | if it is an error... it should appears in the logs without the -d option, right? | 19:50 |
| smcginnis | Yeah | 19:50 |
| *** ircuser-1 has quit IRC | 19:50 | |
| *** radeks has quit IRC | 19:51 | |
| *** radeks has joined #openstack-cinder | 19:51 | |
| qqmber | ok, i'll go for it | 19:52 |
| qqmber | thanks! | 19:52 |
| *** imacdonn has joined #openstack-cinder | 19:52 | |
| *** ircuser-1 has joined #openstack-cinder | 19:53 | |
| qqmber | "command": "tgtd -d 1 -f --iscsi portal=172.16.230.18:3260", | 19:55 |
| qqmber | that's the command... should I take away the "-d 1", right? | 19:55 |
| hemna_ | yes | 19:55 |
| qqmber | tgtd -f --iscsi portal=172.16.230.18:3260 <--- that's the answer of "ps -ef |grep tgtd" | 19:58 |
| qqmber | tadaaaaa | 19:58 |
| qqmber | thank you very much | 19:58 |
| qqmber | I'll check at the logs now in order to detect any errors. | 19:58 |
| hemna_ | :) | 19:58 |
| *** pcaruana has quit IRC | 20:02 | |
| *** itlinux has quit IRC | 20:06 | |
| *** jsquare has quit IRC | 20:26 | |
| *** jsquare has joined #openstack-cinder | 20:26 | |
| *** radeks has quit IRC | 20:30 | |
| jungleboyj | qqmber: Yay! | 20:39 |
| jungleboyj | hemna_: Thanks for the additional help. | 20:39 |
| _alastor_ | jungleboyj: My CI should be reporting now. I still have to migrate it to a permanent setup, but at least it works :) | 20:49 |
| jungleboyj | _alastor_: \o/ | 20:52 |
| openstackgerrit | Merged openstack/cinder master: Handle collections.abc deprecations https://review.opendev.org/651391 | 20:57 |
| openstackgerrit | Merged openstack/cinder master: [Unity] Update doc for compressed volume support https://review.opendev.org/655597 | 20:57 |
| *** KeithMnemonic has quit IRC | 21:08 | |
| *** whoami-rajat has joined #openstack-cinder | 21:30 | |
| *** swegener has joined #openstack-cinder | 21:53 | |
| *** henriqueof has quit IRC | 21:55 | |
| *** itlinux has joined #openstack-cinder | 21:58 | |
| *** qqmber has quit IRC | 22:00 | |
| *** rchurch_ has joined #openstack-cinder | 22:01 | |
| *** rchurch has quit IRC | 22:02 | |
| *** dviroel has quit IRC | 22:19 | |
| *** mriedem has quit IRC | 22:20 | |
| *** rosmaita has left #openstack-cinder | 22:35 | |
| *** jcosmao has joined #openstack-cinder | 22:36 | |
| *** jcosmao has left #openstack-cinder | 22:37 | |
| *** dave-mccowan has quit IRC | 22:50 | |
| *** itlinux_ has joined #openstack-cinder | 22:51 | |
| *** itlinux has quit IRC | 22:52 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Move RBD driver exception to driver https://review.opendev.org/659891 | 23:03 |
| *** mvkr has quit IRC | 23:21 | |
| *** whoami-rajat has quit IRC | 23:40 | |
| *** mmethot has quit IRC | 23:53 | |
| *** lseki has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!