| *** _alastor_ has quit IRC | 00:11 | |
| *** tosky has quit IRC | 00:14 | |
| *** sdake has quit IRC | 00:25 | |
| *** sdake has joined #openstack-cinder | 00:29 | |
| *** sdake has quit IRC | 00:30 | |
| *** N3l1x has joined #openstack-cinder | 00:32 | |
| *** Nel1x has quit IRC | 00:32 | |
| *** TxGirlGeek has quit IRC | 00:44 | |
| *** sdake has joined #openstack-cinder | 00:57 | |
| *** sdake has quit IRC | 01:03 | |
| *** whoami-rajat has joined #openstack-cinder | 01:18 | |
| *** sdake has joined #openstack-cinder | 01:19 | |
| *** ircuser-1 has joined #openstack-cinder | 01:21 | |
| *** sdake has quit IRC | 01:27 | |
| *** sdake has joined #openstack-cinder | 01:35 | |
| *** sdake has quit IRC | 01:52 | |
| *** sdake has joined #openstack-cinder | 02:21 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 02:32 | |
| *** rchurch_ has joined #openstack-cinder | 02:35 | |
| *** rchurch has quit IRC | 02:36 | |
| *** Dinesh_Bhor has quit IRC | 02:58 | |
| *** psachin has joined #openstack-cinder | 03:04 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 03:04 | |
| *** sdake has quit IRC | 03:17 | |
| *** sdake has joined #openstack-cinder | 03:18 | |
| whoami-rajat | jungleboyj: i just added a topic yesterday, hope we get some time to discuss that too. | 03:34 |
|---|---|---|
| *** sdake has quit IRC | 03:35 | |
| *** dave-mccowan has quit IRC | 03:44 | |
| jungleboyj | Ok, what did you add? | 03:48 |
| jungleboyj | whoami-rajat: ^^ | 03:48 |
| *** Dinesh_Bhor has quit IRC | 03:54 | |
| whoami-rajat | jungleboyj: Discuss way of keeping track of features/code affecting other projects | 03:55 |
| whoami-rajat | this one | 03:55 |
| *** sdake has joined #openstack-cinder | 03:57 | |
| jungleboyj | whoami-rajat: Ok, when is a good time for you to discuss that? | 03:57 |
| whoami-rajat | jungleboyj: if it is possible then can we do it at mid time before/after lunch, but i see the timings are filled up so i'm fine with any timing. | 04:02 |
| jungleboyj | Are you planning to connect remotely? | 04:03 |
| whoami-rajat | jungleboyj: yes. | 04:03 |
| jungleboyj | whoami-rajat: If so, when we have some extra time just bring it up. We can usually fit topics in. | 04:03 |
| whoami-rajat | jungleboyj: sure, thanks! | 04:04 |
| jungleboyj | Welcome. Look forward to chatting with you tomorrow. | 04:04 |
| whoami-rajat | jungleboyj: same here :) | 04:05 |
| *** v12aml has quit IRC | 04:08 | |
| *** v12aml has joined #openstack-cinder | 04:14 | |
| *** sdake has quit IRC | 04:16 | |
| *** gkadam__ has joined #openstack-cinder | 04:17 | |
| *** udesale has joined #openstack-cinder | 04:17 | |
| *** bhagyashris_ has joined #openstack-cinder | 04:39 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 04:42 | |
| *** sdake has joined #openstack-cinder | 04:44 | |
| *** lpetrut has joined #openstack-cinder | 04:46 | |
| *** arunkant_ has quit IRC | 04:54 | |
| *** dims has quit IRC | 04:58 | |
| *** N3l1x has quit IRC | 05:19 | |
| *** lpetrut has quit IRC | 05:23 | |
| *** sdake has quit IRC | 06:03 | |
| *** markvoelker has joined #openstack-cinder | 06:45 | |
| *** Luzi has joined #openstack-cinder | 06:48 | |
| *** dims has joined #openstack-cinder | 06:48 | |
| *** dims has quit IRC | 06:52 | |
| *** dims has joined #openstack-cinder | 06:54 | |
| *** dims has quit IRC | 06:59 | |
| *** dims has joined #openstack-cinder | 07:02 | |
| *** abhishekk has joined #openstack-cinder | 07:04 | |
| *** markvoelker has quit IRC | 07:18 | |
| *** e0ne has joined #openstack-cinder | 07:33 | |
| *** pcaruana has joined #openstack-cinder | 07:45 | |
| *** tkajinam has quit IRC | 08:06 | |
| *** markvoelker has joined #openstack-cinder | 08:15 | |
| *** lpetrut has joined #openstack-cinder | 08:21 | |
| *** lpetrut has joined #openstack-cinder | 08:22 | |
| *** Luzi_ has joined #openstack-cinder | 08:25 | |
| *** Luzi has quit IRC | 08:27 | |
| *** lpetrut has quit IRC | 08:28 | |
| *** markvoelker has quit IRC | 08:49 | |
| *** tosky has joined #openstack-cinder | 08:50 | |
| *** lennyb has quit IRC | 08:55 | |
| *** lennyb has joined #openstack-cinder | 08:59 | |
| *** ociuhandu has quit IRC | 09:03 | |
| *** Luzi_ has quit IRC | 09:07 | |
| *** Luzi has joined #openstack-cinder | 09:07 | |
| *** ociuhandu has joined #openstack-cinder | 09:24 | |
| *** ganso has joined #openstack-cinder | 09:33 | |
| *** Dinesh_Bhor has quit IRC | 09:35 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 09:36 | |
| *** luizbag has joined #openstack-cinder | 09:43 | |
| *** markvoelker has joined #openstack-cinder | 09:46 | |
| *** bhagyashris_ has quit IRC | 09:53 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Raise appropriate exception https://review.openstack.org/634894 | 09:57 |
| *** v12aml has quit IRC | 10:15 | |
| *** v12aml has joined #openstack-cinder | 10:16 | |
| *** markvoelker has quit IRC | 10:19 | |
| *** ociuhandu_ has joined #openstack-cinder | 10:28 | |
| *** ociuhandu has quit IRC | 10:31 | |
| *** erlon has joined #openstack-cinder | 10:45 | |
| *** gnufied has quit IRC | 11:05 | |
| *** Dinesh_Bhor has quit IRC | 11:11 | |
| *** gnufied has joined #openstack-cinder | 11:11 | |
| *** Dinesh_Bhor has joined #openstack-cinder | 11:13 | |
| *** markvoelker has joined #openstack-cinder | 11:15 | |
| *** davidsha has joined #openstack-cinder | 11:27 | |
| *** udesale has quit IRC | 11:28 | |
| *** markvoelker has quit IRC | 11:48 | |
| *** _hemna has quit IRC | 11:51 | |
| *** abhishekk has quit IRC | 12:00 | |
| openstackgerrit | Sofia Enriquez proposed openstack/cinder master: Support Incremental Backup Completion In RBD https://review.openstack.org/627941 | 12:10 |
| *** enriquetaso has joined #openstack-cinder | 12:15 | |
| *** samc-bbc has quit IRC | 12:32 | |
| *** avishay has joined #openstack-cinder | 12:34 | |
| *** e0ne has quit IRC | 12:41 | |
| *** avishay has quit IRC | 12:48 | |
| *** gkadam__ has quit IRC | 12:58 | |
| *** sdake has joined #openstack-cinder | 13:05 | |
| *** mriedem has joined #openstack-cinder | 13:11 | |
| *** jmlowe has quit IRC | 13:17 | |
| *** abishop_ has quit IRC | 13:22 | |
| enriquetaso | jungleboyj, o/ how are u? have you defined a "communication channel" for the Stein Mid-Cycle? | 13:26 |
| *** Dinesh_Bhor has quit IRC | 13:30 | |
| *** jmlowe has joined #openstack-cinder | 13:34 | |
| *** erlon has quit IRC | 13:41 | |
| *** e0ne has joined #openstack-cinder | 13:42 | |
| smcginnis | enriquetaso: We are just getting set up and should have a link to join soon. | 13:44 |
| smcginnis | He's currently running back and forth to the front door to let people in. :) | 13:44 |
| enriquetaso | smcginnis, hahaha :D thanks! | 13:45 |
| whoami-rajat | I hope for a hangout + live stream link like last time :) | 13:49 |
| *** mvkr has quit IRC | 13:52 | |
| *** sdake has quit IRC | 13:54 | |
| smcginnis | Still trying to get things set up. Might be another 10-15 minutes yet. | 14:03 |
| *** sdake has joined #openstack-cinder | 14:04 | |
| *** rosmaita has joined #openstack-cinder | 14:04 | |
| *** rosmaita has left #openstack-cinder | 14:05 | |
| *** rosmaita has joined #openstack-cinder | 14:06 | |
| *** eharney has joined #openstack-cinder | 14:07 | |
| *** psachin has quit IRC | 14:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/cinder master: Drop nova-multiattach job https://review.openstack.org/606985 | 14:12 |
| mriedem | kickstarting ^ again | 14:15 |
| mriedem | this time it should be good | 14:15 |
| smcginnis | Thanks mriedem | 14:15 |
| *** markvoelker has joined #openstack-cinder | 14:16 | |
| *** sdake has quit IRC | 14:17 | |
| jungleboyj | Hangouts meeting: | 14:18 |
| jungleboyj | https://hangouts.google.com/call/c2H8hkBRkJFCWJ_HC5ShAAEE | 14:18 |
| *** mvkr has joined #openstack-cinder | 14:20 | |
| *** erlon has joined #openstack-cinder | 14:24 | |
| jungleboyj | Coffee just arrived. Will start after that. | 14:25 |
| erlon | jungleboyj, how is the webcasting going? | 14:26 |
| * erlon has lost connection on the last hour | 14:26 | |
| erlon | so, might have lost any conversation about it | 14:26 |
| smcginnis | erlon: Link is in https://etherpad.openstack.org/p/cinder-stein-mid-cycle-planning | 14:27 |
| smcginnis | Line 147 | 14:27 |
| smcginnis | We will get started in just a couple minutes, so you haven't missed anything yet. | 14:27 |
| whoami-rajat | erlon: not yet started. you can join the hangout link above. | 14:27 |
| erlon | smcginnis, nice thanks | 14:27 |
| jungleboyj | Erlon, going to start the webcast in a minute. | 14:28 |
| jungleboyj | They are setting up stuff here. | 14:29 |
| *** udesale has joined #openstack-cinder | 14:32 | |
| jungleboyj | Live stream is here: https://www.youtube.com/watch?v=yqu88SvzSJ8 | 14:34 |
| *** sdake has joined #openstack-cinder | 14:34 | |
| smcginnis | https://etherpad.openstack.org/p/cinder-stein-mid-cycle-planning | 14:35 |
| *** pckizer has quit IRC | 14:38 | |
| whoami-rajat | running py3 jobs https://review.openstack.org/#/c/616748/ | 14:40 |
| *** avishay has joined #openstack-cinder | 14:42 | |
| avishay | geguileo: Hey. I have a question about os-brick... Seems like I found a bug | 14:42 |
| geguileo | avishay: :-( | 14:43 |
| geguileo | don't look!!! | 14:43 |
| geguileo | ;-) | 14:43 |
| avishay | :) | 14:43 |
| avishay | So I wanted to look at the potential volume paths and make sure they don't exist before the connect | 14:44 |
| avishay | I was please to see that extend_volume already does that | 14:44 |
| *** sdake has quit IRC | 14:45 | |
| avishay | But it just takes whatever is from connection_properties, which if I understand correctly is fine if we have target_portals, but if we need to do discovery, we won't have all paths in connection_properties | 14:46 |
| avishay | geguileo: right? | 14:46 |
| *** pckizer has joined #openstack-cinder | 14:46 | |
| *** sdake has joined #openstack-cinder | 14:48 | |
| *** markvoelker has quit IRC | 14:49 | |
| whoami-rajat | smcginnis: i was working on the upgrade checks base framework in other projects, i can implement the checks if noone is working on it currently? | 14:51 |
| jungleboyj | Can people hear on the live stream? | 14:54 |
| whoami-rajat | jungleboyj: yes | 14:55 |
| woojay | +1 | 14:56 |
| *** sdake has quit IRC | 14:56 | |
| jungleboyj | Ok. I have it using the mic on the camera accidentally. Will try to get it changed on the next recording. | 14:56 |
| *** ociuhandu_ has quit IRC | 14:58 | |
| *** ociuhandu has joined #openstack-cinder | 14:58 | |
| *** Nel1x has joined #openstack-cinder | 14:59 | |
| *** _hemna has joined #openstack-cinder | 14:59 | |
| *** arunkant has joined #openstack-cinder | 15:02 | |
| *** sdake has joined #openstack-cinder | 15:04 | |
| *** udesale has quit IRC | 15:06 | |
| avishay | hemna: _hemna Hey! What's up? Perhaps you know the answer to my question above about extend_volume in os-brick? (I saw you wrote it) | 15:11 |
| *** Luzi has quit IRC | 15:12 | |
| openstackgerrit | Brian Rosmaita proposed openstack/python-brick-cinderclient-ext master: Add python 3.6 unit test job https://review.openstack.org/616748 | 15:13 |
| _hemna | what's up? | 15:14 |
| _hemna | I wrote that ages and ages ago | 15:14 |
| _hemna | not sure if anyone is really using it | 15:14 |
| avishay | OK. Thanks! | 15:15 |
| jungleboyj | geguileo: You around? Walt is here and wanted to chat about Cinderlib. | 15:28 |
| geguileo | jungleboyj: about to go into a meeting, but sure | 15:29 |
| jungleboyj | Eric says it is just your team meeting. Come join us. | 15:29 |
| jungleboyj | geguileo: https://hangouts.google.com/call/c2H8hkBRkJFCWJ_HC5ShAAEE | 15:30 |
| geguileo | jungleboyj: I'm in | 15:30 |
| jungleboyj | woojay: Is the sound in the live stream better now? | 15:37 |
| woojay | yeah. definitely. thank you | 15:37 |
| jungleboyj | Awesome. Got the right Mic working this time. | 15:37 |
| geguileo | jungleboyj: I don't know where in the Etherpad to add it: https://twitter.com/shenitzky/status/1087686192571789313 | 15:42 |
| *** vishakha has joined #openstack-cinder | 15:45 | |
| *** markvoelker has joined #openstack-cinder | 15:46 | |
| *** jgriffith has quit IRC | 15:54 | |
| *** jgriffit1 has joined #openstack-cinder | 15:54 | |
| *** jgriffit1 is now known as jgriffith | 15:55 | |
| *** avishay has quit IRC | 15:59 | |
| *** e0ne has quit IRC | 16:05 | |
| *** TxGirlGeek has joined #openstack-cinder | 16:09 | |
| *** markvoelker has quit IRC | 16:19 | |
| *** arunkant_ has joined #openstack-cinder | 16:23 | |
| *** davidsha has quit IRC | 16:23 | |
| *** arunkant has quit IRC | 16:25 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Remove legacy-tempest-dsvm-full-drbd-devstack job https://review.openstack.org/634969 | 16:28 |
| mriedem | trying to help with the tooz connection errors in the gate https://review.openstack.org/634970 | 16:30 |
| mriedem | smcginnis: does the libvirt drbd volume driver in nova need to be deprecated as well? https://review.openstack.org/#/c/256292/6/nova/virt/libvirt/driver.py | 16:32 |
| mriedem | volume type of 'drbd' | 16:32 |
| mriedem | i guess in cinder that's the DrbdManageDrbdDriver in 'remote' mode | 16:34 |
| smcginnis | mriedem: I believe so. | 16:35 |
| *** openstackgerrit has quit IRC | 16:35 | |
| smcginnis | woojay: ^^ | 16:36 |
| woojay | Yeah didn't know we loose one somewhere else. Let me look at it for one sec please. | 16:37 |
| mriedem | woojay: this is the nova driver https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/drbd.py | 16:37 |
| *** jmlowe has quit IRC | 16:44 | |
| woojay | mriedem: I believe I still need that nova driver for the LINSTOR driver, that will ultimately replace DRBDManage driver for DRBD. | 16:44 |
| mriedem | ok as long as the 'drbd' volume type is not going away then i think we're ok | 16:48 |
| woojay | k, thank you. | 16:49 |
| *** gnufied has quit IRC | 16:50 | |
| erlon | need to drop | 16:51 |
| smcginnis | Thanks erlon | 16:52 |
| *** _alastor_ has joined #openstack-cinder | 16:52 | |
| *** mvkr has quit IRC | 16:53 | |
| *** erlon has quit IRC | 16:57 | |
| enriquetaso | see you after lunch! | 17:07 |
| *** enriquetaso has quit IRC | 17:11 | |
| *** markvoelker has joined #openstack-cinder | 17:16 | |
| *** enriquetaso has joined #openstack-cinder | 17:20 | |
| *** _hemna has quit IRC | 17:23 | |
| *** jmlowe has joined #openstack-cinder | 17:26 | |
| *** gnufied has joined #openstack-cinder | 17:35 | |
| *** luizbag_ has joined #openstack-cinder | 17:35 | |
| *** luizbag has quit IRC | 17:35 | |
| *** jmlowe has quit IRC | 17:36 | |
| *** enriquetaso has quit IRC | 17:44 | |
| *** markvoelker has quit IRC | 17:48 | |
| *** arunkant__ has joined #openstack-cinder | 17:56 | |
| *** jmlowe has joined #openstack-cinder | 17:57 | |
| *** arunkant_ has quit IRC | 18:00 | |
| *** enriquetaso has joined #openstack-cinder | 18:05 | |
| *** dims has quit IRC | 18:06 | |
| *** arunkant__ has quit IRC | 18:06 | |
| *** enriquetaso has quit IRC | 18:10 | |
| *** ociuhandu has quit IRC | 18:11 | |
| *** sdake has quit IRC | 18:11 | |
| *** ociuhandu has joined #openstack-cinder | 18:13 | |
| *** ociuhandu has quit IRC | 18:17 | |
| *** dims has joined #openstack-cinder | 18:26 | |
| *** Nel1x has quit IRC | 18:29 | |
| jungleboyj | We are recongregating. | 18:30 |
| smcginnis | We are napping. | 18:31 |
| jungleboyj | Hangouts restarted: https://hangouts.google.com/call/c2H8hkBRkJFCWJ_HC5ShAAEE | 18:33 |
| *** _hemna has joined #openstack-cinder | 18:33 | |
| *** markvoelker has joined #openstack-cinder | 18:46 | |
| *** itlinux has joined #openstack-cinder | 18:49 | |
| *** sdake has joined #openstack-cinder | 18:52 | |
| whoami-rajat | jungleboyj: what is the notes section for https://docs.openstack.org/cinder/latest/reference/support-matrix.html ? | 19:00 |
| *** luizbag_ has quit IRC | 19:00 | |
| *** openstackgerrit has joined #openstack-cinder | 19:04 | |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Update rbd thin-provisioning in support-matrix https://review.openstack.org/635009 | 19:04 |
| *** enriquetaso has joined #openstack-cinder | 19:07 | |
| *** vishakha has quit IRC | 19:12 | |
| *** dims has quit IRC | 19:16 | |
| *** markvoelker has quit IRC | 19:19 | |
| *** dims has joined #openstack-cinder | 19:25 | |
| *** pcaruana has quit IRC | 19:27 | |
| *** erlon has joined #openstack-cinder | 19:29 | |
| *** ociuhandu has joined #openstack-cinder | 19:30 | |
| *** ociuhandu has quit IRC | 19:35 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Import the cinderlib code https://review.openstack.org/620669 | 19:41 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Add cinderlib docs https://review.openstack.org/620670 | 19:41 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: Add cinderlib functional tests https://review.openstack.org/620671 | 19:41 |
| *** erlon has quit IRC | 19:54 | |
| *** ociuhandu has joined #openstack-cinder | 19:59 | |
| *** e0ne has joined #openstack-cinder | 20:03 | |
| *** mvkr has joined #openstack-cinder | 20:09 | |
| *** markvoelker has joined #openstack-cinder | 20:16 | |
| *** enriquetaso has quit IRC | 20:19 | |
| smcginnis | https://review.openstack.org/#/c/634022/ | 20:27 |
| *** jmlowe has quit IRC | 20:29 | |
| whoami-rajat | e0ne: could you check again https://review.openstack.org/#/c/616748/2 ? | 20:36 |
| e0ne | whoami-rajat: will do in 15 mins | 20:36 |
| whoami-rajat | e0ne: sure | 20:37 |
| whoami-rajat | jungleboyj: do we need to start implementing missing commands in OSC or holding it for now? | 20:41 |
| jungleboyj | whoami-rajat: We want to start implementing as many as possible. | 20:41 |
| whoami-rajat | jungleboyj: ok | 20:43 |
| smcginnis | hemna: https://releases.openstack.org/reference/using.html#requesting-a-release | 20:44 |
| *** markvoelker has quit IRC | 20:48 | |
| smcginnis | eharney: https://bugs.launchpad.net/cinder/+bug/1752355 | 21:02 |
| openstack | Launchpad bug 1752355 in Cinder "Configure an NFS storage back end in Cinder" [Undecided,Incomplete] | 21:02 |
| smcginnis | Shouldn't packages handle that? | 21:02 |
| _hemna | https://review.openstack.org/635038 | 21:03 |
| woojay | jungleboyj: Thank you for the youtube cast. | 21:09 |
| openstackgerrit | Merged openstack/cinder master: Update rbd thin-provisioning in support-matrix https://review.openstack.org/635009 | 21:10 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Update install docs to match default NFS config https://review.openstack.org/635041 | 21:12 |
| smcginnis | https://review.openstack.org/#/c/215885/ | 21:20 |
| *** itlinux has quit IRC | 21:29 | |
| openstackgerrit | Sofia Enriquez proposed openstack/cinder master: Support Incremental Backup Completion In RBD https://review.openstack.org/627941 | 21:31 |
| openstackgerrit | Rajat Dhasmana proposed openstack/python-brick-cinderclient-ext master: Add python 3.6 unit test job https://review.openstack.org/616748 | 21:32 |
| *** e0ne has quit IRC | 21:33 | |
| *** _hemna has quit IRC | 21:39 | |
| *** sdake has quit IRC | 21:39 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Add Python 3.6 version in setup.cfg https://review.openstack.org/635049 | 21:40 |
| *** markvoelker has joined #openstack-cinder | 21:46 | |
| openstackgerrit | Eric Fried proposed openstack/cinder master: DNM: Demonstrate driver sorting in support matrix https://review.openstack.org/635051 | 21:46 |
| *** mchlumsky has quit IRC | 21:52 | |
| *** ganso has quit IRC | 21:57 | |
| *** efried has joined #openstack-cinder | 22:06 | |
| efried | smcginnis: I'm sure I'm being a doofus here. | 22:06 |
| smcginnis | efried: Well that's odd. Not the output I was getting locally. | 22:07 |
| efried | smcginnis: Was it actually sorted, or was it just sorted *differently*? | 22:08 |
| efried | smcginnis: What's your PYTHONHASHSEED locally? | 22:08 |
| efried | It looks to me like you may actually have to sort implementations by driver.title | 22:08 |
| * efried tries... | 22:10 | |
| smcginnis | I think it should work based on http://git.openstack.org/cgit/openstack/sphinx-feature-classification/tree/sphinx_feature_classification/support_matrix.py#n281 | 22:11 |
| * smcginnis notices line 312 is redundant with 281. | 22:11 | |
| efried | smcginnis: But you're not sorting matrix.drivers. You're sorting feature.implementations | 22:11 |
| smcginnis | True, but I saw the same behavior. | 22:12 |
| smcginnis | Trying to repro it now. | 22:12 |
| efried | smcginnis: I don't know offhand what feature.implementations corresponds to, versus matrix.drivers. But I'm guessing (about to confirm) that you could say | 22:14 |
| efried | sorted(features.implementations, key=lambda x: matrix.drivers[x].title) | 22:14 |
| efried | and it would work. Whether that's doing extra that you don't need, I can't say... | 22:14 |
| efried | smcginnis: FWIW, building locally off of cinder master with nothing changed gives me the proper sorting. So I'm betting it's the fact that our local envs aren't setting PYTHONHASHSEED by default. | 22:16 |
| smcginnis | efried: Hmm, sorts fine locally for me. | 22:16 |
| efried | smcginnis: Yeah, try turning off your sphinx patch and see if it still does :) | 22:17 |
| smcginnis | I'm trying using the PYTHONHASHSEED from the gate job. | 22:18 |
| *** markvoelker has quit IRC | 22:20 | |
| smcginnis | Local output is sorted using the same PYTHONHASHSEED. Trying unpatches support-matrix code now. | 22:21 |
| smcginnis | I wonder if it is checking out the right commit, but then installing the released version - http://logs.openstack.org/51/635051/1/check/openstack-tox-docs/0ab7ec4/job-output.txt.gz#_2019-02-05_21_52_11_867003 | 22:23 |
| efried | Yeah, I was just looking at that. That would suck. | 22:25 |
| efried | I can't get it to *not* sort locally, *without* your change, *with* a nonzero hash seed. So the hash seed isn't the problem. And unless we figure out what's causing sorting to happen locally, means we'll have to debug it in the gate :( | 22:26 |
| efried | smcginnis: ima try my above fix on top of yours | 22:27 |
| *** sdake has joined #openstack-cinder | 22:27 | |
| smcginnis | efried: OK, that might be best. I saw the same sorted behavior without the patch. Cleaned out build output and rerunning using the same hash seed once more time. | 22:28 |
| smcginnis | Really concerns me that we can't reproduce this behavior locally. Not sure what would cause a difference if it's not the hash seed. | 22:29 |
| smcginnis | Yep, still sorted. | 22:29 |
| openstackgerrit | Eric Fried proposed openstack/cinder master: DNM: Demonstrate driver sorting in support matrix https://review.openstack.org/635051 | 22:32 |
| efried | smcginnis: ^ with new dep | 22:32 |
| efried | smcginnis: I've run into this before, but I don't remember what the cause was. | 22:32 |
| *** sdake has quit IRC | 22:34 | |
| *** sdake has joined #openstack-cinder | 22:36 | |
| smcginnis | efried: New patch isn't sorted either. :( | 22:42 |
| smcginnis | http://logs.openstack.org/51/635051/2/check/openstack-tox-docs/6e0a081/html/reference/support-matrix.html | 22:42 |
| smcginnis | I suppose I could add some javascript to the css to just sort the list. | 22:46 |
| smcginnis | yee | 22:47 |
| efried | ye gods no | 22:52 |
| efried | yeah, this one is unsorted in a totally different way. Again making me wonder if it's not properly honoring the patch | 22:53 |
| smcginnis | efried: I would be sure of that if it wasn't for different results locally. | 22:53 |
| *** tkajinam has joined #openstack-cinder | 22:55 | |
| *** erlon has joined #openstack-cinder | 23:03 | |
| efried | smcginnis: The keys to the feature.implementations dict are the same as the keys to the matrix.drivers dict. Which are things like 'driver.datacore', not the actual title, meaning the sorting isn't exactly alphabetical (which I noticed e.g. where "Generic NFS Reference Driver (NFS)" comes in the middle of the Ns) BUT your original fix *should* be working fine. | 23:05 |
| efried | (Pdb) sorted(matrix.drivers) == sorted(feature.implementations) | 23:06 |
| efried | True | 23:06 |
| smcginnis | efried: Adding some debug logs, I see the same where the full module path in "keys" is sorted as I would like to have them. | 23:06 |
| smcginnis | So I guess something later is randomizing the bullet_list entries. | 23:06 |
| efried | or your fix is working, and the gate isn't honoring the dependency for some reason. | 23:07 |
| smcginnis | It's a simple fix he said... It will just take a few minutes he said... :) | 23:07 |
| smcginnis | efried: I suppose we could try merging it and see, but if that's the case, it wouldn't show up until an actual release is done. | 23:08 |
| efried | smcginnis: f it, I'm going to approve it based on the fact that it should be working, and then once you've gone through all the pain of releasing and updating l-c and all that crap, we'll see if it really worked or not. | 23:08 |
| efried | which seems... stupid. | 23:08 |
| smcginnis | efried: I would feel much much better if I could reproduce things locally. *shrug* | 23:09 |
| efried | Or we could go gripe in -infra and see whether they can confirm or refute that the dep is or is not being honored. | 23:09 |
| smcginnis | I was thinking of adding Stephen F to the review. He's done a lot of sphinx extensions, so maybe if I add him and we give it until tomorrow he might come back with a reason. | 23:09 |
| *** erlon has quit IRC | 23:10 | |
| efried | this really has nothing to do with sphinx. | 23:11 |
| efried | though he might know things about why the sorting seems to be happening locally. | 23:12 |
| efried | Actually, it looks to me like the sorting isn't *exactly* the same. | 23:12 |
| efried | Did you check it exhaustively or just glance through it? | 23:12 |
| smcginnis | My suspicion is that the sphinx bullet_list is randomized somehow internally. | 23:13 |
| smcginnis | What do you mean "check it exhaustively"? | 23:13 |
| smcginnis | IIRC, python 3 added list randomization so folks would stop assuming things would always be in the right order. | 23:14 |
| efried | I mean that, in my debug session where I'm building locally, the unsorted and sorted versions are *close*, but not *identical*. | 23:15 |
| efried | So if a guy were just skimming, it might look like it was really sorted, but it ain't. | 23:15 |
| efried | i.e. I may have a legit local repro. | 23:15 |
| *** markvoelker has joined #openstack-cinder | 23:16 | |
| efried | smcginnis: booyah, confirmed. | 23:17 |
| efried | At least in my local env, the ordering starts to be different at | 23:17 |
| efried | Dell EMC VMAX Af (250F, 450F, 850F, 950F) Storage Driver (FC, iSCSI): complete | 23:17 |
| efried | Dell EMC VMAX3 (100K, 200K, 400K) Storage Driver (iSCSI, FC): complete | 23:17 |
| efried | Let me instate your fix and run it again... | 23:17 |
| openstackgerrit | Merged openstack/cinder master: Fix keystone auth config in install doc https://review.openstack.org/630081 | 23:17 |
| openstackgerrit | Merged openstack/cinder master: api-ref: modify 'keys' description https://review.openstack.org/566215 | 23:17 |
| smcginnis | efried: VMAX3 should sort after VMAX | 23:19 |
| efried | smcginnis: Remember, it's sorting on the keys, not the titles. | 23:19 |
| efried | If you want it to sort properly on the titles, you'll have to change it in both places. | 23:19 |
| efried | for now I think we'll be happy just to get 'em sorting the same. | 23:20 |
| smcginnis | Ahh, right. | 23:20 |
| efried | as each other. | 23:20 |
| smcginnis | So really what we want is what you had with sorting on the title value, not the key. | 23:20 |
| efried | yuh | 23:20 |
| smcginnis | I think I've learned this lesson before. Multiple times. | 23:21 |
| openstackgerrit | Angela Smith proposed openstack/cinder master: REST connector for Brocade zone driver https://review.openstack.org/617100 | 23:21 |
| efried | smcginnis: Confirmed. | 23:24 |
| efried | smcginnis: So your fix does work, and I can prove it locally (I just can't prove it in the gate with a dep <fume>) | 23:24 |
| efried | smcginnis: I can +2 this... unless you want to do the extra thing to sort by title in both places? | 23:24 |
| efried | and with that, I'm outta here. | 23:31 |
| *** rosmaita has left #openstack-cinder | 23:31 | |
| smcginnis | efried: Thanks, I think we actually do want your change. I'll update my patch with your changes. | 23:34 |
| openstackgerrit | Sam Morrison proposed openstack/cinder master: Include availability-zone of a pool in get-pools API request https://review.openstack.org/599866 | 23:36 |
| *** eharney has quit IRC | 23:43 | |
| *** imacdonn has quit IRC | 23:48 | |
| *** imacdonn has joined #openstack-cinder | 23:49 | |
| *** markvoelker has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!