Wednesday, 2018-12-19

openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder stable/rocky: Fix _per_gb_min usage with _per_gb  https://review.openstack.org/62604700:04
*** jmlowe has quit IRC00:07
*** itlinux has joined #openstack-cinder00:08
openstackgerritMerged openstack/os-brick stable/rocky: Tests: Fix PrivRootwrapTestCase failure  https://review.openstack.org/62563500:09
*** mriedem has quit IRC00:27
*** itlinux has quit IRC00:28
*** itlinux has joined #openstack-cinder00:28
*** _alastor_ has joined #openstack-cinder00:28
*** itlinux has quit IRC00:29
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505800:29
*** noonedeadpunk[h] has joined #openstack-cinder00:31
openstackgerritMerged openstack/cinder master: Retry on DBDeadLock affecting worker updates  https://review.openstack.org/61185600:40
*** sapd1 has joined #openstack-cinder00:45
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505800:51
noonedeadpunk[h]smcginnis: hope, that this one ^ is the last one. At least tests are going to pass again. I don't like the variable name, but otherwise have to resolve long line problem, which will look afwul afterwards.01:03
openstackgerritMerged openstack/cinder master: Add policy test for TENANT_ATTRIBUTE_POLICY  https://review.openstack.org/61644701:11
*** itlinux has joined #openstack-cinder01:12
openstackgerritDmitriy Rabotjagov (noonedeadpunk) proposed openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505801:13
openstackgerritMerged openstack/cinder master: Add user_id in backup list and show API  https://review.openstack.org/61512901:14
openstackgerritMerged openstack/cinder stable/pike: VMAX Pike docs - no support for PowerMax OS  https://review.openstack.org/61456001:14
*** noonedeadpunk[h] has quit IRC01:18
*** sapd1 has quit IRC01:20
openstackgerritMerged openstack/cinder master: Remove deprecated query_volume_filters config option  https://review.openstack.org/62063201:21
*** hedvig_01 has quit IRC01:25
*** _alastor_ has quit IRC01:34
*** Liang__ has joined #openstack-cinder01:42
*** Liang__ is now known as LiangFang01:43
openstackgerritMerged openstack/cinder master: api-ref: add missing volumes_links in list-volume interfaces  https://review.openstack.org/61609401:59
openstackgerritMerged openstack/cinder master: PowerMax driver doc - clarifying SE and Unisphere support  https://review.openstack.org/62346701:59
openstackgerritMerged openstack/cinder master: Doc: Remove unnecessary note  https://review.openstack.org/62343501:59
*** sapd1 has joined #openstack-cinder02:04
*** Dinesh_Bhor has joined #openstack-cinder02:08
*** sapd1 has quit IRC02:09
*** mhen has quit IRC02:22
*** mhen has joined #openstack-cinder02:23
*** Dinesh_Bhor has quit IRC02:23
*** Dinesh_Bhor has joined #openstack-cinder02:39
*** itlinux has quit IRC02:40
openstackgerritRyan Liang proposed openstack/cinder stable/ocata: [Unity] Add support of removing empty host  https://review.openstack.org/62606902:47
openstackgerritYong Huang proposed openstack/cinder stable/pike: Unity: Enable ssl verification  https://review.openstack.org/62607002:53
*** psachin has joined #openstack-cinder02:57
*** brinzhang has joined #openstack-cinder03:04
*** dave-mccowan has joined #openstack-cinder03:06
*** Bhujay has joined #openstack-cinder03:20
*** dave-mccowan has quit IRC03:24
*** Bhujay has quit IRC03:38
openstackgerritMerged openstack/cinder master: Rename BackupNFSSwiftBasedTestCase  https://review.openstack.org/61113703:40
*** erlon has quit IRC03:44
*** gnufied has quit IRC03:44
*** Dinesh_Bhor has quit IRC03:46
*** dklyle has quit IRC04:02
*** david-lyle has joined #openstack-cinder04:02
*** sapd1 has joined #openstack-cinder04:07
*** udesale has joined #openstack-cinder04:14
openstackgerritGhanshyam Mann proposed openstack/cinder master: Use renamed template 'integrated-gate-py3'  https://review.openstack.org/62608304:28
*** Bhujay has joined #openstack-cinder04:33
*** arne_wiebalck has quit IRC05:04
*** Dinesh_Bhor has joined #openstack-cinder05:18
*** udesale has quit IRC05:45
*** brinzhang has quit IRC05:45
*** udesale has joined #openstack-cinder05:49
openstackgerritYong Huang proposed openstack/cinder master: [Unity] Storage-assisted migration support  https://review.openstack.org/61262106:05
*** dims has quit IRC06:27
*** dims has joined #openstack-cinder06:28
*** dims has quit IRC06:33
*** dims has joined #openstack-cinder06:34
*** mgagne has quit IRC06:35
*** mgagne has joined #openstack-cinder06:39
*** Dinesh_Bhor has quit IRC06:56
*** Dinesh_Bhor has joined #openstack-cinder07:10
openstackgerritJonghan Park proposed openstack/cinder master: Support HP MSA 2050 Storage  https://review.openstack.org/62610407:18
*** dpawlik has joined #openstack-cinder07:21
*** dpawlik has quit IRC07:25
*** imacdonn has quit IRC07:29
*** imacdonn has joined #openstack-cinder07:29
*** dpawlik has joined #openstack-cinder07:36
*** dpawlik has quit IRC07:36
*** dpawlik_ has joined #openstack-cinder07:36
*** arne_wiebalck has joined #openstack-cinder07:46
*** sapd1 has quit IRC07:49
openstackgerritJonghan Park proposed openstack/cinder master: Support HP MSA 2050 Storage  https://review.openstack.org/62610407:52
*** Dinesh_Bhor has quit IRC08:03
*** pcaruana has joined #openstack-cinder08:03
*** arunkant has joined #openstack-cinder08:03
*** sapd1 has joined #openstack-cinder08:06
*** markvoelker has joined #openstack-cinder08:10
*** gkadam has joined #openstack-cinder08:11
*** Bhujay has quit IRC08:19
*** pcaruana has quit IRC08:24
*** helenafm has joined #openstack-cinder08:26
*** pcaruana has joined #openstack-cinder08:33
*** bhagyashris has joined #openstack-cinder08:34
*** pcaruana has quit IRC08:41
*** e0ne has joined #openstack-cinder08:47
*** rcernin has quit IRC08:51
*** wuchongyao has joined #openstack-cinder08:56
*** v12aml has quit IRC09:01
*** Bhujay has joined #openstack-cinder09:03
*** v12aml has joined #openstack-cinder09:04
wuchongyao#openstack-cinder  I'm setting up an CI System and post public key to openstack infra mail list but havn't get response.09:04
*** Bhujay has quit IRC09:04
*** Bhujay has joined #openstack-cinder09:05
*** Bhujay has quit IRC09:06
*** Dinesh_Bhor has joined #openstack-cinder09:06
*** Bhujay has joined #openstack-cinder09:06
*** Bhujay has quit IRC09:07
*** Bhujay has joined #openstack-cinder09:08
*** Bhujay has quit IRC09:09
*** Bhujay has joined #openstack-cinder09:09
*** Bhujay has quit IRC09:10
*** Bhujay has joined #openstack-cinder09:11
*** LiangFang has quit IRC09:18
*** zhangxiaofang has joined #openstack-cinder09:20
wuchongyaoI'm setting up an CI System and post public key to        x bswartz09:21
wuchongyao                    | openstack infra mail list but havn't get response.09:21
zhangxiaofangH09:24
*** Bhujay has quit IRC09:24
*** luizbag has joined #openstack-cinder09:26
*** wuchongyao has quit IRC09:27
*** e0ne has quit IRC09:28
*** luizbag has quit IRC09:31
*** sapd1 has quit IRC09:34
*** sapd1 has joined #openstack-cinder09:35
*** wuchongyao has joined #openstack-cinder09:36
*** zhangxiaofang has quit IRC09:37
*** luizbag has joined #openstack-cinder09:37
openstackgerritcaixiaoyu proposed openstack/cinder master: Add test case: retype volume when driver not initialized  https://review.openstack.org/61898709:44
*** Bhujay has joined #openstack-cinder09:48
*** e0ne has joined #openstack-cinder09:50
*** Bhujay has quit IRC09:51
*** ganso has joined #openstack-cinder09:51
lennybe0ne: frickler regarding MariaDB issue. http://13.74.249.42/30/611530/8/check-cinder/Cinder-ISER-LIO/50ce052/console.html.gz          I've upgraded Fedora25 to Fedora27 and the issue was solved. This solution is good enough for me. Thanks09:59
*** bhagyashris has quit IRC10:00
*** erlon has joined #openstack-cinder10:06
*** Dinesh_Bhor has quit IRC10:09
*** wuchongyao has quit IRC10:10
*** Bhujay has joined #openstack-cinder10:11
*** Bhujay has quit IRC10:12
*** Bhujay has joined #openstack-cinder10:12
*** Bhujay has quit IRC10:13
*** Bhujay has joined #openstack-cinder10:14
*** erlon_ has joined #openstack-cinder10:17
*** erlon has quit IRC10:20
*** Bhujay has quit IRC10:24
*** psachin has quit IRC10:29
openstackgerritGorka Eguileor proposed openstack/cinder master: Ignore migration 127 error on older MariaDB  https://review.openstack.org/62614610:55
*** dpawlik_ has quit IRC11:09
*** dpawlik has joined #openstack-cinder11:09
*** e0ne has quit IRC11:09
openstackgerritHelen Walsh proposed openstack/cinder master: VMAX Driver - Failover Unisphere Support  https://review.openstack.org/57040111:10
*** sapd1 has quit IRC11:10
openstackgerritGorka Eguileor proposed openstack/cinder master: Ignore migration 127 error on MariaDB  https://review.openstack.org/62614611:11
*** dpawlik has quit IRC11:13
*** udesale has quit IRC11:13
*** dpawlik has joined #openstack-cinder11:13
*** dpawlik has quit IRC11:14
*** dpawlik has joined #openstack-cinder11:14
*** dpawlik has quit IRC11:16
*** dpawlik has joined #openstack-cinder11:17
*** dpawlik has quit IRC11:17
*** sapd1 has joined #openstack-cinder11:17
*** dpawlik has joined #openstack-cinder11:17
*** Bhujay has joined #openstack-cinder11:21
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - rebranding VMAX to PowerMax  https://review.openstack.org/62065911:22
openstackgerritSilvan Kaiser proposed openstack/cinder master: [WIP] Add _context to online snapshots in remotefs driver  https://review.openstack.org/57088511:27
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  changing from 8.4 to 9.0 REST endpoints  https://review.openstack.org/62529711:29
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  code cleanup and minor improvements  https://review.openstack.org/62558111:37
openstackgerritHelen Walsh proposed openstack/cinder stable/rocky: PowerMax driver doc - clarifying SE and Unisphere support  https://review.openstack.org/62616111:52
*** erlon_ has quit IRC11:59
*** e0ne has joined #openstack-cinder12:01
*** dpawlik has quit IRC12:06
*** erlon_ has joined #openstack-cinder12:15
*** tpsilva has joined #openstack-cinder12:26
fricklerlennyb: well, sadly that doesn't solve the issue for centos-7, but thanks for the update12:32
lennybfrickler, what version of centos?12:34
fricklerlennyb: probably any version of centos 7, but in gate we are testing the latest, which iirc should be 7.6. see http://zuul.openstack.org/builds?job_name=devstack-platform-centos-712:37
*** abishop has joined #openstack-cinder12:48
openstackgerritMerged openstack/cinder master: VMAX Driver - Place volume in SG as part of unmanage volume  https://review.openstack.org/60328312:50
*** dpawlik has joined #openstack-cinder12:50
*** rosmaita has joined #openstack-cinder13:03
*** sapd1 has quit IRC13:03
*** mriedem has joined #openstack-cinder13:06
*** dave-mccowan has joined #openstack-cinder13:08
*** markvoelker has quit IRC13:24
*** helenafm has quit IRC13:34
*** e0ne has quit IRC13:43
*** helenafm has joined #openstack-cinder13:44
*** mmethot has quit IRC13:45
*** mmethot has joined #openstack-cinder13:47
*** e0ne has joined #openstack-cinder14:02
*** Bhujay has quit IRC14:02
*** Bhujay has joined #openstack-cinder14:02
*** Bhujay has quit IRC14:03
*** Bhujay has joined #openstack-cinder14:04
*** Bhujay has quit IRC14:05
openstackgerritSofia Enriquez proposed openstack/cinder stable/queens: Ensure image utils don't block greenthreads  https://review.openstack.org/62599414:05
*** Bhujay has joined #openstack-cinder14:05
*** Bhujay has quit IRC14:06
*** Bhujay has joined #openstack-cinder14:07
smcginnisgeguileo: Thanks for the mariadb patch. All the comments I've seen is the error is on newer centos distros, but your patch says it affects older mariadb versions.14:09
smcginnisgeguileo: Do you know if that is really the case and things like CentOS 7 are using this older version?14:09
geguileosmcginnis: when I say older I mean 5.6 or earlier14:09
geguileosmcginnis: for centos version I believe the issue is caused by the 4K page sizes14:09
smcginnisSo two different causes, same issue?14:10
geguileoyup14:10
smcginnisI thought we set the page size when we initialized the DB...14:10
geguileoI must admit I don't know if we do or don't...14:10
smcginnisHmm, no, looks like we just set the charset.14:11
geguileothe default seems to be 16K, but maybe for some reason in those installations it's 4K14:12
*** Bhujay has quit IRC14:12
e0nejungleboyj, smcginnis: hi. I've got few questions accorsing to  https://bugs.launchpad.net/cinder/+bug/180207014:13
openstackLaunchpad bug 1802070 in openstack-ansible "Add resource_filter field in cinder.conf for non-admin user can retrieve volume & snapshot volume" [Undecided,In progress] - Assigned to KimMinsik (for-beatitudo)14:13
geguileosmcginnis: mmmmm, maybe I'm missreading something... looking again..14:14
*** eharney has joined #openstack-cinder14:15
smcginnise0ne: I hadn't seen that one yet.14:17
e0nesmcginnis: we discussed it few meetings ago14:17
geguileosmcginnis: OK, I didn't missread it, what I said was right14:18
smcginnisgeguileo: Great, thanks!14:18
e0neis it OK to skip filters in there is no any 'resource_query_filters_file' file or we need to have some defaults in the code?14:19
smcginnisI would think we probably need some defaults.14:20
e0nesmcginnis: +1. I just wanted to be sure on it14:21
noonedeadpunksmcginnis e0ne can you please re-check this patch? https://review.openstack.org/#/c/625058/1314:30
openstackgerritEric Harney proposed openstack/cinder stable/rocky: DNM: Test Ceph job  https://review.openstack.org/62617814:32
*** udesale has joined #openstack-cinder14:50
*** idlemind has joined #openstack-cinder14:55
*** erlon_ has quit IRC15:01
*** erlon has joined #openstack-cinder15:01
*** dpawlik has quit IRC15:04
lixiaoy1eharney, Hi Eric, as discussed in last week Cinder meeting, could you help to review   https://review.openstack.org/#/c/624853 ?15:04
*** dpawlik has joined #openstack-cinder15:05
lixiaoy1eharney, it is related to driver reinitialization15:05
eharneylixiaoy1: yes, will take a look15:06
*** dpawlik has quit IRC15:06
*** dpawlik has joined #openstack-cinder15:06
*** gnufied has joined #openstack-cinder15:07
lixiaoy1eharney, thank you15:07
*** dpawlik has quit IRC15:11
*** dpawlik has joined #openstack-cinder15:23
*** dpawlik has quit IRC15:27
openstackgerritTiago Pasqualini da Silva proposed openstack/cinder master: Remove support for NetApp E-Series systems  https://review.openstack.org/62621915:34
*** erlon_ has joined #openstack-cinder15:36
*** luizbag has quit IRC15:39
*** erlon has quit IRC15:39
smcginnistpsilva: Was e-series deprecated in Rocky? I can't recall.15:40
tpsilvasmcginnis: yep15:41
tpsilvalemme find the commit15:41
tpsilvasmcginnis: https://github.com/openstack/cinder/commit/747373f4bdfe4814000a88e4443b56545d5d55bd#diff-3b21a3b5b1b6cf0593783320da295abb15:41
smcginnisPerfect, thanks tpsilva!15:42
openstackgerritHelen Walsh proposed openstack/cinder master: VMAX Driver - Failover Unisphere Support  https://review.openstack.org/57040115:42
smcginnis10,000+ less lines of code in Cinder. #winning15:42
tpsilvahahaha15:42
*** luizbag has joined #openstack-cinder15:43
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver - rebranding VMAX to PowerMax  https://review.openstack.org/62065915:44
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  changing from 8.4 to 9.0 REST endpoints  https://review.openstack.org/62529715:47
*** jmlowe has joined #openstack-cinder15:47
*** luizbag_ has joined #openstack-cinder15:49
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax driver -  code cleanup and minor improvements  https://review.openstack.org/62558115:50
*** Liang__ has joined #openstack-cinder15:52
*** luizbag has quit IRC15:52
*** Bhujay has joined #openstack-cinder15:57
*** Liang__ is now known as LiangFang15:58
*** Bhujay has quit IRC15:58
*** Bhujay has joined #openstack-cinder15:58
*** Bhujay has quit IRC15:59
*** Bhujay has joined #openstack-cinder16:00
*** Bhujay has quit IRC16:01
*** Bhujay has joined #openstack-cinder16:01
*** Bhujay has quit IRC16:02
*** Bhujay has joined #openstack-cinder16:03
*** Bhujay has quit IRC16:04
*** Bhujay has joined #openstack-cinder16:04
*** Bhujay has quit IRC16:05
*** Bhujay has joined #openstack-cinder16:06
*** Bhujay has quit IRC16:07
*** Bhujay has joined #openstack-cinder16:07
*** Bhujay has quit IRC16:08
*** Bhujay has joined #openstack-cinder16:09
*** _alastor_ has joined #openstack-cinder16:10
*** Bhujay has quit IRC16:10
*** Bhujay has joined #openstack-cinder16:10
*** Bhujay has quit IRC16:11
*** Bhujay has joined #openstack-cinder16:12
*** Bhujay has quit IRC16:13
*** Bhujay has joined #openstack-cinder16:13
*** Bhujay has quit IRC16:14
*** Bhujay has joined #openstack-cinder16:15
*** itlinux has joined #openstack-cinder16:15
*** Bhujay has quit IRC16:16
*** Bhujay has joined #openstack-cinder16:16
*** Bhujay has quit IRC16:17
*** Bhujay has joined #openstack-cinder16:18
*** Bhujay has quit IRC16:19
*** Bhujay has joined #openstack-cinder16:19
*** Bhujay has quit IRC16:20
*** Bhujay has joined #openstack-cinder16:21
*** Bhujay has quit IRC16:22
*** Bhujay has joined #openstack-cinder16:22
*** Bhujay has quit IRC16:23
*** Bhujay has joined #openstack-cinder16:24
*** luizbag_ has quit IRC16:24
*** eharney has quit IRC16:24
*** Bhujay has quit IRC16:25
*** luizbag has joined #openstack-cinder16:25
*** Bhujay has joined #openstack-cinder16:25
*** dpawlik has joined #openstack-cinder16:26
*** Bhujay has quit IRC16:26
*** Bhujay has joined #openstack-cinder16:27
*** Bhujay has quit IRC16:28
*** Bhujay has joined #openstack-cinder16:28
*** Bhujay has quit IRC16:29
*** luizbag has quit IRC16:30
*** Bhujay has joined #openstack-cinder16:30
*** dpawlik has quit IRC16:30
*** Bhujay has quit IRC16:31
*** Bhujay has joined #openstack-cinder16:31
*** Bhujay has quit IRC16:32
*** Bhujay has joined #openstack-cinder16:33
*** Bhujay has quit IRC16:34
*** Bhujay has joined #openstack-cinder16:34
*** udesale has quit IRC16:35
*** Bhujay has quit IRC16:35
*** Bhujay has joined #openstack-cinder16:36
*** Bhujay has quit IRC16:37
*** Bhujay has joined #openstack-cinder16:37
*** Bhujay has quit IRC16:38
*** Bhujay has joined #openstack-cinder16:39
*** Bhujay has quit IRC16:40
*** Bhujay has joined #openstack-cinder16:40
openstackgerritSilvan Kaiser proposed openstack/cinder master: [WIP] Add _context to online snapshots in remotefs driver  https://review.openstack.org/57088516:41
*** jistr has quit IRC16:41
*** Bhujay has quit IRC16:41
*** jistr has joined #openstack-cinder16:42
*** Bhujay has joined #openstack-cinder16:42
*** dpawlik has joined #openstack-cinder16:42
*** Bhujay has quit IRC16:43
*** Bhujay has joined #openstack-cinder16:43
*** Bhujay has quit IRC16:44
*** Bhujay has joined #openstack-cinder16:45
*** luizbag has joined #openstack-cinder16:45
openstackgerritSilvan Kaiser proposed openstack/cinder master: [WIP] Add _context to online snapshots in remotefs driver  https://review.openstack.org/57088516:46
*** Bhujay has quit IRC16:46
*** jistr_ has joined #openstack-cinder16:46
*** dpawlik has quit IRC16:46
*** Bhujay has joined #openstack-cinder16:46
*** jistr has quit IRC16:47
*** Bhujay has quit IRC16:47
*** Bhujay has joined #openstack-cinder16:48
*** helenafm has quit IRC16:49
*** Bhujay has quit IRC16:49
*** Bhujay has joined #openstack-cinder16:49
*** Bhujay has quit IRC16:50
*** Bhujay has joined #openstack-cinder16:51
*** jistr_ has quit IRC16:51
*** jistr has joined #openstack-cinder16:52
*** Bhujay has quit IRC16:52
*** Bhujay has joined #openstack-cinder16:52
*** Bhujay has quit IRC16:53
*** Bhujay has joined #openstack-cinder16:54
*** Bhujay has quit IRC16:55
*** Bhujay has joined #openstack-cinder16:55
*** Bhujay has quit IRC16:56
*** Bhujay has joined #openstack-cinder16:57
*** dpawlik has joined #openstack-cinder16:58
*** Bhujay has quit IRC16:58
*** Bhujay has joined #openstack-cinder16:58
*** Bhujay has quit IRC16:59
*** Bhujay has joined #openstack-cinder17:00
lbragstado/17:00
rosmaitahi17:00
rosmaitahere's my concern17:01
*** Bhujay has quit IRC17:01
rosmaitathe code is built around two kinds of users: admins and regular17:01
*** Bhujay has joined #openstack-cinder17:01
rosmaitathe policies affect who can be put into each category, but not what they can do once there17:02
rosmaitawhat i mean is, stuff like cross-project access is restricted in code17:02
rosmaitayou cannot control it in policy17:02
lbragstaddo you have an example of what you mean by cross-project access?17:02
rosmaitayes, project A looking at project B's resources17:02
*** Bhujay has quit IRC17:02
*** dpawlik has quit IRC17:03
rosmaitaan admin can do that17:03
lbragstadoh - sure17:03
*** Bhujay has joined #openstack-cinder17:03
lbragstadso - if i'm understanding correctly, your concern is that particular usecase isn't allowed through configuration?17:04
*** Bhujay has quit IRC17:04
rosmaitai don't think we want it allowed in configuration17:04
lbragstadoh - ok17:04
lbragstadyes, then i would agree17:04
*** Bhujay has joined #openstack-cinder17:04
rosmaitamy concern is that the policy model and the user model aren't entirely consistent17:04
*** e0ne has quit IRC17:05
*** tbarron has joined #openstack-cinder17:05
lbragstadsorry for the million questions, i just want to make sure i'm on the same page - what do you mean by user model?17:05
rosmaitabasically, admin vs. regular17:05
*** Bhujay has quit IRC17:05
lbragstadgot it17:06
*** Bhujay has joined #openstack-cinder17:06
*** gnufied has quit IRC17:06
rosmaitahere's a question for you17:06
lbragstadand what you mean by "admin" is anyone who happens to have the `admin` role on $something, where $something is a project17:06
rosmaitanot so much the admin role, as much as whoever the project recognizes as acting in the admin context17:07
*** Bhujay has quit IRC17:07
*** Bhujay has joined #openstack-cinder17:07
lbragstadsure, ok.. good ahead with your question17:07
tbarroni seem to have lost my auto-join setting for #openstack-cinder so apologies if I'm re-hashing old ground but17:07
tbarroni'm not sure that the fix in https://review.openstack.org/#/c/626146/ works17:08
tbarroni made a null change review that depends on it17:08
tbarronhttps://review.openstack.org/#/c/626173/17:08
*** Bhujay has quit IRC17:08
tbarronthe centos jobs there still fail setting up devstack17:09
*** Bhujay has joined #openstack-cinder17:09
tbarronwith e.g. http://logs.openstack.org/73/626173/1/check/manila-tempest-minimal-dsvm-cephfs-native-centos-7/fe76d59/logs/devstacklog.txt.gz#_2018-12-19_14_22_28_28517:09
*** Bhujay has quit IRC17:10
*** Bhujay has joined #openstack-cinder17:10
rosmaitatbarron: i don't think that has come up this morning17:11
tbarronrosmaita: kk, thanks17:11
tbarronnot an emergency btw, our centos jobs on master are all non-voting17:11
*** Bhujay has quit IRC17:11
smcginnisgeguileo: Still around? Wondering if that is due to a different than expected exception? ^17:11
smcginnisI would think DBAPIError should work - "DBAPIError exception wrapped from (pymysql.err.InternalError)"17:12
tbarronfor other projects like kolla it may be more important though17:12
*** Bhujay has joined #openstack-cinder17:12
smcginnisDefinitely need to sort that out.17:12
lbragstadrosmaita did you have another question?17:13
smcginnisDidn't want to use TEXT field like they initially proposed, but maybe that's what we need to do.17:13
*** Bhujay has quit IRC17:13
rosmaitalbragstad: sorry, my system just froze up for a few minutes17:13
lbragstadoh - no worries, i just didn't want to cut you off :)17:13
*** Bhujay has joined #openstack-cinder17:13
rosmaitalbragstad: what is the advantage of adding these tests rather than just checking the default policy string?17:14
*** Bhujay has quit IRC17:14
*** Bhujay has joined #openstack-cinder17:15
lbragstadby default check string you mean this? https://github.com/openstack/oslo.policy/blob/master/oslo_policy/opts.py#L4217:15
rosmaitano, sorry, i mean the defaults we define in code17:16
*** Bhujay has quit IRC17:16
rosmaitawhat i mean is17:16
rosmaitathere are already tests to make sure that polices work17:16
lbragstadwell - good question17:16
*** Bhujay has joined #openstack-cinder17:16
lbragstadthe problem is that the test policies are overridden17:17
lbragstadthese are the policies for backups https://github.com/openstack/cinder/blob/master/cinder/policies/backups.py17:17
*** Bhujay has quit IRC17:17
lbragstadwhich is what someone would have out of the box when they install cinder, right?17:17
rosmaitaright17:18
*** Bhujay has joined #openstack-cinder17:18
lbragstadbut those are not what it tested https://github.com/openstack/cinder/blob/master/cinder/tests/unit/policy.json#L55-L5817:18
lbragstads/it/is/17:18
rosmaitaright, but the tests show that whatever policy you provide, the code respects17:18
rosmaitaso why not just do a static check of the policy-in-code string17:19
*** e0ne has joined #openstack-cinder17:19
*** Bhujay has quit IRC17:19
lbragstadwhich tests are you referring to?17:19
*** Bhujay has joined #openstack-cinder17:19
rosmaitathe cinder policy code tests + the oslo.policy tests17:19
lbragstadthe ones currently in review? or the existing ones?17:20
rosmaitasorry, the existing ones17:20
rosmaitawhat i'm saying is17:20
rosmaitawhy not replace the ones under review with checks of the string in the code to make sure the policy has not changed17:20
*** Bhujay has quit IRC17:20
rosmaitalike for instance, the policies whose default is currently ""17:21
lbragstadyou mean put the defaults in https://github.com/openstack/cinder/blob/master/cinder/tests/unit/policy.json#L55-L5817:21
rosmaitawe can't really check that17:21
*** Bhujay has joined #openstack-cinder17:21
*** Bhujay has quit IRC17:22
lbragstadyeah - "" is essentially an unauthorized API17:22
rosmaitalbragstad: yes, basically the equivalent of generating the policy.yaml and doing a diff and making sure there is no change17:22
geguileosmcginnis: I'm on a meeting, I'll get back to you17:22
*** Bhujay has joined #openstack-cinder17:22
lbragstadyou could do that, but since the policies are in code by default, you don't really need a policy file defined for testing17:22
rosmaitai think we are talking past each other here17:23
*** Bhujay has quit IRC17:23
*** Bhujay has joined #openstack-cinder17:24
*** e0ne has quit IRC17:24
rosmaitamy question is: if the goal of the tests is to make sure that the default policies defined by cinder in code don't change, why not just look directly at the defined policy? why go through all the request-making stuff the proposed tests are doing?17:24
rosmaita(i told you i was having trouble articulating my concern!)17:25
rosmaitai think i am missing something17:25
*** Bhujay has quit IRC17:25
lbragstadi can hop on audio if it's easier to discuss17:25
*** Bhujay has joined #openstack-cinder17:25
*** Bhujay has quit IRC17:26
*** Bhujay has joined #openstack-cinder17:27
rosmaitasure17:27
rosmaitalbragstad: https://bluejeans.com/brosmait17:28
*** Bhujay has quit IRC17:28
*** Bhujay has joined #openstack-cinder17:28
lbragstadsweet - joined17:29
*** Bhujay has quit IRC17:29
*** Bhujay has joined #openstack-cinder17:30
*** Bhujay has quit IRC17:31
*** Bhujay has joined #openstack-cinder17:31
*** Bhujay has quit IRC17:32
*** Bhujay has joined #openstack-cinder17:33
*** Bhujay has quit IRC17:34
*** Bhujay has joined #openstack-cinder17:34
*** Bhujay has quit IRC17:35
*** Bhujay has joined #openstack-cinder17:36
*** Bhujay has quit IRC17:37
*** Bhujay has joined #openstack-cinder17:37
*** Bhujay has quit IRC17:38
openstackgerritMerged openstack/python-cinderclient master: Re-enable shell UUID completion cache  https://review.openstack.org/61061917:39
*** Bhujay has joined #openstack-cinder17:39
*** Bhujay has quit IRC17:40
*** Bhujay has joined #openstack-cinder17:40
*** Bhujay has quit IRC17:41
*** Bhujay has joined #openstack-cinder17:42
*** Bhujay has quit IRC17:43
*** Bhujay has joined #openstack-cinder17:43
*** Bhujay has quit IRC17:44
*** Bhujay has joined #openstack-cinder17:45
*** Bhujay has quit IRC17:46
*** gkadam has quit IRC17:46
*** Bhujay has joined #openstack-cinder17:46
*** Bhujay has quit IRC17:47
*** dpawlik has joined #openstack-cinder17:48
*** Bhujay has joined #openstack-cinder17:48
*** Bhujay has quit IRC17:49
*** Bhujay has joined #openstack-cinder17:49
*** Bhujay has quit IRC17:50
*** Bhujay has joined #openstack-cinder17:51
*** Bhujay has quit IRC17:52
*** Bhujay has joined #openstack-cinder17:52
*** dpawlik has quit IRC17:53
*** Bhujay has quit IRC17:53
*** Bhujay has joined #openstack-cinder17:54
*** Bhujay has quit IRC17:55
*** Bhujay has joined #openstack-cinder17:55
*** Bhujay has quit IRC17:56
*** Bhujay has joined #openstack-cinder17:57
*** Bhujay has quit IRC17:58
*** Bhujay has joined #openstack-cinder17:58
*** Bhujay has quit IRC17:59
*** Bhujay has joined #openstack-cinder18:00
*** dpawlik has joined #openstack-cinder18:04
openstackgerritMerged openstack/os-brick master: Windows SMBFS: fix using share subdirs  https://review.openstack.org/62025318:04
*** Bhujay has quit IRC18:05
*** dpawlik has quit IRC18:09
geguileosmcginnis: tbarron it is weird...18:16
geguileoI can only think that it is raising the InternalError instead of the DBAPIError18:17
geguileoand the wrap on DBAPIError is done at a higher level18:17
smcginnisYeah, that's all I could think of.18:17
smcginnisOr if somehow the depends-on was not working in this case.18:17
hemnasup peeps18:18
geguileosmcginnis: Since the patch hasn't merged, I'll change it to just catch Exception, like we do in https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/migrate_repo/versions/085_cinder_init.py#L78218:18
smcginnisgeguileo: Works for me. I suppose we really don't care about specific exceptions. If anything is thrown then oh well.18:20
smcginnisHowdy hemna18:20
openstackgerritGorka Eguileor proposed openstack/cinder master: Ignore migration 127 error on MariaDB  https://review.openstack.org/62614618:20
geguileosmcginnis: tbarron submitted new patch and going to hit recheck on the dependent patch18:21
openstackgerritMerged openstack/cinder master: Allow to use _max qos option together with per_gb  https://review.openstack.org/62505818:22
*** gnufied has joined #openstack-cinder18:24
lbragstadrosmaita here is an example of what we're doing in keystone that add the same test coverage yikun is working on for cinder https://review.openstack.org/#/c/623334/218:24
rosmaitalbragstad: thanks!18:28
tbarrongeguileo: thanks for rechecking and trying the broad exception, if it still fails then prob. Depends-on: isn't right or is broken18:31
geguileotbarron: I checked that, and it said that it was merging the right patch18:31
geguileoin the devstack logs18:31
tbarrongeguileo: kk18:32
*** e0ne has joined #openstack-cinder18:33
*** e0ne has quit IRC18:40
openstackgerritMerged openstack/cinder master: Handle image download and conversion errors  https://review.openstack.org/61897618:42
*** gnufied has quit IRC18:42
*** gnufied has joined #openstack-cinder18:43
openstackgerritMerged openstack/cinder master: Move tgt targets to privsep  https://review.openstack.org/61313718:49
smcginnis_alastor_: "Sure, you can scan my badge for free stuff." https://www.flickr.com/photos/143247548@N03/46307863422/in/photostream/19:10
smcginnis:)19:10
_alastor_smcginnis: Ha!  I think that was the first booth I hit at the con19:12
_alastor_smcginnis: My gmail filter for all the con spam has been working hard this morning19:13
smcginnis_alastor_: Some of those folks don't give up easily. I steer way clear of the DataDog booth at any of those.19:14
*** dpawlik has joined #openstack-cinder19:25
*** luizbag has quit IRC19:27
*** dpawlik has quit IRC19:30
*** gouthamr_ is now known as gouthamr19:38
*** e0ne has joined #openstack-cinder19:40
*** dpawlik has joined #openstack-cinder19:41
*** dpawlik has quit IRC19:46
*** erlon_ has quit IRC19:55
*** david-lyle has quit IRC20:04
*** abishop has quit IRC20:10
*** markvoelker has joined #openstack-cinder20:14
*** dklyle has joined #openstack-cinder20:15
*** markvoelker has quit IRC20:19
*** e0ne has quit IRC20:23
geguileotbarron: smcginnis it looks like this one actually fixed it :-)20:24
geguileohttps://review.openstack.org/#/c/626173/20:24
tbarrongeguileo: yup!20:24
geguileotbarron: oh, you had already noticed XD20:25
* geguileo checked first tbarron's patch20:25
tbarrongeguileo: i got an email and looked20:25
geguileo:-)20:25
smcginnisOh good. Must have been wrapped higher up or something.20:25
tbarrongeguileo: can we get that corner case downstream?20:25
geguileotbarron: I don't know... my brain is liquid right now...20:26
tbarrongeguileo: well if we do we'll figure it out in 9 months20:27
geguileorofl20:27
geguileotbarron: without thinking too much, I doubt that many people are doing 255 chars on anything...20:28
tbarrongeguileo: right, but I dunno much about unicode length expansion -- seems not likely though20:28
geguileotbarron: no, no, 255 unicode chars20:29
tbarrongeguileo: ah20:29
*** jmlowe has quit IRC20:31
geguileojungleboyj: NetApp and erlon are happy with this patch you already looked at (don't know if you reviewed it) https://review.openstack.org/#/c/62157520:32
*** alkhodos has quit IRC21:00
*** alkhodos has joined #openstack-cinder21:01
*** alkhodos has quit IRC21:06
*** ganso has quit IRC21:19
*** hedvig_01 has joined #openstack-cinder21:22
*** dpawlik has joined #openstack-cinder21:42
*** dpawlik has quit IRC21:46
*** dpawlik has joined #openstack-cinder21:58
*** dpawlik has quit IRC22:02
smcginnisgeguileo: Still around? Wondering if I should take care of the pep8 error in the migration patch.22:03
openstackgerritSean McGinnis proposed openstack/cinder master: Ignore migration 127 error on MariaDB  https://review.openstack.org/62614622:15
*** markvoelker has joined #openstack-cinder22:15
openstackgerritAngela Smith proposed openstack/cinder master: REST connector for Brocade zone driver  https://review.openstack.org/61710022:17
*** rcernin has joined #openstack-cinder22:19
*** rcernin has quit IRC22:36
*** rcernin has joined #openstack-cinder22:37
*** erlon_ has joined #openstack-cinder22:43
*** tpsilva has quit IRC22:53
*** rcernin has quit IRC22:57
*** rcernin has joined #openstack-cinder22:58
*** rcernin has quit IRC22:59
*** alkhodos has joined #openstack-cinder23:05
*** rcernin has joined #openstack-cinder23:07
*** jmlowe has joined #openstack-cinder23:16
*** mchlumsky has quit IRC23:18
*** LiangFang has quit IRC23:24
*** rcernin has quit IRC23:38
*** rcernin has joined #openstack-cinder23:41
*** erlon_ has quit IRC23:46
hedvig_01@smcginnis: thank you for the comments. I'm working on it at the moment. We have all 254 tests passing successfully now. We made some changes in our backend to get this working. Thank you for the support. I shall respond to the comments inline23:58
*** dpawlik has joined #openstack-cinder23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!