Monday, 2018-10-08

*** swamireddy has joined #openstack-cinder00:01
*** swamireddy has joined #openstack-cinder00:01
*** hoangcx has joined #openstack-cinder00:53
*** erlon has joined #openstack-cinder01:15
*** yikun has joined #openstack-cinder01:16
yikunhello01:17
*** tommylikehu has joined #openstack-cinder01:31
*** lixiaoy1 has joined #openstack-cinder01:34
*** mschuppert has quit IRC01:36
*** jiapei has joined #openstack-cinder01:39
openstackgerritYikun Jiang proposed openstack/cinder master: Fix wrong uuid recognized when create group  https://review.openstack.org/60566601:51
*** mhen has quit IRC01:58
*** mhen has joined #openstack-cinder02:00
openstackgerritYikun Jiang proposed openstack/cinder master: Refactor of _clone_image_volume  https://review.openstack.org/60631002:24
*** faizy98 has joined #openstack-cinder02:25
*** faizy_ has quit IRC02:27
openstackgerritYikun Jiang proposed openstack/cinder master: WIP: Make backup init_host more effectively  https://review.openstack.org/60680002:28
*** dave-mccowan has quit IRC02:30
openstackgerrityenai proposed openstack/os-brick master: Improve VolumePathsNotFound message details  https://review.openstack.org/60557602:56
*** LiangFang has joined #openstack-cinder03:24
openstackgerrityenai proposed openstack/os-brick master: Remove unused connection properties  https://review.openstack.org/60428703:29
*** kaisers has quit IRC03:56
*** kaisers has joined #openstack-cinder04:05
*** kaisers has quit IRC04:12
*** kaisers has joined #openstack-cinder04:19
*** hoangcx has quit IRC04:27
*** pooja_jadhav has joined #openstack-cinder04:33
*** sheel has joined #openstack-cinder05:11
*** tommylikehu has quit IRC05:27
*** lixiaoy1 has quit IRC05:32
openstackgerritYong Huang proposed openstack/os-brick stable/rocky: The validation of iscsi session should be case insensitive  https://review.openstack.org/60857805:51
openstackgerritYikun Jiang proposed openstack/cinder master: Extract _get_image_metadata into volume utils  https://review.openstack.org/60634506:18
openstackgerritYikun Jiang proposed openstack/cinder master: WIP: volume reimage  https://review.openstack.org/60634606:18
*** e0ne has joined #openstack-cinder06:21
openstackgerritzhufl proposed openstack/cinder master: api-ref: qos and extra_spec are optional in types view  https://review.openstack.org/60858506:31
openstackgerritzhufl proposed openstack/cinder master: api-ref: qos and extra_spec are optional in types view  https://review.openstack.org/60858506:46
openstackgerritwang yong proposed openstack/cinder master: Cinder volume driver for Inspur AS13000 series  https://review.openstack.org/60233807:18
*** rcernin has quit IRC07:21
*** chenhaw has joined #openstack-cinder07:22
openstackgerritYikun Jiang proposed openstack/cinder-specs master: Add volume re-image api  https://review.openstack.org/60531707:29
openstackgerritYikun Jiang proposed openstack/cinder master: Extract _get_image_metadata into volume utils  https://review.openstack.org/60634508:03
*** amoralej|off is now known as amoralej08:04
openstackgerritYikun Jiang proposed openstack/cinder master: WIP: volume reimage  https://review.openstack.org/60634608:04
openstackgerritOpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata  https://review.openstack.org/60860608:07
*** belmoreira has joined #openstack-cinder08:17
*** hoangcx has joined #openstack-cinder08:49
*** lemko has joined #openstack-cinder09:28
*** faizy_ has joined #openstack-cinder09:44
*** faizy98 has quit IRC09:48
*** LiangFang has quit IRC10:05
*** luizbag has joined #openstack-cinder10:21
*** rcernin has joined #openstack-cinder10:35
*** dpawlik has joined #openstack-cinder10:37
*** Luzi has joined #openstack-cinder10:46
*** dave-mccowan has joined #openstack-cinder10:47
*** erlon has quit IRC11:08
*** psachin has joined #openstack-cinder11:12
*** rcernin has quit IRC11:17
*** faizy98 has joined #openstack-cinder11:22
*** crazik has joined #openstack-cinder11:23
*** faizy_ has quit IRC11:24
*** belmorei_ has joined #openstack-cinder11:48
*** belmoreira has quit IRC11:51
*** e0ne has quit IRC12:04
*** e0ne has joined #openstack-cinder12:13
*** brinzhang has quit IRC12:28
openstackgerrithongwei.xu proposed openstack/cinder master: Extract user_id from context as the operator id  https://review.openstack.org/59412412:44
*** crazik has left #openstack-cinder12:45
openstackgerritJosephine Seifert proposed openstack/cinder-specs master: Spec for the Cinder part of Image Encryption  https://review.openstack.org/60866312:54
*** psachin has quit IRC13:01
*** eharney has joined #openstack-cinder13:02
*** e0ne has quit IRC13:05
*** dustins has joined #openstack-cinder13:13
*** mriedem has joined #openstack-cinder13:15
*** raghavendrat has joined #openstack-cinder13:22
*** raghavendrat has quit IRC13:23
openstackgerritJosephine Seifert proposed openstack/cinder-specs master: Spec for the Cinder part of Image Encryption  https://review.openstack.org/60866313:24
*** erlon has joined #openstack-cinder13:30
*** erlon_ has joined #openstack-cinder13:31
*** erlon has quit IRC13:35
*** zul has quit IRC13:38
*** enriquetaso has joined #openstack-cinder13:41
*** sheel has quit IRC13:50
*** kukacz has quit IRC13:54
*** kukacz has joined #openstack-cinder13:54
openstackgerritMerged openstack/cinder master: Imported Translations from Zanata  https://review.openstack.org/60860613:58
*** asbishop has joined #openstack-cinder14:02
*** ganso has joined #openstack-cinder14:05
*** munimeha1 has joined #openstack-cinder14:07
*** rosmaita has joined #openstack-cinder14:13
*** SteelyDan is now known as dansmith14:13
*** gnufied has joined #openstack-cinder14:16
*** e0ne has joined #openstack-cinder14:17
*** eharney has quit IRC14:24
*** lpetrut has joined #openstack-cinder14:32
*** faizy_ has joined #openstack-cinder14:33
*** faizy98 has quit IRC14:36
*** enriquetaso_ has joined #openstack-cinder14:45
*** enriquetaso has left #openstack-cinder14:45
*** Emine has joined #openstack-cinder14:49
*** enriquetaso_ has quit IRC14:50
*** itlinux has quit IRC14:50
*** gcb_ has joined #openstack-cinder14:53
*** e0ne has quit IRC14:54
*** faizy98 has joined #openstack-cinder14:56
*** lpetrut has quit IRC14:57
*** faizy_ has quit IRC14:58
*** mriedem has quit IRC15:03
*** dklyle has joined #openstack-cinder15:04
*** mriedem has joined #openstack-cinder15:04
*** enriquetaso_ has joined #openstack-cinder15:09
*** e0ne has joined #openstack-cinder15:11
*** enriquetaso_ has quit IRC15:16
*** Luzi has quit IRC15:17
jgriffitherlon_: so my point was that a simple single line bug included 33 lines of stuff that wasn't really needed.15:17
jgriffitherlon_: I aslo find the commit meesage confusing and rather misleading.  The multiple statement of "incorrect assumption" are completely irrelevant and well... "incorrect assumptions"15:18
jgriffithbut regardless, it's your driver so if you're happy with it it's fine by me15:18
*** Emine has quit IRC15:21
*** enriquetaso_ has joined #openstack-cinder15:24
*** enriquetaso_ has quit IRC15:27
*** enriquetaso has joined #openstack-cinder15:27
openstackgerritGaudenz Steinlin proposed openstack/cinder stable/pike: RBD: Don't query Ceph on stats for exclusive pools  https://review.openstack.org/60719215:33
*** e0ne has quit IRC15:40
*** e0ne has joined #openstack-cinder15:42
*** itlinux has joined #openstack-cinder15:43
*** faizy_ has joined #openstack-cinder15:48
*** e0ne has quit IRC15:49
*** faizy98 has quit IRC15:52
mriedemwill a volume extend operation take longer when it has snapshots?15:59
mriedemor should that be unrelated?15:59
mriedemhttps://bugs.launchpad.net/cinder/+bug/179670816:01
openstackLaunchpad bug 1796708 in Cinder "VolumesExtendTest.test_volume_extend_when_volume_has_snapshot intermittently fails with "Extend volume failed.: VolumeNotDeactivated: Volume volume-5514a6ad-abbb-46b3-a464-d73cc67e55af was not deactivated in time."" [Undecided,New]16:01
smcginnismriedem: I would think it would be unrelated, but different storage works in different ways, so not sure if there are some where that could happen.16:02
mriedemthis is lvm16:02
mriedemso seems it should be unrelated16:02
mriedemmight just be a slow compute node16:02
smcginnisI didn't think LVM would make a difference, but I am not really an LVM expert.16:02
smcginnisI would go with the slow compute node idea.16:02
*** gcb_ has quit IRC16:03
*** faizy_ has quit IRC16:10
*** raunak12 has joined #openstack-cinder16:10
*** faizy_ has joined #openstack-cinder16:10
*** belmorei_ has quit IRC16:11
*** faizy_ has quit IRC16:15
*** faizy98 has joined #openstack-cinder16:16
*** supamatt has joined #openstack-cinder16:19
*** supamatt has quit IRC16:19
*** supamatt has joined #openstack-cinder16:19
*** faizy98 has quit IRC16:20
*** faizy98 has joined #openstack-cinder16:23
jungleboyjsmcginnis:  ++16:26
jungleboyjI have not heard of snapshots impacting LVM performance in the past.  Other storage, maybe.16:26
*** eharney has joined #openstack-cinder16:43
prometheanfiresmcginnis: you know about the new oslo-messaging? http://logs.openstack.org/21/607521/2/check/cross-cinder-py35/e15722e/testr_results.html.gz16:48
smcginnisprometheanfire: Wow, no, I hadn't seen that. Looks... bad.16:49
prometheanfireyep, not just cinder either16:49
smcginnisprometheanfire: Have you pinged the oslo folks?16:49
prometheanfirenot yet16:50
imacdonnI think there was some change in the cinder code in the past w.r.t. _get_transport16:58
imacdonnI recall this because it prevents stable/pike cinder (which doesn't have the change) from working on devstack/master16:58
imacdonnthis, I think https://review.openstack.org/#/c/473716/16:59
imacdonnI was looking at a glance example .. I guess the test are failing in a different way for cinder17:03
*** raunak12_ has joined #openstack-cinder17:04
*** raunak12 has quit IRC17:05
*** raunak12_ is now known as raunak1217:05
imacdonnlooks like the cinder test conf fixture needs to be updated to use transport_url instead of rpc_backend (which was deprecated in the Newton era)17:06
imacdonnhttps://bugs.launchpad.net/oslo.messaging/+bug/171239917:08
openstackLaunchpad bug 1712399 in oslo.messaging "Remove the deprecated rpc_backend configuration option" [Medium,Fix released] - Assigned to Steve Kowalik (stevenk)17:08
*** faizy_ has joined #openstack-cinder17:20
*** faizy98 has quit IRC17:23
*** e0ne has joined #openstack-cinder17:24
*** e0ne has quit IRC17:29
smcginnisOh, good find imacdonn17:38
smcginnisSo did oslo.messaging backport a config option removal?17:39
imacdonnsmcginnis: I think they just finally implemented it .. it's been deprecated, but not removed, for a long time, apparently17:39
imacdonnI was able to reproduce the test failures, and updating the general conf fixture makes some of them go away ... there are some third party driver tests that need updating too, though17:40
jungleboyjimacdonn:  They also just did a Messaging release last week.17:47
jungleboyjMight be why we are just seeing this now.17:47
imacdonnjungleboyj: yes, it's new in 9.0.017:47
prometheanfireimacdonn: smcginnis keystone has the problem too17:54
prometheanfirekmalloc: ^?17:54
*** e0ne has joined #openstack-cinder17:54
kmallochm.17:54
prometheanfirenot sure if you three (projects) want to work together on it or anything or if the ml would be good17:54
imacdonnprometheanfire: Seems the problems are somewhat obvious ... will probably have to be dealt with individually (by project), IMO17:55
*** imacdonn has quit IRC18:23
*** imacdonn has joined #openstack-cinder18:23
smcginnisI think get-capabilities is my new favorite "what were they thinking" command.18:42
smcginnisAnd the fact that we have GETs that perform actions on things is a close second.18:53
*** _hemna has quit IRC18:54
*** _hemna has joined #openstack-cinder18:54
*** faizy_ has quit IRC18:55
imacdonnGetting a new failure running unit tests on master (not with the new oslo.messaging):19:00
imacdonn    oslo_config.cfg.NoSuchOptError: no such option nfs_sparsed_volumes in group [DEFAULT]19:00
imacdonnat least I can't see how it could be related to the oslo.messaging thing19:01
imacdonn(and I went back to 8.1.2)19:01
imacdonnmaybe it's another one of those funky "depends what order things get run in" deals :/19:02
*** eharney has quit IRC19:02
smcginnisMaybe. I haven't noticed any changes with that config option.19:03
*** eharney has joined #openstack-cinder19:04
imacdonnyeah, running tox with concurrency limited to 4 made it go away ... my 48-vCPU dev box seems to be quite good at finding these issues :/19:10
smcginnisNice dev box!19:13
imacdonnyou'd think .... but it seems to cause more problems than it's worth sometimes19:14
jungleboyjimacdonn:  Yikes.  And I was all proud of the system I just got.19:18
imacdonnheh19:18
jungleboyjimacdonn:  What is that running on?19:18
imacdonnOne of these - it's kindof old, actually: http://www.oracle.com/us/products/servers-storage/servers/x86/x4-2-ds-2008629.pdf19:19
jungleboyjimacdonn:  Oh, I haven't seen a Sun Server in a long time.19:20
imacdonnI haven't seen much else in an even longer time ;)19:21
jungleboyj:-)  I tried to build a Sun Sparc based cluster in College with our old Sparc boxes.19:21
imacdonnI worked for Sun before the acquisition, so yeah .. I've literally been there, done that, and got the t-shirt .. quite a few t-shirts ;)19:23
imacdonnI even have a Sun Cluster shirt!19:23
smcginnisI liked my old Sparc machines.19:24
jungleboyjNice.19:27
amitofrom time to time I get to debug scsi inquiries on a sparc server, not a pleasant sight.19:29
imacdonnthese quotes are annoying - if you try to pass multiple args, they all get combined into one, and stestr barfs: https://github.com/openstack/cinder/blob/master/tox.ini#L2519:32
smcginnisHmm, I wonder if {posargs} isn't actually supposed to be quoted there.19:33
imacdonnyeah, it's not .. checked other examples (nova)19:34
imacdonnwith the quotes remove, I can do like: tox -e py27 -- --concurrency=16 cinder.tests.unit.volume.drivers.test_nfs19:34
imacdonn(issue mentioned above seems to happen when concurrency is 15 or higher)19:36
imacdonnthere's also an example of {posargs} not quoted at https://github.com/openstack/cinder/blob/master/tox.ini#L7419:41
openstackgerritiain MacDonnell proposed openstack/cinder master: Don't quote {posargs} in tox.ini  https://review.openstack.org/60875819:44
imacdonn^ discuss ;)19:44
*** luizbag has quit IRC20:05
imacdonnanyone know what's the purpose of this? It's causing grief with the new oslo.messaging. With it commented out, the tests all work... https://github.com/openstack/cinder/blob/master/cinder/tests/unit/zonemanager/test_fc_zone_manager.py#L49-L5120:08
smcginnisNo idea why that would be mocked on the setup call. My guess is it's not needed.20:09
smcginnisIt may have been trying to do something for one of the tests, but if so, they were doing it wrong. So I don't think it has any effect where it is now and must not actually be needed for whatever test it was meant for.20:10
smcginnisLooks like config used to be modified in that setUp call but has since been removed, so it was probably just missed removing the decorator.20:11
imacdonnso... should that be removed in a separate commit, or can it sneak in with changes for the new oslo.messaging ?20:12
smcginnisProbably should be a separate commit. If it's just that, should be really easy to get it through quick. Then your other changes can be a dependent commit off of that.20:13
imacdonnthey're kindof dependent on eachother, to pass CI20:14
smcginnisimacdonn: I thought it was only when run with really high concurrency.20:16
imacdonnno, that's a different issue20:17
smcginnisOK, then it should be fine to include them together in one commit.20:17
smcginnisAnyone have multiple backends that could give me a paste of the output from "cinder get-capabilities <host>"? Where backends are host@backend-1, host@backend-2.20:18
smcginnisSorry, with "--debug" on the output too.20:18
prometheanfirerosmaita: we were talking about the oslo-messaging thing here too20:18
smcginnisrosmaita: If you were looking to do a cinder patch too... :)20:19
*** e0ne has quit IRC20:19
*** e0ne has joined #openstack-cinder20:20
prometheanfiresmcginnis: nah, glance20:21
smcginnisprometheanfire: Yeah, I was suggesting if he wanted to do the same thing he did for glance with cinder. ;)20:21
imacdonnsmcginnis: looks like he's proposing to dodge the issue(s) by just not allowing the new version20:22
smcginnisimacdonn: Yeah, they've fixed the glitch.20:22
imacdonnseems there are at least two separate issues with the new oslo.messaging ... the deprecated option removal (rpc_backend), and the default value thing20:23
imacdonnthe latter may make this mocked setUp() problem moot ... but kinda seems like it should be removed anyway20:24
smcginnisYeah, I think so.20:24
*** eharney has quit IRC20:32
*** e0ne has quit IRC20:48
*** pcaruana has quit IRC20:49
openstackgerritiain MacDonnell proposed openstack/cinder master: Stop using deprecated rpc_backend option  https://review.openstack.org/60876820:53
*** prometheanfire has left #openstack-cinder20:59
*** itlinux has quit IRC21:08
*** erlon_ has quit IRC21:54
imacdonnsmcginnis jungleboyj: any concerns about https://review.openstack.org/608758 ?22:08
*** dustins has quit IRC22:09
jungleboyjimacdonn:  No expert on that code but it looks ok to me.22:10
imacdonnjungleboyj: thanks!22:10
jungleboyjimacdonn:  Welcome.22:10
rosmaitaimacdonn: to test your change with oslo.messaging 9.0.0, put "Depends-On: https://review.openstack.org/#/c/607521/" in your commit message.  Although 9.0.0 has been released, it's not actually being used by anyone since the upper-constraint is 8.1.222:13
imacdonnrosmaita: OK. I think I'll let it run through Check as-is, and consider that as a next step ... thanks22:14
rosmaitayeah, that was just a point of information kind of thinkg22:15
rosmaita*thing22:15
imacdonnyep, thanks22:15
rosmaitalooks like you are right about 2 separate issues, cinder tests still are still failing against olso masters: http://zuul.openstack.org/builds.html?pipeline=periodic&project=openstack%2Fcinder&job_name=openstack-tox-py27-with-oslo-master22:16
imacdonnyeah, there definitely were uses of the removed option in the cinder unit tests22:17
imacdonnuses? usages? :/22:17
rosmaita'uses' works for me22:18
*** ganso has quit IRC22:24
imacdonnso it passed zuul check as-is ... I'm now wondering which way the the CRD should go ... I think that the requirements change should actually "depends-on" the cinder one22:39
rosmaitadepends on what you want to do22:40
imacdonnwell, I'm thinking that their change shouldn't merge until the cinder one has .. so the dependency should reflect that22:41
rosmaitaright, but if you want to *use* their change in your cinder patch, you need to depend on it22:44
rosmaitazuul will apply their change to upper-constraints before your patch runs22:44
rosmaitathat will raise the u-c to 9.0.022:44
rosmaitaand as long as cinder's requirements.txt says something like "oslo.messaging>=5.8.3", zuul should grab 9.0.0 to test your patch22:45
rosmaitagotta go pick up the kid from soccer practice ... ttyl22:47
imacdonnk, later22:47
*** dave-mccowan has quit IRC22:49
*** munimeha1 has quit IRC22:50
*** rcernin has joined #openstack-cinder22:50
*** dave-mccowan has joined #openstack-cinder22:50
*** mriedem has quit IRC22:57
*** tpsilva has quit IRC23:41

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!