Friday, 2018-09-28

« Thursday, 2018-09-27 Index Saturday, 2018-09-29 »
*** strigazi has quit IRC00:01
*** strigazi has joined #openstack-cinder00:02
*** erlon has quit IRC00:19
*** brinzhang has joined #openstack-cinder00:25
*** raunak12 has quit IRC00:26
*** lixiaoy1 has joined #openstack-cinder00:30
*** erlon has joined #openstack-cinder00:36
yikunwhoami-rajat: https://review.openstack.org/#/c/605020/3  replied. :)01:02
*** mhen has quit IRC01:10
*** mhen has joined #openstack-cinder01:12
*** erlon has quit IRC01:16
*** Dinesh_Bhor has joined #openstack-cinder01:20
*** dpawlik has joined #openstack-cinder01:21
*** dpawlik has quit IRC01:26
*** Dinesh_Bhor has quit IRC01:39
*** itlinux has joined #openstack-cinder01:44
*** itlinux has quit IRC01:44
*** zhaochao has joined #openstack-cinder01:46
*** Dinesh_Bhor has joined #openstack-cinder01:48
*** zzzeek has quit IRC01:48
*** zzzeek has joined #openstack-cinder01:49
*** gnufied has quit IRC01:50
*** brinzh has joined #openstack-cinder01:56
*** mschuppert has joined #openstack-cinder01:57
*** brinzhang has quit IRC01:59
openstackgerritRyan Liang proposed openstack/cinder master: VNX: delete the LUN from VNX backend  https://review.openstack.org/60590402:04
*** gnufied has joined #openstack-cinder02:07
*** gnufied has quit IRC02:07
*** stakeda has joined #openstack-cinder02:26
openstackgerritzhufl proposed openstack/cinder master: api-ref: total/free_capacity should be with postfix _gb  https://review.openstack.org/60590902:30
*** imacdonn has quit IRC02:51
*** imacdonn has joined #openstack-cinder02:51
*** dpawlik has joined #openstack-cinder03:22
*** dpawlik has quit IRC03:27
*** psachin has joined #openstack-cinder03:29
*** raunak12 has joined #openstack-cinder03:44
*** Dinesh_Bhor has quit IRC03:54
*** Nel1x has quit IRC04:07
*** Dinesh_Bhor has joined #openstack-cinder04:24
*** swamireddy has quit IRC04:44
*** Dinesh_Bhor has quit IRC04:58
*** Dinesh_Bhor has joined #openstack-cinder05:02
*** raunak12 has quit IRC05:12
*** itlinux has joined #openstack-cinder05:12
*** dpawlik has joined #openstack-cinder05:23
*** dpawlik has quit IRC05:29
whoami-rajatyikun: responded :)05:39
*** Dinesh_Bhor has quit IRC05:51
*** e0ne has joined #openstack-cinder05:52
*** Dinesh_Bhor has joined #openstack-cinder05:56
*** pcaruana has joined #openstack-cinder06:11
yikunwhoami-rajat: Cool, thanks for your suggestion. +106:12
whoami-rajatyikun:  :-)06:14
*** jdillaman has quit IRC06:17
*** e0ne has quit IRC06:24
*** dpawlik has joined #openstack-cinder06:27
*** dpawlik has quit IRC06:32
*** dpawlik has joined #openstack-cinder06:32
*** jiaopengju has quit IRC06:50
*** e0ne has joined #openstack-cinder06:51
*** jiaopengju has joined #openstack-cinder06:52
*** Luzi has joined #openstack-cinder06:53
*** icey has quit IRC06:54
openstackgerritwang yong proposed openstack/cinder master: Cinder volume driver for Inspur AS13000 series  https://review.openstack.org/60233806:59
openstackgerritzhufl proposed openstack/cinder master: api-ref: add missing fields in volume types  https://review.openstack.org/60598407:06
*** icey has joined #openstack-cinder07:07
*** rcernin has quit IRC07:12
openstackgerritzhufl proposed openstack/cinder master: api-ref: total/free_capacity should be with postfix _gb  https://review.openstack.org/60590907:21
openstackgerritzhufl proposed openstack/cinder master: api-ref: total/free_capacity should be with postfix _gb  https://review.openstack.org/60590907:23
*** gkadam has joined #openstack-cinder07:23
*** amoralej|off is now known as amoralej07:26
openstackgerritzhufl proposed openstack/cinder master: api-ref: add missing fields in volume types  https://review.openstack.org/60598407:30
*** dpawlik has quit IRC07:32
*** dpawlik has joined #openstack-cinder07:34
*** dpawlik has quit IRC07:34
*** dpawlik has joined #openstack-cinder07:34
*** dpawlik has quit IRC07:36
*** markvoelker has quit IRC07:36
*** markvoelker has joined #openstack-cinder07:37
*** jdillaman has joined #openstack-cinder07:41
*** markvoelker has quit IRC07:42
*** hoangcx has quit IRC07:43
*** alexchadin has joined #openstack-cinder07:57
*** hoangcx has joined #openstack-cinder07:57
*** alexchadin has quit IRC08:01
*** alexchadin has joined #openstack-cinder08:11
*** dpawlik has joined #openstack-cinder08:12
*** alexchadin has quit IRC08:16
*** zhaochao has quit IRC08:16
*** alexchadin has joined #openstack-cinder08:18
*** zhaochao has joined #openstack-cinder08:18
*** alexchadin has quit IRC08:25
*** alexchadin has joined #openstack-cinder08:28
*** markvoelker has joined #openstack-cinder08:37
*** lixiaoy1 has quit IRC08:55
*** lixiaoy1 has joined #openstack-cinder08:55
*** vivsoni_ has quit IRC08:56
*** lixiaoy1 has quit IRC08:57
*** markvoelker has quit IRC08:59
whoami-rajatjungleboyj:  smcginnis  geguileo  : please review the multiattach patch https://review.openstack.org/#/c/605650/ Thanks!09:05
whoami-rajatsmcginnis , geguileo , ^^09:06
geguileowhoami-rajat: I'm reviewing it now09:06
whoami-rajatgeguileo: ok. Thanks.09:06
geguileowhoami-rajat: you need to split your test in a new method  :-(09:06
geguileoI wanted to +2 the patch, but each method should cover a single case09:07
geguileowe shouldn't keep growing existing methods with additional cases09:07
whoami-rajatgeguileo: actually all the tests are written under the same method so i thought it should be the valid approach, ok i will separate out a method for the test.09:08
geguileowhoami-rajat: yeah, I know it's not your fault...09:10
geguileowhoami-rajat: some people tend to do it wrong, so the next one does it wrong assuming that's how it should be done09:10
geguileobut unit tests should follow the rule of 1 method = 1 test case09:10
*** alexchadin has quit IRC09:10
geguileootherwise it's really hard to know what the test is actually testing to figure out if it's correct, and if we are covering all cases09:11
whoami-rajatgeguileo:  haha, that's true. i will follow the same approach next time. so should i separate out my test only or change other tests too ?09:12
whoami-rajatgeguileo: or maybe a follow up patch to separate other test methods would be good i guess ?09:16
*** alexchadin has joined #openstack-cinder09:25
openstackgerrittianhui proposed openstack/cinder master: Update doc  https://review.openstack.org/60601309:26
geguileowhoami-rajat: You don't need to fix the other tests in this patch, though I would love to see a follow up patch09:36
*** Dinesh_Bhor has quit IRC09:47
*** Dinesh_Bhor has joined #openstack-cinder09:54
*** Dinesh_Bhor has quit IRC09:54
*** markvoelker has joined #openstack-cinder09:57
*** alexchadin has quit IRC10:05
openstackgerritRajat Dhasmana proposed openstack/cinder master: Fix multiattach set to false after retype  https://review.openstack.org/60565010:16
*** e0ne has quit IRC10:16
*** markvoelker has quit IRC10:18
whoami-rajatgeguileo:  ok will do a follow up then. also created separate testcase.10:18
*** alexchadin has joined #openstack-cinder10:22
*** hoangcx has quit IRC10:23
*** e0ne has joined #openstack-cinder10:25
*** alexchadin has quit IRC10:29
*** abishop has joined #openstack-cinder10:30
*** alexchadin has joined #openstack-cinder10:39
*** luizbag has joined #openstack-cinder10:41
geguileowhoami-rajat: I added some comment there, could you have a look, please?10:43
*** stakeda has quit IRC10:43
*** ganso has joined #openstack-cinder10:52
whoami-rajatgeguileo: sure. wait.11:02
*** erlon has joined #openstack-cinder11:03
*** erlon has quit IRC11:05
*** erlon has joined #openstack-cinder11:06
*** erlon has quit IRC11:07
*** erlon has joined #openstack-cinder11:08
*** alexchadin has quit IRC11:08
openstackgerritBoxiang Zhu proposed openstack/cinder master: Fix bug of cloning volume  https://review.openstack.org/60603811:26
openstackgerritIvan Kolodyazhny proposed openstack/cinder master: Fix backup driver configuration examples in the documetation  https://review.openstack.org/60604011:35
*** dpawlik has quit IRC11:37
*** _ix has joined #openstack-cinder11:43
*** mschuppert has quit IRC11:54
*** Bhujay has joined #openstack-cinder11:58
*** mmethot has joined #openstack-cinder12:00
*** mriedem has joined #openstack-cinder12:29
*** nicolasbock_ has joined #openstack-cinder12:32
*** dustins has joined #openstack-cinder12:36
*** tpsilva has joined #openstack-cinder12:40
openstackgerritwang yong proposed openstack/cinder master: Cinder volume driver for Inspur AS13000 series  https://review.openstack.org/60233812:40
*** brinzh has quit IRC13:00
openstackgerritJay Rubenstein proposed openstack/cinder master: SF ensure the correct volume is deleted  https://review.openstack.org/58414913:04
*** dpawlik has joined #openstack-cinder13:05
*** dpawlik has quit IRC13:08
*** dpawlik has joined #openstack-cinder13:08
whoami-rajatgeguileo:  https://review.openstack.org/#/c/605650/3 , so i responded with what i had in my mind while creating this test, please provide your insights too.13:09
*** psachin has quit IRC13:13
*** zul has quit IRC13:16
openstackgerritIvaylo Mitev proposed openstack/cinder master: Implement volume capacity stats for VMware  https://review.openstack.org/60576213:17
*** zul has joined #openstack-cinder13:17
*** yikun has quit IRC13:21
*** amoralej is now known as amoralej|lunch13:23
_hemnanothing like waking up in the morning to identity theft.  weeee!13:27
*** schegi_ has joined #openstack-cinder13:29
*** Luzi has quit IRC13:30
smcginnisOh joy.13:30
*** david-lyle has joined #openstack-cinder13:34
*** gnufied has joined #openstack-cinder13:34
openstackgerritChen proposed openstack/cinder master: doc: update testing doc  https://review.openstack.org/60608313:35
*** dklyle has quit IRC13:37
*** zzzeek has quit IRC13:43
*** zzzeek has joined #openstack-cinder13:45
*** zzzeek has quit IRC13:48
*** amoralej|lunch is now known as amoralej13:49
jungleboyj_hemna:  Ug, what happened?13:49
*** zzzeek has joined #openstack-cinder13:49
_hemnasomeone snagged my atm card # and tried to charge $900 worth of shoes on a few websites13:51
*** Nel1x has joined #openstack-cinder13:56
*** woojay has joined #openstack-cinder14:08
jungleboyj_hemna:  Yikes!14:17
jungleboyj_hemna:  Sorry.14:17
*** edmondsw_ has joined #openstack-cinder14:26
*** edmondsw has quit IRC14:29
*** edmondsw_ is now known as edmondsw14:29
*** dustins has quit IRC14:34
*** dustins has joined #openstack-cinder14:38
openstackgerritIvaylo Mitev proposed openstack/cinder master: Implement volume capacity stats for VMware  https://review.openstack.org/60576214:57
*** e0ne has quit IRC14:58
*** Bhujay has quit IRC14:58
*** pooja_jadhav has quit IRC14:59
*** e0ne has joined #openstack-cinder15:02
*** dave-mccowan has joined #openstack-cinder15:08
*** raunak12 has joined #openstack-cinder15:12
*** dave-mccowan has quit IRC15:13
whoami-rajatgeguileo: so the exact problem is,15:14
whoami-rajat'objects.VolumeType.get_by_name_or_id' returns VolumeType() Object15:14
whoami-rajatwhereas 'volume_types.get_by_name_or_id' returns dictionary15:14
whoami-rajathttps://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L162315:14
whoami-rajatthis line checks if the target supports multiattach or not15:14
whoami-rajathttps://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L19715:14
whoami-rajathere an empty dict is returned as getattr() is only for objects.15:14
whoami-rajatI modified the 'volume_types.get_by_name_or_id' call to 'objects.VolumeType.get_by_name_or_id' call which always returns a VolumeType object no matter whatever test_volume_type i pass.15:14
whoami-rajatSo I'm not sure as where the test should be created, initially i thought this should come under the objects.test_volume_type file but to relate it to the retype code, i created the same effect in the retype test file.15:14
*** _ix has quit IRC15:14
whoami-rajatself.multiattach_type_dict['extra_specs'] = (getattr(15:17
whoami-rajat            self.multiattach_type_dict, 'extra_specs', {}))15:17
whoami-rajatthis line doesn't enforce the extra_specs but creates the same condition as occoured in _is_multiattach() call.15:17
geguileowhoami-rajat: what I don't get is, if you are returning a versioned object, then the _is_multiattach should find the extra_specs, right?15:23
whoami-rajatgeguileo: yes.15:24
geguileowhoami-rajat: then why would you need to mock the other method?15:24
whoami-rajatgeguileo: actually i'm getting some unexcepted errors after removing it.15:26
geguileothe thing is, that I fear that your fix is only partially fixing the issue15:26
geguileoI'm looking at it now trying to figure out what's missing15:27
openstackgerritRaunak Kumar proposed openstack/cinder master: nimble storage: retype support  https://review.openstack.org/60149215:27
geguileowhoami-rajat: oh, I know what's missing15:27
whoami-rajatgeguileo:  ok, i got no clue.15:28
geguileowhoami-rajat: you are retyping from a type that doesn't have multi-attach to one that has multi-attach15:30
whoami-rajatgeguileo: ok, so if i change the initial type to a multiattach type, i can remove the mock? let me try.15:31
*** raunak12 has quit IRC15:31
geguileowhoami-rajat: no, the problem is that you are checking that multiattach is False15:31
geguileowhoami-rajat: when you should be checking that it's true15:32
geguileowhoami-rajat: and then you can remove the mocking15:32
geguileowhoami-rajat: because the mocking was actually falsifying the tests15:32
whoami-rajatgeguileo: ok, so the case you're specifying is fairly simple i guess, but i was trying to do something more complex. nvm i will update the test. Thanks !15:34
geguileowhoami-rajat: don't know what you were trying to do, but you were faking the test and not testing what we want to tes...15:35
geguileowe are retyping from a type that hasn't defined the multiattach to one that says it's true15:36
openstackgerritRajini Karthik proposed openstack/cinder master: Update Dell EMC Driver's multi-attach Support  https://review.openstack.org/60578115:37
whoami-rajatgeguileo: one more issue, i'm having trouble creating a volume with cinder.tests.unit.utils.create_volume, when i'm passing volume_type=self.multiattach_type in it, the db throws an error saying VolumeType object has no attribute '_sa_instance_state'15:38
geguileowhoami-rajat: probably it's expecting a different type of object.  It could be a string, an OVO, or an ORM instance15:39
whoami-rajatgeguileo: actually that kind of tests already existed, multi -> non-multi, non-multi->multi, but i will implement the multi->multi testcase.15:40
whoami-rajatgeguileo: not working with string15:40
*** zul has quit IRC15:41
geguileowhoami-rajat: check the code to see what's expecting to receive15:41
geguileowhoami-rajat: you too, and thanks for fixing this bug  :-)15:42
whoami-rajatgeguileo: thanks for all the help :)15:52
*** finix has joined #openstack-cinder16:00
*** finix has quit IRC16:01
imacdonnNeed a favor from someone with a development environment handy16:04
imacdonnmake a fresh clone of cinder master, then run "tox -e py27 -- VMAXISCSITest" - do the tests pass or fail ?16:04
*** raunak12 has joined #openstack-cinder16:06
openstackgerritMerged openstack/cinder stable/rocky: Fix image volume cache max size and max count limits  https://review.openstack.org/60575716:07
smcginnisimacdonn: Are you hitting this? https://review.openstack.org/#/c/599016/16:12
imacdonnsmcginnis: Yup. Thank you!16:13
imacdonnthought I was missing something stupid16:13
smcginnisimacdonn: A +1 on there if it fixes your issue would be appreciated. ;)16:13
imacdonnroger16:13
smcginnisThen maybe it might get some attention.16:13
imacdonnI noticed that some of the vmax classes, but not all, do this: volume_utils.get_max_over_subscription_ratio = mock.Mock()16:14
imacdonnthe problem seem to surface somewhat sporadically - maybe depending which tests are run, and in what order... ?16:15
smcginnisThat seemed to be the problem when I looked at it. And why they don't normally fail in the gate.16:16
smcginnisIf other things have run and set things up right, it was good. If the order was different, they would fail.16:16
imacdonnstill don't completely have my head around which bits are shared between tests :/16:17
smcginnisThat's like a master thesis kind of research topic I think.16:18
imacdonnhah yeah16:18
*** dpawlik has quit IRC16:18
imacdonnyour change make the VMAXISCSITest class (by itself) work16:20
imacdonnmade*16:20
smcginnisThere's probably more cleanup that can be done there, but I didn't want to touch their unit tests more than I had to in order to get things working.16:21
*** mriedem is now known as mriedem_lunch16:21
imacdonnI thought I may have seen the problem with some other driver (non-EMC) ... but not sure on that. a full 'py27' run worked OK this time16:22
smcginnisI have no doubt there are other driver tests that rely on order of execution, unfortunately. :/16:23
imacdonnhemna: I suspect you're lurking:) Pls review https://review.openstack.org/59901616:26
*** zul has joined #openstack-cinder16:28
*** ianychoi has quit IRC16:39
*** gkadam has quit IRC16:42
KeithMnemonicsmcginnis: thanks for the review, is driverfixes/mitaka closed now or do i need to put it there?16:43
*** ianychoi has joined #openstack-cinder16:44
*** geguileo is now known as geguileo_PTO16:51
smcginnisKeithMnemonic: Those driverfixes branches are meant to stick around to get fixes past any stable policy restrictions, so it would be good to get that into driverfixes/mitaka too.16:58
KeithMnemonicthanks16:58
openstackgerritMerged openstack/cinder master: Adding variable for total gigabytes used by snapshot param  https://review.openstack.org/60361716:59
openstackgerritMerged openstack/cinder master: Fix backup driver configuration examples in the documetation  https://review.openstack.org/60604017:00
KeithMnemonicsmcginnis: there are about 6 dependencies so you will see a bunch coming in17:02
*** zhaochao has quit IRC17:04
*** Nel1x has quit IRC17:04
openstackgerritIvan Kolodyazhny proposed openstack/cinder stable/rocky: Fix backup driver configuration examples in the documetation  https://review.openstack.org/60614417:06
*** psachin has joined #openstack-cinder17:08
*** e0ne has quit IRC17:44
openstackgerritMerged openstack/os-brick master: 'iscsiadm -m session' failure handling  https://review.openstack.org/60496117:48
*** sapd1_ has joined #openstack-cinder17:51
*** mriedem_lunch has quit IRC17:52
*** mriedem has joined #openstack-cinder17:54
*** david-lyle has quit IRC17:56
*** e0ne has joined #openstack-cinder18:02
*** TheJulia is now known as needssleep18:02
*** e0ne has quit IRC18:05
openstackgerritRajat Dhasmana proposed openstack/cinder master: Fix multiattach set to false after retype  https://review.openstack.org/60565018:10
*** gnufied has quit IRC18:24
*** e0ne has joined #openstack-cinder18:25
*** gnufied has joined #openstack-cinder18:39
*** david-lyle has joined #openstack-cinder18:41
*** david-lyle is now known as dklyle18:42
*** mriedem has quit IRC18:44
*** luizbag has quit IRC18:46
*** e0ne has quit IRC18:50
openstackgerritMerged openstack/cinder master: Add test case: create volume from source volume  https://review.openstack.org/58843118:57
openstackgerritMerged openstack/cinder stable/pike: Optimizes volume creation in the Quobyte Driver  https://review.openstack.org/60072218:57
*** sapd1_ has quit IRC19:24
*** e0ne has joined #openstack-cinder19:29
*** e0ne has quit IRC19:34
openstackgerritAlan Bishop proposed openstack/cinder stable/queens: Fix image volume cache max size and max count limits  https://review.openstack.org/60618719:49
*** mriedem has joined #openstack-cinder19:50
*** Emine has quit IRC19:52
*** Emine has joined #openstack-cinder19:55
*** erlon has quit IRC20:07
*** openstackgerrit has quit IRC20:07
*** psachin has quit IRC20:10
*** openstackgerrit has joined #openstack-cinder20:23
openstackgerritJay Rubenstein proposed openstack/cinder master: SF ensure the correct volume is deleted  https://review.openstack.org/58414920:23
*** mmethot has quit IRC21:00
*** mmethot has joined #openstack-cinder21:00
*** mmethot has quit IRC21:05
*** dustins has quit IRC21:06
*** mriedem has quit IRC21:37
*** KeithMnemonic has quit IRC21:47
*** ganso has quit IRC22:18
openstackgerritMerged openstack/cinder stable/queens: VMAX Driver - Initiator retrieval short hostname fix  https://review.openstack.org/60160522:41
openstackgerritMerged openstack/cinder stable/rocky: Fix backup driver configuration examples in the documetation  https://review.openstack.org/60614422:41
jungleboyjimacdonn: https://review.openstack.org/606216  <--- Release for os-brick .22:49
*** tpsilva has quit IRC22:52
imacdonnjungleboyj: ack22:52
jungleboyjimacdonn:  Should probably do releases for some of the stable branches too.  Need to see what patches are outstanding though.22:53
imacdonnjungleboyj: Makes sense.22:54
jungleboyjIt has been a long day and trying to deal with that mental exercise ... well ...22:55
imacdonnyeah, seems like it might be a Monday type thing :)22:55
jungleboyjInstead doing a relaxing thing like removing drivers that are not running CI anymore.  *Sigh*23:03
* jungleboyj is sarcastic in case anyone couldn't tell.23:04
* imacdonn checks the tintri report real quick, and signs in relief23:04
jungleboyj:-)  Don't think you have to worry.  :-)23:05
imacdonnI have to keep an eye on it ... as of a week ago, ZFSSA CI is using py3 by default, but not for stable/(pike|queens|rocky), and it doesn't try to run for stable/ocata at all23:06
*** raunak12 has quit IRC23:50
« Thursday, 2018-09-27 Index Saturday, 2018-09-29 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!