Wednesday, 2018-08-08

openstackgerritMerged openstack/cinder master: Fix typo on Storwize release note  https://review.openstack.org/58958500:00
*** namnh has joined #openstack-cinder00:00
*** namnh has quit IRC00:01
*** cmart has quit IRC00:15
*** Nel1x has joined #openstack-cinder00:45
*** zul has joined #openstack-cinder00:57
*** markstur_ has quit IRC01:03
*** mriedem has quit IRC01:06
*** zhaochao has joined #openstack-cinder01:24
*** gkadam_ has joined #openstack-cinder02:24
*** gkadam__ has joined #openstack-cinder02:26
*** gkadam_ has quit IRC02:29
*** dave-mccowan has quit IRC02:57
*** dklyle has quit IRC02:58
*** Nel1x has quit IRC02:58
openstackgerritBoxiang Zhu proposed openstack/python-cinderclient master: refactor the getid method base.py  https://review.openstack.org/58969202:59
*** zhurong has joined #openstack-cinder03:01
*** psachin has joined #openstack-cinder03:14
whoami-rajatsmcginnis: ok, thanks for sharing :)03:32
*** erlon has quit IRC03:53
*** zhurong has quit IRC04:20
*** jenglisch has quit IRC04:27
*** vivsoni has quit IRC04:54
*** vivsoni_ has joined #openstack-cinder04:55
*** zhaochao has quit IRC05:02
*** zhaochao has joined #openstack-cinder05:02
*** stakeda has joined #openstack-cinder05:25
*** hoonetorg has quit IRC05:31
*** e0ne has joined #openstack-cinder05:40
*** gkadam__ has quit IRC05:42
*** gkadam has joined #openstack-cinder05:44
*** e0ne has quit IRC05:52
*** hoonetorg has joined #openstack-cinder05:52
*** zhurong has joined #openstack-cinder05:58
*** e0ne has joined #openstack-cinder06:03
*** hemna_ has quit IRC06:03
*** nicolasbock has joined #openstack-cinder06:03
*** dpawlik has joined #openstack-cinder06:05
*** hoonetorg has quit IRC06:06
*** dpawlik has quit IRC06:09
*** gkadam has quit IRC06:09
*** dpawlik has joined #openstack-cinder06:09
*** gkadam has joined #openstack-cinder06:24
*** pcaruana has joined #openstack-cinder06:27
*** BrinZhang has joined #openstack-cinder06:29
*** vivsoni_ has quit IRC06:42
*** vivsoni__ has joined #openstack-cinder06:42
*** gnufied has quit IRC06:43
*** gnufied has joined #openstack-cinder06:47
*** e0ne has quit IRC06:51
amitosmcginnis: ping07:02
amitosmcginnis: regarding your patch - https://review.openstack.org/576939 : 'capacity' does seem similar to oslo's 'units', however, it is used by our SDK (the infinisdk package) that is also required by the driver. Changing 'units' to 'capacity' might solve the pylint error, but it will still fail the driver on environments which have a faulty installation of infinisdk (i.e. missing the capacity installation), since we07:09
amitocheck for infinisdk being None in driver setup, and if it was loaded correctly and 'capacity' was loaded as 'units', you might get some unexpected results...07:09
amitosmcginnis: additionally, 'capacity' is in the driver-requirements.txt file, along with other packages we use.07:12
openstackgerritcaixiaoyu proposed openstack/cinder master: volume/rbd: Judge protected attr when deleting snapshot  https://review.openstack.org/58822607:13
*** rcernin has quit IRC07:35
openstackgerritBoxiang Zhu proposed openstack/cinder master: Fix one help description of rbd driver  https://review.openstack.org/58974607:54
amitosmcginnis: ok, taking what I said back, since now I see we're 'None'-ing everything in the import except clause so the above scenario I described can't really happen.08:00
*** moshele has joined #openstack-cinder08:02
*** zhurong has quit IRC08:26
*** stakeda has quit IRC08:31
*** alexchadin has joined #openstack-cinder09:28
openstackgerritMichael McAleer proposed openstack/cinder master: VMAX Driver - Initiator retrieval short hostname fix  https://review.openstack.org/58977209:34
openstackgerritOpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/rocky: Update .gitreview for stable/rocky  https://review.openstack.org/58978009:35
openstackgerritOpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky  https://review.openstack.org/58978109:35
openstackgerritOpenStack Release Bot proposed openstack/python-brick-cinderclient-ext master: Update reno for stable/rocky  https://review.openstack.org/58978209:35
openstackgerritOpenStack Release Bot proposed openstack/python-cinderclient stable/rocky: Update .gitreview for stable/rocky  https://review.openstack.org/58978309:35
openstackgerritOpenStack Release Bot proposed openstack/python-cinderclient stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky  https://review.openstack.org/58978409:35
openstackgerritOpenStack Release Bot proposed openstack/python-cinderclient master: Update reno for stable/rocky  https://review.openstack.org/58978509:35
*** vivsoni__ has quit IRC09:39
*** edmondsw has joined #openstack-cinder09:45
*** edmondsw has quit IRC09:49
openstackgerritBoxiang Zhu proposed openstack/cinder master: relocate the return of create_volume in rbd driver  https://review.openstack.org/58982009:50
*** vivsoni has joined #openstack-cinder10:00
*** tonyb has quit IRC10:16
*** tonyb has joined #openstack-cinder10:23
*** vivsoni has quit IRC10:23
*** vivsoni has joined #openstack-cinder10:23
*** rambo_li has joined #openstack-cinder10:26
*** vivsoni_ has joined #openstack-cinder10:27
*** vivsoni has quit IRC10:29
*** erlon has joined #openstack-cinder10:38
*** BrinZhang has quit IRC10:53
*** BrinZhang has joined #openstack-cinder10:53
*** ganso has joined #openstack-cinder10:59
*** dave-mccowan has joined #openstack-cinder11:00
*** geguileo has quit IRC11:02
openstackgerritMerged openstack/cinder stable/queens: NEC driver: loss of access after live-migration  https://review.openstack.org/58478111:03
*** luizbag has joined #openstack-cinder11:14
*** BrinZhang has quit IRC11:16
*** BrinZhang has joined #openstack-cinder11:16
*** alysonR__ has joined #openstack-cinder11:36
*** tpsilva has joined #openstack-cinder11:42
*** alexchadin has quit IRC11:47
*** rambo_li has quit IRC11:50
*** alexchadin has joined #openstack-cinder11:54
*** zhangbailin_ has joined #openstack-cinder11:56
*** BrinZhang has quit IRC11:59
*** zhangbailin_ has quit IRC12:00
*** BrinZhang has joined #openstack-cinder12:00
*** wN has quit IRC12:04
openstackgerritMerged openstack/python-brick-cinderclient-ext master: Update reno for stable/rocky  https://review.openstack.org/58978212:07
openstackgerritMerged openstack/python-brick-cinderclient-ext stable/rocky: Update .gitreview for stable/rocky  https://review.openstack.org/58978012:10
*** abishop has joined #openstack-cinder12:24
*** geguileo has joined #openstack-cinder12:34
*** e0ne has joined #openstack-cinder12:34
*** mriedem has joined #openstack-cinder12:59
*** dustins has joined #openstack-cinder13:02
*** BrinZhang has quit IRC13:04
*** edmondsw has joined #openstack-cinder13:05
*** psachin has quit IRC13:12
*** alexchadin has quit IRC13:14
*** e0ne has quit IRC13:18
*** alexchadin has joined #openstack-cinder13:20
*** alexchadin has quit IRC13:22
*** e0ne has joined #openstack-cinder13:31
*** alexchadin has joined #openstack-cinder13:31
openstackgerritMerged openstack/cinder master: Fix one help description of rbd driver  https://review.openstack.org/58974613:37
*** alexchadin has quit IRC13:44
*** alexchadin has joined #openstack-cinder13:45
*** alysonR__ has quit IRC13:57
*** alexchadin has quit IRC14:00
*** alexchadin has joined #openstack-cinder14:00
*** alexchadin has quit IRC14:03
*** cmart has joined #openstack-cinder14:06
*** alysonR__ has joined #openstack-cinder14:08
KeithMnemonicsmcmginnis do i need to abandon my cherry pick from master to pike for the VAS thing and redo it from queens to pike once the queens patch merges?14:18
*** rambo_li has joined #openstack-cinder14:21
smcginnisKeithMnemonic: Technically, that would be the proper way to do it.14:25
smcginnisKeithMnemonic: I think the cherry-pick link in the commit message will still link to be able to find the right patches.14:26
*** moshele has quit IRC14:29
openstackgerritJose Castro Leon proposed openstack/os-brick master: Implement extend_volume for RBD  https://review.openstack.org/58992514:36
*** Roamer` has quit IRC14:40
*** gkadam has quit IRC14:43
*** markstur has joined #openstack-cinder14:51
*** markstur has quit IRC14:51
*** markstur has joined #openstack-cinder14:52
*** e0ne has quit IRC14:58
smcginnisWe have some hang issue with running under python 3.7 that appears to be in the storwize driver or unit tests.14:59
openstackgerritSean McGinnis proposed openstack/cinder master: Add volume create schema enforcement unit tests  https://review.openstack.org/58993515:02
*** rambo_li has quit IRC15:06
*** cmart has quit IRC15:11
*** dpawlik has quit IRC15:19
*** gkadam has joined #openstack-cinder15:24
*** cmart has joined #openstack-cinder15:26
*** hemna_ has joined #openstack-cinder15:34
*** pcaruana has quit IRC15:34
*** zhaochao has quit IRC15:50
*** masayukig has quit IRC15:50
*** zhaochao has joined #openstack-cinder15:52
openstackgerritRajat Dhasmana proposed openstack/cinder master: Add retries to delete a volume in the Nimble Driver  https://review.openstack.org/58995115:54
*** dklyle has joined #openstack-cinder15:55
openstackgerritSean McGinnis proposed openstack/cinder master: Default functional tests to use v3 API  https://review.openstack.org/58995515:56
*** david-lyle has joined #openstack-cinder15:59
*** dklyle has quit IRC16:01
*** david-lyle is now known as dklyle16:02
jungleboyjAnyone want to join the Cinder meeting?16:02
*** dpawlik has joined #openstack-cinder16:19
*** masayukig has joined #openstack-cinder16:20
*** dpawlik has quit IRC16:24
*** moshele has joined #openstack-cinder16:30
*** imacdonn has quit IRC16:38
*** imacdonn has joined #openstack-cinder16:39
*** woojay has joined #openstack-cinder16:40
*** dklyle has quit IRC16:43
*** moshele has quit IRC16:45
*** zhaochao has quit IRC16:56
*** gkadam has quit IRC17:01
*** gnufied has quit IRC17:04
*** e0ne has joined #openstack-cinder17:11
eharneyhas anyone looked at https://bugs.launchpad.net/cinder/+bug/1783467 , possibly more API changes related to validation?17:16
openstackLaunchpad bug 1783467 in Cinder "fail to create volume type encryption" [Undecided,New]17:16
eharneyjungleboyj: seems like something good to understand for RC ^17:18
jungleboyjeharney:  I hadn't seen that one.17:19
*** gnufied has joined #openstack-cinder17:19
*** dklyle has joined #openstack-cinder17:21
*** abishop has quit IRC17:22
luizbagsmcginnis, could you take a look at this patch: https://review.openstack.org/#/c/589539/ ?17:23
jungleboyjsmcginnis:  ^^^ Thoughts on the bug from eharney ?17:23
*** abishop has joined #openstack-cinder17:26
jungleboyjeharney:  Just looking at the mailing list Sean is already looking into this.17:27
jungleboyjI wondered if it was related to the bug he mentioned during the weekly meeting.17:27
jungleboyjhttps://bugs.launchpad.net/cinder/+bug/178605417:28
openstackLaunchpad bug 1786054 in Cinder "Volume create schema validation not allowing extra params prior to enforcing microversion" [Undecided,In progress] - Assigned to Sean McGinnis (sean-mcginnis)17:28
eharneyok17:30
jungleboyjeharney:  So, he is looking into it but having trouble recreating.17:31
*** moshele has joined #openstack-cinder17:40
*** moshele has quit IRC17:44
*** gkadam has joined #openstack-cinder17:46
*** pocketprotector has quit IRC17:50
*** pocketprotector has joined #openstack-cinder17:53
*** dklyle has quit IRC17:57
*** e0ne has quit IRC18:03
*** dklyle has joined #openstack-cinder18:09
*** moshele has joined #openstack-cinder18:20
*** e0ne has joined #openstack-cinder18:20
*** moshele has quit IRC18:21
*** abishop has quit IRC18:23
*** itlinux has joined #openstack-cinder18:25
*** abishop has joined #openstack-cinder18:26
*** ircuser-1 has quit IRC18:30
*** dklyle has quit IRC18:31
*** dklyle has joined #openstack-cinder18:34
*** sapd has quit IRC18:49
*** dklyle has quit IRC18:59
smcginnisjungleboyj, eharney: Not sure if that is related or not. I was testing volume creation, but when responding with my last reply I realized I glossed over that they mentioned encryption.19:00
*** cmart has quit IRC19:00
smcginniseharney: I usually look in your direction whenever encryption comes up. Did you look into that at all?19:00
eharneysmcginnis: it looks like the new validation code rejects extraneous parameters that were previously allowed19:01
smcginniseharney: It should only with 3.53. I did not see if we were missing something there for encryption.19:02
smcginniseharney: Is there something that needs to be added here for encryption? https://github.com/openstack/cinder/blob/master/cinder/api/schemas/volumes.py#L2519:02
eharneysmcginnis: it's not about needing to add fields, it's that we used to allow extra unused fields (which horizon sent) and now we reject those as bad requests19:05
smcginniseharney: Only with microversion 3.53 and later.19:05
eharneysmcginnis: the bug claims it happens on 3.0 too19:06
eharney(i haven't tried this myself)19:06
smcginnisI know. Which is why it's odd and I'm confused by my test results. I don't see that.19:06
smcginnisI looked at volume creation though, and this is referring to volume type creation.19:09
* smcginnis pulls up schema19:09
smcginnisOK - https://github.com/openstack/cinder/blob/master/cinder/api/schemas/volume_type_encryption.py#L4219:10
*** e0ne has quit IRC19:11
eharneyah, that might do it19:12
smcginnisI can get that fixed. Should just take a few minutes.19:13
jungleboyjsmcginnis:  Good catch.19:14
smcginnisI got thrown off by the email refering to the wrong patch.19:14
*** cmart has joined #openstack-cinder19:15
eharneythere are a lot of APIs with additionalProperties set to false... what are the odds of there being a handful of other issues like this after introducing validation?19:15
smcginnisI'll scan through the ones tied to 3.53. Looks like this one (volume type encryption) missed adding microversion checks on that.19:16
eharneyah, i see, it's version-dependent in a lot of them  (i haven't looked at the validation code a lot)19:16
smcginnisApparently we need to look a little closer if there are more coming.19:17
*** gkadam has quit IRC19:18
*** e0ne has joined #openstack-cinder19:19
*** e0ne has quit IRC19:23
smcginnisThat should have moved the API out of contrib into its a standard endpoint too, but I guess it's too late for that.19:25
smcginnisTempted to just revert this one and tackle it in stein to get it done right. Thoughts on that eharney and jungleboyj?19:26
jungleboyjsmcginnis: Revert the validation of volume_encryption ?19:27
smcginnisjungleboyj: Yes. It really wasn't done right.19:28
jungleboyjYeah, I am fine doing that.  It is causing more trouble than it is fixing.19:29
smcginnisI can get things to work now, but it would be a workaround. I'd rather not slam something through now with compromises and take a little more time in stein to do it properly.19:29
smcginnisSince this is ending up a multiple cycle effort anyway.19:29
jungleboyjsmcginnis: ++19:30
smcginnisHmm, actually... I think I will leave this but update the schema validation to allow the parameters. Then we can follow up later if/when we want to lock down extra parameters. At least that way there's _some_ validation happening.19:32
jungleboyjsmcginnis:  That works too.  Is it just changing that line to allow extra parameters?19:33
smcginnisYeah, pretty much. A much smaller (hopefully less risk) change to be making at this point.19:33
jungleboyjAgreed.19:33
jungleboyjI can propose the RC later after that has gone through.  I am still waiting for the matrix support to merge anyway.19:34
openstackgerritSean McGinnis proposed openstack/cinder master: Allow extra parameters in volume_type_encryption  https://review.openstack.org/59001419:37
jungleboyjsmcginnis: https://review.openstack.org/58957719:49
smcginnisThat's probably better for the target audience.19:50
jungleboyjsmcginnis:  :-)  Had to sleep on it for a while to get what you meant.19:50
openstackgerritMerged openstack/cinder master: Add sphinx-feature-classification based support matrix  https://review.openstack.org/58075720:00
*** ircuser-1 has joined #openstack-cinder20:05
*** dklyle has joined #openstack-cinder20:05
* jungleboyj does a happy dance20:10
*** itlinux has quit IRC20:12
openstackgerritSean McGinnis proposed openstack/cinder master: Allow extra parameters in volume_type_encryption  https://review.openstack.org/59001420:17
smcginnisjungleboyj: Had to do a small update. ^^20:18
jungleboyjNo problem.20:19
*** cmart has quit IRC20:19
*** cmart has joined #openstack-cinder20:21
*** dpawlik has joined #openstack-cinder20:24
openstackgerritMerged openstack/os-brick stable/queens: FC fix for scanning only connected HBA's  https://review.openstack.org/58953920:35
openstackgerritMatt Riedemann proposed openstack/cinder master: Fix _attachment_reserve to not allow attaching an invalid status volume  https://review.openstack.org/59003720:47
luizbagas the os-brick backport to queens has been merge, how do we get a new 2.3 version with it?20:47
smcginnisluizbag: jungleboyj will need to request a new stable release for os-brick.20:51
jungleboyjsmcginnis:  Will do.20:52
jungleboyjJust call me the release man.20:52
smcginnisjungleboyj: Anything else we need to get in a stable release?20:52
luizbagthanks, jungleboyj20:53
jungleboyjsmcginnis:  Nope, looks like everything is merged there.20:54
jungleboyjluizbag: Welcome.20:54
*** dpawlik has quit IRC20:57
luizbagthen the upper-constraints file for stable/queens will have to be updated as well, right?20:57
*** dklyle has quit IRC20:58
jungleboyjsmcginnis:  Does that happen automatically?21:00
*** dklyle has joined #openstack-cinder21:02
smcginnisYep, with a new library release, when that gets published the bot will propose raising the upper-constraints for the stable requirements.21:06
jungleboyjOk.  That was what I thought.21:06
*** dklyle has quit IRC21:07
*** pcaruana has joined #openstack-cinder21:07
luizbagI didn't know that21:08
*** cmart has quit IRC21:11
*** luizbag has quit IRC21:12
*** abishop has quit IRC21:19
openstackgerritMerged openstack/cinder master: Add policy in code documentation for os-set_bootable API  https://review.openstack.org/58004521:19
*** mriedem has quit IRC21:30
*** mriedem has joined #openstack-cinder21:31
*** randomhack has joined #openstack-cinder21:31
*** imacdonn has quit IRC21:59
*** gnufied has quit IRC22:01
*** pcaruana has quit IRC22:02
*** nicolasbock has quit IRC22:06
*** moshele has joined #openstack-cinder22:06
*** tswanson has joined #openstack-cinder22:07
*** edmondsw has quit IRC22:10
*** imacdonn has joined #openstack-cinder22:12
*** ganso has quit IRC22:17
*** rcernin has joined #openstack-cinder22:19
*** moshele has quit IRC22:25
*** markstur has quit IRC22:33
*** gnufied has joined #openstack-cinder22:37
*** gmann_ has joined #openstack-cinder22:55
*** r-daneel has joined #openstack-cinder22:59
*** stephenfin_ has joined #openstack-cinder23:02
*** evrardjp has quit IRC23:02
*** Tahvok has quit IRC23:02
*** weezhard has quit IRC23:02
*** amrith has quit IRC23:02
*** mtreinish has quit IRC23:02
*** stephenfin has quit IRC23:02
*** Alons1 has quit IRC23:02
*** Gorian has quit IRC23:02
*** dulek has quit IRC23:02
*** lhinds has quit IRC23:02
*** woojay has quit IRC23:02
*** dosaboy has quit IRC23:02
*** gmann has quit IRC23:02
*** gmann_ is now known as gmann23:02
*** Tahvok has joined #openstack-cinder23:03
*** mtreinish has joined #openstack-cinder23:04
*** dustins has quit IRC23:12
*** tpsilva has quit IRC23:18
*** BrinZhang has joined #openstack-cinder23:49
*** rmcall has joined #openstack-cinder23:50
*** BrinZhang has quit IRC23:54
*** BrinZhang has joined #openstack-cinder23:54
*** zhangbailin_ has joined #openstack-cinder23:54
*** moshele has joined #openstack-cinder23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!