Wednesday, 2018-01-03

*** dave-mccowan has joined #openstack-cinder00:05
*** stvnoyes has quit IRC00:09
*** e0ne has quit IRC00:14
*** diablo_rojo has quit IRC00:19
*** wanghao_ has quit IRC00:20
*** wanghao has joined #openstack-cinder00:21
*** mriedem has quit IRC00:29
*** edmondsw has joined #openstack-cinder00:31
*** diablo_rojo has joined #openstack-cinder00:34
*** edmondsw has quit IRC00:36
*** zhaochao has joined #openstack-cinder01:02
*** markvoelker has quit IRC01:08
*** catintheroof has quit IRC01:10
*** catintheroof has joined #openstack-cinder01:11
*** liverpooler has joined #openstack-cinder01:13
*** gkadam has quit IRC01:15
*** catintheroof has quit IRC01:15
*** gkadam has joined #openstack-cinder01:16
*** Apoorva_ has joined #openstack-cinder01:27
*** Apoorva has quit IRC01:30
*** Apoorva_ has quit IRC01:32
*** imran_ansari has joined #openstack-cinder01:33
*** dave-mccowan has quit IRC01:34
*** liverpooler has quit IRC01:42
*** namnh has joined #openstack-cinder01:46
*** tonyb has quit IRC01:47
*** tonyb has joined #openstack-cinder01:49
*** yangyapeng has quit IRC01:51
*** yangyapeng has joined #openstack-cinder01:52
*** dave-mccowan has joined #openstack-cinder01:55
*** gkadam has quit IRC01:56
*** gkadam has joined #openstack-cinder01:59
*** markvoelker has joined #openstack-cinder02:05
*** Brin has joined #openstack-cinder02:10
*** zhaochao has quit IRC02:16
*** dave-mccowan has quit IRC02:18
*** lhx_ has joined #openstack-cinder02:19
*** dave-mccowan has joined #openstack-cinder02:19
*** edmondsw has joined #openstack-cinder02:19
openstackgerritMerged openstack/cinder master: V2/V3 jsonschema validation: snapshots  https://review.openstack.org/52099102:20
*** dalgaaf has quit IRC02:22
*** edmondsw has quit IRC02:24
*** dalgaaf has joined #openstack-cinder02:24
*** gouthamr has quit IRC02:27
*** zhaochao has joined #openstack-cinder02:28
*** imran_ansari has quit IRC02:30
jungleboyjSwanson:  Yes, VMAX needs attention please.02:32
jungleboyjSwanson:  Whas is vacation?02:34
*** diablo_rojo has quit IRC02:36
*** owalsh_ has joined #openstack-cinder02:42
*** owalsh has quit IRC02:45
openstackgerritJeremy Zhang proposed openstack/cinder master: Fix api-ref for v3 volume types  https://review.openstack.org/53083002:55
*** gkadam has quit IRC03:07
*** Apoorva has joined #openstack-cinder03:23
*** Apoorva has quit IRC03:24
*** Apoorva has joined #openstack-cinder03:25
*** masber has quit IRC03:32
*** abhishekk has joined #openstack-cinder03:43
*** gcb has quit IRC03:44
*** nicolasbock has quit IRC03:44
*** lhx__ has joined #openstack-cinder03:47
*** lhx_ has quit IRC03:47
*** _ix_ has quit IRC03:56
*** _ix has joined #openstack-cinder04:03
*** diablo_rojo has joined #openstack-cinder04:07
*** edmondsw has joined #openstack-cinder04:07
*** _ix_ has joined #openstack-cinder04:08
*** _ix has quit IRC04:09
*** edmondsw has quit IRC04:12
*** gmann has joined #openstack-cinder04:19
*** Apoorva has quit IRC04:20
*** masber has joined #openstack-cinder04:21
*** Apoorva has joined #openstack-cinder04:21
openstackgerritFelipe Monteiro proposed openstack/cinder master: Fix reserve volume enforcing the wrong policy action  https://review.openstack.org/53083704:25
*** Apoorva has quit IRC04:25
*** hemna_ has quit IRC04:29
*** Apoorva has joined #openstack-cinder04:30
*** crushil_ has joined #openstack-cinder04:46
*** links has joined #openstack-cinder04:48
*** crushil_ has quit IRC04:51
*** crushil_ has joined #openstack-cinder04:51
*** lhx__ has quit IRC04:52
*** lhx__ has joined #openstack-cinder04:53
*** psachin has joined #openstack-cinder04:55
*** links has quit IRC04:58
*** chhavi has joined #openstack-cinder05:02
*** links has joined #openstack-cinder05:03
*** _ix has joined #openstack-cinder05:04
*** dave-mccowan has quit IRC05:06
*** _ix_ has quit IRC05:06
*** pgadiya has joined #openstack-cinder05:09
*** Apoorva has quit IRC05:14
*** crushil_ has quit IRC05:25
*** hoangcx has quit IRC05:30
*** namnh has quit IRC05:30
*** namnh has joined #openstack-cinder05:31
*** hoangcx has joined #openstack-cinder05:31
*** crushil_ has joined #openstack-cinder05:31
*** crushil_ has quit IRC05:33
*** daidv has quit IRC05:34
*** crushil_ has joined #openstack-cinder05:34
*** daidv has joined #openstack-cinder05:35
*** lkuchlan has joined #openstack-cinder05:42
*** gcb has joined #openstack-cinder05:42
*** markstur has quit IRC05:44
*** armaan has joined #openstack-cinder05:45
*** daidv has quit IRC05:45
*** daidv has joined #openstack-cinder05:46
*** zhurong has joined #openstack-cinder05:47
*** edmondsw has joined #openstack-cinder05:56
*** edmondsw has quit IRC06:00
openstackgerritwanghao proposed openstack/python-cinderclient master: Support for reporting backend state in service list  https://review.openstack.org/53044606:03
*** tasker has quit IRC06:08
*** tasker has joined #openstack-cinder06:09
*** masber has quit IRC06:13
openstackgerritbillsung proposed openstack/cinder master: Re-add Infortrend Cinder volume driver  https://review.openstack.org/52365906:24
*** markvoelker has quit IRC06:28
*** diablo_rojo has quit IRC06:29
*** tasker_tel has joined #openstack-cinder06:29
*** armax has quit IRC06:30
*** armax has joined #openstack-cinder06:30
*** armax has joined #openstack-cinder06:32
*** armax has quit IRC06:32
*** crushil_ has quit IRC06:32
*** tasker_tel has left #openstack-cinder06:32
*** armax has joined #openstack-cinder06:33
*** armax has quit IRC06:34
openstackgerritMerged openstack/cinder master: Discrepancy in api-ref and code for create group type API  https://review.openstack.org/52449206:36
*** moshele has joined #openstack-cinder06:43
*** pcaruana has joined #openstack-cinder07:09
*** david-lyle has quit IRC07:12
*** david-lyle has joined #openstack-cinder07:12
*** rcernin has quit IRC07:25
*** edmondsw has joined #openstack-cinder07:44
*** edmondsw has quit IRC07:48
*** lkuchlan has quit IRC07:51
*** lkuchlan has joined #openstack-cinder07:52
*** e0ne has joined #openstack-cinder07:57
*** armaan has quit IRC08:04
*** armaan has joined #openstack-cinder08:05
openstackgerrityixuan zhang proposed openstack/cinder master: Storwize: add hyperswap volume support  https://review.openstack.org/49241408:05
*** tesseract has joined #openstack-cinder08:05
*** chandankumar has joined #openstack-cinder08:07
openstackgerritJeremy Zhang proposed openstack/cinder master: RBD: get manageable volumes  https://review.openstack.org/52790308:09
*** medy has joined #openstack-cinder08:15
*** medy has quit IRC08:16
*** medy has joined #openstack-cinder08:16
*** medy has quit IRC08:18
*** medy has joined #openstack-cinder08:18
*** medy has quit IRC08:19
*** medy has joined #openstack-cinder08:19
*** medy has quit IRC08:21
*** medy has joined #openstack-cinder08:21
*** medy has quit IRC08:22
*** medy has joined #openstack-cinder08:22
*** e0ne has quit IRC08:23
*** medy has quit IRC08:24
*** medy has joined #openstack-cinder08:24
*** medy has quit IRC08:25
*** medy has joined #openstack-cinder08:25
*** medy has quit IRC08:27
*** medy has joined #openstack-cinder08:27
*** medy has quit IRC08:28
*** medy has joined #openstack-cinder08:28
*** markvoelker has joined #openstack-cinder08:29
*** medy has quit IRC08:29
*** gmann has quit IRC08:33
*** moshele has quit IRC08:35
*** moshele has joined #openstack-cinder08:37
chhaviBrin: Need some clarification on the review comments : https://review.openstack.org/#/c/518316/08:44
chhaviBrin: can you please elaborate.08:45
chhaviBrin: do you foresee any issues making this change,08:45
*** armaan has quit IRC08:48
*** armaan has joined #openstack-cinder08:48
*** moshele has quit IRC08:50
*** moshele has joined #openstack-cinder08:50
*** arnewiebalck_ has joined #openstack-cinder08:54
openstackgerritTommyLike proposed openstack/cinder-specs master: Support restore backup to volumes simultaneously  https://review.openstack.org/52444108:58
*** gmann has joined #openstack-cinder08:59
*** markvoelker has quit IRC09:03
*** erlon has joined #openstack-cinder09:20
*** e0ne has joined #openstack-cinder09:21
openstackgerritmelissaml proposed openstack/os-brick master: Cleanup test-requirements  https://review.openstack.org/53087809:26
*** edmondsw has joined #openstack-cinder09:32
*** wanghao has quit IRC09:33
*** wanghao has joined #openstack-cinder09:33
*** wanghao has quit IRC09:34
*** wanghao has joined #openstack-cinder09:34
*** wanghao has quit IRC09:35
*** wanghao has joined #openstack-cinder09:35
*** Brin has quit IRC09:35
*** wanghao has quit IRC09:35
*** wanghao has joined #openstack-cinder09:36
openstackgerritXiaojun Liao proposed openstack/cinder master: Fix v3 api-ref for showing API details url error  https://review.openstack.org/52249209:36
*** wanghao has quit IRC09:36
*** wanghao has joined #openstack-cinder09:36
*** edmondsw has quit IRC09:37
*** wanghao has quit IRC09:37
*** wanghao has joined #openstack-cinder09:37
*** wanghao has quit IRC09:38
*** wanghao has joined #openstack-cinder09:38
*** erlon has quit IRC09:38
*** wanghao has quit IRC09:39
*** wanghao has joined #openstack-cinder09:39
*** wanghao has quit IRC09:39
*** wanghao has joined #openstack-cinder09:40
*** wanghao has quit IRC09:40
*** erlon has joined #openstack-cinder09:41
*** wanghao has joined #openstack-cinder09:41
*** markvoelker has joined #openstack-cinder10:01
*** mvk has quit IRC10:06
*** mvk has joined #openstack-cinder10:07
*** pcaruana has quit IRC10:09
*** pcaruana has joined #openstack-cinder10:10
*** namnh has quit IRC10:11
*** armaan has quit IRC10:12
*** armaan has joined #openstack-cinder10:13
*** owalsh has joined #openstack-cinder10:21
*** owalsh_ has quit IRC10:22
*** Trident has joined #openstack-cinder10:24
*** armaan has quit IRC10:29
*** armaan has joined #openstack-cinder10:30
*** markvoelker has quit IRC10:34
*** armaan has quit IRC10:43
*** armaan has joined #openstack-cinder10:44
*** abhishekk has quit IRC10:49
*** moshele has quit IRC11:01
*** moshele has joined #openstack-cinder11:01
*** zhurong has quit IRC11:06
*** edmondsw has joined #openstack-cinder11:20
*** mvk has quit IRC11:23
*** edmondsw has quit IRC11:24
*** markvoelker has joined #openstack-cinder11:31
*** moshele has quit IRC11:32
*** moshele has joined #openstack-cinder11:35
*** nicolasbock has joined #openstack-cinder11:36
*** edmondsw has joined #openstack-cinder11:36
*** moshele has quit IRC11:40
*** chhavi has quit IRC11:40
*** arnewiebalck_ has quit IRC11:48
*** armaan has quit IRC11:54
*** armaan has joined #openstack-cinder11:54
*** mvk has joined #openstack-cinder11:59
*** markvoelker has quit IRC12:05
*** yikun has quit IRC12:05
*** yikun has joined #openstack-cinder12:06
*** yikun has quit IRC12:09
*** gcb has quit IRC12:09
*** gcb has joined #openstack-cinder12:12
*** edmondsw has quit IRC12:15
*** gcb has quit IRC12:28
*** gcb has joined #openstack-cinder12:31
*** laurent\ has quit IRC12:40
openstackgerritLucian Petrut proposed openstack/cinder master: Windows: allow multiple c-vol backends per service  https://review.openstack.org/52280612:44
*** yangyapeng has quit IRC12:45
*** yangyapeng has joined #openstack-cinder12:46
*** laurent\ has joined #openstack-cinder12:47
*** sdague has joined #openstack-cinder12:49
*** Jack_Iv has joined #openstack-cinder12:50
*** yangyapeng has quit IRC12:50
*** chenying has joined #openstack-cinder12:51
*** moshele has joined #openstack-cinder12:52
*** lkuchlan has quit IRC12:55
*** laurent\ has quit IRC12:55
*** lkuchlan has joined #openstack-cinder12:56
*** catintheroof has joined #openstack-cinder12:58
*** catintheroof has quit IRC12:59
*** catintheroof has joined #openstack-cinder12:59
*** lkuchlan has quit IRC13:00
*** laurent\ has joined #openstack-cinder13:01
*** markvoelker has joined #openstack-cinder13:02
*** lhx__ has quit IRC13:04
*** arnewiebalck_ has joined #openstack-cinder13:05
*** pgadiya has quit IRC13:05
*** abishop has joined #openstack-cinder13:09
*** yangyapeng has joined #openstack-cinder13:12
*** armaan has quit IRC13:13
*** armaan has joined #openstack-cinder13:13
*** edmondsw has joined #openstack-cinder13:13
*** pgadiya has joined #openstack-cinder13:15
*** yangyapeng has quit IRC13:17
*** Jack_Iv has quit IRC13:18
*** edmondsw has quit IRC13:18
*** Jack_Iv has joined #openstack-cinder13:19
*** markvoelker has quit IRC13:19
*** markvoelker has joined #openstack-cinder13:20
*** yangyapeng has joined #openstack-cinder13:20
*** psachin has quit IRC13:29
*** psachin has joined #openstack-cinder13:39
*** psachin has quit IRC13:43
*** dave-mccowan has joined #openstack-cinder13:49
*** mriedem has joined #openstack-cinder13:52
*** links has quit IRC13:57
*** sdake has quit IRC14:12
*** sdake has joined #openstack-cinder14:13
*** sdake has quit IRC14:13
*** sdake has joined #openstack-cinder14:13
*** wanghao has quit IRC14:16
*** mriedem has quit IRC14:17
*** pgadiya has quit IRC14:25
*** wanghao has joined #openstack-cinder14:29
*** edmondsw has joined #openstack-cinder14:37
*** mriedem has joined #openstack-cinder14:41
*** _ix has quit IRC14:45
*** eharney has joined #openstack-cinder14:59
*** wanghao_ has joined #openstack-cinder15:01
*** wanghao has quit IRC15:02
*** liverpooler has joined #openstack-cinder15:05
*** lkuchlan has joined #openstack-cinder15:06
*** Apoorva has joined #openstack-cinder15:06
*** armax has joined #openstack-cinder15:19
*** armax has quit IRC15:23
*** mchlumsky has quit IRC15:23
*** mchlumsky has joined #openstack-cinder15:25
*** links has joined #openstack-cinder15:25
*** cz2 has joined #openstack-cinder15:25
*** chhavi has joined #openstack-cinder15:29
*** lhx_ has joined #openstack-cinder15:29
*** links has quit IRC15:30
*** moshele has quit IRC15:32
*** gmann has quit IRC15:43
*** lyarwood has joined #openstack-cinder15:54
*** armaan has quit IRC15:55
*** armaan has joined #openstack-cinder15:55
lyarwoodeharney: https://bugs.launchpad.net/cinder/+bug/1739442 - we spoke about this before the break, any thoughts? Trying to work out where we can actually do this if not in c-vol.15:57
openstackLaunchpad bug 1739442 in Cinder "c-vol should always format encrypted volumes during creation" [Undecided,New]15:57
*** armax has joined #openstack-cinder15:57
*** arnewiebalck_ has quit IRC15:58
*** imacdonn has quit IRC15:58
*** imacdonn has joined #openstack-cinder15:58
*** lkuchlan has quit IRC16:00
*** lkuchlan has joined #openstack-cinder16:01
*** bswartz has joined #openstack-cinder16:03
*** markstur has joined #openstack-cinder16:03
*** markstur has quit IRC16:03
*** markstur has joined #openstack-cinder16:03
*** zhaochao has quit IRC16:04
*** _ix has joined #openstack-cinder16:05
*** dims has quit IRC16:09
jungleboyjReminder for anyone who didn't see the mailing list note.  No meeting this week.  We will meet again next week.16:09
*** dims has joined #openstack-cinder16:10
*** Jack_Iv has quit IRC16:18
*** openstackgerrit has quit IRC16:19
*** dave-mccowan has quit IRC16:24
*** gouthamr has joined #openstack-cinder16:24
*** mvk has quit IRC16:24
*** lpetrut has joined #openstack-cinder16:24
*** dave-mccowan has joined #openstack-cinder16:26
*** lkuchlan has quit IRC16:31
ericyoungI've been out a few weeks... any updates on where cinder/nova stand with multi-attach and what drivers need to do?16:34
*** pcaruana has quit IRC16:35
*** mvk has joined #openstack-cinder16:37
SwansonOh, is there some expectation that'll land this release and that there might be changes for drivers?16:40
*** hemna_ has joined #openstack-cinder16:40
SwansonNeed to devote more cycles...16:40
ericyoungswanson: I don't know if it will land but I heard driver work is 'minimal'. I'm looking for verification as we have customers asking16:41
Swansonericyoung, I see. We don't have a ton of time before beta 3, right?16:42
*** moshele has joined #openstack-cinder16:42
ericyoungSwanson. correct. hence my question so I can plan :)16:42
*** mvk has quit IRC16:43
*** niraj_singh has quit IRC16:46
*** stvnoyes has joined #openstack-cinder16:47
*** niraj_singh has joined #openstack-cinder16:50
jungleboyjericyoung:  The spec has merged and ildikov has started working on implementing based on the spec.16:53
jungleboyjericyoung:  We are still hopeful that it will land in Queens.  The driver impact is minimal.16:53
ericyoungjungleboyj, thanks. will check the spec for specifics and keep fingers crossed16:53
jungleboyjI think it is still just a matter of updating a flag to say if your driver supports multiattach.16:53
ildikovericyoung: so I'm looking into what I need to do16:53
jungleboyjericyoung:  :-)  Sounds good.16:54
*** moshele has quit IRC16:54
ericyoungildikov, is it something like.. 'and then a miracle occurred'?16:55
ildikovericyoung: the target is Queens, we have weekly meetings and myself completely freaked out, I'm not fully knowledgable on the driver part, but it's something like whether or not it can handle it on the first place, reporting on shared targets if the driver does share them and turn on the capability if everything looks fine16:55
*** catintheroof has quit IRC16:55
jgriffithildikov: jungleboyj ericyoung I am planning on trying to get something started and posted later this week16:55
*** mvk has joined #openstack-cinder16:55
jgriffiththe needed changes should be fairly minimal16:56
jgriffithdriver requirements as per the spec will be a new capabilities setting being added16:56
jgriffithI can't speak to the Nova side however16:56
jungleboyjjgriffith:  Awesome!  Going to tackle it after a restful break?  :-)16:56
ericyoungexcellent. I'll keep watching ad be ready to jump in (review code, change the ScaleIO driver, whatever).16:57
jgriffithjungleboyj: "restful" is a relative term :)16:57
jgriffithhttps://photos.app.goo.gl/jYUqiXzwoPV232Gr216:57
jgriffith:)16:57
ildikovjgriffith: I'm handling that part, I might need to bump the compute version once more, but should be fine, fingers crossed16:57
ildikovjgriffith: and I'm hoping the ceiling will not land on my head after saying 'it should be fine'... :)16:58
jungleboyjjgriffith:  That is a beautiful photo.16:59
jgriffithjungleboyj: it's a beautiful place :)16:59
jungleboyjjgriffith:  Looks relaxing to me.17:00
jgriffithhardest part about visiting MT for me is leaving :)17:00
*** lhx_ has quit IRC17:00
*** Apoorva has quit IRC17:01
jungleboyjjgriffith:  That is how I feel when having to leave Florida.17:02
jgriffithjungleboyj: nice17:03
*** chhavi has quit IRC17:05
*** felipemonteiro has joined #openstack-cinder17:06
*** kaisers has quit IRC17:10
*** e0ne has quit IRC17:12
*** kaisers has joined #openstack-cinder17:15
*** moshele has joined #openstack-cinder17:23
*** slunkad has quit IRC17:32
*** Jack_Iv has joined #openstack-cinder17:32
*** tesseract has quit IRC17:38
*** mvk has quit IRC17:43
edmondswniraj_singh why does send_service_user_token default to False? I hope you're planning on switching that to True... ?17:47
edmondswI'm not even sure we really need a CONF option for that... why not just always use service tokens, period?17:48
edmondswoh, I see the code isn't checking to see if the new CONF group has anything in it17:54
edmondswso you need it for backward compat unless you start checking that17:55
*** Apoorva has joined #openstack-cinder17:55
*** Apoorva has quit IRC17:56
*** lpetrut has quit IRC17:57
*** Apoorva has joined #openstack-cinder18:00
*** Apoorva has quit IRC18:02
*** Apoorva_ has joined #openstack-cinder18:02
*** Jack_Iv has quit IRC18:03
*** openstackgerrit has joined #openstack-cinder18:05
openstackgerritHagen Finley proposed openstack/cinder master: Test document change to cinder install index.rst file to test my ability to upload files for review in Gerrit.  https://review.openstack.org/53098618:05
openstackgerritHagen Finley proposed openstack/cinder master: 2nd Attempt to push revised install documentation to gerrit  https://review.openstack.org/53098718:05
*** armaan has quit IRC18:06
openstackgerritMerged openstack/python-cinderclient master: Deprecate multiattach flag on volume create  https://review.openstack.org/52937518:07
openstackgerritMerged openstack/os-brick master: Cleanup test-requirements  https://review.openstack.org/53087818:12
*** armaan has joined #openstack-cinder18:13
*** Elidx10 has joined #openstack-cinder18:13
*** ChanServ sets mode: +r 18:19
openstackgerritHagen Finley proposed openstack/cinder master: mend  https://review.openstack.org/53099018:23
*** e0ne has joined #openstack-cinder18:27
*** felipemonteiro has quit IRC18:44
*** pchavva has joined #openstack-cinder18:59
*** armax has quit IRC19:14
*** wanghao_ has quit IRC19:39
*** yangyapeng has quit IRC19:44
openstackgerritMatt Riedemann proposed openstack/cinder master: Enable multiattach capability for lvm driver  https://review.openstack.org/53099619:45
*** pcaruana has joined #openstack-cinder19:45
openstackgerritVipin Balachandran proposed openstack/cinder master: VMware: Support volume adapter type change  https://review.openstack.org/53099819:48
openstackgerritMerged openstack/os-brick master: Recover node.startup values after discovering  https://review.openstack.org/46614619:50
mriedemedmondsw: that's likely copied from nova, and it defaults to False because it was originally considered experimental when it was added19:50
mriedemand yeah, you have to opt into it by configuring a new service user19:51
*** dave-mccowan has quit IRC19:56
*** pcaruana has quit IRC19:59
*** e0ne has quit IRC20:09
mriedemildikov: https://bugs.launchpad.net/cinder/+bug/174111220:15
openstackLaunchpad bug 1741112 in Cinder "500 response received when trying to create volume attachment when volume is in-use" [Undecided,New]20:15
ildikovmriedem: Tnx!20:17
edmondswmriedem yeah. Not what I would have done, but not so bad when I think about it, since you have to go in and add all the auth properties anyway20:25
mriedemare there any fake volume drivers that would allow using the api in the functional tests to create a volume and create attachments without actually needing a real volume backend?20:28
mriedemunit tests don't really cut it for testing the entire wsgi stack20:28
patrickeastmriedem: this thing might be close https://github.com/openstack/cinder/blob/master/cinder/tests/fake_driver.py#L2920:32
patrickeastiirc we do top down wsgi tests from c-api through to driver with that20:32
mriedemyeah maybe, i saw the FakeGateDriver20:32
patrickeasti think the gate driver is closer to a "real" backend, inheriting from lvm iscsi20:34
patrickeasterr nvm20:34
patrickeastso is the logging one20:34
mriedemildikov: now i'm asking myself why we added that explicit check on the nova side for attaching the same volume to the same instance20:40
mriedemoh i see https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L204220:43
mriedemthe volume api explicitly checks if we're attaching more than once to the same instance20:43
mriedemfor live migrate20:43
mriedemoh duh, i see the issue20:45
mriedemhttps://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L204220:45
mriedemha20:45
mriedemoops20:45
mriedemraise webob.exc.HTTPInternalServerError(explanation=err_msg)20:45
ildikovyeah, these checks got a little messy...20:51
openstackgerritMatt Riedemann proposed openstack/cinder master: Handle InvalidVolume when creating a volume attachment  https://review.openstack.org/53101120:53
mriedem^20:53
*** ociuhandu has joined #openstack-cinder20:55
*** eharney has quit IRC20:55
*** ociuhandu has quit IRC20:56
*** armax has joined #openstack-cinder20:59
*** hemna_ has quit IRC21:02
mriedemildikov: patched my devstack with that and now i get a 400 from nova when trying to attach the volume to a 2nd instance21:04
mriedemso yay21:04
ildikov\o/ :)21:05
*** Apoorva_ has quit IRC21:16
*** pchavva has quit IRC21:21
openstackgerritMerged openstack/cinder master: Fix reserve volume enforcing the wrong policy action  https://review.openstack.org/53083721:22
openstackgerritMerged openstack/cinder master: Add descriptions of base policies  https://review.openstack.org/53079721:22
*** edmondsw has quit IRC21:22
openstackgerritMerged openstack/cinder master: Add driver-requirements entry for storpool  https://review.openstack.org/53075121:29
*** gouthamr has quit IRC21:42
*** e0ne has joined #openstack-cinder21:43
openstackgerritVipin Balachandran proposed openstack/cinder master: VMware: Support volume adapter type change  https://review.openstack.org/53099821:43
mriedemildikov: debugging the multiattach test, there appears to be a bug on i think the cinder side when creating the 2nd attachment; it never shows up as a registered attachment for the volume21:57
mriedemmaybe nova's not calling attachment_update on it...21:57
mriedem2nd attachment to the 2nd server i should say21:57
ildikovYou mean with a multi-attach volume it gets attached only once?21:59
*** e0ne has quit IRC21:59
mriedemyeah create a multiattach volume, attach it to server1, the volume goes in-use as expected,21:59
mriedemattach the volume to server2 and the volume goes from in-use->reserved->attaching->in-use, but the 2nd attachment doesn't show up in the volume's attachments list in the GET /volumes/{id}/detail response22:00
mriedemand when the test tears down and tries to detach from server2, nova returns a 400 because the volume isn't actually attached22:00
ildikovI know that Cinder needs updates on how the attachments get displayed22:02
*** e0ne has joined #openstack-cinder22:02
ildikovI guess it includes the volume details too, I've never checked that one explicitly TBH22:02
mriedemi'm assuming either nova isn't calling attachment_update on the 2nd server / attachment, or it is and cinder is ignoring it22:03
ildikovif the volume goes through those state changes then the calls should happen22:04
*** eharney has joined #openstack-cinder22:04
mriedemthis is where the attach starts for the 2nd server http://logs.openstack.org/33/266633/4/check/tempest-full/1c4979f/job-output.txt.gz#_2018-01-03_20_56_26_60292722:04
*** rcernin has joined #openstack-cinder22:05
mriedemthe attachment is created in n-api here22:05
mriedemJan 03 20:42:28.525284 ubuntu-xenial-citycloud-sto2-0001671881 devstack@n-api.service[2197]: DEBUG cinderclient.v3.client [None req-3a39b6a5-517e-46a1-ad52-bff9b89080ab tempest-AttachVolumeMultiAttachTest-640168740 tempest-AttachVolumeMultiAttachTest-640168740] REQ: curl -g -i --cacert "/opt/stack/data/ca-bundle.pem" -X POST https://10.0.1.154/volume/v3/09a2df8b29f847f1a844be562fc917a1/attachments -H "X-Service-Token: {SHA122:05
mriedem1ef9ca173dbb52d2a33caafcdcf0bf326dde0" -H "Accept: application/json" -H "User-Agent: python-cinderclient" -H "OpenStack-API-Version: volume 3.44" -H "X-Auth-Token: {SHA1}e052150045e8c201aa1757408757c98ce1bfbdcf" -H "Content-Type: application/json" -H "X-OpenStack-Request-ID: req-3a39b6a5-517e-46a1-ad52-bff9b89080ab" -d '{"attachment": {"instance_uuid": "719979d8-9fe5-4854-9bf8-d6ce96fb7295", "connector": null, "volume_uuid"22:05
mriedem8fc8c1d-b39d-4365-b370-a068c5d99d81"}}' {{(pid=2199) _http_log_request /usr/local/lib/python2.7/dist-packages/keystoneauth1/session.py:372}}22:05
mriedemRESP BODY: {"attachment": {"status": "reserved", "detached_at": "", "connection_info": {}, "attached_at": "", "attach_mode": null, "instance": "719979d8-9fe5-4854-9bf8-d6ce96fb7295", "volume_id": "68fc8c1d-b39d-4365-b370-a068c5d99d81", "id": "dd5101f2-ef06-4284-9c9b-96da2e38be26"}}22:05
mriedemin n-cpu, it looks like the attachment is updated with the host connector22:06
mriedemREQ: curl -g -i --cacert "/opt/stack/data/ca-bundle.pem" -X PUT https://10.0.1.154/volume/v3/09a2df8b29f847f1a844be562fc917a1/attachments/dd5101f2-ef06-4284-9c9b-96da2e38be26 -H "Accept: application/json" -H "User-Agent: python-cinderclient" -H "OpenStack-API-Version: volume 3.44" -H "X-Auth-Token: {SHA1}e052150045e8c201aa1757408757c98ce1bfbdcf" -H "Content-Type: application/json" -H "X-OpenStack-Request-ID: req-3a39b6a5-5122:06
mriedem6a1-ad52-bff9b89080ab" -d '{"attachment": {"connector": {"initiator": "iqn.1993-08.org.debian:01:87ca90688668", "ip": "10.0.1.154", "platform": "x86_64", "host": "ubuntu-xenial-citycloud-sto2-0001671881", "do_local_attach": false, "mountpoint": "/dev/vdb", "os_type": "linux2", "multipath": false}}}' {{(pid=11175) _http_log_request /usr/local/lib/python2.7/dist-packages/keystoneauth1/session.py:372}}22:06
mriedemRESP BODY: {"attachment": {"status": "reserved", "detached_at": "", "connection_info": {"access_mode": "rw", "attachment_id": "dd5101f2-ef06-4284-9c9b-96da2e38be26", "target_discovered": false, "encrypted": false, "driver_volume_type": "iscsi", "qos_specs": null, "target_iqn": "iqn.2010-10.org.openstack:volume-68fc8c1d-b39d-4365-b370-a068c5d99d81", "target_portal": "10.0.1.154:3260", "volume_id": "68fc8c1d-b39d-4365-b370-a022:07
mriedemd99d81", "target_lun": 1, "auth_password": "eiBrJ2K8Qhe7UV4U", "auth_username": "AVsQ8sULVhPS5Louystc", "auth_method": "CHAP"}, "attached_at": "", "attach_mode": null, "instance": "719979d8-9fe5-4854-9bf8-d6ce96fb7295", "volume_id": "68fc8c1d-b39d-4365-b370-a068c5d99d81", "id": "dd5101f2-ef06-4284-9c9b-96da2e38be26"}}22:07
mriedemaha!22:07
mriedemlibvirtError: internal error: unable to execute QEMU command 'device_add': Failed to get "write" lock22:07
mriedemDriver failed to attach volume 68fc8c1d-b39d-4365-b370-a068c5d99d81 at /dev/vdb: libvirtError: internal error: unable to execute QEMU command 'device_add': Failed to get "write" lock22:08
*** e0ne has quit IRC22:08
mriedemi can't link to these n-cpu logs because of how infra has changed where the logs live now, but that's the issue22:08
ildikovhmm, don't recall seeing that one before...22:09
mriedemand when the attach_volume call in the compute fails, nova destroys the bdm record,22:09
mriedemthat's why the detach fails in tempest cleanup22:10
ildikovat least the cleanup works...22:11
mriedemwell, the cleanup won't work until we add attachment counting to tempest,22:11
mriedembut i just haven't hit that failure yet22:11
*** e0ne has joined #openstack-cinder22:12
mriedemso this should be used https://review.openstack.org/#/c/267587/74/nova/virt/libvirt/volume/volume.py22:12
mriedemso yeah i'm not sure what "libvirtError: internal error: unable to execute QEMU command 'device_add': Failed to get "write" lock" means22:12
mriedemfrom the libvirt domain docs22:14
mriedem"             shareable                      If present, this indicates the device is expected to be shared           between domains (assuming the hypervisor and OS support this),           which means that caching should be deactivated for that device.       "22:14
*** e0ne has quit IRC22:14
ildikovdoes the test patch depend on the chain?22:14
mriedemyes22:14
mriedemthis is the devstack patch at the top that enables the multiattach test in tempest: https://review.openstack.org/#/c/266633/22:14
mriedemthis is the tempest test that depends on the nova series https://review.openstack.org/#/c/266605/22:15
ildikovsigh22:16
mriedemi think this is a behavior change in qemu 2.1022:16
mriedembecause it sounds like https://bugs.launchpad.net/nova/+bug/171829522:16
openstackLaunchpad bug 1718295 in OpenStack Compute (nova) "Live migration fails with qemu-img >= 2.10: "Failed to get shared "write" lock\nIs another process using the image?"" [High,Fix released] - Assigned to Sean Dague (sdague)22:16
ildikovyeah, I did a quick search too and it looks like22:17
ildikovas it used to work fine22:17
mriedemmelwitt: any idea off the top of your head where a cache mode is set for disk devices in libvirt guests?22:18
ildikovwe tested multi-attach before and we only had detach problems with lvm22:18
mriedemah there is a driver element22:20
mriedem"The optional cache attribute controls the             cache mechanism, possible values are "default", "none",             "writethrough", "writeback", "directsync" (like             "writethrough", but it bypasses the host page cache) and             "unsafe" (host may cache all disk io, and sync requests from             guest are ignored).                            Since 0.6.0,               "directsync" since 0.9.5,22:20
mriedem        "unsafe" since 0.9.7             "22:20
melwittmriedem: this is where we set it in the driver https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L41622:21
mriedembut we explicitly set it to none for the volume block device22:22
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/volume.py#L5122:23
mriedemok, so looking at https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAttachDeviceFlags22:24
mriedemhttps://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDeviceModifyFlags22:24
mriedemi bet if shareable is True, we need to add the VIR_DOMAIN_DEVICE_MODIFY_FORCE flag22:24
mriedemi'll update the patch to try that out22:26
mriedemhuzzah!22:27
*** e0ne has joined #openstack-cinder22:28
mriedemmelwitt: if you're looking to move a couple things along, the bottom 2 changes in this series should be pretty easy https://review.openstack.org/#/c/529656/22:31
mriedemmostly plumbing working up toward multiattach22:31
melwittmriedem: yup, will look at those. I have to run out for awhile right now but can do when I get back22:32
*** abishop has quit IRC22:38
*** moshele has quit IRC22:48
*** e0ne has quit IRC23:09
*** jdurgin has quit IRC23:14
*** _ix has quit IRC23:16
*** jdurgin has joined #openstack-cinder23:18
openstackgerritMerged openstack/cinder master: Dell EMC SC: API 4.0 incompatibilities  https://review.openstack.org/50726023:19
*** erlon has quit IRC23:40

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!