Friday, 2017-10-27

*** itlinux has joined #openstack-cinder00:10
*** AlexeyAbashkin has joined #openstack-cinder00:10
*** catintheroof has joined #openstack-cinder00:11
openstackgerritMerged openstack/cinder master: Fix scheduler_host_manager limitation  https://review.openstack.org/47977500:12
*** AlexeyAbashkin has quit IRC00:14
*** abhitechie has quit IRC00:16
*** abhitechie has joined #openstack-cinder00:16
openstackgerritMerged openstack/cinder master: Completely remove mox from Cinder unittest  https://review.openstack.org/51464000:19
openstackgerritMerged openstack/cinder master: Remove doc/build before running docs job  https://review.openstack.org/51250700:19
openstackgerritMerged openstack/cinder master: Support count info in List&Detail APIs  https://review.openstack.org/50510100:19
openstackgerritMerged openstack/cinder master: Don't fail when deleting missing backup  https://review.openstack.org/51502600:19
*** abhitechie has quit IRC00:20
*** rcernin has joined #openstack-cinder00:21
*** abhitechie has joined #openstack-cinder00:21
*** gkadam has joined #openstack-cinder00:23
*** gkadam_ has quit IRC00:25
*** abhinavtechie has joined #openstack-cinder00:26
*** abhitechie has quit IRC00:26
*** aagrawal has joined #openstack-cinder00:28
*** aagrawal has quit IRC00:30
openstackgerritMerged openstack/python-cinderclient master: Add .stestr.conf configuration  https://review.openstack.org/50542200:30
*** abhitechie has joined #openstack-cinder00:31
*** abhinavtechie has quit IRC00:31
*** catintheroof has quit IRC00:32
*** chhavi has joined #openstack-cinder00:34
*** chhavi has quit IRC00:38
*** catintheroof has joined #openstack-cinder00:38
*** wanghao has joined #openstack-cinder00:41
*** catintheroof has quit IRC00:42
*** Apoorva_ has joined #openstack-cinder00:43
*** catintheroof has joined #openstack-cinder00:44
openstackgerritMerged openstack/os-brick master: Remove legacy connector constants  https://review.openstack.org/50950200:46
*** AlexeyAbashkin has joined #openstack-cinder00:46
*** Apoorva has quit IRC00:47
*** Apoorva_ has quit IRC00:47
*** gouthamr has joined #openstack-cinder00:49
*** AlexeyAbashkin has quit IRC00:51
*** catintheroof has quit IRC00:55
*** catintheroof has joined #openstack-cinder00:56
*** zzzeek has quit IRC00:58
*** zzzeek has joined #openstack-cinder01:00
*** gkadam has quit IRC01:07
*** mriedem has joined #openstack-cinder01:15
*** mriedem_away has quit IRC01:15
*** catintheroof has quit IRC01:20
*** namnh has joined #openstack-cinder01:21
*** catintheroof has joined #openstack-cinder01:21
*** fanzhang has quit IRC01:24
*** fanzhang_ has joined #openstack-cinder01:24
*** catintheroof has quit IRC01:24
*** dave-mccowan has quit IRC01:26
*** dave-mccowan has joined #openstack-cinder01:28
*** wes_dillingham has quit IRC01:34
*** psachin has joined #openstack-cinder01:35
*** rcernin has quit IRC01:43
*** rcernin has joined #openstack-cinder01:44
*** dhinesh has quit IRC01:44
*** fanzhang_ is now known as fanzhang01:44
*** wes_dillingham has joined #openstack-cinder01:48
openstackgerritzhuangzejian proposed openstack/cinder master: Update setup instructions  https://review.openstack.org/51556401:49
*** catintheroof has joined #openstack-cinder01:55
*** salv-orlando has joined #openstack-cinder01:55
*** salv-orlando has quit IRC02:00
*** catintheroof has quit IRC02:00
*** dalgaaf has quit IRC02:07
*** dalgaaf has joined #openstack-cinder02:08
*** stakeda has joined #openstack-cinder02:09
*** zhaochao has quit IRC02:15
*** zhaochao has joined #openstack-cinder02:16
*** gcb has joined #openstack-cinder02:16
*** thurloat has joined #openstack-cinder02:22
*** catintheroof has joined #openstack-cinder02:28
*** catintheroof has quit IRC02:33
*** lhx__ has joined #openstack-cinder02:34
*** AlexeyAbashkin has joined #openstack-cinder02:47
*** junboli has joined #openstack-cinder02:47
openstackgerritMerged openstack/cinder master: Dell EMC: Update PS and SC CI wiki names  https://review.openstack.org/51515902:49
*** AlexeyAbashkin has quit IRC02:52
openstackgerrityixuan zhang proposed openstack/cinder master: Fix migate_volume API with replication_status ‘not-capable’  https://review.openstack.org/51498802:56
*** armaan has joined #openstack-cinder02:59
*** AlexeyAbashkin has joined #openstack-cinder03:08
*** AlexeyAbashkin has quit IRC03:12
*** dave-mccowan has quit IRC03:14
*** markstur_ has quit IRC03:17
*** thurloat has quit IRC03:21
*** markstur has joined #openstack-cinder03:21
openstackgerritTommyLike proposed openstack/cinder master: Fix earlier backup records can't be restored  https://review.openstack.org/51557703:28
*** abhitechie has quit IRC03:29
*** nicolasbock has quit IRC03:30
*** markvoelker has quit IRC03:43
openstackgerritMerged openstack/cinder master: FlashSystem: Add CMMVC6045E CLI error for multi-host mapping  https://review.openstack.org/51164503:54
*** salv-orlando has joined #openstack-cinder03:56
*** salv-orlando has quit IRC04:00
*** catintheroof has joined #openstack-cinder04:01
*** psachin has quit IRC04:03
*** catintheroof has quit IRC04:05
*** yangyape_ has joined #openstack-cinder04:09
*** chhavi has joined #openstack-cinder04:11
*** yangyapeng has quit IRC04:11
*** mriedem has quit IRC04:15
*** bhagyashri_s has joined #openstack-cinder04:15
*** pooja-jadhav has joined #openstack-cinder04:15
*** Apoorva has joined #openstack-cinder04:16
*** pooja_jadhav has quit IRC04:17
*** bhagyashris has quit IRC04:17
openstackgerritMerged openstack/cinder master: Dell EMC PS: Fix Duplicate ACL records Issue  https://review.openstack.org/51510704:19
*** gkadam has joined #openstack-cinder04:19
*** psachin has joined #openstack-cinder04:20
*** abhi89 has joined #openstack-cinder04:21
*** bhagyashri_s is now known as bhagyashris04:24
*** abhitechie has joined #openstack-cinder04:31
*** abhinavtechie has joined #openstack-cinder04:32
*** abhitechie has quit IRC04:32
*** logan- has quit IRC04:38
*** logan- has joined #openstack-cinder04:42
*** bhagyashris has quit IRC04:46
*** Apoorva has quit IRC04:46
*** rmk has quit IRC04:50
*** cburgess has quit IRC04:51
*** wes_dillingham has quit IRC05:00
*** cburgess has joined #openstack-cinder05:03
*** rmk has joined #openstack-cinder05:05
*** rmk has quit IRC05:05
*** rmk has joined #openstack-cinder05:05
*** markstur has quit IRC05:10
openstackgerritMerged openstack/cinder master: Make service object UUID not nullable  https://review.openstack.org/51485305:11
*** psachin has quit IRC05:14
*** masuberu has joined #openstack-cinder05:15
*** psachin has joined #openstack-cinder05:15
*** lpetrut has joined #openstack-cinder05:16
*** masber has quit IRC05:18
*** masber has joined #openstack-cinder05:20
*** masuberu has quit IRC05:23
*** markstur has joined #openstack-cinder05:24
*** salv-orlando has joined #openstack-cinder05:25
*** newmember has joined #openstack-cinder05:31
*** wanghao_ has joined #openstack-cinder05:33
*** junboli has quit IRC05:34
*** wanghao has quit IRC05:35
*** salv-orlando has quit IRC05:38
*** salv-orlando has joined #openstack-cinder05:38
*** markvoelker has joined #openstack-cinder05:43
*** junboli has joined #openstack-cinder05:55
openstackgerritTommyLike proposed openstack/cinder master: Fix earlier backup records can't be restored  https://review.openstack.org/51557706:00
*** ntpttr_laptop___ has joined #openstack-cinder06:01
*** ntpttr_laptop__ has quit IRC06:01
*** zengyingzhe has joined #openstack-cinder06:03
*** ntpttr_laptop___ has quit IRC06:05
*** lpetrut has quit IRC06:17
*** markvoelker has quit IRC06:18
*** gouthamr has quit IRC06:21
*** spectr has joined #openstack-cinder06:22
*** bhagyashris has joined #openstack-cinder06:26
*** markstur has quit IRC06:27
*** lpetrut has joined #openstack-cinder06:27
*** lpetrut has quit IRC06:33
*** lpetrut has joined #openstack-cinder06:34
*** lpetrut has quit IRC06:44
*** pgadiya has joined #openstack-cinder06:48
*** armaan has quit IRC07:04
*** armaan has joined #openstack-cinder07:05
*** markvoelker has joined #openstack-cinder07:14
*** armaan has quit IRC07:15
*** armaan has joined #openstack-cinder07:15
*** fanzhang has left #openstack-cinder07:16
*** abhinavtechie has quit IRC07:17
*** armax has quit IRC07:21
*** tesseract has joined #openstack-cinder07:22
*** armax has joined #openstack-cinder07:22
*** armax has quit IRC07:22
*** armax has joined #openstack-cinder07:23
*** armax has quit IRC07:23
*** armax has joined #openstack-cinder07:24
*** armax has quit IRC07:24
*** armax has joined #openstack-cinder07:24
*** armax has joined #openstack-cinder07:25
*** armax has quit IRC07:25
*** armax has joined #openstack-cinder07:26
*** armax has quit IRC07:26
*** armax has joined #openstack-cinder07:27
*** armax has quit IRC07:27
*** salv-orlando has quit IRC07:30
*** salv-orlando has joined #openstack-cinder07:31
*** abhitechie has joined #openstack-cinder07:33
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Add async replication support  https://review.openstack.org/50922207:34
*** namnh has quit IRC07:34
*** salv-orlando has quit IRC07:35
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Enable CHAP authentication for vmax backend  https://review.openstack.org/51061407:36
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Cannot extend volumes in a replication relationship  https://review.openstack.org/51181207:38
*** abhishek has joined #openstack-cinder07:39
*** josecastroleon has joined #openstack-cinder07:41
*** abhi89 has quit IRC07:41
*** itlinux has quit IRC07:43
*** e0ne has joined #openstack-cinder07:45
*** markvoelker has quit IRC07:48
*** amoralej|off is now known as amoralej07:51
*** salv-orlando has joined #openstack-cinder07:52
*** yikun has joined #openstack-cinder07:55
*** AlexeyAbashkin has joined #openstack-cinder07:56
*** rcernin has quit IRC07:58
*** gcb has quit IRC08:00
openstackgerrityixuan zhang proposed openstack/cinder master: Storwize: add backup snapshots support  https://review.openstack.org/51256208:03
openstackgerritzhuangzejian proposed openstack/cinder master: Update setup instructions  https://review.openstack.org/51556408:03
*** gcb has joined #openstack-cinder08:03
*** armaan has quit IRC08:18
*** armaan has joined #openstack-cinder08:19
*** junboli has quit IRC08:22
openstackgerritAlexandru Muresan proposed openstack/cinder master: SMBFS: add fixed image support  https://review.openstack.org/51465908:38
*** markvoelker has joined #openstack-cinder08:45
*** ntpttr_ has joined #openstack-cinder08:50
*** namnh has joined #openstack-cinder08:51
*** ntpttr has quit IRC08:52
*** sdague has joined #openstack-cinder08:54
openstackgerritDinesh Bhor proposed openstack/cinder master: V3 jsonschema validation: base schema framework  https://review.openstack.org/51564908:56
openstackgerritzhuangzejian proposed openstack/cinder master: Update setup instructions  https://review.openstack.org/51556409:00
openstackgerritJack Lu proposed openstack/os-brick master: Update supported transports for iscsi connector  https://review.openstack.org/51077609:00
*** lpetrut has joined #openstack-cinder09:09
*** markvoelker has quit IRC09:18
johnthetubaguyildikov: just reading matt's comment in the review, do we have a way forward on that?09:22
ildikovjohnthetubaguy: it depends on what we want to do :)09:22
ildikovjohnthetubaguy: as the behavior is there for live migrate right now09:22
johnthetubaguyso I think we pass the host and mountpoint to cinder?09:23
ildikovwe don't pass the host to reserve currently09:23
johnthetubaguywhat I thought we said for live-migration was same instance, different host, is allowed09:23
johnthetubaguytrue, this would fail on sending the connector09:23
ildikovhost is missing at the moment, we need to tweak that in Cinder09:24
ildikovfor live migrate I think we send the connector for the second attachment with create09:24
ildikovso we do that in one step09:24
johnthetubaguyyeah, makes sense09:24
ildikovso we might be able to leverage that here09:25
ildikovif we want to build on the current behavior09:26
johnthetubaguydid we want to limit the number of attachments to two, I remember we mentioned that at some point?09:26
ildikovI mean the fact that the second attachment_create contains extra information09:26
ildikovI would leave that decision to Cinder09:27
ildikovand I don't remember that we actually would've agreed on this09:27
ildikovnot yet at least09:27
johnthetubaguyyeah, its more my curiosity really09:27
ildikovI think we would like to try to limit the checks we are doing to find the middle ground between trying to be overly protective and complex but still bullet proof enough09:28
ildikovif you're around in the afternoon when the US folks wake up it would be great to talk about this today or Monday afternoon the latest so we can get progress on this part09:29
ildikovas it's still the regular attach part09:29
*** wanghao_ has quit IRC09:29
johnthetubaguyWe can check on the Nova side, its just we were trying to not do that.09:30
ildikovand with the Summit approaching we're losing two weeks...09:30
ildikovI know, I was thinking about this too09:30
ildikovwe need to think about what check might make sense in Nova, but in general they should all happen in Cinder09:30
johnthetubaguyI mean Nova has the same goals on complexity vs robustness, its a hard problem.09:30
johnthetubaguyadding the host check to attach create and update seems like it would give us the protection we need09:31
johnthetubaguy(its not perfect, but it would stop bad things)09:31
ildikovas for attaching the same volume to the same instance multiple times I believe it causes more of administrational problems rather than data corruption09:31
johnthetubaguydepends if you try and mount all those at the same time, and start writing to them09:32
ildikovI mean having multiple attachment records, but physically I would think it's still one connection09:32
*** armaan has quit IRC09:32
*** armaan has joined #openstack-cinder09:32
johnthetubaguyso automatically, we would plug each connection as a different device, I believe09:32
johnthetubaguyalthough I would have to go check09:32
ildikovhmm, ok, if that happens that's not good09:34
johnthetubaguyildikov: a have a nuts idea, for comparison, we could pass in the attachment-id we are replacing when we do the move09:35
ildikovso technically the host check is doable on the Cinder side, we just don't do it yet as we don't have all the info for it necessarily at the time of the first create call09:36
*** abhi89 has joined #openstack-cinder09:36
ildikovhmm, I think that's too much context09:36
johnthetubaguyildikov: probably, its more bait and switch for the host check09:37
ildikovI mean we would like to keep Cinder somewhat decoupled from what the consumer is doing still09:37
*** gcb has quit IRC09:37
johnthetubaguysure, until you need to know09:37
*** stakeda has quit IRC09:38
*** abhishek has quit IRC09:38
openstackgerritVivek Soni proposed openstack/cinder master: HPE 3PAR: Handle single path in FC configuration  https://review.openstack.org/51495209:38
ildikovjohnthetubaguy: yeah, I wish we could just say that we trust the sanity of our users :)09:39
johnthetubaguyheh, dangerous09:40
ildikovI know :)09:40
*** links has quit IRC09:42
*** dpawlik has joined #openstack-cinder09:52
*** danpawlik has quit IRC09:55
*** armaan has quit IRC09:58
*** kaisers1 has quit IRC10:05
*** psachin has quit IRC10:05
*** kaisers has joined #openstack-cinder10:14
*** markvoelker has joined #openstack-cinder10:15
*** armaan has joined #openstack-cinder10:31
*** gkadam has quit IRC10:34
*** namnh has quit IRC10:36
*** armaan has quit IRC10:43
*** gkadam has joined #openstack-cinder10:47
*** abhishek has joined #openstack-cinder10:48
*** abhitechie has quit IRC10:48
*** markvoelker has quit IRC10:49
*** abhi89 has quit IRC10:51
*** robcresswell has quit IRC11:03
openstackgerritVivek Soni proposed openstack/cinder master: HPE 3PAR: Handle single path in FC configuration  https://review.openstack.org/51495211:06
*** markstur has joined #openstack-cinder11:15
*** markstur has quit IRC11:20
*** sdague has quit IRC11:31
*** sdague has joined #openstack-cinder11:32
*** sdague has quit IRC11:37
*** sdague has joined #openstack-cinder11:38
*** sdague has quit IRC11:38
openstackgerritVivek Soni proposed openstack/cinder master: [WIP]HPE 3PAR: Handle single path in FC configuration  https://review.openstack.org/51495211:41
*** nicolasbock has joined #openstack-cinder11:43
*** belmoreira has joined #openstack-cinder11:45
*** sdague has joined #openstack-cinder11:46
*** markvoelker has joined #openstack-cinder11:46
*** abishop has joined #openstack-cinder11:47
openstackgerritVivek Soni proposed openstack/cinder master: [WIP]HPE 3PAR: Handle single path in FC configuration  https://review.openstack.org/51495211:54
*** dillaman has joined #openstack-cinder12:03
*** liverpooler has joined #openstack-cinder12:05
*** pooja_jadhav has joined #openstack-cinder12:07
*** nsingh has joined #openstack-cinder12:08
*** niraj_singh has quit IRC12:09
*** bhagyashris has quit IRC12:10
*** pooja-jadhav has quit IRC12:10
*** wes_dillingham has joined #openstack-cinder12:16
*** markvoelker has quit IRC12:20
*** markvoelker has joined #openstack-cinder12:27
*** pgadiya has quit IRC12:28
*** lhx__ has quit IRC12:30
*** gkadam has quit IRC12:37
*** armaan has joined #openstack-cinder12:37
*** amoralej is now known as amoralej|lunch12:55
*** mdbooth has quit IRC12:58
*** armaan has quit IRC13:02
*** catintheroof has joined #openstack-cinder13:04
*** dustins has joined #openstack-cinder13:05
*** mriedem has joined #openstack-cinder13:18
*** mdbooth has joined #openstack-cinder13:21
*** hemna_ has joined #openstack-cinder13:25
*** dansmith is now known as superdan13:30
*** sheel has joined #openstack-cinder13:32
*** catintheroof has quit IRC13:34
*** catintheroof has joined #openstack-cinder13:42
*** spectr has quit IRC13:49
*** zhaochao has quit IRC13:53
*** dave-mccowan has joined #openstack-cinder13:53
*** pooja-jadhav has joined #openstack-cinder13:54
*** niraj_singh has joined #openstack-cinder13:55
*** pooja_jadhav has quit IRC13:55
*** nsingh has quit IRC13:55
*** amoralej|lunch is now known as amoralej13:56
*** gouthamr has joined #openstack-cinder14:02
*** Dinesh_Bhor has quit IRC14:04
*** mchlumsky has joined #openstack-cinder14:08
*** spectr has joined #openstack-cinder14:09
*** armax has joined #openstack-cinder14:17
*** mchlumsky has quit IRC14:17
*** mchlumsky has joined #openstack-cinder14:18
*** dave-mccowan has quit IRC14:20
*** mchlumsky has quit IRC14:26
*** felipemonteiro_ has joined #openstack-cinder14:26
*** mchlumsky has joined #openstack-cinder14:28
*** felipemonteiro__ has joined #openstack-cinder14:32
*** felipemonteiro_ has quit IRC14:36
*** spectr has quit IRC14:39
*** e0ne has quit IRC14:45
*** josecastroleon has quit IRC14:46
*** armaan has joined #openstack-cinder14:48
*** e0ne has joined #openstack-cinder14:53
*** e0ne has quit IRC14:53
*** e0ne has joined #openstack-cinder14:54
*** e0ne has quit IRC14:54
*** e0ne has joined #openstack-cinder14:55
*** e0ne has quit IRC14:56
*** e0ne has joined #openstack-cinder14:56
*** e0ne has quit IRC14:57
*** markstur has joined #openstack-cinder15:02
*** belmoreira has quit IRC15:09
*** dave-mccowan has joined #openstack-cinder15:11
*** markstur has quit IRC15:11
*** dustins has quit IRC15:13
*** markstur has joined #openstack-cinder15:13
*** AlexeyAbashkin has quit IRC15:13
*** crose has joined #openstack-cinder15:14
*** jmlowe_ has joined #openstack-cinder15:15
*** newmember has quit IRC15:15
*** hemna_ has quit IRC15:15
*** jmlowe has quit IRC15:16
*** links has joined #openstack-cinder15:19
*** dave-mccowan has quit IRC15:21
*** dhinesh has joined #openstack-cinder15:22
*** armax_ has joined #openstack-cinder15:22
*** salv-orlando has quit IRC15:22
*** armax has quit IRC15:22
*** armax_ is now known as armax15:22
*** salv-orlando has joined #openstack-cinder15:23
*** salv-orlando has quit IRC15:27
*** markstur_ has joined #openstack-cinder15:30
*** itlinux has joined #openstack-cinder15:30
*** itlinux has quit IRC15:30
*** markstur has quit IRC15:33
*** ntpttr_laptop has joined #openstack-cinder15:34
*** sheel has quit IRC15:41
rajinirjungleboyj: smcginnis: eharney;: The driverfixes/ocata gate is still broken looks like. https://review.openstack.org/#/c/514364/ Any idea?15:47
jungleboyj:-(  eharney  Any update there?15:48
eharneyrajinir: jungleboyj: patch needs to be rebased -- see the yellow dot on parents, it's based on an outdated patch which didn't have the fix included.15:49
*** markstur has joined #openstack-cinder15:50
*** markstur_ has quit IRC15:53
*** itlinux has joined #openstack-cinder15:57
rajinireharney. thanks, will do15:57
*** lpetrut has quit IRC16:03
*** Apoorva has joined #openstack-cinder16:03
jungleboyjeharney:  Ah, good to know.  Do you mean 'related changes' ?16:03
*** dave-mccowan has joined #openstack-cinder16:03
eharneyjungleboyj: well, that shows it, but the Parent sha on the left shows its direct git parent16:04
jungleboyjAh, thank you.16:09
*** ntpttr_laptop has quit IRC16:10
jungleboyjNever knew what that dot meant.  Learn something new every day.16:10
*** ntpttr_laptop has joined #openstack-cinder16:10
eharneyit says "Not current" if you mouse over it16:10
*** hemna_ has joined #openstack-cinder16:18
*** robcresswell has joined #openstack-cinder16:19
*** crose has quit IRC16:19
*** e0ne has joined #openstack-cinder16:21
*** catintheroof has quit IRC16:23
*** salv-orlando has joined #openstack-cinder16:23
*** jmlowe_ has quit IRC16:23
*** dave-mccowan has quit IRC16:26
*** catintheroof has joined #openstack-cinder16:27
*** salv-orlando has quit IRC16:27
jungleboyjeharney:  Nice!16:30
*** ntpttr_laptop has quit IRC16:31
*** dustins has joined #openstack-cinder16:34
*** catintheroof has quit IRC16:35
*** catintheroof has joined #openstack-cinder16:36
*** shvepsy has quit IRC16:37
*** shvepsy has joined #openstack-cinder16:37
*** links has quit IRC16:38
*** catintheroof has quit IRC16:39
*** catintheroof has joined #openstack-cinder16:39
*** dave-mccowan has joined #openstack-cinder16:50
jgriffithsmcginnis: thingee geguileo Looks like this broke the default devstack deploy of cinderclient:  https://review.openstack.org/#/c/490961/16:52
*** AlexeyAbashkin has joined #openstack-cinder16:53
jgriffithAttributeError: "'Namespace' object has no attribute 'os_domain_id'"16:54
smcginnisjgriffith: Are you sure that's from this patch?16:54
jgriffithwhich appears to be because auth_type is set to `password`16:54
jgriffithmriedem: yes, it does let you do a second attach to the Instance, BUT it's just reusing the attachment record that already exists16:56
*** AlexeyAbashkin has quit IRC16:57
jgriffithmriedem: at least it *was*, let me go have a look....16:57
jgriffithmay have broken something along the way16:57
*** dave-mccowan has quit IRC17:03
*** dave-mccowan has joined #openstack-cinder17:03
*** dhinesh has quit IRC17:07
*** ntpttr_laptop has joined #openstack-cinder17:08
jgriffithsmcginnis: not 100%17:19
jgriffithsmcginnis: although reverting it did solve the problem17:19
jgriffithit's also highly possible that Keystone screwed us again..17:19
jgriffithor the constant devstack churn has caught something17:19
jgriffithI'd be curious if it fails for anybody else running client from source and not pypi17:20
jgriffithmriedem: ildikov so yeah... since there were some changes for things like live-migrate and the dance that goes with it, we did this:  https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L197217:21
e0nejgriffith: is it broken on master?17:21
*** aarefiev is now known as aarefiev_afk17:21
jgriffithso the side effect is that you *can* call attach on a volume to the same instance as many times as you'd like17:21
jgriffithit will create a new attachment record each time, then reuse the connection if it's there, or init a new one in the case of instance migration17:22
jgriffithe0ne: it was when I just tried it this morning yes17:23
jgriffithbut who knows.. maybe it was one of those "one time glitch" things :)17:23
e0nejgriffith: do you mean it was reproduced on your env?17:23
jgriffithe0ne: it's only occured in my env that I know of17:24
ildikovjgriffith: we discussed to check the host too at the time when we were writing the attach spec for Nova17:24
ildikovjgriffith: I need to re-read, we might have that part in the final spec too17:24
e0nejgriffith: got it. will try to reproduce on my env on Monday17:24
jgriffithe0ne: awesome... I'll probably circle back and look at it again on my side later as well17:25
ildikovjgriffith: so the idea was to let the volume be attached twice to the same instance if the host is different17:25
e0nejgriffith: ok, let me know if it works or not, please17:25
jgriffithe0ne: I'll shoot you a note if I do so you don't waste any time17:25
e0nejgriffith: thanks17:25
jgriffithildikov: I'll leave that up to you and the Nova team17:25
jgriffitheasy enough to force that if that's what's desired17:26
jgriffithildikov: but I'm not letting this raise my blood pressure any more :)17:26
ildikovjgriffith: I thought to discuss it with you on what and what not to do to avoid your blood pressure raising on this again :)17:28
*** itlinux has quit IRC17:28
jgriffithildikov: well, I just mean all the changes we made already to behave like the old code, but let's ignore that17:29
jgriffithit doesn't matter17:29
jgriffithso the way I see it there are two choices, maybe 3:17:29
*** dave-mccowan has quit IRC17:29
jgriffith1. Leave it as it works, but just gives a new attachment-id / entry (I'm sure people will hate that)17:30
*** jmlowe has joined #openstack-cinder17:30
jgriffith2.  Do as you mention and look at host-id and fail if it's the same (that's kinda ugly though IMO)17:30
jgriffith3. Add something on the Nova side that indicates to Cinder that the volume is part of an Instance/Live migration process and handle it explicitly that way17:31
jgriffithPersonally I'm good with option 1 :)17:31
*** dhinesh has joined #openstack-cinder17:31
jgriffithBut wouldn't feel horrible about option 317:31
jgriffithI think option 2 sucks17:31
jgriffiththat's my vote17:31
ildikovyeah, I hate option 2 as well, I was thinking about it but couldn't get to actually liking it17:31
ildikovand I had seven hours on the train today and it wasn't enough... :)17:32
smcginnisjgriffith: You said we actually create a new attachment for it now? It doesn't just return the existing attachment?17:32
jgriffithsmcginnis: nope17:32
ildikovoption 3 sounds good from the perspective that at least we don't just best guess what's going on17:32
jgriffithsmcginnis: so the whole point of this was supposed to be attachments were ephemeral things17:32
ildikovI'm not sure I fully get option 1 though17:32
jgriffithbut we've morphed that a bit now so it's not really quite true any more17:33
jgriffithsmcginnis: so what happens in this particular case is the reserve gets called, sets the special case flag because it's the same instance17:33
jgriffithsmcginnis: creates a new attachment object/id17:34
jgriffiththere's no connector passed in so it doesn't need to do a completion17:34
ildikovjgriffith: live migrate only calls create I think17:34
jgriffithupdates the attachment objects and returns17:34
smcginnisOK, make sense.17:35
jgriffithildikov: nah17:35
jgriffithildikov: it comes back later and does a round of updating and such17:35
ildikovbut anyone else can randomly make that call independently from live migrate anyway17:35
jgriffithildikov: it has to, because it needs to move the connection17:35
jgriffithto antoher host17:35
jgriffithI remember this all pretty well because I didn't want to do the whole reserve and status check thing that mandated this special case handling here17:36
jgriffiththe status checking stuff inparticular was the challenge17:36
ildikovjgriffith: here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L570917:39
jgriffithildikov: "here" what?17:39
ildikovit got updated I think after we realized we don't want an attachment_update call in refresh_connection_info17:40
jgriffithOh, the connector17:40
ildikovyep :)17:40
jgriffithildikov: yeah, I haven't kept up with all 148 version of the patch :)17:41
ildikovjgriffith: that's another patch :)17:41
jgriffithildikov: even better :)17:42
ildikovjgriffith: :)17:42
ildikovjgriffith: so what is option 1 again?17:43
ildikovjgriffith: just to ensure I understand17:43
jgriffithildikov: option 1 is leave it like it is17:46
ildikovjgriffith: ah ok, I guess the 'but' in the sentence is what got me confused :)17:47
ildikovjgriffith: if we decide to tweak the code and option 1 is not good enough my vote is option 317:48
ildikovmriedem: johnthetubaguy: ^^ ?17:48
mriedembeing able to attach a multiattach=False volume to the same instance that it's already attached to needs to result in an error at least from the nova side, since it would today as a 400, otherwise it's a behavior change,17:50
mriedemso if we have to, we'll just do a check_attach() on the nova side17:50
ildikovsadness :(17:51
mriedemwell, it's a behavior change,17:52
mriedemso it has to be dealt with somewhere right?17:52
ildikovyeah, I just hoped we will not get back to check_attach17:52
ildikovI guess it's the matter of taste, like if I needed to choose between a flag and check_attach, I would choose the flag17:53
mriedemnova should probably be enforcing a unique constraint in the bdm table on volumeid and instanceid, which would also catch this, but it's something we haven't done - and doing it now might break some existing deployments in weird ways on upgrade17:53
mriedemflag == config option?17:53
*** itlinux has joined #openstack-cinder17:53
ildikovflag == telling Cinder we're live migrating so it can make an exception17:54
mriedemi'm not really sure what that would look like17:55
mriedemthat's a flag passed during attachment_create?17:55
ildikovif we could use the BDM long term though that might be better17:55
mriedemso normal attach, if the flag isn't there, cinder kicks you out if the instance/volume already has an attachment?17:55
mriedemnova's going to have bdms long term regardless, it's how we model the block devices (including ephemeral and swap devices)17:55
ildikovyes, I meant like that, so when we create the second attachment we tell Cinder we need that for live migrate17:56
ildikovotherwise fail17:57
ildikovdo you think using the BDM for solving this issue would be better/acceptable?17:58
*** newmember has joined #openstack-cinder17:58
ildikovas in that case we can hide behind a check_attach for now that we remove once we figured out the BDM solution17:59
mriedembdm solution == unique constraints?18:02
mriedemso i don't want to have to do another cinder microversion of this, which is what you'd need to pass a new parameter to attachment_create,18:03
mriedemand passing a "seriously i know what i'm doing" flag just for nova-isms sucks18:03
mriedemi'm sure jgriffith would agree18:03
mriedemso for now yeah i think we do a check_attach in nova18:03
mriedemif we can eventually replace that with a bdm unique constraint in the db, that would be cool too18:03
mriedembut i won't hold my breath for that since it would require some thought to not blow people up on upgrade18:03
mriedeme.g. we are upgrading and find out there are 2 bdms in the db for the same instance and volume, what do we do?18:04
ildikovfair enough18:05
*** harlowja has quit IRC18:05
*** harlowja has joined #openstack-cinder18:05
ildikovI might name the new check_attach function to bleeding_ildiko or smth like18:05
ildikovor just add it to check_attach_and_reserve_volume silently18:06
mriedemit might be possible to only do the check_attach thing if we know we're dealing with new style attachments18:06
mriedemi was thinking check_attach_and_reserve_volume18:06
mriedemproblem is i think we don't know if we're doing new style until we try attachment_create and it fails or not18:07
jgriffithmriedem: I was referring to flag in terms of the attachment-create call18:07
jgriffithgimmie  a second to read scrollback18:07
jgriffithOk, all sounds good; how about I just put the enforcements back in Cinder to catch this18:08
jgriffithand if we break something somewhere we can revisit18:08
mriedemthat would break the live migration flow i think18:08
jgriffithmriedem: it looks like that may not18:08
jgriffithat least if I add some Cinder checks for things like connectors and Instance UUID's18:09
mriedemoh b/c of the host?18:09
jgriffithmriedem: yeah18:09
mriedemyeah i guess for live migration we pass the connector in attachment_create,18:09
mriedemduring volume attach, we don't18:09
jgriffithas much as I sort of disliked that it might be the best idea18:09
jgriffithie safest, most explicit and expedient with OUT a mv18:09
mriedemat 1pm on a friday and my head has been in something else all day, i can't really say at this point18:10
jgriffithwhich I don't want to do antoher one of those either ;)18:10
jgriffithmriedem: yeah, fair18:10
jgriffithmriedem: and I haven't looked closely at it18:10
jgriffithI'll see if I can come up with something before Monday without changing the Nova side including mv bump on Cinder18:10
ildikovso I think live migrate itself is fine18:10
jgriffithshould be doable18:10
ildikovand we want to prevent the user from themselves18:11
ildikovfor which we don't pass the connector18:11
jgriffithildikov: in either case, what we have now the more I think about it is no good18:11
jgriffitheven if we wanted to ignore the whole multi-attach False thing we shouldn't swap the attachment-id's anyway18:12
ildikoveither way we can say either that 'Cinder shouldn't care how the volume gets attached and it's on Nova to prevent this' or that 'Nova should only issue the attach call and let Cinder decide on everything as the single source of truth' and now we need to pick one of the above for this particular case18:13
ildikovwe create a new one and don't swap it and yes we shouldn't in the future either18:13
ildikovas by calling create with the connector it creates a new attachment I would think18:14
*** wes_dillingham has quit IRC18:14
*** Apoorva has quit IRC18:15
ildikovjgriffith: let's give it some thought and if I need to check it on the Nova side by the end, I will18:15
*** e0ne has quit IRC18:15
*** ntpttr_laptop has quit IRC18:16
*** Apoorva has joined #openstack-cinder18:17
*** salv-orlando has joined #openstack-cinder18:24
*** salv-orlando has quit IRC18:29
*** crose has joined #openstack-cinder18:31
*** armaan has quit IRC18:34
*** rtjure has quit IRC18:34
*** rtjure has joined #openstack-cinder18:35
*** markstur has quit IRC18:36
*** dave-mccowan has joined #openstack-cinder18:38
*** rtjure has quit IRC18:39
*** dave-mccowan has quit IRC18:44
*** rtjure has joined #openstack-cinder18:45
*** wes_dillingham has joined #openstack-cinder18:45
*** amoralej is now known as amoralej|off18:48
*** rtjure has quit IRC18:50
*** chhavi has quit IRC19:02
*** crose has quit IRC19:07
*** lpetrut has joined #openstack-cinder19:08
*** crose has joined #openstack-cinder19:10
*** abhishek has quit IRC19:11
*** crose has quit IRC19:19
*** ChubYann has joined #openstack-cinder19:23
*** ChubYann has left #openstack-cinder19:28
*** Apoorva has quit IRC19:28
*** Apoorva has joined #openstack-cinder19:29
*** catintheroof has quit IRC19:29
*** e0ne has joined #openstack-cinder19:29
*** e0ne has quit IRC19:30
*** Apoorva has quit IRC19:33
*** tesseract has quit IRC19:33
*** dave-mccowan has joined #openstack-cinder19:37
*** catintheroof has joined #openstack-cinder19:41
*** LobsterRoll has joined #openstack-cinder19:41
*** markstur has joined #openstack-cinder19:43
*** wes_dillingham has quit IRC19:43
*** LobsterRoll is now known as wes_dillingham19:43
*** Apoorva has joined #openstack-cinder19:43
*** catintheroof has quit IRC19:45
*** markstur has quit IRC19:47
*** dave-mccowan has quit IRC19:49
*** rcernin has joined #openstack-cinder19:57
*** itlinux has quit IRC20:01
*** wes_dillingham has quit IRC20:11
*** jmlowe has quit IRC20:14
*** KeithMnemonic1 has quit IRC20:17
*** abhishek has joined #openstack-cinder20:22
*** salv-orlando has joined #openstack-cinder20:25
*** salv-orlando has quit IRC20:29
*** dave-mccowan has joined #openstack-cinder20:33
*** dustins has quit IRC20:35
*** salv-orlando has joined #openstack-cinder20:35
*** ntpttr_laptop has joined #openstack-cinder20:35
*** markstur has joined #openstack-cinder20:36
*** mdbooth has quit IRC20:37
*** dave-mccowan has quit IRC20:38
*** itlinux has joined #openstack-cinder20:41
*** mdbooth has joined #openstack-cinder20:43
*** ntpttr_laptop has quit IRC20:48
*** ntpttr_laptop has joined #openstack-cinder20:48
*** felipemonteiro__ has quit IRC20:48
*** abhishek has quit IRC20:53
*** Apoorva_ has joined #openstack-cinder20:59
*** abishop has quit IRC21:00
*** hemna_ has quit IRC21:01
*** Apoorva has quit IRC21:02
*** ntpttr_laptop__ has joined #openstack-cinder21:03
*** ntpttr_laptop has quit IRC21:05
*** itlinux has quit IRC21:07
*** itlinux has joined #openstack-cinder21:15
*** ntpttr_laptop__ has quit IRC21:15
openstackgerritMerged openstack/cinder master: Vzstorage: improvement of create_cloned_volume  https://review.openstack.org/49682821:23
openstackgerritMerged openstack/cinder master: Mark Cisco FC ZM driver as unsupported  https://review.openstack.org/50827521:28
*** rcernin has quit IRC21:28
*** wes_dillingham has joined #openstack-cinder21:33
*** newmember has quit IRC21:33
*** itlinux has quit IRC21:44
*** ganso has quit IRC21:47
*** wes_dillingham has quit IRC21:49
*** salv-orlando has quit IRC21:50
*** salv-orlando has joined #openstack-cinder21:50
*** mchlumsky has quit IRC21:53
*** salv-orlando has quit IRC21:55
*** salv-orlando has joined #openstack-cinder22:03
*** dave-mccowan has joined #openstack-cinder22:15
*** dave-mccowan has quit IRC22:24
*** salv-orlando has quit IRC22:27
*** salv-orlando has joined #openstack-cinder22:28
*** itlinux has joined #openstack-cinder22:33
*** salv-orlando has quit IRC22:35
*** salv-orlando has joined #openstack-cinder22:36
*** lpetrut has quit IRC22:36
*** salv-orlando has quit IRC22:40
*** itlinux has quit IRC22:46
*** sdague has quit IRC22:50
*** gnufied has quit IRC23:13
SamYaplehello friends. a couple of years back there was a spec make cinder-volume more HA like with shared backends. ceph as the use case, if you submit a create it will be assigned to one cinder-volume and if that cinder-volume service does down you can no longer manage that ovlume you created until it returns (or you db edit) does anyone know the status of that?23:46
*** ntpttr_laptop has joined #openstack-cinder23:47
*** stvnoyes has quit IRC23:48
*** ntpttr_laptop has quit IRC23:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!