Wednesday, 2017-05-31

*** dave-mccowan has joined #openstack-cinder00:03
*** markvoelker has quit IRC00:04
*** gouthamr has joined #openstack-cinder00:10
*** itlinux has quit IRC00:11
*** salv-orlando has joined #openstack-cinder00:15
*** gouthamr has quit IRC00:16
*** jwcroppe has joined #openstack-cinder00:17
*** salv-orlando has quit IRC00:19
*** diablo_rojo has quit IRC00:31
*** mriedem has quit IRC00:38
*** Julien-zte has joined #openstack-cinder00:46
*** zhengyin has joined #openstack-cinder00:47
*** markvoelker has joined #openstack-cinder00:47
*** wanghao has joined #openstack-cinder00:49
*** Julien-zte has quit IRC00:49
*** frontrunner has joined #openstack-cinder00:49
*** wanghao has quit IRC00:50
*** Julien-zte has joined #openstack-cinder00:50
*** wanghao has joined #openstack-cinder00:50
*** jwcroppe has quit IRC00:51
*** dikonoor has joined #openstack-cinder01:01
*** Shunli has joined #openstack-cinder01:04
*** wN has joined #openstack-cinder01:04
*** wN has quit IRC01:04
*** wN has joined #openstack-cinder01:04
*** wanghao_ has joined #openstack-cinder01:07
*** zhangguoqing has joined #openstack-cinder01:08
*** wanghao has quit IRC01:10
*** gouthamr has joined #openstack-cinder01:13
*** gcb has joined #openstack-cinder01:13
*** wanghao_ has quit IRC01:13
*** wanghao has joined #openstack-cinder01:14
openstackgerritLiu Qing proposed openstack/cinder master: Fix SSHPool current_size not work correctly  https://review.openstack.org/46863401:16
*** markvoelker_ has joined #openstack-cinder01:16
*** markvoelker has quit IRC01:17
*** lucasxu has joined #openstack-cinder01:17
*** lucasxu has quit IRC01:17
*** Apoorva_ has joined #openstack-cinder01:18
*** jose-phillips has quit IRC01:20
*** lucasxu has joined #openstack-cinder01:20
*** markvoelker_ has quit IRC01:21
*** jose-phillips has joined #openstack-cinder01:22
*** Apoorva_ has quit IRC01:22
*** Apoorva has quit IRC01:22
*** lucasxu has quit IRC01:22
*** lucasxu has joined #openstack-cinder01:23
*** markvoelker has joined #openstack-cinder01:23
*** dikonoor has quit IRC01:24
*** dhinesh has quit IRC01:25
*** wanghao_ has joined #openstack-cinder01:25
*** wanghao has quit IRC01:28
*** arahal_ has quit IRC01:32
openstackgerritwangxiyuan proposed openstack/cinder master: Return metadata in volume summary  https://review.openstack.org/45914301:35
*** wanghao_ has quit IRC01:36
*** wanghao has joined #openstack-cinder01:36
*** aselius has quit IRC01:45
*** zhaochao has joined #openstack-cinder01:45
openstackgerritwzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression  https://review.openstack.org/45029101:51
*** hongbin has quit IRC01:51
*** kaisers_ has joined #openstack-cinder01:54
openstackgerritwzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression  https://review.openstack.org/45029101:56
*** kaisers has quit IRC01:57
*** lucasxu has quit IRC02:01
*** lucasxu has joined #openstack-cinder02:11
*** lucasxu has quit IRC02:13
*** lucasxu has joined #openstack-cinder02:14
*** salv-orlando has joined #openstack-cinder02:15
*** dave-mccowan has quit IRC02:15
*** wanghao_ has joined #openstack-cinder02:17
*** wanghao_ has quit IRC02:17
*** wanghao has quit IRC02:17
*** wanghao has joined #openstack-cinder02:17
*** salv-orlando has quit IRC02:20
*** wanghao_ has joined #openstack-cinder02:35
*** wanghao has quit IRC02:38
*** lucasxu has quit IRC02:40
openstackgerritwangxiyuan proposed openstack/cinder master: Return metadata in volume summary  https://review.openstack.org/45914302:42
*** zsli_ has joined #openstack-cinder02:44
*** wanghao has joined #openstack-cinder02:44
*** lucasxu has joined #openstack-cinder02:45
*** wanghao_ has quit IRC02:46
*** Shunli has quit IRC02:46
*** lucasxu has quit IRC02:47
*** nicolasbock has quit IRC02:49
*** markstur has quit IRC02:55
*** lucasxu has joined #openstack-cinder02:56
*** Julien-zte has quit IRC03:00
*** Julien-zte has joined #openstack-cinder03:01
*** lucasxu has quit IRC03:04
*** zsli_ has quit IRC03:08
*** Shunli has joined #openstack-cinder03:08
*** Julien-zte has quit IRC03:10
*** Julien-zte has joined #openstack-cinder03:12
*** Julien-zte has quit IRC03:19
*** nicolasbock has joined #openstack-cinder03:20
*** Julien-zte has joined #openstack-cinder03:20
*** esker has quit IRC03:22
*** Julien-zte has quit IRC03:23
*** Julien-zte has joined #openstack-cinder03:24
*** dhinesh has joined #openstack-cinder03:24
*** frontrunner has quit IRC03:26
*** Julien-zte has quit IRC03:27
*** Julien-zte has joined #openstack-cinder03:28
*** psachin has quit IRC03:29
*** nicolasbock has quit IRC03:33
*** david-lyle has joined #openstack-cinder03:35
*** Julien-z_ has joined #openstack-cinder03:35
*** Julien-zte has quit IRC03:37
*** Julien-z_ has quit IRC03:45
*** links has joined #openstack-cinder03:45
*** lucasxu has joined #openstack-cinder03:45
*** Julien-zte has joined #openstack-cinder03:46
*** psachin has joined #openstack-cinder03:46
*** Julien-zte has quit IRC03:50
*** salv-orlando has joined #openstack-cinder03:50
*** Julien-zte has joined #openstack-cinder03:50
*** Julien-zte has quit IRC03:53
*** salv-orlando has quit IRC03:54
*** Julien-zte has joined #openstack-cinder03:57
*** zhangguoqing has quit IRC04:00
*** kaisers_ has quit IRC04:06
*** arnewiebalck_ has joined #openstack-cinder04:07
*** kaisers has joined #openstack-cinder04:10
*** lucasxu has quit IRC04:11
*** kaisers has quit IRC04:15
*** zhurong has joined #openstack-cinder04:15
*** dikonoor has joined #openstack-cinder04:18
*** zhurong has quit IRC04:19
*** mtanino__ has joined #openstack-cinder04:24
*** zhengyin has quit IRC04:32
*** dikonoor has quit IRC04:37
*** salv-orlando has joined #openstack-cinder04:39
*** chhavi has joined #openstack-cinder04:40
*** mtanin___ has joined #openstack-cinder04:45
*** mtanino__ has quit IRC04:46
*** gkadam has joined #openstack-cinder04:46
*** gouthamr has quit IRC04:51
*** zhangguoqing has joined #openstack-cinder04:51
*** Julien-zte has quit IRC04:52
*** dikonoor has joined #openstack-cinder04:55
*** Julien-zte has joined #openstack-cinder04:56
*** pgadiya has joined #openstack-cinder04:59
*** pgadiya has quit IRC04:59
openstackgerritjiamin proposed openstack/cinder master: DS8K: support clone volume asynchroniously  https://review.openstack.org/46713605:00
*** dikonoor has quit IRC05:01
*** adisky__ has joined #openstack-cinder05:03
*** mtanin___ has quit IRC05:07
*** zhengyin has joined #openstack-cinder05:11
*** kaisers has joined #openstack-cinder05:11
*** arnewiebalck_ has quit IRC05:14
*** Poornima has joined #openstack-cinder05:39
*** Julien-zte has quit IRC05:52
openstackgerritCheng Yong Zhao proposed openstack/cinder master: Add gmcv support in SVC driver  https://review.openstack.org/46119105:56
*** ChubYann has quit IRC05:58
*** xiangxinyong is now known as edison06:08
*** edison is now known as edisonxiang06:08
*** mvk has quit IRC06:09
*** rcernin has joined #openstack-cinder06:10
*** KeithMnemonic1 has joined #openstack-cinder06:16
*** karthikp has quit IRC06:16
*** karthikp_ is now known as karthikp06:16
*** dhinesh_ has joined #openstack-cinder06:17
*** dhinesh has quit IRC06:17
*** bluex has quit IRC06:18
*** karthikp_ has joined #openstack-cinder06:18
*** KeithMnemonic has quit IRC06:18
openstackgerritYingzhe Zeng proposed openstack/cinder master: Use requests lib for Huawei array connection  https://review.openstack.org/45904206:24
openstackgerritCheng Yong Zhao proposed openstack/cinder master: Add gmcv support in SVC driver  https://review.openstack.org/46119106:27
*** bluex has joined #openstack-cinder06:27
*** zhengyin has quit IRC06:33
*** zhengyin has joined #openstack-cinder06:34
*** e0ne has joined #openstack-cinder06:42
*** zhengyin has quit IRC06:44
*** e0ne has quit IRC06:50
*** tesseract has joined #openstack-cinder06:53
*** jsuchome has joined #openstack-cinder06:59
*** zhengyin has joined #openstack-cinder07:00
*** e0ne has joined #openstack-cinder07:04
*** mvk has joined #openstack-cinder07:08
*** wanghao_ has joined #openstack-cinder07:09
*** wanghao has quit IRC07:12
*** chhavi has quit IRC07:22
*** pcaruana has joined #openstack-cinder07:26
*** dhinesh_ has quit IRC07:26
*** salv-orl_ has joined #openstack-cinder07:27
*** salv-orlando has quit IRC07:30
*** yangyapeng has joined #openstack-cinder07:31
*** yangyapeng has quit IRC07:31
*** e0ne has quit IRC07:31
*** pjm6 has quit IRC07:34
*** pjm6 has joined #openstack-cinder07:37
*** Poornima has quit IRC07:43
*** aselius has joined #openstack-cinder07:45
*** arnewiebalck_ has joined #openstack-cinder07:46
*** aarefiev_afk is now known as aarefiev07:54
*** zzzeek has quit IRC08:00
*** mnestratov has joined #openstack-cinder08:01
*** zzzeek has joined #openstack-cinder08:01
*** chhavi has joined #openstack-cinder08:02
*** dikonoor has joined #openstack-cinder08:02
*** lpetrut has joined #openstack-cinder08:02
*** Shunli has quit IRC08:12
*** Shunli has joined #openstack-cinder08:13
*** arnewiebalck_ has quit IRC08:14
*** tomh_ has joined #openstack-cinder08:25
*** stakeda has quit IRC08:28
*** Poornima has joined #openstack-cinder08:29
*** dikonoor has quit IRC08:39
*** savvas_ has joined #openstack-cinder08:43
*** savvas has quit IRC08:45
*** cristicalin has joined #openstack-cinder08:48
*** cristicalin has quit IRC08:50
*** gkadam_ has joined #openstack-cinder08:52
*** jose-phi_ has joined #openstack-cinder08:53
*** wxy_ has joined #openstack-cinder08:53
*** dobson has joined #openstack-cinder08:54
*** fmccrthy_ has joined #openstack-cinder08:54
*** wanghao has joined #openstack-cinder08:54
*** ediardo_ has joined #openstack-cinder08:54
*** strigazi_ has joined #openstack-cinder08:56
*** dalvarezs has joined #openstack-cinder08:59
*** oomichi_ has joined #openstack-cinder08:59
*** zzzeek_ has joined #openstack-cinder09:00
*** mmedvede_ has joined #openstack-cinder09:00
*** johnthetubaguy_ has joined #openstack-cinder09:00
*** dmellado_ has joined #openstack-cinder09:00
*** zzzeek has quit IRC09:01
*** wanghao_ has quit IRC09:01
*** gkadam has quit IRC09:01
*** links has quit IRC09:01
*** jose-phillips has quit IRC09:01
*** fmccrthy has quit IRC09:01
*** ediardo has quit IRC09:01
*** kaisers1 has quit IRC09:01
*** mmedvede has quit IRC09:01
*** wxy has quit IRC09:01
*** rushiagr has quit IRC09:01
*** dobson` has quit IRC09:01
*** dmellado has quit IRC09:01
*** dalvarez has quit IRC09:01
*** stvnoyes has quit IRC09:01
*** oomichi has quit IRC09:01
*** strigazi has quit IRC09:01
*** johnthetubaguy has quit IRC09:01
*** jistr has quit IRC09:01
*** mmedvede_ is now known as mmedvede09:01
*** oomichi_ is now known as oomichi09:01
*** ediardo_ is now known as ediardo09:01
*** fmccrthy_ is now known as fmccrthy09:01
*** wxy_ is now known as wxy09:01
*** rarora has joined #openstack-cinder09:01
*** jistr has joined #openstack-cinder09:02
*** gkadam_ is now known as gkadam09:04
*** links has joined #openstack-cinder09:07
*** stvnoyes has joined #openstack-cinder09:08
*** kaisers1 has joined #openstack-cinder09:09
*** david-lyle has quit IRC09:11
*** david-lyle has joined #openstack-cinder09:12
*** rushiagr has joined #openstack-cinder09:14
*** cristicalin has joined #openstack-cinder09:22
openstackgerritxiaoqin proposed openstack/cinder master: [WIP] Add Storwize replication group support  https://review.openstack.org/46939409:26
*** Shunli has quit IRC09:32
*** dalgaaf has quit IRC09:39
*** dalgaaf has joined #openstack-cinder09:44
*** dmellado_ is now known as dmellado09:46
openstackgerritShunei Shiono proposed openstack/cinder master: Refactor NEC volume driver  https://review.openstack.org/45302209:50
*** cristicalin has quit IRC09:52
*** aselius has quit IRC09:54
*** mvk has quit IRC09:55
*** dikonoor has joined #openstack-cinder09:56
*** nicolasbock has joined #openstack-cinder09:56
*** wanghao has quit IRC09:58
*** wanghao has joined #openstack-cinder10:03
*** wanghao has quit IRC10:04
*** Julien-zte has joined #openstack-cinder10:10
*** mvk has joined #openstack-cinder10:10
*** Julien-zte has quit IRC10:12
openstackgerritGorka Eguileor proposed openstack/os-brick master: Add open-iscsi manual scan support  https://review.openstack.org/45539410:12
openstackgerritGorka Eguileor proposed openstack/os-brick master: Refactor iSCSI disconnect  https://review.openstack.org/45539210:12
openstackgerritGorka Eguileor proposed openstack/os-brick master: Refactor iSCSI connect  https://review.openstack.org/45539310:12
*** Julien-zte has joined #openstack-cinder10:13
*** dikonoor has quit IRC10:13
*** dikonoor has joined #openstack-cinder10:14
*** gkadam has quit IRC10:14
*** links has quit IRC10:16
*** e0ne has joined #openstack-cinder10:22
*** Julien-zte has quit IRC10:23
*** Julien-zte has joined #openstack-cinder10:24
*** Julien-zte has quit IRC10:25
*** Julien-zte has joined #openstack-cinder10:26
*** Julien-zte has quit IRC10:26
*** nicolasbock has quit IRC10:27
*** nicolasbock has joined #openstack-cinder10:27
*** Julien-zte has joined #openstack-cinder10:27
*** nicolasbock has quit IRC10:28
*** nicolasbock has joined #openstack-cinder10:28
*** gkadam has joined #openstack-cinder10:34
*** links has joined #openstack-cinder10:36
*** chhavi has quit IRC10:37
*** Julien-zte has quit IRC10:39
*** Julien-zte has joined #openstack-cinder10:40
*** chhavi has joined #openstack-cinder10:40
*** Julien-zte has quit IRC10:44
*** Julien-zte has joined #openstack-cinder10:45
*** zhangguoqing has quit IRC10:50
*** gkadam_ has joined #openstack-cinder10:54
*** gkadam has quit IRC10:57
*** salv-orl_ has quit IRC10:59
openstackgerritSean McGinnis proposed openstack/python-cinderclient master: Fix minor issues in shell help messages  https://review.openstack.org/46942811:02
*** Julien-zte has quit IRC11:03
*** Julien-zte has joined #openstack-cinder11:04
*** cristicalin has joined #openstack-cinder11:06
*** Julien-zte has quit IRC11:07
*** Julien-zte has joined #openstack-cinder11:08
*** gkadam_ is now known as gkadam11:08
*** zhengyin has quit IRC11:08
*** dave-mccowan has joined #openstack-cinder11:12
*** liverpooler has quit IRC11:13
*** Julien-zte has quit IRC11:15
openstackgerritwzyuliyang proposed openstack/cinder master: Add pigz support for cinder-backup chunked driver compression  https://review.openstack.org/45029111:17
*** chhavi has quit IRC11:33
openstackgerritTommyLike proposed openstack/python-cinderclient master: Support generalized resource filter in client  https://review.openstack.org/46500211:33
*** savvas_ has quit IRC11:37
*** savvas has joined #openstack-cinder11:37
*** psachin has quit IRC11:49
*** psachin has joined #openstack-cinder11:49
openstackgerritGorka Eguileor proposed openstack/cinder master: Do proper cleanup if connect volume fails  https://review.openstack.org/45945311:51
openstackgerritGorka Eguileor proposed openstack/cinder master: Add support for OS-Brick force disconnect  https://review.openstack.org/45945411:51
openstackgerritGorka Eguileor proposed openstack/cinder master: Multipath tempest scenarios  https://review.openstack.org/46944511:51
*** esker has joined #openstack-cinder11:55
*** abishop has joined #openstack-cinder11:56
*** esker has quit IRC12:00
*** frontrunner has joined #openstack-cinder12:00
*** MVenesio has joined #openstack-cinder12:01
*** edmondsw has joined #openstack-cinder12:02
*** chlong has quit IRC12:03
*** bjornar_ has joined #openstack-cinder12:04
*** kbaegis has joined #openstack-cinder12:05
*** kbaegis has quit IRC12:05
*** kbaegis has joined #openstack-cinder12:06
*** kbaegis has quit IRC12:06
*** kbaegis has joined #openstack-cinder12:06
*** kbaegis has quit IRC12:06
*** kbaegis has joined #openstack-cinder12:07
*** kbaegis has quit IRC12:07
*** psachin has quit IRC12:07
*** felipemonteiro has joined #openstack-cinder12:10
*** links has quit IRC12:11
*** felipemonteiro_ has joined #openstack-cinder12:19
openstackgerritGorka Eguileor proposed openstack/os-brick master: Add open-iscsi manual scan support  https://review.openstack.org/45539412:20
openstackgerritGorka Eguileor proposed openstack/os-brick master: Refactor iSCSI connect  https://review.openstack.org/45539312:20
*** felipemonteiro has quit IRC12:22
*** kaisers has quit IRC12:30
openstackgerritMerged openstack/cinder master: Fix api-ref for POST backup for optional name  https://review.openstack.org/45209012:31
*** gkadam_ has joined #openstack-cinder12:34
*** gkadam has quit IRC12:37
*** gkadam has joined #openstack-cinder12:40
*** gkadam_ has quit IRC12:40
*** Julien-zte has joined #openstack-cinder12:44
*** liverpooler has joined #openstack-cinder12:47
*** gkadam has quit IRC12:47
*** Julien-zte has quit IRC12:48
*** Julien-zte has joined #openstack-cinder12:48
*** zhangguoqing has joined #openstack-cinder13:01
*** Julien-zte has quit IRC13:01
*** Julien-zte has joined #openstack-cinder13:02
*** eharney has joined #openstack-cinder13:03
*** xyang1 has joined #openstack-cinder13:04
*** dpawlik has joined #openstack-cinder13:05
*** Poornima has quit IRC13:07
*** cristicalin has quit IRC13:07
*** psachin has joined #openstack-cinder13:08
*** danpawlik has quit IRC13:09
*** jwcroppe has joined #openstack-cinder13:10
*** lucasxu has joined #openstack-cinder13:11
*** strigazi_ is now known as strigazi13:15
*** lifeless has quit IRC13:15
*** lixiaoy1 has joined #openstack-cinder13:18
*** gouthamr has joined #openstack-cinder13:19
*** lixiaoy1 has quit IRC13:21
*** superdan is now known as dansmith13:26
*** kaisers has joined #openstack-cinder13:26
*** mugsie has quit IRC13:27
*** chlong has joined #openstack-cinder13:30
*** chhavi has joined #openstack-cinder13:32
*** lifeless has joined #openstack-cinder13:33
*** zhangguoqing has quit IRC13:34
*** crushil has joined #openstack-cinder13:35
*** dfisher has joined #openstack-cinder13:39
*** zhangguoqing has joined #openstack-cinder13:41
*** zhurong has joined #openstack-cinder13:42
*** mriedem has joined #openstack-cinder13:42
*** cristicalin has joined #openstack-cinder13:43
*** chlong has quit IRC13:43
*** chlong has joined #openstack-cinder13:46
*** bjornar_ has quit IRC13:49
*** psachin has quit IRC13:53
*** mtanino__ has joined #openstack-cinder13:53
*** kaisers has quit IRC13:55
*** wanghao has joined #openstack-cinder13:59
*** gluytium has quit IRC14:02
openstackgerritMerged openstack/python-cinderclient master: Support generalized resource filter in client  https://review.openstack.org/46500214:05
openstackgerritGorka Eguileor proposed openstack/cinder master: Remove unused _detach_snapshot method  https://review.openstack.org/46949914:05
*** bjornar_ has joined #openstack-cinder14:05
*** felipemonteiro_ has quit IRC14:06
openstackgerritGorka Eguileor proposed openstack/os-brick master: Add open-iscsi manual scan support  https://review.openstack.org/45539414:06
openstackgerritGorka Eguileor proposed openstack/os-brick master: Refactor iSCSI disconnect  https://review.openstack.org/45539214:06
openstackgerritGorka Eguileor proposed openstack/os-brick master: Refactor iSCSI connect  https://review.openstack.org/45539314:06
openstackgerritGorka Eguileor proposed openstack/cinder master: Multipath tempest scenarios  https://review.openstack.org/46944514:06
openstackgerritGorka Eguileor proposed openstack/cinder master: Allow logging in tempest tests  https://review.openstack.org/46950214:06
*** felipemonteiro has joined #openstack-cinder14:09
smcginnisgeguileo: You're almost back to filling my whole IRC screen. :)14:09
geguileolol14:09
*** salv-orlando has joined #openstack-cinder14:10
*** aselius has joined #openstack-cinder14:13
mriedemsmcginnis: jungleboyj: scottda: jgriffith: ildikov: got a question about this cinderclient code that is doing version discovery https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/client.py#L8814:24
*** hongbin has joined #openstack-cinder14:25
mriedemwhat happens if the server doesn't have v3? doesn't that for loop not error but also doesn't return anything?14:25
mriedemsince '3.' isn't in there?14:25
jgriffithmriedem it would appear you're correct... scottda ?14:25
mriedemalso, looking at this https://developer.openstack.org/api-ref/block-storage/v3/?expanded=list-all-api-versions-detail#response14:27
mriedemit looks like looking at 'version' is the wrong key14:27
jgriffithmriedem  looks like that needs to set a deafault for the return14:27
mriedem"version": "",14:27
mriedemthe id is v1.0, or v2.0 or v3.014:27
*** dikonoor has quit IRC14:27
mriedembut version should be set - is that doc just wrong?14:27
ildikovmriedem: good morning :)14:28
mriedemi was thinking about cinder version discovery at 4am14:29
mriedemso here i am14:29
ildikovthat looks like nightmare-ish, I agree14:29
mriedemor maybe the version key didn't get set until the v3 API?14:30
jgriffithmriedem I believe that's accurate, but scottda should have all the answers around this stuff14:32
mriedemok yeah i think it's this https://github.com/openstack/cinder/blob/master/cinder/api/versions.py#L36-L7314:32
ildikovI believe most of this stuff got introduced with microversions or with that in mind14:32
jgriffithI'm not quite sure how that v3 response is even useful either though looking at the doc there14:32
mriedemjgriffith: right it's the same as the GET /14:32
ildikovbut not many of us has the detailed knowledge about this14:33
mriedembut i'm pretty sure the client code is missing an else on the for loop to raise a ClientException to default to 2.014:33
jgriffithmriedem it's definitely missing that, I'm writing a patch now14:33
mriedemif i'm just passing the endpoint url from the service catalog for volumev2, or the server is not at ocata yet, then it won't have 3.x in the response and return None, which will lead to NoneType14:33
mriedemjgriffith: i'll report a bug14:34
jgriffithmriedem but the response thing I'm punting to somebody else because frankly I don't want to go anywhere near it14:34
*** zhurong has quit IRC14:35
ildikovjgriffith: you mean the 'version' key?14:35
mriedemjgriffith: unless cinder didn't support version discovery before v3, the v3 change actually changed the version discovery response :( https://review.openstack.org/#/c/224910/36/cinder/api/versions.py14:36
jgriffithildikov ?14:36
mriedemby adding new keys14:36
jgriffithildikov I mean this:  https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/client.py#L8814:36
mriedemhow ironic14:36
*** jonesn has joined #openstack-cinder14:37
jgriffithmriedem ha!  Yep!!14:37
ildikovjgriffith: I meant that one, yes14:37
mriedemjgriffith: https://bugs.launchpad.net/python-cinderclient/+bug/169472914:39
openstackLaunchpad bug 1694729 in python-cinderclient "get_server_version does not handle older (non-v3) servers" [Undecided,New]14:39
jgriffithmriedem thanks14:39
*** ericyoung has joined #openstack-cinder14:43
scottdamriedem: Looking...14:46
jgriffithI'm sure my patch will be objectionable, but oh well.14:47
openstackgerritJohn Griffith proposed openstack/python-cinderclient master: cinderclient might not return version for V2 API  https://review.openstack.org/46952014:47
mriedemi think all you need is for/else raise ClientException14:47
jgriffithmriedem I'd prefer to just make it less stupid looking and have it be somewhat clear14:47
jgriffithbut most people don't like it when I do that... or my brain is just broken maybe14:48
jgriffithinner returns suck IMO14:48
*** zhangguoqing has quit IRC14:48
jgriffithanyway, get your -1's ready14:48
mriedemworking on it14:49
*** cristicalin has quit IRC14:49
jgriffithaww crap14:50
jgriffithbreak14:50
openstackgerritMerged openstack/cinder master: Add an instance-uuid check on attachment_reserve  https://review.openstack.org/46925214:50
openstackgerritJohn Griffith proposed openstack/python-cinderclient master: cinderclient might not return version for V2 API  https://review.openstack.org/46952014:50
scottdaYes, that code lacked a default return. Patch looks fine to me jgriffith14:51
jgriffithscottda thanks!14:51
scottdaAnd, yes, there was no  version discovery before microversions.14:52
*** kaisers has joined #openstack-cinder14:52
scottdaSo only exists in V314:52
*** bjornar_ has quit IRC14:52
mriedemscottda: i'm not buying that14:52
mriedemv2 has a GET / response https://developer.openstack.org/api-ref/block-storage/v2/#list-api-versions14:52
*** zhangguoqing has joined #openstack-cinder14:53
mriedemand https://review.openstack.org/#/c/224910/36/cinder/api/versions.py was returning v1 and v2 in the response before v3 was added14:53
mriedemthat's version discovery14:53
*** zhangguoqing has quit IRC14:53
scottdaahh..right. I should say, there was no generic way to get the current version. You had to hit the /v1 or v2 endpoint14:53
scottdaBut, it didn't tell you much, IIRC. I mean, you hit /v2 and it tells you that you are on v2.14:54
mriedemjgriffith: so there is also going to be a similar issue in this one https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/api_versions.py#L24214:54
mriedemjgriffith: although that's probably a programming error if it returns None14:54
*** wanghao has quit IRC14:55
jgriffithsi14:55
jgriffithbut it probably wouldn't hurt to make it explicit and tag it onto the existing bug/review IMO14:55
scottdamriedem: I'll have to look at that one. I think the None, None is dealt with in the calling code. Not that that is the best way to do it...14:55
*** markstur has joined #openstack-cinder14:56
jgriffithI'll let scottda look at if he wishes to do so14:56
*** markstur has quit IRC14:56
*** markstur has joined #openstack-cinder14:57
*** markstur has quit IRC14:57
mriedemscottda: it won't return a tuple14:57
mriedemit will return none14:57
mriedemNone14:57
mriedemwhich will break here https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/api_versions.py#L25414:57
mriedembecause it can't unpack None into a tuple14:57
jgriffithaka vomit14:57
mriedemi'm trying to figure out what the best way, as a client (nova), to determine if we can do a given microversion, and i'm lost between several different methods in the cinderclient code14:58
mriedemthere is get_highest_version https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/api_versions.py#L24714:58
mriedemdiscover_version https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/api_versions.py#L25914:58
mriedemand get_server_version https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/client.py#L7414:58
mriedemoh and get_highest_client_server_version14:58
*** arahal_ has joined #openstack-cinder14:59
smcginnismriedem: Usually bswartz would have jumped in by now, so I'll play the part.14:59
mriedemwe'll use that to set the global in nova's volume api client and key off that to know if we can do new attachment stuff14:59
smcginnismriedem: What about just callingn the new API and handling the failure to know it's not supported?14:59
scottdajgriffith: Feel free to put up a patch if you'd like. I may not get to it until later...15:00
scottdaStill trying to get some cycles for this.15:00
scottdamriedem: Sorry if the documentation isn't clear on the version calls. Depends on whether you have the keystone service catalog available...15:01
mriedemscottda: we do have the url15:01
scottdayup15:02
mriedemsmcginnis: b/c i don't know how that's going to fail15:02
mriedemwill it 404? and does that 404 mean the microversion doesn't exist or that the volume on which we tried to create the attachment doesn't exist?15:02
*** markstur has joined #openstack-cinder15:03
smcginnisscottda: What's the return if you specify a microversion that isn't supported? I didn't think it was a 404.15:03
*** isaacb has joined #openstack-cinder15:04
scottdaIf it's < v3, the microversion header is ignored.15:04
mriedemscottda: https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L8115:04
* mordred heads people are talking about consuming versions15:04
scottdaSo depends on if the call exists in v2 or not15:04
*** hoonetorg has quit IRC15:04
*** kfarr has joined #openstack-cinder15:04
mordredscottda, smcginnis: SO - if y'all haven't read it yet, https://review.openstack.org/#/q/status:open+project:openstack/api-wg+branch:master+topic:version-discovery15:04
scottdaif v3, It returns something meaningful, but I don't recall the details.15:05
mordredis the write up that attempts to describe how to consume versions and microversions consistently across all openstack services with both modern state and history accounted for15:05
mordredit would be great if y'all could verify it's not missing any corner cases (I'll also go read this scrollback)15:05
mordredAND15:05
*** wxy| has joined #openstack-cinder15:05
mordredI've got patches to ksa implemeting the logic up for review as well15:05
scottdaThanks. I'll have a look at those mordred15:06
mriedemmordred: so basically this http://docs-draft.openstack.org/10/459710/13/check/gate-api-wg-docs-ubuntu-xenial/7a8995b//doc/build/html/guidelines/consuming-version-discovery.html15:06
smcginnismordred: Thanks, I was aware there was work being done, but haven't kept up with the latest.15:06
mordredso end-goal of that woul dbe that cinderclient ceases having any local logic handling either major version discovery or finding availble microversions15:06
mriedemright?15:06
mordredmriedem: yes15:06
mordredmriedem: also consuming-catalog.html ... becauseyou can't do discovery until you've got the endpoint from the catalog15:07
mordredbut for this convo, consuming-version-discovery.html is the one15:07
mriedemmordred: nova, as the client, has the endpoint here https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L8115:07
mriedemthat's by default the volumev3 endpoint15:08
mordredmriedem: right. well, that changes too - which is why the consuming-catalog part is important to grok and get implemented15:08
mriedemis that related to what efried is working on in nova?15:08
mordredyes, it is15:08
mordred"I want block-storage v3" should properly find volumev3 if that's what's in the catalog once we're done15:09
mordredand should also find the v3 endpoint if the catalog has block-storage15:09
openstackgerritMerged openstack/cinder master: Do proper cleanup if connect volume fails  https://review.openstack.org/45945315:09
mordredand in both cases should return microversion ranges if they exist15:09
*** diablo_rojo has joined #openstack-cinder15:10
mordredit's a long thread to pull on - but we're actually very close to actually having one impl that works for all the cases that we can all use - which should be really exciting15:10
mordredmriedem: with the ksa patches, instead of "session.get_endpoint" that efried code will call "session.get_endpoint_data" which will return a thing that has the endpoint url - but also the min/max microversions15:11
mordredmriedem: so from the nova side, you can do the normal microversion consume logic however you want - but you can know you will have the data15:11
scottdamriedem: So, I think get_highest_version is probably how you'd call cinder for the version info.15:12
*** kaisers has quit IRC15:13
mriedemscottda: that takes a client15:14
mordredyah - and once we have the ksa patch landed, "get_server_version" can call session.get_endpoint_data and get_highest_client_server_version can call that and grab the microversions - so the using thatshould be upwards compat15:14
mriedemi want to create the client based on the version i know i need (3.27)15:14
bswartzsmcginnis: ?15:15
mriedemscottda: because i want to create the client with 3.27 so that all requests are made using 3.27, not 3.015:15
scottdamriedem: But you want to query cinder first to see if the version is >= 3.27 first?15:15
mriedembut, we could go either way15:15
mriedemscottda: i want to see if 3.27 is available15:15
smcginnisbswartz: I tried being you on how you usually argued microversions should be consumed, but I just don't have the same fire. :)15:15
mriedemwhich i think i can do with get_highest_client_server_version15:15
scottdamriedem: Yes, I think so.15:16
mriedemversion discovery in cinder doesn't require a token does it?15:16
mordredyes. I agree15:16
mordredand no, it doesn't15:16
scottdamriedem: No15:16
mriedemok15:16
mriedemwhew15:16
bswartzit's okay to query for supported microversions, but it's faster to optimistically try the highest version you know about and negotiate down on failure15:16
dfishergood morning!  could I hassle somebody to give https://review.openstack.org/#/c/466397/ a +A?  I've got two +2s and the corresponding 3rd party ran successfully so things should be aligned to merge (I hope)15:16
mriedembswartz: knowing what the failure is is the hard part15:16
bswartzmicroversion too high should be a pretty obvious error response15:16
*** hoonetorg has joined #openstack-cinder15:17
mriedembswartz: it's not obvious to any of the cinder cores in channel right now :)15:17
bswartzif not then that should be fixed15:17
mriedemif it's a 404 or not15:17
mriedemand don't tell me to rely on parsing the error message from the 404 to know the difference :)15:17
scottdamriedem: Not obvious from memory. Sorry, have had to step back from the project.15:17
mordredso, there is ALSO work afoot to improve the efficiency of version querying - I'd suggest writing it to do the query and let the improvement to the process flow via the keystoneauth updates15:17
mordredbecause once that's in place, trying a version, failing and then querying will be less efficient15:18
*** mvk has quit IRC15:19
mordredmriedem: so I'd use get_highest_client_server_version for now. when ksa update 1 is out we can update cinderclient to use it. then when update 2 exists, it'll just magically get it and your flow will be clear and understandable15:19
bswartzmordred: it doesn't matter if it's less efficient if it's the uncommon case15:19
bswartzthe common case is that the client versions matches the server version -- that's what should be optimized15:19
mordredbswartz: just saying - this is eing solved generally for all API consumers - there is no need to code around it specifically in nova15:19
mriedemi will hack a bit15:20
mordredand doing so makes nova's consumption of the api more brittle15:20
mordredbecause there are times when it actually won't match15:20
bswartzthing that can be done in 1 round trip should always be done in 1 round trip15:20
mordredyes15:20
mordredwhich is what the end result will be15:20
mriedemsure but again as a client i don't know how this is going to fail if 3.27 isn't supported on the server15:21
mordredwhich is why I'm saying flow it through ksa and you'll get there correctly for free and will degrade gracefully for non-standard cases15:21
bswartzI don't see a way to get 1 round trip without optimistically trying the highest version you know about15:21
bswartznot unless you have stateful clients (YUCK)15:22
mordredbswartz: I'll point you at the cloud profile spec as soon as I update it from latest feedback - but there was a session on this at the summit15:22
bswartzmordred: that would be appreciated15:22
mordredbswartz: tl;dr is "single global etag-supporting extremely cacheable profile document for a cloud that contians all of the contents of all of the version discovery documents" - client fetches profile once when they first interact with cloud, no more round trips needed. when it changes, etag in catalog will be updated so that a client can know just from the token that they need to refresh the cached15:24
mordredcopy of the profile15:24
mordredbswartz: so after the very first api negotiation with the cloud, all version information can be used proactively without incurring additional round-trips15:24
bswartzmordred: yeah but your first API call is still 2 round trips...15:25
mordredbswartz: yes. your first API to the cloud ever15:25
bswartzmordred: how do you detect that the server has been upgraded?15:25
scottdahttps://www.irccloud.com/pastebin/qwW36dx3/15:25
scottdamriedem: ^^^15:25
mordredbswartz: etag in the token15:25
scottdaThat's for a cinder server with v3, but too high a version15:26
mriedemscottda: computeFault ? :)15:27
mordredbswartz: that will tell you if your cached copy of the profile is out of date - so you'll have an extra roundtrip once after a server version update - but the libs can handle that for you transparently15:27
scottdaHit v2 endpoint and it get's you the volume list (in the case of that command/curl) without error15:27
scottdamriedem: I'm not saying that's the correct return, I'm saying that's what the return is.15:27
bswartzmordred: so if the admin upgraded cinder since my last REST API call, the next API call will get a response that tells me that I'm using a version that not the newest?15:27
mriedemscottda: i know. 406 is the point.15:27
scottdamriedem: I don't recall the details, but I'm almost certain I copied the code from someone else.15:28
scottda:)15:28
scottdaManila or Nova15:28
mordredbswartz: the next time you get a token, you'll get an updated value and you can then go fetch a new doc15:28
scottdaNot to shirk responsibilty...15:28
bswartzmordred: does that time have an upper bound?15:28
bswartzto limit the maximum time a client uses an old API version?15:29
mordredtoken age15:29
mriedemscottda: looks like nova is similar15:29
mordredwhich is usually an hour or less iirc15:29
bswartzk15:29
mordredbswartz: in any case, I'll get the profile spec updated today and send it your way for review15:30
mordredbswartz: this is an issue across all api consumers - and we've been hacking and avoiding all of our discovery info for ages because of the double-api hit fear15:30
mordredwhich has made all of the clients unusably brittle15:30
mordredwhich is sad - given there is excellent data availabe so they don't have to be brittle15:31
*** zhaochao has quit IRC15:31
mordredso it's important we solve this well15:31
mriedemfound another issue in cinderclient which could be nasty https://github.com/openstack/python-cinderclient/blob/2.1.0/cinderclient/api_versions.py#L24715:32
mriedem^ calls _get_server_version_range15:32
mriedemwhich calls client.services.server_api_version()15:32
mriedembut server_api_version() is only implemented on the cinderclient.v3.client.services manager15:32
mriedemit'll be an AttributeError on v1 or v2 clients15:32
jgriffithhouse of cards15:32
mriedemi guess the docstring says "Queries the server version info and returns highest supported microversion" which implies it should be a v3 client15:33
mriedemi might push a patch for that though15:33
jgriffithmaybe I can just load up an old Cinder later today and ferret some of this out15:34
jgriffithunless somebody else is on it15:34
*** aarefiev is now known as aarefiev_afk15:34
bswartzmordred: I agree that clients which are willing to store state should have a very robust way to know what version to use -- my only worry is that clients which want or need to be stateless should be allowed to optimistically try their request at a version of their choice before falling back to a more robust path using some kind of negotiation15:35
mordredbswartz: any client should absolutely be able to try that15:36
scottdamriedem: Yes, those client tools were written under the assumption nova would first call:15:37
scottda     url = _SESSION.get_endpoint(auth, **service_parameters)15:37
mordredbswartz: I'm mostly just saying that keystoneauth, gophercloud, fog, openstack4j, jclouds and php-opencloud at least are all going to grow the ability to transparently handle this - and since nova is using cinderclient which uses keystoneauth - if nova just uses the methods to ask for the data up front, nova will get corect data now and will get that correct data more efficiently in the not too15:37
mordreddistant future15:37
scottdaAnd therefore know which version (v1,v2,v3) cinder was using15:37
scottdai.e. I went down this path: https://review.openstack.org/#/c/385682/3/nova/volume/cinder.py15:37
scottdamriedem: I get that you may not want to use the keystone session to get the endpoint version. That seemed like the way to go for me.15:40
*** lpetrut has quit IRC15:47
openstackgerritwangxiyuan proposed openstack/cinder master: Return metadata in volume summary  https://review.openstack.org/45914315:50
openstackgerritJohn Griffith proposed openstack/python-cinderclient master: cinderclient might not return version for V2 API  https://review.openstack.org/46952015:56
*** ryanender has joined #openstack-cinder15:56
openstackgerritMatt Riedemann proposed openstack/python-cinderclient master: Handle AttributeError in _get_server_version_range  https://review.openstack.org/46954515:56
*** cebruns has joined #openstack-cinder15:57
* jgriffith goes to put pants on before meeting16:00
jgriffithtoo cold for shorts16:00
mriedemsmcginnis: looks like you need to create an ocata series for python-cinderclient in LP https://bugs.launchpad.net/python-cinderclient/+bug/1694729/+nominate16:01
openstackLaunchpad bug 1694729 in python-cinderclient "get_server_version does not handle older (non-v3) servers" [Medium,In progress] - Assigned to John Griffith (john-griffith)16:01
*** Apoorva has joined #openstack-cinder16:03
*** Apoorva has quit IRC16:03
mriedemjgriffith: ildikov: so i'll float 2 options by you for handling 3.27 when creating an attachment in nova,16:05
*** winston-d_ has joined #openstack-cinder16:05
*** Apoorva has joined #openstack-cinder16:05
mriedem1) we discover the max version from the v3 client and key off that in code to see if we should call attachment_create, or16:06
*** david-lyle has quit IRC16:06
mriedem2) when constructing cinderclient v3 client for the attachment_create call, we check if 3.27 is supported and if not, raise some specific error and handle that in the nova code to fallback to the old style16:06
*** rcernin has quit IRC16:07
mriedemonce we create the attachment the new way, we are setting that on the bdm.attachment_id so everything after that just checks bdm.attachment_id, it doesn't need to worry about the microversion checking16:07
mriedemso i'm inclined to think #2 is cleaner16:07
mriedemand that way we don't need a global variable set for the max microversion16:07
*** mnestratov has quit IRC16:07
*** tesseract has quit IRC16:08
jgriffithmriedem I prefer option #2 personally16:08
mriedemme too16:08
mriedemi'll wip something on on that quick to see how it looks16:08
mriedem*up on16:08
jgriffithmriedem thanks16:08
ildikovmriedem: jgriffith: that one sounds good to me too16:08
ildikovmriedem: tnx!16:09
*** kaisers has joined #openstack-cinder16:10
*** david-lyle has joined #openstack-cinder16:14
*** jwcroppe has quit IRC16:16
openstackgerritJohn Griffith proposed openstack/python-cinderclient master: cinderclient might not return version for V2 API  https://review.openstack.org/46952016:22
openstackgerritwangxiyuan proposed openstack/cinder master: Ceph: Fix delete backup with non-existent pool  https://review.openstack.org/46108216:25
openstackgerritGorka Eguileor proposed openstack/cinder master: Allow logging in tempest tests  https://review.openstack.org/46950216:27
openstackgerritGorka Eguileor proposed openstack/cinder master: Add support for OS-Brick force disconnect  https://review.openstack.org/45945416:27
openstackgerritGorka Eguileor proposed openstack/cinder master: Multipath tempest scenarios  https://review.openstack.org/46944516:27
*** mewald has joined #openstack-cinder16:29
*** eharney has quit IRC16:29
*** eharney has joined #openstack-cinder16:31
openstackgerritwangxiyuan proposed openstack/cinder-specs master: Support get volume metadata summary  https://review.openstack.org/46669116:33
openstackgerritMerged openstack/cinder master: GPFS: Fix forceful delete for consistency group  https://review.openstack.org/46876016:35
*** kaisers has quit IRC16:37
openstackgerritMerged openstack/cinder master: ZFSSA: Allow clones to differ in size from parent  https://review.openstack.org/46639716:39
*** mewald has quit IRC16:45
*** Poornima has joined #openstack-cinder16:45
*** rcernin has joined #openstack-cinder16:46
*** mewald has joined #openstack-cinder16:48
*** mvk has joined #openstack-cinder16:49
*** pcaruana has quit IRC16:50
*** kaisers has joined #openstack-cinder16:54
jgriffithdims btw, pushing the snapshot additions to gophercloud today, then possibly the V3 attachment stuff16:55
dimscool jgriffith16:55
jgriffithwill probably be looking at the start you pointed out in the cloud-provider changes next16:55
*** salv-orlando has quit IRC16:55
openstackgerritGorka Eguileor proposed openstack/cinder master: Allow logging in tempest tests  https://review.openstack.org/46950216:56
openstackgerritGorka Eguileor proposed openstack/cinder master: Add support for OS-Brick force disconnect  https://review.openstack.org/45945416:56
openstackgerritGorka Eguileor proposed openstack/cinder master: Multipath tempest scenarios  https://review.openstack.org/46944516:56
openstackgerritWalter A. Boring IV (hemna) proposed openstack/python-brick-cinderclient-ext master: WIP Add new v3 attach/detach workflow  https://review.openstack.org/46959416:56
dimsack jgriffith you know where to find me :)16:57
jgriffithdims indeed :)16:59
*** wxy| has quit IRC16:59
*** gaurangt_ has joined #openstack-cinder16:59
*** mdovgal has joined #openstack-cinder17:00
mewaldIs it right that Cinder with Ceph does not support "cinder migrate"?17:00
*** e0ne has quit IRC17:00
*** dikonoor has joined #openstack-cinder17:00
*** gaurangt- has joined #openstack-cinder17:01
winston-djgriffith: sorry I didn't chime in in the meeting just now.17:02
*** gaurangt has quit IRC17:03
winston-dI'm definitely interested in making Cinder standalone, working perfectly with k8s.17:03
patrickeastanyone have a tl;dr for the force detach connector thing with tempest? i'm trying to resurrect my ci and running into that test failing... trying to figure out where things stood17:03
*** gaurangt_ has quit IRC17:04
*** jwcroppe has joined #openstack-cinder17:04
winston-dWe are moving fast to k8s, by the end of this year, a major part of our applications will be deployed w/ k8s + baremetals.17:05
*** isaacb has quit IRC17:05
winston-dWe still need Cinder 'cos there are a lot of nice stuff we have done in it.17:06
smcginnispatrickeast: We discussed it in a meeting a few weeks back.17:07
*** wN has quit IRC17:07
xyang1winston-d: just Cinder standalone without other openstack components?17:07
smcginnispatrickeast: The agreement at the time was if no connector is provided, the driver should remove all attachments.17:07
patrickeastsmcginnis: yea i'm trying to find the eavesdrop17:07
smcginnispatrickeast: Can't remember even which month that was in now.17:08
patrickeastsmcginnis: oh, interesting17:08
xyang1winston-d: I mean your k8s deployment17:08
patrickeastsmcginnis: so i guess multi-attach is SOL?17:08
smcginnis?17:08
patrickeastif you pass in no connector to cleanup one host, it cleans up all the attachments17:08
patrickeastwhich would probably be the other host it was on?17:09
* patrickeast should probably just keep looking for the meeting notes17:09
smcginnispatrickeast: It shouldn't ever happen in a normal scenario like that.17:09
patrickeastsmcginnis: once (if) we have multi-attach how does the driver know which initiator to clean up the connection for though?17:10
winston-dxyang1: our k8s? we still have keystone, and we use ironic to do BM provisioning17:11
patrickeastsmcginnis: i guess we store more info with the new attach apis...17:11
*** ChubYann has joined #openstack-cinder17:11
patrickeastsmcginnis: i'm just not gonna worry about it :D17:11
xyang1winston-d: ok, just wondering if you still use openstack17:11
smcginnispatrickeast: In normal operation, a connector would be provided for the attachment that needs to be removed.17:11
ildikovpatrickeast: detach is not sorted out with the new API either yet17:11
ildikovpatrickeast: according to jgriffith it's easy though :)17:12
winston-dxyang1: we still have openstack, for sure.17:12
xyang1winston-d: ok, good to know17:13
winston-dwe even have ESX/vCenter running. long long tail.17:13
jgriffithpatrickeast smcginnis are you guys mixing the new attach api's and the old?17:13
jgriffithsorry... was away getting coffee17:13
patrickeastjgriffith: probably17:13
jgriffithbut the pot was empty :(17:13
patrickeastjgriffith: how does the new attach stuff work with force-detach?17:14
patrickeastor does it?17:14
jgriffithpatrickeast there's no such thing as force detach really17:14
jgriffithYou tell cinder "attachment_delete <attachment-id>" cinder deletes that attachment17:14
jgriffithincluding the call to the driver to do what it needs to do17:15
patrickeastyea, that sounds right17:15
smcginnisjgriffith: This is just the old stuff.17:15
patrickeastand cinder has the connector info for the attach so we always have the right params for the driver.... right?17:15
jgriffithsmcginnis no, I'm describing the new stuff17:15
jgriffithpatrickeast yes17:15
jgriffithsmcginnis am I confused?17:15
patrickeastjgriffith: ok cool so thats good17:15
smcginnisjgriffith: Right. I'm answering you're earlier question. We were talking about the old stuff.17:15
smcginnis*your17:16
patrickeastso yea, for the old one the force-detach call doesn't do that17:16
jgriffithpatrickeast so the goal was to access evertyhing by attachment_id so we don't have to worry about the multi-attach case and knowing what's what17:16
patrickeastits just for some volume, and maybe a connector17:16
* jgriffith has moved on... old attach/detach code is dead to him17:16
jgriffithnow if I could just fast fwd 2 years so everybody has it :)17:16
patrickeastthe old api calls will not work on new api attaches, right?17:16
jgriffithpatrickeast not really no17:17
ildikovI might not bring up my confusion with the shared connections stuff with multi-attach at this point17:17
patrickeastlike... if i have (2 years from now) a multi-attached new style attached volume and call force-delete17:17
patrickeastit breaks?17:17
jgriffithildikov *might not* :)17:17
ildikovso that no one wants to kill me :)17:17
patrickeastlol17:17
patrickeastildikov: its ok, all this is hypothetical17:17
jgriffithildikov who would possibly want to kill you?17:17
jgriffith:)17:17
jgriffithpatrickeast so do you mean like attach with the old and detach with the new?17:18
patrickeastmore importantly the other way around17:18
ildikovjgriffith: it just felt like thin ice :)17:18
jgriffithpatrickeast or some other weird frankenstien mix/match17:18
jgriffithattach with new, detach with old?17:18
*** Poornima has quit IRC17:18
patrickeasti guess what i'm trying to decide is if i should change my driver to allow terminate_connection with no connector and to detach *all* attachments17:18
patrickeastjust so it passes the stupid tempest test17:18
jgriffithin theory that *would* work but you're going to be all screwed up17:19
jgriffithAhhhh!17:19
jgriffithpatrickeast if tempest: detach-all17:19
jgriffith:)17:19
patrickeastlol17:19
jgriffithwho wrote the test?17:19
patrickeastdunno17:19
patrickeastbut it works on lvm17:19
patrickeastso its correct, right?17:19
jgriffithof is it that same old force-detach one?17:19
patrickeastright?!17:19
jgriffithLOL17:19
jgriffithwell YES17:19
patrickeastlol17:20
jgriffithno shared connection stuff so life is EZ/PZ17:20
jgriffithpatrickeast you should change how Pure works and make it more like LVM... then all your problems will be solved :)17:20
patrickeastjgriffith: not the worst idea17:20
*** gaurangt has joined #openstack-cinder17:21
patrickeastok, well... i guess i've caused enough trouble with attach apis17:21
patrickeastjgriffith: got a min to talk about gos-brick?17:22
jgriffithpatrickeast so for the tempest test I wouldn't try and mix/match anything to get around it17:22
jgriffithit will likely come back to bight you17:22
patrickeastjgriffith: i'm thinking i'll just turn off the test...17:22
jgriffithalthough notice that the attachment calls are just wrappers to the old stuff17:22
jgriffithpatrickeast +117:22
jgriffiththat's what I'd do honeslty17:22
patrickeastjgriffith: and hope it doesn't show up on some vendors cert list17:22
jgriffithmeh17:22
jgriffithonly on SolidFires :)17:22
jgriffitherr... NetApps17:22
patrickeastlol17:23
jgriffithanyway.. yeah... gos-brick?17:23
patrickeastah yea17:23
hemnagos-brick17:23
patrickeastso, were you thinking of just a kind of port over of os-brick?17:23
*** Julien-zte has quit IRC17:23
patrickeastor an opportunity to make things better?17:23
jgriffithpatrickeast maybe both?17:23
*** gaurangt- has quit IRC17:23
hemnais there a way to wrap python calls in go ?17:24
jgriffithHonestly my initial incling was the rest-server in front of os-brick, but it was pointed out that might not be such a hot idea17:24
*** wN has joined #openstack-cinder17:24
*** wN has quit IRC17:24
*** wN has joined #openstack-cinder17:24
jgriffithto then the idea of actually creating a go version / pkg came up and honestly I think that's a great idea17:24
jgriffithit's something I have always been amazed there isn't something out there for already17:24
hemnaare the FC HBAs even available in a docker/k8s container ?17:24
patrickeastyea, so, i ask because the more time i spend trying to get the attach stuff to work on multiple os's and platforms the more i'm convinced that it isn't something a library with like synchronous attach/detach calls can really work17:25
jgriffithhemna you mean like the old swig style stuff?17:25
jgriffithRun away!!!17:25
hemnaor even the /proc filesystem17:25
patrickeasthemna: yea they can be17:25
hemnayah swig sux0rs, but that's for python calling C17:25
jgriffithpatrickeast yeah, so the idea isn't necessarily a direct port of os-brick, but something that does the same *stuff*17:25
patrickeastjgriffith: what i've been thinking about that would work much much better is a volume service17:25
jgriffithif there's room for improvement along the way then that's awesome17:25
patrickeastand will probably end up with something like that for the pure k8s and docker stuff longer term17:26
jgriffithpatrickeast not sure I track... can you explain more?17:26
patrickeastmore similar to an api call of "i expect this volume to be mounted here, use this info" and then the service makes sure that happens17:26
hemnapart of the problem I see is overcoming the need to access hw interfaces inside the containers17:26
patrickeastthe issue being that over time you need to add/remove paths, update things, etc17:26
jgriffithpatrickeast ahh, and have that be it's own service....17:27
patrickeastplus the workflow is a nightmare with retries and stuff17:27
jgriffithinteresting17:27
patrickeastyea17:27
*** Julien-zte has joined #openstack-cinder17:27
hemnaisn't that what you get with rest + os-brick ?17:27
jgriffithhemna meh, that's not so bad actually17:27
jgriffith--device /dev/*17:27
jgriffith:)17:27
patrickeastyea hw stuff is easy in containers17:27
* jgriffith ducks17:27
xyang1hemna: jgriffith does this look like a FC driver for k8s? https://github.com/kubernetes/kubernetes/tree/master/pkg/volume/fc17:28
patrickeastmake sure you pass through /sys:/sys17:28
jgriffithunless you want to follow the new craze of "don't run privileged" then your SOL :)17:28
patrickeastpff17:28
patrickeastthats crazy talk17:28
hemnaheh17:28
jgriffithxyang1 yeah17:29
jgriffithxyang1 so K8's has iscsi and other *stuffs* built in FWIW17:29
jgriffithxyang1 it's just not nearly as extensive or feature rich as what we've got17:30
xyang1jgriffith: ok17:30
jgriffithpatrickeast crazies are us17:30
patrickeastjgriffith: haha, maybe17:30
hemnamultipath support?17:31
jgriffithanyway, the services idea running in a container/pod etc might be an interesting angle17:31
patrickeasthemna: nope :(17:31
hemnapewp17:31
patrickeastjgriffith: you kinda need something there for like flexvols anyway17:31
jgriffithand probably going to be a requirement at some point17:31
jgriffithpatrickeast yeah17:31
hemnawe need a new multipath daemon.....17:32
hemnathat doesn't suck17:32
patrickeasti guess what i would (very selfishly) like to see is gos-brick either be like a thin helper lib that can do the individual iscsiadm, sys calls, etc, that we can build that service out of, or the actual service17:33
jgriffithpatrickeast so I think the service idea is the right way to go, just trying to wrap my head around what the interface would be and how you'd call it etc17:33
patrickeastwhere its at right now the one-time synchronous api calls to attach aren't as useful to make a robust attacher thingy17:33
jgriffithpatrickeast just link to the pod/container17:33
hemnaso if we want a service, then why not use os-brick behind the rest API ?17:33
jgriffithcall it as an executable... 'attach my-shit here'17:33
hemnaall of those connectors are already there.17:33
patrickeastyea, i mean, it could be pretty flexible and use a REST-like interface or something on a local socket17:34
patrickeastfor cli, or other bins17:34
patrickeastor even a tcp interface17:34
jgriffithsmcginnis pointed out there are some security issues/concerns with that sort of thing17:34
patrickeastala rest+os-brick17:34
jgriffiththe Rest piece that is17:34
patrickeastah, yea, thats good to know17:35
jgriffithTBH the only real problem I have with that approach is it's SOOO HEAVY17:35
patrickeastyea :(17:35
patrickeastthe shitty part is that it seems like it needs to be17:35
jgriffithpatrickeast yeah, that may be the sad reality17:35
patrickeastto hemna's point, we need to like rewrite multipathd to make this junk work17:35
jgriffithwasn't geguileo doing that already :)17:36
patrickeastyea, but for being able to work with a wide variety of systems it needs to work with other versions17:36
jgriffithor stop using multipath :)17:36
patrickeastwell, its not just multipath17:36
jgriffithlalalalalaallallaallaala17:36
patrickeastfrom what i've seen udevd is the real killer17:36
* jgriffith can't hear you17:36
jgriffithdamn it17:36
jgriffithI KNEW you were going there!!!17:36
patrickeastlol17:36
geguileojgriffith: Yeah, I just sent an email to the ML discussing it and with tempest tests to test multipath with error injection17:37
hemnabah!   good luck with not using mpath :P17:37
jgriffithhemna I dunno, I seem to be having better luck not using it than you suckers do using it :)17:39
jgriffithalthough my days are numbered17:39
jgriffithpatrickeast hemna anyway... it would be good to noodle on the gos-brick/rest-brick thing a bit and get some more input from people17:40
jgriffithwhat I meant by heavy earlier was more against the python pieces than anything else17:40
xyang1hemna: a related question.  I somehow remembered FC multipath is auto detected and cannot be turned off by the multipath flag, but it looks like I am wrong.  In the code, it does use the multipath flag to determine whether to use it or not17:40
*** dhinesh has joined #openstack-cinder17:41
xyang1hemna: was this changed when os-brick was first created?17:42
patrickeastjgriffith: sounds good17:42
hemnaxyang1, I think the default was to use mpath if it was on17:44
hemnaor use the iscsi_use_multipath flag originally17:44
xyang1hemna: that is the nova side flag.  It doesn't look like that flag is doing anything though.  It all depends on what is returned from connection info17:48
*** xyang has joined #openstack-cinder17:49
hemnaxyang, the FC driver doesn't try to use mpath if the connector was created with the flag being false17:49
hemnahttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/fibre_channel.py#L18517:49
xyanghemna: I see.  So mpath can be turned off if both flags (in cinder and nova) are set to false17:54
*** cebruns has quit IRC17:56
*** eharney has quit IRC17:56
*** nicolasbock has quit IRC17:58
*** kaisers has quit IRC17:59
*** chlong has quit IRC18:05
*** jsuchome has quit IRC18:09
*** eharney has joined #openstack-cinder18:09
*** cebruns has joined #openstack-cinder18:10
*** chhavi has quit IRC18:17
*** cebruns has quit IRC18:21
*** chlong has joined #openstack-cinder18:22
*** cebruns has joined #openstack-cinder18:36
*** kaisers has joined #openstack-cinder18:37
*** cebruns has joined #openstack-cinder18:38
*** cebruns has quit IRC18:39
*** cebruns has joined #openstack-cinder18:41
*** cebruns has quit IRC18:41
*** cebruns has joined #openstack-cinder18:42
*** cebruns has joined #openstack-cinder18:46
*** dikonoor has quit IRC18:50
*** arnewiebalck_ has joined #openstack-cinder18:59
*** adisky__ has quit IRC19:01
*** gkadam has joined #openstack-cinder19:02
*** arnewiebalck_ has quit IRC19:05
*** arnewiebalck_ has joined #openstack-cinder19:12
*** lucasxu has quit IRC19:13
*** crushil has quit IRC19:14
*** crushil has joined #openstack-cinder19:17
*** bjornar_ has joined #openstack-cinder19:22
*** lpetrut has joined #openstack-cinder19:23
*** pcaruana has joined #openstack-cinder19:45
*** arnewiebalck_ has quit IRC19:47
*** mtanino__ has quit IRC19:52
*** salv-orlando has joined #openstack-cinder20:00
*** pcaruana has quit IRC20:02
*** crushil has quit IRC20:02
*** mnestratov has joined #openstack-cinder20:05
*** liverpooler has quit IRC20:06
*** gkadam has quit IRC20:07
*** gkadam has joined #openstack-cinder20:08
*** e0ne has joined #openstack-cinder20:09
*** salv-orlando has quit IRC20:09
*** salv-orlando has joined #openstack-cinder20:11
e0nemewald: hi. no, migration with ceph backend should work20:13
*** crushil has joined #openstack-cinder20:17
*** crushil has quit IRC20:18
*** crushil has joined #openstack-cinder20:19
*** lucasxu has joined #openstack-cinder20:20
*** rcernin has quit IRC20:21
*** lucasxu has quit IRC20:21
*** rcernin has joined #openstack-cinder20:22
*** crushil has quit IRC20:23
*** crushil has joined #openstack-cinder20:24
*** crushil has quit IRC20:26
*** crushil has joined #openstack-cinder20:27
*** valeska has joined #openstack-cinder20:29
*** crushil has quit IRC20:32
*** crushil has joined #openstack-cinder20:33
valeskahola??20:33
*** kfarr has quit IRC20:35
*** valeska has left #openstack-cinder20:35
*** rcernin has quit IRC20:42
openstackgerritMerged openstack/cinder master: Remove unused _detach_snapshot method  https://review.openstack.org/46949920:49
*** chlong has quit IRC20:53
*** ericyoung has quit IRC20:58
*** jonesn has quit IRC21:00
*** winston-d_ has quit IRC21:00
openstackgerritWalter A. Boring IV (hemna) proposed openstack/python-brick-cinderclient-ext master: Add new v3 attach/detach workflow  https://review.openstack.org/46959421:05
*** Apoorva_ has joined #openstack-cinder21:05
*** chlong has joined #openstack-cinder21:05
*** e0ne has quit IRC21:07
*** Apoorva has quit IRC21:07
openstackgerritxing-yang proposed openstack/python-cinderclient master: Tiramisu: replication group support  https://review.openstack.org/35222921:11
*** pcaruana has joined #openstack-cinder21:12
*** kaisers has quit IRC21:15
*** salv-orlando has quit IRC21:16
*** harlowja has quit IRC21:21
*** pcaruana has quit IRC21:29
*** lpetrut has quit IRC21:30
*** MVenesio has quit IRC21:31
*** MVenesio has joined #openstack-cinder21:31
*** MVenesio has quit IRC21:32
*** abishop has quit IRC21:33
*** ryanender has quit IRC21:34
*** crushil has quit IRC21:39
*** bjornar_ has quit IRC21:40
*** eharney has quit IRC21:42
*** kaisers has joined #openstack-cinder21:45
*** jbernard has quit IRC21:47
*** mewald has quit IRC21:49
stvnoyesi'm using devstack and just updated nova/cinder/etc to latest master. I am hitting this exception a lot- AttributeError: 'RequestContext' object has no attribute 'global_id' any idea why my context obj now needs an id?21:50
stvnoyesthis is being thrown by the cinder client21:51
*** jbernard has joined #openstack-cinder21:53
*** felipemonteiro has quit IRC21:53
*** Apoorva_ has quit IRC21:54
*** Apoorva has joined #openstack-cinder21:54
*** Apoorva has quit IRC21:54
ildikovhmm, I don't recall that one21:54
*** Apoorva has joined #openstack-cinder21:55
*** xyang has quit IRC21:56
*** Apoorva_ has joined #openstack-cinder21:57
*** Apoorva has quit IRC21:57
ildikovalthough I had issues with openrc at some point, repeating the command seemed to solve it, no idea what happened there :/21:58
*** felipemonteiro has joined #openstack-cinder21:58
*** xyang has joined #openstack-cinder21:59
*** felipemonteiro__ has joined #openstack-cinder21:59
*** edmondsw has quit IRC22:01
*** edmondsw has joined #openstack-cinder22:01
*** felipemonteiro has quit IRC22:03
*** edmondsw_ has joined #openstack-cinder22:03
hemnaunset OS_AUTH_TYPE22:04
*** edmondsw has quit IRC22:05
*** harlowja has joined #openstack-cinder22:06
*** edmondsw_ has quit IRC22:07
*** felipemonteiro__ has quit IRC22:08
ildikovhemna: I did that, had to look up the channel logs though, but I finally found it :)22:08
stvnoyeshemna: OS_AUTH_TYPE wasn't set in my env.22:12
*** gouthamr has quit IRC22:20
*** dfisher has quit IRC22:23
*** xyang1 has quit IRC22:28
*** edmondsw has joined #openstack-cinder22:31
*** edmondsw has quit IRC22:35
*** jose-phi_ has quit IRC22:42
*** jwcroppe has quit IRC22:48
*** jose-phillips has joined #openstack-cinder22:50
*** xyang has quit IRC22:57
*** ekoorjr has joined #openstack-cinder22:59
*** chlong has quit IRC23:00
*** xyang has joined #openstack-cinder23:02
*** mnestratov has quit IRC23:02
*** gouthamr has joined #openstack-cinder23:11
*** nicolasbock has joined #openstack-cinder23:16
*** liverpooler has joined #openstack-cinder23:36
*** Julien-zte has quit IRC23:37

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!