Thursday, 2016-08-18

*** thumpba_ has joined #openstack-cinder00:03
patrickeastwtf is all this neutron crap breaking my devstack :/00:03
*** julim has quit IRC00:03
*** thumpba has quit IRC00:05
*** yangyapeng has quit IRC00:06
*** Julien-zte has joined #openstack-cinder00:08
*** leeantho has quit IRC00:09
bswartzpatrickeast: if neutron didn't break devstack then who else would?00:14
patrickeasthah00:14
patrickeastbswartz: me, if it would get far enough :p00:14
*** bswartz has quit IRC00:17
*** raunak has quit IRC00:18
*** mriedem has joined #openstack-cinder00:18
*** laughterwym has joined #openstack-cinder00:18
*** laughter_ has joined #openstack-cinder00:22
*** laughte__ has joined #openstack-cinder00:22
*** Julien-zte has quit IRC00:22
*** laughterwym has quit IRC00:25
*** bwallis has quit IRC00:25
*** laughter_ has quit IRC00:26
*** bswartz has joined #openstack-cinder00:32
*** sdake has joined #openstack-cinder00:35
*** Suyi has quit IRC00:44
*** lixiaoy1 has joined #openstack-cinder00:47
*** jamielennox is now known as jamielennox|away00:48
*** gus has joined #openstack-cinder00:48
*** raunak has joined #openstack-cinder00:53
*** cheneydc has joined #openstack-cinder00:55
*** cheneydc has quit IRC00:56
*** xyang has joined #openstack-cinder00:58
*** sdake has quit IRC00:59
openstackgerritzhangyanxian proposed openstack/cinder: Fix typo in the huawei_driver.py  https://review.openstack.org/34027600:59
*** xyang has quit IRC00:59
*** bwallis has joined #openstack-cinder01:00
*** bardia has quit IRC01:01
*** bardia has joined #openstack-cinder01:02
*** sdake has joined #openstack-cinder01:02
*** bardia has quit IRC01:03
*** jamielennox|away is now known as jamielennox01:04
*** cdelatte has joined #openstack-cinder01:06
*** sdake has quit IRC01:11
*** chrichip has joined #openstack-cinder01:19
*** yangyapeng has joined #openstack-cinder01:21
*** ducttape_ has joined #openstack-cinder01:23
*** ducttape_ has quit IRC01:23
*** ducttape_ has joined #openstack-cinder01:23
*** gouthamr_ has joined #openstack-cinder01:28
*** campee has joined #openstack-cinder01:29
*** EinstCrazy has joined #openstack-cinder01:32
*** gouthamr has quit IRC01:32
*** EinstCrazy has quit IRC01:32
*** EinstCra_ has joined #openstack-cinder01:33
*** bardia has joined #openstack-cinder01:37
*** Lee1092 has joined #openstack-cinder01:37
*** alonma has joined #openstack-cinder01:38
*** edmondsw has quit IRC01:40
campeedoes anyone know of a good document that describes what the architecture of a SAN used with Cinder should look like?01:41
campeei'm a little confused as to whether or not each compute host would need to access the storage through a cinder host or whether they can just talk to it directly. i assume they can talk to it directly, but i'm not sure what that would look like01:42
*** alonma has quit IRC01:43
*** Krenair has left #openstack-cinder01:43
*** takedakn has joined #openstack-cinder01:44
*** Asaithambi has joined #openstack-cinder01:44
*** alonma has joined #openstack-cinder01:46
*** delattec has joined #openstack-cinder01:47
openstackgerritSean McGinnis proposed openstack/python-cinderclient: Update the home-page with developer documentation  https://review.openstack.org/31723201:47
*** raunak has quit IRC01:48
*** bardia has quit IRC01:49
*** cdelatte has quit IRC01:49
*** haplo37__ has joined #openstack-cinder01:50
*** alonma has quit IRC01:51
*** takedakn has quit IRC01:51
*** thumpba_ has quit IRC01:52
openstackgerritxianming.mao proposed openstack/python-cinderclient: Update the homepage with developer documentation page  https://review.openstack.org/35469801:53
*** alonma has joined #openstack-cinder01:53
openstackgerritxianming.mao proposed openstack/cinder-specs: Replace the homepage with developer documentation page  https://review.openstack.org/35467501:56
*** cknight has joined #openstack-cinder01:57
*** Apoorva has quit IRC01:57
*** alonma has quit IRC01:58
*** bill_az has quit IRC01:58
*** alonma has joined #openstack-cinder02:00
*** tbarron is now known as tbarron|afk02:00
*** EinstCrazy has joined #openstack-cinder02:03
*** ducttape_ has quit IRC02:04
*** alonma has quit IRC02:05
*** EinstCra_ has quit IRC02:07
*** alonma has joined #openstack-cinder02:08
*** delattec has quit IRC02:09
*** neophy has joined #openstack-cinder02:13
*** chrichip has quit IRC02:13
*** alonma has quit IRC02:13
*** delattec has joined #openstack-cinder02:14
*** chrichip has joined #openstack-cinder02:15
*** diogogmt has joined #openstack-cinder02:17
*** mriedem has quit IRC02:18
*** diogogmt has quit IRC02:18
*** bardia has joined #openstack-cinder02:20
*** laughte__ has quit IRC02:20
*** laughterwym has joined #openstack-cinder02:20
*** haplo37__ has quit IRC02:20
*** ebalduf has quit IRC02:21
*** thumpba has joined #openstack-cinder02:23
*** ducttape_ has joined #openstack-cinder02:23
*** EinstCra_ has joined #openstack-cinder02:27
*** yangyape_ has joined #openstack-cinder02:27
*** Asaithambi has quit IRC02:28
*** yangyapeng has quit IRC02:28
*** EinstCrazy has quit IRC02:29
*** Asaithambi has joined #openstack-cinder02:38
*** zhangguoqing has joined #openstack-cinder02:41
*** jamielennox is now known as jamielennox|away02:42
*** coolsvap has joined #openstack-cinder02:45
*** chrichip has quit IRC02:45
*** Asaithambi has quit IRC02:46
*** takedakn has joined #openstack-cinder02:46
*** chrichip has joined #openstack-cinder02:47
*** ducttape_ has quit IRC02:48
openstackgerritDao Cong Tien proposed openstack/cinder: Stop using mox in unit/api/v3/ tests  https://review.openstack.org/35684102:50
*** ducttape_ has joined #openstack-cinder02:50
*** ducttape_ has quit IRC02:58
*** julim has joined #openstack-cinder03:05
*** delattec has quit IRC03:06
*** jamielennox|away is now known as jamielennox03:07
*** thumpba has quit IRC03:15
*** raunak has joined #openstack-cinder03:16
*** julim has quit IRC03:19
*** coolsvap is now known as _coolsvap_03:21
*** bardia has quit IRC03:24
*** raunak has quit IRC03:25
*** raunak has joined #openstack-cinder03:30
openstackgerritSoffie Huang proposed openstack/cinder: Add a missing option for iSCSI multipath in FalconStor FSS driver  https://review.openstack.org/35583603:33
*** gouthamr_ has quit IRC03:34
openstackgerritMerged openstack/cinder: Imported Translations from Zanata  https://review.openstack.org/35624803:34
openstackgerritMerged openstack/cinder: Revise Synology DSM storage driver  https://review.openstack.org/34134503:35
*** ArsenC has quit IRC03:36
openstackgerritLisaLi proposed openstack/cinder: Fix the interface to call update_server_volume  https://review.openstack.org/35685003:40
*** yangyapeng has joined #openstack-cinder03:40
*** raunak has quit IRC03:41
*** yangyape_ has quit IRC03:44
*** links has joined #openstack-cinder03:45
*** raunak has joined #openstack-cinder03:45
*** takedakn has quit IRC03:46
*** pbandark has joined #openstack-cinder03:51
*** shausy has joined #openstack-cinder03:56
*** Asaithambi has joined #openstack-cinder03:57
*** ducttape_ has joined #openstack-cinder03:58
*** pbandark is now known as pbandark`brb04:02
*** bill_az has joined #openstack-cinder04:03
*** ducttape_ has quit IRC04:03
*** neophy has quit IRC04:19
*** neophy has joined #openstack-cinder04:26
*** bardia has joined #openstack-cinder04:28
openstackgerritDao Cong Tien proposed openstack/cinder: Stop using mox in unit/api/contrib/ tests (1)  https://review.openstack.org/35685604:28
*** lixiaoy1 has quit IRC04:33
*** lixiaoy1 has joined #openstack-cinder04:36
openstackgerritDao Cong Tien proposed openstack/cinder: Stop using mox in unit/api/contrib/ tests (end)  https://review.openstack.org/35685904:41
openstackgerritDao Cong Tien proposed openstack/cinder: Stop using mox in unit/api/contrib/ tests (1)  https://review.openstack.org/35685604:41
openstackgerritDao Cong Tien proposed openstack/cinder: Stop using mox in unit/api/v2/ tests  https://review.openstack.org/35634704:43
*** hemna__ has joined #openstack-cinder04:53
*** chrichip has quit IRC04:53
*** chrichip has joined #openstack-cinder04:53
*** hemna__ has quit IRC04:54
*** hemna__ has joined #openstack-cinder04:54
openstackgerritMerged openstack/cinder: Enhance api_microversion doc  https://review.openstack.org/33144704:56
*** narayrak has joined #openstack-cinder04:59
*** ducttape_ has joined #openstack-cinder05:00
*** narayrak has quit IRC05:02
*** ducttape_ has quit IRC05:04
*** laughter_ has joined #openstack-cinder05:07
*** cknight has quit IRC05:08
*** laughterwym has quit IRC05:10
*** raunak has quit IRC05:12
*** raunak has joined #openstack-cinder05:16
*** raunak has quit IRC05:22
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35686705:25
*** rajinir has quit IRC05:35
*** alonma has joined #openstack-cinder05:42
*** laughter_ has quit IRC05:44
*** laughterwym has joined #openstack-cinder05:45
openstackgerritwanghao proposed openstack/cinder: Backup tenant attribute support  https://review.openstack.org/25837405:45
*** alonma has quit IRC05:47
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35686705:49
*** alonma has joined #openstack-cinder05:50
openstackgerritKarthik Prabhu Vinod proposed openstack/cinder: WIP, DNM: multinode partial grenade testing  https://review.openstack.org/35301405:52
openstackgerritwanghao proposed openstack/cinder: Support to query volume filter by change since/before  https://review.openstack.org/35268805:53
*** lixiaoy1 has quit IRC05:53
*** lixiaoy1 has joined #openstack-cinder05:54
*** alonma has quit IRC05:55
*** alonma has joined #openstack-cinder05:58
*** bardia has quit IRC05:59
*** lkuchlan has joined #openstack-cinder05:59
*** bardia has joined #openstack-cinder05:59
*** ducttape_ has joined #openstack-cinder06:01
*** alonma has quit IRC06:02
*** hemna__ has quit IRC06:02
*** lkuchlan_ has joined #openstack-cinder06:04
*** ducttape_ has quit IRC06:05
openstackgerritwanghao proposed openstack/cinder-specs: Transfer snapshots with volumes  https://review.openstack.org/31983106:07
*** lkuchlan has quit IRC06:07
*** lkuchlan_ has quit IRC06:08
*** neophy has quit IRC06:08
*** lkuchlan has joined #openstack-cinder06:08
*** lkuchlan is now known as lkuchlan_wfh06:08
*** bardia has quit IRC06:12
*** rcernin has joined #openstack-cinder06:12
*** alonma has joined #openstack-cinder06:14
*** alonma has quit IRC06:18
*** lpetrut has joined #openstack-cinder06:18
openstackgerritSoffie Huang proposed openstack/cinder: Refactoring FalconStor FSS storage driver  https://review.openstack.org/35583606:19
*** alonma has joined #openstack-cinder06:21
*** alonma has quit IRC06:26
*** alonma has joined #openstack-cinder06:28
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata  https://review.openstack.org/35695606:30
*** arecknag has joined #openstack-cinder06:30
*** alonma has quit IRC06:33
*** alonma has joined #openstack-cinder06:44
*** takedakn has joined #openstack-cinder06:44
*** alonma has quit IRC06:49
*** takedakn has quit IRC06:49
*** bill_az has quit IRC06:49
openstackgerritMerged openstack/cinder: Specify key algorithm and size for create_key  https://review.openstack.org/25150306:49
*** pcaruana has joined #openstack-cinder06:52
openstackgerritGuy Kim proposed openstack/cinder: ITRI DISCO cinder volume driver  https://review.openstack.org/34710006:54
*** gaurangt has joined #openstack-cinder06:55
*** takedakn has joined #openstack-cinder06:56
*** ducttape_ has joined #openstack-cinder07:02
openstackgerritGuy Kim proposed openstack/cinder: ITRI DISCO cinder backup driver  https://review.openstack.org/34931807:06
*** ducttape_ has quit IRC07:07
*** xek__ has quit IRC07:08
*** lpetrut has quit IRC07:11
openstackgerritEllen Leahy proposed openstack/python-cinderclient: Changed backup-restore to accept backup name  https://review.openstack.org/35277807:14
*** tesseract- has joined #openstack-cinder07:17
*** e0ne has joined #openstack-cinder07:18
*** EinstCra_ has quit IRC07:18
*** lkuchlan_wfh has quit IRC07:20
*** ManishD has joined #openstack-cinder07:22
*** EinstCrazy has joined #openstack-cinder07:34
openstackgerritArnon Yaari proposed openstack/cinder: New cinder driver to support INFINIDAT InfiniBox  https://review.openstack.org/35698607:36
*** nkrinner_afk has quit IRC07:39
openstackgerritMatan Sabag proposed openstack/cinder: Changes stats report for ScaleIO driver  https://review.openstack.org/35612007:41
openstackgerritLisaLi proposed openstack/cinder: Attachment lost after migrating in-use volume  https://review.openstack.org/35699207:45
openstackgerritLisaLi proposed openstack/cinder: Attachment lost after migrating in-use volume  https://review.openstack.org/35699207:46
*** liverpooler has joined #openstack-cinder07:48
*** Asaithambi has quit IRC07:49
*** Asaithambi has joined #openstack-cinder07:49
*** nkrinner_afk has joined #openstack-cinder07:52
*** vladani has joined #openstack-cinder07:54
*** alonma has joined #openstack-cinder07:57
*** akapil has joined #openstack-cinder07:59
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-cinder08:01
*** Asaithambi has quit IRC08:07
openstackgerritxianming.mao proposed openstack/cinder-specs: Update homepage with developer documentation page  https://review.openstack.org/35700308:09
openstackgerritDavanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c  https://review.openstack.org/30376608:10
*** lennyb has quit IRC08:13
lixiaoy1geguileo: dulek: ping08:14
geguileolixiaoy1: pong08:14
lixiaoy1lixiaoy1: I run into a problem, https://review.openstack.org/#/c/356992/08:15
lixiaoy1geguileo: https://review.openstack.org/#/c/356992/208:15
lixiaoy1geguileo: this is about when to refresh objects etc. I have difficulities to create unit test for such changes08:16
lixiaoy1geguileo: as we don't use real db data in current unit test, so whether refresh or not, can't be checked by the ut08:17
geguileolixiaoy1: We can check the refresh08:17
geguileolixiaoy1: You can mock the method and confirm that it's being called08:17
lixiaoy1geguileo: but may sometime the refresh is not necessary08:17
geguileolixiaoy1: Or if you have mocked the get_by_id method08:17
geguileolixiaoy1: You can return different value for the N call08:18
geguileolixiaoy1: But in unit tests you either need the refresh or you don't08:18
geguileolixiaoy1: And you can test for both cases08:18
geguileolixiaoy1: If it's only called sometimes08:18
geguileolixiaoy1: Why do we need a refresh there?08:19
lixiaoy1geguileo: which line08:19
geguileolixiaoy1: https://review.openstack.org/#/c/356992/2/cinder/volume/manager.py@183008:20
lixiaoy1geguileo: as line 1824 changes volume_attachment of the volume08:20
*** EinstCra_ has joined #openstack-cinder08:21
geguileolixiaoy1: I would have to review the whole code path08:21
geguileolixiaoy1: But I have the impression this is not the right approach08:21
geguileolixiaoy1: You shouldn't need to refresh that volume there08:21
geguileolixiaoy1: Or save it in the OVO class08:22
lixiaoy1lixiaoy1: I did the test, if no refresh here, volume_attachment will be lost in the volume08:22
*** dosaboy_ has joined #openstack-cinder08:23
*** dosaboy_ has quit IRC08:24
*** dosaboy has quit IRC08:24
geguileolixiaoy1: But that's because we are doing something wrong08:24
geguileolixiaoy1: I'm not saying that the bug doesn't exist08:24
lixiaoy1geguileo: when calling save() of an object, only the obj_get_changes() fields will be updated to db. Correct?08:24
geguileolixiaoy1: Correct08:24
geguileolixiaoy1: You are introducing 2 new DB queries, and one of them is not cheap (the load of a volume)08:25
*** EinstCrazy has quit IRC08:25
geguileolixiaoy1: And I believe that's not necessary08:25
lixiaoy1lixiaoy1: yes, I know. this refresh should not be called. I haven't figured out why it can fix the problem08:26
geguileolixiaoy1: Do you want to keep trying to figure out or do you want me to see if I can fix it?08:26
geguileoAnd propose and alternative?08:27
*** lennyb has joined #openstack-cinder08:28
lixiaoy1lixiaoy1: let me try at first. And if I can't, talk to you tomorrow?08:28
lixiaoy1geguileo: thank you for your help08:28
geguileolixiaoy1: Great!08:28
*** dosaboy has joined #openstack-cinder08:29
*** laughterwym has quit IRC08:34
*** laughterwym has joined #openstack-cinder08:35
*** laughter_ has joined #openstack-cinder08:36
*** takedakn has quit IRC08:37
*** Asaithambi has joined #openstack-cinder08:38
*** laughterwym has quit IRC08:39
*** lixiaoy1 has quit IRC08:39
*** laughter_ has quit IRC08:40
*** lixiaoy1 has joined #openstack-cinder08:42
*** vbala has joined #openstack-cinder08:49
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Merge two fake drivers into the one FakeLoggingVolumeDriver  https://review.openstack.org/34842808:59
*** dkehn_ has quit IRC09:00
*** ducttape_ has joined #openstack-cinder09:03
openstackgerritLisaLi proposed openstack/cinder: Attachment lost after migrating in-use volume  https://review.openstack.org/35699209:06
*** _coolsvap_ is now known as coolsvap09:06
*** e0ne has quit IRC09:07
*** ducttape_ has quit IRC09:08
openstackgerritLisaLi proposed openstack/cinder: Attachment lost after migrating in-use volume  https://review.openstack.org/35699209:10
*** dkehn_ has joined #openstack-cinder09:19
*** EinstCrazy has joined #openstack-cinder09:28
*** mvk has quit IRC09:29
*** lpetrut has joined #openstack-cinder09:29
*** EinstCra_ has quit IRC09:32
lixiaoy1geguileo: Gorka, thank you for your review. https://review.openstack.org/#/c/356992/4/cinder/objects/volume.py@466 , why not need save after some fields are changed https://review.openstack.org/#/c/356992/4/cinder/objects/volume.py@46309:33
*** alonma has quit IRC09:36
*** laughterwym has joined #openstack-cinder09:37
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Use the ClientHelper class to reduce amount of code  https://review.openstack.org/34727009:41
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Avoid an extra resize later on  https://review.openstack.org/34727109:41
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Do batch delivery  https://review.openstack.org/34727209:41
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Report an error if a snapshot has vanished  https://review.openstack.org/34727309:41
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Avoid duplicated volumes from the error path  https://review.openstack.org/34727409:41
*** laughterwym has quit IRC09:42
*** alonma has joined #openstack-cinder09:44
*** jordanP has joined #openstack-cinder09:47
ManishD@Lisa, does https://review.openstack.org/#/c/356992 is on similar lines on what Wlat is trying here https://review.openstack.org/#/c/312773/09:48
*** alonma has quit IRC09:49
ManishD*Wlat=Walt09:49
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35686709:50
lixiaoy1ManishD: let me check09:50
geguileolixiaoy1: Because we are already saving it here: https://review.openstack.org/#/c/356992/4/cinder/volume/manager.py@183209:50
lixiaoy1ManishD: they are different09:51
ManishDok09:51
*** alonma has joined #openstack-cinder09:51
lixiaoy1geguileo: I see. But I think it is not to safe. As it calls attach_volume, and which may not save volume and refresh.09:53
geguileolixiaoy1: If you think something's not safe around there, that's for another patch  ;-)09:54
geguileolixiaoy1: In this one you are fixing the attachment info part09:54
lixiaoy1ManishD: hemna's patch is to save connection_info during live migration, my patch is to fix attachment lost during migration in-use volume09:54
lixiaoy1geguileo: ok09:54
lixiaoy1geguileo: may I ask you a question about how to put several patches together without rebase?09:55
*** alonma has quit IRC09:55
geguileolixiaoy1: Sure, but I don't know what do you mean without rebase09:56
lixiaoy1geguileo: https://review.openstack.org/#/c/356226/ here is my tempest test09:56
lixiaoy1geguileo: it needs three cinder patches09:56
geguileoDepends-On is for out of the project patches09:57
lixiaoy1geguileo: but these three patches don't depend on each other, so I don't want to rebase them one by the other09:57
geguileolixiaoy1: afaik there's no solution for that09:57
*** akapil has quit IRC09:57
lixiaoy1geguileo: ok, thank you anyway09:57
geguileoYeah, sorry about that :-(09:58
*** alonma has joined #openstack-cinder09:58
lixiaoy1geguileo: :)09:58
geguileoIt's not a very common problem, though I have sometimes wondered what I would do if it happened to me  XD09:58
*** mvk has joined #openstack-cinder09:59
lixiaoy1geguileo: yes it is. as from this tempest such problems are found. And I would like to use tempest test to prove the changes are correct10:00
openstackgerritClenimar Filemon proposed openstack/cinder: Read domain info from context when contacting nova  https://review.openstack.org/33732210:01
geguileolixiaoy1: Oh, wait, your patch was for tempest, not for in-tree tempest tests10:01
*** gcb_ has quit IRC10:02
geguileolixiaoy1: So the Depends-On should work, I think, but only if the patches can be merged without conflict I guess10:02
* geguileo is full of certainty today10:02
*** alonma has quit IRC10:03
lixiaoy1geguileo: yes Depdens-On works. Only I adds three cinder patches in Depends-on, it gave error message.10:03
geguileolixiaoy1: Probably because those patches are in conflict10:03
*** ducttape_ has joined #openstack-cinder10:04
lixiaoy1lixiaoy1: two patches update same file, this may be the reason10:05
*** mvk has quit IRC10:05
lixiaoy1geguileo: thank you. And I am going to leave office. Have a good day10:05
*** sdague has joined #openstack-cinder10:06
geguileolixiaoy1: Thanks, you too10:06
*** lixiaoy1 has quit IRC10:06
*** lixiaoy1 has joined #openstack-cinder10:07
*** ManishD has quit IRC10:08
*** akapil has joined #openstack-cinder10:08
*** ducttape_ has quit IRC10:09
*** laughterwym has joined #openstack-cinder10:11
*** alonma has joined #openstack-cinder10:14
*** alonma has quit IRC10:15
*** alonma has joined #openstack-cinder10:15
*** yangyapeng has quit IRC10:16
*** mvk has joined #openstack-cinder10:20
*** Asaithambi has quit IRC10:28
*** akapil has quit IRC10:29
*** Asaithambi has joined #openstack-cinder10:29
*** EinstCrazy has quit IRC10:32
*** ociuhandu has quit IRC10:33
*** laughterwym has quit IRC10:33
*** laughterwym has joined #openstack-cinder10:34
*** laughterwym has quit IRC10:36
*** laughterwym has joined #openstack-cinder10:37
*** Asaithambi has quit IRC10:37
*** laughterwym has quit IRC10:38
*** laughterwym has joined #openstack-cinder10:38
*** Asaithambi has joined #openstack-cinder10:38
*** laughterwym has quit IRC10:43
*** lpetrut1 has joined #openstack-cinder10:43
*** lpetrut has quit IRC10:45
*** lpetrut1 is now known as lpetrut10:45
*** akapil has joined #openstack-cinder10:48
*** coolsvap is now known as _coolsvap_10:55
*** Asaithambi has quit IRC10:59
*** ducttape_ has joined #openstack-cinder11:05
*** bhagya has quit IRC11:08
*** gaurangt has left #openstack-cinder11:08
*** neophy has joined #openstack-cinder11:08
*** neophy has quit IRC11:09
*** JoseMello has joined #openstack-cinder11:09
*** ducttape_ has quit IRC11:09
*** Linkmark has joined #openstack-cinder11:15
*** GB21 has joined #openstack-cinder11:28
openstackgerritSatish Venkatasubramanian proposed openstack/cinder: Add volumes/summary API support  https://review.openstack.org/33506711:33
*** takedakn has joined #openstack-cinder11:34
vladanihttps://review.openstack.org/#/c/342722/11:36
*** yangyapeng has joined #openstack-cinder11:38
openstackgerritnaga venkata proposed openstack/os-brick: Fixes backup with customized ceph cluster name  https://review.openstack.org/35100511:38
*** takedakn has quit IRC11:39
*** ociuhandu has joined #openstack-cinder11:39
*** laughterwym has joined #openstack-cinder11:40
*** haplo37__ has joined #openstack-cinder11:42
swamireddyvbala: Thanks for review...updated the patch with your comments...https://review.openstack.org/33506711:45
*** laughterwym has quit IRC11:53
*** lprice1 has quit IRC12:03
openstackgerritxianming.mao proposed openstack/cinder: Drop unused logging import  https://review.openstack.org/35715012:03
*** lprice has joined #openstack-cinder12:04
*** kwathore_ has joined #openstack-cinder12:05
*** ducttape_ has joined #openstack-cinder12:06
*** ducttape_ has quit IRC12:08
*** ducttape_ has joined #openstack-cinder12:08
kwathore_HI All,12:09
kwathore_I am getting an error while detaching any iscsi or fc volume from an instance:12:09
kwathore_“DeviceDetachFailed: Device detach failed for vdb: Unable to detach from guest transient domain on”12:09
kwathore_Libvert version:libvirt-daemon-driver-qemu-1.2.17-13.el7_2.5.x86_6412:09
kwathore_ Could anyone help me in this?12:09
*** e0ne has joined #openstack-cinder12:09
*** alyson_ has joined #openstack-cinder12:11
*** edmondsw has joined #openstack-cinder12:15
*** laughterwym has joined #openstack-cinder12:15
*** Julien-zte has joined #openstack-cinder12:19
*** haplo37__ has quit IRC12:21
*** mvk has quit IRC12:21
*** tpsilva has joined #openstack-cinder12:22
openstackgerritzheng yin proposed openstack/cinder: Add command information to cinder-manage.rst  https://review.openstack.org/35716212:24
*** pauloewerton has joined #openstack-cinder12:25
*** ducttape_ has quit IRC12:26
*** gouthamr has joined #openstack-cinder12:26
openstackgerritzheng yin proposed openstack/cinder: Add command information to cinder-manage.rst  https://review.openstack.org/35716212:27
*** laughterwym has quit IRC12:46
*** laughterwym has joined #openstack-cinder12:47
lixiaoy1jgriffith: ping12:50
*** gouthamr is now known as gouthamr_afk12:51
*** e0ne has quit IRC12:52
*** julim has joined #openstack-cinder12:53
*** e0ne has joined #openstack-cinder12:55
*** ducttape_ has joined #openstack-cinder12:56
*** rlrossit has joined #openstack-cinder12:59
*** ducttape_ has quit IRC13:03
*** shausy has quit IRC13:04
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Merge two fake drivers into the one FakeLoggingVolumeDriver  https://review.openstack.org/34842813:04
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Use the ClientHelper class to reduce amount of code  https://review.openstack.org/34727013:09
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Avoid an extra resize later on  https://review.openstack.org/34727113:09
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Do batch delivery  https://review.openstack.org/34727213:09
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Report an error if a snapshot has vanished  https://review.openstack.org/34727313:09
openstackgerritPhilipp Marek proposed openstack/cinder: DRBD: Avoid duplicated volumes from the error path  https://review.openstack.org/34727413:09
*** xyang1 has joined #openstack-cinder13:12
*** xyang has joined #openstack-cinder13:13
*** links has quit IRC13:16
*** thumpba has joined #openstack-cinder13:17
* cFouts gently reminds DuncanT of https://review.openstack.org/#/c/34613513:18
*** Julien-zte has quit IRC13:18
DuncanTcFouts: Hey, I got to that one a few minutes ago!13:19
cFoutshah13:19
cFoutsthanks! sorry for the nag13:19
*** ametts has joined #openstack-cinder13:20
DuncanTcFouts: I'm really starting to think about getting theory-of-operations docs for drivers like netapp... they rely so much on vendor features that I need to keep notes to do the reviews.13:20
*** dustins has joined #openstack-cinder13:20
*** liverpooler has quit IRC13:20
DuncanTcFouts: A short doc on concepts like flexvols and such might be useful?13:21
*** vgridnev has joined #openstack-cinder13:21
vgridnevhello cinder team, do you know something about DSS Cinder CI ?13:22
cFoutsDuncanT: we have the DOG that we generate for each release: http://netapp.github.io/openstack-deploy-ops-guide/mitaka/content/ch_cinder.html  That isn't exactly what you are asking for though. I'll see what I can dig up13:24
openstackgerritLisaLi proposed openstack/cinder: Attachment lost after migrating in-use volume  https://review.openstack.org/35699213:24
*** mriedem has joined #openstack-cinder13:25
*** porrua has joined #openstack-cinder13:26
*** Julien-zte has joined #openstack-cinder13:26
DuncanTcFouts: Some interesting stuff there though, thanks for the link13:26
openstackgerritHussain Chachuliya proposed openstack/cinder: Use min attribute from oslo_config  https://review.openstack.org/35638813:29
*** cknight has joined #openstack-cinder13:29
e0neDuncanT: hi. do you have few minutes to talk about functional tests?13:33
xyange0ne: If we add any new functional tests, they should be dependent on your fake driver patch, right?13:35
*** vgridnev has quit IRC13:36
e0nexyang: yes. we're going to do so13:36
xyange0ne: ok.  I have someone look at the snapshots tests.  I'll let you know if there's any progress on it13:37
e0nexyang: here is patch to devstack https://review.openstack.org/#/c/348449/ to enable fake drivers13:37
xyange0ne: thanks13:37
e0nexyang: I want go get everything in infra before writing tests13:37
xyange0ne: so we should hold off then?13:38
e0nexyang: e.g. I'm working on fixing noauth mode13:38
DuncanTe0ne: Yes13:38
*** akerr has joined #openstack-cinder13:38
e0nexyang: are you talking about cinder or cinderclient tests?13:38
xyange0ne: cinder functional tests.  right now there are some for volume, I asked someone to add tests for snapshot13:38
xyange0ne: if you think we should wait for your patches to land, we can wait13:39
openstackgerritYuriy Nesenenko proposed openstack/cinder: Separate create and update rules for volume metadata  https://review.openstack.org/35662413:39
*** BigWillie has joined #openstack-cinder13:39
e0nexyang: now, functional tests for cinder doen't run cinder services on gates13:39
e0neDuncanT: according to noauth support for functional test: do we need cinderclient support too?13:40
*** pbandark`brb has quit IRC13:40
e0neDuncanT: server-side is broken, but looks like it's easy to fixi t13:41
DuncanTe0ne: If the noauth is done as a fake middleware that has a fixed tenant / password hard coded (or two, one for admin) then the client needs no changes13:41
DuncanTe0ne: We reach into the context in too many places to make the old noauth approach sane, in my estimation13:41
e0neDuncanT: but client uses keystone before any API call13:41
*** ducttape_ has joined #openstack-cinder13:42
*** _coolsvap_ is now known as coolsvap13:42
DuncanTe0ne: Oh, of course it does. Bugger13:43
DuncanTe0ne: Suggestions? You could put a fake keystone client in, since all the keystone stuff goes through that now, but it might be a pain13:44
e0neDuncanT: in current implementation, we have to fix https://github.com/openstack/cinder/blob/master/cinder/api/middleware/auth.py#L129 to pass https://github.com/openstack/cinder/blob/master/cinder/api/openstack/wsgi.py#L89113:45
*** Asaithambi has joined #openstack-cinder13:45
DuncanTe0ne: There's a bunch of reaching into the context object for quota stuff too13:46
e0neDuncanT: yea, I didn't test qoutas with noauth yet13:46
DuncanTe0ne: If noauth can be fixed as it stands, how does that tie in with the client?13:47
*** xyang has quit IRC13:47
*** dustins has quit IRC13:47
*** xyang has joined #openstack-cinder13:49
e0neDuncanT: I'm going to try implement NoAuthPlugin13:50
DuncanTe0ne: I've not looked at the framework there very much, when I was experimenting I just deleted a lot of code from the client until it did what I wanted13:52
e0neDuncanT: :)13:52
DuncanTe0ne: It would be nice if as few codepaths as possible change between noauth and keystone auth13:52
e0neDuncanT: we've got auth_plugin.py module. TBH, I'm not sure if it is supported13:53
DuncanTI'm not sure how practical that is though13:53
DuncanTe0ne: It's not tested, so I'd bet buttons to dollars that it is broken13:53
e0neDuncanT: OK, so in general, getting NoAuthPlugin for client sounds good13:54
*** asselin_ has joined #openstack-cinder13:54
DuncanTe0ne: I guess so, yes. If it ends up requiring substantial work in the main cinderclient code, it might be worth making a fake keystoneclient instead13:54
*** baojg has joined #openstack-cinder13:55
*** asselin has quit IRC13:56
e0neDuncanT: got it. I'll try to get working PoC and submit it to the review13:56
DuncanTe0ne: Awesome. Thanks.13:56
e0neDuncanT: thanks for the help13:56
DuncanTe0ne: You're more then welcome.13:56
*** baojg has quit IRC13:56
DuncanTe0ne: I'll sit here, swear at ansible some more and question my life choices13:56
*** jgregor has joined #openstack-cinder13:57
*** yangyape_ has joined #openstack-cinder13:57
e0neDuncanT: I like the idea of auth plugin, because it could be usable for standalone cinder mode too13:57
DuncanTe0ne: Yup, if it works then great, for sure. In the end, a fake keystoneclient is just a plugin by another name...13:58
e0neDuncanT: yea, but I don't want to fix it each time, when we'll add something to keystoneclient13:59
e0neDuncanT: less dependencies sounds better13:59
DuncanTe0ne: If it's something we rely on from keystoneclient in cinderclient, you'll end up having to do something, even if it is a proxy through the auth plugin14:00
*** yangyapeng has quit IRC14:01
*** EinstCrazy has joined #openstack-cinder14:04
*** arecknag has quit IRC14:04
*** e0ne has quit IRC14:10
*** e0ne has joined #openstack-cinder14:14
hoobamanhi14:15
hoobamanwhy is the qemu-img convert image validation not honouring the volume_dd_blocksize?14:16
*** Julien-zte has quit IRC14:18
*** alonma has quit IRC14:19
*** xinli has joined #openstack-cinder14:24
*** xinli has quit IRC14:24
*** lprice has quit IRC14:25
*** alonma has joined #openstack-cinder14:26
*** haplo37__ has joined #openstack-cinder14:28
*** raunak has joined #openstack-cinder14:28
*** Asaithambi has quit IRC14:28
*** _ducttape_ has joined #openstack-cinder14:28
xyanghoobaman: probably because it needs to convert to raw.  It's the virtual size of the image that matters14:30
*** zhangguoqing has quit IRC14:31
*** ducttape_ has quit IRC14:31
xyanghoobaman: by the way, regarding your question yesterday, I think it has to do with the virtual size of your image14:31
*** alonma has quit IRC14:31
xyanghoobaman: The slowest part is to download the image to a temp location.  It has not reached the backend yet14:32
*** alonma has joined #openstack-cinder14:34
openstackgerritJustin A Wilson proposed openstack/cinder: Added config option to enable SSL  https://review.openstack.org/35295814:34
*** enriquetaso has joined #openstack-cinder14:36
*** jschwarz has joined #openstack-cinder14:38
jschwarzgeguileo, heya :)14:38
*** alonma has quit IRC14:38
*** Julien-zte has joined #openstack-cinder14:39
*** raunak has quit IRC14:41
*** alonma has joined #openstack-cinder14:41
*** Lee1092 has quit IRC14:43
*** Julien-zte has quit IRC14:44
*** alonma has quit IRC14:46
geguileojschwarz: Hi14:46
* geguileo is on a meeting :-(14:47
jschwarzgeguileo, then ping me later :)14:47
geguileojschwarz: Ok14:47
*** xenogear has quit IRC14:47
*** alonma has joined #openstack-cinder14:48
openstackgerritMatan Sabag proposed openstack/cinder: Changes stats report for ScaleIO driver  https://review.openstack.org/35612014:49
*** yangyapeng has joined #openstack-cinder14:49
*** rajinir has joined #openstack-cinder14:50
*** yangyape_ has quit IRC14:50
*** _ducttape_ has quit IRC14:51
*** ducttape_ has joined #openstack-cinder14:52
*** dmellado|off is now known as dmellado14:52
openstackgerritYuriy Nesenenko proposed openstack/cinder: Separate create and update rules for volume metadata  https://review.openstack.org/35662414:53
*** alonma has quit IRC14:53
*** bill_az has joined #openstack-cinder14:54
*** xyang has quit IRC14:55
*** alonma has joined #openstack-cinder14:55
*** xyang has joined #openstack-cinder14:55
*** jgregor has quit IRC14:55
openstackgerritMerged openstack/python-cinderclient: Add "start_version" and "end_version" support to  argparse  https://review.openstack.org/34012914:56
*** jgregor has joined #openstack-cinder14:57
*** gouthamr_afk is now known as gouthamr14:59
*** alonma has quit IRC14:59
*** tbarron|afk is now known as tbarron15:00
*** diablo_rojo has joined #openstack-cinder15:00
*** salv-orlando has joined #openstack-cinder15:00
*** bill_az has quit IRC15:01
*** jungleboyj has joined #openstack-cinder15:01
*** lprice has joined #openstack-cinder15:01
*** xenogear has joined #openstack-cinder15:02
*** Linkmark has quit IRC15:05
*** EinstCrazy has quit IRC15:05
*** jdurgin1 has joined #openstack-cinder15:09
*** dustins has joined #openstack-cinder15:09
*** xinli has joined #openstack-cinder15:10
*** coolsvap is now known as _coolsvap_15:16
smcginnisPike and Queens. Could have been worse. :)15:17
hemnamep15:17
*** IanGovett has joined #openstack-cinder15:19
*** mvk has joined #openstack-cinder15:19
*** mmedvede has quit IRC15:21
*** rcernin has quit IRC15:22
*** laughterwym has quit IRC15:25
Swanson"Pike and Queens. Could have been worse. :)"15:25
SwansonHow far back do I have to scroll for context?15:25
*** laughterwym has joined #openstack-cinder15:25
smcginnisNo context. Just random spewage.15:25
smcginnisIt's like a treasure hunt. :)15:25
*** laughter_ has joined #openstack-cinder15:26
*** laughterwym has quit IRC15:26
*** sdake_ has joined #openstack-cinder15:29
*** IanGovett has quit IRC15:30
*** e0ne has quit IRC15:30
*** mmedvede has joined #openstack-cinder15:34
*** baumann has joined #openstack-cinder15:34
*** dustins has quit IRC15:34
*** leeantho has joined #openstack-cinder15:35
*** diablo_rojo has quit IRC15:35
_alastor_If anyone has a spare moment: https://review.openstack.org/#/c/352533/15:37
hemna_alastor_, looking15:38
_alastor_hemna: Thanks!15:38
*** freerunner has joined #openstack-cinder15:39
*** Apoorva has joined #openstack-cinder15:39
*** diablo_rojo has joined #openstack-cinder15:42
hemna_alastor_, looks good man15:42
hemna_alastor_, one possible addition is to add the @utils.trace decorator to some select functions15:42
hemnait has helped me debug some issues on our driver fwiw15:43
hemnalike initialize_connection, terminate_connection15:43
hemnafor attaches15:43
smcginnis_alastor_: A couple comments there.15:44
_alastor_hemna: I set utils.setup_tracing at the method level with the datera_debug option.  Is that not the same?   I get method input/output in the logs with that.15:44
*** dustins has joined #openstack-cinder15:44
hemnaah ok, so that works automagically then.15:45
hemnacool15:45
hemnaah I see that on 17115:45
_alastor_hemna: Yeah, I think so.  Not sure what black magic they're using for it though ;)15:45
*** mmedvede has quit IRC15:45
hemnathat might be a bit much for the get_manageable_volumes though15:45
hemnabut, that's up to you15:46
_alastor_hemna: True, but it has to be set explicitly and I think it's better to have the option15:46
hemnayah works for me.15:47
*** Asaithambi has joined #openstack-cinder15:47
*** mvk has quit IRC15:50
_alastor_smcginnis: I'm using the deprecated_for_removal keyword arg  in those config options, I just additonally added the (DEPRECATED) string to the help to make it easy for folks reading the source to see15:51
_alastor_smcginnis: Should I remove that?15:51
smcginnis_alastor_: Oops. Nevermind. :)15:52
smcginnisMaybe overkill for the DEPRECATED text in the string, but no harm.15:52
hemnadoesn't oslo config automatically label it as that?15:52
smcginnisYep15:53
*** vbala has quit IRC15:53
_alastor_I can remove it, nbd15:53
openstackgerritMatt Smith (_alastor_) proposed openstack/cinder: Datera driver 2.2 update  https://review.openstack.org/35253315:54
*** Suyi has joined #openstack-cinder15:54
smcginnisYou can see some examples in here: http://docs.openstack.org/developer/cinder/sample_config.html15:54
*** Asaithambi has quit IRC15:57
*** dustins has quit IRC15:57
*** ftersin has joined #openstack-cinder15:59
SwansonWhat were the problem names? Pee and Queue would have been my choices.15:59
*** aleksey8 has joined #openstack-cinder16:02
*** aleksey8 is now known as alekseyruban16:02
openstackgerritArnon Yaari proposed openstack/cinder: New cinder driver to support INFINIDAT InfiniBox  https://review.openstack.org/35698616:02
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: 3PAR use OSLO versioned Object for volume  https://review.openstack.org/33914716:05
*** xyang has quit IRC16:06
openstackgerritMerged openstack/cinder: Handle snapshot delete conflict in 3par driver  https://review.openstack.org/34272216:08
*** laughter_ has quit IRC16:09
*** laughterwym has joined #openstack-cinder16:09
openstackgerritMerged openstack/cinder: NetApp: Add Consistency Group Support for NFS  https://review.openstack.org/34613516:11
*** arch-nemesis has joined #openstack-cinder16:12
*** xyang has joined #openstack-cinder16:13
*** laughterwym has quit IRC16:14
*** sdake_ has quit IRC16:16
*** ametts has quit IRC16:16
*** diablo_rojo has quit IRC16:19
*** jgregor has quit IRC16:19
*** mtanino has joined #openstack-cinder16:20
*** jgregor has joined #openstack-cinder16:20
*** baumann has quit IRC16:21
*** ametts has joined #openstack-cinder16:21
*** jungleboyj has quit IRC16:24
*** tesseract- has quit IRC16:26
*** xyang has quit IRC16:27
*** xyang has joined #openstack-cinder16:29
*** Apoorva has quit IRC16:30
*** bwallis has quit IRC16:34
*** liverpooler has joined #openstack-cinder16:37
*** jungleboyj has joined #openstack-cinder16:37
*** thumpba_ has joined #openstack-cinder16:37
*** thumpba has quit IRC16:39
*** liverpooler has quit IRC16:40
*** jordanP has quit IRC16:43
*** sdake has joined #openstack-cinder16:43
*** sdague has quit IRC16:49
geguileojschwarz: Sorry, I totally forgot to ping you back  :-(16:49
jschwarzgeguileo, oh that's ok, I was in a meeting until just now XD16:50
geguileojschwarz: Great  :-)16:50
*** raunak has joined #openstack-cinder16:50
jschwarzgeguileo, so tooz16:50
jschwarzgeguileo, I've started looking at things and it looks like you guys implemented a few stuff that the tooz guys also implemented concurrently16:51
jschwarzgeguileo, mostly the heartbeat thread, etc16:51
jschwarzgeguileo, so I'm gonna submit patches to join them together in tooz16:52
jschwarzgeguileo, the idea is that the "useful" coordination.py code in cinder should be shared in tooz instead, and cinder's code should be as small as possible16:52
jschwarzgeguileo, then we can re-use as much as possible in neutron16:52
jschwarzgeguileo, thoughts? :)16:52
geguileojschwarz: I'm going to be redoing some of that stuff16:53
geguileojschwarz: Because I'll be needing a supervisor16:53
jschwarzgeguileo, redoing how?16:54
geguileojschwarz: That can auto fence the node16:54
jschwarzgeguileo, ahh.. details on how that's going to work?16:54
jschwarzgeguileo, alas, the principle persists - I think the fencer should implemented in tooz to begin with16:54
geguileojschwarz: I'll need to keep count of the number of locks in use in the process16:54
jschwarzgeguileo, and how do you notify a thread that its lock has been lost due to fencing?16:55
geguileojschwarz: I'm not sure I'll be able to do it in tooz, it needs to have some knowledge of how to stop and properly restart the backend...16:55
*** bwallis has joined #openstack-cinder16:55
jschwarzgeguileo, blah.16:55
jschwarzgeguileo, callback?16:56
geguileojschwarz: I have to look if a send a signal or if I just kill it16:56
jschwarzgeguileo, think of it this way: if you implement it in cinder, we'll have to copy-paste it in neutron. practically a fork16:56
jschwarzwhich is not optimal at all16:56
geguileojschwarz: Maybe Neutron doesn't agree with our view16:57
geguileojschwarz: I think it's easier to get a specific solution16:57
geguileojschwarz: And work from there to get the generic version16:57
*** akapil has quit IRC16:57
geguileojschwarz: Trying to get consensus between Neutron, Cinder, Tooz, and anybody else would simply kill me16:57
jschwarzgeguileo, if Neutron doesn't want it *right now*, it will soon enough once I mention this to them :)16:58
geguileojschwarz: I mean, I've been working on this A/A stuff for over a year now16:58
geguileojschwarz: And I would like to finish it in the next release16:58
scottdanoone is allowed to bother geguileo , much less kill him :)16:58
jschwarzgeguileo, so once you know you want to fench a process, you want to either call a function that initiates it (a callback) or send a signal16:58
jschwarzgeguileo, both are generics16:59
geguileoscottda: XD XD XD16:59
geguileoscottda: Thanks  :-)16:59
jschwarzgeguileo, and I assure you, I neither want to kill you, nor not-finish it by next release.16:59
geguileojschwarz: Or just kill the thread, whichever is more convenient or easier to implement  ;-)16:59
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/35686716:59
jschwarzgeguileo, agreed16:59
geguileojschwarz: I know that's not your intention17:00
jschwarzgeguileo, either way, the point is that the action part is generic enough to be implemented in tooz17:00
geguileojschwarz: But then this work would depend on moving our current code to Tooz17:00
geguileojschwarz: I hope I can get to work on the specs for the auto fencing in 2 weeks17:00
jschwarzgeguileo, I'll be willing to take on the migration-to-tooz part of the job myself17:00
*** _ducttape_ has joined #openstack-cinder17:00
geguileojschwarz: Once I write some stuff and create a PoC I'll ping you so we can discuss it17:01
geguileojschwarz: Sounds good?17:01
jschwarzgeguileo, ok17:01
jschwarzgeguileo, I didn't know you were writing a spec17:01
jschwarzthat does complicate things :P17:02
geguileojschwarz: I have to write one17:02
geguileojschwarz: I wrote something, but it was when I was thinking something completely different17:02
*** jordanP has joined #openstack-cinder17:02
erlonsmcginnis: ping17:03
patrickeastjschwarz: one thing to keep in mind is that there is a strong aversion by some in cinder to making tooz a hard dependency, not a deal breaker IMO, but worth trying to have a plan to deal with negative feedback on a spec or changes to move that stuff out of cinder17:03
geguileojschwarz: https://review.openstack.org/#/c/237076/17:03
geguileopatrickeast: The aversion should be against a DLM, not Tooz itself17:03
scottdayes, we want deployers who don't want AA/HA to be able to deploy without tooz if they want to.17:04
geguileoscottda: But tooz is a very small library17:04
scottdaright, that's DLM in general, not tooz.17:04
patrickeastgeguileo: yea, but they are kinda seen as one in the same :(17:04
geguileoOk17:04
*** ducttape_ has quit IRC17:04
scottdaI think we're DLM library agnostic.17:04
scottdaor should be.17:04
jschwarzI'll be right back guys17:05
geguileoWell, I think it makes sense to move stuff to TooZ as long as everything can be optionally used or not17:05
*** Apoorva has joined #openstack-cinder17:05
scottdasure. Just as long as people that want a simple deployment with local file locks instead of DLM can still do that.17:05
*** sdague has joined #openstack-cinder17:06
geguileoscottda: Oh, that's for sure17:06
geguileoscottda: If we lose that we are doing to wrong, terribly wrong!!17:07
scottdaI'm not sure how strongly people would feel about a lack of choice of DLM, if tooz started to contain the necessary logic for things like fencing, and some alternate DLM did not..17:07
geguileoscottda: Well, the fencing should be DLM agnostic17:07
geguileoscottda: Otherwise it's useless17:07
scottdacool. we're in agreement, I think17:07
geguileoscottda: I'll ping you too once I have something concrete17:08
smcginniserlon: pong17:08
scottdageguileo: great, thanks, and thanks for all your work on this. You are greatly appreciated.17:08
smcginnisscottda, geguileo: +117:09
* scottda thinks maybe we should re-name Active-Active High Availability -> Gorkafication17:09
scottdaor at least geguileo 's favorite food..17:09
*** pbandark has joined #openstack-cinder17:10
jschwarzI'll vote for that, scottda17:10
erlonsmcginnis: Hey Sean,17:10
smcginniserlon: Hey17:10
erlonsmcginnis: while reviewing this driver: https://review.openstack.org/#/c/356986/1/cinder/volume/drivers/infinidat.py17:11
geguileoXD XD XD17:11
jschwarzgeguileo, so that spec you mentioned is specifically for the auto-fencing?17:11
erlonsmcginnis: I hit something I think that I think is not usual/right from the Cinder perpective17:12
geguileojschwarz: If I didn't make a mistake it should17:12
smcginniserlon: Oh, what was that?17:12
geguileojschwarz: Because I created multiple specs for the A/A work17:12
geguileojschwarz: And that's the last one that I will have to implement17:12
jschwarzgeguileo, so that complicates things in the way that if a design was made according to a spec in cinder, I see tooz devs arguing against copying that to tooz17:13
erlonsmcginnis: for what I understood, the driver clones volumes, using some kind of internal snapshot feature that can't decouple the clones from the original17:13
geguileojschwarz: Oh, but it's not a problem17:13
geguileojschwarz: That spec is useless now17:13
geguileojschwarz: I'll work on a new one and see if it can be done project agnostic17:13
jschwarzgeguileo, that sounds good17:13
erlonsmcginnis: so, you clone/snapshot a volume and you are stuck with the original until you delete all copies17:14
geguileojschwarz: Create a Poc, and then I may propose the spec in Tooz17:14
geguileojschwarz: And change the one in Cinder to explain that it's going to use that feature, and blah, blah, blah17:14
smcginniserlon: Hmm, they call out HPE and LVM as being the same. Need to look at that.17:14
jschwarzgeguileo, sounds excellent17:15
jschwarzgeguileo, so I'll wait for your POC before I start porting things17:15
erlonsmcginnis: LVM does not do for shure, LVM only checks if the volume has snapshots, what IMO shouldn't be needed as the API already does that, an in that case it throuhs the exception17:15
openstackgerritAlexey Khodos proposed openstack/cinder: NexentaStor5: add extend method to NFS driver  https://review.openstack.org/29788017:15
smcginniserlon: They may be right. Looks like LVM "clones" by creating a snapshot, and in delete_volume it checks if there are existing snapshots.17:16
erlonsmcginnis: so, if you create a clone in LVM driver you can't delete the source?17:17
erlonsmcginnis: that seems sooo wrong17:17
smcginniserlon: That's what it looks like to me. Maybe jgriffith or someone that has been good enough to maintain the LVM driver can confirm that.17:17
bswartzlvm snapshots should be independent17:18
smcginnisI just haven't used it in enough different scenarios to really know how it all works.17:18
bswartzit's cinder that prevents you from deleting a volume which has snapshots17:18
bswartzno driver is allowed to delete volumes with snapshots17:18
smcginnisbswartz: Not snapshots. Clones. But looks like LVM creates clones by creating a snapshot.17:18
bswartzyes that should be valid17:19
bswartzwhat's the problem?17:19
smcginnisLVM clones by creating a snapshot here: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L48217:19
bswartzan LVM "snapshot" is just another LV17:19
*** cdelatte has joined #openstack-cinder17:19
smcginnisAnd fails a delete here: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L42717:19
*** _ducttape_ has quit IRC17:19
erlonbswartz: the problem is if is possible/or not to delete the source after you have cloned a volume17:19
smcginnisbswartz: Right. So the philosophical question is = is a snapshot a clone?17:20
bswartzyeah... it should be possible to delete the souce17:20
smcginnisbswartz: Not if it's a snapshot here.17:20
*** ducttape_ has joined #openstack-cinder17:20
bswartzsmcginnis -- no need to as philisophical questions -- what matters is the API contract17:20
smcginnis:)17:20
bswartzcreate volume, clone volume, delete (first) volume should succeed17:20
erlonbswartz: mhm, which makes total sense17:21
smcginnisbswartz: So basically at least LVM breaks that contract. And possibly others.17:21
bswartznetapp actually performs quite a big of magic to ensure the above is true17:21
smcginnisbswartz: I agree that's how it should work.17:21
smcginnisBut it appears that's not always the case.17:21
bswartzsmcginnis: this could simply be a small bug in LVM though17:21
smcginnishemna: ping17:22
erlonbswartz: not that small once that to fix would require a lot of copy to release the source17:22
*** alkhodos has joined #openstack-cinder17:23
scottdamaybe not small, but sounds like a bug to me. If it's a clone, you can delete the source. That's the point of clone.17:24
hemnasmcginnis, sup17:24
alkhodosHi everyone, I have this review https://review.openstack.org/#/c/297880/ which says "Patch in Merge Conflict". I have rebased it before pushing latest patch set 5 minutes ago, but it did not help. How can I fix this?17:25
bswartzerlon: I find it very hard to believe that this never worked correctly in the past17:25
erlonbswartz: me too, looks odd that nobody wouldn't already hit that17:25
smcginnishemna: Do you know if any of the HPE arrays treat clones as snapshots and prevent deleting the source volume if clones exist?17:26
smcginnishemna: Called out here: https://review.openstack.org/#/c/356986/1/cinder/volume/drivers/infinidat.py17:26
erlonbswartz: should be easy to test that in tempest17:27
smcginnisbswartz: Or just no one clones when using LVM.17:27
smcginniserlon: I think that's a good idea.17:27
hemnathe 3PAR clone operation creates a separate volume on the array that has no association with the original after the operation is completed.17:28
*** Apoorva has quit IRC17:28
smcginnishemna: OK, good.17:28
hemnaduring the clone operation there is a temporary association17:28
erlonhemna: thanks17:28
hemnathat prevents deletion, or requires some special work17:28
erlonhemna: after that they are split17:29
hemnayah, once it's completed, it's split.17:29
smcginnisSo this might just be a bug/restriction with the LVM driver.17:30
hemnahttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_3par_common.py#L1991-L201917:30
*** lpetrut has quit IRC17:31
hemnaline 2000 there explains it a little bit17:31
smcginnishemna: Which I think is totally legit when you're in the middle of a clone anyway.17:31
hemnayah I would presume other arrays are similar17:32
smcginnis"Using non-online copy" - umm, like offline? :)17:32
hemnayah those are 3par terms17:32
hemnaonline copy means it's a background process that makes the volume available/online immediately for attaching17:32
*** dustins has joined #openstack-cinder17:34
erlonhemna: shouldn' t have a lock on the volume there? what happens if there's a clone + delete operation in the sequence?17:35
hemnawe have code in delete that acounts for the online copy taking place and we stop the copy then delete and cleanup17:35
hemnahttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_3par_common.py#L207117:36
erlonhemna: hmm? it fails the copy already in place?17:36
hemnait stops it and nukes it.17:37
smcginnisSeems like it would be better to wait for the copy to complete, then delete the source. But as long as that's the expected behavior, they really should know better than to delete a volume being cloned anyway.17:39
erlonhemna: hmm, that sounds bad, the opposite looks like a better way to handle17:39
hemnathat copy can take a very very long time17:40
hemnadepending on how large the volume is17:40
erlonhemna: smcginnis: yes, the user must know what he is doing17:40
hemnaif the user asks to delete, we assume they mean it, and stop and kill everything.17:40
smcginnisThe customer is always right. ;)17:41
hemnaeven when they aren't17:42
*** gouthamr is now known as gouthamr_afk17:42
akerrya but here you might have more than 1 user of the same tenant who aren't talking to each other :(17:42
*** gouthamr_afk is now known as gouthamr-afk17:42
erlonakerr: worst, you can have a imaga cache that is being used by many tenants17:43
akerrbut images can be "protected" and we're talking about create from volume here aren't we?17:44
*** bardia has joined #openstack-cinder17:45
akerrnot a great situation in general but I'd agree with the idea of finishing the clone in progress before nuking the source.  just my $.0217:46
erlonakerr: it's an image storage inside the storage17:46
hemnathere is no mechanism built in that can allow drivers to take an action at some time in the future17:47
hemnawe are talking possibly hours17:47
hemnadepending on how many of these are queued up and ongoing.17:47
hemnaand the size.17:47
hemnait's completely unrealistic to expect the clone to finish in this case before deletion.17:48
* erlon needs to start working with volumes bigger than 1G17:49
*** bardia has quit IRC17:49
hemnaheh yup :)17:50
*** bardia has joined #openstack-cinder17:50
akerrya, reality sucks17:50
akerri much prefer my idealistic mind-world17:50
*** dustins has quit IRC17:50
*** rcernin has joined #openstack-cinder17:51
bswartzerlon: do you have LVM set to thick or thin17:51
erlonbswartz: haven't tested that yet, Im fixing the LVM BE17:52
erlonbswartz: Ill try both17:52
bswartzsmcginnis, erlon: my reading of the code is that if it's thick, the clone method does nothing17:53
bswartzand if it's thin, it seems that LVM lets you delete the parent LV of a snap17:53
erlonbswartz: if is thick it should use dd17:54
bswartzerlon: I agree17:54
bswartznobody thinks thick LVM is a good idea though17:54
bswartzthin LVM is the only way to go17:55
bswartzthick is supported for backwards compat only17:55
*** Apoorva has joined #openstack-cinder17:56
*** ftersin has left #openstack-cinder18:02
*** mmedvede- has joined #openstack-cinder18:08
*** dustins has joined #openstack-cinder18:08
hemnahttps://bugs.launchpad.net/oslo.privsep/+bug/161106118:10
openstackLaunchpad bug 1611061 in oslo.privsep "redirecting stderr truncates output" [Undecided,New]18:10
hemnasadness18:10
hemnanot a single comment since it was filed18:10
hemnanothing18:10
hemna:(18:11
openstackgerritMatt Smith (_alastor_) proposed openstack/cinder: Datera driver 2.2 update  https://review.openstack.org/35253318:13
*** zul has quit IRC18:16
*** baumann has joined #openstack-cinder18:17
*** baumann has quit IRC18:17
*** baumann has joined #openstack-cinder18:18
patrickeasthemna: my guess is as soon as people start deploying with it and complaining about all the weird logging it will gain some traction18:22
*** zul has joined #openstack-cinder18:23
*** xyang has quit IRC18:26
erlonbswartz: smcginnis: the deletion works with LVM18:27
smcginniserlon: Oh, nice. Thanks for checking on it.18:27
openstackgerritYucong Feng proposed openstack/cinder: Fix Cisco Initiator zoning updates  https://review.openstack.org/35612118:28
erlonsmcginnis: both thin and thick18:28
smcginniserlon: So the unfortunate thing will be if they really have no way of supporting that with their product.18:30
smcginnisWhich would seem really odd.18:30
smcginniserlon: Good eye catching that!18:30
*** xyang has joined #openstack-cinder18:30
erlonsmcginnis: thanks, so, not sure how they should fix that, may be using dd like LVM18:31
openstackgerritJay Bryant proposed openstack/cinder: Change NFS driver to not throw exception without nfs shares file  https://review.openstack.org/34128218:31
erlonsmcginnis: but Its hard to imagine how a storage wouldn't support the split18:32
smcginniserlon: Yeah, I would think there's got to be a way for them to handle that.18:32
*** Lee1092 has joined #openstack-cinder18:33
smcginniserlon: Commented on there.18:35
erlonsmcginnis: mhm18:37
*** bardia_ has joined #openstack-cinder18:41
*** bardia has quit IRC18:41
*** dustins has quit IRC18:47
*** lpetrut has joined #openstack-cinder18:47
*** ociuhandu has quit IRC18:47
*** xyang has quit IRC18:48
*** catintheroof has joined #openstack-cinder18:49
*** xyang has joined #openstack-cinder18:50
*** rlrossit has quit IRC18:52
openstackgerritvenkata krishna proposed openstack/cinder: Add replication failback in Kaminario K2 drivers  https://review.openstack.org/35647518:53
*** rlrossi__ has joined #openstack-cinder18:55
*** fifieldt has quit IRC19:06
*** pbandark has quit IRC19:06
*** julim has quit IRC19:13
*** xyang has quit IRC19:13
openstackgerritMerged openstack/cinder: EMC VMAX - iSCSI Multipath support  https://review.openstack.org/31706019:13
*** julim has joined #openstack-cinder19:14
*** xyang has joined #openstack-cinder19:15
*** salv-orl_ has joined #openstack-cinder19:15
*** fifieldt has joined #openstack-cinder19:18
*** salv-orlando has quit IRC19:18
patrickeastoo thats a new one, zuul-merger's cinder repo got a corrupt git index so all my ci jobs have been silently failing this morning19:23
bswartzerlon: I'm glad it worked out19:24
bswartzerlon: do you know what code path is followed when you clone an LVM thick volume?19:24
erlonbswartz: yep, but just don't know how it can clone that fast and delete the source without coping19:25
erlonbswartz: may be it does take time if you change a lot in the desination19:26
bswartzerlon: 1g takes less time to copy then you'd think19:26
bswartzif you create a 100g volume and it's still fast then I'd be suspicious19:26
erlonbswartz: hmm, another point is that I didn't write to the volume, so, it was less that 1G19:27
*** thumpba_ has quit IRC19:29
bswartzerlon: thick volumes are thick19:30
bswartzdd doesn't know it's full of zeros19:30
erlonbswartz: I tested thin with 20GB volumes, and thick with 2GB19:31
erlonbswartz: it toke 5~10 s to create19:31
erlonthe thick ones, thin are immediately19:32
openstackgerritPatrick East proposed openstack/cinder: Add release note to warn about os-brick lock dir  https://review.openstack.org/35450119:32
*** dgonzalez has quit IRC19:34
*** e0ne has joined #openstack-cinder19:34
openstackgerritAlyson proposed openstack/cinder: HNAS: Add support for manage/unmanage snapshots in NFS driver  https://review.openstack.org/33399219:34
openstackgerritNate Potter proposed openstack/cinder: Public core API to check backup capability at runtime.  https://review.openstack.org/35031019:38
*** thumpba has joined #openstack-cinder19:39
openstackgerritMichael Price proposed openstack/cinder: NetApp E-Series: Add volume tagging for back-end  https://review.openstack.org/34895819:40
*** leeantho_ has joined #openstack-cinder19:44
*** ociuhandu has joined #openstack-cinder19:45
*** dgonzalez has joined #openstack-cinder19:45
*** leeantho has quit IRC19:46
*** bill_az has joined #openstack-cinder19:48
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Merge two fake drivers into the one FakeLoggingVolumeDriver  https://review.openstack.org/34842819:53
*** Apoorva_ has joined #openstack-cinder19:59
*** Apoorva has quit IRC20:03
*** ducttape_ has quit IRC20:04
*** xyang has quit IRC20:04
*** thumpba has quit IRC20:04
*** ducttape_ has joined #openstack-cinder20:04
*** GB21 has quit IRC20:04
*** enriquetaso has quit IRC20:05
*** xyang has joined #openstack-cinder20:06
*** porrua has quit IRC20:07
*** JoseMello has quit IRC20:10
openstackgerritRaunak Kumar proposed openstack/cinder: Add support for force backup for Nimble Storage  https://review.openstack.org/34908620:13
*** xyang has quit IRC20:14
*** diablo_rojo has joined #openstack-cinder20:20
*** _coolsvap_ has quit IRC20:21
openstackgerritAleksey Ruban proposed openstack/cinder: Nexenta: NexentaStor4 NFS driver cache capacity and use sessions  https://review.openstack.org/35614220:22
*** BigWillie has quit IRC20:24
*** nikeshm has joined #openstack-cinder20:27
*** diogogmt has joined #openstack-cinder20:27
nikeshmhi20:27
nikeshmif any one get time please review https://review.openstack.org/#/c/356475/20:28
nikeshmthanks20:28
*** Lee1092 has quit IRC20:33
*** akapil has joined #openstack-cinder20:37
tbarronping patrickeast when you get a chance, have a query about how to verify volume limits on purestorage side?20:40
patrickeasttbarron: there isn't an API to get the limits (i've got an RFE open for that), but its pretty easy right now20:41
*** akapil has quit IRC20:41
patrickeasttbarron: i think all arrays in the field that customers have its 500 as the limit20:41
patrickeasttbarron: relatively soon with a Purity update it goes to 5k20:42
patrickeasttbarron: more specifically 500 vols for Purity <=  v4.7.x20:43
*** rlrossi__ has quit IRC20:44
tbarronpatrickeast: is there a way to see if he or the customer can be storage admin on the array?20:46
tbarronpatrickeast: or is it best just to look at the version of Purity and figure 500 or 5k?20:46
tbarronthen see how many vols cinder has allocated and find out if anyone else could be consuming them?20:47
tbarronpatrickeast: oh, i see: all in the field right now have 500 vols, that's pretty easy then20:47
patrickeasttbarron: easiest is to look at the version, but yea unless they're very special its 50020:48
patrickeasttbarron: typically the issue is that there are volumes in the "pending eradication" state20:48
patrickeasttbarron: i added a config option to mitaka to eradicate immediately, but as a "feature" of the array deleted volumes are available to be restored for 24 hours20:49
patrickeasttbarron: in that pending state they still count as one of the volumes20:49
*** alkhodos has quit IRC20:50
tbarronpatrickeast: ok, good info, i'll have him find out if they very recently deleted a bunch and don't see them freed yet20:51
patrickeasthttps://www.irccloud.com/pastebin/RTImO15V/20:52
patrickeasttbarron: they can use something like that to see ^20:52
patrickeasttbarron: the san api and api token can be grabbed from cinder.conf20:52
tbarronpatrickeast: ++, ty20:53
smcginnisForgot to mention in the IRC meeting this week - I'm travelling tomorrow through Monday.20:55
smcginnisSo I might not be around as much, but I should be able to get back to any pings, just delayed.20:55
smcginnisJust an FYI20:55
*** rlrossit has joined #openstack-cinder20:55
*** crose has quit IRC20:56
*** baumann has quit IRC20:58
*** gouthamr-afk is now known as gouthamr20:58
jungleboyjsmcginnis: You can't leave us!20:59
smcginnisjungleboyj: Hah!21:00
smcginnisjungleboyj: How was your "lunch". Your typing seems to be OK. ;)21:00
*** baumann has joined #openstack-cinder21:00
*** xyang has joined #openstack-cinder21:00
jungleboyjsmcginnis: I have actually solved a number of problem that have been outstanding this afternoon.21:00
jungleboyjNeed to do 'lunch' more often.21:01
*** baumann has quit IRC21:01
smcginnisjungleboyj: Nice!21:01
*** baumann has joined #openstack-cinder21:01
jungleboyjsmcginnis: Hoping to have a rebased snapshot patch for NFS pushed up yet this week.21:02
*** diablo_rojo has quit IRC21:02
smcginnisjungleboyj: Ooh, nice. Glad to see progress there.21:03
jungleboyjsmcginnis: Yeah, hoping no one else has started working on that.21:03
*** julim has quit IRC21:04
*** jgregor has quit IRC21:04
smcginnisjungleboyj: Unfortunately for you - I doubt it. :)21:04
nikeshmxyang1: if you get time can you review this replication failback support patch for kaminario driver https://review.openstack.org/#/c/356475/21:04
*** e0ne has quit IRC21:04
jungleboyjsmcginnis: I am learning a lot in the process, so it is all good.21:05
xyangnikeshm: ok21:05
*** Apoorva_ has quit IRC21:08
*** Apoorva has joined #openstack-cinder21:08
*** leeantho_ has quit IRC21:10
*** crose has joined #openstack-cinder21:11
*** cdelatte has quit IRC21:16
*** catintheroof has quit IRC21:21
*** baumann has quit IRC21:23
*** crose has quit IRC21:23
*** edmondsw has quit IRC21:25
*** mriedem has left #openstack-cinder21:25
*** mriedem has joined #openstack-cinder21:26
*** leeantho has joined #openstack-cinder21:27
SwansonSimple change here (all dell internal stuff):  https://review.openstack.org/#/c/350262/21:27
*** rlrossit has quit IRC21:31
SwansonThis one is pretty basic, too.... https://review.openstack.org/35668721:33
*** pauloewerton has quit IRC21:34
Swansonscottda, Thanks!21:37
scottdanp. there's the other as well.21:37
smcginnisscottda: Don't be too nice to him. He might start to expect it.21:38
smcginnis:P21:38
Swansonxyang, also thanks!21:39
xyangSwanson: np21:39
*** jungleboyj has quit IRC21:44
*** lprice has quit IRC21:45
*** lpetrut has quit IRC21:55
*** mriedem has quit IRC21:58
*** tbarron is now known as tbarron|afk22:02
*** xyang1 has quit IRC22:14
*** sumit7990 has quit IRC22:15
*** kwathore_ has quit IRC22:17
*** tpsilva has quit IRC22:18
*** julim has joined #openstack-cinder22:19
*** xyang has quit IRC22:20
*** alyson_ has quit IRC22:23
*** erlon has quit IRC22:27
*** xinli has quit IRC22:30
*** ntpttr has quit IRC22:31
*** ducttape_ has quit IRC22:32
*** leeantho has quit IRC22:34
*** ntpttr has joined #openstack-cinder22:36
*** ametts has quit IRC22:51
*** wxy__ has quit IRC22:53
*** hemna is now known as hemnafk22:54
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: Add warning message for None volume type set  https://review.openstack.org/34861022:54
*** Apoorva_ has joined #openstack-cinder23:00
*** haplo37__ has quit IRC23:03
*** Apoorva has quit IRC23:03
*** sdake_ has joined #openstack-cinder23:12
*** sdake has quit IRC23:13
*** sdague has quit IRC23:14
*** jordanP has quit IRC23:16
*** chlong has quit IRC23:20
openstackgerritMerged openstack/cinder: Use min attribute from oslo_config  https://review.openstack.org/35638823:24
openstackgerritMerged openstack/cinder: Updated from global requirements  https://review.openstack.org/35686723:25
*** rcernin has quit IRC23:32
*** xenogear has quit IRC23:40
patrickeastew just had a c-sch segfault in the middle of tempest... i feel like that isn't supposed to happen with python23:48
*** mriedem has joined #openstack-cinder23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!