Wednesday, 2016-08-03

*** diogogmt has quit IRC00:00
*** yangyapeng has quit IRC00:03
*** alonma has quit IRC00:03
*** thumpba has joined #openstack-cinder00:04
*** alonma has joined #openstack-cinder00:06
*** alonma has quit IRC00:10
*** mtanino has quit IRC00:11
*** jungleboyj has joined #openstack-cinder00:11
*** thumpba has quit IRC00:12
*** alonma has joined #openstack-cinder00:16
*** jwcroppe_ has joined #openstack-cinder00:20
*** alonma has quit IRC00:20
*** jwcroppe has quit IRC00:22
*** alonma has joined #openstack-cinder00:23
*** laughterwym has joined #openstack-cinder00:25
*** laughterwym has quit IRC00:26
*** laughterwym has joined #openstack-cinder00:26
*** alonma has quit IRC00:27
*** jwcroppe has joined #openstack-cinder00:28
*** alonma has joined #openstack-cinder00:30
*** jwcroppe_ has quit IRC00:31
*** akerr_ is now known as akerr_away00:33
*** akerr_away is now known as akerr_00:33
*** kaisers_ has joined #openstack-cinder00:34
*** alonma has quit IRC00:35
*** alonma has joined #openstack-cinder00:37
*** kaisers_ has quit IRC00:38
*** Suyi_ has quit IRC00:40
*** karthik__ has quit IRC00:42
*** alonma has quit IRC00:42
*** alonma has joined #openstack-cinder00:46
*** alonma has quit IRC00:50
*** alonma has joined #openstack-cinder00:53
*** jungleboyj has quit IRC00:54
*** karthik__ has joined #openstack-cinder00:56
*** alonma has quit IRC00:57
*** sdake has quit IRC00:57
*** sdake has joined #openstack-cinder00:59
*** Guest45378 has quit IRC00:59
*** alonma has joined #openstack-cinder01:00
*** wilson has joined #openstack-cinder01:01
*** wilson is now known as Guest1586501:02
*** alonma has quit IRC01:04
*** karthik__ has quit IRC01:07
*** nikeshm has quit IRC01:08
*** diogogmt has joined #openstack-cinder01:09
openstackgerritzheng yin proposed openstack/python-cinderclient: remove raise "e"  https://review.openstack.org/35000001:11
openstackgerritRaunak Kumar proposed openstack/cinder: Add support for force backup for Nimble Storage  https://review.openstack.org/34908601:11
*** Apoorva has quit IRC01:12
*** yangyapeng has joined #openstack-cinder01:16
*** iceyao has joined #openstack-cinder01:18
*** mriedem has quit IRC01:19
*** karthik__ has joined #openstack-cinder01:19
GuyHi everybody, sorry for disturbing, can I get some reviews on https://review.openstack.org/#/c/347100/ and https://review.openstack.org/#/c/349318/2 please. Thank you in advance.01:20
*** akshai has joined #openstack-cinder01:23
*** Apoorva has joined #openstack-cinder01:23
*** abhitechie has joined #openstack-cinder01:27
*** delattec has quit IRC01:28
*** Lee1092 has joined #openstack-cinder01:32
*** tangchen has quit IRC01:33
*** alonma has joined #openstack-cinder01:33
*** akshai has quit IRC01:35
*** abhitechie has quit IRC01:37
*** alonma has quit IRC01:37
*** tangchen has joined #openstack-cinder01:39
*** Apoorva_ has joined #openstack-cinder01:40
*** alonma has joined #openstack-cinder01:40
openstackgerritzhangyanxian proposed openstack/os-brick: Update the home-page info with the developer documentation  https://review.openstack.org/35033701:41
openstackgerritzhangyanxian proposed openstack/os-brick: Update the home-page info with the developer documentation  https://review.openstack.org/35033701:41
*** sdake has quit IRC01:44
*** Apoorva has quit IRC01:44
*** EinstCrazy has joined #openstack-cinder01:44
*** Apoorva_ has quit IRC01:44
*** alonma has quit IRC01:44
*** alonma has joined #openstack-cinder01:47
*** alonma has quit IRC01:52
*** karthik__ has quit IRC01:53
*** alonma has joined #openstack-cinder01:54
openstackgerritLisaLi proposed openstack/cinder: Create encrypted volumes from images  https://review.openstack.org/21656701:55
openstackgerritLisaLi proposed openstack/cinder: Add encryptor attach/detach in utils  https://review.openstack.org/34191401:55
openstackgerritLisaLi proposed openstack/cinder: Retype encrypted volumes  https://review.openstack.org/31907801:57
*** alonma has quit IRC01:59
*** yangyape_ has joined #openstack-cinder02:03
*** yangyapeng has quit IRC02:04
*** alonma has joined #openstack-cinder02:08
*** bardia has quit IRC02:12
*** alonma has quit IRC02:13
*** akerr_ has quit IRC02:16
*** alonma has joined #openstack-cinder02:16
*** coolsvap has joined #openstack-cinder02:19
*** alonma has quit IRC02:21
openstackgerritLisaLi proposed openstack/cinder: Create encrypted volumes from images  https://review.openstack.org/21656702:22
*** kaisers_ has joined #openstack-cinder02:23
*** gouthamr has joined #openstack-cinder02:24
*** gouthamr_ has joined #openstack-cinder02:27
*** kaisers_ has quit IRC02:27
openstackgerritxing-yang proposed openstack/cinder: Add group type and group specs  https://review.openstack.org/32016502:29
openstackgerritxing-yang proposed openstack/cinder: Add group snapshots  https://review.openstack.org/32805202:29
openstackgerritxing-yang proposed openstack/cinder: Add generic volume groups  https://review.openstack.org/32245902:29
openstackgerritxing-yang proposed openstack/cinder: WIP: Migrate consistency groups to groups  https://review.openstack.org/35035002:29
*** gouthamr has quit IRC02:30
*** alonma has joined #openstack-cinder02:32
*** yangyapeng has joined #openstack-cinder02:34
*** alonma has quit IRC02:37
*** yangyape_ has quit IRC02:37
*** markvoelker has joined #openstack-cinder02:39
*** alonma has joined #openstack-cinder02:39
*** dave-mccowan has joined #openstack-cinder02:41
*** Guest15865 has quit IRC02:41
*** wilson has joined #openstack-cinder02:41
*** wilson is now known as Guest2359102:42
*** alonma has quit IRC02:44
*** alonma has joined #openstack-cinder02:46
openstackgerritLisaLi proposed openstack/cinder: Fix ImportError of fake_driver  https://review.openstack.org/35035702:47
*** daneyon has quit IRC02:48
*** alonma has quit IRC02:51
*** alonma has joined #openstack-cinder02:54
openstackgerritMerged openstack/cinder: Docs: Correct i18n information  https://review.openstack.org/34647702:57
*** alonma has quit IRC02:58
*** alonma has joined #openstack-cinder03:01
*** Srinu has joined #openstack-cinder03:05
*** alonma has quit IRC03:05
Srinupatrickeast:hi03:06
*** dave-mccowan has quit IRC03:08
*** alonma has joined #openstack-cinder03:08
openstackgerritMerged openstack/cinder: Fix documentation and remove dead code  https://review.openstack.org/34908903:09
openstackgerritMerged openstack/cinder: ScaleIO ignore rename of external volumes  https://review.openstack.org/34360603:09
*** alonma has quit IRC03:12
*** iceyao_ has joined #openstack-cinder03:12
*** Guest23591 has quit IRC03:14
*** wilson_liu has joined #openstack-cinder03:15
*** iceyao has quit IRC03:16
*** alonma has joined #openstack-cinder03:17
wilson_liuhi, I have a question about the concurrency of message cinder-volume recieved from rabbitmq03:17
wilson_liuDo we have any configuration to config the concurrency?03:18
*** alonma has quit IRC03:21
*** cknight has joined #openstack-cinder03:26
*** Nakato has quit IRC03:27
*** gouthamr_ has quit IRC03:29
*** Nakato has joined #openstack-cinder03:32
*** alonma has joined #openstack-cinder03:36
*** pradipm has joined #openstack-cinder03:38
*** alonma has quit IRC03:40
*** pradipm has quit IRC03:42
*** alonma has joined #openstack-cinder03:43
*** alonma has quit IRC03:47
*** nkrinner_afk is now known as nkrinner03:47
*** alonma has joined #openstack-cinder03:50
*** sdake has joined #openstack-cinder03:50
*** abhitechie has joined #openstack-cinder03:53
*** sdake_ has joined #openstack-cinder03:54
*** alonma has quit IRC03:54
*** markvoelker has quit IRC03:55
*** alonma has joined #openstack-cinder03:57
*** sdake has quit IRC03:58
*** bardia has joined #openstack-cinder04:01
*** alonma has quit IRC04:02
*** karthikp_ has quit IRC04:04
*** alonma has joined #openstack-cinder04:04
*** sdake_ has quit IRC04:05
*** alonma has quit IRC04:09
*** links has joined #openstack-cinder04:10
*** alonma has joined #openstack-cinder04:11
*** alonma has quit IRC04:16
*** jdillaman has quit IRC04:18
*** alonma has joined #openstack-cinder04:19
*** nikeshm has joined #openstack-cinder04:22
nikeshmDuncanT: ping04:22
nikeshmsorry04:22
nikeshmhi04:22
*** kaisers_ has joined #openstack-cinder04:23
*** alonma has quit IRC04:23
*** kaisers_ has quit IRC04:23
*** alonma has joined #openstack-cinder04:26
nikeshmDuncanT:  we deleted 'kaminario_nodedup_substring' option in https://review.openstack.org/346540 to decide from extra-specs about creating dedup/nodedup volumes, but in reviews we were suggested to deprecate this option in current release and delete it in Ocata release.04:27
nikeshmDuncanT: Please let me know what should i do for your comment on https://review.openstack.org/#/c/34901904:29
*** alonma has quit IRC04:31
*** markvoelker has joined #openstack-cinder04:33
*** alonma has joined #openstack-cinder04:33
*** alonma has quit IRC04:38
*** markvoelker has quit IRC04:39
*** alonma has joined #openstack-cinder04:41
*** alonma has quit IRC04:45
*** alonma has joined #openstack-cinder04:48
*** alonma has quit IRC04:52
*** alonma has joined #openstack-cinder04:55
*** lkuchlan has joined #openstack-cinder04:56
*** alonma has quit IRC05:00
*** pdeore has joined #openstack-cinder05:01
*** julim has quit IRC05:02
*** alonma has joined #openstack-cinder05:02
*** bardia has quit IRC05:02
openstackgerritMerged openstack/cinder: Huawei: Fixed problems caused by password expiration  https://review.openstack.org/30563305:04
*** lkuchlan has quit IRC05:04
*** lkuchlan has joined #openstack-cinder05:04
*** cknight has quit IRC05:06
*** chris_morrell has joined #openstack-cinder05:06
*** alonma has quit IRC05:07
*** chris_morrell has quit IRC05:07
*** karthikp_ has joined #openstack-cinder05:09
*** gcb has quit IRC05:11
*** gcb has joined #openstack-cinder05:12
*** pbandark has joined #openstack-cinder05:12
*** alonma has joined #openstack-cinder05:12
*** e0ne has joined #openstack-cinder05:12
*** e0ne has quit IRC05:15
*** alonma has quit IRC05:17
openstackgerritVijay Ladani proposed openstack/cinder: Handle snapshot delete conflict in 3par driver  https://review.openstack.org/34272205:18
*** alonma has joined #openstack-cinder05:20
*** Poornima has joined #openstack-cinder05:22
*** alonma has quit IRC05:24
*** alonma has joined #openstack-cinder05:27
*** markvoelker has joined #openstack-cinder05:28
*** liverpooler has joined #openstack-cinder05:28
*** rcernin has joined #openstack-cinder05:28
*** liverpooler has quit IRC05:30
*** liverpooler has joined #openstack-cinder05:31
*** alonma has quit IRC05:31
*** markvoelker has quit IRC05:33
*** alonma has joined #openstack-cinder05:34
*** alonma has quit IRC05:38
*** alonma has joined #openstack-cinder05:41
*** yangyape_ has joined #openstack-cinder05:42
*** yangyapeng has quit IRC05:42
*** ChubYann has quit IRC05:42
*** jdillaman has joined #openstack-cinder05:44
*** alonma has quit IRC05:46
*** alonma has joined #openstack-cinder05:48
*** alonma has quit IRC05:53
*** alonma has joined #openstack-cinder05:56
*** julim has joined #openstack-cinder05:57
*** alonma has quit IRC06:00
*** alonma has joined #openstack-cinder06:03
*** mjura has joined #openstack-cinder06:04
*** sdake has joined #openstack-cinder06:07
*** sdake has quit IRC06:07
*** sdake has joined #openstack-cinder06:07
*** alonma has quit IRC06:07
*** alonma has joined #openstack-cinder06:10
*** mjura has quit IRC06:12
*** mjura has joined #openstack-cinder06:13
*** iceyao_ has quit IRC06:13
*** iceyao has joined #openstack-cinder06:13
*** alonma has quit IRC06:14
DuncanTnikeshm: Replied to review. Just updating the commit message with an explanation should be fine. Thanks.06:15
*** alonma has joined #openstack-cinder06:19
*** lpetrut has joined #openstack-cinder06:19
*** alonmarx has joined #openstack-cinder06:22
*** markvoelker has joined #openstack-cinder06:22
*** alonma has quit IRC06:23
*** sdake has quit IRC06:23
*** alonma has joined #openstack-cinder06:26
*** markvoelker has quit IRC06:26
*** lkuchlan has quit IRC06:29
*** lkuchlan has joined #openstack-cinder06:30
*** alonma has quit IRC06:31
*** alonma has joined #openstack-cinder06:33
nikeshmDuncanT:  hi, actually i tried to remove  kaminario_nodedup_substring in Change I43630dd6f7b9c1d18f59be12626b66f798de2822  but added it back in same change06:34
nikeshmDuncanT: i am not readding it06:34
nikeshmin https://review.openstack.org/#/c/349019/1006:34
*** Digvijay has joined #openstack-cinder06:36
nikeshmso bit confuse06:36
*** pgadiya has joined #openstack-cinder06:36
*** alonma has quit IRC06:38
*** vbala has joined #openstack-cinder06:38
*** arecknag has joined #openstack-cinder06:39
openstackgerritDinesh Bhor proposed openstack/cinder: Remove unused register_models() method  https://review.openstack.org/35039306:40
*** alonma has joined #openstack-cinder06:41
*** belmoreira has joined #openstack-cinder06:42
*** alonma has quit IRC06:45
*** tesseract- has joined #openstack-cinder06:45
DuncanTnikeshm: Sorry, I messed up rebasing the patch. I'll update the review. You need to use the actual deprecation mechanism for the deprecation so that the standard deprecation warnings come out. Basically follow Vipin's comments in https://review.openstack.org/#/c/346540/16/cinder/volume/drivers/kaminario/kaminario_common.py (fix the import order too please).06:47
*** alonma has joined #openstack-cinder06:48
*** alonma has quit IRC06:52
*** alonma has joined #openstack-cinder06:55
*** tangchen has quit IRC07:00
nikeshmDuncanT: thanks, no need to say sorry, you are always helpful07:00
*** alonma has quit IRC07:00
*** alonma has joined #openstack-cinder07:02
*** karthikp_ has quit IRC07:03
*** alonma has quit IRC07:07
nikeshmDuncanT vbala:  changes suggested are small, shall i change it it retype patch07:07
nikeshmitself07:08
*** alonma has joined #openstack-cinder07:09
DuncanTYes, that's probably easiest.07:12
*** alonma has quit IRC07:14
vbalanikeshm: I'm fine with that07:14
*** markvoelker has joined #openstack-cinder07:16
*** e0ne has joined #openstack-cinder07:16
openstackgerritMerged openstack/cinder: Dell SC: Use Live Volume for replication  https://review.openstack.org/32953107:19
*** alonma has joined #openstack-cinder07:19
*** markvoelker has quit IRC07:21
*** pcaruana has joined #openstack-cinder07:21
nikeshmvbala: http://paste.openstack.org/show/547713/   is this OK?07:21
nikeshmvbala:  Ocata  -->  10.0.007:23
nikeshmvbala:  is this to change in option tooo07:23
nikeshmhttp://paste.openstack.org/show/547713/07:23
*** alonma has quit IRC07:23
*** links has quit IRC07:23
vbalanikeshm: I think you can keep the original help text and add the reason for deprecation as the value of deprecated_reason07:24
vbalaSee https://github.com/openstack/nova/blob/be59c19c969acf6b25b0711f0ebfb26aaed0a171/nova/conf/libvirt.py#L9107:24
nikeshmvbala:  what about Ocata  -->  10.0.007:25
nikeshmvbala:  i saw using Mitaka07:25
nikeshmin deprecated07:25
nikeshmmessage07:25
vbalanikeshm: No need to add the version in the help text, I think you can change the version in the info log07:26
*** alonma has joined #openstack-cinder07:26
nikeshmvbala:  but how it useful to use version in info and name in text07:29
nikeshmany issue if we keep name in text07:29
nikeshmi mean Ocata07:29
nikeshmin info07:29
*** ekarlso has quit IRC07:29
nikeshmname in help message i mean07:30
nikeshmlet me correct myself07:31
*** alonma has quit IRC07:31
nikeshmvbala:  how is it useful to use 10.0.0 in info and Ocata in option help?07:32
nikeshmany issue if i use Ocata  in info07:32
*** alonma has joined #openstack-cinder07:34
*** lpetrut has quit IRC07:36
vbalanikeshm: i think there is no need to mention 'ocata' or the version in the help text because it is already mentioned in the logs. But it's ok for me if you want to mention it in both places.07:36
*** links has joined #openstack-cinder07:37
*** ekarlso has joined #openstack-cinder07:37
*** claudiub has joined #openstack-cinder07:37
vbalaWe started using the version instead of the release name (Ocata) in the code, I don't whether it is changed now.07:38
*** alonma has quit IRC07:38
*** alonma has joined #openstack-cinder07:41
*** ebalduf has quit IRC07:41
nikeshmvbala: ok i will change it to 10.0.0 in info and will use "next release" in help07:43
*** alonma has quit IRC07:45
*** lpetrut has joined #openstack-cinder07:46
openstackgerritnikesh proposed openstack/cinder: Support retype in K2 cinder driver  https://review.openstack.org/34901907:48
*** alonma has joined #openstack-cinder07:48
*** alonma has quit IRC07:52
*** alonma has joined #openstack-cinder07:55
*** alonma has quit IRC07:57
*** alonma has joined #openstack-cinder07:57
*** yangyapeng has joined #openstack-cinder07:59
*** jistr is now known as jistr|training07:59
*** zzzeek has quit IRC08:00
*** yangyap__ has joined #openstack-cinder08:01
*** zzzeek has joined #openstack-cinder08:02
*** yangyape_ has quit IRC08:03
*** yangyapeng has quit IRC08:04
*** lpetrut has quit IRC08:04
*** yangyap__ has quit IRC08:05
*** coolsvap is now known as coolsvap_08:08
openstackgerritDavanum Srinivas (dims) proposed openstack/cinder: [WIP] Testing latest u-c  https://review.openstack.org/30376608:10
*** markvoelker has joined #openstack-cinder08:10
*** abhinavtechie has joined #openstack-cinder08:11
*** abhitechie has quit IRC08:12
*** markvoelker has quit IRC08:14
*** alonmarx has quit IRC08:21
openstackgerritnikesh proposed openstack/cinder: Support retype in K2 cinder driver  https://review.openstack.org/34901908:31
*** gb21 has joined #openstack-cinder08:40
*** lkuchlan has quit IRC08:42
*** yangyapeng has joined #openstack-cinder08:42
*** laughterwym has quit IRC08:44
*** gb21 has quit IRC08:48
*** gb21 has joined #openstack-cinder08:48
*** jistr|training is now known as jistr08:49
*** Digvijay has quit IRC08:58
*** Digvijay has joined #openstack-cinder08:59
*** amitkqed has quit IRC09:04
*** markvoelker has joined #openstack-cinder09:04
*** amitkqed has joined #openstack-cinder09:04
*** gb21 has quit IRC09:05
openstackgerritOpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements  https://review.openstack.org/34866709:06
*** lkuchlan has joined #openstack-cinder09:08
*** nikeshm has quit IRC09:08
*** Srinu has quit IRC09:08
*** markvoelker has quit IRC09:09
*** gb21 has joined #openstack-cinder09:10
*** lkuchlan has quit IRC09:13
*** EinstCrazy has quit IRC09:15
*** EinstCrazy has joined #openstack-cinder09:16
openstackgerritLisaLi proposed openstack/cinder: Update detach_volume() with versionedobjects  https://review.openstack.org/26860909:17
openstackgerritLisaLi proposed openstack/cinder: Update attach_volume() with versionedobjects  https://review.openstack.org/26860809:17
*** tangchen has joined #openstack-cinder09:24
*** gb21 has quit IRC09:25
*** lpetrut has joined #openstack-cinder09:26
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Imported Translations from Zanata  https://review.openstack.org/35047509:31
*** alonma has quit IRC09:33
*** smile-luobin_ has quit IRC09:33
openstackgerritLisaLi proposed openstack/cinder: Update detach_volume() with versionedobjects  https://review.openstack.org/26860909:34
*** nikeshm has joined #openstack-cinder09:34
*** smile-luobin has joined #openstack-cinder09:34
nikeshmvbala DuncanT: check this https://github.com/openstack/cinder/blob/fd2790f575c748b0a745e8b1030998a16c5906f1/cinder/volume/manager.py#L215-L22009:34
nikeshmi used suppress_requests_ssl_warnings = true in cinder.conf09:35
nikeshmbut even though warnings are coming09:35
nikeshmmay be i have to add kaminario_suppress_requests_ssl_warnings option09:36
flip214jgriffith: thingee: thank you very much for reviewing 347273!  my patch queue starts with 347267, sadly, so it'll take some more reviews to get that merged, too ;/09:36
lpetrutHi, any chance someone could take a look over those two patches on os-brick adding Windows SMBFS and FC connectors? https://review.openstack.org/#/c/323781/  https://review.openstack.org/#/c/32378009:40
lpetrutFirst one already got a +2 and our CI already voted positively for both of them.09:40
lpetrutThanks09:40
*** kambiz has joined #openstack-cinder09:44
*** alonma has joined #openstack-cinder09:47
*** laughterwym has joined #openstack-cinder09:50
*** alonma has quit IRC09:52
*** laughterwym has quit IRC09:54
*** nikeshm has quit IRC09:58
*** Jaison has joined #openstack-cinder09:58
*** markvoelker has joined #openstack-cinder09:58
*** links has quit IRC09:59
*** alonma has joined #openstack-cinder10:01
*** markvoelker has quit IRC10:04
*** alonma has quit IRC10:06
*** alonma has joined #openstack-cinder10:08
*** amit213 has quit IRC10:10
*** amit213 has joined #openstack-cinder10:12
*** ManishD has joined #openstack-cinder10:12
*** bhagyashris has joined #openstack-cinder10:12
*** alonma has quit IRC10:13
*** alonma has joined #openstack-cinder10:14
*** serverascode has quit IRC10:15
ManishDHI, I am running into one case:-- 1. Attach FC and ICSI volume to single instance (same instance) -- Successful  2. Detach ICSI volume -- Successful 3. Reattach ICSI volume -- Error :- 24 - iSCSI login failed due to authorization failure10:16
ManishDPlease can someone explain10:16
ManishDassist10:16
*** bhagyashri has quit IRC10:16
*** Dinesh_Bhor has quit IRC10:16
*** serverascode has joined #openstack-cinder10:16
*** Dinesh_Bhor has joined #openstack-cinder10:17
openstackgerritMerged openstack/cinder: Add proxy config option to google backup driver  https://review.openstack.org/34109010:18
*** gb21 has joined #openstack-cinder10:18
*** pckizer has quit IRC10:19
*** pckizer has joined #openstack-cinder10:19
openstackgerritLisaLi proposed openstack/cinder: Update detach_volume() with versionedobjects  https://review.openstack.org/26860910:19
openstackgerritLisaLi proposed openstack/cinder: Update detach_volume() with versionedobjects  https://review.openstack.org/26860910:26
*** yangyapeng has quit IRC10:26
*** yangyapeng has joined #openstack-cinder10:27
*** laughterwym has joined #openstack-cinder10:33
*** Guy has quit IRC10:33
*** alonma has quit IRC10:37
*** EinstCrazy has quit IRC10:39
openstackgerritHelen Walsh proposed openstack/cinder: VMAX Driver - QoS support for the VMAX3  https://review.openstack.org/30750210:39
*** EinstCrazy has joined #openstack-cinder10:39
*** pdeore has quit IRC10:41
*** EinstCrazy has quit IRC10:44
*** iceyao has quit IRC10:45
*** yangyapeng has quit IRC10:46
*** laughterwym has quit IRC10:47
*** Jaison has quit IRC10:49
*** nikeshm has joined #openstack-cinder10:50
*** links has joined #openstack-cinder10:53
*** sdague has joined #openstack-cinder10:55
openstackgerrit张丹阳 proposed openstack/cinder: Fix size exceed of dd action when clearing a volume  https://review.openstack.org/32437610:56
openstackgerritnikesh proposed openstack/cinder: Ignore requests warnings in K2 cinder driver  https://review.openstack.org/34901310:56
*** alonma has joined #openstack-cinder10:57
openstackgerritGorka Eguileor proposed openstack/os-brick: Fix FC multipath cleanup  https://review.openstack.org/23113510:59
openstackgerritGorka Eguileor proposed openstack/os-brick: Fix the mocking mess  https://review.openstack.org/35051610:59
openstackgerritGorka Eguileor proposed openstack/os-brick: Fix weak test_vzstorage_with_mds_list  https://review.openstack.org/35051710:59
*** pdeore has joined #openstack-cinder11:00
openstackgerritZhang Danyang proposed openstack/cinder: Fix size exceed of dd action when clearing a volume  https://review.openstack.org/32437611:02
*** laughterwym has joined #openstack-cinder11:02
*** alonma has quit IRC11:02
openstackgerritZhang Danyang proposed openstack/cinder: Fix size exceed of dd action when clearing a volume  https://review.openstack.org/32437611:03
nikeshmvbala DuncanT: https://review.openstack.org/34901311:08
*** laughterwym has quit IRC11:11
*** alonma has joined #openstack-cinder11:11
openstackgerritnikesh proposed openstack/cinder: Concurrency issue in K2 iSCSI and FC Cinder drivers  https://review.openstack.org/35018211:16
*** alonma has quit IRC11:16
*** alonmarx has joined #openstack-cinder11:17
*** gb21 has quit IRC11:17
*** Digvijay has quit IRC11:20
openstackgerritZhang Danyang proposed openstack/cinder: Fix size exceed of dd action when clearing a volume  https://review.openstack.org/32437611:21
*** gb21 has joined #openstack-cinder11:23
*** ManishD has quit IRC11:28
*** alyson_ has joined #openstack-cinder11:28
*** alonma has joined #openstack-cinder11:36
openstackgerritZhang Danyang proposed openstack/cinder: Fix size exceed of dd action when clearing a volume  https://review.openstack.org/32437611:39
*** yangyapeng has joined #openstack-cinder11:42
*** Poornima has quit IRC11:43
*** coolsvap_ is now known as coolsvap11:45
*** tpsilva has joined #openstack-cinder11:48
openstackgerritMichal Dulko proposed openstack/cinder: Cleanup upgrade-related FIXME's  https://review.openstack.org/35053311:51
openstackgerritMichal Dulko proposed openstack/cinder: Pin RPC server's serializer to min obj version  https://review.openstack.org/35053411:51
*** markvoelker has joined #openstack-cinder11:52
openstackgerritnikesh proposed openstack/cinder: Concurrency issue in K2 iSCSI and FC Cinder drivers  https://review.openstack.org/35018212:01
*** Lee1092 has quit IRC12:03
*** alonma has quit IRC12:05
*** alonma has joined #openstack-cinder12:05
*** ducttape_ has joined #openstack-cinder12:06
*** alonma has quit IRC12:07
*** alonma has joined #openstack-cinder12:07
*** thurloat has joined #openstack-cinder12:07
*** timcl has joined #openstack-cinder12:08
smcginnise0ne: Test runs have started using the previously blocked os-brick 1.4.0 and nothing has dramatically exploded, so I've requested a 1.5.0 release to pick up the latest changes.12:09
*** alonma has quit IRC12:10
*** alonma has joined #openstack-cinder12:11
*** pdeore has quit IRC12:11
*** alonmarx has quit IRC12:12
*** alonma_ has joined #openstack-cinder12:13
*** alonma_ has quit IRC12:13
*** alonma_ has joined #openstack-cinder12:13
*** alonma has quit IRC12:15
openstackgerritCao ShuFeng proposed openstack/cinder: Fix size exceed of dd action when clearing a volume  https://review.openstack.org/35055012:16
JayConroyCould someone else have a look at this patch for me please? https://review.openstack.org/#/c/347944/ It adds support for vhd disk format for volume upload-to-image. Thanks!12:16
*** narayrak has joined #openstack-cinder12:16
*** xyang1 has joined #openstack-cinder12:16
*** gb21 has quit IRC12:19
*** edmondsw has joined #openstack-cinder12:19
*** takedakn has joined #openstack-cinder12:22
openstackgerritMerged openstack/cinder: Don't puke when exiting driver list  https://review.openstack.org/35026912:23
*** dulek has left #openstack-cinder12:25
openstackgerritMichal Dulko proposed openstack/cinder: Use volume o.vo in get_backup_volume_temp_snapshot  https://review.openstack.org/35055112:25
*** dulek has joined #openstack-cinder12:25
openstackgerritSean McGinnis proposed openstack/cinder: Fix ImportError of fake_driver  https://review.openstack.org/35055212:25
dulekhttps://review.openstack.org/#/c/246600 - looks like no one is brave enough to hit +A here. :D12:26
smcginnisdulek: Hah! I'll take a look and see if I am. ;)12:26
scottdaI ain't scared....12:27
smcginnis:)12:27
dulekscottda: terrified?12:27
nikeshmsmcginnis: hi12:27
smcginnisnikeshm: hey12:27
scottdaha12:28
duleksmcginnis: https://bugs.launchpad.net/cinder/+bug/1609208 - is that the bug you're fixing with your most recent commit?12:28
openstackLaunchpad bug 1609208 in Cinder "No module named fake_driver" [Undecided,In progress] - Assigned to Lisa Li (lisali)12:28
nikeshmsmcginnnis:  if yu get time have a look https://review.openstack.org/#/c/34893212:28
nikeshmsmcginnis:  one +2 there12:28
smcginnisnikeshm: Sure12:28
xyang1dulek: I was going to check with you to see if you are working on an update12:29
smcginnisdulek: Doh, didn't realize she already found that and had a patch up.12:29
smcginnisMultiple bugs for the same issue...12:29
*** gouthamr has joined #openstack-cinder12:30
nikeshmsmcginnis:  also  is this acceptible https://review.openstack.org/#/c/350182/4/cinder/volume/drivers/kaminario/kaminario_common.py line no 6312:30
nikeshmunit tests was failing so i did12:31
nikeshmlike that12:31
xyang1dulek: I'd rather have yours merged now so I can update my patch12:31
nikeshmin unit tests i am not using krest12:31
dulekxyang1: Oh, update on the issues Szymon mentioned on previous patchset. I've missed them.12:31
*** dulek has left #openstack-cinder12:32
*** dulek has joined #openstack-cinder12:32
dulekxyang1: Yeah, these made sense, I'll do a follow up patch.12:33
xyang1dulek: thanks.  waiting for yours to merge, then I'll need to change my patch based on it12:34
openstackgerritMerged openstack/python-cinderclient: Changed backup-restore to accept backup name  https://review.openstack.org/34494112:34
smcginnisnikeshm: I guess so. Will add to the list to look at.12:35
*** dustins has joined #openstack-cinder12:36
*** sdake has joined #openstack-cinder12:37
*** narayrak has quit IRC12:41
*** akerr has joined #openstack-cinder12:41
*** iceyao has joined #openstack-cinder12:41
*** diablo_rojo has joined #openstack-cinder12:44
e0nesmcginnis: good news, thanks Sean!12:47
*** julim has quit IRC12:48
adrianofrdulek: ping12:50
dulekadrianofr: Hi!12:51
adrianofrdulek: Hey :)12:52
adrianofrI'm fixing this https://review.openstack.org/#/c/285469/46/releasenotes/notes/hnas-drivers-refactoring-9dbe297ffecced21.yaml  according to your comments12:52
*** abhinavtechie has quit IRC12:52
*** narayrak has joined #openstack-cinder12:52
adrianofrdulek: But what command do you use to check reno format?12:52
dulekadrianofr: Just run "tox -e releasenotes". :)12:52
adrianofrdulek: I guess this is not working properly in my env then  :/12:53
adrianofrdulek: it's giving me success even without changing my reno12:53
adrianofrthat one that jenkins didn't like12:53
claudiubhemna: hello. if you have some time, can you take a look at the windows os-brick fc and smb connectors? They have a working ci, they already have a +2 from smcginnis. Thanks! https://review.openstack.org/#/c/323780/  https://review.openstack.org/#/c/323781/12:54
dulekadrianofr: You can also check out how the note itself looks like in cinder/releasenotes/build/html/index.html12:54
*** narayrak has quit IRC12:54
dulekadrianofr: reno (app we use for release notes) works on git repos and commits, so you need to have all the changes committed to have them included in the build.12:54
*** narayrak has joined #openstack-cinder12:54
dulekadrianofr: I mean - committed to your local repo, not sent to Gerrit.12:55
adrianofrdulek: hmmm. Maybe this is the problem12:55
adrianofrI was just adding the reno in the env and running the command12:55
dulekadrianofr: Most certainly that's it.12:56
adrianofrdulek: I guess it was not considering my reno then12:56
adrianofrdulek: Thanks for the help :)12:56
dulekadrianofr: http://docs.openstack.org/developer/cinder/devref/releasenotes.html12:56
openstackgerritnikesh proposed openstack/cinder: Concurrency issue in K2 iSCSI and FC Cinder drivers  https://review.openstack.org/35018212:56
openstackgerritMerged openstack/cinder: DRBD: Disk-options for new resources  https://review.openstack.org/34726712:58
openstackgerritMerged openstack/cinder: Imported Translations from Zanata  https://review.openstack.org/35047512:58
*** alonma_ has quit IRC12:59
openstackgerritnikesh proposed openstack/cinder: Ignore requests warnings in K2 cinder driver  https://review.openstack.org/34901313:00
*** alonma has joined #openstack-cinder13:01
*** rlrossit has joined #openstack-cinder13:02
*** pauloewerton has joined #openstack-cinder13:04
openstackgerritSean McGinnis proposed openstack/cinder: Remove Scality volume driver  https://review.openstack.org/34804213:05
*** alonma has quit IRC13:05
openstackgerritAdriano Freires Rosso proposed openstack/cinder: HNAS drivers refactoring  https://review.openstack.org/28546913:06
*** mriedem has joined #openstack-cinder13:06
*** alonma has joined #openstack-cinder13:08
*** diogogmt has quit IRC13:09
*** dave-mccowan has joined #openstack-cinder13:10
*** diogogmt has joined #openstack-cinder13:10
*** ducttape_ has quit IRC13:11
*** alonma has quit IRC13:13
openstackgerritnikesh proposed openstack/cinder: Ignore requests warnings in K2 cinder driver  https://review.openstack.org/34901313:14
*** alonma has joined #openstack-cinder13:16
*** porrua has joined #openstack-cinder13:17
*** markvoelker has quit IRC13:19
*** alonma has quit IRC13:20
*** Lee1092 has joined #openstack-cinder13:21
openstackgerritMerged openstack/os-brick: Splitting Out Connectors from connector.py  https://review.openstack.org/30797413:22
Dinesh_BhorHi all, Can someone please take a look at it: https://review.openstack.org/#/c/350393/13:23
*** alonma has joined #openstack-cinder13:23
*** pgadiya has quit IRC13:25
*** alonma has quit IRC13:27
*** jwcroppe has quit IRC13:28
*** takedakn has quit IRC13:28
*** nkrinner is now known as nkrinner_afk13:29
*** alonma has joined #openstack-cinder13:30
*** belmoreira has quit IRC13:31
*** diogogmt has quit IRC13:33
*** faiz89 has joined #openstack-cinder13:33
*** alonma has quit IRC13:35
*** asselin has joined #openstack-cinder13:36
*** alonma has joined #openstack-cinder13:41
*** jwcroppe has joined #openstack-cinder13:42
*** arecknag has quit IRC13:44
openstackgerritnikesh proposed openstack/cinder: Support retype in K2 cinder driver  https://review.openstack.org/34901913:46
*** markvoelker has joined #openstack-cinder13:46
*** ebalduf has joined #openstack-cinder13:53
*** eharney has joined #openstack-cinder13:54
*** akshai has joined #openstack-cinder13:54
openstackgerritMerged openstack/cinder: Switch request_spec in create volume calls to ovo  https://review.openstack.org/24660013:55
openstackgerritMerged openstack/cinder: Fix ImportError of fake_driver  https://review.openstack.org/35035713:55
*** faiz89 has quit IRC13:58
*** merooney has joined #openstack-cinder13:58
*** Yogi1 has joined #openstack-cinder13:58
*** timcl1 has joined #openstack-cinder13:59
*** faiz89 has joined #openstack-cinder14:00
*** krot_sickleave is now known as krotscheck14:00
*** akshai has quit IRC14:00
*** tongli has joined #openstack-cinder14:01
*** esker has joined #openstack-cinder14:01
*** akshai has joined #openstack-cinder14:02
*** timcl has quit IRC14:02
*** zhipeng has joined #openstack-cinder14:02
*** laughterwym has joined #openstack-cinder14:03
*** eharney_ has joined #openstack-cinder14:04
*** eharney has quit IRC14:04
*** tongli has quit IRC14:04
*** tongli has joined #openstack-cinder14:05
*** jwcroppe has quit IRC14:05
*** ducttape_ has joined #openstack-cinder14:06
*** zhipeng has quit IRC14:06
*** zhipeng has joined #openstack-cinder14:07
*** lkuchlan has joined #openstack-cinder14:07
*** lkuchlan has quit IRC14:13
*** cdelatte has joined #openstack-cinder14:21
*** links has quit IRC14:23
*** claudiub has quit IRC14:24
*** dkehn_ has quit IRC14:25
*** chris_morrell has joined #openstack-cinder14:30
openstackgerritxing-yang proposed openstack/cinder: Add group type and group specs  https://review.openstack.org/32016514:33
openstackgerritxing-yang proposed openstack/cinder: Add generic volume groups  https://review.openstack.org/32245914:33
*** dkehn_ has joined #openstack-cinder14:38
*** iceyao has quit IRC14:39
*** mtanino has joined #openstack-cinder14:40
*** diogogmt has joined #openstack-cinder14:40
*** zhipeng has quit IRC14:42
*** zhipeng has joined #openstack-cinder14:43
*** knikolla has joined #openstack-cinder14:48
*** jungleboyj has joined #openstack-cinder14:49
jungleboyjFYI ... the GPFS CI system lost a disk so it is down while they attempt to recover it.14:49
*** akapil has joined #openstack-cinder14:49
*** eharney_ is now known as eharney14:51
*** xinli has joined #openstack-cinder14:53
scottdageguileo: I'm testing the cinderclient cluster commands and getting an error:14:53
geguileoscottda: What error?14:53
scottdahttps://www.irccloud.com/pastebin/LQIxUFFE/14:53
geguileoscottda: I haven't tested it in a while...14:53
scottdageguileo: Yes, it worked previously, so some kind of regression...14:54
geguileo:'-(14:54
geguileoOk, I'll work on it14:54
scottdageguileo: thanks. I -2'd the patch, since it looked ready to merge and we probably want to hold off.14:55
geguileoscottda: Good idea14:55
*** karthikp_ has joined #openstack-cinder14:55
* geguileo really needs to start working again in the HA A/A feature14:55
smcginnisjungleboyj: Darn storage.14:58
jungleboyjsmcginnis: Oh the irony.14:59
*** dulek_ has joined #openstack-cinder14:59
scottdaeharney, xyang1, gouthamr, akerr, smcginnis, cFouts, e0ne, geguileo, dulek, flip214, ntpttr patrickeast, _alastor_, DuncanT, erlon Would you like to talk about cinder testing?14:59
eharneyhey14:59
e0nehi14:59
smcginnisSure, why not. :)14:59
geguileoo/14:59
akerrhi14:59
erlonscottda: Hi15:00
*** esker has quit IRC15:00
xyang1hi15:00
patrickeastYo15:00
e0ne#link https://etherpad.openstack.org/p/Cinder-testing15:00
cFoutshi15:00
scottdaWhat did I call this meeting? cinder-testing?15:00
*** daneyon has joined #openstack-cinder15:00
scottda#startmeeting cinder-testing15:01
smcginnisscottda: I think so.15:01
openstackMeeting started Wed Aug  3 15:01:10 2016 UTC and is due to finish in 60 minutes.  The chair is scottda. Information about MeetBot at http://wiki.debian.org/MeetBot.15:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:01
gouthamrhey15:01
openstackThe meeting name has been set to 'cinder_testing'15:01
_alastor_hey15:01
scottdaI'd hoped to go through all the patches listed in the etherpad and update stauts, etc.....I'll do that today15:02
e0neI'll propose patches with fake drivers refactoring to remove duplication, devstack integration later this week15:03
scottdaWe'd discussed some stuff at the mid-cycle. Notes are here: https://etherpad.openstack.org/p/newton-cinder-midcycle-day215:04
e0nealso, I'm going to install only cinder+keystone for the functional job15:04
scottdae0ne: +115:04
e0neI'm going to send mail to openstack-dev once pathces will be ready for review15:04
eharneykeystone for the functional job?15:05
*** nkrinner_afk has quit IRC15:05
e0neeharney: TBH, I didn't try to run cinder w/o keystone yet15:05
eharneythat doesn't sound like it fits with what we defined functional tests as two weeks ago15:05
e0neeharney: it worked few years ago, but we need to check and fix it if needed15:05
smcginniseharney: Right15:06
e0neeharney: I agree that usage of 'noauth' will be better for functional tests15:06
*** mjura has quit IRC15:06
*** jungleboyj has quit IRC15:06
eharneyat the midcycle, the agreement was that functional tests will work in an environment identical to unit tests today15:07
DuncanTnoauth is totally broken in cinder15:07
scottdae0ne: Is it much work to test 'noauth' before moving on with this?15:07
*** akapil has quit IRC15:07
e0nescottda: I didn't try to test it yet:(15:07
scottdaDuncanT: Well that answers my question...15:07
DuncanTThe easiest way forward with that would be to write a fake keystone middleware that just returns constant values15:07
*** guy has joined #openstack-cinder15:07
smcginniseharney: My understanding as well. Functional should be extended unit tests.15:08
DuncanTFunctional tests will have a real db, right?15:08
e0nesmcginnis, eharney: I propose to do it step-by-step15:08
eharneythat was already a departure from the previous definition of functional... now it looks like we're drifting elsewhere15:08
e0neDuncanT: +115:08
*** akshai has quit IRC15:09
e0neeharney: IMO, it's better to have keystone for the beginning and and functional tests with fake drivers rather than fixing noauth or fake middleware few months more15:09
*** enriquetaso has joined #openstack-cinder15:10
eharneyfor it to be "better" i think we need to define what these tests are supposed to do... which we did, i thought15:10
openstackgerritMerged openstack/cinder: Size in tintri driver should be converted to integer  https://review.openstack.org/32502515:11
smcginnisWe did. And there is no keystone as part of it.15:11
*** dulek_ has quit IRC15:11
e0ne#link https://github.com/openstack/cinder/blob/master/doc/source/devref/testing.rst#functional-tests15:11
smcginnisThat does need to be updated to be more specific.15:11
*** dulek_ has joined #openstack-cinder15:12
e0nesmcginnis, eharney: what about rabbitmq?15:12
eharneythis is where we came up with the idea of "small-scale integration" which is an environment with Cinder+rabbit+db+Keystone and nothing else15:12
*** dulek_ has quit IRC15:12
geguileoThis was said in the meeting (etherpad):15:12
geguileo    The original idea was to just have, cider, rabbit, and mysql15:12
geguileo    Anything more than that should go into tempest15:12
e0negeguileo: +115:12
eharney"original"15:13
*** dulek_ has joined #openstack-cinder15:13
geguileoI'm ok to add Keytone for a little bit as long as it's clear that it should go away15:13
*** guy has quit IRC15:14
geguileoAlthough I think it would be better to get it right from the start15:14
eharneyi don't think it's clear at all at the moment15:14
Swansonxyang1, thanks for the review15:14
smcginnisNo keystone. These should basically just be like unit testing, but the scope is to test more than a "unit".15:14
xyang1Swanson: np15:14
patrickeastIMO if we add it in now it's harder to take out later... And more than likely won't happen15:14
scottdaIf noone has time for the keystone work ATM, it pushes changes to functional tests out. Maybe no next release?15:15
patrickeastsmcginnis: +115:15
smcginnisI would even say no mysql and rabbitmq. Those don't make sense in that context.15:15
eharneysmcginnis: right15:15
*** leeantho has joined #openstack-cinder15:15
SwansonNext time it will be 2000 1 line patches.15:15
geguileoI may be getting a little lost here15:15
geguileoThen what are we going to test?15:15
geguileoAre we going to fake all DB access and messaging?15:15
e0nescottda: I'll take a look on it15:15
eharneythe idea was to have unit tests be unit tests and huge run-through-ten-modules tests be in functional tests15:16
*** julim has joined #openstack-cinder15:16
e0nescottda: I mean how to run cinder w/o keystone15:16
smcginnisAnything outside of Cinder should be mocked.15:16
eharneybut they are essentially the same test setup, just with different styles of tests15:16
smcginnisJust like we do for unit testing - anything outside the unit we are testing should be mocked.15:16
e0nesmcginnis: are you talking about unit tests?15:16
xyang1Swanson: that will bump yiur stats!15:16
smcginnise0ne: Functional testing.15:16
geguileosmcginnis: So we won't be testing in functional tests anything that goes from API to Scheduler and then to the volume, right?15:16
smcginnisgeguileo: Correct.15:16
*** nkrinner_afk has joined #openstack-cinder15:17
smcginnisAlthough it can go from the API level through, but not a running deployment.15:17
e0nesmcginnis: :(15:17
smcginnisJust calling the methods.15:17
e0nesmcginnis: it makes functional tests not useful, IMO15:17
smcginnise0ne: It makes them extremely useful.15:17
e0nesmcginnis: it becases the same as unit + DB15:17
smcginnisAnd give us a way to get out of the mess that our current unit tests are.15:18
eharneyso i posted a question on the etherpad about this issue as well15:18
*** akshai has joined #openstack-cinder15:18
smcginnisUnit tests should actually be unit tests - but right now they are not.15:18
eharneyi think having the current (midcycle) functional tests be a separate job is problematic15:18
nikeshmsmcginnis: are yu familiar with Traceback in http://54.209.116.144/19/349019/13/check/kaminario-dsvm-tempest-full-iscsi/f871021/logs/screen-c-vol.txt.gz15:18
smcginnisThe next level up will allow us to test interaction between different modules.15:19
nikeshmi m getting today15:19
*** RageLtMan has joined #openstack-cinder15:19
scottdaeharney: Yeah, the py3 issue makes sense as a problem/blocker15:19
nikeshmthis in iscsi15:19
nikeshmjob15:19
nikeshmwhen running15:19
eharneyif we're doing this version of functional tests, they should probably be run in the same jobs that run the unit tests15:19
smcginniseharney: I don't think so.15:19
*** jungleboyj has joined #openstack-cinder15:19
*** akapil has joined #openstack-cinder15:19
eharneysmcginnis: there are at least two downsides to having them in a separate job, i'm not sure what the upsides are15:20
nikeshmany one familiar with Traceback in http://54.209.116.144/19/349019/13/check/kaminario-dsvm-tempest-full-iscsi/f871021/logs/screen-c-vol.txt.gz15:20
smcginnisIt's a different scope of testing. Unit tests should be our basic level of tests run.15:20
smcginnisFunctional expands on that, but is good to separate so they are not run for basic validation.15:21
eharneysure, but to do this right, we need py27 and py3 functional jobs15:21
smcginnisThat's true.15:21
eharneyand i'd like to be able to see coverage stats for both combined, but i guess that can be sorted out in tox.ini somehow outside of how we do jobs15:21
jgriffithnikeshm: looks like privsep stuff :(15:21
*** vbala has quit IRC15:21
*** akapil has quit IRC15:22
*** akapil has joined #openstack-cinder15:22
eharneyso i guess we'll just make a functional-py3 job then?15:22
*** dkehn_ has quit IRC15:22
e0neI'm afraid to ask, but...15:23
*** sheel has joined #openstack-cinder15:23
e0neif we are so interested in functional-py3 jib, why nobody don't talk about tempest-py3 job?15:23
jgriffithe0ne: +115:23
eharneysounds like a good idea to me15:24
smcginnisMaybe "integration" testing would be a better name for these. Unit testing for units of code, integration for the interaction between these units, functional then defined as run against a running instance,15:24
*** dave-mccowan has quit IRC15:24
nikeshmjgriffith: any solution to avoid that in our CI15:24
smcginnise0ne: DOn't we have that already?15:24
geguileonikeshm: I think the problem is that scsi_transport_fc module is not loaded in the system15:24
e0nesmcginnis: maybe in an experimental queue only15:24
eharneysmcginnis: i think that's backwards from normal terminology which is part of what jgriffith was trying to fix15:24
e0neintegration between modules sounds interesting15:24
jgriffithgeguileo: indeed, but I can't figure out if it failed to load because of privsep error or just wasn't included?15:25
e0nebut ingetration between different cinder components should be done too15:25
dulek_haypo was talking that py3 tempest is another step in his conversion efforts.15:25
Swansonsmcginnis, integration tests are for testing against a running instance.15:25
geguileojgriffith: True15:25
smcginnisSwanson: It seems most folks have different definitions of integration vs testing.15:25
smcginnis* vs functional.15:25
jgriffithsigh.. here we go again15:25
e0neI won't hollywar ot bukeshed on what is func. testing15:25
jgriffithe0ne: +115:25
geguileoe0ne: I agree, but maybe those should be integration tests to differentiate them from functional15:26
e0neI'll propose my patches and send links  to the mailing list15:26
smcginnisBut I thought we were being consistent with what other projects were calling the types of testing.15:26
jgriffithCall it other-testing AFAIAC this is rather silly15:26
eharneywell... "Tempest - The OpenStack Integration Test Suite" already exists, so let's not redefine it to something else15:26
smcginnisjgriffith: +a15:26
jgriffithsmcginnis: yes, that was the whole point and the hour long discussion in Ft Collins15:26
xyang1e0ne: jgriffith have we decided on the fake driver name yet15:26
smcginnisAs long as we differentiate the type of testing for one vs the other.15:26
jgriffithsmcginnis: which for some reason we've decided we need to talk about and rhash again15:26
smcginnisjgriffith: I agree. I thought we had it all set. But apparently not.15:27
geguileoeharney: Sure, but it also says: "This is a set of integration tests to be run against a live OpenStack cluster."15:27
Swansonthe jgriffith memorial test suite.15:27
e0nexyang1, jgriffith: AFAIR, we desided to use FakeLoggingDriver and FakeGateDriver names15:27
smcginnisgeguileo: Stale comments in the etherpad I believe.15:27
xyang1e0ne: ok15:27
smcginnishttps://www.youtube.com/channel/UCJ8Koy4gsISMy0qW3CWZmaQ15:28
geguileosmcginnis: Not really, it's from here http://docs.openstack.org/developer/tempest/overview.html15:28
e0nee.g. python-heatclient funcitonal tests http://logs.openstack.org/79/345379/12/check/gate-heatclient-dsvm-functional/14d3a7e/15:28
e0ne#link http://logs.openstack.org/79/345379/12/check/gate-heatclient-dsvm-functional/14d3a7e/15:28
geguileoeharney: And we are talking about integration tests where we should be able to have an error generator, right?15:28
scottdasmcginnis: How about you post a devref patch that states what you/we think are the definitions, we review and, once merged, we take that as the definitions?15:28
e0neI like how Heat team implemented funcitonal tests15:28
geguileoscottda: +115:28
eharneye0ne: what do those tests do?15:28
nikeshmgeguileo: jgriffith: do we need that module in iscsi driver testing15:29
smcginnisgeguileo: OK, then back to the four levels we defined: unit tests, functional tests, integration tests, tempest.15:29
e0neeharney: they setup minimal devstack with heat components only15:29
jgriffithscottda: I'll post it, but frankly you were there in the meeting and I specifically asked you if you understood and agreed.  You did15:29
geguileosmcginnis: I'm fine with that15:29
eharneye0ne: this is what i was proposing as "small scale integration"15:29
*** xinli has quit IRC15:29
jgriffitheharney: then propose that, don't stop progress on something else that somebody has started (ie e0ne )15:30
scottdajgriffith: It's not about agreement/disagreement, it's about getting it into the devref so we all know what the defs are.15:30
eharneyjgriffith: i'm not stopping progress on anything15:30
jgriffithscottda: fine, devref patch coming up15:30
jgriffitheharney: ok15:30
jgriffitheharney: sorry15:30
eharneyaccording to what we defined at the midcycle, the functional test environment is done and just needs tests, not more components added15:30
*** xinli has joined #openstack-cinder15:30
jgriffitheharney: +115:30
smcginniseharney: +115:31
geguileonikeshm: In the logs I see "Fetching connector for FibreChannelConnector get_connector_properties" before the error15:31
e0neand we will have 10 functional, 3 "small scale integration" tests in the end of O release15:31
*** timcl1 has quit IRC15:32
jgriffithscottda: can you clarify what's missing from the devref for me?15:32
e0neI don't want to spray attention on too many of test types15:32
geguileonikeshm: http://54.209.116.144/19/349019/13/check/kaminario-dsvm-tempest-full-iscsi/f871021/logs/screen-c-vol.txt.gz#_2016-08-03_14_49_56_92915:32
scottdahttps://www.irccloud.com/pastebin/4qBAq2bp/15:32
*** dkehn_ has joined #openstack-cinder15:32
jgriffithscottda: http://docs.openstack.org/developer/cinder/devref/testing.html15:32
scottdaDo we agree that functional tests run with a database?15:33
smcginnisThat last section should be removed, IMO.15:33
scottdaI thought that was contentious?15:33
scottdasmcginnis: Ok, so that needs changing15:33
xyang1e0ne: do you have any patch that moves the fake driver?  or are we all set using the existing LoggingDriver to write the functional tests?15:33
jgriffithsmcginnis: the non-cinder services part?15:33
smcginnisAnd we should add Integration Tests with a description of the "small scale integration" work being done now.15:33
smcginnisjgriffith: The "database present and may start Cinder services to accept requests" I think.15:33
e0nexyang1: I don't know now15:33
jgriffithok15:34
scottdaAnd messageQ will run with "small scale integration", right?15:34
scottdaWe also have nothing in the devref to differentiate between in-tree tempest and upstream15:35
eharneyin-tree tempest vs upstream tempest is not a very interesting distinction IMO15:35
xyang1e0ne: ok, I'll start with the existing LoggingDriver and will change if needed15:36
eharneythey're tests run in the same environments, it's just where the code lives15:36
scottdaeharney: So how to people know where the tests should go?15:36
e0nexyang1: ok. I'll ping you if i have any update on fake frivers15:36
eharneyscottda: yeah, true, we do need to document that15:36
xyang1e0ne: ok, thanks15:37
*** timcl has joined #openstack-cinder15:37
scottdaI don't recall coming to a decision at the mid-cycle around how to decide in-tree vs. out-of-tree for tempest?15:38
eharneymy working assumption is that in-tree is for things that we want to test that is outside of the scope of what tempest wants15:38
eharney(what tempest wants as a project etc)15:39
jgriffithsmcginnis: scottda https://gist.github.com/j-griffith/063574aac688d9a383bf6fe4a50f00c915:39
scottdaeharney: Yes, that seems correct. But I think we need to codify that and put that in the devref.15:39
*** itlinux has joined #openstack-cinder15:39
jgriffithdoes that work for the Functional section at least?15:39
scottdajgriffith: Doesn't that mean we need messageQ running ?15:40
smcginnisjgriffith: I would think even less than that. It wouldn't necessarily be all the way from API to driver. Could just be between two modules.15:40
*** karthikp__ has joined #openstack-cinder15:40
jgriffithsmcginnis: ok, but just to be clear, there's no mechanism in there right now to fake those sorts of things out15:42
jgriffithsmcginnis: it's indeed "functional" in that it uses a client and send REAL API cmds15:43
jgriffiths/send/sends/15:43
smcginnisjgriffith: I think that's why it needs to state a smaller scope. Just unit test style tests that validate code paths between more than just a unit of code.15:43
e0nejgriffith: +115:43
smcginnisThey almost fit "integration" testing in my definition more than "functional".15:43
jgriffithI'm no longer interested in trying to drive this to concensus or to try and *force* my opinion or the methodology used in other OpenStack projects15:44
e0nesmcginnis: you've just described most of our "unit15:44
e0ne" tests15:44
eharneye0ne: which is why we want to move a lot of unit tests to functional tests15:44
smcginnise0ne: Right, which is  aproblem.15:44
smcginnisA lot of our unit tests right now are not unit tests.15:44
e0nejgriffith: +1 :(15:44
jgriffithrather than bike-shed on this why don't people write/propose tests and see how things go?15:45
*** pece has joined #openstack-cinder15:45
dulek_jgriffith: +115:45
scottdaBecause then we'll keep having this conversation...15:45
smcginnisjgriffith: I think we need at least a general consensus so it's not chaos. But we can try that.15:45
jgriffithscottda: not if you don't keep bringing it up15:45
hemnamornin15:45
scottdaWhy not just draw the lines somewhere, write it down (in the devref) and be done with it.15:45
jgriffithI did and we've done nothing but argue about it :)15:46
eharneyscottda: i think we have a good idea of what to propose in the devref now, seems like a good idea15:46
scottdaThat's why I said, smcginnis put up a patch with the definitions and be done with it.15:46
smcginnisjgriffith: I can try proposing something to the devref if you'd prefer. Then we can bikeshed on that. :)15:46
jgriffithOk15:46
scottdaor jgriffith or whomever. I don't care what the defs are, just define them once and for all15:46
jgriffithsmcginnis: as long as we have something to bikeshed about :)15:46
geguileosmcginnis: +115:46
jgriffithsmcginnis: I'll pass the torch to you, because frankly I can't figure out how to appease all of this15:47
*** laughterwym has quit IRC15:47
smcginnis;015:47
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: CI: Add CI_WIKI_NAME to all drivers  https://review.openstack.org/34800215:48
scottda#action smcginnis Will put up a devref patch with definitions for unit, functional, small scale integrations, in-tree vs. out-of-tree tempest15:49
scottdasmcginnis: OK?15:49
smcginnisscottda: +115:49
*** akapil has quit IRC15:49
scottdaAnyone have anything else today? Or shall be break before the Next Exciting Meeting?15:50
scottda#endmeeting15:50
openstackMeeting ended Wed Aug  3 15:50:50 2016 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:50
openstackMinutes:        http://eavesdrop.openstack.org/meetings/cinder_testing/2016/cinder_testing.2016-08-03-15.01.html15:50
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/cinder_testing/2016/cinder_testing.2016-08-03-15.01.txt15:50
openstackLog:            http://eavesdrop.openstack.org/meetings/cinder_testing/2016/cinder_testing.2016-08-03-15.01.log.html15:50
smcginnisscottda: Thanks15:50
openstackgerritLucian Petrut proposed openstack/os-brick: Add Windows Fibre Channel connector  https://review.openstack.org/32378015:57
openstackgerritLucian Petrut proposed openstack/os-brick: Add Windows SMBFS connector  https://review.openstack.org/32378115:57
*** locust has quit IRC15:57
*** JoseMello has joined #openstack-cinder15:57
*** akshai has quit IRC15:59
flip214meeting?15:59
openstackgerritIvan Kolodyazhny proposed openstack/python-brick-cinderclient-ext: Add reno for release notes management  https://review.openstack.org/35066215:59
hemnaheh15:59
hemnamerge conflict city in os-brick patches now15:59
e0nehemna: is't refactoring!16:00
*** baumann has joined #openstack-cinder16:00
hemnayah, we finally got that one to land16:01
*** laughterwym has joined #openstack-cinder16:03
*** sv7577 has joined #openstack-cinder16:03
*** bardia has joined #openstack-cinder16:03
*** bardia has quit IRC16:04
*** pbandark has quit IRC16:06
*** jistr is now known as jistr|biab16:06
*** Yogi1 has quit IRC16:09
*** bardia has joined #openstack-cinder16:12
*** bardia has quit IRC16:13
*** sv7577 has quit IRC16:14
*** alonma has quit IRC16:19
*** seldenr has joined #openstack-cinder16:20
*** jdurgin1 has joined #openstack-cinder16:21
*** jistr|biab is now known as jistr16:22
flip214DuncanT: re 347274: I was *soooo* happy that all the voting CIs finally said "okay" that I forgot to look at the DRBD output ;/16:25
DuncanTflip214: Ha :-)16:25
*** alonma has joined #openstack-cinder16:27
*** faiz89 has quit IRC16:27
*** dansmith has quit IRC16:27
*** Apoorva has joined #openstack-cinder16:27
*** zhipeng has quit IRC16:27
flip214DuncanT: the later patches in that series are okay, though, so I guess it's only a temporary problem.16:28
*** dansmith has joined #openstack-cinder16:28
*** dansmith is now known as Guest2098816:28
*** zhipeng has joined #openstack-cinder16:28
flip214if it's really that patch, just approve the next one too ;)16:28
openstackgerritMerged openstack/cinder: Support replication in K2  https://review.openstack.org/34893216:28
*** Guest20988 is now known as dansmith16:29
*** akshai has joined #openstack-cinder16:30
flip214especially, I wouldn't know how *that* patch might be wrong...16:30
*** alonma has quit IRC16:31
*** akshai_ has joined #openstack-cinder16:32
*** Guest6612 has joined #openstack-cinder16:32
*** narayrak has quit IRC16:33
DuncanTflip214: Recheck is certainly an option, but if you've no way to figure out what happened, it might indicate that more logging in the CI would be useful :-)16:33
*** sdague has quit IRC16:34
*** wilson_liu has quit IRC16:35
*** akshai has quit IRC16:35
flip214DuncanT: I can tell you more details tomorrow, if you like. (I hope ;)16:36
DuncanTflip214: Great, thanks. I've a natural aversion to recheck-and-hope, but I generally understand that sometimes it is the only way. Nice to know what extra info would be useful though16:37
*** rcernin has quit IRC16:38
*** laughterwym has quit IRC16:38
erlonxyang1: so, splinting the patch will not be a good idea16:38
*** alonma has joined #openstack-cinder16:39
*** alonmarx has joined #openstack-cinder16:40
xyang1erlon: I was just concerned about CI passing.  It will be easier to get things merged if you splitting them16:41
openstackgerritEric Harney proposed openstack/cinder: Add functional-py34 to tox  https://review.openstack.org/35068516:41
*** alonma has quit IRC16:43
*** sdague has joined #openstack-cinder16:43
*** pece has quit IRC16:44
*** e0ne has quit IRC16:44
erlonxyang1: hmm, I see, so each driver change would be part of a depended patch16:45
*** Suyi_ has joined #openstack-cinder16:45
*** alonma has joined #openstack-cinder16:46
xyang1erlon: you submit the first patch for common code changes and LVM, after that is merged, you won't have dependencies16:46
*** chris_morrell has quit IRC16:47
erlonxyang1: that would be a problem as there would be cross dependencies, for example, there's a change in driver.py, and in the create_flow.py that will call the new defined function in BaseVD. If this merge first, all other drivers will be automatically broken16:49
xyang1erlon: ok16:50
erlonxyang1: unless each driver redefines the function from the base class16:50
*** alonma has quit IRC16:50
openstackgerritGorka Eguileor proposed openstack/os-brick: Fix FC multipath cleanup  https://review.openstack.org/23113516:50
openstackgerritGorka Eguileor proposed openstack/os-brick: Fix weak test_vzstorage_with_mds_list  https://review.openstack.org/35051716:50
openstackgerritGorka Eguileor proposed openstack/os-brick: Fix the mocking mess  https://review.openstack.org/35051616:50
patrickeastanyone know what the tempest "backendX_name" tempest conf variables are for? looking at the tests it only looks for "backend_names" as a csv list of backend names16:50
openstackgerritGorka Eguileor proposed openstack/os-brick: Fix FC multipath rescan  https://review.openstack.org/34959816:51
patrickeasthaha "Fix the mocking mess"16:51
erlonpatrickeast: multi-backend vs single backend?16:52
erlonI think scottda added the backend_names16:52
patrickeasterlon: nah it does numbered backend names https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L46016:52
patrickeasterlon: but the tests look for "backend_names"16:52
*** krotscheck is now known as kro_focused16:53
*** Gao has joined #openstack-cinder16:53
patrickeastwell, i'll put up a patch to change it... hopefully it doesn't break too much16:53
*** zhongjun_ has quit IRC16:53
*** Lallana has quit IRC16:53
*** alonma has joined #openstack-cinder16:53
*** zhongjun_ has joined #openstack-cinder16:55
erlonpatrickeast: https://review.openstack.org/#/c/325895/10/lib/tempest16:55
*** Guest6612 has quit IRC16:55
*** Guest6612 has joined #openstack-cinder16:55
patrickeastooo sweet16:56
patrickeastless work16:56
*** Gao has quit IRC16:56
*** Gao has joined #openstack-cinder16:56
*** smile-luobin has quit IRC16:56
patrickeastdang, thats the wrong list though unless there is a tempest patch to go with it16:57
patrickeastscottda: got a min to chat about that patch?16:58
*** alonma has quit IRC16:58
*** pcaruana has quit IRC17:00
*** tesseract- has quit IRC17:03
*** jwcroppe has joined #openstack-cinder17:04
*** openstackgerrit_ has joined #openstack-cinder17:07
*** openstackgerrit_ has quit IRC17:08
nikeshmvbala:  there17:08
nikeshm?17:08
*** akshai_ has quit IRC17:11
*** lpetrut has quit IRC17:11
*** karthikp_ has quit IRC17:11
*** karthikp__ is now known as karthikp_17:11
_alastor_Does get_manageable_volumes have a commandline option?17:20
*** eharney has quit IRC17:20
_alastor_Specifically a way to display that information via a CLI command17:20
*** dave-mccowan has joined #openstack-cinder17:20
hemna_alastor_, I thought that was the entire point of that api17:21
patrickeastoh, did that thing merge?17:21
hemnato dump out the available volumes on the backend17:21
hemnaugly API17:21
hemnasadness17:21
_alastor_hemna: Yeah, I thought that too, but there doesn't seem to be a CLI option for it that I've found17:21
_alastor_cinder --help | grep manage isn't helping17:22
patrickeast_alastor_: its possible there isn't a change to cinderclient for it, or its still in review17:22
hemnahttps://review.openstack.org/#/q/project:openstack/python-cinderclient17:22
hemnaI just started looking in there for it17:22
*** dave-mcc_ has joined #openstack-cinder17:22
hemnaI think avishay did the cinder change no ?17:23
_alastor_Here's the cinder change: https://review.openstack.org/#/c/285296/17:23
_alastor_looks like a merge conflict17:23
_alastor_https://review.openstack.org/#/c/28538117:23
hemnaoopsie17:24
_alastor_No activity since february...17:24
_alastor_Wait, may17:24
openstackgerritnikesh proposed openstack/cinder: Support retype in K2 cinder driver  https://review.openstack.org/34901917:25
*** zhangjn has quit IRC17:26
*** zhangjn has joined #openstack-cinder17:27
*** dave-mccowan has quit IRC17:27
patrickeast_alastor_: you wanna resurrect the client change?17:27
*** e0ne has joined #openstack-cinder17:27
_alastor_patrickeast: Never done one, but it seems like something we would want in newton17:27
hemnapatrickeast, +117:27
hemnayah17:27
hemnathe driver API is useless w/o the cinderclient change in17:28
patrickeastif no one else does  sometime in the next few weeks i'll implement that driver api on the pure drivers and can go poke that thing too, although i guess if we are getting close to client freeze i needs to be done soonish right?17:28
*** e0ne has quit IRC17:28
patrickeasthemna: pff i openstack via curl exclusively17:28
hemnapatrickeast, just pull the patch and rebase it17:28
*** alonma has joined #openstack-cinder17:28
_alastor_patrickeast: this is something my SEs want, so I have motivation to get it in17:28
patrickeast_alastor_: sounds good to me, it does look like it might just take a rebase and some tweaking based on the review feedback... shouldn't be too crazy17:30
_alastor_patrickeast: I can just `git review -d` it, then perform the rebase and any subsequent `git review` will post to this review?17:30
patrickeast_alastor_: yep17:31
hemna_alastor_, yes17:31
_alastor_patrickeast: cool17:31
nikeshmhi i address vipin comment on https://review.openstack.org/#/c/34901917:31
nikeshmcan someone please check  is it correct17:32
*** alonma has quit IRC17:33
*** alonma has joined #openstack-cinder17:35
*** lpetrut has joined #openstack-cinder17:37
*** alonmarx_ has joined #openstack-cinder17:37
*** alonma has quit IRC17:40
*** alonmarx has quit IRC17:40
openstackgerritLucian Petrut proposed openstack/os-brick: Add Windows Fibre Channel connector  https://review.openstack.org/32378017:40
openstackgerritLucian Petrut proposed openstack/os-brick: Add Windows SMBFS connector  https://review.openstack.org/32378117:40
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: LeftHand add entry point tracing  https://review.openstack.org/33912817:42
*** lkuchlan has joined #openstack-cinder17:42
*** alonma has joined #openstack-cinder17:43
*** e0ne has joined #openstack-cinder17:43
*** faiz89 has joined #openstack-cinder17:46
*** alonma has quit IRC17:47
*** zhipeng has quit IRC17:47
*** alonma has joined #openstack-cinder17:50
*** RageLtMan has quit IRC17:51
smcginnise0ne: Oops. :)17:51
*** lpetrut has quit IRC17:52
e0nesmcginnis: np :)17:52
*** julim has quit IRC17:53
*** alonma has quit IRC17:54
*** diogogmt has quit IRC17:54
*** julim has joined #openstack-cinder17:56
scottdapatrickeast: My latest patch to "Add a multibackend list to tempest.conf" needs some work...17:56
*** diogogmt has joined #openstack-cinder17:57
scottdapatrickeast: Sorry about the confusion17:57
*** alonma has joined #openstack-cinder17:57
*** harlowja has quit IRC17:58
scottdapatrickeast: The change to add backend_names to tempest was done by someone else: af136a9617:58
*** haplo37__ has joined #openstack-cinder17:59
*** alonmarx_ has quit IRC17:59
*** dulek_ has quit IRC17:59
*** e0ne has quit IRC18:00
*** harlowja has joined #openstack-cinder18:00
nikeshmhemna: any solotion of http://54.209.116.144/82/350182/5/check/kaminario-dsvm-tempest-full-iscsi/0dcadef/logs/screen-c-vol.txt.gz#_2016-08-03_15_44_24_00918:01
nikeshmsolution18:01
*** alonma has quit IRC18:02
nikeshmi m hitting this sometimes in CI18:02
* hemna looks18:02
hemnaheh18:03
hemna*sigh*18:03
hemnathat's privsep for you18:03
hemnait logs everything as WARNING18:03
hemnaregardless18:03
hemnahate it18:03
*** alonmarx has joined #openstack-cinder18:03
hemnanikeshm, https://review.openstack.org/#/c/339275/18:03
*** lpetrut has joined #openstack-cinder18:03
hemnanikeshm, and.....https://review.openstack.org/#/c/350415/18:04
*** fernnest has joined #openstack-cinder18:04
*** alonma has joined #openstack-cinder18:04
hemnanikeshm, so that systool -c fc_host -v "error" is  normal18:04
hemnaon hosts that don't have Fibre Channel18:05
hemnaprior to privsep, os-brick used oslo_concurrency processutils to execute commands18:05
hemnaputils doesn't automatically log all stderr18:05
hemnait captures it and lets the caller deal with it.18:05
hemnaos-brick puts a try catch around the call to systool and if there is a failure (no FC HBA's installed) it catches it and correctly ignores it18:06
hemnanow privsep just dumps all stderr/stdout to WARNING logs.18:06
hemnawhich is bogus18:06
*** dave-mcc_ has quit IRC18:08
*** alonma has quit IRC18:09
*** wxy__ has quit IRC18:10
*** alonma has joined #openstack-cinder18:12
*** bardia has joined #openstack-cinder18:12
*** wxy__ has joined #openstack-cinder18:13
*** alonma has quit IRC18:17
*** ntpttr has quit IRC18:17
*** alonma has joined #openstack-cinder18:19
*** nikeshm has quit IRC18:21
*** alonma has quit IRC18:23
*** timcl1 has joined #openstack-cinder18:24
*** nikeshm has joined #openstack-cinder18:25
*** sheel has quit IRC18:26
*** alonma has joined #openstack-cinder18:26
*** timcl has quit IRC18:27
nikeshmjgriffith geguileo hemna:  sorry problem was different for failure in my case http://54.209.116.144/82/350182/5/check/kaminario-dsvm-tempest-full-iscsi/0dcadef/logs/screen-c-vol.txt.gz#_2016-08-03_15_45_31_33218:28
nikeshmsomehow i missed18:28
hemnayour destination volume is too small18:31
*** alonma has quit IRC18:31
*** wilson_liu has joined #openstack-cinder18:31
*** Guest6612 has quit IRC18:32
*** DiaoSi has joined #openstack-cinder18:34
*** lprice has joined #openstack-cinder18:35
*** alonma has joined #openstack-cinder18:35
*** Gao has quit IRC18:38
*** angela-s has joined #openstack-cinder18:38
*** alonma has quit IRC18:39
*** alonmarx has quit IRC18:41
*** dustins has quit IRC18:41
*** alonma has joined #openstack-cinder18:42
*** alonmarx has joined #openstack-cinder18:43
johnplanowI'm looking to add unit test coverage for manage_existing functionality per https://bugs.launchpad.net/cinder/+bug/1599140 but..18:43
openstackLaunchpad bug 1599140 in Cinder "manage_existing flow has poor unit test coverage" [Undecided,New]18:43
johnplanowI'm diving into this project for the first time and having a bit of trouble understanding how all the layers fit together.18:43
johnplanowWould someone mind spending 15 mins getting me pointed in the right direction?18:43
*** dustins has joined #openstack-cinder18:45
*** ametts has joined #openstack-cinder18:45
*** julim has quit IRC18:46
*** alonma has quit IRC18:47
*** darosale has joined #openstack-cinder18:48
*** jdurgin1 has quit IRC18:48
*** alonma has joined #openstack-cinder18:49
scottdajohnplanow: Hi18:51
hemnajohnplanow !18:52
scottdajohnplanow: michal has stated in the bug that a good example for manage_existing tests are in cinder.tests.unit.test_volume.VolumeTestCase.test_create_delete_volume18:52
hemna:)18:52
hemnaback in the tech game18:52
scottdajohnplanow: Are you  wondering how the layers of cinder work together?18:52
*** alonma has quit IRC18:54
nikeshmxyang smcginnis : addressed all reviews on retype https://review.openstack.org/#/c/349019 and CI also happy, waiting fo jenkins18:54
nikeshmxyang1:18:54
scottdajohnplanow: uh-oh, I see from that test there are things we no longer want in unit tests, like calling the Database...18:54
scottdaSo not a good example maybe.18:54
*** haplo37__ has quit IRC18:55
*** lpetrut has quit IRC18:55
*** lpetrut has joined #openstack-cinder18:55
fernnestsmcginnis, please confirm, HPE_XP CI is back online and reporting.18:56
*** alonmarx has quit IRC18:56
*** eharney has joined #openstack-cinder18:58
xyang1nikeshm: hi18:59
xyang1nikeshm: ok, I'll take a look18:59
nikeshmxyang1: thanks18:59
*** alonmarx has joined #openstack-cinder19:00
*** diogogmt has quit IRC19:00
*** karthik__ has joined #openstack-cinder19:01
diablo_rojoxyang1: Thank you for merging the brick refactor :) That was merge conflict hell for a while, so I am happy it's over.19:02
xyang1diablo_rojo: welcome:)19:03
*** alonma has joined #openstack-cinder19:04
*** dave-mccowan has joined #openstack-cinder19:04
johnplanowscottda: yes, wondering how the layers of cinder work together.19:05
johnplanowhemna: hey! long time!19:06
*** porrua has quit IRC19:06
*** fifieldt has quit IRC19:07
*** haplo37__ has joined #openstack-cinder19:07
bardiaCan I get some of the cores' attention to this: https://review.openstack.org/#/c/346238 :)19:07
johnplanowscottda: maybe there's a better example?19:07
*** alonma has quit IRC19:09
smcginnisfernnest: Looks good.19:10
*** timcl has joined #openstack-cinder19:10
smcginnisfernnest: Hmm, that's skipping a lot of tests for core functionality (?!.*test_snapshots_actions)19:10
smcginnisfernnest: Can you clean up that list a little. I could see a few of those, but really are too many being skipped I think.19:11
*** alonma has joined #openstack-cinder19:11
jungleboyjxyang1: Question for you ...19:11
*** timcl1 has quit IRC19:13
*** Lee1092 has quit IRC19:13
scottdajohnplanow: You could start with the developer's reference: http://docs.openstack.org/developer/cinder/devref/19:14
scottdajohnplanow: I cannot guarantee that info is all up-to-date, or complete.19:14
*** alonma has quit IRC19:16
xyang1jungleboyj: sure19:17
jungleboyjxyang1: So, where do things stand with Tiramisu and Newton.  Is it going to land or not?19:17
jungleboyjI haven't been able to follow that as closely as I would like.19:18
*** jdurgin1 has joined #openstack-cinder19:18
xyang1jungleboyj: I am working on the groups patches first19:18
jungleboyjxyang1: Right.19:18
xyang1jungleboyj: there are 4 patches I need to get in before Tiramisu19:18
*** fifieldt has joined #openstack-cinder19:19
jungleboyjOk, so all the generic grouping stuff first.19:19
*** alonma has joined #openstack-cinder19:19
*** alonmarx has quit IRC19:19
xyang1jungleboyj: this is the first one: https://review.openstack.org/#/c/320165/19:20
xyang1jungleboyj: I am updating the other patches now that request_spec has a ovo19:20
xyang1jungleboyj: would appreciate if you could help review them19:21
*** alonmarx has joined #openstack-cinder19:22
johnplanowscottda: ok, i'll dig in a little deeper with that. thanks.19:22
jungleboyjxyang1: Ok.  Will try to look at them.  So, there is still quite a bit of work to get the generic groups in place.  The tiramisu probably won't make it until Ocata then?19:23
jungleboyjxyang1: The driver developers here are just wondering what to plan.19:23
*** zul_ has joined #openstack-cinder19:23
*** alonma has quit IRC19:24
xyang1jungleboyj: probably, we only have a month left.  if all patches get merged soon, we still have hope to get Tiramisu in19:24
jungleboyjxyang1: Ok.  Makes sense.19:24
nikeshmtesting i am online19:28
nikeshmok19:28
*** lkuchlan has quit IRC19:28
*** alonma has joined #openstack-cinder19:29
*** nikeshm has quit IRC19:31
*** tesseract- has joined #openstack-cinder19:31
*** ametts has quit IRC19:32
*** alonma has quit IRC19:33
*** clenimar has quit IRC19:34
*** diogogmt has joined #openstack-cinder19:34
*** clenimar has joined #openstack-cinder19:35
*** zul_ has quit IRC19:35
*** gouthamr has quit IRC19:35
*** zul_ has joined #openstack-cinder19:35
*** alonma has joined #openstack-cinder19:36
*** tesseract- has quit IRC19:37
*** timcl has quit IRC19:39
*** alonma has quit IRC19:40
*** gouthamr has joined #openstack-cinder19:45
*** ametts has joined #openstack-cinder19:45
*** dulek_ has joined #openstack-cinder19:47
*** alonmarx has quit IRC19:47
*** chris_morrell has joined #openstack-cinder19:50
*** alonmarx has joined #openstack-cinder19:51
*** permalac has quit IRC20:02
*** permalac has joined #openstack-cinder20:03
openstackgerritMerged openstack/cinder: Remove Tegile volume driver  https://review.openstack.org/34803220:05
*** jungleboyj has quit IRC20:06
*** porrua has joined #openstack-cinder20:09
*** lpetrut has quit IRC20:10
*** alonma has joined #openstack-cinder20:10
*** coolsvap has quit IRC20:11
_alastor_patrickeast: There seems to be some conflict over whether the name on the backend device is called an "identifier" or a "reference"20:14
*** alonma has quit IRC20:15
_alastor_patrickeast: The implemented Cinder API says it's a "reference", but the help for all manage calls referrs to it as  an "identifier", which due to the nature of python-cinderclient, means it can't find any "identifier" attribute from the api20:15
*** chris_morrell has quit IRC20:16
_alastor_patrickeast: having fun already :)20:16
*** merooney has quit IRC20:16
*** alonma has joined #openstack-cinder20:17
*** jungleboyj has joined #openstack-cinder20:18
patrickeast_alastor_: haha, well, it can't be tooo eazy20:19
*** alonmarx has quit IRC20:19
patrickeast_alastor_: i would have it match the api given the choice20:19
_alastor_patrickeast: gonna have to update the regular manage commands.  Shouldn't be too hard...20:22
patrickeast_alastor_: easy peasy XD20:22
*** alonma has quit IRC20:22
*** alonmarx has joined #openstack-cinder20:23
*** alonma has joined #openstack-cinder20:26
*** akapil has joined #openstack-cinder20:28
*** dustins has quit IRC20:30
*** porrua has quit IRC20:30
*** alonma has quit IRC20:30
fernnestsmcginnis, will do.20:31
*** karthik__ has quit IRC20:33
*** alonma has joined #openstack-cinder20:33
*** akapil has quit IRC20:36
_alastor_patrickeast: Is the v3 blockstorage api reference not available?  It's not here: http://developer.openstack.org/api-ref.html20:36
patrickeast_alastor_: good question...20:37
patrickeastscottda: ^^ you know if we have v3 docs stashed away somewhere?20:37
*** alonma has quit IRC20:38
scottdaI'm not sure we ever started one...v3 originally being the same as v220:38
patrickeastyea thats what i was thinking20:38
patrickeastoh yea20:38
_alastor_patrickeast: snapshot-manage is not even listed in the v2 api ref20:38
patrickeast_alastor_: well they wouldn't be very good secret api's if we documented them :p20:39
_alastor_:)20:39
patrickeasti'm not even sure where those come from... i guess cinder/api-ref/ ??20:39
patrickeastguess we need a v3 directory20:40
*** timcl has joined #openstack-cinder20:40
*** chris_morrell has joined #openstack-cinder20:40
_alastor_This is starting to feel a bit like yak shaving...20:40
patrickeastlol20:40
*** alonma has joined #openstack-cinder20:41
*** alonma has joined #openstack-cinder20:41
_alastor_side note: Maybe a shaved yak could be our new mascot?20:41
_alastor_That or a stack of Jenga blocks20:42
scottdapatrickeast: I think they are in a docs repo...20:42
patrickeastscottda: whats this stuff then? https://github.com/openstack/cinder/tree/master/api-ref20:42
* patrickeast wouldn't be too surprised if its duplicated20:43
scottdapatrickeast: Yeah, that :)20:43
*** akapil has joined #openstack-cinder20:43
*** baumann has quit IRC20:44
*** dustins has joined #openstack-cinder20:44
*** alonmarx has quit IRC20:45
*** alonma has quit IRC20:45
*** alonmarx has joined #openstack-cinder20:46
*** RageLtMan has joined #openstack-cinder20:47
*** alonma has joined #openstack-cinder20:48
*** ametts has quit IRC20:52
*** akerr has quit IRC20:52
*** alonma has quit IRC20:52
openstackgerritTom Swanson proposed openstack/cinder: WIP: Dell SC: Live Volume Autofailover  https://review.openstack.org/35078220:54
*** alonma has joined #openstack-cinder20:55
*** ntpttr- is now known as ntpttr20:56
*** timcl has quit IRC20:57
*** v12aml has quit IRC20:57
*** jwcroppe has quit IRC20:58
*** alonma has quit IRC20:59
*** alonma has joined #openstack-cinder21:02
*** v12aml has joined #openstack-cinder21:04
*** xinli has quit IRC21:06
*** alonma has quit IRC21:07
*** dustins has quit IRC21:07
_alastor_patrickeast: figured it out.  I can just look at the api view for what I need ;)21:08
*** liverpooler has quit IRC21:08
*** rlrossit has quit IRC21:08
*** alonma has joined #openstack-cinder21:09
*** JoseMello has quit IRC21:10
*** chris_morrell has quit IRC21:11
*** baker has joined #openstack-cinder21:11
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder: CI: Add CI_WIKI_NAME to all drivers  https://review.openstack.org/34800221:12
*** pauloewerton has quit IRC21:13
*** lprice has quit IRC21:13
openstackgerritMatt Smith (_alastor_) proposed openstack/python-cinderclient: List manageable volumes and snapshots  https://review.openstack.org/28538121:13
bakerI've been searching for a while, but have come up empty.  Is it possible to override the default quota for a volume_type from -1 to 0?21:13
*** alonma has quit IRC21:14
*** akapil has quit IRC21:14
bakerstill running juno - so is_public isn't a possibility yet, unfortunately, but I only want specific tenants to be able to access a new volume type21:15
*** fifieldt has quit IRC21:15
*** akapil has joined #openstack-cinder21:15
*** alonmarx has quit IRC21:16
*** alonma has joined #openstack-cinder21:16
*** chris_morrell has joined #openstack-cinder21:20
*** alonmarx has joined #openstack-cinder21:20
*** alonma has quit IRC21:21
*** faiz89 has quit IRC21:23
guitarzanbaker: you can set your quotas to whatever you like21:24
*** gouthamr has quit IRC21:24
guitarzanwere default quotas in the config file in j? or in the db? (I don't remember)21:25
*** diablo_rojo has quit IRC21:25
*** fifieldt has joined #openstack-cinder21:25
*** alonma has joined #openstack-cinder21:27
*** enriquetaso has quit IRC21:27
bakerI think in the DB21:27
bakerthe option is still there in the config file21:27
bakerI see that for the standard global ones, like volume, snapshots, gigabytes21:28
*** bardia has quit IRC21:28
*** jwcroppe has joined #openstack-cinder21:28
bakerbut - if I wanted to set a default quota for a new volume_type for all tenants, I'm struggling with how to do that21:28
bakerwithout having to set it on each tenant individually that is21:30
bakerright now the quota on new volume_types for each volumes,gigabytes,snapshots is -121:31
*** alonma has quit IRC21:31
*** jungleboyj has quit IRC21:33
*** angela-s has quit IRC21:36
*** akapil has quit IRC21:36
*** alonmarx has quit IRC21:37
*** dulek_ has quit IRC21:39
guitarzanbaker: you should be able to set a quota for volume_<volume_type_name>21:39
bakerI can with the CLI - for a given tenant21:40
bakerI think the tenant ID is required21:40
guitarzanset in the config file right next to you rother defaults21:40
bakerhmm... I hadn't tried that - but it didn't look like the code would pick that up21:40
guitarzanif it's in the db, you can adjust the quota for the quota class "default"21:40
bakerI was looking at the quota.py21:41
guitarzanI don't know if that part is juno though21:41
bakerI was just poking around in the database, looking at the quota_classes table21:41
bakerit has volumes,snapshots, gb's, and consisteny groups, but not any of the volume types21:42
*** sdake has quit IRC21:43
bakerI just found the code in horizon that is doing it default quota updates with the cinderclient call21:46
bakerI should be able to back-track from there21:46
*** jwcroppe_ has joined #openstack-cinder21:56
*** jwcroppe has quit IRC21:58
*** markvoelker has quit IRC21:58
*** markvoelker has joined #openstack-cinder21:59
*** mriedem has quit IRC22:01
*** alonma has joined #openstack-cinder22:01
*** eharney has quit IRC22:02
*** eharney has joined #openstack-cinder22:03
*** alyson_ has quit IRC22:03
*** markvoelker has quit IRC22:03
hemnaanyone try retype lately that kicks off a migrate22:03
hemnaI'm getting keystone failures22:04
hemnaDiscoveryFailure: Could not determine a suitable URL for the plugin22:04
smcginnisRuh roh22:05
smcginnisHaven't tried lately.22:05
smcginnisJust a standard retype --migration-policy on-demand?22:05
*** darosale has quit IRC22:05
*** alonma has quit IRC22:06
hemnayah22:07
*** cdelatte has quit IRC22:08
*** ebalduf has quit IRC22:08
*** alonma has joined #openstack-cinder22:09
scottdadang it, I've a tempest test for that stuck in review....22:09
*** alonma has quit IRC22:13
jgriffithhemna: burn it!22:13
*** jwcroppe has joined #openstack-cinder22:14
hemnaanyone else see it ?22:14
hemnamaybe it's just me22:14
scottdasorry, I need a new devstack. I'll test in a while...22:15
*** chris_morrell has quit IRC22:15
*** alonma has joined #openstack-cinder22:16
*** jwcroppe_ has quit IRC22:17
*** alonma has quit IRC22:20
*** baker has quit IRC22:28
*** alonma has joined #openstack-cinder22:30
*** karthik__ has joined #openstack-cinder22:34
*** alonma has quit IRC22:35
*** julim has joined #openstack-cinder22:37
*** alonma has joined #openstack-cinder22:38
*** ducttape_ has quit IRC22:41
*** alonma has quit IRC22:42
*** alonma has joined #openstack-cinder22:45
*** zul_ has quit IRC22:46
*** alonma has quit IRC22:49
*** hemna is now known as hemnafk22:52
*** alonma has joined #openstack-cinder22:52
*** johnplanow has quit IRC22:55
*** chris_morrell has joined #openstack-cinder22:56
*** xyang1 has quit IRC22:56
*** alonma has quit IRC22:57
*** alonma has joined #openstack-cinder22:59
openstackgerritNate Potter proposed openstack/python-cinderclient: Add friendly user message for incompatible microversion  https://review.openstack.org/31950123:00
*** ducttape_ has joined #openstack-cinder23:02
openstackgerritNate Potter proposed openstack/python-cinderclient: Add API versioning to upload_to_image options  https://review.openstack.org/31950123:03
*** sdake has joined #openstack-cinder23:03
*** alonma has quit IRC23:03
*** alonma has joined #openstack-cinder23:06
*** seldenr has quit IRC23:07
*** tpsilva has quit IRC23:08
*** diogogmt has quit IRC23:09
*** alonma has quit IRC23:11
*** alonma has joined #openstack-cinder23:14
openstackgerritxing-yang proposed openstack/cinder: Add generic volume groups  https://review.openstack.org/32245923:15
*** alonma has quit IRC23:18
*** diogogmt has joined #openstack-cinder23:19
*** alonma has joined #openstack-cinder23:21
*** adrianofr has quit IRC23:21
*** ducttape_ has quit IRC23:24
*** ducttape_ has joined #openstack-cinder23:25
*** leeantho has quit IRC23:25
*** alonma has quit IRC23:25
*** diogogmt has quit IRC23:27
*** sdague has quit IRC23:29
*** fernnest_ has quit IRC23:34
*** fernnest has quit IRC23:35
*** hoonetorg has quit IRC23:39
*** Guy has joined #openstack-cinder23:41
*** hoonetorg has joined #openstack-cinder23:44
*** lprice has joined #openstack-cinder23:46
GuyDuncanT: ping23:47
*** zhongjun_ has quit IRC23:47
*** jamielennox is now known as jamielennox|away23:48
*** zhongjun_ has joined #openstack-cinder23:48
*** ducttape_ has quit IRC23:49
*** wilson1 has joined #openstack-cinder23:50
*** sdake has quit IRC23:51
*** lprice has quit IRC23:52
*** wilson_liu has quit IRC23:52
GuyDuncanT: Hi Duncan, in https://review.openstack.org/#/c/347103/ (this one is abandonned, the new one is https://review.openstack.org/#/c/349318/2), you said that you haven't seen anything major in the code and the tests are clear. But there is no reviews. I would like to know if you can give me some reviews about the code. Thank you in advance.23:54
*** daneyon has quit IRC23:54
*** alonma has joined #openstack-cinder23:55
*** lprice has joined #openstack-cinder23:55
*** sdake has joined #openstack-cinder23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!