Thursday, 2016-02-25

*** merooney has quit IRC00:00
*** haomaiwang has quit IRC00:01
*** haomaiwang has joined #openstack-cinder00:01
*** IlyaG has joined #openstack-cinder00:01
jgriffithjeanfabrice: sorry, I'm really not sure.  Have you logged into the screen session and verified everything is running?00:04
jeanfabricejgriffith:  yep. I setup osapi_volume_base_URL in cinder.conf then stop / start the cinder-api in the screen session00:05
*** mylu has joined #openstack-cinder00:06
jgriffithjeanfabrice: sorry, not sure what might be going on.  Likely a problem with the config file.  You could also try the client just incase your curl cmd is goofed up00:07
jeanfabriceI'm devstacking a stable/kilo, to compare. The concern is that I'm facing a similar issue to this one : https://bugs.launchpad.net/mos/+bug/1490266, trying to solve it using osapi_volume_base_URL without success till now.00:10
openstackLaunchpad bug 1490266 in Mirantis OpenStack 9.0.x "[Tempest] [SSL] Tempest test "test_volume_list_pagination" and "test_volume_list_details_pagination" FAIL in MOS with TLS" [Medium,Confirmed] - Assigned to MOS Puppet Team (mos-puppet)00:10
*** diogogmt has quit IRC00:10
jeanfabricemy cinder.conf :00:11
jeanfabrice[DEFAULT]00:11
jeanfabriceosapi_volume_base_URL = http://foo.com/00:11
jeanfabricestop/start the api, then :00:12
jeanfabricecurl http://localhost:877600:12
jeanfabrice{"versions": [{"status": "SUPPORTED", "updated": "2014-06-28T12:20:21Z", "id": "v1.0", "links": [{"href": "http://localhost:8776/v1/", "rel": "self"}]}, {"status": "CURRENT", "updated": "2012-11-21T11:33:21Z", "id": "v2.0", "links": [{"href": "http://localhost:8776/v2/", "rel": "self"}]}]}00:12
jeanfabricesame issue running devstack/kilo. Sounds like a pebkac...00:15
*** sdague has quit IRC00:15
*** laughterwym has joined #openstack-cinder00:15
jeanfabrice(or I don't understand the use of osapi_volume_base_URL)00:15
*** laughter_ has joined #openstack-cinder00:17
*** laughter_ has quit IRC00:18
*** laughter_ has joined #openstack-cinder00:18
*** laughter_ has quit IRC00:18
*** annasort has joined #openstack-cinder00:18
*** laughterwym has quit IRC00:19
*** laughterwym has joined #openstack-cinder00:21
*** IlyaG has quit IRC00:21
*** ntpttr has quit IRC00:21
jgriffithjeanfabrice: try removing that entry00:23
jeanfabricethe entry that sets osapi_volume_base_URL ? Sure ? That's the reply from the api I would like to see in the json (instead of the href:localhost)00:25
jeanfabriceaccording to http://docs.openstack.org/juno/config-reference/content/section_cinder.conf.html, osapi_volume_base_URL is :00:28
jeanfabrice# Base URL that will be presented to users in links to the00:28
jeanfabrice# OpenStack Volume API (string value)00:28
jeanfabrice# Deprecated group/name - [DEFAULT]/osapi_compute_link_prefix00:28
jeanfabrice#osapi_volume_base_URL=<None>00:28
*** qeelee has joined #openstack-cinder00:31
jgriffithaorourke: you there?00:36
aorourkejgriffith, yes00:36
jgriffithaorourke: so thanks for finding those issues00:36
jgriffithaorourke: my merge somewhere along the way go screwed up00:37
jgriffithaorourke: notice that the thaw method I specifically point out that problem in service get00:37
jgriffithaorourke: for the rep_status, I saved the service.status instead of the service.replication_status :(00:37
jgriffithaorourke: which also points out that I'm not using my fancy new enum there00:37
openstackgerritMerged openstack/cinder: cinder-api-microversions code  https://review.openstack.org/22491000:38
jgriffithaorourke: finally on the restart... I'm not sure what's up with that, but I'll dig into it00:38
aorourkejgriffith, excellent. i think it's almost there00:38
jgriffithaorourke: I'm not sure what to do about the restart thing yet :)00:39
jgriffithaorourke: the others are EZ00:39
aorourkejgriffith, if active_backend_id is not None, don't update it?00:39
aorourkeassume failover00:39
jgriffithaorourke: meh00:40
jgriffithmaybe00:40
*** vincent_hou has quit IRC00:40
*** mylu has quit IRC00:42
jgriffithaorourke: that might be the only way for now00:44
aorourkejgriffith, i mean it's not the best solution but i think it would work00:45
aorourkeor off of the replication_status00:45
jgriffithaorourke: Oh,, DERP00:46
*** ildikov has quit IRC00:48
jgriffithaorourke: running unit tests and pep8 now00:49
*** ildikov has joined #openstack-cinder00:52
apoorvadsmcginnis: When you get a chance, could you please look at https://review.openstack.org/#/c/268370/?00:52
*** mylu has joined #openstack-cinder00:54
*** akerr has joined #openstack-cinder00:58
*** delatte has joined #openstack-cinder00:58
*** wilson_liu has quit IRC00:58
openstackgerritJohn Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake)  https://review.openstack.org/27579700:59
*** wilson has joined #openstack-cinder00:59
*** akerr_ has joined #openstack-cinder00:59
*** wilson is now known as Guest7807100:59
*** delattec has quit IRC01:00
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-cinder01:01
jgriffithwell the attach stuff was going good til I hit the unit tests :(01:02
jgriffithsigh01:02
*** akerr has quit IRC01:02
openstackgerritJacob Gregor proposed openstack/cinder: WIP: Storwize SVC multiple management IPs  https://review.openstack.org/28426701:02
*** jdillaman has quit IRC01:08
*** cheneydc has joined #openstack-cinder01:08
*** yangyapeng has joined #openstack-cinder01:09
*** jgregor has quit IRC01:12
*** yangyapeng has quit IRC01:12
*** gouthamr_ has quit IRC01:13
*** mylu has quit IRC01:13
*** garthb has quit IRC01:14
*** garthb_ has quit IRC01:14
openstackgerritPatrick East proposed openstack/cinder: WIP: Update Pure replication to cheesecake  https://review.openstack.org/27698101:14
*** davechen has joined #openstack-cinder01:14
*** gouthamr has joined #openstack-cinder01:16
*** Suyash has quit IRC01:16
*** aorourke is now known as aorourke-afk01:17
*** EinstCrazy has joined #openstack-cinder01:20
*** jdillaman has joined #openstack-cinder01:21
*** mss-4 has joined #openstack-cinder01:22
*** haomaiwang has quit IRC01:22
openstackgerritsmile-luobin proposed openstack/cinder-specs: Specify availability_zone and volume_type for backup restore API  https://review.openstack.org/27387001:25
*** julim has joined #openstack-cinder01:26
*** Lee1092 has joined #openstack-cinder01:27
*** Thelo has joined #openstack-cinder01:31
*** mtanino has quit IRC01:32
*** zhangjn has quit IRC01:32
TheloHi all, in the project system-config, If I change the file system-config/modules/openstack_project/files/pydistutils.cfg to use this link, what do I need to do to have it taken into account?01:34
*** yangyapeng has joined #openstack-cinder01:34
TheloO wrong channel01:35
*** edtubill has joined #openstack-cinder01:36
*** zhangjn has joined #openstack-cinder01:37
*** leeantho has quit IRC01:39
patrickeastjgriffith: hey, still around? just rebased on patchset 32 and am seeing http://paste.openstack.org/show/488133/01:39
patrickeastoh01:40
patrickeastnvm, i see the typo01:40
*** zzzeek has quit IRC01:45
*** zzzeek has joined #openstack-cinder01:45
openstackgerritOpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements  https://review.openstack.org/28392301:46
*** zzzeek has quit IRC01:47
*** zzzeek has joined #openstack-cinder01:50
*** dims has quit IRC01:52
*** zzzeek has quit IRC01:52
smcginnisgus: You still around?01:52
*** zzzeek has joined #openstack-cinder01:54
*** vincent_hou has joined #openstack-cinder01:58
smcginnisgus: NM, commented on the patch I had a question on.01:58
*** haomaiwang has joined #openstack-cinder01:59
*** haomaiwang has quit IRC02:01
*** haomaiwang has joined #openstack-cinder02:01
*** mss-4 has quit IRC02:04
*** diogogmt has joined #openstack-cinder02:05
openstackgerritPatrick East proposed openstack/cinder: WIP: Update Pure replication to cheesecake  https://review.openstack.org/27698102:15
*** erlon has quit IRC02:16
openstackgerritLisaLi proposed openstack/cinder: Fix NoneType error in service_get_all  https://review.openstack.org/28450002:20
*** IlyaG has joined #openstack-cinder02:24
*** houming has joined #openstack-cinder02:26
*** smoriya_ has quit IRC02:41
*** bardia_ has quit IRC02:45
*** links has joined #openstack-cinder02:47
openstackgerritJohn Griffith proposed openstack/cinder: Replication v2.1 (Cheesecake)  https://review.openstack.org/27579702:48
openstackgerritMerged openstack/cinder: Tintri image cache cleanup  https://review.openstack.org/26837002:50
huyangkindly review, https://review.openstack.org/#/c/283975/02:50
openstackgerritMerged openstack/cinder: Fix HNAS iSCSI driver attachment  https://review.openstack.org/28429502:51
*** apoorvad has quit IRC02:52
*** apoorvad has joined #openstack-cinder02:53
*** apoorvad has quit IRC02:57
*** edtubill has quit IRC02:59
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-cinder03:01
*** gcb has quit IRC03:02
*** gcb has joined #openstack-cinder03:03
*** boris-42 has quit IRC03:04
*** edmondsw has quit IRC03:07
*** gcb has quit IRC03:07
*** gcb has joined #openstack-cinder03:08
openstackgerritWilson Liu proposed openstack/cinder: Add unit tests for Huawei drivers  https://review.openstack.org/28302903:11
*** diogogmt has quit IRC03:23
*** akerr_ has quit IRC03:24
*** diogogmt has joined #openstack-cinder03:26
openstackgerritWilson Liu proposed openstack/cinder: Huawei: delete_snapshot need not return any value  https://review.openstack.org/28451403:27
*** salv-orlando has joined #openstack-cinder03:27
*** salv-orlando has quit IRC03:28
*** salv-orl_ has quit IRC03:30
*** links has quit IRC03:34
*** diogogmt has quit IRC03:43
*** chlong_ has quit IRC03:47
*** davechen is now known as davechen_afk03:49
*** chlong_ has joined #openstack-cinder03:49
*** vincent_hou has quit IRC03:51
*** vincent_hou has joined #openstack-cinder03:52
openstackgerritWilson Liu proposed openstack/cinder: Add LUN wwn check in Huawei driver  https://review.openstack.org/27159203:55
*** qeelee has quit IRC04:00
*** haomaiwang has quit IRC04:01
*** haomaiwa_ has joined #openstack-cinder04:01
gussmcginnis: (was out for a bit, back now if that helps)04:02
*** Guest78071 has quit IRC04:04
*** Guest78071 has joined #openstack-cinder04:05
*** ntpttr has joined #openstack-cinder04:07
*** shyama has joined #openstack-cinder04:10
*** vincent_hou has quit IRC04:12
*** gouthamr has quit IRC04:17
*** gcb has quit IRC04:28
*** gcb has joined #openstack-cinder04:28
*** salv-orlando has joined #openstack-cinder04:29
*** links has joined #openstack-cinder04:29
*** haomaiwa_ has quit IRC04:30
*** merooney_ has quit IRC04:31
*** salv-orlando has quit IRC04:39
*** haomaiwa_ has joined #openstack-cinder04:39
*** winston-d_ has joined #openstack-cinder04:42
*** ntpttr has quit IRC04:47
*** davechen_afk is now known as davechen04:48
*** qeelee has joined #openstack-cinder04:59
*** cknight1 has quit IRC04:59
*** haomaiwa_ has quit IRC05:01
*** haomaiwang has joined #openstack-cinder05:01
*** lprice has joined #openstack-cinder05:06
*** qeelee has quit IRC05:10
*** Lallana has quit IRC05:11
*** Lallana has joined #openstack-cinder05:12
*** belmoreira has joined #openstack-cinder05:12
*** Fdaisuke has quit IRC05:15
*** Fdaisuke has joined #openstack-cinder05:17
*** bardia has joined #openstack-cinder05:20
*** bardia has quit IRC05:20
*** bardia has joined #openstack-cinder05:21
*** sgotliv has joined #openstack-cinder05:23
*** shyama has quit IRC05:24
*** shyama_ has joined #openstack-cinder05:24
*** shyama_ is now known as shyama05:24
*** Poornima has joined #openstack-cinder05:30
*** cknight has joined #openstack-cinder05:35
*** liverpooler has quit IRC05:44
openstackgerritChhavi Agarwal proposed openstack/cinder-specs: Allow setting multiattach property  https://review.openstack.org/26405905:44
*** cknight has quit IRC05:46
*** qeelee has joined #openstack-cinder05:49
*** dims has joined #openstack-cinder05:52
*** nkrinner has joined #openstack-cinder05:58
*** salv-orlando has joined #openstack-cinder05:58
*** laughterwym has quit IRC05:59
*** laughterwym has joined #openstack-cinder06:00
*** haomaiwang has quit IRC06:01
*** haomaiwang has joined #openstack-cinder06:01
*** edtubill has joined #openstack-cinder06:03
*** salv-orlando has quit IRC06:03
*** laughterwym has quit IRC06:13
*** laughterwym has joined #openstack-cinder06:14
*** gcb has quit IRC06:18
*** laughterwym has quit IRC06:19
*** jeanfabrice has quit IRC06:22
*** cknight has joined #openstack-cinder06:27
*** laughterwym has joined #openstack-cinder06:29
*** ChubYann has quit IRC06:29
*** gcb has joined #openstack-cinder06:30
*** laughterwym has quit IRC06:31
*** laughterwym has joined #openstack-cinder06:31
qeeleeHello, does anyone know if the sheepdog tempest testing is done in a real sheepdog cluster env?06:34
lixiaoy1_qeelee: I think. devstack install sheepdog plugin06:35
*** aagrawal has joined #openstack-cinder06:35
*** laughterwym has quit IRC06:36
*** Poornima has quit IRC06:37
*** edtubill has quit IRC06:38
*** Poornima has joined #openstack-cinder06:39
*** laughterwym has joined #openstack-cinder06:43
*** dims has quit IRC06:43
qeeleelixiaoy1_: Thanks!06:43
*** dave-mccowan has quit IRC06:45
*** cknight has quit IRC06:46
*** laughterwym has quit IRC06:47
*** laughterwym has joined #openstack-cinder06:50
*** qeelee_ has joined #openstack-cinder06:50
*** qeelee has quit IRC06:50
*** qeelee_ is now known as qeelee06:50
*** belmoreira has quit IRC06:53
ankit_agsmcginnis: hi06:54
*** laughterwym has quit IRC06:56
ankit_agsmcginnis:: wanted to discuss about https://review.openstack.org/#/c/147186/ if community is interested to push this Snapshot feature in Mitaka timeframe06:56
*** zzzeek has quit IRC06:56
*** laughterwym has joined #openstack-cinder06:58
*** zzzeek has joined #openstack-cinder06:59
*** haomaiwang has quit IRC07:01
*** haomaiwang has joined #openstack-cinder07:01
*** salv-orlando has joined #openstack-cinder07:02
*** laughterwym has quit IRC07:02
*** abhishekk has joined #openstack-cinder07:02
*** bardia has quit IRC07:06
*** salv-orlando has quit IRC07:07
*** jeanfabrice has joined #openstack-cinder07:10
*** zzzeek has quit IRC07:10
*** laughterwym has joined #openstack-cinder07:10
*** laughterwym has quit IRC07:17
*** lpetrut has joined #openstack-cinder07:19
*** anshul has joined #openstack-cinder07:23
*** salv-orlando has joined #openstack-cinder07:25
*** salv-orl_ has joined #openstack-cinder07:26
*** salv-orlando has quit IRC07:26
*** ociuhandu has joined #openstack-cinder07:30
*** ociuhandu has quit IRC07:31
*** ociuhandu has joined #openstack-cinder07:32
*** liverpooler has joined #openstack-cinder07:32
*** jeanfabrice has quit IRC07:36
*** laughterwym has joined #openstack-cinder07:38
*** zul has quit IRC07:41
*** laughter_ has joined #openstack-cinder07:42
*** laughter_ has quit IRC07:42
*** laughter_ has joined #openstack-cinder07:42
*** laughterwym has quit IRC07:45
openstackgerrithuanan proposed openstack/cinder: Huawei: Check the QoS status before we use  https://review.openstack.org/27160107:48
*** zul has joined #openstack-cinder07:48
*** ociuhandu has quit IRC07:49
*** Poornima has quit IRC07:51
*** belmoreira has joined #openstack-cinder07:51
*** Poornima has joined #openstack-cinder07:52
openstackgerrithuanan proposed openstack/cinder: Huawei: Check the QoS status before we use  https://review.openstack.org/27160107:53
openstackgerritSheel Rana proposed openstack/cinder: Adding verbose to error during volume create  https://review.openstack.org/28457107:54
openstackgerritLisaLi proposed openstack/cinder: No volume_id needed for backup-create from snapshot  https://review.openstack.org/28457207:54
*** daneyon_ has quit IRC07:55
*** belmoreira has quit IRC07:58
*** smoriya_ has joined #openstack-cinder07:59
*** belmoreira has joined #openstack-cinder08:00
*** haomaiwang has quit IRC08:01
*** haomaiwa_ has joined #openstack-cinder08:01
*** belmoreira has quit IRC08:06
openstackgerrithuanan proposed openstack/cinder: Huawei: Check the QoS status before we use  https://review.openstack.org/27160108:08
openstackgerritLisaLi proposed openstack/cinder: Handle exceptions about snapshot in backup create  https://review.openstack.org/28457708:09
*** arecknag has joined #openstack-cinder08:09
*** lpetrut has quit IRC08:13
*** Oku_OS has quit IRC08:18
openstackgerrithuanan proposed openstack/cinder: Huawei: Check the QoS status before we use  https://review.openstack.org/27160108:31
*** laughter_ has quit IRC08:43
*** laughterwym has joined #openstack-cinder08:43
*** laughterwym has quit IRC08:47
*** laughterwym has joined #openstack-cinder08:50
*** boris-42 has joined #openstack-cinder08:52
*** laughterwym has quit IRC08:55
openstackgerritBéla Vancsics proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B)  https://review.openstack.org/28459708:55
*** haomaiwa_ has quit IRC09:01
*** Lallana has quit IRC09:01
*** haomaiwang has joined #openstack-cinder09:01
*** jistr has joined #openstack-cinder09:01
*** Lallana has joined #openstack-cinder09:01
openstackgerritLisaLi proposed openstack/cinder: Add necessary fields to volume creation  https://review.openstack.org/28460009:03
openstackgerritMaxim Nestratov proposed openstack/cinder: vzstorage: add ploop volume format support  https://review.openstack.org/26224609:06
openstackgerritMaxim Nestratov proposed openstack/cinder: vzstorage: fix creating and deleting snapshots of in-use volumes  https://review.openstack.org/27646509:06
openstackgerritMaxim Nestratov proposed openstack/cinder: Use versionedobjects in remotefs.py  https://review.openstack.org/26155809:06
*** mvk has joined #openstack-cinder09:09
*** esp has joined #openstack-cinder09:10
*** Oku_OS has joined #openstack-cinder09:10
duleklixiaoy1_: Hi!09:12
lixiaoy1_dulek: I found a bug today, I need you to look, it may cause serious problem09:13
duleklixiaoy1_: Sure, I was reading through recent bugreports and seen some of yours.09:13
duleklixiaoy1_: Which one it is?09:13
lixiaoy1_dulek: https://bugs.launchpad.net/cinder/+bug/154966909:13
openstackLaunchpad bug 1549669 in Cinder "object get can't work when fields not valid" [High,Confirmed] - Assigned to Lisa Li (lisali)09:13
lixiaoy1_dulek: it is about ovo.09:14
duleklixiaoy1_: Oh, I see.09:14
*** esp has quit IRC09:14
lixiaoy1_dulek: it leads qurey_all and query the invalid item not work09:15
*** jeanfabrice has joined #openstack-cinder09:15
lixiaoy1_dulek: this case is probably happen when users upgrade to new release09:15
*** ildikov has quit IRC09:15
duleklixiaoy1_: I wonder what motivations had thangp to make Volume.attach_status non-nullable in object while it's nullable in the DB.09:16
lixiaoy1_dulek: this problem is not only for this field. for any fields, if nullable is change in this release, or db module is different from object, it may lead problem09:17
duleklixiaoy1_: I agree, nullable status of a field should match.09:17
duleklixiaoy1_: How about simply changing the object to match what's in the DB?09:18
lixiaoy1_dulek: I am worried about other fields which may also have such problem. maybe we can fix this bug like you say. And we need to have UT to check09:19
lixiaoy1_dulek: db schema and objects match09:20
duleklixiaoy1_: That should be possible.09:20
duleklixiaoy1_: I can work on that if you want.09:20
lixiaoy1_dulek: that's ok. I can do it. as the backup bp is finished, I have time now :)09:21
lixiaoy1_dulek: I just want to confirm with you about the solution09:21
duleklixiaoy1_: I think the right thing to do is to keep them in sync.09:21
*** ndipanov has joined #openstack-cinder09:21
*** yangyapeng has quit IRC09:21
duleklixiaoy1_: I'll answer on the bugreport and will try to draft a UT idea for you.09:22
duleklixiaoy1_: I think we have a matching between models and objects done somewhere. ;)09:23
lixiaoy1_dulek: another issue is that we also have to check that there is no fields whose nullable is changed from true to false for liberty to mitaka09:23
lixiaoy1_dulek: that's good09:23
duleklixiaoy1_: This is very easy by just looking on DB migrations - quick check tells me that there weren't.09:24
lixiaoy1_dulek: yes :)09:24
lixiaoy1_dulek: you remind me09:25
duleklixiaoy1_: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L4314-L432509:26
*** salv-orlando has joined #openstack-cinder09:27
lixiaoy1_dulek: this is for name change between db models and versioned object. any problems?09:27
duleklixiaoy1_: In the UT you can iterate over objects like test_objects.TestObjectVersions.test_versions_history is doing.09:28
duleklixiaoy1_: And in the loop you can use this method to fetch the correct DB model for the Object and compare nullable statuses for fields and columns.09:29
lixiaoy1_dulek: yes!09:30
*** salv-orl_ has quit IRC09:30
duleklixiaoy1_: I advice you to iterate over DB model columns and check obj fields and not the other way around.09:31
duleklixiaoy1_: Because sometimes there more fields than columns.09:31
duleklixiaoy1_: Yeah, that should work. :)09:31
lixiaoy1_dulek: nullable, default value, data type, need to check. how do you think09:32
duleklixiaoy1_: We can start with nullable, maybe default.09:32
lixiaoy1_dulek: ok09:32
dulekdata type is more complicated - UUID on Object is Varchar in the DB. Same for enums.09:33
*** yuriy_n17 has joined #openstack-cinder09:34
lixiaoy1_dulek: got all. And will do it tomorrow09:35
duleklixiaoy1_: Okay, feel free to add me to the review. :)09:35
*** yangyapeng has joined #openstack-cinder09:35
lixiaoy1_dulek: of course09:35
lixiaoy1_dulek: you give me the idea to fix it.09:36
openstackgerritxiaoqin proposed openstack/cinder: IBM Storwize pool aware support  https://review.openstack.org/28461409:37
duleklixiaoy1_: Ah, no, no Co-Authored-By, just as reviewer.09:41
duleklixiaoy1_: :P09:41
*** liverpooler has quit IRC09:41
duleklixiaoy1_: So I can notice a new mail from Gerrit. :)09:41
lixiaoy1_dulek: ok reviewer :)09:41
*** liverpooler has joined #openstack-cinder09:42
*** salv-orlando has quit IRC09:43
abhishekkhi all, could you please go through comments on https://bugs.launchpad.net/cinder/+bug/1540938 and update your thoughts for the same09:44
openstackLaunchpad bug 1540938 in Cinder "upload volume to image fails if disk-format is iso" [Undecided,New] - Assigned to Abhishek Kekane (abhishek-kekane)09:45
openstackgerritDinesh Bhor proposed openstack/cinder: Fix error message in cinder type-update  https://review.openstack.org/28461809:45
*** laughterwym has joined #openstack-cinder09:46
*** haomaiw__ has joined #openstack-cinder09:48
*** haomaiwang has quit IRC09:49
*** qeelee has quit IRC09:51
*** laughterwym has quit IRC09:51
*** jeanfabrice has quit IRC09:53
*** davechen has left #openstack-cinder09:53
*** grassy is now known as davechen_afk09:53
*** haomaiw__ has quit IRC10:01
*** ildikov has joined #openstack-cinder10:01
*** Guest78071 has quit IRC10:01
*** haomaiwang has joined #openstack-cinder10:01
*** mvk has quit IRC10:01
*** wilson has joined #openstack-cinder10:02
*** cheneydc has quit IRC10:02
*** wilson is now known as Guest7349510:03
openstackgerritxiaoqin proposed openstack/cinder: IBM Storwize with pool-aware-cinder-scheduler  https://review.openstack.org/28461410:04
*** EinstCrazy has quit IRC10:07
*** EinstCrazy has joined #openstack-cinder10:07
openstackgerritBéla Vancsics proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B)  https://review.openstack.org/28459710:08
*** EinstCrazy has quit IRC10:12
*** yangyapeng has quit IRC10:12
*** qeelee has joined #openstack-cinder10:19
*** jeanfabrice has joined #openstack-cinder10:20
*** qeelee has quit IRC10:31
*** lpetrut has joined #openstack-cinder10:39
*** belmoreira has joined #openstack-cinder10:49
openstackgerritYuriy Nesenenko proposed openstack/python-brick-cinderclient-ext: Attach/detach features implementation  https://review.openstack.org/26374410:57
*** salv-orlando has joined #openstack-cinder10:59
*** salv-orlando has quit IRC10:59
*** salv-orlando has joined #openstack-cinder10:59
*** slotti has joined #openstack-cinder11:00
*** haomaiwang has quit IRC11:01
slottiHey guys, I'm using cinder volume-types in liberty. Is it possible to set the default quota value for number of Volumes (is always -1 here) to another Value?11:01
*** haomaiwang has joined #openstack-cinder11:01
*** sdague has joined #openstack-cinder11:06
openstackgerritWilson Liu proposed openstack/cinder: Huawei: delete_snapshot need not return any value  https://review.openstack.org/28451411:10
openstackgerritWilson Liu proposed openstack/cinder: Add LUN wwn check in Huawei driver  https://review.openstack.org/27159211:20
*** erlon has joined #openstack-cinder11:20
*** jordanP has joined #openstack-cinder11:25
*** houming has quit IRC11:31
arnewiebalckslotti: I think this is what the default classes are for.11:32
arnewiebalckdefault quota classes11:32
*** [1]Thelo has joined #openstack-cinder11:32
*** wanghao has quit IRC11:33
arnewiebalckslotti: cinder help quota-class-update11:34
*** Thelo has quit IRC11:34
*** [1]Thelo is now known as Thelo11:34
*** wanghao has joined #openstack-cinder11:35
*** ankit_ag has quit IRC11:37
*** ankit_ag has joined #openstack-cinder11:37
*** aagrawal has quit IRC11:41
*** gcb has quit IRC11:42
*** EinstCrazy has joined #openstack-cinder11:43
*** gcb has joined #openstack-cinder11:43
*** laughterwym has joined #openstack-cinder11:53
openstackgerritGábor Antal proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B)  https://review.openstack.org/28459711:57
*** tpsilva has joined #openstack-cinder11:58
*** haomaiwang has quit IRC12:01
*** haomaiwang has joined #openstack-cinder12:01
*** fthiagogv has quit IRC12:10
*** adrianofr_ has joined #openstack-cinder12:11
openstackgerritBéla Vancsics proposed openstack/cinder: Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B)  https://review.openstack.org/28459712:12
slottiarnewiebalck: Thank you :-) tried that using project_id as class... didn't know there is a class called default.12:18
*** yhayashi has quit IRC12:19
*** Lee1092 has quit IRC12:22
*** jeanfabrice has quit IRC12:22
*** haomaiwang has quit IRC12:31
*** raildo-afk is now known as raildo12:37
*** yangyapeng has joined #openstack-cinder12:37
*** zul has quit IRC12:43
*** zul has joined #openstack-cinder12:44
*** diogogmt has joined #openstack-cinder12:46
*** fthiagogv has joined #openstack-cinder12:53
*** salv-orlando has quit IRC12:56
*** dave-mccowan has joined #openstack-cinder12:56
*** akerr has joined #openstack-cinder13:00
yuriy_n17hemnafk: Hi! Very sorry for disturbing. Please review https://review.openstack.org/#/c/263744/ whenever you have free time. Thanks a lot for advance.13:01
*** takedakn has joined #openstack-cinder13:02
*** smoriya_ has quit IRC13:02
*** ildikov has quit IRC13:03
*** edmondsw has joined #openstack-cinder13:04
openstackgerritSheel Rana proposed openstack/cinder: Adding verbose to error during volume create  https://review.openstack.org/28457113:04
*** yangyapeng has quit IRC13:08
*** yangyapeng has joined #openstack-cinder13:09
*** diogogmt has quit IRC13:10
*** yangyape_ has joined #openstack-cinder13:13
*** takedakn has quit IRC13:15
*** yangyapeng has quit IRC13:16
*** timcl has joined #openstack-cinder13:17
*** gouthamr has joined #openstack-cinder13:22
*** links has quit IRC13:26
openstackgerritSheel Rana proposed openstack/cinder: Added Bootable filter for cinder list command  https://review.openstack.org/27860513:29
*** jseiler has quit IRC13:32
openstackgerritBéla Vancsics proposed openstack/cinder: Reduced the complexity of the send_cmd method (in ProphetStor)  https://review.openstack.org/25051713:37
*** ankit_ag has quit IRC13:37
openstackgerritSheel Rana proposed openstack/cinder: Adding verbose to error during volume create  https://review.openstack.org/28457113:39
openstackgerritBéla Vancsics proposed openstack/cinder: Reduce code duplication (in the ssc_cmode.py)  https://review.openstack.org/25147813:42
*** shyama has quit IRC13:44
*** dims has joined #openstack-cinder13:47
scottdadulek: Hi13:49
*** ildikov has joined #openstack-cinder13:50
*** martyturner has joined #openstack-cinder13:50
*** xyang1 has joined #openstack-cinder13:52
*** JoseMello has joined #openstack-cinder13:55
*** Poornima has quit IRC13:55
*** zzzeek has joined #openstack-cinder13:57
*** zzzeek has quit IRC13:58
*** salv-orlando has joined #openstack-cinder13:58
*** zzzeek has joined #openstack-cinder13:58
*** porrua has joined #openstack-cinder14:00
*** shyama has joined #openstack-cinder14:01
*** edtubill has joined #openstack-cinder14:03
*** salv-orlando has quit IRC14:03
*** edtubill has quit IRC14:04
*** edtubill has joined #openstack-cinder14:04
*** links has joined #openstack-cinder14:07
dulekscottda: Hi, what's up?14:07
scottdadulek: sorry, give me a minute. Nova meeting right now...14:08
*** slotti has quit IRC14:08
*** andymaier has joined #openstack-cinder14:08
*** jgregor has joined #openstack-cinder14:11
*** rlrossit_ has joined #openstack-cinder14:15
scottdadulek: Saw your comments on the "remove pypi" patch14:16
dulekscottda: Ah, right. Tempest is down, so maybe I'm wrong.14:17
scottdadulek: I'm not sure what caused this issue. I did hear in Nova meeting that there was a nasty gate bug, and the fix just merged.14:17
scottdadulek: OK. That patch could probably use a 'reverify', maybe after a while to ensure that gate bug fix goes through. I'm not sure on the details.14:17
dulekscottda: I agree. :)14:18
scottdacool. I've had my morning coffee. Crisis potentially averted. On to the next thing.....14:18
*** rlrossit_ has quit IRC14:19
dulekSorry for suggesting it may be your patch, but "policy" ringed a bell for me.14:19
*** rlrossit has joined #openstack-cinder14:19
scottdadulek: No problem. Microversions just merged and then this broke. I'd suspect the same thing.14:20
*** merooney has joined #openstack-cinder14:20
smcginnisdulek: We can just blame scottda for everything for a while now. ;)14:30
openstackgerritEvgeny Antyshev proposed openstack/cinder: Move test from test_glusterfs and test_quobyte to test_remotefs  https://review.openstack.org/26154914:33
openstackgerritEvgeny Antyshev proposed openstack/cinder: Use versionedobjects in remotefs.py  https://review.openstack.org/26155814:33
kaisersHi Cinders! If you have experience with libvirt supported migrations perhaps take a glance at https://bugs.launchpad.net/nova/+bug/1549828 , I'd appreciate any help with that. :)14:33
openstackLaunchpad bug 1549828 in OpenStack Compute (nova) "permission denied on console.log during some migrations" [Undecided,New]14:33
kaiserseharney: ping ^^^^^^14:33
*** cknight has joined #openstack-cinder14:39
*** dustins has joined #openstack-cinder14:39
*** tsekiyama has joined #openstack-cinder14:40
*** mriedem has joined #openstack-cinder14:40
*** jwcroppe has joined #openstack-cinder14:44
*** Yogi1 has joined #openstack-cinder14:47
*** markstur_ has joined #openstack-cinder14:54
scottdasmcginnis: dulek Weren't we just discussing paranoia yesterday? I definitely think it's a healthy attitude...14:55
*** merooney has quit IRC14:56
*** markstur_ has left #openstack-cinder14:57
smcginnis;)14:58
*** diogogmt has joined #openstack-cinder14:59
*** eharney has joined #openstack-cinder15:00
*** merooney has joined #openstack-cinder15:01
*** baumann has joined #openstack-cinder15:02
*** baumann has quit IRC15:03
*** PsionTheory has joined #openstack-cinder15:04
*** baumann has joined #openstack-cinder15:04
*** diablo_rojo has joined #openstack-cinder15:07
*** salv-orlando has joined #openstack-cinder15:08
*** links has quit IRC15:12
*** e0ne has joined #openstack-cinder15:13
*** arecknag has quit IRC15:14
*** salv-orlando has quit IRC15:15
arnewiebalckIs there a way to have metadata associated with volume types? Think “intended_usage” as an example.15:15
*** knikolla has joined #openstack-cinder15:16
*** nkrinner has quit IRC15:16
*** anshul has quit IRC15:16
merooneyhey xyang1, got an all-green run on https://review.openstack.org/#/c/283194/4 Should be ready for you now :)15:17
xyang1merooney: sure15:18
*** garthb_ has joined #openstack-cinder15:18
*** garthb has joined #openstack-cinder15:18
*** merooney has quit IRC15:18
*** kfarr has joined #openstack-cinder15:19
*** merooney has joined #openstack-cinder15:23
*** jungleboyj has joined #openstack-cinder15:23
*** boichev2 has joined #openstack-cinder15:24
*** PsionTheory has quit IRC15:26
*** boichev has quit IRC15:26
*** chris_mo_ has quit IRC15:26
DuncanTarnewiebalck: There's the description field?15:27
*** sdague has quit IRC15:32
arnewiebalckDuncanT: Wasn’t aware of that one. That should do, thx!15:32
*** Yogi1 has quit IRC15:34
*** liverpooler has quit IRC15:36
*** wilson has joined #openstack-cinder15:37
*** wilson is now known as Guest528915:37
*** Guest5289 has quit IRC15:37
*** wilson_liu has joined #openstack-cinder15:38
mc_nairdulek: do you know if there's a config setting to specify the DB connection pool size? Saw that https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L625 doesn't have a config for pool_size, but wanted to verify15:40
*** e0ne has quit IRC15:40
*** e0ne_ has joined #openstack-cinder15:41
dulekmc_nair: Sorry, I have no idea. Probably option may be hidden inside oslo.db, but I don't really know. Maybe #openstack-oslo?15:42
*** mtanino has joined #openstack-cinder15:43
*** lprice1 has joined #openstack-cinder15:43
*** knikolla has quit IRC15:43
mc_nairdulek: thanks, will do. You're the first stop for all DB questions :)15:44
*** lprice has quit IRC15:44
*** kaisers_ has joined #openstack-cinder15:45
*** darosale has joined #openstack-cinder15:46
dulekmc_nair: I probably shouldn't be, I just got some knowledge on how Nova classifies things…15:46
dulekmc_nair: Or maybe I need to learn more to be worthy the hopes you have. ;)15:46
mc_nairdulek: yea, that sounds easiest for everyone :)15:48
dulekDamn…15:49
openstackgerritScott DAngelo proposed openstack/python-cinderclient: api-microversion support for python-cinderclient  https://review.openstack.org/24816315:49
*** aorourke-afk is now known as aorourke15:49
*** e0ne_ has quit IRC15:52
*** mtanino has quit IRC15:52
openstackgerritAlex O'Rourke proposed openstack/cinder: WIP - 3PAR: Update replication to v2.1  https://review.openstack.org/27930715:53
*** darosale has quit IRC15:54
*** daneyon has joined #openstack-cinder15:56
scottdasmcginnis: There's ^^^ a working /v3 enpdoint cinderclient that passes unit tests (except 1 with Mock issues I need to fix, but am skipping)15:57
*** daneyon_ has joined #openstack-cinder15:57
*** kaisers_ has quit IRC15:57
smcginnisscottda: Sweet, thanks!15:57
scottdaIt could use a high-level look from Cores/others regarding how I've moved /v2 stuff to /v3. Seems like a good way (stolen from Manila) but results in a bunch of copy to new dir and removal from old. So equals a lot of LOC.15:58
*** kaisers_ has joined #openstack-cinder15:58
smcginnisStealing is good. :)15:58
*** wilson_liu has quit IRC15:59
*** kaisers_ has quit IRC15:59
scottdasorry, should have said 'leveraging'15:59
smcginnishaha15:59
*** knikolla has joined #openstack-cinder15:59
*** merooney has quit IRC15:59
*** daneyon has quit IRC16:00
*** timcl1 has joined #openstack-cinder16:01
*** kvidvans has quit IRC16:02
bswartz"good artists borrow, great artists steal" -- attributed to picasso?16:02
yuriy_n17hemnafk: ping ^^16:02
scottdaI nominate bswartz for Quote Czar16:03
*** timcl has quit IRC16:03
*** mtanino has joined #openstack-cinder16:03
*** merooney has joined #openstack-cinder16:03
Swansonbswartz, by that logic I'm a great neighbor.16:05
*** garthb has quit IRC16:06
*** garthb_ has quit IRC16:06
*** dims has quit IRC16:06
*** mylu has joined #openstack-cinder16:08
*** diogogmt has quit IRC16:08
*** daneyon_ has quit IRC16:11
*** merooney has quit IRC16:12
*** sdague has joined #openstack-cinder16:14
*** crose has joined #openstack-cinder16:18
*** timcl1 has quit IRC16:19
*** laughterwym has quit IRC16:20
*** avishay has joined #openstack-cinder16:21
*** anshul has joined #openstack-cinder16:23
*** haomaiwa_ has joined #openstack-cinder16:24
*** belmoreira has quit IRC16:27
*** mylu has quit IRC16:30
*** arch-nemesis has joined #openstack-cinder16:30
*** mylu has joined #openstack-cinder16:31
*** anshul has quit IRC16:34
*** merooney has joined #openstack-cinder16:36
*** merooney has quit IRC16:38
*** salv-orlando has joined #openstack-cinder16:38
*** JoseMello has quit IRC16:38
*** sheel has joined #openstack-cinder16:39
*** sgotliv has quit IRC16:39
*** timcl has joined #openstack-cinder16:40
*** JoseMello has joined #openstack-cinder16:41
*** salv-orlando has quit IRC16:41
*** ntpttr has joined #openstack-cinder16:41
*** salv-orlando has joined #openstack-cinder16:41
*** EinstCrazy has quit IRC16:46
sdaguefyi, it looks like cinder unit tests are borked, and all cinder patches will fail until it's dealt with16:47
sheelhey all16:47
sheelwhy below test is getting failed16:47
sheelhttps://www.irccloud.com/pastebin/LyHGJOOg/16:47
smcginnissdague: That's not the previous gate issues?16:47
sdaguehttp://logs.openstack.org/94/283194/4/gate/gate-cinder-python27/993b7b8/console.html#_2016-02-25_16_04_54_98516:47
sdagueno, unit tests16:48
sheelThis is on fresh cinder repo16:48
smcginnissdague: We've had a few pass recently.16:48
sdagueok, you have 3 failing in the gate16:48
smcginnissdague: K, I'll take a look. Thanks for the heads up.16:48
sdagueright now16:48
eharneynetapp unit test failure, and we just landed a patch for those tests to support py3... https://review.openstack.org/#/c/280331/16:49
sheeleharney: yes, its netapp16:49
smcginnisGerrit down now? I get a Service Unavailable16:49
eharneygerrit's having some issues today16:50
*** crose has quit IRC16:51
*** crose has joined #openstack-cinder16:51
scottdaSo it's not microversions?16:51
openstackgerritSheel Rana proposed openstack/cinder: Add verbose logging for multibyte unicode errors  https://review.openstack.org/28457116:51
smcginnisscottda: Guilty until proven innocent.16:51
scottdaThat's how I think. This is turning out to be a stressful day.16:52
eharneyi'm going to just assume it's microversions, because the git commit message for that is too wide to read in my terminal :)16:52
smcginnisHah16:52
*** ivase has joined #openstack-cinder16:53
smcginnisHmm, can't repro UT failures locally.16:53
eharneyme neither so far...16:53
sheelsmcginnis: I have pasted same above16:53
*** mylu has quit IRC16:53
sheelits failing on my end locally16:53
sheelon fresh cinder checkout16:53
eharneysmcginnis: maybe need a new tox env?16:54
sheelhttps://www.irccloud.com/pastebin/LyHGJOOg/16:54
*** dims has joined #openstack-cinder16:54
smcginnisTrying fresh.16:54
*** mylu has joined #openstack-cinder16:54
smcginnisAaaand, awesome. Can't even kick off tests now.16:54
mtaninoumm, I'm hitting netapp unit test error with latest master branch....16:55
eharneymtanino: see the above conversation :)16:55
*** chris_morrell has joined #openstack-cinder16:55
sheeltox -epy27 -- --no-discover cinder.tests.unit.volume.drivers.netapp.dataontap.test_block_base.NetAppBlockStorageLibraryTestCase.test_get_reserved_percentage16:55
sheelspecifically for this test16:55
mtaninoeharney: yes, I read it thanks :)16:55
eharneyso the failure is related to mocking out log calls... ooh, this will be a fun one16:56
sheelLOG.WARN16:57
smcginniseharney: Bah!! Still not happy with anything with logging in UTs.16:58
eharneyasserting that LOG.warn was not called may be risky, since that could be called by about anything16:58
*** garthb has joined #openstack-cinder16:58
*** garthb_ has joined #openstack-cinder16:59
smcginnis<rant deleted>17:00
openstackgerritVivek Dhayaal proposed openstack/cinder: Fix usage of "cinder-volume" string  https://review.openstack.org/28322517:00
*** haomaiwa_ has quit IRC17:01
*** esker has quit IRC17:01
*** haomaiwang has joined #openstack-cinder17:01
smcginnisOh! How did that get in.17:02
smcginnisLOG.warn is deprecated, so LOG.warn won't get called.17:02
smcginnisLOG.warning17:02
eharneyit probably worked when it was first written17:03
openstackgerritEric Harney proposed openstack/cinder: Tests: Don't assert on LOG.warn  https://review.openstack.org/28481617:04
eharneythat's my proposal until anyone has a better idea ^17:04
*** zhipeng has joined #openstack-cinder17:04
xyang1smcginnis: any other objections on cheese cake?  ready to merge?17:05
Swansonmergemergemergemerge17:05
smcginnisxyang1: Yeah, I'd like to have it go in and have issues fixed as we go.17:06
xyang1smcginnis: done17:07
smcginnisMost of it is good, so rather than having to churn over a big patch on smaller things, I'd rather we have smaller focused patches.17:07
smcginnisxyang1: At least that's my take. ;)17:07
xyang1smcginnis: sure17:07
smcginniseharney: versionutils update?17:07
smcginnisThat code (UT and code under test) hasn't changed since 8/201517:08
Swansonhaving to keep merging that patch endlessly will push jgriffith to drink and horse.17:08
smcginnisThere is also no direct logging, just a call to versionutils.report_deprecated_feature.17:08
smcginnisSwanson: It will make his horses drink.17:08
*** jistr has quit IRC17:08
mtaninoeharney: or self.assertTrue(block_base.LOG.warning.called) works for me17:08
Swansonsmcginnis, :)17:08
smcginnismtanino: Yeah, looks like versionutils must have updated to switch LOG.warn to LOG.warning.17:09
eharneythat doesn't make sense though, that just means it's not a valid thing to test17:09
smcginniseharney: Exactly. I'm for your patch.17:09
eharneythe test needs to assert that a warning with some specific text appeared or not if it really wants to check that17:09
smcginnisJust get rid of them.17:09
mtaninoeharney: ok. I understand your opinion.17:09
avishay...the fear when you see you are reaching 80 characters will be with me forever...17:10
smcginnisNO! No specific text. :)17:10
smcginnisavishay: ;)17:10
*** bardia has joined #openstack-cinder17:10
smcginnisavishay: I find myself watching that with non-Python non-OS code too.17:10
sheel:)17:11
avishaysmcginnis: :)17:11
eharneywhile on the subject of warnings, i'm about to submit a different patch related to how we handle warnings in Cinder logging too17:13
smcginniseharney: Oh? In what way?17:13
eharneysmcginnis: modules that issue messages via the warnings module spit them out to stderr instead of our logs17:13
eharneysmcginnis: which is pretty not great17:13
smcginniseharney: Oh, the whole "warnings.warn()" thing?17:14
eharneysome oslo ones do this (Deprecation), python-amqp does this17:14
eharneysmcginnis: yeah17:14
smcginniseharney: Cool!17:14
Swansonavishay, I find it thrilling when you just fit a line in at 80 chars!  And heartbreaking when you have to split it....17:14
*** timcl has quit IRC17:14
dimseharney : smcginnis : oslo has a debtcollector library that helps with the deprecation stuff as well (http://docs.openstack.org/developer/debtcollector/api.html)17:15
smcginnisdims: Thanks, I hadn't looked at that one.17:16
dimssome examples here - http://docs.openstack.org/developer/debtcollector/examples.html#removing-a-class-classmethod-method-function17:16
openstackgerritJohn Griffith proposed openstack/cinder: Change frozen error messages from _LE to _  https://review.openstack.org/28482317:16
openstackgerritKendall Nelson proposed openstack/cinder: WIP: Add SnapshotStatus enum field  https://review.openstack.org/28482517:17
avishaySwanson: yep :)17:17
*** wilson_liu has joined #openstack-cinder17:20
*** Guest73495 has quit IRC17:20
jgriffithxyang1: 284823 fixes those logging hints up, thanks!17:20
smcginnisjgriffith: Thanks for that. ^^17:20
jgriffithsmcginnis: NP17:20
xyang1jgriffith: great, thanks for the quick fix17:21
*** leeantho has joined #openstack-cinder17:21
jgriffithsmcginnis: have I mentioned my distaste for /cinder/tests/unit/test_volume.py today?17:21
*** krtaylor has quit IRC17:21
smcginnisjgriffith: Hah, not today yet. :)17:21
jgriffithsmcginnis: ok... well consider it mentioned17:21
eharneyjgriffith: but it has every flavor that exists in it!17:22
eharney;)17:22
jgriffitheharney: :)17:22
smcginniseharney: You broke out some of that, right?17:22
eharneysmcginnis: yeah, but i slowed down on the continuation of that17:22
jgriffitheharney: it's sad because you've cleaned up so many things in it, but it's still rather bloated17:22
eharneyi chopped some of it into separate classes which still need to be split into different files17:22
tbarroneharney: smcginnis: mtanino: sheel: well this is too much fun, I am the culprit on that mock of LOG.warn17:22
jgriffitheharney: and some fairly crazy logic in there as well17:22
smcginniseharney: You don't want to work on unit test refactoring full time? :)17:22
tbarroneharney: thanks!17:22
*** mylu has quit IRC17:22
smcginnistbarron: It was fine at the time.17:23
jgriffithsmcginnis: ohh... I think that's a GREAT idea :)17:23
jgriffitheharney: I'll come and visit you in the institution17:23
tbarronsmcginnis: mocking LOG globally is not good17:23
eharneylol17:23
sheeltbarron: oops17:23
tbarronsmcginnis: probably shouldn't do it at all17:23
tbarronor if there's a real reason, mock it in smaller scope17:24
jgriffithtbarron: just curious why you would do it at all as you mentioend?17:24
smcginnistbarron: Yeah. And asserting on a library doing logging probably isn't too good either.17:24
tbarronjgriffith: i was learning :-)17:24
jgriffithsmcginnis: I thought the test framework did that for us anyway17:24
jgriffithtbarron: ahh... fair enough :)17:24
tbarronjgriffith: we had a mandate to get as much coverage as possible17:24
openstackgerritEric Harney proposed openstack/cinder: Capture warnings into logs  https://review.openstack.org/28482817:24
jgriffithtbarron: LOL17:24
smcginniseharney: Oh, just thought of something.17:25
eharneysmcginnis: there's the other warning thing ^17:25
tbarronjgriffith: and I got too enthusiastic17:25
jgriffithcoverage for the sake of coverage eh17:25
smcginniseharney: Probably should have pulled out the "self.mock_object(block_base, 'LOG')" lines in those tests too.17:25
smcginniseharney: Harmless I guess, but not really needed.17:25
eharneysmcginnis: well, i looked at self.mock_object for a minute (which is used everywhere) and kinda decided i would pretend it didn't exist17:25
tbarronjgriffith: well, like all guidelines, it requires intelligence (that I didn't exercise in this case) on the part of the person following it17:25
*** haplo37 has joined #openstack-cinder17:25
smcginniseharney: ;)17:26
eharneysmcginnis: because using something like that always has be worried about whether the mocks are cleaned up right, etc17:26
openstackgerritKendall Nelson proposed openstack/cinder: WIP: Add SnapshotStatus enum field  https://review.openstack.org/28482517:26
jgriffithtbarron: haha17:26
eharneybut yeah, i missed it as far as removing it17:26
tbarronlately I've been mocking time.time() and such.  Am learning to do it with as narrow scope as possible :-)17:26
tbarronthere's a lot to learn about mock17:27
smcginnistbarron: Really, time.time() has been mocking me.17:27
tbarrontime is unreal17:27
openstackgerritMerged openstack/python-cinderclient: Remove pypy from tox environment list  https://review.openstack.org/28321517:27
tbarrona position that I have learned to take aas the years have passed17:27
Swansontime.time() gets all men.17:27
tbarronpretty deep, Homer17:28
*** julim has quit IRC17:28
eharneyi also feel like Homer when i work on unit tests17:29
eharneyit's just "Doh! Doh! Doh!" over and over17:29
smcginnis:)17:29
*** merooney has joined #openstack-cinder17:30
*** asti_ has joined #openstack-cinder17:33
*** krtaylor has joined #openstack-cinder17:33
*** jordanP has quit IRC17:35
openstackgerritEric Harney proposed openstack/cinder: Delete volumes with snapshots  https://review.openstack.org/26498217:36
*** jwcroppe has quit IRC17:38
*** jwcroppe has joined #openstack-cinder17:39
openstackgerritMerged openstack/python-cinderclient: Updated from global requirements  https://review.openstack.org/28276817:40
SwansonCinder patches are drowning in a sea of blood.  Might want to skip +A'ing and rechecking until that is sorted.17:40
*** mylu has joined #openstack-cinder17:43
*** jwcroppe has quit IRC17:43
*** asti_ has left #openstack-cinder17:44
*** asti_ has joined #openstack-cinder17:45
*** crose has quit IRC17:47
*** bardia has quit IRC17:49
*** avishay has quit IRC17:49
jgriffithSwanson: ?17:51
SwansonSeems better now.  I presume it was the failures being talked about earlier.17:51
*** apoorvad has joined #openstack-cinder17:52
*** crose has joined #openstack-cinder17:53
*** jwcroppe has joined #openstack-cinder17:58
*** timcl has joined #openstack-cinder18:00
*** haomaiwang has quit IRC18:01
*** hemna has joined #openstack-cinder18:01
*** haomaiwang has joined #openstack-cinder18:01
*** mylu has quit IRC18:02
*** ndipanov has quit IRC18:07
*** lpetrut has quit IRC18:08
*** julim has joined #openstack-cinder18:10
*** wilson_liu has quit IRC18:14
*** wilson-l has joined #openstack-cinder18:14
*** tsekiyama has quit IRC18:16
*** wanghao has quit IRC18:17
*** wanghao has joined #openstack-cinder18:17
openstackgerritMerged openstack/python-cinderclient: Add extra_specs_list test  https://review.openstack.org/28207518:18
aorourkejgriffith, the issue of the active_backend_id not being passed into the driver if c-vol is restarted after fail-over still exists18:19
*** annasort has quit IRC18:19
aorourkejgriffith, i can have my driver save off the new active_backend_id no problem, but if c-vol is restarted, i lose that entry18:20
aorourkejgriffith, the disabled services are filtered out of the query used here: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L423 so the service is not found. how can we handle the case where c-vol is restarted?18:22
jgriffithaorourke: don't use that query18:26
aorourkejgriffith, it is done in the manager18:27
aorourkejgriffith, on driver init18:27
jgriffithaorourke: Yes, my point is that I think that's a bug outside of replication18:27
jgriffithaorourke: if someone disables the service that should be honored on a restart, looking at the existing code that doesn't appear to be the case18:28
jgriffithaorourke: see what I mean?18:28
aorourkejgriffith, maybe it is. Either way, if c-vol is restarted or the driver is re-initialized, fail-over no longer works18:28
aorourkejgriffith, the driver has no access to the active_backend_id18:28
jgriffithaorourke: yeah, I got ya on that18:28
jgriffithaorourke: I can fix that18:28
jgriffithaorourke: going to be a bit before I get it fired up and running again though18:31
aorourkejgriffith, followup patch then? Looks like your patch has been +A'd18:31
jgriffithaorourke: yeah, follow up as bug fix for restarts18:32
aorourkejgriffith, sounds good18:32
*** salv-orlando has quit IRC18:32
*** hemna has quit IRC18:33
*** Suyash has joined #openstack-cinder18:37
*** salv-orlando has joined #openstack-cinder18:39
*** haomaiwang has quit IRC18:39
*** hemna has joined #openstack-cinder18:40
*** asti_ has left #openstack-cinder18:42
openstackgerritYucong Feng proposed openstack/cinder: Return all target_wwpns for FC storwize  https://review.openstack.org/28254118:42
*** haomaiwang has joined #openstack-cinder18:44
*** bardia has joined #openstack-cinder18:45
anteayajungleboyj: are you at the ibm site in rochester? and are you coming to the neutron sprint? (or have you been already?)18:48
openstackgerritJohn Griffith proposed openstack/cinder: Add connector info to volume_attachment table  https://review.openstack.org/28486718:49
*** haomaiwang has quit IRC18:49
jungleboyjanteaya: I am at the IBM site but I don't know that I am going to make it over there.  It has been a very busy week.18:49
anteayajungleboyj: I hear that18:51
*** merooney has quit IRC18:51
anteayawould be great to see you if you can make it over18:51
*** hemna has quit IRC18:52
smcginnisanteaya: Missed you. I was there the last two days but had to get back to work.18:52
anteayasmcginnis: :( sorry I missed you18:53
anteayawould have been great to see you18:53
anteayawas it beneficial to be here do you think?18:53
*** mvk has joined #openstack-cinder18:54
*** IlyaG has quit IRC18:54
smcginnisanteaya: Yeah, it was good to meet some of the folks I don't normally interact with.18:54
smcginnisA couple of interesting discussions as well.18:55
*** dramakri has joined #openstack-cinder18:55
*** ChubYann has joined #openstack-cinder18:55
anteayanice to hear18:55
anteayaglad you could make it down for a few days18:55
smcginnisanteaya: You got lucky with the weather. This is overall pretty good for Feb.18:56
*** lpetrut has joined #openstack-cinder18:56
anteayaway warm18:56
anteayahome keeps getting rain18:56
anteayait is supposed to be a steady -10 at home at least18:57
*** cknight has quit IRC18:57
anteayaand it isn't18:57
anteaya:(18:57
smcginnisAt least you're getting a little sunshine here.18:57
anteayaour local economy is hurting as we are tourist based and also logging18:57
anteayasunshine is good!18:57
smcginnisanteaya: Oh yeah, didn't think of that.18:57
*** cknight has joined #openstack-cinder18:58
anteayahard on tourism when they keep falling through the ice when they shouldn't be on it in the first place18:58
*** hemna has joined #openstack-cinder18:58
anteayabut they don't think of that18:58
smcginnisHah, I suppose.18:58
smcginnisWell, off to a meeting. Have fun!18:59
anteayathanks, happy meeting18:59
*** merooney has joined #openstack-cinder18:59
*** esker has joined #openstack-cinder19:01
*** daneyon has joined #openstack-cinder19:02
ntpttris the volume status 'maintenance' only reserved for migration or is there anything else its used for?19:05
*** daneyon has quit IRC19:06
sdaguehey, can folks stop approving cinder patches until the unit tests are fixed?19:06
sdagueoh, sorry, looks like they did. I had an old zuul screen with different fails.19:07
sdaguenever mind19:07
hemnadoh19:07
sdaguethough, I haven't seen the fixed change post into the gate yet, so I have no idea if it's fixed or not19:10
eharneycheck jobs haven't even started running on the fix yet19:10
sdagueeharney: ah19:10
sdaguethe mad rush after the gate fix?19:11
eharneyhttps://review.openstack.org/#/c/284816/ is the patch to fix it19:12
*** angela-s has joined #openstack-cinder19:14
Swanson373 patch queue.  Then gate.  Soooo... Sometime sunday things will be ready for a recheck?19:15
*** JoseMello has quit IRC19:18
*** salv-orlando has quit IRC19:29
*** andymaier has quit IRC19:30
*** salv-orlando has joined #openstack-cinder19:36
openstackgerritEric Harney proposed openstack/cinder: Delete volumes with snapshots  https://review.openstack.org/26498219:41
*** kvidvans has joined #openstack-cinder19:42
openstackgerritKendall Nelson proposed openstack/cinder: Add SnapshotStatus enum field  https://review.openstack.org/28482519:42
eharneyi rebased delete volume with snaps to merge after Replication v2.1 (rpcapi version number sync)  ^19:42
*** haomaiwang has joined #openstack-cinder19:45
*** lpetrut has quit IRC19:48
*** shyama has quit IRC19:50
*** krotscheck is now known as krotscheck_dcm19:50
*** timcl has quit IRC19:51
*** martyturner has quit IRC19:52
*** haomaiwang has quit IRC19:53
*** lpetrut has joined #openstack-cinder19:54
*** timcl has joined #openstack-cinder19:55
*** hemna has quit IRC19:56
*** porrua has quit IRC19:59
*** porrua has joined #openstack-cinder19:59
*** martyturner has joined #openstack-cinder19:59
*** porrua has quit IRC20:02
*** porrua has joined #openstack-cinder20:03
openstackgerritVivek Dhayaal proposed openstack/cinder: Fixed string formatting issues in volume manager  https://review.openstack.org/28490720:11
*** annasort has joined #openstack-cinder20:15
*** salv-orlando has quit IRC20:18
*** salv-orlando has joined #openstack-cinder20:20
*** esker has quit IRC20:21
*** kfarr has quit IRC20:23
*** sheel has quit IRC20:27
diablo_rojobrick799220:28
diablo_rojoLol20:29
diablo_rojonvm that20:29
* smcginnis writes down diablo_rojo's passwords20:29
diablo_rojoI am just failing at life today20:29
smcginnis:]20:29
diablo_rojoThis whole week actually20:29
smcginnisdiablo_rojo: Can't be _that_ bad.20:30
diablo_rojosmcginnis: I guess things could have gone worse today given how little and badly I slept last night.20:31
smcginnisdiablo_rojo: Bleh. That sucks.20:32
diablo_rojosmcginnis: That it does. I can sleep in tomorrow though so that'll be nice. Are you still in Rochester?20:32
smcginnisdiablo_rojo: Nope, bad to the cities.20:32
smcginnis*back20:32
diablo_rojosmcginnis: How was the meetup while you were there?20:33
smcginnisdiablo_rojo: Not bad. Nice to hang out with folks.20:34
smcginnisdiablo_rojo: I still think you're crazy with that commute though.20:34
diablo_rojosmcginnis: I sleep for most of them. That's the only way I can cope.20:35
diablo_rojosmcginnis: Also its way more fun to harrass jungleboyj in person.20:35
scottdadiablo_rojo: I hope you're not the driver.20:35
smcginnisHah!20:35
diablo_rojoscottda: Not usually while I'm sleeping20:36
scottdawhew!20:36
diablo_rojoscottda: Have to listen to Wiggle on repeat to keep me awake.20:36
scottdaThat works? It seems kinda soothing and sleep-inducing to me.20:36
cfoutssmcginnis: I see your point regarding https://review.openstack.org/#/c/284816. I didn't like the use of warn.call either. A number of these cases need bug fixes (*cough refactoring). I'll see what I can do about it in Newton20:37
smcginnisscottda: It's like a lullaby.20:37
smcginniscfouts: Awesome, thanks!20:38
scottdaIN all seriousness, I'd appreciate any reviewer input on the direction I've taken with microversion cinderclient for /v3 endpoint: https://review.openstack.org/#/c/24816320:38
smcginniscfouts: I know there is a lot in there, all over the place.20:38
scottdaA quick look and general :) or :( would be nice.20:38
smcginnisscottda: :|20:38
scottdasmcginnis: That all leads to the next big question: How badly do we want these changes for the Mitaka release of cinderclient?20:39
smcginnisscottda: Kidding, haven't had a chance to look yet.20:39
smcginnisscottda: Did you see the requirements error?20:39
smcginnisscottda: It would be great if we can get this in for M.20:39
smcginnisscottda: But if we have to wait until after the M deadline for clients, I think we're fine.20:40
*** jwcroppe has quit IRC20:40
*** daneyon has joined #openstack-cinder20:40
*** jwcroppe has joined #openstack-cinder20:40
scottdasmcginnis: What requirements error? You may need a browser refresh.20:41
smcginnisscottda: If you have CI's filtered you won't see it.20:41
smcginnisscottda: All jenkins tests show up green but there's a -1 from jenkins.20:41
scottdaahh, you are right.20:42
eharneythe "Toggle CI" thing is broken for requirements failures20:42
smcginniseharney: And other cases...20:42
diablo_rojosmcginnis: Yeah I see that too.20:42
*** JoseMello has joined #openstack-cinder20:42
*** haplo37 has quit IRC20:43
scottdaOK, olso stuff, I think due to latest library. I'll fix after gate stuff calms down.20:43
smcginnisscottda: Good plan. Not much point in doing it immediately with the way things are going.20:44
smcginnisDang, up to 383 in queue.20:45
*** jwcroppe has quit IRC20:45
eharneythat's why i just put Depends-On: <gate fix> in my last patch submission and kept moving20:46
haypocinder.tests.unit.volume.drivers.netapp.dataontap.test_block_base.NetAppBlockStorageLibraryTestCase.test_get_reserved_percentage fails20:46
haypoin master20:46
smcginnishaypo: Fix is in queue.20:46
hayposmcginnis: ah great :) how was it merged? the test didn't fail on the gate?20:46
jungleboyjsmcginnis: Oh, that is why my UT is failing here.20:46
openstackgerritMerged openstack/python-cinderclient: Don't print HTTP codes for non-HTTP errors  https://review.openstack.org/28385020:46
jungleboyjYay.  Glad it is not my problem.20:47
smcginnishaypo: A test was checking for a mocked logger call that changed in an oslo library.20:47
smcginnisjungleboyj: It's all your fault!20:47
jungleboyjsmcginnis: Are two test failing due to that?20:47
smcginnisAnd scottda's of course for microversions.20:47
hayposmcginnis: hum ok20:47
smcginnisjungleboyj: I just saw one, but there were two tests doing that.20:47
smcginnishaypo: Hopefully it makes it through that queue some time this week.20:48
eharneythe other test was passing because it was asserting that the log method was called, but still wrong20:48
*** porunov has joined #openstack-cinder20:48
jungleboyjsmcginnis: Ok.  Cool.  Been beating my head against that for a little bit.20:49
smcginnisjungleboyj: That's why diablo_rojo is having a bad week. Bang your head against the other wall for a bit.20:50
*** haomaiwang has joined #openstack-cinder20:50
openstackgerritDina Belova proposed openstack/cinder: Use OSprofiler options consolidated in lib itself  https://review.openstack.org/27815520:54
*** mylu has joined #openstack-cinder20:57
*** haomaiwang has quit IRC20:58
* jungleboyj starts banging his head again.20:58
scottdarock on jungleboyj20:58
openstackgerritJacob Gregor proposed openstack/cinder: Storwize: SVC multiple management IPs  https://review.openstack.org/28426721:02
*** martyturner has quit IRC21:02
*** timcl has quit IRC21:03
openstackgerritJacob Gregor proposed openstack/cinder: Storwize SVC multiple management IPs  https://review.openstack.org/28426721:04
*** raildo is now known as raildo-afk21:04
*** haplo37 has joined #openstack-cinder21:06
eharneysmcginnis: could you look at https://review.openstack.org/#/c/268255/ again?   I just found more missing dependencies21:06
*** tpsilva has quit IRC21:07
*** merooney has quit IRC21:09
*** _alastor_ has joined #openstack-cinder21:09
openstackgerritEric Harney proposed openstack/cinder: Add missing requirements  https://review.openstack.org/28492921:13
*** martyturner has joined #openstack-cinder21:14
*** ildikov has quit IRC21:16
*** timcl has joined #openstack-cinder21:17
*** annasort has quit IRC21:25
*** annasort has joined #openstack-cinder21:28
*** timcl has quit IRC21:29
smcginniseharney: Back, looking now.21:30
*** [1]Thelo has joined #openstack-cinder21:32
*** jungleboyj has quit IRC21:32
smcginniseharney: ImportError: cannot import name normalize_name21:33
smcginniseharney: Am I missing something?21:34
smcginnisWell... other than the normalize_name module of course.21:34
*** Thelo has quit IRC21:34
*** [1]Thelo is now known as Thelo21:34
*** esker has joined #openstack-cinder21:36
*** kaisers has quit IRC21:39
*** esker has quit IRC21:41
*** sgotliv has joined #openstack-cinder21:41
*** kaisers has joined #openstack-cinder21:41
*** annasort has quit IRC21:44
eharneysmcginnis: umm... not familiar with that one, how did you hit it?21:45
smcginniscd cinder; git review -d 268255; tox -e pip-missing-reqs21:46
*** esker has joined #openstack-cinder21:46
*** akerr has quit IRC21:47
eharneysmcginnis: is there a stack trace?  i don't see "normalize_name" anywhere?21:47
eharneyahh, it's a method imported from pip.utils21:48
smcginniseharney: Here's the full thing: http://paste.openstack.org/show/488280/21:48
smcginnisyep21:48
smcginnisKind of ironic, don't you think?21:49
eharneyhah, yeah21:49
eharneyi assume you need a newer pip, what version is that?21:49
smcginnis8.0.321:49
smcginnispip 8.0.3 from /usr/local/lib/python2.7/dist-packages (python 2.7)21:49
*** annasort has joined #openstack-cinder21:50
*** esker has quit IRC21:51
*** esker has joined #openstack-cinder21:51
eharneysmcginnis: apparently that method was removed in 8.0.021:51
eharneysmcginnis: so i guess the pip_missing_reqs package is buggy, awesome21:51
smcginnisDoh!21:52
*** winston-d_ has quit IRC21:52
*** haomaiwang has joined #openstack-cinder21:55
*** chris_morrell has quit IRC21:55
*** baumann has quit IRC21:56
*** delatte has quit IRC22:00
*** haomaiwang has quit IRC22:01
*** porunov has quit IRC22:01
*** ivase has quit IRC22:01
*** julim has quit IRC22:04
eharneysmcginnis: i went and wrote a fix for it, only to find that dims already did it :)22:04
dimshaha eharney22:05
*** merooney has joined #openstack-cinder22:05
*** porrua has quit IRC22:07
smcginnis:)22:07
*** gouthamr has quit IRC22:07
_alastor_hey folks.  I'm trying to post a review for cinder, but `git review` tells me to fill out the contact information on review.openstack.org and that site just gives me a server error when I try to do that.22:07
smcginnis_alastor_: I can get to it now. Can you try to refresh?22:07
smcginnis_alastor_: I know they've been having some issues today.22:08
*** martyturner has quit IRC22:08
_alastor_refresh the page?22:08
smcginnis_alastor_: Yep. Or try to hit it again in some way.22:08
_alastor_kk22:08
_alastor_It still says 'server error cannot store contact information'22:09
_alastor_It said the same thing when I tried to input that information when I signed the contribution agreement.22:10
*** eharney has quit IRC22:10
smcginnis_alastor_: Hmm. Might need to ask over in #openstack-infra if someone there knows of any issues with that right now.22:10
_alastor_cool.  I'll head over there.  Thanks!22:10
*** mylu has quit IRC22:10
smcginnis_alastor_: np, good luck.22:10
*** knikolla has quit IRC22:13
jgriffithaorourke: turns out I think this might be pretty easy22:14
*** crose has quit IRC22:14
jgriffithaorourke: on init if failed_over, just call failover_host again with the info from the db22:14
*** crose has joined #openstack-cinder22:15
jgriffithaorourke: which is what I should've done in the first place now that I think about it22:15
*** mylu has joined #openstack-cinder22:17
aorourkejgriffith, so the driver should then also check to see if it is failed over? Otherwise it may try and run failover related commands to a dead array22:22
patrickeastjgriffith: aorourke: hey guys, i'm catching up on the replication stuff, did one of you run into or already fix the issues where after failover you cant do anything? seeing http://paste.openstack.org/show/488284/ in c-api22:22
*** jeanfabrice has joined #openstack-cinder22:22
aorourkepatrickeast, is that the newest patch set? Looks like an error from before FAILED_OVER was added in the object22:23
jgriffithaorourke: patrickeast https://goo.gl/aWKkgq22:23
patrickeastaorourke: yep, the latest one22:23
patrickeastjgriffith: whats that for?22:24
aorourkejgriffith, ah, your comment in that answers my question22:24
* patrickeast might be missing context22:24
aorourkejgriffith, so our drivers should know that it has already done failover on the volumes and simply return the active_backend_id22:24
jgriffithpatrickeast: when you failover, if you restart a c-vol node, it comes back up and the driver doesn't "know" anything22:24
jgriffithpatrickeast: I forgot to tell the driver on init that "hey... you're supposed to be in a failed over state based on the DB"22:25
patrickeastjgriffith: huh? that was why we passed in the like active backend id22:25
patrickeastjgriffith: or was that not enough?22:25
Swansonpatrickeast, is it being sent in?22:25
aorourkepatrickeast, disabled services were being filtered out the of the query22:25
*** delatte has joined #openstack-cinder22:25
aorourkeso no it was not being sent in22:25
aorourkebecause the manager could not find the service22:25
patrickeastwhy not just use a different query?22:26
aorourkepatrickeast, that is always an option I believe22:26
* patrickeast is suspicious about calling failover multiple times and having the driver need to know how to handle them correctly22:26
jgriffithaorourke: patrickeast yes, so there's two sides of it22:27
patrickeastits also very possible i'm kind of out of the loop and just causing trouble :D22:27
jgriffithpatrickeast: I could just add a new call that tells it what the backend_id is set to and leave it at that22:28
jgriffithpatrickeast: but I thought there might be some things that driver wanted to reset after it did a restart22:28
jgriffithpatrickeast: like if it was keeping cached info or something22:28
aorourkejgriffith, I think something along those lines is better. I too am a little iffy on calling failover every time22:28
patrickeastjgriffith: wasn't it a kwarg for the driver init?22:28
aorourkepatrickeast, it still is22:28
patrickeastim not sure i'm seeing why a new method is required22:28
jgriffithahhh sob22:28
jgriffithYou're correct patrickeast22:29
jgriffithaorourke: use the kwarg :)22:29
aorourkejgriffith, I am using the kwarg22:29
jgriffithpatrickeast: that seems like soooo long ago22:29
aorourkejgriffith, but it is not set22:29
aorourkethat is the whole problem22:29
jgriffithaorourke: well.. why didn't you say so :)22:29
aorourkejgriffith, patrickeast this query is being called https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L419-L42922:29
aorourkei did22:29
jeanfabricejgriffith:  we have a talk last a day ago regarding the use of osapi_volume_base_URL in cinder.conf. Just to let you know the issue was a kind of pebkac on my side. osapi_volume_base_URL is dedicated to the wsgi setup while a recent (kilo) public_endpoint patch introduces the configuration of the versions endpoint announced by the api. We backported this patch to juno.22:29
jgriffithYou HP guys... everything is a riddle22:29
jgriffith:)22:29
jgriffithjust kidding22:29
patrickeastok i think i get it now22:29
aorourkejgriffith, and that query strips out alld isabled services22:30
patrickeastso yah, lets fix that query22:30
aorourkeall disabled*22:30
jgriffithpatrickeast: yes, that's the easy one22:30
*** hemna has joined #openstack-cinder22:30
*** jungleboyj has joined #openstack-cinder22:31
openstackgerritMatt Smith proposed openstack/cinder: Updating Datera DataFabric Driver to v2 of Datera DataFabric API  https://review.openstack.org/28496722:32
*** diablo_rojo has quit IRC22:32
jgriffithaorourke: patrickeast https://goo.gl/EavVz622:33
*** delattec has joined #openstack-cinder22:33
patrickeastjgriffith: sweet22:34
patrickeastjgriffith: next up: any ideas on http://paste.openstack.org/show/488284/?22:34
patrickeastlooks like going from db -> object after a failover it doesn't like the status enum value22:35
patrickeastbut i dunno why22:35
patrickeastthat field was added in the latest patchset22:35
*** mylu has quit IRC22:35
jgriffithhum, not sure... gimmie a moment22:35
*** delatte has quit IRC22:36
jgriffithpatrickeast: I think that's something different than the enum22:36
*** IlyaG has joined #openstack-cinder22:36
jgriffithpatrickeast: It appears that it's trying to access a member field named "failed-over" but that's no bueano22:36
jgriffithfailed_over22:36
patrickeastohh22:37
jgriffithwhat I mean is there is not "failed_over" in the db model at all22:37
jgriffithpatrickeast: that's a wild guess though, trying to reproduce it now22:38
hemnaare patches making it through the gate yet?22:40
patrickeastjgriffith: poking around a little bit the only thing i see is http://paste.openstack.org/show/488286/, in the stack trace its failing while iterating through the field keys and is complaining about the field value22:41
patrickeastthe only thing i see with that string*22:42
*** mylu has joined #openstack-cinder22:42
smcginnishemna: A think some are. Still a lot of issues yet.22:43
*** annasort has quit IRC22:43
*** arch-nemesis has quit IRC22:44
patrickeastjgriffith: yea its the replication_status value, updating the db directly to set it to disabled prevents the error22:44
jgriffithpatrickeast: coolio, looking now22:44
*** mylu has quit IRC22:44
jgriffithpatrickeast: don't forget that snippet I sent on the service get needs a context change22:44
*** mylu has joined #openstack-cinder22:44
patrickeastjgriffith: ah yea, thanks, was just applying that change to my test env22:45
Swansonsmcginnis, 284816 is still the big holdup, right?  Once that goes through cinder has a chance.  Currently blocked with gate-cinder-docs-constraints queued.22:46
jgriffithpatrickeast: oddly I can't repro your failure22:46
jgriffithpatrickeast: what sequence of cmds did you run to get that?22:47
aorourkepatrickeast, I have not ran into that either during testing FWIW22:47
smcginnisSwanson: Yep, that's the one.22:47
jgriffithaorourke: http://goo.gl/Oeee1h22:47
jgriffithaorourke: that jibberish in the middle is the stop/restart of c-vol22:48
smcginnisSwanson: Man, queued for almost 6 hours and just waiting on a docs-constraints test.22:48
patrickeastjgriffith: just did a failover (cinder failover-host blah) and then was trying to run like cinder service-list or cinder create22:48
aorourkejgriffith, the db was always populated, it just was not being passed into the driver via the kwargs22:48
jgriffithaorourke: right... it is now though :)22:48
jgriffithsorry... now I'm using riddles :)22:49
patrickeastjgriffith: aorourke : let me reset things and get to a nice clean state and try to repro again, theres a reasonable chance something weird happened while i was trying to failover and fixing some bugs in my driver22:49
aorourkei will add that change to my setup as well and see what happens22:49
Swansonsmcginnis, +2/A that thing.  It is going to pass.22:50
jgriffithaorourke: here's a breakpoint in the driver on init:  http://goo.gl/SC26nf22:50
jgriffithaorourke: if you roll with that don't forget that I didn't fix the context in that gist yet22:50
jgriffithpatrickeast: I'm completely unable to repro the issue you are seeing :(22:51
patrickeastjgriffith: no worries, i'm not convinced yet that its a real bug or something22:51
*** esker has quit IRC22:52
*** jgregor has quit IRC22:54
openstackgerritJohn Griffith proposed openstack/cinder: Get disabled services on init  https://review.openstack.org/28497622:55
*** hemna has quit IRC22:55
* jgriffith was so happy with his attach/connector patch, until he started looking at the unit tests22:58
* jgriffith jumps out the window22:58
smcginnisSwanson: Already did. Should go right through.22:58
* smcginnis knocks on formica22:58
* jgriffith knocks on his hollow head22:58
smcginnis:)22:59
smcginnisjgriffith: Unit tests tend to have that affect on people I think.22:59
*** haomaiwang has joined #openstack-cinder22:59
*** arch-nemesis has joined #openstack-cinder22:59
* jgriffith can't respond to your message right now, he's jumped out a window23:00
smcginnishah!23:00
*** haomaiwang has quit IRC23:01
*** delatte has joined #openstack-cinder23:01
*** rlrossit has quit IRC23:02
*** delattec has quit IRC23:03
*** crose has quit IRC23:04
*** arch-nemesis has quit IRC23:07
*** hemna has joined #openstack-cinder23:07
*** odyssey4me has joined #openstack-cinder23:08
*** salv-orl_ has joined #openstack-cinder23:08
odyssey4meexit23:08
*** odyssey4me has left #openstack-cinder23:08
*** cknight has quit IRC23:09
*** jungleboyj has quit IRC23:10
*** edmondsw has quit IRC23:11
*** lpetrut has quit IRC23:11
*** edtubill has quit IRC23:11
hemnasmcginnis, so, still no +A'ing patches then?23:12
*** salv-orlando has quit IRC23:12
scottdasmcginnis: What about submitting patches? Are we supposed to hold off on that as well?23:14
*** xyang1 has quit IRC23:14
*** sborkows has quit IRC23:17
*** xek_ has joined #openstack-cinder23:19
*** xek has quit IRC23:19
*** sborkows has joined #openstack-cinder23:20
*** mriedem has quit IRC23:23
openstackgerritPatrick East proposed openstack/cinder: Update Pure replication to cheesecake  https://review.openstack.org/27698123:24
*** haplo37 has quit IRC23:25
*** hemna has quit IRC23:28
*** JoseMello has quit IRC23:28
*** jeanfabrice has quit IRC23:30
jgriffithpatrickeast: so did you get it working then?23:31
patrickeastjgriffith: dunno yet, spent some time fixing up unit tests... waiting on fresh stack.sh right now23:32
jgriffithpatrickeast: ahh... ok, well let me know23:32
patrickeastjgriffith: i'm hoping its just a side effect of my kinda hacked up devstack23:32
*** jeanfabrice has joined #openstack-cinder23:35
patrickeastugh my stupid ci is broken again23:38
patrickeastevery time i go on a trip somewhere.... its like it knows23:38
jgriffithpatrickeast: I'm not sure what's going on but mine has been acting up lately as well23:38
jgriffithpast few days have been weird stuff in the gerrit stream it looks like23:38
patrickeastyea23:38
patrickeastand i think a lot of libs getting cut23:39
patrickeastwhich never helps with devstack stability23:39
*** salv-orl_ has quit IRC23:39
jgriffith:(23:39
*** jeanfabrice has quit IRC23:39
*** bardia_ has joined #openstack-cinder23:40
*** bardia has quit IRC23:40
*** jeanfabrice has joined #openstack-cinder23:40
*** sgotliv has quit IRC23:42
jgriffithhmm... network unreachable trying to connect to gerrit23:45
jgriffiththis doesn't look good23:45
*** smoriya_ has joined #openstack-cinder23:45
*** edtubill has joined #openstack-cinder23:49
SwansonInfra is having their sprint now aren't they?23:53
*** yhayashi has joined #openstack-cinder23:54
*** jeanfabrice has quit IRC23:57
*** krtaylor has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!