| *** alonma has joined #openstack-cinder | 00:00 | |
| *** alonma has quit IRC | 00:05 | |
| *** chlong has joined #openstack-cinder | 00:06 | |
| *** alonma has joined #openstack-cinder | 00:07 | |
| *** alonma has quit IRC | 00:12 | |
| *** chlong has quit IRC | 00:12 | |
| *** cknight has joined #openstack-cinder | 00:12 | |
| *** alonma has joined #openstack-cinder | 00:13 | |
| *** chlong has joined #openstack-cinder | 00:13 | |
| *** alonma has quit IRC | 00:18 | |
| *** salv-orlando has quit IRC | 00:21 | |
| *** laughterwym has joined #openstack-cinder | 00:23 | |
| *** laughter_ has joined #openstack-cinder | 00:24 | |
| *** alonma has joined #openstack-cinder | 00:25 | |
| *** laughter_ has quit IRC | 00:26 | |
| *** mylu has quit IRC | 00:27 | |
| *** houming has joined #openstack-cinder | 00:27 | |
| *** laughter_ has joined #openstack-cinder | 00:27 | |
| *** laughterwym has quit IRC | 00:27 | |
| *** alonma has quit IRC | 00:29 | |
| *** yhayashi has joined #openstack-cinder | 00:30 | |
| *** alonma has joined #openstack-cinder | 00:31 | |
| *** alonma has quit IRC | 00:35 | |
| *** alonma has joined #openstack-cinder | 00:37 | |
| *** alonma has quit IRC | 00:42 | |
| *** alonma has joined #openstack-cinder | 00:44 | |
| *** cknight has quit IRC | 00:46 | |
| *** alonma has quit IRC | 00:49 | |
| *** alonma has joined #openstack-cinder | 00:50 | |
| *** mylu has joined #openstack-cinder | 00:51 | |
| *** alonma has quit IRC | 00:55 | |
| *** markvoelker has joined #openstack-cinder | 00:55 | |
| *** alonma has joined #openstack-cinder | 00:56 | |
| *** cheneydc has joined #openstack-cinder | 00:57 | |
| *** markvoelker has quit IRC | 01:00 | |
| *** alonma has quit IRC | 01:01 | |
| *** alonma has joined #openstack-cinder | 01:03 | |
| *** chlong has quit IRC | 01:06 | |
| *** mylu has quit IRC | 01:07 | |
| *** alonma has quit IRC | 01:07 | |
| *** mylu has joined #openstack-cinder | 01:09 | |
| *** alonma has joined #openstack-cinder | 01:09 | |
| *** mylu has quit IRC | 01:10 | |
| *** mylu has joined #openstack-cinder | 01:10 | |
| *** davechen has joined #openstack-cinder | 01:12 | |
| *** alonma has quit IRC | 01:13 | |
| *** alonma has joined #openstack-cinder | 01:15 | |
| *** davechen1 has joined #openstack-cinder | 01:17 | |
| *** mylu has quit IRC | 01:19 | |
| *** alonma has quit IRC | 01:19 | |
| *** mylu has joined #openstack-cinder | 01:19 | |
| *** davechen has quit IRC | 01:19 | |
| *** davechen has joined #openstack-cinder | 01:23 | |
| *** haomaiwang has joined #openstack-cinder | 01:24 | |
| *** davechen1 has quit IRC | 01:25 | |
| *** salv-orlando has joined #openstack-cinder | 01:29 | |
| *** salv-orlando has quit IRC | 01:31 | |
| *** Lee1092 has joined #openstack-cinder | 01:32 | |
| *** lixiaoy1 has joined #openstack-cinder | 01:36 | |
| *** alonma has joined #openstack-cinder | 01:39 | |
| *** alonma has quit IRC | 01:43 | |
| *** alonma has joined #openstack-cinder | 01:45 | |
| *** baojg has joined #openstack-cinder | 01:48 | |
| *** alonma has quit IRC | 01:50 | |
| *** alonma has joined #openstack-cinder | 01:51 | |
| *** alonma has quit IRC | 01:56 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add restore_volume_id in backup https://review.openstack.org/260903 | 01:57 |
|---|---|---|
| *** alonma has joined #openstack-cinder | 01:58 | |
| *** haomaiwang has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-cinder | 02:01 | |
| *** alonma has quit IRC | 02:02 | |
| *** alonma has joined #openstack-cinder | 02:05 | |
| *** alonma has quit IRC | 02:09 | |
| *** chlong has joined #openstack-cinder | 02:09 | |
| *** mudassirlatif has joined #openstack-cinder | 02:11 | |
| *** alonma has joined #openstack-cinder | 02:11 | |
| *** alonma has quit IRC | 02:16 | |
| *** alonma has joined #openstack-cinder | 02:18 | |
| *** mylu has quit IRC | 02:19 | |
| *** alonma has quit IRC | 02:22 | |
| *** laughter_ has quit IRC | 02:26 | |
| *** laughterwym has joined #openstack-cinder | 02:27 | |
| *** mylu has joined #openstack-cinder | 02:43 | |
| *** mylu has quit IRC | 02:47 | |
| *** sheel has joined #openstack-cinder | 02:49 | |
| *** markvoelker has joined #openstack-cinder | 02:56 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Scaling backup service https://review.openstack.org/262395 | 02:58 |
| *** markvoelker has quit IRC | 03:00 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-cinder | 03:01 | |
| lixiaoy1 | :hemna ping may I ask you whether any plans to add sheepdog into os-brick? | 03:11 |
| lixiaoy1 | :hemna is there anyone working on it? | 03:11 |
| *** alonma has joined #openstack-cinder | 03:18 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Update quota when volume type renames https://review.openstack.org/267999 | 03:19 |
| *** alonma has quit IRC | 03:22 | |
| *** alonma has joined #openstack-cinder | 03:24 | |
| *** mylu has joined #openstack-cinder | 03:27 | |
| *** alonma has quit IRC | 03:29 | |
| *** cknight has joined #openstack-cinder | 03:29 | |
| *** alonma has joined #openstack-cinder | 03:31 | |
| *** cknight has quit IRC | 03:34 | |
| openstackgerrit | Angus Lees proposed openstack/os-brick: Trivial rootwrap -> privsep replacement https://review.openstack.org/277224 | 03:35 |
| *** alonma has quit IRC | 03:36 | |
| *** coolsvap|away is now known as coolsvap | 03:36 | |
| *** alonma has joined #openstack-cinder | 03:37 | |
| *** alonma has quit IRC | 03:41 | |
| *** alonma has joined #openstack-cinder | 03:43 | |
| *** cknight has joined #openstack-cinder | 03:47 | |
| *** alonma has quit IRC | 03:48 | |
| *** cknight has quit IRC | 03:48 | |
| *** alonma has joined #openstack-cinder | 03:50 | |
| *** alonma has quit IRC | 03:54 | |
| *** dongc has joined #openstack-cinder | 03:56 | |
| *** alonma has joined #openstack-cinder | 03:56 | |
| *** cheneydc has quit IRC | 03:57 | |
| *** dongc is now known as cheneydc | 03:57 | |
| *** akshai has joined #openstack-cinder | 03:58 | |
| *** coolsvap is now known as coolsvap|away | 03:59 | |
| *** akshai_ has joined #openstack-cinder | 04:00 | |
| *** alonma has quit IRC | 04:00 | |
| *** dave-mccowan has quit IRC | 04:00 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 04:01 | |
| *** akshai has quit IRC | 04:03 | |
| *** alonma has joined #openstack-cinder | 04:09 | |
| *** haomaiwa_ has quit IRC | 04:13 | |
| *** alonma has quit IRC | 04:13 | |
| *** haomaiwang has joined #openstack-cinder | 04:13 | |
| *** coolsvap|away is now known as coolsvap | 04:13 | |
| *** alonma has joined #openstack-cinder | 04:15 | |
| *** akshai_ has quit IRC | 04:18 | |
| *** kbyrne has quit IRC | 04:19 | |
| *** kbyrne has joined #openstack-cinder | 04:19 | |
| *** alonma has quit IRC | 04:20 | |
| *** dims has joined #openstack-cinder | 04:28 | |
| *** laughter_ has joined #openstack-cinder | 04:29 | |
| *** dims has quit IRC | 04:30 | |
| *** mudassirlatif has quit IRC | 04:32 | |
| *** laughterwym has quit IRC | 04:32 | |
| *** dongc has joined #openstack-cinder | 04:33 | |
| *** martyturner has joined #openstack-cinder | 04:34 | |
| *** cheneydc has quit IRC | 04:34 | |
| *** dongc is now known as cheneydc | 04:34 | |
| *** ircuser-1 has joined #openstack-cinder | 04:43 | |
| *** salv-orlando has joined #openstack-cinder | 04:44 | |
| *** cooldharma06 has quit IRC | 04:45 | |
| *** cooldharma06 has joined #openstack-cinder | 04:46 | |
| *** cooldharma06 has quit IRC | 04:46 | |
| *** salv-orlando has quit IRC | 04:49 | |
| *** shyama has joined #openstack-cinder | 04:50 | |
| *** shausy has joined #openstack-cinder | 04:56 | |
| *** markvoelker has joined #openstack-cinder | 04:56 | |
| *** sheel has quit IRC | 04:57 | |
| *** hideme has joined #openstack-cinder | 05:00 | |
| *** hideme has quit IRC | 05:00 | |
| *** markvoelker has quit IRC | 05:00 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** daneyon_ has joined #openstack-cinder | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** daneyon has quit IRC | 05:02 | |
| *** Guest78744 has joined #openstack-cinder | 05:12 | |
| *** Guest78744 is now known as guest_monitor | 05:13 | |
| *** alonma has joined #openstack-cinder | 05:15 | |
| *** Poornima has joined #openstack-cinder | 05:17 | |
| *** alonma has quit IRC | 05:20 | |
| *** david-lyle has quit IRC | 05:21 | |
| *** alonma has joined #openstack-cinder | 05:25 | |
| *** laughter_ has quit IRC | 05:28 | |
| *** laughterwym has joined #openstack-cinder | 05:29 | |
| *** alonma has quit IRC | 05:29 | |
| *** alonma has joined #openstack-cinder | 05:31 | |
| *** alonma has quit IRC | 05:36 | |
| *** alonma has joined #openstack-cinder | 05:37 | |
| *** alonma has quit IRC | 05:42 | |
| *** alonma has joined #openstack-cinder | 05:43 | |
| *** alonma has quit IRC | 05:48 | |
| *** baojg has quit IRC | 05:48 | |
| *** baojg has joined #openstack-cinder | 05:49 | |
| *** alonma has joined #openstack-cinder | 05:50 | |
| *** nkrinner has joined #openstack-cinder | 05:51 | |
| *** julim has quit IRC | 05:52 | |
| *** ankit_ag has joined #openstack-cinder | 05:52 | |
| *** alonma has quit IRC | 05:54 | |
| *** alonma has joined #openstack-cinder | 05:56 | |
| *** martyturner has quit IRC | 05:56 | |
| *** alonma has quit IRC | 06:00 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-cinder | 06:01 | |
| *** alonma has joined #openstack-cinder | 06:02 | |
| *** alonma has quit IRC | 06:07 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add backup update function https://review.openstack.org/263179 | 06:07 |
| *** alonma has joined #openstack-cinder | 06:08 | |
| *** haomaiwang has quit IRC | 06:13 | |
| *** alonma has quit IRC | 06:13 | |
| *** haomaiwa_ has joined #openstack-cinder | 06:14 | |
| *** alonma has joined #openstack-cinder | 06:14 | |
| *** alonma has quit IRC | 06:19 | |
| *** abhishekk has joined #openstack-cinder | 06:22 | |
| *** ChubYann_ has quit IRC | 06:24 | |
| *** ysm has joined #openstack-cinder | 06:26 | |
| *** alonma has joined #openstack-cinder | 06:26 | |
| *** salv-orlando has joined #openstack-cinder | 06:30 | |
| *** alonma has quit IRC | 06:31 | |
| *** alonma has joined #openstack-cinder | 06:33 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Use assert_valid_body in volume update https://review.openstack.org/280081 | 06:33 |
| *** mudassirlatif has joined #openstack-cinder | 06:34 | |
| *** alonma has quit IRC | 06:37 | |
| *** mudassirlatif has quit IRC | 06:38 | |
| *** alonma has joined #openstack-cinder | 06:39 | |
| *** alonma has quit IRC | 06:43 | |
| *** vgridnev has joined #openstack-cinder | 06:45 | |
| *** alonma has joined #openstack-cinder | 06:46 | |
| *** lpetrut has joined #openstack-cinder | 06:47 | |
| *** alonma has quit IRC | 06:50 | |
| *** mylu has quit IRC | 06:52 | |
| *** alonma has joined #openstack-cinder | 06:52 | |
| *** alonma has quit IRC | 06:57 | |
| *** markvoelker has joined #openstack-cinder | 06:57 | |
| *** alonma has joined #openstack-cinder | 06:58 | |
| *** crose has joined #openstack-cinder | 07:00 | |
| *** haomaiwa_ has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-cinder | 07:01 | |
| *** markvoelker has quit IRC | 07:02 | |
| *** aarefiev has quit IRC | 07:03 | |
| *** alonma has quit IRC | 07:03 | |
| *** cbader has quit IRC | 07:03 | |
| *** precurse has quit IRC | 07:03 | |
| *** jdurgin has quit IRC | 07:03 | |
| *** mordred has quit IRC | 07:03 | |
| *** sileht has quit IRC | 07:03 | |
| *** pots has quit IRC | 07:03 | |
| *** dulek has quit IRC | 07:03 | |
| *** krotscheck has quit IRC | 07:03 | |
| *** skraynev has quit IRC | 07:03 | |
| *** SergeyLukjanov has quit IRC | 07:03 | |
| *** cebruns has quit IRC | 07:03 | |
| *** pocketprotector has quit IRC | 07:03 | |
| *** netapp has quit IRC | 07:03 | |
| *** cbader has joined #openstack-cinder | 07:04 | |
| *** jdurgin has joined #openstack-cinder | 07:04 | |
| *** skraynev has joined #openstack-cinder | 07:04 | |
| *** pocketprotector has joined #openstack-cinder | 07:04 | |
| *** pots has joined #openstack-cinder | 07:04 | |
| *** mordred has joined #openstack-cinder | 07:04 | |
| *** SergeyLukjanov has joined #openstack-cinder | 07:04 | |
| *** netapp has joined #openstack-cinder | 07:04 | |
| *** alonma has joined #openstack-cinder | 07:04 | |
| *** sileht has joined #openstack-cinder | 07:04 | |
| *** krotscheck has joined #openstack-cinder | 07:04 | |
| *** cebruns has joined #openstack-cinder | 07:05 | |
| *** precurse has joined #openstack-cinder | 07:05 | |
| *** aarefiev has joined #openstack-cinder | 07:07 | |
| *** alonma has quit IRC | 07:09 | |
| *** alonma has joined #openstack-cinder | 07:10 | |
| *** crose has quit IRC | 07:10 | |
| openstackgerrit | Merged openstack/cinder: Don't use Mock.called_once_with that does not exist https://review.openstack.org/279134 | 07:15 |
| *** alonma has quit IRC | 07:15 | |
| *** gouthamr has quit IRC | 07:15 | |
| openstackgerrit | Merged openstack/cinder: Log stack trace for middleware faults https://review.openstack.org/277963 | 07:16 |
| *** wanghao has joined #openstack-cinder | 07:16 | |
| *** alonma has joined #openstack-cinder | 07:16 | |
| wanghao | lixiaoy1: ping | 07:17 |
| lixiaoy1 | wanghao: pong | 07:17 |
| wanghao | lixiaoy1: hi I'm reviewing "update quota when rename type" patch. | 07:18 |
| lixiaoy1 | what's up? | 07:19 |
| wanghao | lixiaoy1: there's a question I want to know, is it necessary to update quota_class and quota? | 07:19 |
| wanghao | lixiaoy1: Can't image some cases for those two updating. | 07:20 |
| *** liverpooler has joined #openstack-cinder | 07:21 | |
| lixiaoy1 | cinder quota-show lists quotas for a tenant. we need to change the resource if volume type name is changed | 07:21 |
| *** alonma has quit IRC | 07:22 | |
| lixiaoy1 | users can update quota | 07:22 |
| lixiaoy1 | wanghao: by quota-update | 07:22 |
| wanghao | lixiaoy1: but quota-update should just update the limit of quota. | 07:23 |
| lixiaoy1 | wanghao: yes. for example, a volume type 'test1', we set one quota item volumes_test1 as 10. | 07:24 |
| lixiaoy1 | wanghao: and then the type name is renamed to 'test2', the item in 'quota-show' should be volumes_test2 10 | 07:25 |
| *** alonma has joined #openstack-cinder | 07:26 | |
| wanghao | lixiaoy1: oh, i see... | 07:28 |
| wanghao | lixiaoy1, If updating limit before rename type, we need to update quota table too. | 07:29 |
| lixiaoy1 | wanghao: yes. quota and quota-class shows limitations, and quota-usage shows the usage of resource | 07:30 |
| *** chlong has quit IRC | 07:30 | |
| *** arecknag has joined #openstack-cinder | 07:30 | |
| *** alonma has quit IRC | 07:30 | |
| wanghao | lixiaoy1: Got it, looks like we can merge this now, thx:) | 07:31 |
| *** alonma has joined #openstack-cinder | 07:32 | |
| lixiaoy1 | wanghao: waiting for another core.. | 07:33 |
| wanghao | lixiaoy1: Yeah, I think it's soon. BTW, do you have any idea about how to provide the clean-up script off-tree? | 07:34 |
| wanghao | lixiaoy1: some wiki? or API doc? | 07:35 |
| *** alonma has quit IRC | 07:37 | |
| *** alonma has joined #openstack-cinder | 07:38 | |
| openstackgerrit | Ankit Agrawal proposed openstack/python-cinderclient: Add release notes for return-request-id-to-caller https://review.openstack.org/273930 | 07:39 |
| *** alonma has quit IRC | 07:43 | |
| *** alonma has joined #openstack-cinder | 07:45 | |
| *** salv-orlando has quit IRC | 07:47 | |
| *** Julien-zte has joined #openstack-cinder | 07:48 | |
| *** alonma has quit IRC | 07:49 | |
| *** alonma has joined #openstack-cinder | 07:51 | |
| lixiaoy1 | wanghao: no, | 07:52 |
| lixiaoy1 | wanghao: may we upload the script in github, and then add the link in the comments of the bug | 07:53 |
| *** yhayashi has quit IRC | 07:54 | |
| *** yhayashi_ has joined #openstack-cinder | 07:54 | |
| *** alonma has quit IRC | 07:55 | |
| *** shyama_ has joined #openstack-cinder | 07:56 | |
| *** shyama has quit IRC | 07:56 | |
| *** yhayashi_ has quit IRC | 07:56 | |
| *** shyama_ is now known as shyama | 07:56 | |
| *** alonma has joined #openstack-cinder | 07:57 | |
| openstackgerrit | xiaoqin proposed openstack/cinder: Storwize/SVC: Clone volume between different volume size https://review.openstack.org/266743 | 07:57 |
| *** lpetrut has quit IRC | 07:58 | |
| *** ildikov_ has quit IRC | 07:58 | |
| *** haomaiwang has quit IRC | 08:01 | |
| wanghao | lixiaoy1: hm, great. | 08:01 |
| *** alonma has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-cinder | 08:01 | |
| wanghao | lixiao1: also need some docs to guide users to use it. | 08:02 |
| *** alonma has joined #openstack-cinder | 08:03 | |
| *** yhayashi has joined #openstack-cinder | 08:06 | |
| *** alonma has quit IRC | 08:07 | |
| *** alonma has joined #openstack-cinder | 08:09 | |
| *** lpetrut has joined #openstack-cinder | 08:12 | |
| *** subscope has joined #openstack-cinder | 08:13 | |
| *** alonma has quit IRC | 08:13 | |
| *** alonma has joined #openstack-cinder | 08:14 | |
| *** Julien-zte has quit IRC | 08:20 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add backup update function https://review.openstack.org/263179 | 08:31 |
| *** laughterwym has quit IRC | 08:32 | |
| *** laughterwym has joined #openstack-cinder | 08:33 | |
| *** rcernin has joined #openstack-cinder | 08:34 | |
| *** ildikov_ has joined #openstack-cinder | 08:35 | |
| *** laughter_ has joined #openstack-cinder | 08:37 | |
| *** laughterwym has quit IRC | 08:40 | |
| *** laughter_ has quit IRC | 08:42 | |
| *** ysm has quit IRC | 08:49 | |
| *** ysm has joined #openstack-cinder | 08:50 | |
| *** ysm has quit IRC | 08:50 | |
| *** alonma has quit IRC | 08:51 | |
| *** alonma has joined #openstack-cinder | 08:52 | |
| *** sheel has joined #openstack-cinder | 08:56 | |
| *** alonma has quit IRC | 08:56 | |
| *** ysm has joined #openstack-cinder | 08:57 | |
| *** alonma has joined #openstack-cinder | 08:58 | |
| *** markvoelker has joined #openstack-cinder | 08:58 | |
| *** yhayashi has quit IRC | 08:59 | |
| *** salv-orlando has joined #openstack-cinder | 08:59 | |
| *** salv-orlando has quit IRC | 08:59 | |
| *** salv-orlando has joined #openstack-cinder | 08:59 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-cinder | 09:01 | |
| *** markvoelker has quit IRC | 09:03 | |
| *** alonma has quit IRC | 09:03 | |
| *** dulek has joined #openstack-cinder | 09:04 | |
| *** alonma has joined #openstack-cinder | 09:04 | |
| openstackgerrit | YAMADA Hideki proposed openstack/cinder: Sheepdog: Fix malformed image url format https://review.openstack.org/280114 | 09:04 |
| *** bardia has joined #openstack-cinder | 09:05 | |
| *** Julien-zte has joined #openstack-cinder | 09:06 | |
| *** houming has quit IRC | 09:06 | |
| *** lpetrut has quit IRC | 09:06 | |
| *** houming has joined #openstack-cinder | 09:06 | |
| *** sborkows has joined #openstack-cinder | 09:08 | |
| openstackgerrit | Bardia Keyoumarsi proposed openstack/cinder: Coho volume stats update https://review.openstack.org/279766 | 09:08 |
| *** alonma has quit IRC | 09:09 | |
| *** chlong has joined #openstack-cinder | 09:09 | |
| *** houming has quit IRC | 09:11 | |
| *** ysm has quit IRC | 09:14 | |
| sborkows | geguileo: Hi, I have talked to some ppl in my team about my problem we discussed about last thursday. One of the solutions involves putting the creation process in a transaction and first create temporary table with all volumes except the created one and then conditional update with that temporary table in filters. Is it a good convention for cinder? | 09:15 |
| *** ysm has joined #openstack-cinder | 09:16 | |
| geguileo | sborkows: I don't think you need the temporary table | 09:16 |
| *** alonma has joined #openstack-cinder | 09:16 | |
| *** alonma has quit IRC | 09:16 | |
| *** liverpooler has quit IRC | 09:16 | |
| *** liverpooler has joined #openstack-cinder | 09:16 | |
| *** arecknag has quit IRC | 09:16 | |
| *** arecknag has joined #openstack-cinder | 09:16 | |
| *** rcernin has quit IRC | 09:17 | |
| *** rcernin has joined #openstack-cinder | 09:17 | |
| *** alonma has joined #openstack-cinder | 09:17 | |
| *** sheel has quit IRC | 09:17 | |
| *** sheel has joined #openstack-cinder | 09:17 | |
| *** alonma has quit IRC | 09:17 | |
| *** alonma has joined #openstack-cinder | 09:17 | |
| geguileo | sborkows: You can do it with a transaction and setting the isolation level to serializable | 09:17 |
| dulek | geguileo: Can we set transaction level in a per-transaction manner? If I recall correctly with oslo.db it would require changing it globally for all connections. | 09:18 |
| sborkows | geguileo: so then we do not need the conditional update, do we? It can be done normally as earlier but wrapped with the transaction | 09:19 |
| dulek | And serializable would have terrible impact on performance. | 09:19 |
| geguileo | dulek: SQLAlchemy supports setting it at transaction level | 09:19 |
| *** ysm has quit IRC | 09:19 | |
| geguileo | dulek: I know about the performance, but creating a temporary table would probably be even worse :-( | 09:19 |
| *** ysm has joined #openstack-cinder | 09:19 | |
| dulek | Sure, not only perfomancewise, but also would be just ugly… | 09:20 |
| *** sgotliv has joined #openstack-cinder | 09:20 | |
| *** lpetrut has joined #openstack-cinder | 09:21 | |
| *** bardia has quit IRC | 09:22 | |
| geguileo | I'm no SQL expert, but I find it odd that we cannot do the update with an exists condition on the same table :-( | 09:22 |
| *** aagrawal has joined #openstack-cinder | 09:25 | |
| *** lpetrut has quit IRC | 09:25 | |
| *** ircuser-1 has quit IRC | 09:26 | |
| geguileo | I'm still convinced that it should work using an alias on the table r:-?? | 09:26 |
| *** ysm has quit IRC | 09:26 | |
| *** hemna_ has joined #openstack-cinder | 09:27 | |
| *** bapalm has quit IRC | 09:28 | |
| *** Nakato has quit IRC | 09:28 | |
| *** mvk has quit IRC | 09:28 | |
| *** mattymo has quit IRC | 09:28 | |
| *** subscope has quit IRC | 09:29 | |
| *** mattymo has joined #openstack-cinder | 09:29 | |
| *** mvk has joined #openstack-cinder | 09:29 | |
| *** Nakato has joined #openstack-cinder | 09:29 | |
| *** ankit_ag has quit IRC | 09:29 | |
| *** hemna has quit IRC | 09:29 | |
| *** bapalm has joined #openstack-cinder | 09:29 | |
| *** Julien-zte has quit IRC | 09:31 | |
| *** laughterwym has joined #openstack-cinder | 09:32 | |
| *** ysm has joined #openstack-cinder | 09:36 | |
| *** jordanP has joined #openstack-cinder | 09:36 | |
| *** laughterwym has quit IRC | 09:36 | |
| dulek | sborkows: Can you prepare a simple query that's affected by the issue and then try aliasing the table? | 09:36 |
| *** subscope has joined #openstack-cinder | 09:37 | |
| sborkows | dulek: I tried to do that thing, by aliasing the table which goes to filter condition. It still does not work | 09:38 |
| *** ysm has quit IRC | 09:38 | |
| sborkows | I used 'aliased' from sqlalchemy.orm | 09:39 |
| *** ysm has joined #openstack-cinder | 09:39 | |
| openstackgerrit | Ankit Agrawal proposed openstack/python-cinderclient: Add release notes for return-request-id-to-caller https://review.openstack.org/273930 | 09:41 |
| *** lpetrut has joined #openstack-cinder | 09:41 | |
| *** ysm has quit IRC | 09:41 | |
| sborkows | and a query was like: update volumes set ... where ... and exists(select * from volumes as volumes_1 where ...) | 09:42 |
| *** yuriy_n17 has joined #openstack-cinder | 09:46 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder-specs: Deleting volume metadata keys with a single request https://review.openstack.org/279202 | 09:46 |
| *** ysm has joined #openstack-cinder | 09:47 | |
| *** lpetrut has quit IRC | 09:48 | |
| geguileo | sborkows: When you say it didn't work you mean the tests failed or that it failed when running against postgresql or mysql? | 09:53 |
| sheel | dulek: hi | 09:53 |
| sheel | dulek:you there? | 09:53 |
| *** davechen has left #openstack-cinder | 09:54 | |
| sborkows | geguileo: I tested it on my devstack environment, by just issuing the cinder create command with specified volume id | 09:55 |
| geguileo | sborkows: Ok | 09:55 |
| sborkows | I will be in about 2 hours, we have a meeting now | 09:55 |
| geguileo | sborkows: Ok, ttyl | 09:56 |
| sheel | dulek:need your views on mysql utf8 character set update to utf8mb4 | 09:56 |
| *** shausy has quit IRC | 09:58 | |
| *** ysm has quit IRC | 09:58 | |
| *** e0ne has joined #openstack-cinder | 09:59 | |
| *** cheneydc has quit IRC | 10:00 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:01 | |
| *** sborkows_ has joined #openstack-cinder | 10:01 | |
| *** salv-orl_ has joined #openstack-cinder | 10:03 | |
| *** sborkows has quit IRC | 10:05 | |
| *** salv-orlando has quit IRC | 10:06 | |
| *** ysm has joined #openstack-cinder | 10:14 | |
| dulek | sheel: I have a meeting now, I'll be free in about an hour. | 10:14 |
| sheel | dulek:sure. | 10:14 |
| dulek | sheel: But that's 4-byte UTF stuff, right? | 10:14 |
| sheel | dulek:right | 10:14 |
| *** ysm has quit IRC | 10:15 | |
| *** ysm has joined #openstack-cinder | 10:18 | |
| *** ircuser-1 has joined #openstack-cinder | 10:19 | |
| *** ysm has quit IRC | 10:21 | |
| *** ysm has joined #openstack-cinder | 10:21 | |
| *** ysm has quit IRC | 10:23 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Fix service-list filter https://review.openstack.org/263257 | 10:24 |
| *** ysm has joined #openstack-cinder | 10:25 | |
| *** ysm has quit IRC | 10:29 | |
| *** lpetrut has joined #openstack-cinder | 10:30 | |
| *** marcusvrn_ has joined #openstack-cinder | 10:32 | |
| openstackgerrit | Edward Hope-Morley proposed openstack/cinder: Conditionally restore display_name https://review.openstack.org/278629 | 10:35 |
| *** alyson_ has joined #openstack-cinder | 10:38 | |
| *** baojg has quit IRC | 10:43 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API v1 and v2 to Python 3 https://review.openstack.org/277835 | 10:46 |
| *** sborkows_ has quit IRC | 10:46 | |
| *** tpsilva has joined #openstack-cinder | 10:49 | |
| *** sborkows_ has joined #openstack-cinder | 10:51 | |
| *** ndipanov has quit IRC | 10:55 | |
| *** chlong has quit IRC | 10:56 | |
| *** shyama has quit IRC | 10:56 | |
| *** shyama has joined #openstack-cinder | 10:57 | |
| *** sgotliv has quit IRC | 10:59 | |
| *** markvoelker has joined #openstack-cinder | 10:59 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port hgst driver to Python 3 https://review.openstack.org/280154 | 11:00 |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 11:01 | |
| *** subscope has quit IRC | 11:02 | |
| *** ndipanov has joined #openstack-cinder | 11:04 | |
| *** markvoelker has quit IRC | 11:04 | |
| dulek | sheel: Hi, so what's the problem with utf8mb4? | 11:04 |
| dulek | sheel: You probably have doubts how it fit into our online-schema-migrations policy? | 11:04 |
| sheel | dulek:yes, I wanted to discuss for this specifically | 11:05 |
| dulek | sheel: https://dev.mysql.com/doc/refman/5.6/en/innodb-create-index-overview.html | 11:06 |
| sheel | dulek: will altering table column structure and re indexing will create problem for this | 11:06 |
| *** adrianofr has joined #openstack-cinder | 11:06 | |
| dulek | sheel: According to that this is pretty serious change that copies the table… But it seems to allow concurrent queries, which is nice. | 11:06 |
| dulek | sheel: Do you have a patch where you propose these migrations? | 11:07 |
| sheel | dulek: I could see in first line that table copy will not be required - CREATE INDEX, ADD INDEXYes*No*YesYes | 11:07 |
| sheel | dulek: no, still in spec form | 11:08 |
| dulek | sheel: Oh, wait, this is not a "Convert character set"? | 11:08 |
| dulek | It's just creating an index? | 11:08 |
| sheel | dulek: oops, i missed | 11:08 |
| sheel | dulek: its both | 11:08 |
| *** shyama has quit IRC | 11:08 | |
| sheel | in convert character set we have to reindex as well | 11:09 |
| dulek | sheel: I think you're right. | 11:09 |
| *** shyama has joined #openstack-cinder | 11:09 | |
| dulek | And we probably want to affect all the "name" and "description" columns in volumes, snapshots, backups, etc.? | 11:09 |
| openstackgerrit | xiaoqin proposed openstack/cinder: Storwize/SVC: Clone volume between different volume size https://review.openstack.org/266743 | 11:10 |
| sheel | dulek: exactly | 11:10 |
| sheel | dulek: you got the crux | 11:10 |
| sheel | dulek: and this is to be discussed with all components as this would be the case with other componenets as well | 11:10 |
| sheel | dulek: so, this spec is specific to cross project repo | 11:11 |
| dulek | sheel: Other components here mean Nova? | 11:11 |
| sheel | dulek: yes, at least nova | 11:11 |
| sheel | dulek: and all other component as well where user can input 4 byte unicode | 11:11 |
| dulek | sheel: But that probably wouldn't affect Nova's DB, right? | 11:12 |
| dulek | sheel: They don't save cinder volumes names in Nova's DB, are they? | 11:13 |
| sheel | dulek: I am not sure why it will not effect nova!! | 11:13 |
| sheel | dulek: may be if they have already blocked usage of 4byte unicode..only then this will not affect | 11:13 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port hgst driver to Python 3 https://review.openstack.org/280154 | 11:13 |
| sheel | dulek: yes, nova dont store | 11:14 |
| dulek | :) | 11:14 |
| sheel | dulek: but they also can use 4byte for instance name | 11:14 |
| *** haypo has joined #openstack-cinder | 11:14 | |
| sheel | dulek: so, nova should be impacted | 11:14 |
| dulek | sheel: Ah, so this is more like cross-project thing to start supporting 4-byte unicode names? | 11:15 |
| sheel | dulek: yes, in this context, it is | 11:15 |
| sheel | dulek: so first concern for me in this implementation was upgrade support | 11:16 |
| sheel | dulek: so, I pinged you.. | 11:16 |
| sheel | :) | 11:16 |
| dulek | sheel: Our online-schema-migrations guidelines are built on Nova's. It's Nova who first decided what migrations are problematic for ops. | 11:16 |
| dulek | That means all the problem we will have - Nova will also have. | 11:16 |
| sheel | dulek: right | 11:16 |
| *** sgotliv has joined #openstack-cinder | 11:17 | |
| dulek | And Nova guys are far more experienced in that than me. | 11:17 |
| johnthetubaguy | there are guidelines not rules as such, what issues are you hitting with that? | 11:17 |
| dulek | Are you proposing that topic for a cross project meeting? It may be really interesting to discuss. | 11:17 |
| sheel | dulek: yes | 11:17 |
| sheel | dulek: by tomorrow, I will propose.. | 11:18 |
| dulek | johnthetubaguy: Ah, thanks for showing up! :) sheel is starting work on 4-byte unicode names support. | 11:18 |
| johnthetubaguy | some common patters between the projects would be good stuff | 11:18 |
| sheel | johnthetubaguy: hey thanks for joining in.. :) | 11:18 |
| dulek | johnthetubaguy: And the main problem is the MySQL DB, where a change of columns charset would be required - which is a migration prohibited by the Nova's (and Cinder) online-schema-upgrades policies. | 11:19 |
| johnthetubaguy | ah, yeah, it would be an online data migration for us | 11:19 |
| johnthetubaguy | using the objects framework | 11:19 |
| johnthetubaguy | add new column, move stuff across, etc | 11:20 |
| dulek | johnthetubaguy: Ah, right, you would be able to implement that in one release. In Cinder it's at least 2 (we have no atomic update of all the conductors). | 11:20 |
| johnthetubaguy | we don't have an atomic update, we report the versions of services that are running, and only move data when required | 11:21 |
| johnthetubaguy | we wait for the min_version to be high enough to allow the migration, roughly | 11:22 |
| sheel | johnthetubaguy: ok | 11:23 |
| dulek | johnthetubaguy: Whoa, I wasn't aware of that. Any chance of pointing me to some code or any resources on that "conditional" migrations? | 11:23 |
| johnthetubaguy | let me find that | 11:23 |
| sheel | johnthetubaguy: So, as stated by dulek, actually we were discussing about upgrade support... whether converting utf8 to utf8mb will create any problem in online migration or not.. | 11:23 |
| johnthetubaguy | it is new | 11:23 |
| dulek | sheel: I think you should discuss it on a cross-project-meeting. I'll make sure to be there. If this will have positive feedback I'll work to provide online-schema-migration scheme that will allow us to implement this as soon as it's possible. | 11:24 |
| johnthetubaguy | sheel: depends if the database can do that live or not, it seems like that might requite a lock, but I am unsure | 11:24 |
| dulek | johnthetubaguy: It certainly will require a lock. | 11:24 |
| johnthetubaguy | dulek: right, thats a big no then | 11:24 |
| dulek | sheel: I also need to think a little on how make that migration in a smart way. | 11:25 |
| johnthetubaguy | need a new colum and a move | 11:25 |
| *** alonma has quit IRC | 11:25 | |
| *** alonma has joined #openstack-cinder | 11:25 | |
| johnthetubaguy | so this is the key bit: | 11:26 |
| johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/objects/pci_device.py#L122 | 11:26 |
| dulek | johnthetubaguy: Sure, in Cinder it's a more complicated process streching through multiple releases, but maybe these "conditional" migrations will somehow help us to shrink this time. | 11:26 |
| johnthetubaguy | we use our service group to report a service version | 11:26 |
| johnthetubaguy | we expand and move in the same release, generally | 11:26 |
| johnthetubaguy | I think its the service version stuff that changes that | 11:26 |
| dulek | johnthetubaguy: Sure, we report it there too. | 11:26 |
| johnthetubaguy | so if you check the min_version, and update that on SIG_UP, we can wait until things are in "new enough" that we can move the data | 11:27 |
| johnthetubaguy | the computes can be old while we move the data, because we proxy all the DB through the conductor, but API and conductor have to be new before we do the data move | 11:27 |
| johnthetubaguy | I think that is correct | 11:27 |
| dulek | johnthetubaguy: Cool. This expands our sets of tool - I've never thought of doing it that way. Thanks! | 11:28 |
| johnthetubaguy | no worries | 11:28 |
| * johnthetubaguy starts paying more attention at the operator meetup now its got going again | 11:29 | |
| dulek | johnthetubaguy: Have fun, thanks again! | 11:29 |
| dulek | sheel: I believe next CP meeting is tomorrow, am I right? | 11:30 |
| johnthetubaguy | its tuesday if its on | 11:30 |
| *** subscope has joined #openstack-cinder | 11:30 | |
| sheel | dulek: :) | 11:30 |
| *** alonma has quit IRC | 11:30 | |
| sheel | dulek: as stated by johnthetubaguy | 11:31 |
| sheel | dulek: so, how we see it for cinder? | 11:31 |
| dulek | sheel: So I'll make sure to be there if you propose this topic for the agenda. Meanwhile I'll look how we would be able to make such DB migration in Cinder safely. | 11:31 |
| *** alonma has joined #openstack-cinder | 11:31 | |
| sheel | dulek: ok, sure | 11:32 |
| dulek | sheel: As I think now it would take two releases, but maybe I'll be able to find a way to shrink it safely. | 11:32 |
| *** zhonghua-lee has quit IRC | 11:32 | |
| sheel | dulek: but will it be possible on cinder end ...means from perspective of current upgrade support? | 11:32 |
| sheel | dulek: Ok, got your point | 11:32 |
| *** zhonghua-lee has joined #openstack-cinder | 11:32 | |
| dulek | sheel: This probably won't get merged in M (two weeks left!), so 2 means we have 4-byte UTF working in O. | 11:33 |
| sheel | dulek: right | 11:33 |
| dulek | sheel: Still - I need to confirm that - this stuff John showed may simplify things for us. :) | 11:33 |
| *** ildikov_ has quit IRC | 11:34 | |
| sheel | dulek: right. So, I think first we should clear it from cinder end, and then can discuss in cross project | 11:34 |
| sheel | dulek: what you say? | 11:34 |
| sheel | dulek: I am ok with tomorrow as well | 11:34 |
| *** ociuhandu has quit IRC | 11:35 | |
| dulek | sheel: Oh, I think the discussion can start in parallel - if it receives positive feedback and cross-project spec is merged, then we will have no choice other than implementing it. :) | 11:35 |
| sheel | dulek: ohk, sure | 11:36 |
| sheel | dulek: so, will propose this in tomorrow's meeting | 11:36 |
| dulek | sheel: And come on - it can't be that our rolling upgrades guidelines will block some work indefinitely. | 11:36 |
| sheel | dulek: hmm...right | 11:36 |
| *** alonma has quit IRC | 11:36 | |
| sheel | dulek: so, lets do it..catch you tomorrow.. | 11:36 |
| dulek | sheel: If it won't be enteirely possible to implement something because of the guidelines, then the guidelines are wrong. | 11:37 |
| dulek | Sure! :) | 11:37 |
| sheel | dulek: yupp | 11:37 |
| sheel | dulek: thanks for your time... | 11:38 |
| *** alonma has joined #openstack-cinder | 11:38 | |
| dulek | sheel: No problem. :) | 11:38 |
| sheel | dulek: :) | 11:38 |
| *** nkrinner has quit IRC | 11:39 | |
| sheel | dulek: It seems meeting is not scheduled for tomorrow https://wiki.openstack.org/wiki/Meetings/CrossProjectMeeting | 11:40 |
| sheel | dulek: Next meeting Date: 2/9/16 | 11:40 |
| dulek | sheel: 2/9/16 means last week? It's either nothing on agenda yet or meeting is canceled. | 11:41 |
| dulek | sheel: Let me look through mailing list. | 11:42 |
| *** alonma has quit IRC | 11:42 | |
| sheel | dulek: oh great... | 11:42 |
| sheel | dulek: if need any help from my side, please let me know... | 11:42 |
| *** alonma has joined #openstack-cinder | 11:44 | |
| dulek | sheel: I see no post on openstack-dev about cancellation, so you're probably free to move 2/9 to previous meetings and add a new with your item. | 11:44 |
| dulek | thingee: ^ (if you're here maybe you'll help us?) | 11:44 |
| sheel | dulek: I think its quite early(3:46 AM) for thingee for now.. | 11:46 |
| *** alonma has quit IRC | 11:48 | |
| *** alonma has joined #openstack-cinder | 11:50 | |
| *** alonma has quit IRC | 11:54 | |
| *** sheel has left #openstack-cinder | 11:56 | |
| *** alonma has joined #openstack-cinder | 11:56 | |
| *** sheel has joined #openstack-cinder | 11:57 | |
| thingee | sheel, dulek I'm around, in manchester for the ops meetup | 12:00 |
| *** haomaiwa_ has quit IRC | 12:01 | |
| *** alonma has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-cinder | 12:01 | |
| *** alonma has joined #openstack-cinder | 12:02 | |
| * thingee updates the cross-project meeting agenda | 12:02 | |
| dulek | thingee: Thanks! :) | 12:05 |
| *** ociuhandu has joined #openstack-cinder | 12:06 | |
| *** alonma has quit IRC | 12:06 | |
| *** alonma has joined #openstack-cinder | 12:08 | |
| sheel | thingee: thanks | 12:09 |
| openstackgerrit | xiaoqin proposed openstack/cinder: Storwize/SVC: Clone between different size volumes https://review.openstack.org/266743 | 12:11 |
| *** ildikov_ has joined #openstack-cinder | 12:11 | |
| *** alonma has quit IRC | 12:13 | |
| *** alonma has joined #openstack-cinder | 12:14 | |
| *** laughterwym has joined #openstack-cinder | 12:15 | |
| *** raildo-afk is now known as raildo | 12:17 | |
| *** raildo is now known as raildo-afk | 12:18 | |
| *** raildo-afk is now known as raildo | 12:18 | |
| sheel | dulek: agenda added in cross project | 12:19 |
| *** alonma has quit IRC | 12:19 | |
| sheel | dulek: will update with spec link if able to write till tomorrow.. | 12:19 |
| *** chlong has joined #openstack-cinder | 12:20 | |
| *** alonma has joined #openstack-cinder | 12:21 | |
| sheel | dulek: but it will be quite odd time for you as well as me... 2100 UTC... :) | 12:24 |
| *** alonma has quit IRC | 12:25 | |
| dulek | sheel: Yeah, it is… Not that bad for me - I have trouble sleeping since my return from the mid-cycle. ;) | 12:27 |
| * dulek is always strongly affected by jet lag. | 12:27 | |
| sheel | dulek: hehehe....I will be having after this meeting... 2:30 AM | 12:27 |
| sheel | dulek: :) | 12:27 |
| *** openstackgerrit_ has joined #openstack-cinder | 12:28 | |
| *** alonma has joined #openstack-cinder | 12:28 | |
| *** markvoelker has joined #openstack-cinder | 12:29 | |
| *** alonma has quit IRC | 12:33 | |
| *** markvoelker has quit IRC | 12:34 | |
| *** chhavi has joined #openstack-cinder | 12:34 | |
| *** alonma has joined #openstack-cinder | 12:34 | |
| *** coolsvap is now known as coolsvap|away | 12:36 | |
| *** marcusvrn_ has quit IRC | 12:37 | |
| *** alonma has quit IRC | 12:39 | |
| *** alonma has joined #openstack-cinder | 12:41 | |
| *** sborkows_ has quit IRC | 12:41 | |
| *** sborkows_ has joined #openstack-cinder | 12:41 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder-specs: Deleting volume metadata keys with a single request https://review.openstack.org/279202 | 12:42 |
| *** dims_ has joined #openstack-cinder | 12:42 | |
| *** alonma has quit IRC | 12:45 | |
| *** alonma has joined #openstack-cinder | 12:47 | |
| *** alonma has quit IRC | 12:51 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/cinder: Fix service-list filter https://review.openstack.org/263257 | 12:53 |
| *** alonma has joined #openstack-cinder | 12:53 | |
| *** cdelatte has quit IRC | 12:53 | |
| *** alonma has quit IRC | 12:54 | |
| *** alonma has joined #openstack-cinder | 12:54 | |
| *** sborkows_ has quit IRC | 12:54 | |
| *** sborkows_ has joined #openstack-cinder | 12:55 | |
| *** haomaiwang has quit IRC | 13:01 | |
| *** 14WAAFARW has joined #openstack-cinder | 13:01 | |
| *** salv-orl_ has quit IRC | 13:04 | |
| *** sb has quit IRC | 13:06 | |
| *** abhishekk has quit IRC | 13:06 | |
| *** sb has joined #openstack-cinder | 13:08 | |
| *** subscope has quit IRC | 13:10 | |
| *** cdelatte has joined #openstack-cinder | 13:11 | |
| *** JoseMello has joined #openstack-cinder | 13:13 | |
| *** dave-mccowan has joined #openstack-cinder | 13:14 | |
| *** dustins has joined #openstack-cinder | 13:16 | |
| *** subscope has joined #openstack-cinder | 13:17 | |
| *** shakamunyi has quit IRC | 13:20 | |
| *** 14WAAFARW has quit IRC | 13:21 | |
| *** jkraj has joined #openstack-cinder | 13:23 | |
| *** Julien-zte has joined #openstack-cinder | 13:24 | |
| *** porrua has joined #openstack-cinder | 13:30 | |
| *** markvoelker has joined #openstack-cinder | 13:30 | |
| *** edmondsw has joined #openstack-cinder | 13:31 | |
| *** porrua has quit IRC | 13:31 | |
| *** dims_ has quit IRC | 13:33 | |
| *** dims has joined #openstack-cinder | 13:33 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix test_blockbridge to support hash randomization https://review.openstack.org/280224 | 13:35 |
| *** markvoelker has quit IRC | 13:35 | |
| *** salv-orlando has joined #openstack-cinder | 13:40 | |
| *** jiangliucheng has joined #openstack-cinder | 13:42 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port test_emc_vnx to Python 3 https://review.openstack.org/280241 | 13:51 |
| *** dims has quit IRC | 13:53 | |
| *** marcusvrn_ has joined #openstack-cinder | 13:54 | |
| *** porrua has joined #openstack-cinder | 13:56 | |
| *** haomaiwang has joined #openstack-cinder | 13:57 | |
| *** dims has joined #openstack-cinder | 13:57 | |
| *** porrua has quit IRC | 13:57 | |
| *** delattec has joined #openstack-cinder | 13:58 | |
| *** fthiagogv has joined #openstack-cinder | 14:00 | |
| *** dims has quit IRC | 14:00 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** rlrossit has joined #openstack-cinder | 14:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 14:01 | |
| *** cdelatte has quit IRC | 14:01 | |
| *** vgridnev has quit IRC | 14:02 | |
| *** dims has joined #openstack-cinder | 14:02 | |
| *** vgridnev has joined #openstack-cinder | 14:06 | |
| *** Poornima has quit IRC | 14:07 | |
| *** jgregor has joined #openstack-cinder | 14:08 | |
| *** jungleboyj has quit IRC | 14:16 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API contribs to Python 3 https://review.openstack.org/277861 | 14:17 |
| haypo | geguileo, ^^ patch updated for tests-py3.txt (now "cinder.tests.unit.api.contrib" is tested) | 14:17 |
| geguileo | haypo: Thanks! | 14:18 |
| haypo | geguileo: FYI i ran *all* unit tests on py3 with all my pending patches, and very few tests still fail (less than 10) | 14:18 |
| geguileo | haypo: Wow!!! That's great!! | 14:18 |
| haypo | i see the light at the end of the tunnel... | 14:18 |
| geguileo | haypo: Indeed, only 10 remaining!!! Congrats! | 14:19 |
| dulek | haypo: Had you tried running tempest on Cinder running with Python 3? | 14:19 |
| haypo | dulek: i'm making baby steps :) one by one | 14:19 |
| haypo | dulek: running tempest is too scary for me :-D | 14:20 |
| dulek | haypo: :D | 14:20 |
| haypo | dulek: (i expect huge traceback when running tempest) | 14:20 |
| haypo | fixing unit tests is a major milestone, but you're right that it's not enough | 14:20 |
| dulek | haypo: That's why I've wondered. :) I'm really curious what the end-result will be. | 14:20 |
| haypo | i finished to port horizon & glance (with the help of cyril for glance) | 14:20 |
| *** JoseMello_ has joined #openstack-cinder | 14:21 | |
| haypo | dulek: the next step is to fix devstack to be able to install services on py3, to be able to run tempest on gates with services running on top of py3 | 14:21 |
| *** mtanino has joined #openstack-cinder | 14:21 | |
| haypo | dulek: there is an approved spec for that, but i don't know that status of the patch | 14:21 |
| *** marcusvrn__ has joined #openstack-cinder | 14:21 | |
| dulek | haypo: Sure, this sound logical. | 14:22 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port API v1 and v2 to Python 3 https://review.openstack.org/277835 | 14:22 |
| haypo | geguileo: ditto for this patch (tests-py3.txt fixed) ^^ | 14:22 |
| geguileo | haypo: Thanks | 14:23 |
| *** spring_ has joined #openstack-cinder | 14:23 | |
| geguileo | haypo: I know you prefered being explicit about the tests, so thanks for changing it | 14:23 |
| haypo | geguileo: don't worry, in a few days, we will be able to drop tests-py3.txt ;) | 14:23 |
| *** liverpoo1er has joined #openstack-cinder | 14:24 | |
| *** edmondsw_ has joined #openstack-cinder | 14:24 | |
| *** marcusvrn_ has quit IRC | 14:24 | |
| *** edmondsw has quit IRC | 14:24 | |
| *** dave-mccowan has quit IRC | 14:24 | |
| *** JoseMello has quit IRC | 14:24 | |
| *** ndipanov has quit IRC | 14:24 | |
| *** liverpooler has quit IRC | 14:24 | |
| *** guest_monitor has quit IRC | 14:24 | |
| *** marcusvrn__ is now known as marcusvrn_ | 14:24 | |
| *** dave-mccowan has joined #openstack-cinder | 14:24 | |
| *** JoseMello_ is now known as JoseMello | 14:25 | |
| *** edtubill has joined #openstack-cinder | 14:26 | |
| *** salv-orlando has quit IRC | 14:27 | |
| *** dims has quit IRC | 14:28 | |
| *** mriedem has joined #openstack-cinder | 14:30 | |
| smcginnis | haypo: Awesome progress! | 14:31 |
| *** ociuhandu has quit IRC | 14:32 | |
| * haypo hugs the whole IRC channel | 14:32 | |
| smcginnis | :) | 14:32 |
| *** diablo_rojo has joined #openstack-cinder | 14:35 | |
| *** ndipanov has joined #openstack-cinder | 14:35 | |
| *** dims has joined #openstack-cinder | 14:36 | |
| *** diablo_rojo has left #openstack-cinder | 14:37 | |
| sheel | :) | 14:39 |
| openstackgerrit | Merged openstack/python-cinderclient: Fix link for OpenStack manual https://review.openstack.org/268690 | 14:41 |
| scottda | e0ne: I put a hack in the microversion patches and now apache is passing: https://review.openstack.org/#/c/224910/ | 14:44 |
| e0ne | scottda: hi, thanks! | 14:44 |
| scottda | thanks for all your help. That patch set ^^^ is ripe for reviewing smcginnis DuncanT dulek geguileo | 14:45 |
| smcginnis | scottda: Excellent! | 14:45 |
| *** superdan is now known as dansmith | 14:46 | |
| scottda | haypo: I had to put a hack in to deal with encoding differences b/w 2.7 and 3.4 . Perhaps you know a better way? https://review.openstack.org/#/c/224910/27..28/cinder/api/openstack/wsgi.py | 14:47 |
| sheel | smcginnis: hi there | 14:47 |
| smcginnis | sheel: Hey | 14:47 |
| sheel | smcginnis: this is regarding openstack client | 14:47 |
| sheel | smcginnis: are we planning to support all commands of cinder in openstack client in some specific release | 14:47 |
| sheel | smcginnis: or its open? | 14:48 |
| smcginnis | sheel: Right now it's open. | 14:48 |
| smcginnis | sheel: I haven't gone through to identify what is missing yet. | 14:48 |
| smcginnis | sheel: I do think we would want to support all commands. | 14:48 |
| sheel | smcginnis: Actually I have found many many commands which still needs to incorporated in openstack client | 14:48 |
| sheel | smcginnis: refer https://blueprints.launchpad.net/python-openstackclient/+spec/cinder-command-support for details | 14:48 |
| smcginnis | sheel: The overall direction was that individual projects should deprecate their CLIs in favor or osc. | 14:49 |
| sheel | smcginnis: So, I am planning to support all these command, i think around 15 in osc | 14:49 |
| smcginnis | sheel: If we are going to actually get rid of our CLI (which I still have some doubts about) then we would need everything implemented in osc. | 14:49 |
| sheel | smcginnis: yes, that is why i raised BP for it https://blueprints.launchpad.net/python-openstackclient/+spec/cinder-command-support | 14:49 |
| sheel | smcginnis: will work for it now | 14:49 |
| smcginnis | sheel: Ah, thanks. I hadn't noticed that one yet. | 14:49 |
| *** amoturi has joined #openstack-cinder | 14:50 | |
| sheel | smcginnis: hope osc for cinder comes under you..is it? | 14:50 |
| smcginnis | sheel: Might want to check in with DuncanT quick. I think he was going to look in to a possible way to automagically impport CLI commands. | 14:50 |
| amoturi | hemna_: Hi could you take a look at https://review.openstack.org/#/c/238635/ | 14:50 |
| *** eharney has joined #openstack-cinder | 14:50 | |
| smcginnis | sheel: No, that's a separate project with a different set of cores. | 14:50 |
| sheel | smcginnis: ohkk... | 14:51 |
| smcginnis | sheel: Which is part of the concern. We would be losing some control if we deprecated our CLI. | 14:51 |
| *** haomaiwa_ has quit IRC | 14:51 | |
| sheel | smcginnis: haha.. | 14:51 |
| sheel | smcginnis: no, we will send some of our members to be core over there | 14:52 |
| smcginnis | ;) | 14:52 |
| sheel | smcginnis: still control is ours :) | 14:52 |
| *** delattec has quit IRC | 14:52 | |
| smcginnis | sheel: I don't mind giving up control so much as risking adding delays to get things done. | 14:52 |
| sheel | smcginnis: yes, jk.. | 14:53 |
| smcginnis | sheel: Yep. :) | 14:53 |
| flip214 | for cinder driver configuration items -- if an item is not mentioned in the cinder.conf, should the driver receive the "default=" value? | 14:53 |
| sheel | smcginnis: Should i discuss with DuncanT ..if he has any idea of automatically merging CLIs..that will ease my work... | 14:53 |
| smcginnis | flip214: Correct. | 14:54 |
| smcginnis | sheel: Yeah, definitely. | 14:54 |
| smcginnis | sheel: Not sure if it can work, but if it could it would be a huge time saver. | 14:54 |
| sheel | smcginnis: thats ok.... | 14:54 |
| flip214 | smcginnis: yeah, a print() says that, too... but why can't JSON parse that? | 14:54 |
| DuncanT | sheel: I've not had time to look yet, but it is definitely something we should propose - it's far more sane than having a third project in the way of completing a feature | 14:55 |
| sheel | smcginnis: thanks for giving direction... | 14:55 |
| sheel | DuncanT: do we have some way to automatically merge CLIs to ops? | 14:55 |
| sheel | DuncanT: else i will start working on it ... | 14:55 |
| smcginnis | flip214: Hmm, not sure. Doesn't seem right. | 14:55 |
| sheel | DuncanT: your suggestion will be much helpful if something is there | 14:56 |
| smcginnis | DuncanT: The naming conflict is the only risk I see. | 14:56 |
| smcginnis | DuncanT: But if we could have a decorator, something like @osc_command("volume-list") on our "list" command, could be a simple way to use different names. | 14:56 |
| DuncanT | smcginnis: Yup, something like that. Should be solvable. | 14:57 |
| sheel | DuncanT: smcginnis: may we discuss the approach later in this week..? | 14:59 |
| *** dims has quit IRC | 14:59 | |
| sheel | DuncanT: smcginnis: or should I keep it part of cinder meeting? | 14:59 |
| smcginnis | sheel: Sure. I'd love to see a simple solution to that, if at all possible. | 14:59 |
| smcginnis | sheel: Maybe spend a little time looking in to it. | 15:00 |
| DuncanT | sheel: Probably worth looking at and coming up with something that works, then we can discuss | 15:00 |
| smcginnis | sheel: Then if there are any design considerations we can discuss in the meeting. | 15:00 |
| sheel | smcginnis: DuncanT : yes sure.. | 15:00 |
| smcginnis | sheel: Thanks! | 15:00 |
| sheel | smcginnis: DuncanT: Thank you.. | 15:01 |
| flip214 | brrr, " vs. ' for the json keys and values. | 15:01 |
| *** akerr has joined #openstack-cinder | 15:01 | |
| openstackgerrit | Merged openstack/python-cinderclient: Update HACKING with current information https://review.openstack.org/265594 | 15:02 |
| DuncanT | flip214: If I had a shekel for every time I'd done that... | 15:02 |
| DuncanT | flip214: I could afford a good coffee at least | 15:02 |
| openstackgerrit | Gage Hugo proposed openstack/cinder: Removed duplicated code in VNX cinder driver https://review.openstack.org/279782 | 15:02 |
| flip214 | DuncanT: thanks, so it's not just me. baaah, too many programming languages, and each one a little bit different... | 15:03 |
| *** baojg has joined #openstack-cinder | 15:04 | |
| *** baumann has joined #openstack-cinder | 15:05 | |
| *** Julien-zte has quit IRC | 15:06 | |
| openstackgerrit | Merged openstack/python-cinderclient: Code is hosted on git.openstack.org https://review.openstack.org/268691 | 15:06 |
| openstackgerrit | Merged openstack/python-cinderclient: Removes MANIFEST.in as it is not needed explicitely by PBR https://review.openstack.org/258408 | 15:06 |
| *** baojg has quit IRC | 15:09 | |
| *** diablo_rojo has joined #openstack-cinder | 15:09 | |
| *** dims has joined #openstack-cinder | 15:10 | |
| *** jkraj has quit IRC | 15:13 | |
| *** knomura has joined #openstack-cinder | 15:15 | |
| *** pots has quit IRC | 15:22 | |
| *** julim has joined #openstack-cinder | 15:25 | |
| *** zhangjn has quit IRC | 15:25 | |
| *** PsionTheory has joined #openstack-cinder | 15:26 | |
| *** zhangjn has joined #openstack-cinder | 15:26 | |
| *** akerr is now known as akerr_away | 15:26 | |
| *** jdurgin1 has joined #openstack-cinder | 15:27 | |
| *** subscope has quit IRC | 15:30 | |
| *** adrianofr has quit IRC | 15:31 | |
| *** alyson_ has quit IRC | 15:34 | |
| *** jungleboyj has joined #openstack-cinder | 15:34 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port hgst driver to Python 3 https://review.openstack.org/280154 | 15:34 |
| *** adrianofr has joined #openstack-cinder | 15:37 | |
| *** alyson_ has joined #openstack-cinder | 15:37 | |
| *** pots has joined #openstack-cinder | 15:38 | |
| knomura | smcginnis: Hi, Are you there? I have a question about this patch. (https://review.openstack.org/#/c/271763/) | 15:41 |
| *** subscope has joined #openstack-cinder | 15:41 | |
| smcginnis | knomura: Hey, back now. | 15:43 |
| smcginnis | looking | 15:43 |
| *** akerr_away is now known as akerr | 15:43 | |
| sheel | DuncanT: e0ne: Hi, Could you please review https://review.openstack.org/#/c/273938/ | 15:43 |
| smcginnis | knomura: Oh, OK. I remember now. | 15:44 |
| sheel | DuncanT: e0ne : comments have been incorporated as per previous review comments.. | 15:44 |
| *** eharney has quit IRC | 15:44 | |
| knomura | smcginnis: Thank you. As you know, this patch has a lot of code changes. So It is difficult to review it. I thought how to break a large patch into the smaller patches. | 15:44 |
| smcginnis | knomura: That would be good if you could. | 15:45 |
| *** kvidvans has joined #openstack-cinder | 15:45 | |
| smcginnis | knomura: You'll have a much better chance of it getting through in a more timely matter. | 15:45 |
| smcginnis | knomura: I've spent some time reviewing it, but I still have a ways to go. | 15:45 |
| *** liverpoo1er has quit IRC | 15:46 | |
| kvidvans | Hi Cinder core...looking for +2 on https://review.openstack.org/#/c/263766/6 . Both Oracle CI's have reported success..its a few lines change and wont take much time. promise :) | 15:48 |
| knomura | smcginnis: My current idea is breaking this patch to $B!H(Bcommon code$B!I(B patch and $B!H(Bdriver code$B!I(B patches. But if we update $B!H(Bcommon code$B!I(B at first, this will break the existing driver and whole unit tests. So I$B!G(Bm thinking these two options. | 15:49 |
| *** sborkows_ has quit IRC | 15:49 | |
| *** asselin_ has joined #openstack-cinder | 15:50 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 https://review.openstack.org/275797 | 15:50 |
| knomura | smcginnis: sorry. I mistake. this sentence have wrong word. | 15:51 |
| *** mylu has joined #openstack-cinder | 15:52 | |
| knomura | smcginnis: My current idea is breaking this patch to "common code" patch and "driver code" patches. But if we update "common code" at first, this will break the existing driver and whole unit tests. So I'm thinking these two options. | 15:53 |
| smcginnis | knomura: I wouldn't think it should. If you are keeping the same functionality but moving it into a common location, it really should just be moving code from one (or more) files to a single common place. | 15:54 |
| smcginnis | knomura: That shouldn't break your functionality. | 15:54 |
| smcginnis | knomura: That's actually something that surprised me about this patch. | 15:54 |
| smcginnis | knomura: One of the stated goals is to have common functionality, but the lines of code actually increase rather than decrease with the patch. | 15:55 |
| mtanino | smcginnis: oops, The "common code patch" means patch for our "hitachi/hbsd/hbsd_common.py". | 15:56 |
| mtanino | smcginnis: sorry for confusion. | 15:56 |
| *** daneyon_ has quit IRC | 15:56 | |
| smcginnis | mtanino: Isn't part of that moving common functionality out of the drivers and into common? | 15:56 |
| mtanino | smcginnis: No. | 15:56 |
| knomura | mtanino: Thank you for helping. | 15:56 |
| *** daneyon has joined #openstack-cinder | 15:56 | |
| smcginnis | mtanino: I'm really confused then. You may want to check the definition of refactoring. That might not be the correct word to use for this. | 15:57 |
| smcginnis | If the code is being refactored to improve maintainability, I would expect the lines of code count to go down, not up. | 15:58 |
| *** baumann has quit IRC | 15:58 | |
| *** daneyon has quit IRC | 15:59 | |
| *** eharney has joined #openstack-cinder | 15:59 | |
| *** daneyon has joined #openstack-cinder | 16:00 | |
| *** shyama has quit IRC | 16:00 | |
| *** krtaylor has quit IRC | 16:01 | |
| *** shyama has joined #openstack-cinder | 16:01 | |
| mtanino | smcginnis: Sorry, common is not appropriate key word. | 16:01 |
| *** jungleboyj has quit IRC | 16:01 | |
| *** jungleboyj has joined #openstack-cinder | 16:02 | |
| *** daneyon_ has joined #openstack-cinder | 16:04 | |
| *** arch-nemesis has joined #openstack-cinder | 16:06 | |
| *** daneyon has quit IRC | 16:07 | |
| *** mylu has quit IRC | 16:08 | |
| mtanino | smcginnis: So our driver is basically consisted "hbsd_common.py" + hbsd driver.py. Current proposd patch includes fixed both of them. | 16:09 |
| mtanino | smcginnis: and knomura is tring to divide the patch to patch for "hbsd_common.py" and patch for hbsd driver.py. | 16:10 |
| *** ociuhandu has joined #openstack-cinder | 16:12 | |
| *** ociuhandu has quit IRC | 16:13 | |
| knomura | smcginnis mtanino: That's right. I'm sorry for confusing you. | 16:13 |
| *** krtaylor has joined #openstack-cinder | 16:15 | |
| mtanino | smcginnis: knomura One problem is when we'll post a patch for "hbsd_common.py" at first, this will break existing driver's unit tests. So we are thinking what should we do to break the patch. | 16:15 |
| smcginnis | mtanino, knomura: Tests will definitely need to be updated along with the code. | 16:15 |
| *** chhavi has quit IRC | 16:15 | |
| smcginnis | mtanino, knomura: But I'm still really confused. I have no idea what you're trying to accomplish. | 16:16 |
| smcginnis | mtanino, knomura: And there is so much code churn here I can't readily tell. | 16:16 |
| *** akerr is now known as akerr_away | 16:16 | |
| *** ociuhandu has joined #openstack-cinder | 16:17 | |
| *** vgridnev has quit IRC | 16:17 | |
| jgriffith | dulek: ping | 16:19 |
| Swanson | Every time I see "dulek" I think it is some kind of conjoined dalek. My brain doesn't work right. | 16:20 |
| diablo_rojo | Swanson: +1 Same.. | 16:23 |
| smcginnis | He's exterminating rolling upgrade issues. | 16:23 |
| diablo_rojo | smcginnis: EXTERMINATE!! EXTERMINATE!! EXTERMINATE!! | 16:24 |
| jungleboyj | diablo_rojo: FYI, new oslo.config release coming this week with fix for config option ordering. | 16:24 |
| diablo_rojo | smcginnis: Though upgrading is more of a cyberman thing | 16:24 |
| diablo_rojo | jungleboyj: Cool. Good to know. Thanks! | 16:24 |
| smcginnis | diablo_rojo: Hah, true. | 16:24 |
| jungleboyj | diablo_rojo: Welcome. | 16:25 |
| jungleboyj | DELETE!! | 16:25 |
| diablo_rojo | jungleboyj: smcginnis We are a bunch of nerds :) | 16:25 |
| jungleboyj | diablo_rojo: Yep. And I think we are proud of it. | 16:26 |
| *** mrrowden has joined #openstack-cinder | 16:26 | |
| diablo_rojo | jungleboyj: Too true. | 16:27 |
| jungleboyj | diablo_rojo: It is your fault I am a Dr. Who nerd. | 16:28 |
| *** sgotliv has quit IRC | 16:28 | |
| sheel | diablo_rojo: hi | 16:30 |
| diablo_rojo | sheel: Hello :) | 16:30 |
| *** shyama has quit IRC | 16:30 | |
| sheel | diablo_rojo: regarding unicode support in mysql | 16:30 |
| diablo_rojo | sheel: Sure, what's up? | 16:31 |
| sheel | diablo_rojo: I have set meeting agenda for cross project | 16:31 |
| sheel | https://wiki.openstack.org/wiki/Meetings/CrossProjectMeeting | 16:31 |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 https://review.openstack.org/275797 | 16:31 |
| sheel | diablo_rojo: lets discuss same tomorrow | 16:31 |
| diablo_rojo | sheel: Yeah Jacob told me about it. Sounds good :) | 16:31 |
| diablo_rojo | sheel: I'll be there :) | 16:32 |
| *** chhavi has joined #openstack-cinder | 16:32 | |
| sheel | diablo_rojo: ohk, seems office mates | 16:32 |
| diablo_rojo | sheel: Yeah we are :) | 16:32 |
| sheel | :) | 16:32 |
| sheel | diablo_rojo: ok, so catch u guys tomorrow in meeting | 16:33 |
| diablo_rojo | sheel: yep! | 16:33 |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Migration: take the direct path for the source volume https://review.openstack.org/250220 | 16:35 |
| *** vincent_hou has joined #openstack-cinder | 16:36 | |
| vincent_hou | geguileo: eharney: https://review.openstack.org/#/c/250220/. I have submitted a one patch set. | 16:37 |
| *** arch-nemesis has quit IRC | 16:38 | |
| *** mrrowden has quit IRC | 16:39 | |
| *** mylu has joined #openstack-cinder | 16:39 | |
| *** eharney has quit IRC | 16:39 | |
| *** arch-nemesis has joined #openstack-cinder | 16:41 | |
| *** PsionTheory has quit IRC | 16:41 | |
| *** subscope has quit IRC | 16:42 | |
| openstackgerrit | Merged openstack/cinder: Fix 'asert' typo in unit test https://review.openstack.org/279666 | 16:42 |
| *** alonma has quit IRC | 16:45 | |
| mtanino | smcginnis: Thank you. We will discuss internally again. | 16:45 |
| *** rajinir has joined #openstack-cinder | 16:46 | |
| *** subscope has joined #openstack-cinder | 16:46 | |
| *** rajinir has quit IRC | 16:47 | |
| *** rajinir has joined #openstack-cinder | 16:47 | |
| *** rcernin has quit IRC | 16:48 | |
| knomura | smcginnis: Thank you. | 16:48 |
| *** arecknag has quit IRC | 16:50 | |
| *** cdelatte has joined #openstack-cinder | 16:50 | |
| *** alonma has joined #openstack-cinder | 16:52 | |
| jungleboyj | smcginnis: Am I being a jerk or does this seems a little scary for backport? | 16:52 |
| jungleboyj | https://review.openstack.org/#/c/280297/ | 16:52 |
| *** ByPasS has quit IRC | 16:52 | |
| *** ByPasS has joined #openstack-cinder | 16:54 | |
| *** mylu has quit IRC | 16:54 | |
| *** mylu has joined #openstack-cinder | 16:54 | |
| *** gouthamr has joined #openstack-cinder | 16:55 | |
| *** kvidvans has quit IRC | 16:55 | |
| *** jwcroppe has joined #openstack-cinder | 16:56 | |
| *** alonma has quit IRC | 16:56 | |
| e0ne | jungleboyj: is it covered by tempest tests? | 16:57 |
| jungleboyj | e0ne: Not sure. | 16:57 |
| *** alonma has joined #openstack-cinder | 16:58 | |
| e0ne | jungleboyj: I'm OK with a patch itself. I'm worried only about will it affect existing deployments? | 16:58 |
| e0ne | jungleboyj: unfortunately, I don't see unit-tests which revify the fix | 16:59 |
| jungleboyj | e0ne: Right, concerned that it will change the behavior of existing installations. | 17:00 |
| *** jwcroppe_ has joined #openstack-cinder | 17:00 | |
| openstackgerrit | Merged openstack/cinder: Updated from global requirements https://review.openstack.org/279759 | 17:00 |
| mc_nair | e0ne: my understanding is that the only affect it would have for existing deployments would be if they had previously set the CONF.volume_api_class (which would have incorrectly have been ignored), that config will now get picked up | 17:00 |
| mc_nair | instead of always being the default | 17:00 |
| smcginnis | jungleboyj: I agree, I'd be a little worried backporting that at this point. | 17:00 |
| *** vgridnev has joined #openstack-cinder | 17:01 | |
| jgriffith | e0ne: around? | 17:01 |
| smcginnis | mtanino, knomura: Thanks. Don't mean to give you a hard time on this, but it's hard to review something like that. | 17:01 |
| e0ne | mc_nair: good point. does anybody use this param? | 17:01 |
| smcginnis | mtanino, knomura: Hopefully you kind find a simpler way. | 17:01 |
| e0ne | jgriffith: yes | 17:01 |
| jungleboyj | smcginnis: mc_nair Anything that has the potential to change the behavior of a customer's system on a backport is not a good candidate. | 17:01 |
| mtanino | smcginnis: We will try. thanks. | 17:01 |
| jgriffith | e0ne: here's your chance to win me over on Rally :) | 17:01 |
| jgriffith | e0ne: can you teach me how to interpret the failure here: http://logs.openstack.org/04/279304/2/check/gate-rally-dsvm-cinder/0749d2c/ | 17:02 |
| e0ne | jgriffith: oh... | 17:02 |
| jgriffith | e0ne: how do I figure out "why" it fails... and "how" to fix it... and "what" it actually means :) | 17:02 |
| e0ne | jgriffith: it's a bad example:( | 17:02 |
| mc_nair | e0ne: I would doubt it since it plain would not do anything if you set it before. The config was basically broken and would always be the default value. But that's wild speculation | 17:02 |
| jgriffith | e0ne: but that's my point, it's a *real* example :) | 17:02 |
| e0ne | jgriffith: agree | 17:03 |
| *** EinstCra_ has joined #openstack-cinder | 17:03 | |
| *** alonma has quit IRC | 17:03 | |
| *** baumann has joined #openstack-cinder | 17:03 | |
| *** dims_ has joined #openstack-cinder | 17:03 | |
| e0ne | jgriffith: it's "bad" for me, because I didn't know why it happen | 17:03 |
| jgriffith | e0ne: so this is why I say "no" on making rally voting :) | 17:03 |
| jgriffith | e0ne: ahh.. that's fair | 17:03 |
| e0ne | jgriffith: let me try to answer your questions one-by-one | 17:03 |
| jgriffith | e0ne: but I've spent 15 minutes looking at the rally data and output, and I don't have any idea why it fails :) | 17:03 |
| *** EinstCrazy has quit IRC | 17:03 | |
| jungleboyj | mc_nair: Regardless, if a customer had it set, thought it was being used and now they update and it suddenly starts working ... that is concerning. | 17:04 |
| e0ne | jgriffith: I've spend 1 day and failed:( | 17:04 |
| jgriffith | e0ne: or what is "wrong" | 17:04 |
| *** laughterwym has quit IRC | 17:04 | |
| jgriffith | e0ne: LOL... then I don't feel bad any more :) | 17:04 |
| *** jwcroppe has quit IRC | 17:04 | |
| jungleboyj | Oh, interesting. | 17:04 |
| jungleboyj | guitarzan: Just updated the bug. | 17:04 |
| *** dims has quit IRC | 17:04 | |
| e0ne | jgriffith: my thoughts were: backups doesn't work, let's see c-bak logs | 17:04 |
| *** laughterwym has joined #openstack-cinder | 17:04 | |
| jungleboyj | guitarzan: So, this worked in Kilo and then broke in Liberty and is preventing upgrades? | 17:04 |
| *** alonma has joined #openstack-cinder | 17:05 | |
| *** jwcroppe_ has quit IRC | 17:05 | |
| guitarzan | jungleboyj: right, that config option worked before, then didn't work :) | 17:05 |
| e0ne | jgriffith: we use swift backend for c-bak. and we've for permission denied error: http://logs.openstack.org/04/279304/2/check/gate-rally-dsvm-cinder/0749d2c/logs/screen-c-bak.txt.gz?level=WARNING#_2016-02-12_00_47_47_473 | 17:05 |
| DuncanT | jgriffith: Ok, I'll bite since I think I can see how to tell as much as tempest tells you | 17:06 |
| jungleboyj | guitarzan: I guess that makes it a little less concerning. | 17:06 |
| jgriffith | e0ne: yeah... ok. So "why" :) | 17:06 |
| *** salv-orlando has joined #openstack-cinder | 17:06 | |
| jgriffith | e0ne: so yeah, that's awesome... we can see it failed for permission denied on the put to swift | 17:07 |
| e0ne | jgriffith: according to http://logs.openstack.org/04/279304/2/check/gate-rally-dsvm-cinder/0749d2c/logs/etc/swift/proxy-server.conf.txt.gz, we must have "Member" or "admin" role ([filter:keystoneauth] section) | 17:07 |
| jgriffith | e0ne: are we checking swift quota in the backup? | 17:07 |
| e0ne | jgriffith: no, we are not | 17:08 |
| DuncanT | jgriffith: We don't test swift quota | 17:08 |
| jgriffith | e0ne: right on... so the problem is the infra config for the rally test then? But why *this patch*? | 17:08 |
| guitarzan | swift has quotas? today I learned... | 17:08 |
| jgriffith | e0ne: why not ALL patches :) | 17:08 |
| e0ne | jgriffith: it failed for all patches, afaik | 17:08 |
| jgriffith | guitarzan: no, not saying that ... sorry, don't tweet that or something :) | 17:08 |
| jgriffith | e0ne: ahh... ok, I hadn't noticed that | 17:08 |
| *** laughterwym has quit IRC | 17:09 | |
| e0ne | jgriffith: I've failed a bug to cinder to track a progress | 17:09 |
| jgriffith | e0ne: ok, good enough :) | 17:09 |
| jgriffith | e0ne: sorry to put you on the spot in the middle of the night there :) | 17:09 |
| guitarzan | jgriffith: so it isn't a thing? I don't really know :) | 17:09 |
| e0ne | jgriffith: I'll make a patch to disable this tests later tonight | 17:09 |
| guitarzan | I'm easily confused though | 17:09 |
| jgriffith | e0ne: but it goes to my point about how I'm not comfortable with making rally voting at the moment | 17:10 |
| *** alonma has quit IRC | 17:10 | |
| jgriffith | guitarzan: I have NO idea :) | 17:10 |
| guitarzan | haha | 17:10 |
| e0ne | jgriffith: don't worry, I'm always ready to help when available | 17:10 |
| jgriffith | guitarzan: I'm the easiest to confuse these days :) | 17:10 |
| DuncanT | I wonder if the problem is with the user rally creates not having enough roles to write to swift at all? | 17:10 |
| jgriffith | guitarzan: OpenStack and Cinder have gotten *hard* | 17:10 |
| e0ne | DuncanT, jgriffith: http://logs.openstack.org/04/279304/2/check/gate-rally-dsvm-cinder/0749d2c/rally-plot/results.html.gz#/CinderVolumes.create_and_restore_volume_backup/task - here you can see that rally must add Member role to user | 17:10 |
| jgriffith | DuncanT: seems like it | 17:10 |
| *** julim has quit IRC | 17:11 | |
| *** alonma has joined #openstack-cinder | 17:11 | |
| *** salv-orlando has quit IRC | 17:11 | |
| jgriffith | DuncanT: based on the logs at any rate.. as e0ne pointed out it seems that was just missed in the config | 17:11 |
| guitarzan | jgriffith: indeed, I'm currently reading up on this nonsense: https://github.com/openstack/pycadf | 17:11 |
| jgriffith | guitarzan: oh dear! | 17:11 |
| e0ne | DuncanT, jgriffith: but in http://logs.openstack.org/04/279304/2/check/gate-rally-dsvm-cinder/0749d2c/logs/screen-s-proxy.txt.gz we see that there is only "_member_" role | 17:11 |
| e0ne | DuncanT, jgriffith: search by "403" error code | 17:12 |
| e0ne | DuncanT, jgriffith: I can't open http://logs.openstack.org/04/279304/2/check/gate-rally-dsvm-cinder/0749d2c/console.html.gz right now | 17:13 |
| guitarzan | jgriffith: fyi: http://docs.openstack.org/juno/config-reference/content/object-storage-account-quotas.html | 17:13 |
| guitarzan | so I guess it is a thing | 17:13 |
| e0ne | DuncanT, jgriffith: there were a logs wehre I found that rally added Member role to all created roles | 17:13 |
| e0ne | guitarzan: we've got 403 error, not 413 :( | 17:14 |
| openstackgerrit | Merged openstack/cinder: RBD: use versioned objects https://review.openstack.org/279158 | 17:14 |
| guitarzan | e0ne: yeah, sorry, I'm not really helping, I just didn't know quotas were a thing | 17:14 |
| e0ne | jgriffith: that's everything I've found. and I can't reproduce it on mu local env | 17:14 |
| e0ne | need to head home. I'll be back in ~2 hours | 17:15 |
| *** abhishekk has joined #openstack-cinder | 17:15 | |
| *** alonma has quit IRC | 17:15 | |
| *** mtanino has quit IRC | 17:16 | |
| *** e0ne has quit IRC | 17:16 | |
| *** alonma has joined #openstack-cinder | 17:17 | |
| *** abhishekk has quit IRC | 17:17 | |
| dulek | jgriffith: I'm here. :) | 17:18 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port netapp dataontap driver to Python 3 https://review.openstack.org/280331 | 17:20 |
| *** alonma has quit IRC | 17:22 | |
| jgriffith | dulek: hey ya | 17:22 |
| jgriffith | dulek: I wanted to ask about your comments on the versioning in my rep patch | 17:22 |
| dulek | Sure, what's wrong? | 17:22 |
| jgriffith | dulek: might be easiest to just ask you to look at the revision I made and see if that's what you were getting at? | 17:22 |
| *** alejandrito has joined #openstack-cinder | 17:22 | |
| jgriffith | dulek: nothing *wrong* just wanted to make sure I understood the last part correctly :) | 17:23 |
| * dulek is looking. | 17:23 | |
| *** alonma has joined #openstack-cinder | 17:23 | |
| jgriffith | dulek: https://review.openstack.org/#/c/275797/8..9/cinder/volume/rpcapi.py | 17:23 |
| dulek | jgriffith: That's it I think. This isn't really related to versioning or upgrades. | 17:24 |
| *** rcernin has joined #openstack-cinder | 17:24 | |
| dulek | jgriffith: https://review.openstack.org/#/c/271848/ | 17:24 |
| jgriffith | dulek: ahh... I see | 17:25 |
| dulek | jgriffith: The reason for this patch is that in case of zmq messages need to be addressed for a hostname, so our oslo.messaging hacking with host@backend#pool was breaking zmq. | 17:25 |
| jgriffith | dulek: ok, makes sense (I think) :) | 17:26 |
| *** akshai has joined #openstack-cinder | 17:26 | |
| dulek | jgriffith: There's a follow up patch by Vivek, but I don't think it will affect replication work https://review.openstack.org/#/c/277113/ | 17:26 |
| jgriffith | dulek: yeah, first glance that should be "ok", only messing with the delimeters | 17:27 |
| *** knomura has quit IRC | 17:27 | |
| jgriffith | dulek: my changes should just suck in what's needed there magically | 17:28 |
| *** alonma has quit IRC | 17:28 | |
| jgriffith | dulek: if not I'll comment with a -1 :) | 17:28 |
| dulek | jgriffith: :D | 17:28 |
| *** erlon has joined #openstack-cinder | 17:28 | |
| jgriffith | dulek: thanks for the help... and for the review | 17:28 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix last Python 3 issues in zonemanager https://review.openstack.org/280335 | 17:29 |
| *** knomura has joined #openstack-cinder | 17:29 | |
| dulek | jgriffith: No problem. I need to grab something to eat and continue to unclog my review queue. :) | 17:30 |
| *** krtaylor has quit IRC | 17:30 | |
| jgriffith | dulek: review queue's are always clogged I've decided | 17:30 |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix last Python 3 issues in zonemanager https://review.openstack.org/280335 | 17:30 |
| jgriffith | dulek: simple math... input >> output | 17:30 |
| *** akshai has quit IRC | 17:30 | |
| *** alonma has joined #openstack-cinder | 17:30 | |
| mc_nair | jgriffith: on that note... thank you muchly for the quota review (and the size limits review for that matter) - know it was a larger one | 17:31 |
| jgriffith | Needs to be a 5:1 rule... you have to do 5 reviews for every 1 patch you submit | 17:31 |
| jgriffith | mc_nair: yeah.. YOU'RE KILLIN ME :) | 17:31 |
| jgriffith | just kidding | 17:31 |
| mc_nair | :) | 17:31 |
| *** krtaylor has joined #openstack-cinder | 17:31 | |
| jgriffith | mc_nair: did my comment on the size patch make sense? | 17:32 |
| *** markvoelker has joined #openstack-cinder | 17:32 | |
| jgriffith | mc_nair: so I have a strong distaste for one-offs in the API methods | 17:32 |
| dulek | Swanson, smcginnis, diablo_rojo: I've needed to Google daleks, I guess I'm not a nerd. :( | 17:32 |
| mc_nair | jgriffith: I think so. I'm trying to finish up some more quota stuff first, then I'm going to take another path at it | 17:32 |
| jgriffith | mc_nair: get's unwieldy | 17:32 |
| jgriffith | mc_nair: fair enough | 17:33 |
| jgriffith | dulek: you and I both | 17:33 |
| mc_nair | jgriffith: yea - makes total sense. Was taking path of least resistance, but I agree with what you said | 17:33 |
| jgriffith | I guess you have to watch Dr Who to be a true nerd? | 17:33 |
| *** knomura has quit IRC | 17:33 | |
| *** subscope has quit IRC | 17:33 | |
| diablo_rojo | jgriffith: If you want to be a cool nerd you must watch Doctor Who :) | 17:34 |
| jgriffith | diablo_rojo: apparantly so! | 17:35 |
| jbernard | Doctor who? | 17:35 |
| jbernard | (get it?) | 17:35 |
| *** lpetrut has quit IRC | 17:35 | |
| jbernard | sorry, couldn't help myself | 17:35 |
| jgriffith | jbernard: Nice! | 17:35 |
| diablo_rojo | jbernard: Lol | 17:35 |
| *** alonma has quit IRC | 17:35 | |
| jgriffith | jbernard: I used to pull that one with my Dad when I was a kid | 17:35 |
| jgriffith | jbernard: play on the "who's on first"... he didn't think I was funny | 17:36 |
| *** salv-orlando has joined #openstack-cinder | 17:36 | |
| jbernard | they never do :) | 17:37 |
| *** markvoelker has quit IRC | 17:37 | |
| jgriffith | :( | 17:37 |
| dulek | jgriffith: You were making dad's jokes as a kid? I thought it is supposed to go the other way. :D | 17:37 |
| smcginnis | jgriffith: Someone else that grew up watching the old ones?! | 17:37 |
| jgriffith | dulek: I was warped :) | 17:37 |
| jgriffith | smcginnis: yes! Those are the only ones I've ever watched | 17:38 |
| *** alonma has joined #openstack-cinder | 17:38 | |
| *** asselin__ has quit IRC | 17:38 | |
| diablo_rojo | jgriffith: 'was' ? ;) I think we all ARE warped | 17:38 |
| jgriffith | diablo_rojo: fair point! | 17:38 |
| *** chhavi has quit IRC | 17:41 | |
| *** alonma has quit IRC | 17:42 | |
| *** alonma has joined #openstack-cinder | 17:44 | |
| *** openstackgerrit has quit IRC | 17:45 | |
| *** neophy has joined #openstack-cinder | 17:46 | |
| *** openstackgerrit has joined #openstack-cinder | 17:46 | |
| *** mylu has quit IRC | 17:47 | |
| *** alonma has quit IRC | 17:48 | |
| *** mylu has joined #openstack-cinder | 17:49 | |
| *** alonma has joined #openstack-cinder | 17:50 | |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell: Failed vol create could leave dead volumes https://review.openstack.org/280343 | 17:51 |
| *** porrua has joined #openstack-cinder | 17:52 | |
| *** alonma has quit IRC | 17:55 | |
| *** alonma has joined #openstack-cinder | 17:58 | |
| openstackgerrit | Merged openstack/cinder: Huawei: Implement v2 replication (managed) https://review.openstack.org/261246 | 17:59 |
| *** ChubYann has joined #openstack-cinder | 18:00 | |
| *** alonma has quit IRC | 18:03 | |
| *** alonma has joined #openstack-cinder | 18:05 | |
| *** alonma has quit IRC | 18:09 | |
| *** alonma has joined #openstack-cinder | 18:12 | |
| *** gouthamr has quit IRC | 18:13 | |
| *** e0ne has joined #openstack-cinder | 18:13 | |
| *** vincent_hou has quit IRC | 18:13 | |
| *** mylu has quit IRC | 18:15 | |
| *** lpetrut has joined #openstack-cinder | 18:15 | |
| *** alonma has quit IRC | 18:16 | |
| *** alejandrito has quit IRC | 18:18 | |
| *** alonma has joined #openstack-cinder | 18:19 | |
| *** vincent_hou has joined #openstack-cinder | 18:20 | |
| *** vincent_hou has quit IRC | 18:21 | |
| *** alonma has quit IRC | 18:23 | |
| *** eharney has joined #openstack-cinder | 18:25 | |
| *** bardia has joined #openstack-cinder | 18:27 | |
| *** mtanino has joined #openstack-cinder | 18:30 | |
| wN | where is the volume_attachements table in earlier versions of osp? i cant find it in the cinder db. | 18:31 |
| *** mylu has joined #openstack-cinder | 18:32 | |
| *** baumann1 has joined #openstack-cinder | 18:37 | |
| *** jordanP has quit IRC | 18:38 | |
| *** alonma has joined #openstack-cinder | 18:39 | |
| *** baumann has quit IRC | 18:39 | |
| *** gouthamr has joined #openstack-cinder | 18:40 | |
| *** bardia has quit IRC | 18:42 | |
| *** sgotliv has joined #openstack-cinder | 18:43 | |
| *** alonma has quit IRC | 18:45 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Disable Rally backup-related scenarios https://review.openstack.org/280359 | 18:46 |
| e0ne | jgriffith: ^^ | 18:46 |
| *** alonma has joined #openstack-cinder | 18:46 | |
| e0ne | wN: what versions do you mean? | 18:47 |
| wN | e0ne: icehouse -- but i think i figured it out. thanks! | 18:49 |
| jgriffith | e0ne: thanks | 18:49 |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: manage_existing_get_size for VMDK driver https://review.openstack.org/276063 | 18:49 |
| e0ne | jgriffith: np | 18:50 |
| e0ne | I just want to get all jobs stable | 18:50 |
| jgriffith | e0ne: roger that | 18:51 |
| *** alonma has quit IRC | 18:51 | |
| *** jdurgin1 has quit IRC | 18:51 | |
| e0ne | jgriffith: did you see my comment for https://review.openstack.org/#/c/279432/? | 18:52 |
| e0ne | jgriffith: I'm looking for the best way to test cinderclient on gates | 18:53 |
| jgriffith | e0ne: ahh.. that's fair | 18:53 |
| jgriffith | e0ne: how about we start with the basics and add later though? | 18:54 |
| jgriffith | e0ne: ie create, delete, snapshot etc | 18:54 |
| jgriffith | e0ne: also we can "fake" things like nova-volume-attach IMHO | 18:54 |
| e0ne | jgriffith: makes sense, but I would like to drop tempest job to save time | 18:54 |
| jgriffith | e0ne: because I still would consider that cross-project and as covered by dsvm-full | 18:54 |
| geguileo | dulek: ping - rolling upgrades question | 18:54 |
| e0ne | jgriffith: tempest for cinderclient? | 18:54 |
| jgriffith | e0ne: well, depending on which ones you're talking about there are some you should never drop | 18:55 |
| e0ne | jgriffith: are they going to use clients again? | 18:55 |
| jgriffith | e0ne: well; they're not specifically cinderclient tests | 18:55 |
| eharney | this little patch would quite like a review: https://review.openstack.org/#/c/278594/ | 18:55 |
| jgriffith | e0ne: they use clients now, that's the only way it works | 18:55 |
| openstackgerrit | Merged openstack/cinder: Support for consistency groups in ScaleIO driver https://review.openstack.org/269624 | 18:55 |
| *** subscope has joined #openstack-cinder | 18:55 | |
| e0ne | jgriffith: I'm not sure that we're on the same page | 18:56 |
| smcginnis | eharney: Well that went quick. | 18:56 |
| jgriffith | e0ne: sounds like I may be missing something | 18:56 |
| jgriffith | anybody know anything about this: http://paste.openstack.org/show/487031/ | 18:57 |
| e0ne | jgriffith: tempest does NOT use cinderclient | 18:58 |
| jgriffith | e0ne: oh? | 18:58 |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: manage_existing_get_size for VMDK driver https://review.openstack.org/276063 | 18:58 |
| e0ne | jgriffith: eharney just posted link to fix ^^ | 18:58 |
| e0ne | jgriffith: tempest uses own client to access APIs | 18:58 |
| jgriffith | e0ne: I think that's different | 18:59 |
| dulek | geguileo: hi | 18:59 |
| jgriffith | eharney: 's patch | 18:59 |
| jgriffith | err.. wait | 18:59 |
| jgriffith | e0ne: ok, one thing at a time for me... | 18:59 |
| jgriffith | e0ne: back to Tempest | 18:59 |
| e0ne | jgriffith: :) | 18:59 |
| geguileo | dulek: Hi | 18:59 |
| geguileo | dulek: Regarding the _current and _available version fields in the DB | 19:00 |
| geguileo | dulek: I see we are setting current in start | 19:00 |
| dulek | geguileo: Right, these were merged in Liberty, when idea was a little different. | 19:00 |
| geguileo | dulek: Why aren't we setting available as well? | 19:00 |
| dulek | geguileo: That's why available is unused. | 19:00 |
| geguileo | dulek: So we can drop available? | 19:00 |
| *** gouthamr_ has joined #openstack-cinder | 19:01 | |
| geguileo | dulek: I'm asking because I need to work that stuff out for the job distribution patches | 19:01 |
| e0ne | jgriffith: we can't test cinderclient with tempest | 19:01 |
| dulek | geguileo: I think we can drop it, I have a bad habit of leaving the indefinite decision for the last moments… ;) | 19:01 |
| dulek | geguileo: But in current status it's much easier to readd things, than to drop it. | 19:02 |
| geguileo | dulek: Ok, so I won't recreate that field in the nodes table | 19:02 |
| e0ne | jgriffith: https://github.com/openstack/tempest/search?utf8=%E2%9C%93&q=cinderclient | 19:02 |
| dulek | geguileo: Cool. I'll propose patche to remove these fields from the model, so we'll be able to drop them from the DB in Newton. | 19:02 |
| geguileo | dulek: And the current one is the one that the service runs or the minimum? | 19:02 |
| dulek | geguileo: It's the manager version of the service. | 19:03 |
| dulek | geguileo: So the version the service runs. | 19:03 |
| *** ociuhandu has quit IRC | 19:03 | |
| geguileo | dulek: Ok, and minimum will be used from the Service method you added | 19:04 |
| *** gouthamr has quit IRC | 19:04 | |
| *** vgridnev has quit IRC | 19:04 | |
| jgriffith | e0ne: my point is/was we can test cinderclient without the cross project stuff being installed | 19:04 |
| jgriffith | e0ne: do you disagree? | 19:04 |
| jgriffith | e0ne: at the very least we can start that way | 19:05 |
| openstackgerrit | Merged openstack/cinder: Port utils.safe_minidom_parse_string() to Python 3 https://review.openstack.org/277983 | 19:05 |
| e0ne | jgriffith: I'm agree with you | 19:05 |
| e0ne | jgriffith: but we're talking about different things | 19:05 |
| jgriffith | e0ne: yes, perhaps | 19:05 |
| geguileo | dulek: And I need to move those fields to the node table | 19:06 |
| e0ne | jgriffith: IMO, we need 2 types of tests | 19:06 |
| jgriffith | e0ne: so you're saying also set up a full integration test suite | 19:06 |
| dulek | geguileo: Yes, it gets all the managers version and selects lowest one. | 19:06 |
| geguileo | dulek: Ok, thanks | 19:06 |
| jgriffith | e0ne: that depends on Nova, Neutron, Swift etc | 19:06 |
| *** vgridnev has joined #openstack-cinder | 19:06 | |
| e0ne | jgriffith: 1) w/o cross-project things to verify cinderclient itselfs | 19:06 |
| dulek | geguileo: Yes, as we probably should allow to update nodes one-by-one as well. | 19:07 |
| e0ne | jgriffith: correct, 2) integration tests to verify cinderclient API to make sure that we won't break other projects/client users | 19:07 |
| dulek | geguileo: And if this would be reported in the same DB entry… That wouldn't work. :) | 19:07 |
| geguileo | dulek: Yes we need to support it | 19:07 |
| jgriffith | e0ne: ok, yes that makes sense | 19:07 |
| geguileo | dulek: Yes, I've moved a couple of fields already, but I have to move these 2 as well | 19:07 |
| e0ne | jgriffith: tempest doesn't verify clients for cross-projetc stuff. so, I think it's OK to have few tests in cinderclietn for that | 19:08 |
| jgriffith | e0ne: perhaps... but I do think the functional tests are the better place to start | 19:09 |
| jgriffith | e0ne: but ok, I'll remove my vote and let others hash it out :) | 19:09 |
| jgriffith | e0ne: I'm just saying that I think it makes more sense to start with the basics and build on them | 19:09 |
| mtanino | jgriffith: I have fixed that port error but seems it was broken.... https://review.openstack.org/#/c/259524/ | 19:10 |
| *** akerr_away has quit IRC | 19:10 | |
| jgriffith | mtanino: thank you for that link! I suspect my rebase messed things up perhaps? I'll look and make sure I have everything in place | 19:10 |
| mtanino | jgriffith: But now eharney is trying to fix it again. Looks good. https://review.openstack.org/#/c/278594/ | 19:11 |
| jgriffith | mtanino: right, and I gave that a +2/A | 19:12 |
| jgriffith | mtanino: but I'm confused now :( | 19:12 |
| mtanino | jgriffith: oh :( | 19:12 |
| openstackgerrit | Merged openstack/cinder: Sheepdog: Fix malformed image url format https://review.openstack.org/280114 | 19:13 |
| eharney | as am i | 19:13 |
| eharney | mtanino: oh, i see. https://review.openstack.org/#/c/258541/ removed your fix. | 19:14 |
| *** annasort has joined #openstack-cinder | 19:15 | |
| mtanino | eharney: yes... unfortunately... | 19:15 |
| mtanino | I noticed it now... | 19:15 |
| jgriffith | That's disappointing | 19:15 |
| *** fthiagogv_ has joined #openstack-cinder | 19:16 | |
| Swanson | Easy +2 for anyone so inclined ... https://review.openstack.org/280343 | 19:17 |
| *** fthiagogv has quit IRC | 19:19 | |
| jgriffith | hmm... so yes, indeed | 19:20 |
| jgriffith | that explains it all | 19:20 |
| jgriffith | thanks mtanino and eharney | 19:20 |
| mtanino | jgriffith: you got something? | 19:20 |
| jgriffith | mtanino: yeah... well; I cherry-picked in eharney 's changes that I did not think would impact this. Turns out I was very wrong :) | 19:21 |
| jgriffith | mtanino: eharney this fixed the failing items that I started seeing after the last rebase | 19:21 |
| eharney | good | 19:21 |
| jgriffith | I was confused by this though... but anyway; probably doesn't matter | 19:21 |
| jgriffith | still bothers me, but I'll get over it ;) | 19:22 |
| e0ne | jgriffith: I'll send a mail to openstack-dev: python-*client integraion tests could be cross-project issues | 19:22 |
| jgriffith | e0ne: that's a great idea | 19:22 |
| jgriffith | e0ne: seems to me that would be something applicable to that team | 19:22 |
| e0ne | jgriffith: thanks, it's mostly your idea | 19:23 |
| jgriffith | e0ne: take it you saw my comment regarding the duplication of tests? | 19:23 |
| e0ne | jgriffith: looking on your comment | 19:23 |
| jgriffith | e0ne: if the majority thinks I'm off my rocker that's ok too. I don't want to stop progress | 19:23 |
| jgriffith | e0ne: I just think it could result in a lot of duplication of effort and double/triple testing etc | 19:24 |
| e0ne | jgriffith: tests duplication could be an issue, I'm agree with you | 19:25 |
| jgriffith | e0ne: cool.. and also keep in mind that I'd assume OSC has a lot of this going on as well | 19:25 |
| e0ne | jgriffith: OSC will cover only CLI | 19:25 |
| *** kvidvans has joined #openstack-cinder | 19:26 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Recreating SG when it has been deleted https://review.openstack.org/279900 | 19:26 |
| jgriffith | e0ne: well... perhaps, but that cli is calling the client which is calling the API and checking the results | 19:27 |
| jgriffith | e0ne: in other words it's testing the code paths | 19:27 |
| jgriffith | e0ne: I could be wrong, maybe they're not going end2end.. I'll look | 19:27 |
| jgriffith | e0ne: yes, it looks to me like they are | 19:27 |
| e0ne | jgriffith: :) | 19:28 |
| *** lpetrut has quit IRC | 19:28 | |
| jgriffith | e0ne: for example... here's yet another volume-attach test :) http://logs.openstack.org/20/279920/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e980e0c/logs/screen-c-vol.txt.gz#_2016-02-14_13_32_46_824 | 19:28 |
| e0ne | jgriffith: in such case, I would like to run it on every cinderclient's patch | 19:29 |
| *** salv-orlando has quit IRC | 19:30 | |
| *** markvoelker has joined #openstack-cinder | 19:32 | |
| *** markvoelker has quit IRC | 19:37 | |
| *** alejandrito has joined #openstack-cinder | 19:41 | |
| *** alejandrito has quit IRC | 19:42 | |
| *** alejandrito has joined #openstack-cinder | 19:42 | |
| *** alejandrito has quit IRC | 19:42 | |
| *** alejandrito has joined #openstack-cinder | 19:42 | |
| *** alonma has joined #openstack-cinder | 19:46 | |
| jgriffith | e0ne: sure, but I'd argue that's overkill... if you write proper functional tests that should be sufficient | 19:48 |
| jgriffith | e0ne: as opposed to having 6 or 7 different test-suites all testing the exact same thing :) | 19:49 |
| *** raildo is now known as raildo-afk | 19:49 | |
| e0ne | jgriffith: I can't argue with you because you're right:) | 19:50 |
| e0ne | jgriffith: http://lists.openstack.org/pipermail/openstack-dev/2016-February/086591.html - I've tried to summurize our conversation | 19:50 |
| jgriffith | e0ne: haha... wow!! I don't think I've ever had anybody say that to me before :) | 19:50 |
| jgriffith | e0ne: excellent, thanks Ivan! | 19:50 |
| e0ne | jgriffith: forget it, I didn't say that ;) | 19:50 |
| jgriffith | e0ne: LOL!! Smart man!! | 19:51 |
| e0ne | jgriffith: :) | 19:51 |
| *** alonma has quit IRC | 19:51 | |
| *** alonma has joined #openstack-cinder | 19:53 | |
| e0ne | jgriffith: I believe, we'll find best way to test cinderclient | 19:53 |
| jgriffith | e0ne: agreed | 19:53 |
| e0ne | need to take a break. be back tomorrow in ~12 hours | 19:53 |
| jgriffith | e0ne: sleep well.. see you tomorrow | 19:54 |
| jgriffith | e0ne: thanks for all the help, and being patient explaining things to me :) | 19:54 |
| e0ne | jgriffith: you're welcome! | 19:54 |
| *** 20WAADYST has joined #openstack-cinder | 19:55 | |
| e0ne | jgriffith: btw, do you have day-off due to Presidents Day? | 19:55 |
| jgriffith | e0ne: yes.. but it's a good chance for me to work on OpenStack stuff without meetings or other interruptions :) | 19:56 |
| e0ne | jgriffith: :) | 19:56 |
| *** raildo-afk is now known as raildo | 19:56 | |
| openstackgerrit | Merged openstack/cinder: Tests: Set volume listen port to test_service_listen_port https://review.openstack.org/278594 | 19:56 |
| e0ne | have a good day! see you tomorrow | 19:56 |
| *** e0ne has quit IRC | 19:56 | |
| *** alonma has quit IRC | 19:57 | |
| *** alonma has joined #openstack-cinder | 19:59 | |
| *** e0ne has joined #openstack-cinder | 19:59 | |
| *** 20WAADYST has quit IRC | 20:00 | |
| mtanino | e0ne: see you! | 20:01 |
| *** alonma has quit IRC | 20:04 | |
| *** alonma has joined #openstack-cinder | 20:05 | |
| *** alonma has quit IRC | 20:09 | |
| dulek | jgriffith: What does "default" mean in active_backend_id field? | 20:10 |
| jgriffith | dulek: :) | 20:10 |
| dulek | jgriffith: I just wonder if it shouldn't be just NULL by default. | 20:10 |
| jgriffith | dulek: so it *means* just the NORMAL backend is in use.. no replication target etc... and YES, you're correct, I think Null is more appropriate | 20:11 |
| dulek | jgriffith: Hey, that was easy… ;) | 20:11 |
| jgriffith | :) | 20:11 |
| *** raildo is now known as raildo-afk | 20:11 | |
| *** alonma has joined #openstack-cinder | 20:11 | |
| *** alonma has quit IRC | 20:16 | |
| *** openstackgerrit has quit IRC | 20:17 | |
| *** openstackgerrit_ is now known as openstackgerrit | 20:17 | |
| *** openstackgerrit has quit IRC | 20:17 | |
| *** alonma has joined #openstack-cinder | 20:17 | |
| *** openstackgerrit_ has joined #openstack-cinder | 20:18 | |
| *** openstackgerrit_ is now known as openstackgerrit | 20:18 | |
| *** openstackgerrit_ has joined #openstack-cinder | 20:19 | |
| *** lpetrut has joined #openstack-cinder | 20:20 | |
| *** alonma has quit IRC | 20:22 | |
| *** alonma has joined #openstack-cinder | 20:23 | |
| *** erlon has quit IRC | 20:26 | |
| *** alonma has quit IRC | 20:28 | |
| *** e0ne has quit IRC | 20:29 | |
| *** alonma has joined #openstack-cinder | 20:31 | |
| *** alonma has quit IRC | 20:36 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port infortrend driver to Python 3 https://review.openstack.org/280389 | 20:37 |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell: Failed vol create could leave dead volumes https://review.openstack.org/280343 | 20:38 |
| *** alonma has joined #openstack-cinder | 20:42 | |
| *** salv-orlando has joined #openstack-cinder | 20:42 | |
| *** alonma has quit IRC | 20:46 | |
| *** vgridnev has quit IRC | 20:47 | |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell: Failed vol create could leave dead volumes https://review.openstack.org/280343 | 20:56 |
| Swanson | !@#! pep8 | 20:56 |
| openstack | Swanson: Error: "@#!" is not a valid command. | 20:56 |
| smcginnis | Swanson: tox -e pep8 | 20:58 |
| jgriffith | You tell him openstack bot! | 20:58 |
| *** dustins has quit IRC | 20:59 | |
| smcginnis | openstack bot is so helpful. We should nominate him for core. | 20:59 |
| Swanson | openstack bot can suck it. | 20:59 |
| smcginnis | :D | 20:59 |
| jgriffith | smcginnis: haha +1 | 20:59 |
| *** mylu has quit IRC | 21:03 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Test middleware test_faults to Python 3 https://review.openstack.org/249399 | 21:11 |
| *** Lee1092 has quit IRC | 21:12 | |
| *** sgotliv has quit IRC | 21:12 | |
| jgriffith | patrickeast: ping | 21:16 |
| jgriffith | Swanson: you might have some input too... | 21:16 |
| jgriffith | I'm working on implementing the exception handling in manager.failover... | 21:16 |
| Swanson | jgriffith, wut? | 21:16 |
| jgriffith | So I have a few cases that I catch: UnableToFailOver, InvalidTarget and just the general "I'm hosed" Driver exception | 21:17 |
| jgriffith | I'm trying to decide what will not make people came at me with pitch-forks in terms of setting state on these | 21:17 |
| jgriffith | s/came/come/ | 21:18 |
| Swanson | s/will not make/will make fewer/ | 21:18 |
| jgriffith | I can set "replication_status" to "error" or "failover-error" or ignore the problem and just set it back to "enabled" | 21:19 |
| jgriffith | in the case of success BTW it changes to "failed-over" | 21:19 |
| Swanson | 'failover-error' | 21:19 |
| patrickeast | jgriffith: hey | 21:19 |
| jgriffith | Swanson: that's what I thought too, but then I need a mechanism to clear that or allow passing in the failover command again later | 21:19 |
| jgriffith | patrickeast: hey | 21:20 |
| jgriffith | patrickeast: thoughts on that? | 21:20 |
| jgriffith | Swanson: which is "ok" | 21:20 |
| patrickeast | I'm ok with an error kind of state as long as we can try and failover again while in that state | 21:20 |
| jgriffith | patrickeast: ok... Swanson you agree I think? | 21:20 |
| patrickeast | I just got a lot of feedback from the v2 one that it was really hard to recover if you type the secondary name wrong | 21:20 |
| jgriffith | patrickeast: Swanson the invalid-target case I think should just reset back to where it was and return and error to the user? | 21:21 |
| patrickeast | Sounds good to me | 21:21 |
| jgriffith | although that raises the problem/question of blocking on failover again :( | 21:21 |
| Swanson | jgriffith, I would agree. You bozoed the command, nothing happened, back to the start state. | 21:21 |
| jgriffith | Swanson: yeah, seems reasonable to me, just don't know if people are going to freak out that there's no feedback to indicate that | 21:22 |
| jgriffith | maybe I'll just add an error-reason column and be done with it ;) | 21:22 |
| patrickeast | jgriffith: ah yea, I was wondering about that too, if we do end up doing non-blocking on failover we could add a driver api that was like validate_secondary or even have the manager peek at the list targets and check that the name is there | 21:24 |
| jgriffith | patrickeast: yeah, I think I have a comment to that affect somewhere | 21:25 |
| patrickeast | But for general errors the error column makes a lot of sense imo | 21:25 |
| jgriffith | patrickeast: so maybe that's good follow up work :) | 21:25 |
| patrickeast | Yea v2.2 :D | 21:25 |
| jgriffith | LOL | 21:25 |
| jgriffith | patrickeast: I think I'll table the error-reason column for a future patch as well | 21:25 |
| jgriffith | patrickeast: it would SURE come in handy for other things in the future | 21:26 |
| Swanson | I would punt for now if it isn't really needed. Not going to have a ton of runtime on 2.1 before release as is. | 21:27 |
| jgriffith | Swanson: good point | 21:27 |
| *** ianbrown_ has quit IRC | 21:28 | |
| *** markvoelker has joined #openstack-cinder | 21:33 | |
| *** cdelatte has quit IRC | 21:35 | |
| *** markvoelker has quit IRC | 21:38 | |
| *** alonma has joined #openstack-cinder | 21:43 | |
| *** haomaiwang has joined #openstack-cinder | 21:44 | |
| *** amoturi has left #openstack-cinder | 21:46 | |
| *** sheel has quit IRC | 21:47 | |
| *** alonma has quit IRC | 21:47 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 https://review.openstack.org/275797 | 21:47 |
| *** subscope has quit IRC | 21:48 | |
| *** haomaiwang has quit IRC | 21:48 | |
| *** esp has joined #openstack-cinder | 21:49 | |
| *** alejandrito has quit IRC | 21:49 | |
| *** cdelatte has joined #openstack-cinder | 21:50 | |
| *** alonma has joined #openstack-cinder | 21:50 | |
| *** sgotliv has joined #openstack-cinder | 21:52 | |
| *** alonma has quit IRC | 21:54 | |
| *** esp has quit IRC | 21:56 | |
| *** alonma has joined #openstack-cinder | 21:57 | |
| *** esp has joined #openstack-cinder | 21:59 | |
| *** zhonghua-lee has quit IRC | 21:59 | |
| *** zhonghua-lee has joined #openstack-cinder | 22:00 | |
| *** alonma has quit IRC | 22:01 | |
| *** alyson_ has quit IRC | 22:02 | |
| *** salv-orl_ has joined #openstack-cinder | 22:03 | |
| *** alonma has joined #openstack-cinder | 22:03 | |
| *** esp has quit IRC | 22:04 | |
| *** laughterwym has joined #openstack-cinder | 22:05 | |
| *** salv-orlando has quit IRC | 22:05 | |
| *** alonma has quit IRC | 22:07 | |
| *** alonma has joined #openstack-cinder | 22:09 | |
| *** laughterwym has quit IRC | 22:10 | |
| jgriffith | Well that sucks | 22:13 |
| jgriffith | I add the get Service object in the manager which works fine in real life.. but fails 516 of the unit tests because of missing components in the fakes | 22:13 |
| jgriffith | :( | 22:13 |
| *** neophy has quit IRC | 22:14 | |
| *** alonma has quit IRC | 22:14 | |
| *** alonma has joined #openstack-cinder | 22:15 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Migration: take the direct path for the source volume https://review.openstack.org/250220 | 22:17 |
| *** ociuhandu has joined #openstack-cinder | 22:18 | |
| *** alonma has quit IRC | 22:20 | |
| diablo_rojo | smcginnis: Got the link to that page with all the CI triggers? jungleboyj needs it. | 22:21 |
| smcginnis | diablo_rojo: https://wiki.openstack.org/wiki/ThirdPartySystems | 22:21 |
| jgriffith | Ummm... diablo_rojo smcginnis you guys got some kinda Vulcan mind-meld there or what? | 22:22 |
| jungleboyj | diablo_rojo: I told you that was the one he was talking about. | 22:22 |
| jungleboyj | jgriffith: You didn't get that? | 22:22 |
| jgriffith | diablo_rojo: smcginnis 30 seconds to figure it out, find the link and post it! | 22:22 |
| *** alonma has joined #openstack-cinder | 22:23 | |
| diablo_rojo | smcginnis: jungleboyj Maybe I am blind or stupid but I don't see the triggers there.. | 22:23 |
| jgriffith | jungleboyj: the mind-meld? Nope.. lucky for all of you :) | 22:23 |
| diablo_rojo | smcginnis: Blind. | 22:24 |
| jgriffith | jungleboyj: none of you want to look inside here | 22:24 |
| diablo_rojo | smcginnis: I am blind. | 22:24 |
| smcginnis | jgriffith: I've had to use that link often. ;) | 22:24 |
| jgriffith | smcginnis: :) | 22:24 |
| jgriffith | smcginnis: sorry to hear that | 22:24 |
| smcginnis | diablo_rojo: If you go to a specific CI, we've been trying to put the recheck triggers at the bottom. | 22:24 |
| jungleboyj | smcginnis: That was what I thought. Ok, cool. | 22:24 |
| smcginnis | jgriffith: I think I've said it before. My mind is just one giant index of pointers to other information. :) | 22:24 |
| jungleboyj | Tried to find an example but had no luck. | 22:24 |
| diablo_rojo | smcginnis: Took me a sec cause I happend to click on like three links with no trigger listed lol | 22:24 |
| smcginnis | Yeah, no way to enforce it, so not all of them have it. | 22:25 |
| jungleboyj | smcginnis: I will start calling you google mcginnis | 22:25 |
| *** sgotliv has quit IRC | 22:25 | |
| diablo_rojo | smcginnis: But then I clicked on an IBM driver and the trigger was there :) | 22:25 |
| diablo_rojo | smcginnis: Recheck trigger: "<please update with the comment format(s) that will trigger a recheck of this CI>" | 22:27 |
| *** alonma has quit IRC | 22:28 | |
| *** huanan_L has quit IRC | 22:28 | |
| smcginnis | diablo_rojo: ;) | 22:28 |
| diablo_rojo | smcginnis: Thank you for such ninja linking | 22:28 |
| *** JoseMello has quit IRC | 22:28 | |
| *** huanan_L has joined #openstack-cinder | 22:28 | |
| *** liewegas has quit IRC | 22:29 | |
| *** liewegas has joined #openstack-cinder | 22:30 | |
| *** baumann1 has left #openstack-cinder | 22:31 | |
| *** diablo_rojo has quit IRC | 22:32 | |
| *** jungleboyj has quit IRC | 22:32 | |
| openstackgerrit | John Griffith proposed openstack/cinder: Replication v2.1 https://review.openstack.org/275797 | 22:35 |
| *** jgregor has quit IRC | 22:39 | |
| *** lpetrut has quit IRC | 22:40 | |
| *** ociuhandu has quit IRC | 22:41 | |
| *** edtubill has quit IRC | 22:56 | |
| *** mriedem is now known as mriedem_away | 22:57 | |
| *** arif-ali has left #openstack-cinder | 22:59 | |
| *** rlrossit has quit IRC | 23:01 | |
| jgriffith | smcginnis: I know this was unpopular, but I fail to see why we still fight with that ? | 23:03 |
| jgriffith | smcginnis: as opposed to just requiring that you trigger on "recheck-<ci-name>" | 23:04 |
| *** jungleboyj has joined #openstack-cinder | 23:04 | |
| *** rcernin has quit IRC | 23:05 | |
| *** tpsilva has quit IRC | 23:06 | |
| DuncanT | smcginnis: What do you mean no way to enforce it? Just start removing drivers and the triggers magically appear | 23:10 |
| * DuncanT suggests that people also implement alternative recheck triggers, such as 'for f%$@ sake solidfire' and such | 23:11 | |
| *** krtaylor has quit IRC | 23:11 | |
| jgriffith | DuncanT: heeh.. I like that! | 23:12 |
| *** krtaylor has joined #openstack-cinder | 23:23 | |
| *** mylu has joined #openstack-cinder | 23:28 | |
| *** akerr has joined #openstack-cinder | 23:28 | |
| *** Julien-zte has joined #openstack-cinder | 23:29 | |
| openstackgerrit | Merged openstack/cinder: Add missing requirements https://review.openstack.org/268254 | 23:30 |
| *** akerr has quit IRC | 23:31 | |
| *** haomaiwang has joined #openstack-cinder | 23:32 | |
| *** markvoelker has joined #openstack-cinder | 23:34 | |
| *** haomaiwang has quit IRC | 23:36 | |
| *** markvoelker has quit IRC | 23:38 | |
| openstackgerrit | Merged openstack/cinder: py3: Fix usage of JSON in API contrib https://review.openstack.org/277989 | 23:41 |
| *** dims_ has quit IRC | 23:41 | |
| *** yhayashi has joined #openstack-cinder | 23:51 | |
| openstackgerrit | Merged openstack/cinder: Profiler: don't call trace_cls if profiler is not enabled https://review.openstack.org/278595 | 23:52 |
| *** Julien-zte has quit IRC | 23:57 | |
| *** dims has joined #openstack-cinder | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!