| *** haomaiwang has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-cinder | 00:01 | |
| *** daneyon has quit IRC | 00:03 | |
| smcginnis | savihou: Hi, welcome. | 00:05 |
|---|---|---|
| smcginnis | savihou: If you're running in to issues once you actually start running cinder we can definitely help. | 00:05 |
| smcginnis | savihou: But there are several here that have gone through setting up CI, so chances are you can get some pointers. | 00:05 |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 00:05 |
| scottda | smcginnis: I believe we really will need a change in grenade for adding a /v3 endpoint: https://review.openstack.org/#/c/276505/ | 00:06 |
| scottda | Hopefully that ^^ will help Jenkins and CI for the microversions patch | 00:07 |
| *** lprice has joined #openstack-cinder | 00:08 | |
| *** lprice1 has quit IRC | 00:08 | |
| *** dalgaaf has quit IRC | 00:08 | |
| *** daneyon_ has quit IRC | 00:09 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder: EMC VMAX - Method not being called for V3 https://review.openstack.org/252066 | 00:09 |
| smcginnis | scottda: OK, good. I'll weigh in on there and see how it goes. | 00:09 |
| smcginnis | scottda: Thanks! | 00:10 |
| hemna | now I remember why I hate nfs so much | 00:12 |
| anteaya | hemna: only now? | 00:13 |
| *** alonma has joined #openstack-cinder | 00:14 | |
| hemna | hehe | 00:14 |
| hemna | well, I'm trying to get it to work so I can test something | 00:14 |
| hemna | haven't used nfs in ages | 00:15 |
| hemna | such a pain | 00:15 |
| *** alonma has quit IRC | 00:18 | |
| apoorvad | smcginnis thanks for your comments yesterday, I have replied to your questions and worked on suggestions. when you get a chance could you please look at it again? https://review.openstack.org/#/c/268370/ and https://review.openstack.org/#/c/261126/ | 00:21 |
| smcginnis | apoorvad: Sure, I'll try to take a look soon. Thanks for updating them. | 00:22 |
| *** mylu has quit IRC | 00:22 | |
| apoorvad | smcginnis: appreciate it :) | 00:22 |
| *** gouthamr_ has joined #openstack-cinder | 00:22 | |
| *** alonma has joined #openstack-cinder | 00:24 | |
| hemna | finally | 00:24 |
| hemna | what a pain | 00:24 |
| hemna | Stale file handle | 00:24 |
| hemna | hours | 00:24 |
| hemna | pain! | 00:24 |
| *** gouthamr has quit IRC | 00:25 | |
| *** alonma has quit IRC | 00:28 | |
| *** edtubill has quit IRC | 00:29 | |
| *** alonma has joined #openstack-cinder | 00:33 | |
| *** smoriya_ has joined #openstack-cinder | 00:34 | |
| anteaya | hemna: are you experiencing pain? | 00:37 |
| anteaya | is that what I'm hearing? | 00:37 |
| *** alonma has quit IRC | 00:37 | |
| *** haomaiw__ has joined #openstack-cinder | 00:38 | |
| *** dims_ has joined #openstack-cinder | 00:39 | |
| *** haomaiwang has quit IRC | 00:40 | |
| *** dims has quit IRC | 00:40 | |
| *** alonma has joined #openstack-cinder | 00:42 | |
| *** alonma has quit IRC | 00:47 | |
| *** qeelee has joined #openstack-cinder | 00:47 | |
| *** alonma has joined #openstack-cinder | 00:50 | |
| *** salv-orl_ has quit IRC | 00:54 | |
| *** alonma has quit IRC | 00:55 | |
| *** alonma has joined #openstack-cinder | 00:57 | |
| *** mylu has joined #openstack-cinder | 00:59 | |
| *** haomaiw__ has quit IRC | 01:01 | |
| *** rockeychen has quit IRC | 01:01 | |
| *** alonma has quit IRC | 01:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 01:01 | |
| *** rockeychen has joined #openstack-cinder | 01:01 | |
| *** chlong has joined #openstack-cinder | 01:01 | |
| *** dustins has quit IRC | 01:04 | |
| *** xyang has joined #openstack-cinder | 01:05 | |
| *** xyang has quit IRC | 01:06 | |
| *** daneyon has joined #openstack-cinder | 01:08 | |
| *** daneyon_ has joined #openstack-cinder | 01:09 | |
| *** cheneydc has joined #openstack-cinder | 01:11 | |
| *** daneyon has quit IRC | 01:13 | |
| jbernard | DuncanT: so, rbd's iSCSI is a bit better than connecting the block devices and re-exporting those over iSCSI | 01:18 |
| jbernard | DuncanT: it uses both the rbd kernel module and the rbd-lio module | 01:18 |
| *** daneyon_ has quit IRC | 01:18 | |
| jbernard | DuncanT: so that targetcli can be used to create exports for rbd images | 01:19 |
| jbernard | DuncanT: and there is no local block device | 01:19 |
| jbernard | DuncanT: but it does require a dedicated node(s) to provide those exports | 01:19 |
| jbernard | DuncanT: so the solution is not present within the ceph cluster | 01:20 |
| jbernard | DuncanT: ive just been digging through the kernel code, i dont have a tutorial yes | 01:21 |
| jbernard | DuncanT: but i do plan to give this all a try soon and see how it goes | 01:21 |
| jbernard | DuncanT: s/yes/yet | 01:21 |
| *** r-daneel has quit IRC | 01:24 | |
| *** garthb has quit IRC | 01:24 | |
| *** joqo78 has joined #openstack-cinder | 01:26 | |
| *** merooney has joined #openstack-cinder | 01:28 | |
| *** davechen has joined #openstack-cinder | 01:28 | |
| *** alonma has joined #openstack-cinder | 01:31 | |
| *** mtanino has quit IRC | 01:34 | |
| *** chlong has quit IRC | 01:34 | |
| *** chlong has joined #openstack-cinder | 01:35 | |
| *** alonma has quit IRC | 01:36 | |
| *** wanghao has quit IRC | 01:41 | |
| *** savihou has quit IRC | 01:41 | |
| *** wanghao has joined #openstack-cinder | 01:41 | |
| *** leeantho has quit IRC | 01:42 | |
| *** merooney has quit IRC | 01:43 | |
| *** mylu has quit IRC | 01:51 | |
| *** merooney has joined #openstack-cinder | 01:52 | |
| *** mudassirlatif has quit IRC | 01:54 | |
| *** laughterwym has joined #openstack-cinder | 01:58 | |
| *** mylu has joined #openstack-cinder | 01:59 | |
| *** itzdilip has quit IRC | 02:00 | |
| *** haomaiwa_ has quit IRC | 02:01 | |
| *** laughterwym has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-cinder | 02:01 | |
| *** laughterwym has joined #openstack-cinder | 02:02 | |
| *** mylu_ has joined #openstack-cinder | 02:05 | |
| *** mylu has quit IRC | 02:05 | |
| *** edmondsw has quit IRC | 02:10 | |
| *** alkhodos has quit IRC | 02:17 | |
| *** baojg has joined #openstack-cinder | 02:18 | |
| *** itzdilip has joined #openstack-cinder | 02:25 | |
| *** apoorvad has quit IRC | 02:26 | |
| *** haomaiwang has quit IRC | 02:28 | |
| *** haomaiwang has joined #openstack-cinder | 02:29 | |
| *** apoorvad has joined #openstack-cinder | 02:29 | |
| *** alonma has joined #openstack-cinder | 02:31 | |
| *** alonma has quit IRC | 02:36 | |
| *** daneyon has joined #openstack-cinder | 02:37 | |
| *** mylu_ has quit IRC | 02:39 | |
| *** cknight1 has joined #openstack-cinder | 02:39 | |
| *** mylu has joined #openstack-cinder | 02:40 | |
| *** daneyon_ has joined #openstack-cinder | 02:41 | |
| *** cknight has quit IRC | 02:42 | |
| *** daneyon has quit IRC | 02:43 | |
| *** apoorvad has quit IRC | 02:47 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 03:01 | |
| *** bardia has quit IRC | 03:03 | |
| *** haomaiwa_ has quit IRC | 03:05 | |
| *** mylu has quit IRC | 03:06 | |
| *** mylu has joined #openstack-cinder | 03:06 | |
| *** mylu has quit IRC | 03:11 | |
| *** mylu has joined #openstack-cinder | 03:12 | |
| *** rockeychen has quit IRC | 03:18 | |
| *** rockeychen has joined #openstack-cinder | 03:19 | |
| *** leeantho has joined #openstack-cinder | 03:31 | |
| *** alonma has joined #openstack-cinder | 03:32 | |
| *** dims_ has quit IRC | 03:33 | |
| *** alonma has quit IRC | 03:36 | |
| *** alonma has joined #openstack-cinder | 03:39 | |
| *** alonma has quit IRC | 03:44 | |
| *** qeelee has quit IRC | 03:47 | |
| *** daneyon_ has quit IRC | 03:57 | |
| *** baojg has quit IRC | 03:57 | |
| *** baojg has joined #openstack-cinder | 04:03 | |
| *** vgridnev has joined #openstack-cinder | 04:04 | |
| *** joqo78 has quit IRC | 04:06 | |
| *** cknight1 has quit IRC | 04:07 | |
| *** arch-nemesis has joined #openstack-cinder | 04:07 | |
| *** cknight has joined #openstack-cinder | 04:07 | |
| *** baojg has quit IRC | 04:08 | |
| *** baojg has joined #openstack-cinder | 04:11 | |
| *** yhayashi has joined #openstack-cinder | 04:25 | |
| *** shyama has joined #openstack-cinder | 04:26 | |
| *** 16WAAR2BV has joined #openstack-cinder | 04:27 | |
| *** baojg has quit IRC | 04:28 | |
| *** cknight has quit IRC | 04:34 | |
| *** baojg has joined #openstack-cinder | 04:39 | |
| *** alonma has joined #openstack-cinder | 04:40 | |
| *** links has joined #openstack-cinder | 04:43 | |
| *** alonma has quit IRC | 04:44 | |
| *** alonma has joined #openstack-cinder | 04:46 | |
| *** gouthamr_ has quit IRC | 04:49 | |
| *** alonma has quit IRC | 04:50 | |
| *** leeantho has quit IRC | 05:00 | |
| *** 16WAAR2BV has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-cinder | 05:01 | |
| *** sheel has joined #openstack-cinder | 05:03 | |
| *** dalgaaf has joined #openstack-cinder | 05:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/275729 | 05:06 |
| *** salv-orlando has joined #openstack-cinder | 05:08 | |
| *** laughter_ has joined #openstack-cinder | 05:12 | |
| *** laughterwym has quit IRC | 05:14 | |
| *** rockeychen has quit IRC | 05:16 | |
| *** rockeychen has joined #openstack-cinder | 05:17 | |
| *** mylu has quit IRC | 05:18 | |
| *** salv-orlando has quit IRC | 05:18 | |
| openstackgerrit | Sheel Rana proposed openstack/cinder: Use of metadata id instead of metadata name https://review.openstack.org/274589 | 05:18 |
| *** mylu has joined #openstack-cinder | 05:19 | |
| *** chhavi has joined #openstack-cinder | 05:29 | |
| *** sheel has quit IRC | 05:38 | |
| *** mylu has quit IRC | 05:41 | |
| *** mylu has joined #openstack-cinder | 05:42 | |
| *** alonma has joined #openstack-cinder | 05:46 | |
| *** merooney has quit IRC | 05:47 | |
| *** sgotliv has joined #openstack-cinder | 05:48 | |
| *** alonma has quit IRC | 05:50 | |
| *** alonma has joined #openstack-cinder | 05:52 | |
| *** qeelee has joined #openstack-cinder | 05:53 | |
| *** alonma has quit IRC | 05:56 | |
| *** alonma has joined #openstack-cinder | 05:59 | |
| *** shyama has quit IRC | 06:00 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** shyama has joined #openstack-cinder | 06:01 | |
| *** haomaiwang has joined #openstack-cinder | 06:01 | |
| *** wanghao has quit IRC | 06:03 | |
| *** wanghao has joined #openstack-cinder | 06:03 | |
| *** shyama has quit IRC | 06:04 | |
| *** shyama has joined #openstack-cinder | 06:05 | |
| *** Poornima has joined #openstack-cinder | 06:09 | |
| *** mylu has quit IRC | 06:18 | |
| *** laughter_ has quit IRC | 06:19 | |
| *** nkrinner has joined #openstack-cinder | 06:19 | |
| *** laughterwym has joined #openstack-cinder | 06:19 | |
| openstackgerrit | zwei proposed openstack/cinder: When volume_backend_name is None Error https://review.openstack.org/272031 | 06:19 |
| openstackgerrit | Merged openstack/cinder: Remove useless unit tests mock in Huawei driver https://review.openstack.org/271594 | 06:19 |
| *** alonma has quit IRC | 06:21 | |
| *** alonma has joined #openstack-cinder | 06:21 | |
| *** alonma has quit IRC | 06:25 | |
| *** esp has joined #openstack-cinder | 06:26 | |
| *** alonma has joined #openstack-cinder | 06:27 | |
| *** ChubYann has quit IRC | 06:30 | |
| *** bardia has joined #openstack-cinder | 06:31 | |
| *** alonma has quit IRC | 06:32 | |
| Poornima | Hi folks please review : https://review.openstack.org/#/c/235752/ | 06:32 |
| *** esp has quit IRC | 06:33 | |
| *** alonma has joined #openstack-cinder | 06:34 | |
| *** sgotliv has quit IRC | 06:35 | |
| *** wanghao has quit IRC | 06:35 | |
| *** wanghao has joined #openstack-cinder | 06:36 | |
| *** alonma has quit IRC | 06:38 | |
| wanghao | Poornima: some nits found inline, please have a look. | 06:40 |
| Poornima | thanks wanghao will fix them | 06:42 |
| Poornima | :) | 06:42 |
| wanghao | Poornima: you're welcome. | 06:42 |
| *** alonma has joined #openstack-cinder | 06:43 | |
| swamireddy | Poornima: patch looks fine. found a few nits. Please check. | 06:45 |
| Poornima | swamireddy, sure thanks :) | 06:46 |
| *** alonma has quit IRC | 06:47 | |
| *** jwcroppe has joined #openstack-cinder | 06:58 | |
| *** sheel has joined #openstack-cinder | 07:00 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-cinder | 07:01 | |
| *** qeelee has quit IRC | 07:01 | |
| *** rockeychen has quit IRC | 07:02 | |
| *** anshul has joined #openstack-cinder | 07:03 | |
| *** sheel has quit IRC | 07:04 | |
| *** links has quit IRC | 07:04 | |
| *** bardia has quit IRC | 07:05 | |
| *** stevemar has joined #openstack-cinder | 07:06 | |
| *** baojg has quit IRC | 07:07 | |
| *** lpetrut has joined #openstack-cinder | 07:08 | |
| *** links has joined #openstack-cinder | 07:14 | |
| *** qeelee has joined #openstack-cinder | 07:15 | |
| *** baojg has joined #openstack-cinder | 07:16 | |
| *** belmoreira has joined #openstack-cinder | 07:29 | |
| *** e0ne has joined #openstack-cinder | 07:30 | |
| *** qeelee has quit IRC | 07:32 | |
| openstackgerrit | wanghao proposed openstack/cinder: Clean up image tmp file if c-vol gets restarted https://review.openstack.org/225081 | 07:37 |
| *** ociuhandu has joined #openstack-cinder | 07:38 | |
| *** alonma has joined #openstack-cinder | 07:43 | |
| *** baojg has quit IRC | 07:45 | |
| *** alonma has quit IRC | 07:47 | |
| *** alonma has joined #openstack-cinder | 07:52 | |
| *** vgridnev has quit IRC | 07:54 | |
| *** baojg has joined #openstack-cinder | 07:56 | |
| *** alonma has quit IRC | 07:56 | |
| *** alonma has joined #openstack-cinder | 07:58 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-cinder | 08:01 | |
| *** alonma has quit IRC | 08:03 | |
| *** alonma has joined #openstack-cinder | 08:05 | |
| *** savihou has joined #openstack-cinder | 08:06 | |
| *** sheel has joined #openstack-cinder | 08:06 | |
| *** Poornima has quit IRC | 08:09 | |
| *** arecknag has joined #openstack-cinder | 08:09 | |
| *** alonma has quit IRC | 08:09 | |
| sheel | ameade: hi | 08:11 |
| *** arecknag has quit IRC | 08:15 | |
| *** arecknag has joined #openstack-cinder | 08:15 | |
| *** alonma has joined #openstack-cinder | 08:15 | |
| *** laughterwym has quit IRC | 08:19 | |
| *** jwcroppe has quit IRC | 08:19 | |
| *** alonma has quit IRC | 08:20 | |
| *** arecknag has quit IRC | 08:21 | |
| *** alonma has joined #openstack-cinder | 08:23 | |
| *** arecknag has joined #openstack-cinder | 08:24 | |
| *** geguileo has joined #openstack-cinder | 08:25 | |
| openstackgerrit | Liucheng Jiang proposed openstack/cinder: Huawei: Implement v2 replication (managed) https://review.openstack.org/261246 | 08:26 |
| *** alonma has quit IRC | 08:27 | |
| *** Poornima has joined #openstack-cinder | 08:29 | |
| *** lpetrut has quit IRC | 08:29 | |
| flip214 | some cores want to help with DRBD, https://review.openstack.org/#/c/276242/ ? | 08:30 |
| *** ildikov has quit IRC | 08:30 | |
| flip214 | only +3 lines, a compat change for newer drbdmanage versions... needed so that I can push other fixes in. | 08:31 |
| *** sgotliv has joined #openstack-cinder | 08:32 | |
| *** salv-orlando has joined #openstack-cinder | 08:45 | |
| *** salv-orlando has quit IRC | 08:49 | |
| *** savihou has quit IRC | 08:49 | |
| *** savihou has joined #openstack-cinder | 08:50 | |
| *** Poornima has quit IRC | 08:50 | |
| *** Poornima has joined #openstack-cinder | 08:51 | |
| *** chlong has quit IRC | 08:52 | |
| *** savihou has quit IRC | 08:52 | |
| *** savihou has joined #openstack-cinder | 08:53 | |
| *** vgridnev has joined #openstack-cinder | 08:58 | |
| *** salv-orlando has joined #openstack-cinder | 09:00 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 09:01 | |
| *** EinstCrazy has quit IRC | 09:01 | |
| *** EinstCrazy has joined #openstack-cinder | 09:02 | |
| openstackgerrit | Merged openstack/cinder: Updated from global requirements https://review.openstack.org/275729 | 09:05 |
| *** yhayashi has quit IRC | 09:07 | |
| *** EinstCrazy has quit IRC | 09:07 | |
| *** baojg has quit IRC | 09:10 | |
| openstackgerrit | chenzongliang proposed openstack/cinder: Huawei: Support huawei consistency group https://review.openstack.org/260930 | 09:13 |
| *** baojg has joined #openstack-cinder | 09:14 | |
| *** openstackgerrit has quit IRC | 09:17 | |
| *** openstackgerrit has joined #openstack-cinder | 09:18 | |
| *** ociuhandu has quit IRC | 09:18 | |
| *** markvoelker has quit IRC | 09:20 | |
| *** jordanP has joined #openstack-cinder | 09:23 | |
| *** alonma has joined #openstack-cinder | 09:24 | |
| *** baojg has quit IRC | 09:25 | |
| openstackgerrit | Jinxing Fang proposed openstack/cinder: Update the home page https://review.openstack.org/276641 | 09:28 |
| *** alonma has quit IRC | 09:28 | |
| *** ildikov has joined #openstack-cinder | 09:28 | |
| *** arch-nemesis has quit IRC | 09:33 | |
| *** stevemar has quit IRC | 09:35 | |
| *** stevemar has joined #openstack-cinder | 09:36 | |
| *** baojg has joined #openstack-cinder | 09:36 | |
| mkoderer | DuncanT: btw I added the unit test in https://review.openstack.org/#/c/276198/ | 09:37 |
| *** stevemar has quit IRC | 09:40 | |
| *** ociuhandu has joined #openstack-cinder | 09:52 | |
| *** boris-42 has joined #openstack-cinder | 09:52 | |
| *** sheel has quit IRC | 09:54 | |
| *** davechen has left #openstack-cinder | 09:55 | |
| *** cheneydc has quit IRC | 09:56 | |
| *** haomaiwa_ has quit IRC | 10:01 | |
| *** mvk has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-cinder | 10:01 | |
| *** ankit_ag has joined #openstack-cinder | 10:08 | |
| *** ociuhandu has quit IRC | 10:08 | |
| *** baojg has quit IRC | 10:14 | |
| *** baojg has joined #openstack-cinder | 10:16 | |
| *** lpetrut has joined #openstack-cinder | 10:17 | |
| *** alonma has joined #openstack-cinder | 10:18 | |
| *** dalgaaf has quit IRC | 10:18 | |
| *** markvoelker has joined #openstack-cinder | 10:21 | |
| *** EinstCrazy has joined #openstack-cinder | 10:22 | |
| *** alonma has quit IRC | 10:22 | |
| *** markvoelker has quit IRC | 10:26 | |
| *** mvk has joined #openstack-cinder | 10:28 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Support for consistency groups in ScaleIO driver https://review.openstack.org/269624 | 10:35 |
| *** EinstCrazy has quit IRC | 10:35 | |
| *** EinstCrazy has joined #openstack-cinder | 10:36 | |
| *** lpetrut has quit IRC | 10:36 | |
| *** stevemar has joined #openstack-cinder | 10:37 | |
| *** salv-orl_ has joined #openstack-cinder | 10:39 | |
| *** stevemar has quit IRC | 10:40 | |
| *** EinstCrazy has quit IRC | 10:40 | |
| *** salv-orlando has quit IRC | 10:42 | |
| *** tpsilva has joined #openstack-cinder | 10:51 | |
| *** dulek has joined #openstack-cinder | 10:52 | |
| *** huanan_L has quit IRC | 10:56 | |
| *** huanan has joined #openstack-cinder | 10:57 | |
| *** e0ne has quit IRC | 10:57 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-cinder | 11:01 | |
| *** geguileo has quit IRC | 11:01 | |
| *** zhonghua has joined #openstack-cinder | 11:09 | |
| *** aagrawal has joined #openstack-cinder | 11:09 | |
| DuncanT | mkoderer: Thanks. Quick question: Shouldn't https://review.openstack.org/#/c/276198/2/cinder/tests/unit/test_hacking.py line 108 be warning about the import of '_'? | 11:12 |
| *** ankit_ag has quit IRC | 11:12 | |
| *** skraynev has quit IRC | 11:12 | |
| *** zhonghua-lee has quit IRC | 11:12 | |
| *** dobson has quit IRC | 11:12 | |
| *** mvk has quit IRC | 11:12 | |
| *** ccesario has quit IRC | 11:12 | |
| *** alonma has joined #openstack-cinder | 11:18 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Manage/unmanage volume in ScaleIO driver https://review.openstack.org/268344 | 11:19 |
| *** Poornima has quit IRC | 11:19 | |
| *** laughterwym has joined #openstack-cinder | 11:20 | |
| *** alonma has quit IRC | 11:22 | |
| openstackgerrit | Matan Sabag proposed openstack/cinder: Support for consistency groups in ScaleIO driver https://review.openstack.org/269624 | 11:24 |
| *** laughterwym has quit IRC | 11:24 | |
| *** mvk has joined #openstack-cinder | 11:24 | |
| *** skraynev has joined #openstack-cinder | 11:24 | |
| *** ccesario has joined #openstack-cinder | 11:25 | |
| *** bkumar has joined #openstack-cinder | 11:25 | |
| *** jwcroppe has joined #openstack-cinder | 11:26 | |
| *** dobson has joined #openstack-cinder | 11:27 | |
| *** alonma has joined #openstack-cinder | 11:28 | |
| *** alonma has quit IRC | 11:32 | |
| *** jwcroppe has quit IRC | 11:32 | |
| *** jwcroppe has joined #openstack-cinder | 11:33 | |
| *** jwcroppe has quit IRC | 11:37 | |
| *** wanghao has quit IRC | 11:43 | |
| *** wanghao has joined #openstack-cinder | 11:45 | |
| *** dims has joined #openstack-cinder | 11:46 | |
| *** baojg has quit IRC | 11:48 | |
| *** ociuhandu has joined #openstack-cinder | 11:51 | |
| *** baojg has joined #openstack-cinder | 11:51 | |
| *** lpetrut has joined #openstack-cinder | 11:53 | |
| *** sgotliv has quit IRC | 11:54 | |
| *** bkumar has quit IRC | 11:55 | |
| *** e0ne has joined #openstack-cinder | 11:55 | |
| *** raildo-afk is now known as raildo | 11:58 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** salv-orl_ has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-cinder | 12:01 | |
| *** thurloat is now known as thurloat_isgone | 12:04 | |
| *** baojg has quit IRC | 12:09 | |
| *** markvoelker has joined #openstack-cinder | 12:22 | |
| *** baojg has joined #openstack-cinder | 12:26 | |
| *** markvoelker has quit IRC | 12:27 | |
| *** alonma has joined #openstack-cinder | 12:28 | |
| *** EinstCrazy has joined #openstack-cinder | 12:29 | |
| *** salv-orlando has joined #openstack-cinder | 12:29 | |
| *** vgridnev has quit IRC | 12:32 | |
| *** alyson_ has quit IRC | 12:32 | |
| *** alonma has quit IRC | 12:33 | |
| *** stevemar has joined #openstack-cinder | 12:35 | |
| *** sinese has joined #openstack-cinder | 12:35 | |
| *** vgridnev has joined #openstack-cinder | 12:36 | |
| *** EinstCrazy has quit IRC | 12:36 | |
| *** alonma has joined #openstack-cinder | 12:37 | |
| *** stevemar has quit IRC | 12:38 | |
| *** baojg has quit IRC | 12:39 | |
| *** alonma has quit IRC | 12:41 | |
| *** links has quit IRC | 12:43 | |
| *** baojg has joined #openstack-cinder | 12:44 | |
| *** savihou has quit IRC | 12:44 | |
| *** laughterwym has joined #openstack-cinder | 12:46 | |
| *** baojg has quit IRC | 12:47 | |
| *** mtanino has joined #openstack-cinder | 12:50 | |
| *** smoriya_ has quit IRC | 12:54 | |
| *** erlon has joined #openstack-cinder | 12:56 | |
| *** sinese_ has joined #openstack-cinder | 13:00 | |
| *** haomaiwang has quit IRC | 13:01 | |
| *** krotscheck has joined #openstack-cinder | 13:01 | |
| *** laughterwym has quit IRC | 13:01 | |
| *** haomaiwang has joined #openstack-cinder | 13:01 | |
| *** sinese has quit IRC | 13:01 | |
| *** laughterwym has joined #openstack-cinder | 13:01 | |
| *** baojg has joined #openstack-cinder | 13:02 | |
| *** laughterwym has quit IRC | 13:06 | |
| *** esp has joined #openstack-cinder | 13:12 | |
| *** salv-orlando has quit IRC | 13:13 | |
| *** laughterwym has joined #openstack-cinder | 13:13 | |
| *** aagrawal has quit IRC | 13:14 | |
| *** akerr has joined #openstack-cinder | 13:15 | |
| *** markvoelker has joined #openstack-cinder | 13:22 | |
| *** boris-42 has quit IRC | 13:23 | |
| *** thurloat_isgone is now known as thurloat | 13:24 | |
| *** markvoelker_ has joined #openstack-cinder | 13:24 | |
| *** markvoelker has quit IRC | 13:24 | |
| *** esp has quit IRC | 13:27 | |
| *** xyang1 has joined #openstack-cinder | 13:30 | |
| *** edmondsw has joined #openstack-cinder | 13:34 | |
| *** takedakn has joined #openstack-cinder | 13:34 | |
| *** alonma has joined #openstack-cinder | 13:37 | |
| *** fthiagogv_ has quit IRC | 13:38 | |
| *** fthiagogv has joined #openstack-cinder | 13:39 | |
| mtanino | DuncanT: hi, are you there? | 13:40 |
| *** diablo_rojo has joined #openstack-cinder | 13:40 | |
| *** alonma has quit IRC | 13:41 | |
| *** laughterwym has quit IRC | 13:42 | |
| *** laughterwym has joined #openstack-cinder | 13:43 | |
| mtanino | DuncanT: If you have a chance, please revisit glance metadata support? https://review.openstack.org/#/c/258649/ | 13:45 |
| *** laughterwym has quit IRC | 13:47 | |
| *** laughterwym has joined #openstack-cinder | 13:49 | |
| *** gouthamr has joined #openstack-cinder | 13:51 | |
| *** timcl has joined #openstack-cinder | 13:51 | |
| *** jwang_ has joined #openstack-cinder | 13:53 | |
| *** julim has joined #openstack-cinder | 13:54 | |
| *** gouthamr has quit IRC | 13:55 | |
| *** geguileo has joined #openstack-cinder | 13:56 | |
| *** jwang__ has quit IRC | 13:57 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Update initialize_connection to use versionedobjects https://review.openstack.org/238894 | 13:58 |
| *** eharney has joined #openstack-cinder | 13:59 | |
| *** takedakn has quit IRC | 14:00 | |
| *** laughterwym has quit IRC | 14:00 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** laughterwym has joined #openstack-cinder | 14:01 | |
| *** haomaiwang has joined #openstack-cinder | 14:01 | |
| scottda | e0ne: Can you ping me when you have a couple minutes? | 14:03 |
| *** sheel has joined #openstack-cinder | 14:04 | |
| *** laughterwym has quit IRC | 14:06 | |
| e0ne | scottda: hi | 14:09 |
| scottda | e0ne: Hi. I've added /v3 endpoint to microversions https://review.openstack.org/#/c/224910/17 | 14:09 |
| scottda | The unit tests pass on my workstation, but they are failing in Jenkins... | 14:10 |
| scottda | I've fixed one problem (I think) by looking at the code. There is one other issue that I am not sure about. | 14:10 |
| openstackgerrit | Szymon Borkowski proposed openstack/cinder: Fix for glance_metadata during volume migration https://review.openstack.org/276747 | 14:10 |
| scottda | I was wondering if you had any ideas why tests can pass for me but not for Jenkins? | 14:10 |
| *** rlrossit has joined #openstack-cinder | 14:11 | |
| *** sinese_ has quit IRC | 14:11 | |
| scottda | IF you get some time, let me know, I can show you some details. | 14:12 |
| *** sinese_ has joined #openstack-cinder | 14:12 | |
| *** sinese_ has quit IRC | 14:12 | |
| *** takedakn has joined #openstack-cinder | 14:12 | |
| *** sinese_ has joined #openstack-cinder | 14:12 | |
| *** sinese_ has quit IRC | 14:12 | |
| *** sgotliv has joined #openstack-cinder | 14:13 | |
| e0ne | scottda: why do we want api v3 now? | 14:13 |
| scottda | We discussed this at the midcycle... | 14:13 |
| scottda | For microversions, we want it to be explicit that the user is connecting to a new endpoint.... | 14:13 |
| *** salv-orlando has joined #openstack-cinder | 14:13 | |
| e0ne | scottda: I'm sorry, I've missed the decision:(. my fail | 14:13 |
| scottda | Otherwise, a newer client might request a microversion and expect new behavior.... | 14:14 |
| e0ne | it makes sense | 14:14 |
| scottda | and if it is an older server, it will fail silently | 14:14 |
| scottda | New /v3 would start identical to /v2 and change as microversions are added. | 14:14 |
| scottda | So I've attempted to add /v3 code, and basic testing works, so do my workstation unit tests. But there are problems with Jenkins and CI | 14:15 |
| scottda | I thought you had a lot of expertise with your work to deprecate /v1 (not abandonede?) and unit tests, etc. | 14:15 |
| *** mkoderer__ has quit IRC | 14:16 | |
| e0ne | did you change a defaule version to v3 in your code? | 14:17 |
| e0ne | or did you create any new keystone endpoints on your env? | 14:17 |
| *** mkoderer__ has joined #openstack-cinder | 14:17 | |
| e0ne | scottda: looks like openstack client can't work with your changes to the api | 14:19 |
| scottda | I did not set any default here: https://review.openstack.org/#/c/224910/17/cinder/common/config.py | 14:19 |
| *** merooney has joined #openstack-cinder | 14:19 | |
| scottda | Does Jenkins use OSC? | 14:19 |
| e0ne | so, you disabled all APIs by default :) | 14:19 |
| e0ne | scottda: yes, it uses only OSC during devstack setup | 14:20 |
| scottda | OK, that would explain some of the failures | 14:20 |
| e0ne | scottda: you have to enable APIv2 at least | 14:20 |
| e0ne | but I'm pretty sure that some tempest tests still uses APIv1 too | 14:20 |
| *** porrua has joined #openstack-cinder | 14:22 | |
| *** baojg has quit IRC | 14:22 | |
| scottda | I did not disable /v1 or /v2. At least they both work on my workstation. | 14:22 |
| *** nkrinner has quit IRC | 14:24 | |
| *** haomaiwang has quit IRC | 14:24 | |
| e0ne | hm... | 14:24 |
| e0ne | enable_v2_api=False | 14:24 |
| e0ne | and there is no overrides in config: http://logs.openstack.org/10/224910/18/check/gate-tempest-dsvm-full/2cf9501/logs/etc/cinder/cinder.conf.txt.gz | 14:25 |
| *** raildo is now known as raildo-afk | 14:25 | |
| e0ne | oh! got it! you've changed https://review.openstack.org/#/c/224910/18/cinder/api/__init__.py | 14:26 |
| e0ne | not sure how it works now:( | 14:26 |
| e0ne | http://logs.openstack.org/10/224910/18/check/gate-tempest-dsvm-full/2cf9501/logs/screen-c-api.txt.gz - your c-api didn't started | 14:27 |
| *** baojg has joined #openstack-cinder | 14:29 | |
| e0ne | scottda: https://review.openstack.org/#/c/224910/18/cinder/api/v3/volumes.py - IMO, it's a root cause of failures | 14:30 |
| *** salv-orlando has quit IRC | 14:30 | |
| *** lprice has quit IRC | 14:30 | |
| e0ne | scottda: both for tempest and "unit"-tests | 14:30 |
| *** takedakn has quit IRC | 14:31 | |
| scottda | OK, yes. I saw that and fixed it locally, so I figured that would solve many of the unit tests failures.... | 14:31 |
| scottda | like these: | 14:32 |
| scottda | https://www.irccloud.com/pastebin/Rw7XrB3S/ | 14:32 |
| *** arecknag has quit IRC | 14:33 | |
| openstackgerrit | Merged openstack/cinder-specs: Support query volume filter by glance metadata https://review.openstack.org/174778 | 14:33 |
| scottda | e0ne: I've made this change: | 14:33 |
| scottda | https://www.irccloud.com/pastebin/FC7lzXRA/ | 14:34 |
| scottda | The troublesome thing is that I cannot repro the issues locally, so I cannot test this (or any other) fix. | 14:35 |
| *** alaski is now known as lascii | 14:35 | |
| scottda | e0ne: If you think that fix will solve most of the problems, I can push it up and see. I just wish I could test before doing that. | 14:35 |
| scottda | e0ne: I also added a dependency for Grenade to update api-paste.ini with the new endpoint info: https://review.openstack.org/#/c/276505/ | 14:36 |
| *** thangp has joined #openstack-cinder | 14:37 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Storwize: Implement v2 replication https://review.openstack.org/237387 | 14:37 |
| *** alonma has joined #openstack-cinder | 14:37 | |
| *** dustins has joined #openstack-cinder | 14:39 | |
| *** xyang1 has quit IRC | 14:41 | |
| *** alonma has quit IRC | 14:41 | |
| sheel | Dear Core members: Please have a look at | 14:42 |
| sheel | 1. https://review.openstack.org/#/c/272229/ (final +2 required) | 14:42 |
| sheel | 2. https://review.openstack.org/#/c/272232/ (final +2 required), | 14:42 |
| sheel | 3. https://review.openstack.org/#/c/274589/ | 14:42 |
| *** jgregor has joined #openstack-cinder | 14:42 | |
| *** baojg has quit IRC | 14:43 | |
| e0ne | scottda: AFIAK, cinder/opts.py is used only for config generator | 14:43 |
| scottda | e0ne: Are you saying that the patch above is not a fix for the query_volume_filters being registered twice? | 14:44 |
| diablo_rojo | e0ne: scottda that is correct. It is only used for the config generator to generate the sample config opt file | 14:45 |
| e0ne | scottda: yes, if I didn't miss anything | 14:45 |
| e0ne | eharney: hi! I've answered your comments. | 14:45 |
| *** bkumar has joined #openstack-cinder | 14:45 | |
| e0ne | eharney: what is the isssue with osprofiler? | 14:45 |
| eharney | e0ne: that's what we determined was breaking this yesterday | 14:46 |
| smcginnis | e0ne: staticmethod is fine, osprofiler doesn't decorate it right. | 14:46 |
| *** baojg has joined #openstack-cinder | 14:46 | |
| smcginnis | https://bugs.launchpad.net/osprofiler/+bug/1440027 | 14:46 |
| openstack | Launchpad bug 1440027 in osprofiler "osprofiler is Incompatibe with staticmethod within a class" [Undecided,New] | 14:46 |
| e0ne | thanks! I'll ask about is to osprofiler team | 14:46 |
| smcginnis | I've just proposed a requirements change: https://review.openstack.org/276761 | 14:47 |
| *** alonma has joined #openstack-cinder | 14:47 | |
| scottda | hmm...OK, my bad. e0ne I reckon I should remove it from here: | 14:47 |
| scottda | cinder/api/v2/volumes.py:CONF.register_opt(query_volume_filters_opt) | 14:47 |
| e0ne | scottda: yes. it should help | 14:47 |
| smcginnis | I'm behind removing the staticmethod as a workaround, mainly to get my CI to stop failing. ;) | 14:47 |
| smcginnis | But there are many places in the code where we have static methods. | 14:47 |
| e0ne | scottda: or may be move it to some more general place | 14:47 |
| smcginnis | So this will likely fail somewhere else as well. | 14:47 |
| eharney | did anyone make sure it's not going to just fail on another test? | 14:47 |
| smcginnis | eharney: I'm pretty confident it will, so this just works around a specific case. | 14:48 |
| e0ne | smcginnis: sometimes, we use staticmethods where it's not needed | 14:48 |
| smcginnis | The reality is, we either need osprofiler fixed or we need to rollback to pre-1.0.0 | 14:48 |
| smcginnis | e0ne: That's a language theory argument. :) | 14:48 |
| eharney | e0ne: that's the sentiment i can't really understand here | 14:49 |
| smcginnis | e0ne: It is definitely used correctly. | 14:49 |
| scottda | e0ne: any thoughts on a better place to register query_volume_filters_opt ? | 14:49 |
| eharney | i mean, most of python is not "needed", it's there to help us produce better code | 14:49 |
| e0ne | smcginnis, eharney: I don't want to debate on it becase looks like only me thinks that we've got not readable code there. probably, I have to abandone that patch | 14:50 |
| e0ne | eharney: I prefer to use simple functions without classes where possible. but it's only IMHO | 14:51 |
| smcginnis | e0ne: Maybe. It was very useful though. It definitely helped validate that that was the cause of the failure. | 14:51 |
| *** alonma has quit IRC | 14:51 | |
| *** cknight has joined #openstack-cinder | 14:52 | |
| e0ne | scottda: maybe cinder/common/config.py | 14:52 |
| e0ne | scottda: or cinder/api/common.py | 14:52 |
| e0ne | scottda: the second one looks better for me | 14:52 |
| flip214 | e0ne: smcginnis: thank you very much for your help! | 14:53 |
| smcginnis | flip214: np | 14:53 |
| e0ne | flip214: you're welcome! | 14:54 |
| *** bkumar4 has joined #openstack-cinder | 14:54 | |
| *** esp has joined #openstack-cinder | 14:54 | |
| scottda | e0ne: I'll move it. Thanks a lot for all the help! | 14:55 |
| e0ne | scottda: np. I'm glad to be useful:) | 14:56 |
| *** jordanP has quit IRC | 14:56 | |
| *** bkumar has quit IRC | 14:56 | |
| *** mriedem has joined #openstack-cinder | 14:57 | |
| e0ne | smcginnis: I'm sorry, -1 with a question to your patch | 14:57 |
| smcginnis | e0ne: Thanks! My mistake. | 14:58 |
| *** haomaiwang has joined #openstack-cinder | 14:59 | |
| *** crose has joined #openstack-cinder | 14:59 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** edtubill has joined #openstack-cinder | 15:03 | |
| *** esp has quit IRC | 15:05 | |
| *** anshul has quit IRC | 15:06 | |
| diablo_rojo | scottda: Cadillac Cadillac.. | 15:11 |
| *** dguryanov has quit IRC | 15:12 | |
| diablo_rojo | How do you rerun only the unit tests that failed again? | 15:16 |
| smcginnis | diablo_rojo: Running tests locally? | 15:16 |
| diablo_rojo | smcginnis: Correct | 15:16 |
| sheel | tox -epy27 -- --no-discover test_case_location | 15:17 |
| smcginnis | sheel: Quicker than me. ;) | 15:17 |
| sheel | smcginnis: i was running this on my local just now | 15:18 |
| smcginnis | diablo_rojo: Some details here: https://github.com/openstack/cinder/blob/master/doc/source/devref/unit_tests.rst | 15:18 |
| diablo_rojo | smcginnis: sheel Thank you :) | 15:18 |
| sheel | diablo_rojo: happy to help.. welcome | 15:19 |
| *** baojg has quit IRC | 15:19 | |
| *** ildikov has quit IRC | 15:20 | |
| *** xyang1 has joined #openstack-cinder | 15:24 | |
| *** bkumar4 has quit IRC | 15:25 | |
| *** baojg has joined #openstack-cinder | 15:25 | |
| *** bkumar4 has joined #openstack-cinder | 15:25 | |
| *** esker has quit IRC | 15:26 | |
| openstackgerrit | Alex Meade proposed openstack/cinder-specs: User facing error messages https://review.openstack.org/274958 | 15:26 |
| *** esker has joined #openstack-cinder | 15:26 | |
| *** baumann has joined #openstack-cinder | 15:28 | |
| scottda | diablo_rojo: I'm not sure what to have for lunch, ham sandwich? | 15:28 |
| *** timcl has quit IRC | 15:30 | |
| *** xyang has joined #openstack-cinder | 15:30 | |
| diablo_rojo | scottda: Only if you can clap with no hands | 15:31 |
| *** jwcroppe has joined #openstack-cinder | 15:31 | |
| *** eharney has quit IRC | 15:33 | |
| *** haomaiwang has joined #openstack-cinder | 15:33 | |
| *** xyang has quit IRC | 15:36 | |
| *** timcl has joined #openstack-cinder | 15:40 | |
| *** arch-nemesis has joined #openstack-cinder | 15:42 | |
| *** sgotliv has quit IRC | 15:46 | |
| *** alonma has joined #openstack-cinder | 15:47 | |
| *** david-lyle has joined #openstack-cinder | 15:47 | |
| *** sgotliv has joined #openstack-cinder | 15:47 | |
| *** mragupat has joined #openstack-cinder | 15:48 | |
| *** sinese has joined #openstack-cinder | 15:49 | |
| *** bkumar4 has quit IRC | 15:50 | |
| *** jungleboyj has joined #openstack-cinder | 15:51 | |
| *** alonma has quit IRC | 15:52 | |
| *** merooney has quit IRC | 15:53 | |
| *** merooney has joined #openstack-cinder | 15:54 | |
| *** mgarza has joined #openstack-cinder | 15:55 | |
| *** thurloat is now known as thurloat_isgone | 15:56 | |
| *** nkrinner has joined #openstack-cinder | 15:57 | |
| *** jdurgin1 has joined #openstack-cinder | 15:59 | |
| *** tongli has quit IRC | 16:00 | |
| *** logan_ has joined #openstack-cinder | 16:00 | |
| *** logan_ is now known as Guest78654 | 16:01 | |
| *** haomaiw__ has joined #openstack-cinder | 16:01 | |
| *** logan- has quit IRC | 16:01 | |
| *** haomaiwang has quit IRC | 16:02 | |
| *** baojg has quit IRC | 16:02 | |
| *** tongli has joined #openstack-cinder | 16:02 | |
| *** TheJulia_ has joined #openstack-cinder | 16:02 | |
| *** Guest78654 is now known as logan- | 16:02 | |
| *** sinese_ has joined #openstack-cinder | 16:02 | |
| *** aarefiev_ has joined #openstack-cinder | 16:03 | |
| *** frakt_ has joined #openstack-cinder | 16:03 | |
| *** TheJulia has quit IRC | 16:04 | |
| *** fernnest__ has joined #openstack-cinder | 16:04 | |
| *** cburgess_ has joined #openstack-cinder | 16:05 | |
| *** TheJulia_ is now known as TheJulia | 16:05 | |
| *** sinese_ is now known as sinise | 16:08 | |
| *** akerr_ has joined #openstack-cinder | 16:08 | |
| *** pratap_ has joined #openstack-cinder | 16:08 | |
| *** belmoreira has quit IRC | 16:13 | |
| *** sinese has quit IRC | 16:14 | |
| *** akerr has quit IRC | 16:14 | |
| *** fernnest_ has quit IRC | 16:14 | |
| *** frakt has quit IRC | 16:14 | |
| *** pratap has quit IRC | 16:14 | |
| *** cburgess has quit IRC | 16:14 | |
| *** aarefiev has quit IRC | 16:14 | |
| *** Kimmo_ has quit IRC | 16:14 | |
| *** sinise has quit IRC | 16:16 | |
| *** baojg has joined #openstack-cinder | 16:17 | |
| *** xyang has joined #openstack-cinder | 16:19 | |
| *** vgridnev has quit IRC | 16:19 | |
| *** david-lyle has quit IRC | 16:23 | |
| *** garthb has joined #openstack-cinder | 16:24 | |
| jungleboyj | ameade: You around? | 16:25 |
| *** merooney has quit IRC | 16:27 | |
| *** raildo-afk is now known as raildo | 16:27 | |
| *** timcl has quit IRC | 16:27 | |
| ameade | jungleboyj: yesish | 16:28 |
| ameade | what's up? | 16:28 |
| jungleboyj | ameade: Just wanted to check on a couple of things w/r/t the cDOT driver. | 16:28 |
| *** david-lyle has joined #openstack-cinder | 16:29 | |
| *** baojg has quit IRC | 16:29 | |
| ameade | jungleboyj: shoot :) | 16:30 |
| jungleboyj | ameade: Are you guys going to be able to get replication in at the FlexVol level for Mitaka? | 16:30 |
| ameade | jungleboyj: no not for mitaka | 16:30 |
| jungleboyj | ameade: Doh! I thought you guys were going to have that in. | 16:32 |
| *** baojg has joined #openstack-cinder | 16:33 | |
| ameade | jungleboyj: :/ | 16:33 |
| ameade | tight resources atm | 16:33 |
| *** mragupat has quit IRC | 16:34 | |
| ameade | we will have it in our manila cdot driver :) :P | 16:34 |
| jungleboyj | ameade: :-( Ok, you did get the QoS changes that IBM was looking for addressed though. Right? | 16:34 |
| *** mragupat has joined #openstack-cinder | 16:34 | |
| *** tongli has quit IRC | 16:35 | |
| ameade | jungleboyj: for the most part, not upstream yet | 16:35 |
| jungleboyj | ameade: SoftLayer has code though. Right? | 16:35 |
| ameade | jungleboyj: yes | 16:36 |
| jungleboyj | ameade: Is that code against Liberty then? | 16:36 |
| ameade | yeah | 16:36 |
| *** e0ne has quit IRC | 16:37 | |
| ameade | i should double check we have a bp for this "maxIOPSperGB" | 16:37 |
| jungleboyj | ameade: That would be good. | 16:39 |
| jungleboyj | ameade: Still planning to get replication for cDOT into Newton but it will be at the flexvol level? | 16:39 |
| *** baojg has quit IRC | 16:41 | |
| ameade | jungleboyj: I believe that to be one of our big priorities for Newton | 16:42 |
| jungleboyj | ameade: Ok. Thanks. Have a PM in my ear needing info. | 16:42 |
| ameade | jungleboyj: haha yep, totally get that | 16:42 |
| jungleboyj | :-) | 16:43 |
| ameade | jungleboyj: heres this btw: https://blueprints.launchpad.net/cinder/+spec/add-variable-qos-to-netapp-cdot-drivers | 16:43 |
| *** baojg has joined #openstack-cinder | 16:44 | |
| jungleboyj | ameade: Thank you. | 16:47 |
| hemna | looks like gorka's Remove API races * patches are all merge conflicted now | 16:49 |
| hemna | :( | 16:49 |
| jungleboyj | I feel very conflicted about that. | 16:52 |
| *** e0ne has joined #openstack-cinder | 16:52 | |
| *** baojg has quit IRC | 16:53 | |
| *** dulek has quit IRC | 16:56 | |
| *** crose has quit IRC | 16:57 | |
| *** haomaiw__ has quit IRC | 17:01 | |
| *** haomaiwang has joined #openstack-cinder | 17:01 | |
| *** bluex has quit IRC | 17:01 | |
| jungleboyj | ameade: If you can keep me in the loop on those patches I can maybe keep other IBMers off your back. ;-) | 17:02 |
| *** crose has joined #openstack-cinder | 17:03 | |
| *** stevemar has joined #openstack-cinder | 17:03 | |
| *** ildikov has joined #openstack-cinder | 17:10 | |
| *** timcl has joined #openstack-cinder | 17:13 | |
| *** tongli has joined #openstack-cinder | 17:14 | |
| *** david-lyle has quit IRC | 17:14 | |
| *** stevemar has quit IRC | 17:17 | |
| *** stevemar has joined #openstack-cinder | 17:18 | |
| e0ne | smcginnis, hemna: could you please review https://review.openstack.org/#/c/265811/ - Introduce functional tests for python-brick-cinderclient-ext | 17:21 |
| *** david-lyle has joined #openstack-cinder | 17:21 | |
| *** leeantho has joined #openstack-cinder | 17:22 | |
| *** stevemar has quit IRC | 17:22 | |
| openstackgerrit | Anthony Lee proposed openstack/cinder: LeftHand: Implement un/manage snapshot support https://review.openstack.org/255015 | 17:23 |
| *** david-lyle has quit IRC | 17:25 | |
| mc_nair | has anyone run into the issue of trying to access a config option before the config file has been loaded, so the config value is set to the default instead of what's specified in cinder.conf? | 17:28 |
| mc_nair | it's got me pretty stumped right now | 17:29 |
| *** mudassirlatif has joined #openstack-cinder | 17:30 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Update db in CGSnapshot create https://review.openstack.org/271054 | 17:30 |
| *** mriedem is now known as mriedem_afk | 17:31 | |
| *** vgridnev has joined #openstack-cinder | 17:31 | |
| *** apoorvad has joined #openstack-cinder | 17:33 | |
| sheel | mc_nair: If I got your point right, you want to set some default value even before start of cinder services(config value are loaded during start up) | 17:34 |
| sheel | mc_nair: or you have some other use case? | 17:35 |
| *** alonma has joined #openstack-cinder | 17:35 | |
| mc_nair | sheel: so the issue I'm having I think boils down to the fact that QuotaEngine globally (https://github.com/openstack/cinder/blob/master/cinder/quota.py#L969) so when we get to QuotaEngine's __init__ I don't think the config values are loaded yet | 17:35 |
| mc_nair | so this check isn't working https://github.com/openstack/cinder/blob/master/cinder/quota.py#L629 | 17:36 |
| mc_nair | e.g. http://paste.openstack.org/show/486120/ | 17:36 |
| mc_nair | sheel: but I think you've got the crux of the problem | 17:36 |
| sheel | mc_nair: hm..so why you want to init these values...are you going to use these globally somewhere... | 17:39 |
| sheel | mc_nair: even before any quota call... | 17:39 |
| sheel | mc_nair: I am aksing these many question as have less idea about quota working.. | 17:40 |
| *** alonma has quit IRC | 17:40 | |
| *** alonma has joined #openstack-cinder | 17:41 | |
| mc_nair | sheel: fair question. So basically the way the quota code currently works is there's a QuotaEngine which has a QuotaDriver that it uses. There's existing code in QuotaEngine startup *tries* to look a config for which quota_driver to use, instantiates it, and will use it for all the rest of the quota calls | 17:42 |
| mc_nair | sheel: but currently we instantiate the QuotaEngines immediately when quota.py is loaded - https://github.com/openstack/cinder/blob/master/cinder/quota.py#L969 | 17:43 |
| mc_nair | sheel: so at that point, I *think* the QuotaEngine is always saying "What driver should I use?", but it's always the default config value because CONF hasn't been loaded yet | 17:44 |
| *** eharney has joined #openstack-cinder | 17:45 | |
| *** alonma has quit IRC | 17:45 | |
| sheel | mc_nair: may be its ok to set some default value for time being | 17:48 |
| *** alonma has joined #openstack-cinder | 17:48 | |
| sheel | mc_nair: and get this loaded from config later during quota call | 17:48 |
| mc_nair | sheel: yea, but I guess then we'd need to be re-loading the QuotaDriver (or at least do a check for it) on a quota call with isn't great | 17:49 |
| sheel | mc_nair: hmm right | 17:50 |
| mc_nair | sheel: but I think you're on the right track... maybe we need to change when the QuotaEngine gets initialized | 17:50 |
| mc_nair | sheel: I just was hoping there'd be an easy way to say "Load config, now!!" and then I could use the existing code that's in there :/ | 17:50 |
| *** e0ne has quit IRC | 17:51 | |
| sheel | mc_nair: haha ... | 17:51 |
| sheel | mc_nair: I will check if there is something around for solving this...will ping you in case got success. | 17:52 |
| *** alonma has quit IRC | 17:52 | |
| sheel | mc_nair: will see if some code tweak is possible.. | 17:53 |
| openstackgerrit | Sean McGinnis proposed openstack/cinder: WIP: Add in-tree tempest tests https://review.openstack.org/274471 | 17:55 |
| *** alonma has joined #openstack-cinder | 17:55 | |
| mc_nair | sheel: that would be awesome. I'll poke around see if there's any simple things that would push the QuotaEngine instantiation later | 17:55 |
| *** salv-orlando has joined #openstack-cinder | 17:55 | |
| sheel | mc_nair: yup.. | 17:55 |
| Swanson | Re replication v2.1 : After failover how do I know I'm in a failover state? If I am failed over but I have non replicated volumes should I try to use them on the failed backend? | 17:56 |
| *** chhavi has quit IRC | 17:56 | |
| *** gouthamr has joined #openstack-cinder | 17:59 | |
| *** alonma has quit IRC | 17:59 | |
| *** yuriy_n17 has quit IRC | 17:59 | |
| *** chhavi has joined #openstack-cinder | 18:00 | |
| *** haomaiwang has quit IRC | 18:01 | |
| *** 77CAAFNN9 has joined #openstack-cinder | 18:01 | |
| *** alonma has joined #openstack-cinder | 18:02 | |
| *** Kimmo_ has joined #openstack-cinder | 18:03 | |
| openstackgerrit | Apoorva Deshpande proposed openstack/cinder: Tintri image direct clone https://review.openstack.org/261126 | 18:05 |
| *** crose has quit IRC | 18:06 | |
| *** alonma has quit IRC | 18:07 | |
| *** vgridnev has quit IRC | 18:07 | |
| *** alonma has joined #openstack-cinder | 18:08 | |
| *** mvk has quit IRC | 18:09 | |
| *** lpetrut has quit IRC | 18:11 | |
| *** alonma has quit IRC | 18:13 | |
| *** dansmith is now known as superdan | 18:16 | |
| mtanino | jgriffith_away: If you have a chance, could you give your opinion for LIO target problem? https://review.openstack.org/#/c/271424/3 | 18:19 |
| *** jkraj has joined #openstack-cinder | 18:22 | |
| *** stevemar has joined #openstack-cinder | 18:25 | |
| *** liverpooler has joined #openstack-cinder | 18:27 | |
| *** liverpoo1er has joined #openstack-cinder | 18:28 | |
| *** dims is now known as dimsum__ | 18:30 | |
| *** shyama has quit IRC | 18:30 | |
| *** ociuhandu has quit IRC | 18:36 | |
| *** sgotliv has quit IRC | 18:43 | |
| *** angela-s has joined #openstack-cinder | 18:44 | |
| *** geguileo has quit IRC | 18:45 | |
| *** xyang has quit IRC | 18:45 | |
| *** mylu has joined #openstack-cinder | 18:47 | |
| *** bardia has joined #openstack-cinder | 18:48 | |
| *** e0ne has joined #openstack-cinder | 18:50 | |
| *** xyang has joined #openstack-cinder | 18:51 | |
| *** mylu has quit IRC | 18:52 | |
| *** lpetrut has joined #openstack-cinder | 18:54 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/python-brick-cinderclient-ext: Introduce functional tests for python-brick-cinderclient-ext https://review.openstack.org/265811 | 18:55 |
| *** vgridnev has joined #openstack-cinder | 18:55 | |
| *** mylu has joined #openstack-cinder | 18:55 | |
| *** 77CAAFNN9 has quit IRC | 19:01 | |
| *** ociuhandu has joined #openstack-cinder | 19:01 | |
| *** mylu has quit IRC | 19:01 | |
| *** haomaiwang has joined #openstack-cinder | 19:01 | |
| hemna | huh ok | 19:03 |
| hemna | so it looks like nova doesn't use os-brick for nfs | 19:03 |
| * hemna has a sad | 19:03 | |
| *** mylu has joined #openstack-cinder | 19:03 | |
| patrickeast | hemna: that would make way too much sense | 19:04 |
| *** chhavi has quit IRC | 19:06 | |
| *** vgridnev has quit IRC | 19:06 | |
| hemna | and...the cinder nfs driver has it's own copy_volume_to_image | 19:07 |
| hemna | that doesn't use os-brick | 19:07 |
| hemna | so....the brick remotefs connector isn't used. | 19:07 |
| smcginnis | :/ | 19:07 |
| hemna | afaik | 19:07 |
| hemna | boo | 19:07 |
| hemna | shite | 19:07 |
| hemna | I have no way to test the remotefs privsep code :(!!! | 19:08 |
| hemna | shitballs | 19:08 |
| patrickeast | well if no one is using it.... does it need to work? :P | 19:08 |
| openstackgerrit | Anthony Lee proposed openstack/os-brick: Fix output returned from get_all_available_volumes https://review.openstack.org/276876 | 19:08 |
| hemna | hehe | 19:08 |
| hemna | I wonder | 19:09 |
| *** alonma has joined #openstack-cinder | 19:09 | |
| hemna | if I can use e0ne's attach w/o nova patch to cinderclient | 19:09 |
| e0ne | hemna: you can | 19:09 |
| e0ne | hemna: that's why I'm using umount directly in my code:( | 19:09 |
| hemna | I think that's the only way to excercize this | 19:10 |
| hemna | and there is no CI for it | 19:10 |
| e0ne | hemna: now, I'm feeling OK to modify disconnect_volume for NFS connector | 19:10 |
| hemna | https://review.openstack.org/#/c/258252/ | 19:10 |
| hemna | that guy | 19:10 |
| hemna | I wanted to get that tested | 19:10 |
| hemna | to land | 19:10 |
| hemna | as a blueprint of how to migrate iSCSI and FC | 19:11 |
| e0ne | CI will be once we merge https://review.openstack.org/265811 | 19:11 |
| e0ne | I'm not sure that we need functional tests for os-brick too | 19:11 |
| hemna | e0ne, do you have the url for your cinderclient patch handy? | 19:11 |
| hemna | maybe I can try that real quick on my same VM that I have nfs setup | 19:11 |
| e0ne | https://review.openstack.org/263744 | 19:11 |
| e0ne | it's a bit hacky, so still in WIP | 19:12 |
| hemna | ok | 19:12 |
| e0ne | I have to use rootwrap or privsep to remove hacks | 19:12 |
| e0ne | :( | 19:12 |
| hemna | ok I have the repo cloned and that patch pulled | 19:13 |
| hemna | pip install . ? | 19:13 |
| hemna | is that sufficient for cinderclient to get it ? | 19:13 |
| e0ne | yes, you need "pip install ." for the extension | 19:14 |
| *** nkrinner has quit IRC | 19:14 | |
| e0ne | oops | 19:14 |
| hemna | ok | 19:14 |
| hemna | cinder local-attach .... | 19:14 |
| e0ne | the lastes patch doesn't support nfs | 19:14 |
| hemna | bah | 19:14 |
| hemna | FACK! | 19:14 |
| e0ne | patch #8 does: https://review.openstack.org/#/c/263744/8/brick_cinderclient_ext/client.py | 19:15 |
| *** alonma has quit IRC | 19:15 | |
| eharney | is any of this brick connector code related to NFS accounting for it using files that aren't raw-formatted? | 19:17 |
| *** alonma has joined #openstack-cinder | 19:17 | |
| hemna | eharney, I can't find where the remotefs connector is used | 19:17 |
| hemna | :( | 19:17 |
| hemna | the cinder nfs driver doesn't seem to use it | 19:17 |
| hemna | and nova doesn't seem to use it. | 19:17 |
| e0ne | :( | 19:18 |
| e0ne | I use it in brickclient | 19:18 |
| hemna | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L392-L428 | 19:18 |
| hemna | that doesn't use it. | 19:18 |
| e0ne | wft | 19:18 |
| eharney | why is this a wtf, this code has been around forever | 19:19 |
| hemna | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/nfs.py#L58-L63 | 19:20 |
| *** stevemar has quit IRC | 19:20 | |
| hemna | doesn't use it. | 19:20 |
| hemna | so....the remotefs connector isn't used afaik | 19:20 |
| hemna | :( | 19:20 |
| hemna | smh | 19:20 |
| *** stevemar has joined #openstack-cinder | 19:20 | |
| e0ne | because this copy_volume_to_image code in drivers is very similar, sometimes even copy-pasted | 19:21 |
| hemna | yah | 19:21 |
| hemna | some drivers have to do 'special' stuffs | 19:21 |
| e0ne | we have to move it to manager/base driver where it's possible | 19:21 |
| *** alonma has quit IRC | 19:21 | |
| e0ne | the question: | 19:21 |
| e0ne | how many drivers implement copy_volume_to_image using this code: image_utils.upload_volume(context, image_service, image_meta,self.local_path(volume))? | 19:22 |
| hemna | eharney, so I guess at some point we should modify the nfs/remotefs driver to use os-brick for the local volume copy operations | 19:22 |
| hemna | and then migrate nova to use os-brick as well | 19:22 |
| hemna | bleh | 19:23 |
| jbernard | i believe migration will use that connector | 19:23 |
| jbernard | when i submitted the patch, lvm to/from nfs worked | 19:23 |
| jbernard | and nfs to/from ceph also worked | 19:23 |
| hemna | jbernard, ok | 19:23 |
| hemna | I'm trying to find any way to test the os-brick privsep patch | 19:23 |
| jbernard | since it calls connect_volume, i believe it would follow that code path | 19:23 |
| sheel | mc_nair: you there | 19:23 |
| hemna | which modifies how the remotefs connector calls the local commands | 19:23 |
| hemna | ok, so create an lvm volume, then migrate that to nfs ? | 19:24 |
| sheel | mc_nair: was looking into quota in nova | 19:24 |
| jbernard | hemna: yeah, that worked when i submitted the patch, i swear | 19:24 |
| hemna | ok let me try | 19:24 |
| sheel | mc_nair: there something that is different then what is being used in cinder | 19:24 |
| hemna | jbernard, thanks | 19:24 |
| jbernard | hemna: but it's not tested in the gate, so usual disclaimer applies | 19:24 |
| mc_nair | sheel: yea - actually just hacked something to get the QuotaDriver instantiation further down (will put up a WIP shortly) | 19:24 |
| jbernard | hemna: np | 19:24 |
| *** alonma has joined #openstack-cinder | 19:24 | |
| *** salv-orlando has quit IRC | 19:24 | |
| *** stevemar has quit IRC | 19:24 | |
| mc_nair | sheel: anything particularly interesting with it? I'll take a look at it now | 19:24 |
| sheel | mc_nair: actually in nova, they are not intializing driver_class specifically | 19:25 |
| sheel | mc_nair: rather at the time of call only | 19:25 |
| * hemna tries | 19:26 | |
| sheel | mc_nair: refer http://paste.openstack.org/show/486131/ | 19:26 |
| e0ne | jbernard: in such case, we need to get disconnect_volume implemented to umount volume | 19:27 |
| hemna | Failed to schedule_migrate_volume_to_host: No valid host was found. Cannot place volume 4b5befe5-112b-4c87-a984-6209ca79ad9d on trusty-devstack@nfs | 19:27 |
| hemna | hrmm | 19:27 |
| hemna | puked in the scheduler | 19:27 |
| jbernard | hmm | 19:27 |
| jbernard | --migration-policy=ondemand ? | 19:27 |
| mc_nair | sheel: wish I had seen that before - it's what I just ended up doing :) thanks for the help on that. Good confirmation about that being the way to go | 19:27 |
| mc_nair | sheel: that seems to make sense, will continue on with that. Thanks again for the help | 19:28 |
| sheel | mc_nair: yeah..its ok... just wanted to help you | 19:28 |
| sheel | mc_nair: always welcome | 19:28 |
| *** mylu has quit IRC | 19:29 | |
| *** alonma has quit IRC | 19:29 | |
| *** rlrossit has quit IRC | 19:29 | |
| hemna | 'free_capacity_gb': 0.8544921875 | 19:30 |
| hemna | arg | 19:30 |
| *** mylu has joined #openstack-cinder | 19:31 | |
| hemna | normal volume create works | 19:31 |
| hemna | just can't migrate | 19:31 |
| hemna | wtf | 19:31 |
| sheel | eharney: hi there | 19:31 |
| e0ne | migrate do not use thin provisioning | 19:31 |
| sheel | eharney: regarding https://review.openstack.org/#/c/272232/ | 19:32 |
| jbernard | e0ne: sparse is passed to dd if both volumes are block devices | 19:32 |
| sheel | eharney : comments incorporated , also jenkins turned green | 19:32 |
| sheel | eharney: could you find some time to review it.. | 19:33 |
| jbernard | e0ne: does disconnect not unmount now? | 19:33 |
| jbernard | e0ne: i haven't tested that in some time | 19:33 |
| *** alonma has joined #openstack-cinder | 19:34 | |
| *** rlrossit_ has joined #openstack-cinder | 19:34 | |
| e0ne | jbernard: https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connector.py#L1811 | 19:34 |
| hemna | my volume type is basically empty but the volume_backend_name | 19:34 |
| hemna | I can create | 19:34 |
| hemna | just not migrate | 19:34 |
| e0ne | jbernard: it's in my TODO list to implement it at least for nfs | 19:35 |
| hemna | scheduler says no host found on migrate | 19:35 |
| *** stevemar has joined #openstack-cinder | 19:35 | |
| jbernard | hemna: damn, ill add that to my todo list for investigation | 19:36 |
| hemna | http://paste.openstack.org/show/486133/ | 19:36 |
| hemna | cinder migrate 4b5befe5-112b-4c87-a984-6209ca79ad9d trusty-devstack@nfs#nfs | 19:36 |
| hemna | cinder-volume | trusty-devstack@nfs | nova | enabled | up | 19:37 |
| *** mylu has quit IRC | 19:37 | |
| hemna | tried not passing the pool name | 19:37 |
| hemna | same result | 19:37 |
| *** crose has joined #openstack-cinder | 19:37 | |
| jbernard | hemna: oh, you cannot 'migrate' to migrate | 19:37 |
| jbernard | hemna: you must 'retype' | 19:38 |
| hemna | the nfs free capacity is reporting 0.85G though | 19:38 |
| hemna | but I can create against it | 19:38 |
| hemna | does migrate not use overprovisioning ? | 19:38 |
| *** alonma has quit IRC | 19:38 | |
| jbernard | i dont think migrate will allow the type to change | 19:38 |
| jbernard | so you cannot cross teh backend boundry | 19:38 |
| jbernard | which is required to move from lvm to nfs | 19:39 |
| hemna | retype pukes as well | 19:39 |
| *** vgridnev has joined #openstack-cinder | 19:39 | |
| *** krotscheck is now known as krotscheck_dcm | 19:39 | |
| jbernard | something like 'cinder retype --migration-policy=ondemand <volume id> <type>' | 19:39 |
| jbernard | ^ that's "supposed" to work | 19:39 |
| sheel | hemna: retype pukes if migration policy is not specified | 19:40 |
| sheel | hemna: may be you can try with migration policy | 19:40 |
| jbernard | puke might be the wrong word, it refuses the operation because a migration is required and the default is to disallow it | 19:41 |
| *** alonma has joined #openstack-cinder | 19:42 | |
| hemna | on-demand | 19:42 |
| hemna | :P | 19:42 |
| jbernard | hemna: ah yeah, oops :) | 19:42 |
| hemna | that seemed to have worked | 19:42 |
| sheel | :) | 19:42 |
| hemna | c-vol errors now :P | 19:42 |
| * jbernard rejoices | 19:42 | |
| * jbernard cries | 19:42 | |
| hemna | http://paste.openstack.org/show/486134/ | 19:43 |
| hemna | pewp | 19:43 |
| jbernard | hemna: privsep failing there? | 19:44 |
| jbernard | hemna: is that with or without your local changes? | 19:44 |
| hemna | jbernard, could be, have to track it down.... | 19:44 |
| jbernard | hemna: honestly, im extatic it made it that far | 19:44 |
| hemna | jbernard, hehe | 19:45 |
| jbernard | i may try to come up with a proposal for improved migration/retype flow for austin | 19:45 |
| jbernard | it's really getting crazy in there | 19:45 |
| hemna | I don't understand what --migration-policy is all about | 19:45 |
| hemna | and why that makes it work | 19:46 |
| hemna | :( | 19:46 |
| * hemna is confused | 19:46 | |
| jbernard | retype without migration just changes metadata (extra specs) to satisfy the request | 19:46 |
| jbernard | if the type or backend are differetn, then migration is required | 19:46 |
| *** mvk has joined #openstack-cinder | 19:46 | |
| jbernard | but the default is 'no, do not do it' | 19:46 |
| *** alonma has quit IRC | 19:46 | |
| jbernard | so you must say 'on-demand' to allow it to proceed | 19:47 |
| hemna | I see, so that just forces the retype -> migration | 19:47 |
| jbernard | yep | 19:47 |
| hemna | and yet cinder migrate doesn't work | 19:47 |
| hemna | wtf | 19:47 |
| jbernard | but.. it's not the same flow as proper 'cinder migrate' | 19:47 |
| hemna | :( | 19:47 |
| jbernard | which just moves a volume between hosts of the same backend | 19:47 |
| smcginnis | That would be too logical. :) | 19:47 |
| hemna | *smh* | 19:47 |
| hemna | can we please shoot ourselves more. | 19:48 |
| hemna | thanks | 19:48 |
| *** alonma has joined #openstack-cinder | 19:50 | |
| *** alonma has quit IRC | 19:55 | |
| *** mylu has joined #openstack-cinder | 19:56 | |
| *** jwcroppe has quit IRC | 19:58 | |
| *** alonma has joined #openstack-cinder | 19:58 | |
| *** jwcroppe has joined #openstack-cinder | 19:59 | |
| hemna | arg ok | 20:00 |
| hemna | well, progress | 20:00 |
| *** haomaiwang has quit IRC | 20:01 | |
| *** haomaiwang has joined #openstack-cinder | 20:01 | |
| *** Lee1092 has quit IRC | 20:02 | |
| hemna | https://review.openstack.org/#/c/258252/ | 20:02 |
| hemna | pewp | 20:02 |
| *** vgridnev has quit IRC | 20:03 | |
| *** alonma has quit IRC | 20:03 | |
| eharney | hemna: IIRC that execute argument only really exists for unit testing | 20:03 |
| eharney | hemna: so there may be a way to remove it | 20:04 |
| hemna | I'm hacking the patch just to get past it | 20:05 |
| hemna | at least locally | 20:05 |
| *** sheel has quit IRC | 20:05 | |
| hemna | execute=None | 20:05 |
| openstackgerrit | Alex Meade proposed openstack/cinder-specs: User facing error messages https://review.openstack.org/274958 | 20:10 |
| *** xyang has quit IRC | 20:14 | |
| *** salv-orlando has joined #openstack-cinder | 20:24 | |
| *** stevemar has quit IRC | 20:26 | |
| *** stevemar has joined #openstack-cinder | 20:26 | |
| *** lpetrut has quit IRC | 20:32 | |
| *** apoorvad has quit IRC | 20:33 | |
| *** mylu has quit IRC | 20:37 | |
| *** david-lyle has joined #openstack-cinder | 20:39 | |
| *** mylu has joined #openstack-cinder | 20:40 | |
| *** mylu has quit IRC | 20:53 | |
| *** akerr_ has quit IRC | 20:55 | |
| *** david-lyle has quit IRC | 20:55 | |
| *** david-lyle_ has joined #openstack-cinder | 20:55 | |
| *** porrua has quit IRC | 20:56 | |
| *** apoorvad has joined #openstack-cinder | 20:56 | |
| *** mylu has joined #openstack-cinder | 20:57 | |
| *** alonma has joined #openstack-cinder | 20:59 | |
| *** david-lyle_ is now known as david-lyle | 21:00 | |
| *** tongli has quit IRC | 21:00 | |
| *** haomaiwang has quit IRC | 21:01 | |
| *** raildo is now known as raildo-afk | 21:01 | |
| *** mylu has quit IRC | 21:01 | |
| *** haomaiwang has joined #openstack-cinder | 21:01 | |
| *** alonma has quit IRC | 21:03 | |
| *** alonma has joined #openstack-cinder | 21:06 | |
| *** mylu has joined #openstack-cinder | 21:08 | |
| guitarzan | hmm, does anyone know who oslo_config actually works? :) | 21:09 |
| guitarzan | when does it actually parse the config file? | 21:09 |
| dimsum__ | guitarzan : when CONF() is called | 21:09 |
| guitarzan | this for example, doesn't seem to work anymore: | 21:10 |
| guitarzan | CONF = config.CONF | 21:10 |
| guitarzan | API = importutils.import_class(CONF.volume_api_class) | 21:10 |
| guitarzan | it always returns the default value for volume_api_class now | 21:10 |
| *** mylu has quit IRC | 21:10 | |
| *** mylu has joined #openstack-cinder | 21:10 | |
| *** alonma has quit IRC | 21:10 | |
| guitarzan | it doesn't complain about the option, it just doesn't seem to read the value from cinder.conf | 21:11 |
| guitarzan | later, when printing out the config options, it has the correct value | 21:11 |
| *** lprice has joined #openstack-cinder | 21:12 | |
| dimsum__ | guitarzan : search for "CONF(" if you print before it's called you will get the default | 21:12 |
| guitarzan | dimsum__: yep, grepping all of cinder for that now, thanks a lot | 21:12 |
| *** alonma has joined #openstack-cinder | 21:12 | |
| guitarzan | striking out... | 21:13 |
| guitarzan | cinder/cmd/all.py | 21:14 |
| guitarzan | so everything imported before that main is going to not have the correct config options? | 21:14 |
| dimsum__ | guitarzan : http://paste.openstack.org/show/486152/ | 21:15 |
| guitarzan | but all of these top level import uses of CONF are just not going to work? | 21:15 |
| dimsum__ | guitarzan : when CONF() is called it gets the command line args and loads the config files | 21:15 |
| guitarzan | dimsum__: yeah, found it | 21:16 |
| hemna | I tried to use oslo.config in my standalone scripts | 21:16 |
| hemna | = PITA | 21:16 |
| hemna | https://github.com/WaltHP/diediedie/blob/master/diediedie/brick_volume.py | 21:16 |
| hemna | that's what I ended up doing | 21:16 |
| hemna | fwiw | 21:16 |
| guitarzan | hemna: ah, calling CONF at top level :) | 21:16 |
| *** alonma has quit IRC | 21:16 | |
| hemna | that's the only way I could get it to not puke | 21:17 |
| guitarzan | dimsum__: so is that pattern of using CONF.foo at top level just a broken idea? | 21:17 |
| dimsum__ | hemna : simple example - https://gist.github.com/dims/19cb6ee280c3177fbf52 | 21:17 |
| dimsum__ | let me look at yours | 21:17 |
| hemna | dimsum__, basically the same thing | 21:18 |
| guitarzan | dimsum__: so this just doesn't work? https://github.com/openstack/cinder/blob/master/cinder/volume/__init__.py | 21:18 |
| dimsum__ | hemna : you could add the CLI stuff to CONF as well | 21:18 |
| dimsum__ | guitarzan : depends on when that import kicks in | 21:19 |
| guitarzan | right | 21:19 |
| guitarzan | I'm going to have to check and see when this broke | 21:19 |
| guitarzan | fun | 21:19 |
| dimsum__ | what's the actual error you are seeing? is it in CI? | 21:20 |
| guitarzan | dimsum__: not an error, that option just doesn't work anymore | 21:20 |
| dimsum__ | hemna : we are always on oslo channel :) | 21:20 |
| guitarzan | no one tests the alternate volume api class :) | 21:20 |
| dimsum__ | guitarzan : ah | 21:20 |
| *** e0ne has quit IRC | 21:20 | |
| mc_nair | guitarzan: yea :/ I just ran into a similar issue with this today with the config not working for quota_driver either - https://github.com/openstack/cinder/blob/master/cinder/quota.py#L630 | 21:20 |
| hemna | dimsum__, thanks :) | 21:21 |
| guitarzan | mc_nair: that one should work though | 21:21 |
| guitarzan | mc_nair: that doesn't execute on import | 21:21 |
| guitarzan | oh, maybe it does | 21:21 |
| mc_nair | guitarzan: well we instantiate the class immediately - https://github.com/openstack/cinder/blob/master/cinder/quota.py#L969 | 21:21 |
| guitarzan | QUOTAS = VolumeTypeQuotaEngine() | 21:21 |
| guitarzan | CGQUOTAS = CGQuotaEngine() | 21:21 |
| guitarzan | at th ebottom | 21:21 |
| guitarzan | yeah | 21:21 |
| mc_nair | guitarzan: so with the help of sheel, we figured out easiest way to fix it was to do something similar to what nova does - http://paste.openstack.org/show/486131/ | 21:22 |
| guitarzan | I'm curious when this behavior changed | 21:22 |
| mc_nair | guitarzan: though not sure if that will help you for the API case or not | 21:22 |
| guitarzan | ah, just load it on demand | 21:22 |
| *** timcl has quit IRC | 21:22 | |
| *** boris-42 has joined #openstack-cinder | 21:23 | |
| mc_nair | yea - then it's good to go. Was losing my mind earlier today trying to figure out why it wouldn't pick up my config change for the driver :) | 21:23 |
| guitarzan | mc_nair: yeah, this is pretty maddening ;) | 21:24 |
| *** alonma has joined #openstack-cinder | 21:24 | |
| mc_nair | guitarzan: indeed :) and I guess the API one is tougher to do an on-demand load for... | 21:26 |
| *** stevemar has quit IRC | 21:27 | |
| guitarzan | you are probably right :) | 21:27 |
| *** stevemar has joined #openstack-cinder | 21:28 | |
| *** alonma has quit IRC | 21:29 | |
| *** alonma has joined #openstack-cinder | 21:31 | |
| *** crose has quit IRC | 21:31 | |
| *** stevemar_ has joined #openstack-cinder | 21:32 | |
| *** stevemar has quit IRC | 21:33 | |
| *** alonma has quit IRC | 21:35 | |
| *** alonma has joined #openstack-cinder | 21:40 | |
| *** mragupat has quit IRC | 21:40 | |
| *** mragupat has joined #openstack-cinder | 21:41 | |
| *** alonma has quit IRC | 21:45 | |
| mc_nair | guitarzan: could we do something like this? http://paste.openstack.org/show/486156/ | 21:46 |
| *** baumann has quit IRC | 21:46 | |
| mc_nair | guitarzan: it at least failed now when I put in a made up API class :) | 21:46 |
| *** xyang has joined #openstack-cinder | 21:47 | |
| *** jgregor has quit IRC | 21:47 | |
| hemna | so... | 21:48 |
| openstackgerrit | Ryan Rossiter proposed openstack/cinder: Add test for checking object compatibilities https://review.openstack.org/259123 | 21:48 |
| hemna | can we push through a few of these specs that are just sitting there. The code has already landed. https://review.openstack.org/#/c/243730/ and https://review.openstack.org/#/c/204180/ | 21:49 |
| guitarzan | mc_nair: that does kind of work | 21:49 |
| guitarzan | mc_nair: it needs to be singletonized somehow I think | 21:49 |
| guitarzan | so ugly though :) | 21:49 |
| *** xyang1 has quit IRC | 21:50 | |
| mc_nair | guitarzan: was it singletonized before? I can't tell if it was just used to map to the API class that you want to instantiate | 21:50 |
| mc_nair | guitarzan: but indeed - I uglified it | 21:50 |
| guitarzan | mc_nair: that's a good point | 21:50 |
| mc_nair | FWIW... I really like the word "singletonized" | 21:51 |
| guitarzan | you can english anything | 21:51 |
| hemna | :) | 21:51 |
| hemna | singletonizification | 21:52 |
| Swanson | verbing weirds words. | 21:52 |
| mc_nair | :) | 21:52 |
| guitarzan | mc_nair: I don't even now for sure if returning a class instance is what that's really supposed to do | 21:52 |
| guitarzan | mc_nair: ya, it's not supposed to return the class | 21:53 |
| guitarzan | er, the instance | 21:53 |
| mc_nair | guitarzan: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L262? | 21:53 |
| openstackgerrit | Merged openstack/cinder-specs: Add extend_volume API to connectors https://review.openstack.org/243730 | 21:53 |
| openstackgerrit | Merged openstack/cinder-specs: Brick add new Connector volume APIs https://review.openstack.org/204180 | 21:54 |
| mc_nair | guitarzan: that's where I was looking where I think that change would still keep the same behavior. But I haven't tracked down other places we may use it | 21:54 |
| hemna | thank you | 21:54 |
| *** tpsilva has quit IRC | 21:56 | |
| *** diablo_rojo has quit IRC | 21:58 | |
| *** adrianofr has quit IRC | 22:00 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** sgotliv has joined #openstack-cinder | 22:01 | |
| *** haomaiwa_ has joined #openstack-cinder | 22:01 | |
| *** dims has joined #openstack-cinder | 22:04 | |
| *** dimsum__ has quit IRC | 22:04 | |
| openstackgerrit | Scott DAngelo proposed openstack/cinder: cinder-api-microversions code https://review.openstack.org/224910 | 22:07 |
| *** jungleboyj has quit IRC | 22:10 | |
| guitarzan | mc_nair: it needs to be trickier, because you can't change the thing you're creating in init :) | 22:10 |
| scottda | How much to folks want api-microversions in Mitaka? Badly enough to review 3500 lines of code? | 22:10 |
| scottda | s/to/do | 22:10 |
| guitarzan | mc_nair: some __new__ shennanigans are in order I think | 22:10 |
| *** gouthamr has quit IRC | 22:11 | |
| mc_nair | guitarzan: sounds like quite a party | 22:13 |
| patrickeast | scottda: i'll take a stab at it this weekend | 22:13 |
| patrickeast | scottda: have been meaning to pull it down and play around with it... day job has really gotten in the way :( | 22:13 |
| scottda | patrickeast: Thanks. Adding a new /v3 endpoint means copying a bunch of /v2 stuff and /v2 unit tests, so it's not as bad as it sounds | 22:14 |
| patrickeast | scottda: sweet, that makes things easier | 22:14 |
| scottda | patrickeast: I need to update this, but it has some ideas for testing: https://github.com/scottdangelo/TestCinderAPImicroversions | 22:14 |
| scottda | And I need to fix the cinderclient for the /v3 changes.... | 22:15 |
| mc_nair | xyang: oh synchronized reviews :) | 22:15 |
| xyang | mc_nair: you clicked the publish button quicker:) | 22:16 |
| *** dustins has quit IRC | 22:16 | |
| mc_nair | xyang: haha - yea, it's like a draw | 22:17 |
| mc_nair | xyang: btw - regarding https://review.openstack.org/#/c/275408/, did you want me to push up something to do the validation of the max_oversubscription_config? | 22:18 |
| mc_nair | probably won't get much review love from others til we get it into a non -1 state. | 22:19 |
| *** knikolla has quit IRC | 22:19 | |
| xyang | mc_nair: as long as you work with the original author. He marked it WIP. I don't want a first time contributor's work wasted:) | 22:19 |
| mc_nair | xyang: for sure :) just wanted to make sure you hadn't started on that already. Will work with him on Monday on that | 22:21 |
| mc_nair | thanks | 22:21 |
| *** geguileo has joined #openstack-cinder | 22:22 | |
| xyang | mc_nair: sure | 22:23 |
| guitarzan | mc_nair: using __new__ actually kind of works | 22:24 |
| *** lascii is now known as alaski | 22:24 | |
| *** stevemar_ has quit IRC | 22:24 | |
| *** stevemar has joined #openstack-cinder | 22:25 | |
| mc_nair | guitarzan: haha - kind of works is what we shoot for right? Could you share the code snippet on that? My interest is piqued | 22:26 |
| guitarzan | mc_nair: it's just the same as yours, only overriding __new__ instead | 22:28 |
| guitarzan | mc_nair: http://paste.openstack.org/show/486161/ | 22:28 |
| mc_nair | guitarzan: ack - I get what you're saying. Yea that makes sense | 22:31 |
| mc_nair | cool | 22:31 |
| *** lprice has quit IRC | 22:31 | |
| guitarzan | does cells still override the compute api class? | 22:31 |
| * guitarzan looks | 22:31 | |
| guitarzan | it's kind of a first class citizen, so they might not do that anymore | 22:32 |
| guitarzan | ah, API is a method in compute now | 22:33 |
| guitarzan | mc_nair: this works too: http://paste.openstack.org/show/486162/ | 22:35 |
| guitarzan | stolen from nova | 22:35 |
| mc_nair | guitarzan: oh nice | 22:36 |
| mc_nair | guitarzan: but that's got no character.... to clean :) | 22:36 |
| guitarzan | haha, indeed | 22:37 |
| *** salv-orl_ has joined #openstack-cinder | 22:40 | |
| *** alonma has joined #openstack-cinder | 22:41 | |
| *** salv-orlando has quit IRC | 22:43 | |
| *** cbader has quit IRC | 22:43 | |
| *** alonma has quit IRC | 22:45 | |
| *** alonma has joined #openstack-cinder | 22:49 | |
| *** alonma has quit IRC | 22:53 | |
| *** garthb_ has joined #openstack-cinder | 22:53 | |
| *** garthb has quit IRC | 22:53 | |
| *** geguileo has quit IRC | 22:53 | |
| *** mylu has quit IRC | 22:54 | |
| *** erlon has quit IRC | 22:56 | |
| *** cknight has quit IRC | 22:56 | |
| *** cknight has joined #openstack-cinder | 22:56 | |
| *** geguileo has joined #openstack-cinder | 22:58 | |
| *** xyang has quit IRC | 22:58 | |
| *** haomaiwa_ has quit IRC | 23:01 | |
| *** haomaiwang has joined #openstack-cinder | 23:01 | |
| *** laughterwym has joined #openstack-cinder | 23:01 | |
| *** mylu has joined #openstack-cinder | 23:02 | |
| *** laughterwym has quit IRC | 23:06 | |
| *** dims_ has joined #openstack-cinder | 23:06 | |
| *** rlrossit_ has quit IRC | 23:06 | |
| *** mragupat has quit IRC | 23:08 | |
| *** dims has quit IRC | 23:10 | |
| *** edmondsw has quit IRC | 23:13 | |
| *** IlyaG has joined #openstack-cinder | 23:16 | |
| *** edtubill has quit IRC | 23:26 | |
| *** IlyaG has quit IRC | 23:28 | |
| *** mylu has quit IRC | 23:31 | |
| *** mylu has joined #openstack-cinder | 23:31 | |
| *** mylu has quit IRC | 23:32 | |
| *** IlyaG has joined #openstack-cinder | 23:35 | |
| *** mgarza has quit IRC | 23:37 | |
| *** sgotliv has quit IRC | 23:37 | |
| *** chlong has joined #openstack-cinder | 23:38 | |
| *** IlyaG has quit IRC | 23:46 | |
| *** cknight has quit IRC | 23:46 | |
| *** geguileo has quit IRC | 23:49 | |
| *** mvk has quit IRC | 23:50 | |
| *** arch-nemesis has quit IRC | 23:52 | |
| *** mylu has joined #openstack-cinder | 23:54 | |
| *** mylu has quit IRC | 23:58 | |
| *** bardia has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!