Monday, 2015-07-06

*** chlong has joined #openstack-cinder00:04
*** harlowja_at_home has joined #openstack-cinder00:04
openstackgerritxing-yang proposed openstack/cinder: Attach snapshot  https://review.openstack.org/19855600:07
*** laughterwym has joined #openstack-cinder00:14
*** hflai has joined #openstack-cinder00:27
*** jasondotstar has quit IRC00:54
*** dims__ has joined #openstack-cinder00:55
*** dims_ has quit IRC00:56
*** heyun has joined #openstack-cinder00:58
openstackgerritEdwin Wang proposed openstack/cinder: Separate FlashSystem FC and iSCSI common code  https://review.openstack.org/19538201:05
*** dims__ has quit IRC01:06
*** dims_ has joined #openstack-cinder01:07
*** lixiaoy1 has joined #openstack-cinder01:10
*** lixiaoy1 has joined #openstack-cinder01:11
*** lixiaoy1 has quit IRC01:11
*** lixiaoy1 has joined #openstack-cinder01:12
*** dims_ has quit IRC01:15
*** blmartin has joined #openstack-cinder01:18
*** davechen has joined #openstack-cinder01:26
*** zhenguo has joined #openstack-cinder01:34
*** jasondotstar has joined #openstack-cinder01:38
*** Longgeek_ has joined #openstack-cinder01:46
*** gouthamr has quit IRC01:49
*** Longgeek has quit IRC01:49
openstackgerritPeter Wang proposed openstack/cinder: Add white list support for target ports in VNX driver  https://review.openstack.org/19697901:50
*** jamielennox is now known as jamielennox|away01:51
*** jasondotstar has quit IRC01:55
*** annashen has joined #openstack-cinder02:00
*** jamielennox|away is now known as jamielennox02:02
*** annashen has quit IRC02:05
*** annashen has joined #openstack-cinder02:07
*** annashen has quit IRC02:08
*** annashen has joined #openstack-cinder02:08
*** mutoulbj has joined #openstack-cinder02:09
*** annashen has quit IRC02:21
*** marzif has quit IRC02:22
*** annashen has joined #openstack-cinder02:26
*** blmartin has quit IRC02:30
*** coolsvap|away is now known as coolsvap02:36
*** bkopilov has quit IRC02:45
*** Longgeek_ has quit IRC02:47
*** Longgeek has joined #openstack-cinder02:47
*** annashen has quit IRC02:50
*** jungleboyj has quit IRC02:50
*** coolsvap is now known as coolsvap|away02:50
*** hakimo has joined #openstack-cinder02:51
*** hakimo_ has quit IRC02:55
*** BharatK has joined #openstack-cinder03:01
*** annashen has joined #openstack-cinder03:03
*** annashen has quit IRC03:05
*** avishay_ has quit IRC03:15
*** Longgeek_ has joined #openstack-cinder03:16
*** Longgeek has quit IRC03:18
*** annashen has joined #openstack-cinder03:23
*** annashen has quit IRC03:27
*** yamada-h has joined #openstack-cinder03:30
*** tobe has joined #openstack-cinder03:31
*** RuiChen has quit IRC03:33
*** yamada-h has quit IRC03:34
*** harlowja_at_home has quit IRC03:38
*** jamielennox is now known as jamielennox|away03:38
*** annashen has joined #openstack-cinder03:41
*** jungleboyj has joined #openstack-cinder03:47
*** jamielennox|away is now known as jamielennox03:49
openstackgerritwanghao proposed openstack/cinder: Incremental backup improvements for L  https://review.openstack.org/18832803:49
*** bkopilov has joined #openstack-cinder03:51
*** mutoulbj has quit IRC03:51
*** mutoulbj has joined #openstack-cinder03:52
*** coolsvap|away is now known as coolsvap03:53
openstackgerritLiu Xinguo proposed openstack/cinder: Add multiple pools support for Huawei driver  https://review.openstack.org/18825103:55
*** avishay_ has joined #openstack-cinder03:59
*** dims_ has joined #openstack-cinder04:12
*** annashen has quit IRC04:12
*** dims__ has joined #openstack-cinder04:16
*** dims_ has quit IRC04:18
*** dims__ has quit IRC04:20
*** pradipta has joined #openstack-cinder04:20
*** dims__ has joined #openstack-cinder04:21
*** dims___ has joined #openstack-cinder04:22
*** p_deore has joined #openstack-cinder04:23
*** kkeuning has joined #openstack-cinder04:24
*** dims__ has quit IRC04:26
*** dims___ has quit IRC04:27
*** daneyon has joined #openstack-cinder04:28
*** daneyon has quit IRC04:28
*** daneyon has joined #openstack-cinder04:28
*** avishay_ is now known as avishay04:28
*** p_deore has quit IRC04:33
*** coolsvap is now known as coolsvap|brb04:35
*** BharatK has quit IRC04:37
*** shyama has joined #openstack-cinder04:38
*** annashen has joined #openstack-cinder04:47
*** annashen has quit IRC04:49
*** tobe has quit IRC04:51
*** nihilifer has joined #openstack-cinder04:53
openstackgerritxing-yang proposed openstack/cinder: Attach snapshot  https://review.openstack.org/19855604:53
*** yamada-h has joined #openstack-cinder04:54
*** lpetrut has joined #openstack-cinder05:03
*** BharatK has joined #openstack-cinder05:03
*** deepakcs has joined #openstack-cinder05:05
*** coolsvap|brb is now known as coolsvap05:06
*** pradipta has quit IRC05:08
*** lpetrut has quit IRC05:17
*** nkrinner has joined #openstack-cinder05:23
*** ankit_ag has joined #openstack-cinder05:28
*** shausy has joined #openstack-cinder05:29
*** coolsvap is now known as coolsvap|away05:29
*** s0nea has joined #openstack-cinder05:36
*** lpetrut has joined #openstack-cinder05:39
*** ig0r__ has joined #openstack-cinder05:52
*** ig0r_ has quit IRC05:55
*** Nikolay_St has quit IRC06:03
*** pradipta has joined #openstack-cinder06:06
*** dims_ has joined #openstack-cinder06:10
*** nlevinki has joined #openstack-cinder06:12
*** zhenguo has quit IRC06:13
*** dims_ has quit IRC06:15
*** kkeuning has quit IRC06:19
*** aarefiev_home has joined #openstack-cinder06:20
*** aarefiev_home has quit IRC06:27
*** daneyon has quit IRC06:28
*** anshul has joined #openstack-cinder06:29
*** ianbrown has quit IRC06:35
*** tobe has joined #openstack-cinder06:38
*** zhenguo has joined #openstack-cinder06:41
openstackgerritXi Yang proposed openstack/cinder: Fix getting out-of-date volume operation state issue for VNX  https://review.openstack.org/19745806:41
*** ociuhandu has joined #openstack-cinder06:42
*** jwcroppe has joined #openstack-cinder06:43
openstackgerritKuo-tung Kao proposed openstack/cinder: cinder list fails with 'name' sort key  https://review.openstack.org/19861406:48
*** belmoreira has joined #openstack-cinder06:53
*** sgotliv__ has quit IRC06:56
*** bluex-pl has joined #openstack-cinder07:03
*** bluex-pl has quit IRC07:08
*** tobe has quit IRC07:08
*** dims_ has joined #openstack-cinder07:12
*** dims_ has quit IRC07:16
*** ociuhandu has quit IRC07:16
*** tobe has joined #openstack-cinder07:20
openstackgerritVincent Hou proposed openstack/python-cinderclient: Change the client according to volume migration improvement  https://review.openstack.org/18954707:24
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631207:24
*** mikedillion has joined #openstack-cinder07:26
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631207:29
*** mikedillion has left #openstack-cinder07:29
*** markus_z has joined #openstack-cinder07:29
*** ndipanov has joined #openstack-cinder07:30
*** ndipanov has quit IRC07:32
*** ndipanov has joined #openstack-cinder07:32
*** chlong has quit IRC07:35
*** kaisers has joined #openstack-cinder07:37
*** kaisers has quit IRC07:37
openstackgerritwanghao proposed openstack/cinder: Notify the transfer volume action in cinder  https://review.openstack.org/18553107:46
openstackgerritwanghao proposed openstack/cinder: Implement function to manage/unmanage snapshots  https://review.openstack.org/14459007:48
*** annashen has joined #openstack-cinder07:50
*** mutoulbj has quit IRC07:51
*** annashen has quit IRC07:55
*** mutoulbj has joined #openstack-cinder07:55
*** nlevinki has quit IRC07:59
*** lpetrut has quit IRC08:00
*** laughterwym_ has joined #openstack-cinder08:00
*** bluex-pl has joined #openstack-cinder08:02
*** bluex-pl has quit IRC08:02
*** bluex-pl has joined #openstack-cinder08:02
*** kaisers has joined #openstack-cinder08:03
*** laughterwym has quit IRC08:04
*** kaisers has quit IRC08:04
*** sgotliv has joined #openstack-cinder08:10
*** shausy has quit IRC08:11
*** shausy has joined #openstack-cinder08:11
*** nkrinner has quit IRC08:15
*** nlevinki has joined #openstack-cinder08:15
*** subscope has joined #openstack-cinder08:17
*** daneyon has joined #openstack-cinder08:17
*** nkrinner has joined #openstack-cinder08:18
*** daneyon has quit IRC08:22
wanghaoguys, I found this patch "Add support for force-delete backups"(https://review.openstack.org/#/c/166127/) has no more new reviews for a few days. Could we push this forward in L-2?  Thanks.08:26
openstackgerritVipin Balachandran proposed openstack/cinder: Move volume.api test to correct location  https://review.openstack.org/19863608:37
openstackgerritVipin Balachandran proposed openstack/cinder: Add unit tests for cinder.api.v2.volumes  https://review.openstack.org/19863708:39
*** laughterwym_ has quit IRC08:48
openstackgerritVipin Balachandran proposed openstack/cinder: Raise BadRequest for invalid replication status  https://review.openstack.org/19864008:48
*** jordanP has joined #openstack-cinder09:00
*** bluex-pl has quit IRC09:00
*** bluex-pl has joined #openstack-cinder09:01
*** kodoku has joined #openstack-cinder09:06
*** nlevinki has quit IRC09:07
BharatKDuncanT, Hi, need your blessings for the patch: https://review.openstack.org/18228609:08
kodokuHi, is it possible to modify the public URL send by CINDER by API ? Because I use reverse proxy for my APIs and the url for Cinder is http://proxy/volume ==> http://controler:8776/v1    BUT Cinder return http://proxy/v1 ......09:09
kodokuI now in keystone I can use public_endpoint=.....09:09
*** yuriy_n17 has joined #openstack-cinder09:11
*** jamielennox is now known as jamielennox|away09:11
*** subscope has quit IRC09:14
*** subscope has joined #openstack-cinder09:15
*** jamielennox|away is now known as jamielennox09:18
*** nlevinki has joined #openstack-cinder09:20
openstackgerritVincent Hou proposed openstack/python-cinderclient: Change the client according to volume migration improvement  https://review.openstack.org/18954709:22
openstackgerritVincent Hou proposed openstack/cinder: Add the notification and the migration progress indication  https://review.openstack.org/18961409:24
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631209:25
openstackgerritKuo-tung Kao proposed openstack/cinder: cinder list fails with 'name' sort key  https://review.openstack.org/19861409:30
deepakcsjordanP: ping09:34
jordanPdeepakcs, ping09:34
*** lpetrut has joined #openstack-cinder09:34
deepakcsjordanP: reg.https://review.openstack.org/192736, you said u don't have a failing testcase to fix the blockCommit part, right ?09:35
*** sb has quit IRC09:35
deepakcsjordanP: so i managed to get a failing testcase, outside of tempest, i can open a LP bug, if that helps u fix the blockCommit too ?09:35
*** strictlyb has joined #openstack-cinder09:36
jordanPdeepakcs, feel free to open a new bug in LP and submit a new patch. One bug in LP, one patch09:36
deepakcsjordanP: Hmm i have seen 1 patch fixing 2 bugs too, anyways, i will open a LP bug, will leave it to you on how u want to fix it.09:37
kodokunobody can help me ?09:37
jordanPdeepakcs, that so kind of you :)09:38
*** ociuhandu has joined #openstack-cinder09:46
deepakcsjordanP: lpetrut https://bugs.launchpad.net/nova/+bug/1471726 ( FYI )09:49
openstackLaunchpad bug 1471726 in OpenStack Compute (nova) "libvirt: blockCommit fails if domain is not running, for attached cinder volumes" [Undecided,New]09:49
*** swamireddy_ has joined #openstack-cinder09:49
*** yamada-h has quit IRC09:52
*** davechen has left #openstack-cinder09:54
openstackgerritBharat Kumar Kobagana (BharatK) proposed openstack/cinder: Posix backup driver  https://review.openstack.org/16364709:54
*** lixiaoy1 has quit IRC09:54
*** bluex-pl has quit IRC10:00
*** heyun has quit IRC10:02
openstackgerritYuriy Nesenenko proposed openstack/cinder: Filter cgsnapshots data on the DB side  https://review.openstack.org/19716310:02
*** mutoulbj has quit IRC10:03
*** daneyon has joined #openstack-cinder10:06
*** laughterwym has joined #openstack-cinder10:06
*** dtynan has quit IRC10:07
*** lan_ has quit IRC10:07
*** dtynan has joined #openstack-cinder10:07
lpetrutdeepakcs: Thanks for the heads up10:09
*** kaisers has joined #openstack-cinder10:11
*** daneyon has quit IRC10:11
*** kaisers has quit IRC10:11
*** marzif has joined #openstack-cinder10:12
*** kaisers has joined #openstack-cinder10:12
openstackgerritYuriy Nesenenko proposed openstack/cinder: Filter cgsnapshots data on the DB side  https://review.openstack.org/19716310:12
*** lan_ has joined #openstack-cinder10:19
*** kodoku has quit IRC10:22
swamireddy_Hi All10:35
openstackgerritKyrylo Romanenko proposed openstack/python-cinderclient: Add tests for python-cinderclient  https://review.openstack.org/19866310:36
*** lan__ has joined #openstack-cinder10:37
swamireddy_Quick Q:  Can we block  (stop giving access to user) a specific APIs?10:38
swamireddy_from cinder?10:38
openstackgerritBharat Kumar Kobagana (BharatK) proposed openstack/cinder: GlusterFS backup driver  https://review.openstack.org/18225410:40
*** lan_ has quit IRC10:40
*** bluex-pl has joined #openstack-cinder10:41
shyamaswamireddy_: that can be done through the policy.json file. It is more of keystone10:41
*** Longgeek_ has quit IRC10:41
*** Longgeek has joined #openstack-cinder10:42
*** pradipta has quit IRC10:44
*** mutoulbj has joined #openstack-cinder10:46
openstackgerritKyrylo Romanenko proposed openstack/python-cinderclient: Add tests for python-cinderclient  https://review.openstack.org/19764310:46
*** dims_ has joined #openstack-cinder10:47
*** dims_ has quit IRC10:52
*** ociuhandu has quit IRC10:58
*** Yogi1 has joined #openstack-cinder10:59
*** tobe has quit IRC11:01
*** chlong has joined #openstack-cinder11:05
*** Yogi1 has quit IRC11:11
*** subscope has quit IRC11:12
swamireddy_shyama: OK...but with policy.json, we can set the role for the API, can not block the specific API??11:17
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Pass volume size in GB to copy_volume function  https://review.openstack.org/19800611:17
*** e0ne has joined #openstack-cinder11:17
geguileowinston-d: ping - VolumeIsBusy stuff11:28
*** IanGovett has joined #openstack-cinder11:33
*** subscope has joined #openstack-cinder11:36
*** ociuhandu has joined #openstack-cinder11:37
*** kodoku has joined #openstack-cinder11:39
*** Yogi1 has joined #openstack-cinder11:45
*** e0ne has quit IRC11:45
*** ganso_ has joined #openstack-cinder11:45
*** bluex-pl has quit IRC11:49
*** daneyon has joined #openstack-cinder11:55
*** e0ne has joined #openstack-cinder11:56
*** bill_az has joined #openstack-cinder11:57
*** kodoku has quit IRC11:58
*** daneyon has quit IRC12:00
*** nikeshm has joined #openstack-cinder12:00
*** bluex-pl has joined #openstack-cinder12:00
*** delatte has quit IRC12:01
*** delatte has joined #openstack-cinder12:02
*** dtynan has quit IRC12:02
*** dtynan has joined #openstack-cinder12:03
*** dims_ has joined #openstack-cinder12:03
*** Yogi1 has quit IRC12:05
*** tpsilva has joined #openstack-cinder12:05
*** dims_ has quit IRC12:08
*** bkopilov has quit IRC12:09
DuncanTswamireddy_: Just put a role in policy that doesn't exist and the API is blocked12:11
*** leakypipes is now known as jaypipes12:12
openstackgerritxiaoqin proposed openstack/cinder: IBM storwize driver configuration item default valume change  https://review.openstack.org/19869212:13
*** edmondsw has joined #openstack-cinder12:24
*** bswartz has quit IRC12:24
openstackgerritYuriy Nesenenko proposed openstack/cinder: Checking the existence of volume  https://review.openstack.org/17580912:27
*** BharatK has quit IRC12:31
*** bluex-pl has quit IRC12:35
*** bluex-pl has joined #openstack-cinder12:35
*** bluex-pl has quit IRC12:36
*** andrey-mp has joined #openstack-cinder12:36
*** bluex-pl has joined #openstack-cinder12:36
openstackgerritKyrylo Romanenko proposed openstack/python-cinderclient: Add tests for python-cinderclient  https://review.openstack.org/19764312:37
*** kodoku has joined #openstack-cinder12:38
*** jasondotstar has joined #openstack-cinder12:38
kodokuHi, Python cinder client 1.2.2 no works with Cinder API V1 JUNO. Is it normal ?12:38
openstackgerritDuncan Thomas proposed openstack/cinder: Add tenant validation to quota  https://review.openstack.org/14364512:41
*** akerr has joined #openstack-cinder12:42
*** jdurgin has joined #openstack-cinder12:47
*** eduardo has joined #openstack-cinder12:48
*** ankit_ag has quit IRC12:51
*** mildan has joined #openstack-cinder12:51
*** gouthamr has joined #openstack-cinder12:53
*** dims_ has joined #openstack-cinder12:55
andrey-mpDuncanT, if you can please review my last patchset - https://review.openstack.org/#/c/193596/12:57
*** dims__ has joined #openstack-cinder12:57
*** e0ne is now known as e0ne_12:57
DuncanTandrey-mp: Certainly12:58
*** mildan has quit IRC12:58
*** avishay_ has joined #openstack-cinder12:59
*** avishay has quit IRC12:59
swamireddy_DuncanT: Cool.. All APIs, is the policy.json check added? Means is the all APIs function call chek the policy.jscon role checks??13:00
*** dims___ has joined #openstack-cinder13:00
*** dims_ has quit IRC13:00
*** dims_ has joined #openstack-cinder13:01
*** kodoku has quit IRC13:01
*** julim has joined #openstack-cinder13:03
*** dims__ has quit IRC13:03
*** dims___ has quit IRC13:05
*** nihilifer has quit IRC13:05
*** erlon has joined #openstack-cinder13:06
*** dims__ has joined #openstack-cinder13:06
*** timcl has joined #openstack-cinder13:07
*** bswartz has joined #openstack-cinder13:07
*** merooney has joined #openstack-cinder13:08
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631213:08
*** ameade_vacation is now known as ameade13:08
*** xyang1 has joined #openstack-cinder13:09
*** dims_ has quit IRC13:09
*** jungleboyj has quit IRC13:10
*** dims__ has quit IRC13:11
openstackgerritShay Halsband proposed openstack/cinder: XtremIO support for iscsi discovery auth  https://review.openstack.org/18935813:20
*** e0ne_ is now known as e0ne13:24
*** andrey-mp has quit IRC13:24
jgriffithe0ne: think you missed something here: https://review.openstack.org/#/c/198006/3/cinder/image/image_utils.py13:25
e0nejgriffith: looks you're right. we need unit test for this case13:26
*** jskinner has joined #openstack-cinder13:27
*** rushil has joined #openstack-cinder13:29
*** rushil has quit IRC13:29
*** bkopilov has joined #openstack-cinder13:30
*** fabrice_ has joined #openstack-cinder13:31
fabrice_hi, can we ask question on cinderclient here ?13:32
e0nefabrice_: hi. sure13:33
*** dustins has joined #openstack-cinder13:34
openstackgerritTaoBai proposed openstack/cinder: Storwize Driver zone removing  https://review.openstack.org/19696613:35
fabrice_how can we do a set-bootable in python with cinderclient ?13:37
e0nejgriffith: oops. we've already have unit test  and i broke it too :(13:37
*** shausy has quit IRC13:38
*** chlong has quit IRC13:39
*** mriedem has joined #openstack-cinder13:39
openstackgerritVincent Hou proposed openstack/python-cinderclient: test  https://review.openstack.org/19871613:39
*** eharney has joined #openstack-cinder13:40
*** chlong has joined #openstack-cinder13:40
jgriffithe0ne: :)13:41
*** Yogi1 has joined #openstack-cinder13:41
jgriffithe0ne: this is why I always cringe a little when people say "-1 need a unit test" :)13:42
jgriffith98% of the time we all just change the unit test incorrectly with our patches anyway :)13:42
jgriffithor maybe that should be :(13:42
*** Longgeek has quit IRC13:43
e0nejgriffith: my patch is great example how to DON'T write unit tests13:43
jgriffithe0ne: anyway, I didn't see anything else other than that first glance.  I'll take a look again after you update13:43
jgriffithe0ne: LOL13:43
jgriffithe0ne: I have lots of those myself probably13:43
jgriffithe0ne: so I'm trying t a new strategy:13:44
*** daneyon has joined #openstack-cinder13:44
openstackgerritSergey Vilgelm proposed openstack/cinder: Remove unused config.generator module  https://review.openstack.org/19872113:44
jgriffithe0ne: instead of "write code... write code... fix unit tests"13:44
jgriffithe0ne: I'm trying "write unit tests... write code... write code..."13:44
e0nejgriffith: :)13:44
jgriffithe0ne: it works really well but it's VERY difficult to get in the habbit13:45
fabrice_myvol = cinder.volumes.create(name="test-vol", size=40)13:46
fabrice_cinder.volumes.set_bootable(myvol,True)13:46
e0nejgriffith: i'm agree with you13:47
fabrice_Traceback (most recent call last):13:47
fabrice_  File "/home/fabrice/programmation/workspace/Openstack/src/cinder.py", line 18, in <module>13:47
fabrice_    cinder.volumes.set_bootable(myvol,True)13:47
fabrice_AttributeError: 'VolumeManager' object has no attribute 'set_bootable'13:47
e0nejgriffith: but for me it's really very hard do tests first if i've got more than 2-3 mocks:(13:47
*** ctracey has quit IRC13:47
*** ctracey has joined #openstack-cinder13:48
*** merooney has quit IRC13:48
e0nefabrice_: please, use paste.openstack.org to share code and traceback13:48
*** daneyon has quit IRC13:48
fabrice_ok13:49
*** r-daneel has joined #openstack-cinder13:56
*** blmartin has joined #openstack-cinder13:58
openstackgerritIvan Kolodyazhny proposed openstack/cinder: Pass volume size in GB to copy_volume function  https://review.openstack.org/19800613:59
*** merooney has joined #openstack-cinder14:00
*** timcl has quit IRC14:00
openstackgerritErlon R. Cruz proposed openstack/cinder: Fix update_migrate_volume() exception handling  https://review.openstack.org/19873114:01
fabrice_e0ne , thanks for you answers. my prob was bad lib. next time i will use  paste.openstack.org14:01
*** timcl has joined #openstack-cinder14:01
*** nlevinki has quit IRC14:01
thingeejgriffith: thanks for writing the example14:04
thingeejgriffith: for capabilities14:04
thingeejgriffith: I think we're aligned here. I was hoping this would include the scheduler bits since that's where I'm unfamiliar with things.14:05
openstackgerritSergey Vilgelm proposed openstack/os-brick: Remove unused oslo incubator files  https://review.openstack.org/19873414:05
*** r-daneel has quit IRC14:07
*** dtynan has quit IRC14:07
*** deepakcs has quit IRC14:08
*** dtynan has joined #openstack-cinder14:09
*** anshul has quit IRC14:12
DuncanTswamireddy_: I beleive so - if you find any missing, please file a bug.14:13
e0neDuncanT: could you please take one more look on https://review.openstack.org/192683?14:14
DuncanTe0ne: Sure, two minutes14:14
e0neDuncanT: thanks!14:14
jgriffiththingee: the scheduler bits are "free"14:15
jgriffiththingee: that's what I keep trying to say :)14:15
jgriffiththingee: if you put any of those things in the extra-specs without a scoping on them the scheduler is going to look at capabilities to make sure they're there14:16
jgriffiththingee: but it MUST be in the stats piece then14:16
jgriffiththingee: so I could even put "set key foo=biz" in the extra spec14:16
jgriffiththingee: and as long as the stats report has "foo" in it it filters14:17
*** logan2 has quit IRC14:17
*** nlevinki has joined #openstack-cinder14:17
DuncanTe0ne: +214:17
e0neDuncanT: thank you14:18
thingeejgriffith: ok14:18
thingeejgriffith: I think I understand. Your example is just how the driver would go about doing it, but we'd still need the manager logic to know when to report the capabilities14:19
thingeelike we talked about last week14:19
jgriffithDuncanT: e0ne winston-d re https://review.openstack.org/#/c/192683/14:20
jgriffithDuncanT: e0ne winston-d ^^ Is that really beneficial?14:20
*** r-daneel has joined #openstack-cinder14:20
jgriffiththingee: I'll finish up the POC later today with everything14:21
jgriffiththingee: in reality you don't even need to add anything to the scheduler or manager14:21
DuncanTjgriffith: Keystone performs quite a bit better under it14:21
jgriffiththingee: if the structure is in the stats update it "just works"14:21
e0nejgriffith: it's abput 20% of performance increase for keysrone.14:21
DuncanTjgriffith: If the code isn't horrible and somebody does a CI for it, I don't think it's a bad thing14:21
jgriffithDuncanT: yeah... just asking14:21
jgriffithDuncanT: so IMHO sometimes you can have "too many options"14:22
thingeejgriffith: well unless you want the manager to be enforcing. For example we said somethings like standard capabilities should default to some boolean14:22
DuncanTjgriffith: Though most of the performance issues I usually see are DB related, so not so sure it will help *much* - enough to see the code though, I think14:22
jgriffithand you end up with none of them being well-supported14:22
e0nejgriffith: i believe, we'll deprecate eventelt-wsgi in a future14:22
jgriffithDuncanT: e0ne the statement in the write up is kinda contradictory IMO14:22
jgriffithEnteprises exposed via client access etc14:23
jgriffithThat sounds like  a public cloud issue, not an enterprise issue behind a firewall14:23
DuncanTjgriffith: Honestly, I don't buy the security line14:23
jgriffithDuncanT: so FTR that's what caught my attention14:23
jgriffithand the main reason I asked14:23
jgriffithDuncanT: e0ne if it's just about giving a non-eventlet and a nginx option let's just be honest about it14:24
jgriffithnot try and justify it or boost it's importance in the name of security14:24
DuncanTjgriffith: That's probably a fair comment - I just want to see it exist at this point, to make a more informed decission14:24
jgriffithDuncanT: yeah, that's fine by me14:25
e0nejgriffith: some enterprises want to use single endpoint like https://internalclour/{cinder, nova}14:25
DuncanTjgriffith: Security arguments are not something that I generally find all that compelling - the fact we took passwords out of debug output still annoys the hell out of me14:25
jgriffithe0ne: DuncanT I just don't want someobdy seeing this on the web and misinterpretting this as "a or more secure than b"14:25
DuncanTe0ne: Some enterprises want the moon on a stick....14:25
e0neDuncanT: :)14:26
DuncanTjgriffith: Hmmmm, probably worth a comment to that effect on the review at least14:26
jgriffithe0ne: so won't openstack-client help with that?14:26
e0nejgriffith: partially, yes. it won't help with more easy https deployment14:28
*** Adriano__ has joined #openstack-cinder14:28
openstackgerritMike Perez proposed openstack/cinder: Remove X-IO volume driver  https://review.openstack.org/19874114:28
thingeejgriffith: DuncanT ^14:28
lpetrutthingee: Hi. We'd like to add backup support for the Windows iSCSI and SMB drivers. Could you please take a look and maybe aprove the following two BPs? https://blueprints.launchpad.net/cinder/+spec/windows-smb-backup https://blueprints.launchpad.net/cinder/+spec/windows-iscsi-backup14:28
jgriffithe0ne: so I gave it a -1... but only because I'd prefer we don't pretend it's more secure or anythign like that14:28
e0nejgriffith: i mean, redirect between nginx+https and eventlet+http14:29
jgriffithe0ne: I think it's fine to introduce another option14:29
jgriffithe0ne: and certainly I myself am a fan of nginx14:29
jgriffithe0ne: would you mind terribly just rewording it a bit for me?14:29
jgriffithe0ne: if not I understand, and you'll get enough votes to merge it anyway :)14:30
openstackgerritVincent Hou proposed openstack/python-cinderclient: Change the client according to volume migration improvement  https://review.openstack.org/18954714:30
*** lpabon has joined #openstack-cinder14:30
*** rushil has joined #openstack-cinder14:31
e0nejgriffith: fair enough. i'll re-write security and deployers impact sections14:31
*** rushil has quit IRC14:31
jgriffithe0ne: thanks!!14:31
e0nejgriffith: thanks for review!14:32
*** nkrinner has quit IRC14:33
*** timcl has quit IRC14:33
*** timcl has joined #openstack-cinder14:33
jgriffithe0ne: you're welcome, sorry if I seem pedantic about that14:34
e0nejgriffith: np. i like your comment "they saw some reference to a statement in the spec on the internet" :)14:34
*** dustins_ has joined #openstack-cinder14:35
jgriffithe0ne: :) Only because it happens.14:35
*** stefan_amann has joined #openstack-cinder14:35
e0ne:)14:35
e0neit does14:35
*** stefan_amann has quit IRC14:35
DuncanTjgriffith: People who believe what they read on the internet deserve exactly what they get14:36
*** stefan_amann has joined #openstack-cinder14:36
*** dustins has quit IRC14:38
openstackgerritxing-yang proposed openstack/cinder: Attach snapshot  https://review.openstack.org/19855614:39
*** logan2 has joined #openstack-cinder14:41
*** nlevinki has quit IRC14:42
aarefievDuncanT: thanks for rebase patch with tenant validation in quota, I'll fix all issue and update patch14:43
*** Longgeek has joined #openstack-cinder14:43
*** rushil has joined #openstack-cinder14:48
*** Longgeek has quit IRC14:49
*** tbarron_afk is now known as tbarron14:49
openstackgerritAnton Arefiev proposed openstack/cinder: Fix properties extracting from image with glance api v2  https://review.openstack.org/16943014:50
openstackgerritIvan Kolodyazhny proposed openstack/cinder-specs: Cinder API WSGI application under Apache/Nginx  https://review.openstack.org/19268314:51
*** thangp has joined #openstack-cinder14:52
openstackgerritTaoBai proposed openstack/cinder: Storwize Driver zone removing Storwize driver may remove zone even when the zone is still in use by an attached volume.To fix this issue, we need only report initiator and target map when there are no volumes attached.  https://review.openstack.org/19696614:54
*** timcl has quit IRC14:58
*** cbader has joined #openstack-cinder14:58
*** timcl has joined #openstack-cinder14:59
*** mtanino has joined #openstack-cinder15:02
*** serverascode has quit IRC15:05
*** serverascode has joined #openstack-cinder15:05
*** dims_ has joined #openstack-cinder15:09
*** logan2 has quit IRC15:11
*** dannywilson has joined #openstack-cinder15:12
*** dtynan has quit IRC15:13
*** markvoelker has quit IRC15:14
*** haomaiwang has quit IRC15:14
openstackgerritVincent Hou proposed openstack/cinder: Volume status management during migration  https://review.openstack.org/18631215:14
*** IlyaG has joined #openstack-cinder15:14
*** dtynan has joined #openstack-cinder15:14
*** haomaiw__ has joined #openstack-cinder15:15
openstackgerritVincent Hou proposed openstack/python-cinderclient: Change cinderclient according to volume migration improvement  https://review.openstack.org/18954715:16
*** logan2 has joined #openstack-cinder15:19
*** kashyap has joined #openstack-cinder15:20
swamireddy_DuncanT: Sure, will check and file a bug, if some thing missing... Thx15:21
openstackgerritTom Barron proposed openstack/cinder: Port NetApp E-Series iSCSI driver to ABC model  https://review.openstack.org/19622515:21
*** timcl has left #openstack-cinder15:22
*** ameade has quit IRC15:22
*** ameade_vacation has joined #openstack-cinder15:23
*** ameade_vacation is now known as ameade15:23
aarefievthingee: hi, have quick  question, do we accept fixes to client v1 https://review.openstack.org/#/c/178588/  ?15:23
thingeeaarefiev: yeah fixes are fine. just no new functionality15:23
e0nethingee, aarefiev: yes for both options for cinderclient15:24
e0nethingee: am i right?15:24
aarefievthingee: could you look at  https://review.openstack.org/#/c/178588/ ,  please, very small fix?15:25
swamireddy_All - I have created a volume with size of 998GB (~1TB) and deleted the same. But the delete took time around 9 min. (cinder with ceph backend)15:25
swamireddy_Is the volume of  ~ 1 TB delete takes 9 min or so?? Is there justtification for this?15:26
*** belmoreira has quit IRC15:27
*** lpetrut has quit IRC15:27
*** tsekiyama has joined #openstack-cinder15:27
*** hodos has joined #openstack-cinder15:27
*** jungleboyj has joined #openstack-cinder15:28
*** crose has joined #openstack-cinder15:28
openstackgerritAnton Arefiev proposed openstack/cinder: Add tenant validation to quota  https://review.openstack.org/14364515:30
smcginnisswamireddy_: Could be that ceph takes that long to complete the operation. I would think it's backend dependent.15:31
swamireddy_smcginnis: I have tried with devstack + ceph, its taking 2 or 3 min..but with icehouse cinder+ceph, its talking 9 min or so..15:32
e0neswamireddy_: ceph deletion is a slow operation15:32
*** daneyon has joined #openstack-cinder15:33
*** hemnafk is now known as hemna15:33
*** daneyon has quit IRC15:33
openstackgerritThang Pham proposed openstack/cinder: Service object  https://review.openstack.org/16041715:34
e0neswamireddy_: http://www.sebastien-han.fr/blog/2013/12/12/rbd-image-bigger-than-your-ceph-cluster/15:34
e0neswamireddy_: it shrinks all vokume(image) chumks15:35
e0nes/chumks/chunks15:35
*** IlyaG_ has joined #openstack-cinder15:36
*** annegentle has joined #openstack-cinder15:37
*** IlyaG has quit IRC15:39
openstackgerritKuo-tung Kao proposed openstack/cinder: cinder list fails with 'name' sort key  https://review.openstack.org/19861415:40
*** dustins_ has quit IRC15:41
*** harlowja_at_home has joined #openstack-cinder15:44
openstackgerritDiem Tran proposed openstack/cinder: Fix PEP476 & format message of Oracle ZFSSA drivers  https://review.openstack.org/19773615:44
*** merooney has quit IRC15:44
*** lcurtis has joined #openstack-cinder15:44
*** zhiyan has quit IRC15:47
*** zhiyan has joined #openstack-cinder15:47
*** rushil has quit IRC15:48
*** patrickeast has joined #openstack-cinder15:53
*** eduardo has quit IRC15:59
*** Longgeek has joined #openstack-cinder16:00
*** jskinner has quit IRC16:03
*** jskinner has joined #openstack-cinder16:04
*** rwsu has joined #openstack-cinder16:04
*** Longgeek has quit IRC16:05
*** leeantho has joined #openstack-cinder16:08
*** avishay_ has quit IRC16:10
*** markvoelker has joined #openstack-cinder16:10
*** stefan_amann has quit IRC16:11
*** laughterwym has quit IRC16:13
DuncanTswamireddy_: Try creating and deleting a large block device on your ceph cluster without using cinder - cinder can never go faster than that16:13
swamireddy_DuncanT: sure, will check the delete time without cinder and confirm the status.16:15
openstackgerritAnton Arefiev proposed openstack/cinder: Fix properties extracting from image with glance api v2  https://review.openstack.org/16943016:16
*** haypo has joined #openstack-cinder16:20
*** jaypipes is now known as jay-deepthought16:21
*** lpetrut has joined #openstack-cinder16:24
*** rushil has joined #openstack-cinder16:27
*** jwcroppe_ has joined #openstack-cinder16:27
*** harlowja_at_home has quit IRC16:28
*** merooney has joined #openstack-cinder16:28
*** dustins has joined #openstack-cinder16:28
*** yuriy_n17 has quit IRC16:28
*** jwcroppe has quit IRC16:30
*** haypo has quit IRC16:31
*** ociuhandu has quit IRC16:31
*** jwcroppe_ has quit IRC16:32
*** timcl has joined #openstack-cinder16:32
e0nexyang1: hi. one question inline for https://review.openstack.org/#/c/193937/16/cinder/volume/driver.py16:34
xyang1e0ne: Hi16:36
*** Yogi1 has quit IRC16:36
xyang1e0ne: Backup is running in the same process as the volume driver now16:38
e0nexyang1: i mean different process: cinder-volume and cinder-backup16:40
xyang1e0ne: That is not happening now without code change16:40
*** jordanP has quit IRC16:41
e0nexyang1: i'm confused16:41
*** eharney has quit IRC16:42
xyang1e0ne: When you start backup service, it will load the driver in its process16:42
e0nexyang1: yes16:42
e0nexyang1: but the same for cinder-volume service16:42
xyang1e0ne: I see what you are saying16:43
e0nexyang1: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L307 and  https://github.com/openstack/cinder/blob/master/cinder/backup/manager.py#L17616:43
xyang1e0ne: good point16:44
e0nexyang1: thanks16:46
e0nexyang1: need to go offline. bb in ~2 hours16:46
xyang1e0ne: Thank you!16:46
e0nexyang1: you're welcome16:46
*** e0ne has quit IRC16:47
*** garthb has joined #openstack-cinder16:49
*** garthb_ has joined #openstack-cinder16:49
*** garthb_ has quit IRC16:50
openstackgerritJohn Griffith proposed openstack/cinder: Add deactivate step to extend_lv  https://review.openstack.org/19881316:50
*** annegentle has quit IRC16:50
*** dtynan has quit IRC16:50
*** git-harry has quit IRC16:50
*** jbernard has quit IRC16:50
*** anshprat has quit IRC16:50
*** ondergetekende_ has quit IRC16:50
*** anshprat has joined #openstack-cinder16:50
*** ondergetekende has joined #openstack-cinder16:50
*** jbernard has joined #openstack-cinder16:51
*** git-harry has joined #openstack-cinder16:54
*** annegentle has joined #openstack-cinder16:54
*** dtynan has joined #openstack-cinder16:55
*** rushil has quit IRC16:55
*** eharney has joined #openstack-cinder16:57
*** avishay_ has joined #openstack-cinder16:58
*** rushil has joined #openstack-cinder16:59
*** daneyon has joined #openstack-cinder17:00
*** _cjones_ has joined #openstack-cinder17:00
*** Longgeek has joined #openstack-cinder17:01
*** avishay_ has quit IRC17:03
*** jordanP has joined #openstack-cinder17:05
*** Longgeek has quit IRC17:06
*** markus_z has quit IRC17:10
*** crose has quit IRC17:17
*** jordanP has quit IRC17:17
*** logan2 has quit IRC17:21
*** sgotliv has quit IRC17:27
*** albertom has quit IRC17:28
*** albertom has joined #openstack-cinder17:35
*** jordanP has joined #openstack-cinder17:35
*** amit213 has quit IRC17:39
*** amit213 has joined #openstack-cinder17:39
*** jay-deepthought is now known as jaypipes17:40
*** amit213 has quit IRC17:40
*** amit213 has joined #openstack-cinder17:40
*** amit213 has quit IRC17:41
*** amit213 has joined #openstack-cinder17:42
*** mutoulbj has quit IRC17:42
*** amit213 has quit IRC17:42
*** amit213 has joined #openstack-cinder17:42
*** mutoulbj has joined #openstack-cinder17:43
*** rushil has quit IRC17:43
*** merooney has quit IRC17:48
*** dustins has quit IRC17:48
*** delattec has joined #openstack-cinder17:48
*** jdurgin has quit IRC17:48
*** annashen has joined #openstack-cinder17:50
*** delatte has quit IRC17:50
rmstarhi guys..need a little suggestion here.  I had created a volume when my storage noe is up.  But while my storage node was down, i tried to delete it.  It shows that it was in state deleting, but it is really hanging.  I brought the storage node up, but didn't do anything.  I resetted the state and to delete again, and again it hangs on 'deleting' state.  Any suggestion how i can get ride of the vo17:50
rmstarlume?17:50
*** logan2 has joined #openstack-cinder17:50
*** delatte has joined #openstack-cinder17:50
jgriffithrmstar: what backend device are you using?17:51
openstackgerritSean Chen proposed openstack/cinder: Tintri snapshot id  https://review.openstack.org/19882917:51
*** delattec has quit IRC17:51
jgriffithrmstar: when you brought the backend back online did you restart your c-vol services?  You shouldn't need to but maybe the driver you have isn't properly retrying/checking17:51
*** cdelatte has joined #openstack-cinder17:52
*** jwcroppe has joined #openstack-cinder17:53
*** merooney has joined #openstack-cinder17:53
*** dustins has joined #openstack-cinder17:53
rmstarjgriffith: i didn't restart anything.  I am relatively new to all this.  I am not sure what you mean by backend device.  But i can certainly restart the c-services to see if that helps17:53
jgriffithrmstar: well, you said storage node... guess I should assume that means you're using LVM/ref driver17:54
*** e0ne has joined #openstack-cinder17:54
*** delattec has joined #openstack-cinder17:54
rmstari essentially configured the node according to the juno installation guide, and it did not tell me to set up any driver...unless i missed something :S17:54
rmstarjust checked cinder.conf.  no driver parameter17:55
*** jasondotstar has quit IRC17:56
jgriffithrmstar: k, so it's the default NP17:56
rmstarjgriffith: btw, what would be the default backend (for my info)17:57
e0nermstar: it will use default (LVM) driver17:57
jgriffithrmstar: do a "cinder service-list" cmd, make sure c-vol is running and good17:57
rmstareOne:  ok.  thanks :)17:57
openstackgerritSean Chen proposed openstack/cinder: Remove duplicate volume.filters entry  https://review.openstack.org/18889917:57
*** jskinner has quit IRC17:58
rmstarjgriffith: yes. status enabled and state is up17:58
*** cdelatte has quit IRC17:58
*** delatte has quit IRC17:58
*** jordanP has quit IRC17:58
*** cdelatte has joined #openstack-cinder17:58
*** jskinner has joined #openstack-cinder17:58
jgriffithrmstar: on your volume node, do "sudo lvs" seee if your volume is there17:58
rmstarjgriffith: yes. the volume's there.18:01
*** delatte has joined #openstack-cinder18:01
jgriffithrmstar: odd.. so you mentioned you reset state succesfully, then try "cinder delete" again and it hangs?18:02
jgriffithrmstar: what's in your logs?  Check c-sch log for ERROR or TRACE18:02
jgriffithrmstar: perhaps c-vol as well18:02
jgriffithOhh.... one other thing :)18:02
jgriffithhow big is the volume?18:02
jgriffithand did you set secure_delete = False?18:03
*** zhenguo has quit IRC18:03
rmstarjgriffith: i did not set the secure_delete parameter.  The volume is 10G.  I will double check the logs.18:04
*** e0ne is now known as e0ne_18:04
*** rushil has joined #openstack-cinder18:04
jgriffithrmstar: so if you don't set "volume_clear=none" in your conf file it does a dd of zeros to every block on the dev18:04
jgriffithrmstar: which can take a long time and be rather problematic on some systems18:04
*** delattec has quit IRC18:05
*** cdelatte has quit IRC18:05
openstackgerritSean Chen proposed openstack/cinder: Tintri snapshot id  https://review.openstack.org/19882918:06
rmstarjgriffith: i did not set volume_clear=none in my config.18:07
rmstarjgriffith: just checked the logs.  No errors.18:07
*** med_` is now known as med_18:07
*** med_ has joined #openstack-cinder18:07
*** jasondotstar has joined #openstack-cinder18:08
jgriffithrmstar: did the volume go to error_deleting status?18:09
jgriffithsorry, I'm sure you mentioned that but I forget :)18:09
rmstarjgriffith: np.  just stuck on 'deleting'  i can just wait to see if it goes to error or if it actually works. :)18:09
rmstarjgriffith: not to confuse things, but i also tried to create a 1G volume when the storage was down, and it is stuck in 'creating' status.18:10
jgriffithrmstar: so I think you're just stuck waiting for the secure delete18:10
jgriffithrmstar: well, yeah, it's not very smart about some things18:11
jgriffithrmstar: can you create volumes now?18:11
*** IlyaG_ has quit IRC18:12
rmstarjgriffith: it's not a problem.  I know there are still lotsa scenarios we need to iron out.  I thought i check with you guys to make sure i'm not overlooking anything before deeming this as a bug.18:12
rmstarjgriffith: let me try to create18:12
rmstarjgriffith: yes.  creation successful.18:14
rmstarjgriffith: also able to delete18:14
jgriffithcool18:15
*** anshul has joined #openstack-cinder18:15
*** daneyon_ has joined #openstack-cinder18:15
*** lpetrut has quit IRC18:16
rmstarjgriffith: i will try to recreate the probelm.  If it is recreatable, i will add this to the bug list :)18:16
rmstarjgriffith: thanks for your help :)18:16
jgriffithrmstar: sure18:17
smcginnisjgriffith: Got a sec? Wondering if you could give some historical background on the "integrated" unit tests.18:18
*** daneyon has quit IRC18:18
smcginnisjgriffith: As in - what the heck are they and are they even needed. :)18:19
*** dims_ has quit IRC18:20
jgriffithsmcginnis: frankly I *HATE* them18:20
smcginnisjgriffith: I'm starting to share the dislike. ;)18:20
jgriffithsmcginnis: but, thingee introduced those as I remember, so you need to talk to him about it :)18:21
hemna"integrated" unit tests?18:21
jgriffithactually, those may be there from original fork18:22
smcginnisAre they supposed to be something in between a unit test and a tempest test? I just don't understand them really.18:22
jgriffithlooking at github18:22
smcginnisjgriffith: Yeah, most appear so.18:22
jgriffithTheyr'e crap is what they are :)18:22
smcginnishemna: cinder/tests/unit/integrated18:22
jgriffithsmcginnis: they should go away and be replaced with the functional tests18:22
jgriffithwhich nobody has picked up any work on18:23
* jgriffith looks away :)18:23
smcginnisjgriffith: So my question now is... are they of any use, and should I just submit a patch to blow away the whole directory? :D18:23
jgriffithsmcginnis: I suspect that you'll get push back if there isn't something to replace them18:24
*** e0ne_ is now known as e0ne18:24
smcginnisjgriffith: I'll add it to my list of things to bring up at the midcycle I guess.18:25
*** bluex-pl has quit IRC18:25
hemnasmcginnis, looks like nothing is mocked out, so does it require a running Cinder to have these tests work?18:25
smcginnishemna: That was my understanding.18:25
hemnaand isn't that what tempest is supposed to test ?18:25
* hemna is confused18:25
smcginnishemna: Which confuses me - yeah, why not tempest.18:25
* hemna shrugs18:25
jgriffithhemna: it runs client calls18:26
smcginnisI was assuming maybe these were a pre-tempest attempt to do full integration testing.18:26
jgriffithto the api... anyway18:26
*** lpetrut has joined #openstack-cinder18:26
hemnait calls the api18:26
smcginnisI guess to ask another way - is there anything we would lose here by deleting these that are not covered by tempest?18:27
hemnaI don't see client calls, I presume self.api = cinder/volume/api.py ?18:27
*** Yogi1 has joined #openstack-cinder18:27
e0nesmcginnis: imo, we need to create functional tests instead of "integrated"18:27
smcginnise0ne: What should that be then that is different than tempest?18:28
*** annashen has quit IRC18:28
hemnaisn't tempest's charter is to make sure the REST API's work ?18:28
smcginnise0ne: Just trying to understand the need that this is filling.18:28
jgriffithOk.. one more try:18:28
hemnathat seems different than ensuring cinder's internal stuff does X18:28
e0nesmcginnis: it was on Paris summit18:28
jgriffithThose are API tests that mock and use a bunch of fixtures to call the API18:28
jgriffiththey are a PITA to maintain18:28
jgriffithwhich I suspect is why smcginnis is asking18:28
jgriffithIMO they are kinda lame18:29
e0nesmcginnis: to move some tests inside projects instead of tempest18:29
jgriffithand should be replaced by cinder/tests/functional/18:29
*** thangp is now known as thangp_afk18:29
hemnajgriffith, +118:29
e0nejgriffith: +118:29
jgriffithremoving them is fine, but they have to have equivalents18:29
jgriffithand although I strated the functional work it still needs "finished"18:29
jgriffithinparticular it needs a gate job18:29
jgriffithand then obviously the test suite needs grown18:30
*** blmartin has quit IRC18:30
jgriffithI can work on that again here in a while, in the meantime as much as I don't care about those tests I would say they shouldn't just be blindly removed18:30
jgriffithsmcginnis: if you need help figuring out why your change is breaking them maybe we can help18:30
e0nejgriffith: thanks for reminder:). i was going to send mail to openstack-dev to invite people to writr functional tests for cinderclient:)18:30
jgriffitha few of us have been through the pain of that before18:30
jgriffithe0ne: :)18:31
smcginnissmcginnis: Thanks, nothing of mine breaking. Just cleaning some things up and don't understand them.18:31
smcginnisOops18:31
smcginnisjgriffith: Related to https://review.openstack.org/#/c/197723/18:31
jgriffithwe should test that and bounce anybody that puts a LOG back in there FWIW18:33
smcginnisjgriffith: Hacking check?18:34
jgriffithsmcginnis: as much as I hate myself for even saying it "yes"18:35
smcginnisHehe18:35
jgriffith:)18:35
*** lpetrut has quit IRC18:36
smcginnisjgriffith: Problem is we have lines like: block_base.LOG.error.assert_called_once_with(msg)18:36
*** anshul has quit IRC18:37
smcginnisjgriffith: So just looking for "LOG.[error|exception|warn|debug]" would have false hits.18:37
smcginnisNot that it couldn't be done...18:37
jgriffithsmcginnis: yeah, maybe we could just all be more strict in review18:38
jgriffithsmcginnis: and frankly those tests that a log message was called are AWFUL!!!!18:38
jgriffithI HATE them and they should die a slow and painful death18:38
*** annashen has joined #openstack-cinder18:38
hemnajgriffith, +118:38
smcginnis;)18:38
hemnadie die die!18:38
jgriffithIMO anything that imports LOG in the unit tests dir could basicly be bansished18:39
*** annashen has quit IRC18:40
e0nejgriffith: +2. checking log messages in tests should go away18:41
smcginnise0ne: +1. The whole thing of checking the text passed for log messages is another one I would like to see go away.18:45
e0nesmcginnis: sometimes, i want to drop error message checking too:)18:45
*** jdurgin has joined #openstack-cinder18:45
openstackgerritJon Bernard proposed openstack/cinder: Add support for generic volume migration  https://review.openstack.org/18727018:48
*** Rockyg has joined #openstack-cinder18:55
patrickeastjgriffith: hey, got a min? i am looking into less ridiculous ways to make the generic image cache thing work with non-public images… i have an idea but want to bounce it off someone18:55
openstackgerritRaunak Kumar proposed openstack/cinder: Implements: blueprint nimble-add-extra-specs-support  https://review.openstack.org/19885318:56
*** annashen has joined #openstack-cinder18:57
*** DericHorn-HP has joined #openstack-cinder18:58
*** jskinner has quit IRC18:59
jungleboyjjgriffith: You still around?19:00
*** jskinner has joined #openstack-cinder19:00
openstackgerritSergey Vilgelm proposed openstack/cinder: Remove unused config.generator module  https://review.openstack.org/19872119:00
*** Longgeek has joined #openstack-cinder19:02
*** e0ne has quit IRC19:06
openstackgerritTom Swanson proposed openstack/cinder: Dell SC: Add support for consistency groups  https://review.openstack.org/19681819:14
*** reed has quit IRC19:18
*** reed has joined #openstack-cinder19:18
*** Yogi11 has joined #openstack-cinder19:25
*** e0ne has joined #openstack-cinder19:26
openstackgerritSean McGinnis proposed openstack/cinder: Remove useless logging from unit tests  https://review.openstack.org/19772319:26
*** Yogi1 has quit IRC19:27
*** Longgeek has quit IRC19:27
*** gouthamr has quit IRC19:29
*** Yogi1 has joined #openstack-cinder19:29
*** gouthamr has joined #openstack-cinder19:30
*** mutoulbj has quit IRC19:30
*** Yogi11 has quit IRC19:31
*** dims_ has joined #openstack-cinder19:36
*** annashen has quit IRC19:37
*** lpetrut has joined #openstack-cinder19:38
*** annashen has joined #openstack-cinder19:38
*** annashen has quit IRC19:42
*** e0ne has quit IRC19:47
*** rushil has quit IRC19:49
*** rushil has joined #openstack-cinder19:49
*** anshul has joined #openstack-cinder19:55
*** bswartz has quit IRC19:55
*** anshul has quit IRC19:59
*** jasondotstar has quit IRC20:00
*** Yogi1 has quit IRC20:00
*** DericHorn-HP has quit IRC20:02
*** Yogi1 has joined #openstack-cinder20:03
*** timcl has quit IRC20:03
*** DericHorn-HP has joined #openstack-cinder20:03
*** sgotliv has joined #openstack-cinder20:05
jgriffithjungleboyj: back.. what's up?20:06
*** annashen has joined #openstack-cinder20:07
jungleboyjjgriffith: Howdy!  Just wanted to check how things are progressing with the code for replication.20:07
jgriffithjungleboyj: yeah, should have a patch up later this week or next week if I get side-tracked again :(20:07
jungleboyjjgriffith: Ok, didn't want to be a pest, but have been getting questions about it.20:08
jgriffithNo worries20:08
jungleboyjAnything I can do to help right now?20:08
jgriffithNot really, unless you want to take it20:08
*** dims_ has quit IRC20:17
jgriffithpatrickeast: so what are you thinking?20:21
patrickeastjgriffith: so, the problem is that when creating the volumes owned by the internal tenant we need one request context for volume type things in cinder, but the original request context for the image related stuff20:23
patrickeastjgriffith: to test it out and make sure it mostly works, i piped through a new image_context parameter all the way through and put it in the glance client calls, but it requires changing the driver api for copy_image_to_volume, which is implemented by a ton of folks… and i dont really want to mess with it20:24
*** akerr has quit IRC20:24
*** Longgeek has joined #openstack-cinder20:24
patrickeastjgriffith: i’m thinking of storing the context for the image related stuff in the image service client thing https://github.com/openstack/cinder/blob/master/cinder/image/glance.py#L197 and then breaking the pattern we have now to instead not pass in one for each call made on it, but to instead use whatever was given as part of its __init__()20:25
patrickeastjgriffith: its slightly less messy, but changes code in a somewhat subtle way… which is also not so good20:26
jungleboyjjgriffith: No, want to see what you come up with and then can work with you from there.20:26
*** rushil has quit IRC20:26
jungleboyjThanks for the update.20:26
patrickeastjgriffith: i’m also not sure how attached we are to the ‘pass context into everything’ pattern vs store context on objects that get passed around20:26
*** annegentle has quit IRC20:27
jungleboyjBack online in a bit.20:28
jgriffithpatrickeast: that's a good question20:29
jgriffithpatrickeast: the only objection I'd have to embedding context is inconsistency20:29
*** rushil has joined #openstack-cinder20:29
jgriffithpatrickeast: also it's prone to unauthorized access IMO20:29
jgriffithpatrickeast: it's one of those cases where explicit seems like a good idea20:29
jgriffithpatrickeast: so what about my suggestion before...20:31
jgriffithpatrickeast: just leaving it sort of like how I have it, but use a db entry to store info about it?20:31
jgriffithpatrickeast: alleviate the whole context thing20:31
jgriffithpatrickeast: because the db entry is basicly "public"20:31
jgriffithpatrickeast: or "admin" but doesn't matter20:32
jgriffithpatrickeast: because it's internal only20:32
jgriffithpatrickeast: not part of list or anything20:32
*** jungleboyj has quit IRC20:32
jgriffithpatrickeast: honestly the more I looked at it the more I think using the create--->clone might be more restrictive than it is helpful20:33
jgriffithbut I could be wrong20:33
jgriffithI just think it's tricky depending on whether somebody does optimized cloning or not20:33
jgriffithor of course if they use snpashots vs volumes etc etc20:33
jgriffithpatrickeast: certainly not saying we can't make it work20:34
jgriffithpatrickeast: just throwing out a thought20:34
jgriffithpatrickeast: the other thing is introduce a new method might be good20:34
jgriffithpatrickeast: so that a driver can override it20:34
jgriffithpatrickeast: a general one exists and can be used, but can be over-ridden as well20:34
jgriffithpatrickeast: not sure if what I'm saying is making any sense or not20:34
patrickeastjgriffith: yep, sry, someone just called me, just catching up on irc20:36
*** simondodsley has joined #openstack-cinder20:37
patrickeastjgriffith: so i like the idea of making it do less, and only using the cache db to track them20:38
patrickeastjgriffith: i think one of the alternative approaches we talked about a while ago was very similar, adding a new driver method like create_from_cache_image or something like that20:39
thingeejgriffith, smcginnis I don't remember introducing cinder.tests.unit.integrated20:39
smcginnisthingee: Yeah, I think we figured out they were original.20:39
smcginnisMost have copyright to Justin Santa Barbra20:40
patrickeastjgriffith: im trying to remember exactly why i moved away from that approach, i think the benefit of doing it from a little big higher level where it is now is that the cache entries are tracked as just normal volumes and that it can use any driver’s create from source functionality20:41
patrickeastjgriffith: but maybe you are right, and that approach is making it too restrictive20:42
*** IlyaG has joined #openstack-cinder20:43
*** IlyaG has quit IRC20:43
patrickeastjgriffith: i’ll maybe take a few hours today and play around with not using the internal tenant, high level cinder apis, and try just some new driver api’s… see if the tradeoffs make sense20:45
*** Rockyg has quit IRC20:45
*** Longgeek has quit IRC20:50
jgriffithpatrickeast: So maybe later today/this-evening we can look at it together?20:56
jgriffithpatrickeast: I think there's probably some cool things we could make happen there20:56
patrickeastjgriffith: sounds good20:57
*** thangp_afk is now known as thangp21:00
*** eharney has quit IRC21:01
*** ociuhandu has joined #openstack-cinder21:01
*** lpabon has quit IRC21:03
*** DericHorn-HP has quit IRC21:05
*** annashen has quit IRC21:05
*** annegentle has joined #openstack-cinder21:05
*** annashen has joined #openstack-cinder21:06
*** jungleboyj has joined #openstack-cinder21:06
*** simondodsley has quit IRC21:06
*** lpetrut has quit IRC21:08
*** dims_ has joined #openstack-cinder21:09
*** annasort has joined #openstack-cinder21:10
*** annashen has quit IRC21:10
*** dims_ has quit IRC21:14
*** annashen has joined #openstack-cinder21:14
*** thangp has quit IRC21:14
annasortHi! I could not find any cinder code that is using this policy rule in /etc/cinder/policy.json:   "volume:services": "rule:admin_api". There is "volume_extension:services": "rule:admin_api" that is used by cinder/api/contrib/services.py. Is anything actually using the first rule or can it be deleted?21:14
*** dims has joined #openstack-cinder21:16
*** rushil has quit IRC21:20
edmondswjungleboyj ^^ you know anything here, or who to direct that to? I don't see anything using that either21:24
*** ociuhandu has quit IRC21:25
*** jasondotstar has joined #openstack-cinder21:25
jungleboyjedmondsw and annasort I thought that was only in our internal code base and that it might be something PowerVC specific.21:26
jungleboyjHad copied Gerald McBrearty to see if he knew anything.21:26
annasortjungleboyj: you are not confusing this with last week's question about check_attach/detach cinder?21:28
edmondswjungleboyj no, https://github.com/openstack/cinder/blob/master/etc/cinder/policy.json#L5521:28
*** akerr has joined #openstack-cinder21:28
jungleboyjannasort: Oh, sorry, I am confused.21:29
jungleboyjannasort: If it doesn't appear to be used I would propose a patch to remove it and get some eyes on that to see if it concerns anyone.21:31
annasortok, I will open a bug, thanks21:31
jungleboyjIf you don't see it being used anywhere I would guess that it isn't being used anymore and its removal was just forgotten.21:31
annasortit does not appear to be used but I might be missing something21:31
*** dustins has quit IRC21:31
annasortok21:32
jungleboyj:-)  It wouldn't be the first time that has happened.21:32
annasort:-)21:32
*** akerr has quit IRC21:34
*** julim has quit IRC21:34
*** Yogi1 has quit IRC21:36
*** ianbrown has joined #openstack-cinder21:46
*** ianbrown has quit IRC21:46
*** Longgeek has joined #openstack-cinder21:47
*** merooney has quit IRC21:49
*** tpsilva has quit IRC21:55
*** DericHorn-HP has joined #openstack-cinder21:55
*** MentalRay has joined #openstack-cinder22:00
*** hodos has quit IRC22:02
*** Longgeek has quit IRC22:06
*** daneyon has joined #openstack-cinder22:09
*** bill_az has quit IRC22:10
*** daneyon_ has quit IRC22:12
*** gouthamr has quit IRC22:13
*** jungleboyj has quit IRC22:16
*** jasondotstar has quit IRC22:17
*** sparr has quit IRC22:18
*** sparr has joined #openstack-cinder22:18
*** mriedem is now known as mriedem_away22:23
*** bswartz has joined #openstack-cinder22:27
*** jasondotstar has joined #openstack-cinder22:37
*** annegentle has quit IRC22:40
*** annegentle has joined #openstack-cinder22:44
*** edmondsw has quit IRC22:47
openstackgerritAnish Bhatt proposed openstack/os-brick: [WIP] os-brick : Add support for --interface option in iscsiadm.  https://review.openstack.org/19345122:49
*** chlong_ has joined #openstack-cinder22:50
*** chlong_ has quit IRC22:50
anishtsekiyama: handled as requested ^22:50
*** chlong has quit IRC22:51
*** chlong has joined #openstack-cinder22:51
tsekiyamaanish: thanks, I'll try it again.22:51
*** dims has quit IRC22:54
*** DericHorn-HP has quit IRC22:58
*** lcurtis has quit IRC22:59
openstackgerritRaunak Kumar proposed openstack/cinder: Implements: blueprint nimble-add-extra-specs-support  https://review.openstack.org/19885323:00
*** jskinner has quit IRC23:01
*** annegentle has quit IRC23:02
*** daneyon has quit IRC23:05
*** jamielennox is now known as jamielennox|away23:11
*** reed has quit IRC23:15
*** reed_ has joined #openstack-cinder23:18
*** annegentle has joined #openstack-cinder23:18
*** ganso_ has quit IRC23:18
*** jaypipes has quit IRC23:18
*** annegentle has quit IRC23:20
*** jamielennox|away is now known as jamielennox23:22
*** Longgeek has joined #openstack-cinder23:32
*** annashen has quit IRC23:45
*** annashen has joined #openstack-cinder23:46
*** Longgeek has quit IRC23:50
*** annashen has quit IRC23:51
*** Yogi1 has joined #openstack-cinder23:52
*** Yogi1 has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!