| *** Longgeek has quit IRC | 00:00 | |
| *** lixiaoy11 has joined #openstack-cinder | 00:03 | |
| *** lixiaoy1 has quit IRC | 00:03 | |
| *** chlong has joined #openstack-cinder | 00:04 | |
| *** mriedem has quit IRC | 00:05 | |
| *** smoriya has joined #openstack-cinder | 00:09 | |
| *** jamielennox is now known as jamielennox|away | 00:26 | |
| *** DericHorn-HP has joined #openstack-cinder | 00:28 | |
| *** jamielennox|away is now known as jamielennox | 00:30 | |
| *** bill_az has quit IRC | 00:36 | |
| *** harlowja_at_home has joined #openstack-cinder | 00:37 | |
| *** DericHorn-HP has quit IRC | 00:40 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/195105 | 00:40 |
|---|---|---|
| *** harlowja_at_home has quit IRC | 00:47 | |
| *** lixiaoy1 has joined #openstack-cinder | 00:48 | |
| *** lixiaoy11 has quit IRC | 00:50 | |
| *** liuxg has joined #openstack-cinder | 01:06 | |
| openstackgerrit | Rakesh H S proposed openstack/cinder: Return 404 if volume type encryption is not found https://review.openstack.org/194677 | 01:09 |
| *** Yogi1 has joined #openstack-cinder | 01:12 | |
| *** zhenguo has joined #openstack-cinder | 01:16 | |
| *** Lee1092 has joined #openstack-cinder | 01:27 | |
| *** markvoelker has joined #openstack-cinder | 01:30 | |
| *** markvoelker has quit IRC | 01:35 | |
| openstackgerrit | wanghao proposed openstack/cinder: Support volume backup of qcow2 format volume https://review.openstack.org/182276 | 01:35 |
| *** vilobhmm has quit IRC | 01:35 | |
| *** jasondotstar has joined #openstack-cinder | 01:40 | |
| *** vilobhmm has joined #openstack-cinder | 01:49 | |
| openstackgerrit | liusheng proposed openstack/cinder: (WIP) Switch to oslo.reports https://review.openstack.org/196489 | 01:50 |
| openstackgerrit | Li Yingjun proposed openstack/cinder: Validate maximum limit for quota https://review.openstack.org/196490 | 01:51 |
| *** heyun has joined #openstack-cinder | 01:51 | |
| openstackgerrit | Li Yingjun proposed openstack/cinder: Validate maximum limit for quota https://review.openstack.org/165068 | 01:53 |
| *** liuxg has quit IRC | 01:54 | |
| *** Longgeek has joined #openstack-cinder | 01:59 | |
| *** liuxg has joined #openstack-cinder | 02:06 | |
| *** Longgeek has quit IRC | 02:11 | |
| *** davechen1 has joined #openstack-cinder | 02:13 | |
| *** vincent_hou has joined #openstack-cinder | 02:22 | |
| *** MRay has joined #openstack-cinder | 02:22 | |
| *** MRay has quit IRC | 02:23 | |
| vincent_hou | Is there anyone working on storpool, dell or infoortrend driver? | 02:23 |
| vincent_hou | I have got questions for your folks. | 02:24 |
| *** MentalRay has quit IRC | 02:25 | |
| *** Yogi1 has quit IRC | 02:48 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 02:48 |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: sheepdog: Add class for dog command executor https://review.openstack.org/194532 | 02:56 |
| *** liuxg has quit IRC | 02:58 | |
| *** haomaiwang has joined #openstack-cinder | 02:59 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Volume status management during migration https://review.openstack.org/186312 | 02:59 |
| openstackgerrit | Edwin Wang proposed openstack/cinder: Separate FlashSystem FC and iSCSI common code https://review.openstack.org/195382 | 02:59 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/195105 | 03:03 |
| openstackgerrit | Xi Yang proposed openstack/cinder: Fix timeout issue in EMC VNX driver unit test https://review.openstack.org/194573 | 03:06 |
| *** Longgeek has joined #openstack-cinder | 03:07 | |
| *** tobe has joined #openstack-cinder | 03:12 | |
| *** markvoelker has joined #openstack-cinder | 03:19 | |
| *** haomaiwang has quit IRC | 03:19 | |
| *** haomaiwang has joined #openstack-cinder | 03:19 | |
| *** Longgeek has quit IRC | 03:20 | |
| *** liuxg has joined #openstack-cinder | 03:23 | |
| *** markvoelker has quit IRC | 03:23 | |
| *** jasondotstar has quit IRC | 03:32 | |
| *** jasondotstar has joined #openstack-cinder | 03:33 | |
| *** haomaiwang has quit IRC | 03:34 | |
| *** vilobhmm has quit IRC | 03:34 | |
| *** haomaiwang has joined #openstack-cinder | 03:37 | |
| *** yamada-h has joined #openstack-cinder | 03:51 | |
| *** coolsvap|away is now known as coolsvap | 03:52 | |
| *** tobe has quit IRC | 03:55 | |
| *** yamada-h has quit IRC | 03:55 | |
| *** tobe has joined #openstack-cinder | 03:56 | |
| *** tobe has quit IRC | 03:56 | |
| *** rushiagr_away is now known as rushiagr | 03:57 | |
| *** tobe has joined #openstack-cinder | 03:59 | |
| *** rushiagr is now known as rushiagr_away | 04:03 | |
| *** liuxg has quit IRC | 04:05 | |
| *** MentalRay has joined #openstack-cinder | 04:09 | |
| *** Apoorva has joined #openstack-cinder | 04:10 | |
| *** tobe has quit IRC | 04:13 | |
| *** haomaiwang has quit IRC | 04:13 | |
| *** Apoorva has quit IRC | 04:20 | |
| *** DericHorn-HP has joined #openstack-cinder | 04:30 | |
| *** shyama has joined #openstack-cinder | 04:31 | |
| *** DericHorn-HP has quit IRC | 04:41 | |
| *** MentalRay has quit IRC | 04:45 | |
| *** nihilifer has joined #openstack-cinder | 04:45 | |
| openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO driver fix array snapshot problem https://review.openstack.org/193954 | 05:00 |
| *** patrickeast has quit IRC | 05:01 | |
| *** DericHorn-HP has joined #openstack-cinder | 05:02 | |
| *** vincent_hou has quit IRC | 05:06 | |
| *** DericHorn-HP has quit IRC | 05:06 | |
| *** markvoelker has joined #openstack-cinder | 05:08 | |
| *** markvoelker has quit IRC | 05:12 | |
| *** Longgeek has joined #openstack-cinder | 05:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/195105 | 05:19 |
| *** ociuhandu has quit IRC | 05:21 | |
| openstackgerrit | LisaLi proposed openstack/cinder: Add dependency check in RBD delete_snapshot https://review.openstack.org/193003 | 05:24 |
| *** Longgeek has quit IRC | 05:25 | |
| *** Longgeek has joined #openstack-cinder | 05:25 | |
| *** Longgeek has quit IRC | 05:34 | |
| *** Longgeek has joined #openstack-cinder | 05:34 | |
| openstackgerrit | Lin Yang proposed openstack/python-cinderclient: Improve error message when exceed cinder quota exceed https://review.openstack.org/178946 | 05:36 |
| *** shausy has joined #openstack-cinder | 05:43 | |
| openstackgerrit | Lin Yang proposed openstack/python-cinderclient: Improve error message when cinder quota exceeded https://review.openstack.org/178946 | 05:47 |
| openstackgerrit | LisaLi proposed openstack/cinder: Add dependency check in RBD delete_snapshot https://review.openstack.org/193003 | 05:52 |
| *** jasondotstar has quit IRC | 05:53 | |
| *** tobe has joined #openstack-cinder | 05:56 | |
| *** tobe has quit IRC | 05:58 | |
| *** tobe_ has joined #openstack-cinder | 05:58 | |
| *** nkrinner has joined #openstack-cinder | 06:00 | |
| openstackgerrit | Xi Yang proposed openstack/cinder: Provide snap copy feature in EMC VNX Cinder driver https://review.openstack.org/184733 | 06:01 |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: sheepdog: Add class for dog command executor https://review.openstack.org/194532 | 06:01 |
| *** DericHorn-HP has joined #openstack-cinder | 06:01 | |
| *** deepakcs has joined #openstack-cinder | 06:03 | |
| *** lpetrut has joined #openstack-cinder | 06:03 | |
| *** DericHorn-HP has quit IRC | 06:05 | |
| *** sgotliv has quit IRC | 06:07 | |
| openstackgerrit | Lin Yang proposed openstack/python-cinderclient: Remove redundant statement and refactor https://review.openstack.org/196546 | 06:08 |
| *** agarciam has joined #openstack-cinder | 06:10 | |
| *** shyama has quit IRC | 06:10 | |
| *** yamada-h has joined #openstack-cinder | 06:13 | |
| *** yamada-h has quit IRC | 06:27 | |
| *** shyama has joined #openstack-cinder | 06:28 | |
| openstackgerrit | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 06:37 |
| *** abhishekk has joined #openstack-cinder | 06:42 | |
| *** haomaiwang has joined #openstack-cinder | 06:46 | |
| openstackgerrit | Lin Yang proposed openstack/cinder: Fix typo in comment message https://review.openstack.org/196554 | 06:47 |
| openstackgerrit | Forest Romain proposed openstack/cinder: Correct overquota error message https://review.openstack.org/193018 | 06:47 |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Add missing backup/restore methods to Sheepdog driver https://review.openstack.org/162927 | 06:53 |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: sheepdog: Add class for dog command executor https://review.openstack.org/194532 | 06:53 |
| *** anshul has joined #openstack-cinder | 06:54 | |
| *** markvoelker has joined #openstack-cinder | 06:56 | |
| *** yamada-h has joined #openstack-cinder | 06:57 | |
| *** ociuhandu has joined #openstack-cinder | 07:01 | |
| *** markvoelker has quit IRC | 07:01 | |
| *** anshul has quit IRC | 07:02 | |
| *** yamada-h has quit IRC | 07:02 | |
| *** ociuhandu has quit IRC | 07:06 | |
| *** anshul has joined #openstack-cinder | 07:06 | |
| *** breitz1 has joined #openstack-cinder | 07:08 | |
| *** breitz has quit IRC | 07:08 | |
| *** yamada-h has joined #openstack-cinder | 07:11 | |
| *** yamada-h has quit IRC | 07:11 | |
| *** Longgeek has quit IRC | 07:13 | |
| *** Longgeek has joined #openstack-cinder | 07:13 | |
| openstackgerrit | wanghao proposed openstack/cinder-specs: Support query volume filter by glance metadata https://review.openstack.org/174778 | 07:14 |
| *** ociuhandu has joined #openstack-cinder | 07:14 | |
| openstackgerrit | wanghao proposed openstack/cinder: query volume detail support volume_glance_metadata https://review.openstack.org/147738 | 07:14 |
| *** wanghao has joined #openstack-cinder | 07:15 | |
| *** ronis has joined #openstack-cinder | 07:17 | |
| openstackgerrit | Kuo-tung Kao proposed openstack/python-cinderclient: Add more details for replication. https://review.openstack.org/196562 | 07:22 |
| openstackgerrit | wanghao proposed openstack/cinder: Do not allow to modify access for public volume type https://review.openstack.org/194549 | 07:25 |
| *** laughterwym has quit IRC | 07:32 | |
| *** jistr has joined #openstack-cinder | 07:32 | |
| *** lpetrut has quit IRC | 07:32 | |
| wanghao | Hey, guys, Do we propose freezing spec approval at L-2, right? | 07:34 |
| *** laughterwym has joined #openstack-cinder | 07:36 | |
| *** markus_z has joined #openstack-cinder | 07:37 | |
| *** sgotliv has joined #openstack-cinder | 07:43 | |
| *** chlong has quit IRC | 08:03 | |
| *** yamada-h has joined #openstack-cinder | 08:12 | |
| *** yamada-h has quit IRC | 08:17 | |
| *** pschaef has joined #openstack-cinder | 08:18 | |
| winston-d | d | 08:19 |
| *** jordanP has joined #openstack-cinder | 08:20 | |
| *** dtynan has quit IRC | 08:21 | |
| *** dtynan has joined #openstack-cinder | 08:21 | |
| *** liuxg has joined #openstack-cinder | 08:23 | |
| *** ronis has quit IRC | 08:29 | |
| openstackgerrit | Forest Romain proposed openstack/cinder: Correct overquota error message https://review.openstack.org/193018 | 08:33 |
| *** Longgeek has quit IRC | 08:38 | |
| *** yamada-h has joined #openstack-cinder | 08:44 | |
| *** markvoelker has joined #openstack-cinder | 08:45 | |
| *** lixiaoy1 has quit IRC | 08:46 | |
| *** kbyrne has quit IRC | 08:47 | |
| *** markvoelker has quit IRC | 08:50 | |
| openstackgerrit | Pradeep Sathasivam proposed openstack/cinder: Adds friendly zone name support https://review.openstack.org/180518 | 08:52 |
| *** kbyrne has joined #openstack-cinder | 08:53 | |
| *** ndipanov has joined #openstack-cinder | 08:54 | |
| *** laughterwym has quit IRC | 08:54 | |
| *** afazekas_ has joined #openstack-cinder | 08:56 | |
| *** ronis has joined #openstack-cinder | 08:59 | |
| *** abhishekk has quit IRC | 08:59 | |
| *** yrabl has quit IRC | 09:09 | |
| *** belmoreira has joined #openstack-cinder | 09:10 | |
| *** shausy has quit IRC | 09:11 | |
| *** pschaef has quit IRC | 09:11 | |
| *** shausy has joined #openstack-cinder | 09:12 | |
| *** Longgeek has joined #openstack-cinder | 09:12 | |
| *** ronis_ has joined #openstack-cinder | 09:17 | |
| openstackgerrit | Dave Chen proposed openstack/cinder: set/unset volume image metadata https://review.openstack.org/147726 | 09:18 |
| *** bluex-pl has joined #openstack-cinder | 09:18 | |
| *** bluex-pl has quit IRC | 09:19 | |
| *** bluex-pl has joined #openstack-cinder | 09:19 | |
| *** ronis has quit IRC | 09:22 | |
| *** shyama has quit IRC | 09:22 | |
| *** ronis__ has joined #openstack-cinder | 09:25 | |
| *** ronis_ has quit IRC | 09:27 | |
| *** breitz1 has quit IRC | 09:28 | |
| *** lpetrut has joined #openstack-cinder | 09:29 | |
| *** ronis__ has quit IRC | 09:30 | |
| *** breitz has joined #openstack-cinder | 09:30 | |
| *** ronis has joined #openstack-cinder | 09:31 | |
| *** laughterwym has joined #openstack-cinder | 09:34 | |
| *** ronis_ has joined #openstack-cinder | 09:34 | |
| *** shyama has joined #openstack-cinder | 09:35 | |
| *** ronis has quit IRC | 09:36 | |
| *** ronis_ has quit IRC | 09:40 | |
| openstackgerrit | Forest Romain proposed openstack/cinder: Correct overquota error message https://review.openstack.org/193018 | 09:41 |
| *** aix has joined #openstack-cinder | 09:53 | |
| *** openstackgerrit has quit IRC | 09:53 | |
| *** davechen1 has left #openstack-cinder | 09:53 | |
| *** openstackgerrit has joined #openstack-cinder | 09:53 | |
| *** uschreiber_ has joined #openstack-cinder | 10:03 | |
| *** uschreiber_ has quit IRC | 10:05 | |
| dulek | theanalyst: | 10:10 |
| dulek | theanalyst: Sorry, missed backspace. ;) | 10:11 |
| openstackgerrit | chenzongliang proposed openstack/cinder: Refactor Huawei Volume driver https://review.openstack.org/188240 | 10:23 |
| *** haomaiwang has quit IRC | 10:26 | |
| *** yamada-h has quit IRC | 10:27 | |
| *** ronis has joined #openstack-cinder | 10:28 | |
| *** markvoelker has joined #openstack-cinder | 10:34 | |
| *** dims has joined #openstack-cinder | 10:37 | |
| openstackgerrit | Sasikanth Eda proposed openstack/cinder: GPFS volume encryption-at-rest support https://review.openstack.org/195507 | 10:39 |
| *** markvoelker has quit IRC | 10:40 | |
| *** bluex-pl has quit IRC | 10:41 | |
| *** IanGovett has joined #openstack-cinder | 10:42 | |
| *** shyama has quit IRC | 10:46 | |
| *** jistr_ has joined #openstack-cinder | 10:49 | |
| *** afazekas__ has joined #openstack-cinder | 10:49 | |
| *** jistr has quit IRC | 10:51 | |
| *** shyama has joined #openstack-cinder | 10:51 | |
| *** afazekas_ has quit IRC | 10:53 | |
| *** jistr_ has quit IRC | 10:54 | |
| *** afazekas__ has quit IRC | 10:54 | |
| *** liuxg has quit IRC | 10:55 | |
| *** yamada-h has joined #openstack-cinder | 10:57 | |
| openstackgerrit | Pradeep Sathasivam proposed openstack/cinder: Adds VF support with HTTPS southbound connector https://review.openstack.org/184799 | 11:01 |
| openstackgerrit | Sergey Vilgelm proposed openstack/cinder: Use versionutils from oslo.log https://review.openstack.org/196628 | 11:02 |
| *** yamada-h has quit IRC | 11:02 | |
| *** jistr_ has joined #openstack-cinder | 11:06 | |
| *** afazekas__ has joined #openstack-cinder | 11:07 | |
| *** rakesh_mishra has joined #openstack-cinder | 11:08 | |
| *** deepakcs has quit IRC | 11:09 | |
| openstackgerrit | Sergey Vilgelm proposed openstack/cinder: Use versionutils from oslo.log https://review.openstack.org/196628 | 11:10 |
| *** coolsvap is now known as coolsvap|away | 11:10 | |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Create volume backing in specific clusters https://review.openstack.org/186664 | 11:17 |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Change inventory folder hierarchy https://review.openstack.org/193095 | 11:21 |
| openstackgerrit | Vipin Balachandran proposed openstack/cinder: VMware: Add volume ID in vCenter's volume config https://review.openstack.org/194534 | 11:22 |
| *** bluex-pl has joined #openstack-cinder | 11:25 | |
| *** avishay has joined #openstack-cinder | 11:25 | |
| avishay | jgriffith: hey | 11:26 |
| avishay | jgriffith: i'm running juno and just applied your patch "Remove iscsi_helper calls from base iscsi driver" | 11:26 |
| avishay | jgriffith: looks like it breaks the lio driver because you added a call to lio's terminate_connection, and that method isn't implemented | 11:27 |
| avishay | jgriffith: please take a look and let me know | 11:27 |
| *** avishay_ has joined #openstack-cinder | 11:31 | |
| *** avishay has quit IRC | 11:32 | |
| *** markvoelker has joined #openstack-cinder | 11:35 | |
| *** markvoelker has quit IRC | 11:40 | |
| openstackgerrit | Jordan Pittier proposed openstack/os-brick: [WIP]Remotefs: add ScalityFS support https://review.openstack.org/196631 | 11:43 |
| *** avishay_ is now known as avishay | 11:45 | |
| *** heyun has quit IRC | 11:45 | |
| *** tobe_ has quit IRC | 11:49 | |
| *** shyama has quit IRC | 11:51 | |
| *** markvoelker has joined #openstack-cinder | 11:55 | |
| *** aarefiev_home has joined #openstack-cinder | 12:01 | |
| *** markus_z has quit IRC | 12:01 | |
| *** dalgaaf has joined #openstack-cinder | 12:02 | |
| *** yrabl has joined #openstack-cinder | 12:06 | |
| *** markus_z has joined #openstack-cinder | 12:06 | |
| openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Fix cinder.conf.sample generation https://review.openstack.org/195619 | 12:10 |
| openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Fix cinder.conf.sample generation https://review.openstack.org/195619 | 12:12 |
| openstackgerrit | Pradeep Sathasivam proposed openstack/cinder: Handle attachment of second volume https://review.openstack.org/196640 | 12:13 |
| openstackgerrit | Szymon Wróblewski proposed openstack/cinder: Tooz locks https://review.openstack.org/183537 | 12:17 |
| *** erlon has joined #openstack-cinder | 12:17 | |
| *** edmondsw has joined #openstack-cinder | 12:27 | |
| *** jungleboyj has quit IRC | 12:30 | |
| *** rakesh_mishra has quit IRC | 12:34 | |
| *** avishay has quit IRC | 12:38 | |
| *** mtreinish has quit IRC | 12:40 | |
| *** mtreinish has joined #openstack-cinder | 12:40 | |
| *** haypo has joined #openstack-cinder | 12:42 | |
| *** Yogi1 has joined #openstack-cinder | 12:43 | |
| haypo | hey. i'm working on python 3, and i found a crazy bug. quota_reserve() uses quotas[r] >= 0 where quotas[r] is a Quota instance of cinder.db.sqlalchemy.models | 12:43 |
| *** nihilifer has quit IRC | 12:43 | |
| haypo | problem: Quota is not comparable. in this case, Python uses a stupid rule: it compares the type name of the two values, basically: strcmp("Quota", "int") | 12:44 |
| *** bill_az has joined #openstack-cinder | 12:45 | |
| *** chlong has joined #openstack-cinder | 12:46 | |
| openstackgerrit | Kazumasa Nomura proposed openstack/cinder: Fix cinder.conf.sample generation https://review.openstack.org/195619 | 12:47 |
| *** eharney has quit IRC | 12:48 | |
| *** Yogi1 has quit IRC | 12:49 | |
| haypo | maybe it's a bug in the unit test (test_db_api.py) | 12:50 |
| *** kjnelson has joined #openstack-cinder | 12:54 | |
| *** avishay has joined #openstack-cinder | 12:55 | |
| *** amoturi has joined #openstack-cinder | 12:56 | |
| dulek | haypo: Hm... | 12:57 |
| dulek | haypo: return {k: v['limit'] for k, v in quotas.items()} | 12:57 |
| dulek | haypo: In cinder.quota (line 264) | 12:57 |
| dulek | So it's rather a dict. | 12:57 |
| dulek | Outside of the unit tests... | 12:58 |
| haypo | dulek: i'm interested by the type of dict values | 12:58 |
| haypo | dulek: it looks like the root object comes from db.quota_get_all_by_project(...).get(...) | 12:58 |
| dulek | haypo: Yeah, but it returns a dict also. | 12:59 |
| dulek | quota.py#209-214 | 12:59 |
| haypo | dulek: the dict is used as a convenient container for quota name => quota object | 12:59 |
| *** DericHorn-HP has joined #openstack-cinder | 12:59 | |
| haypo | dulek: my question is: is the quota object a regular Python int object, or a Quota object of cinder.db.sqlalchemy.models? | 12:59 |
| haypo | (there is an intermediate level of dict between _get_quotas & get_project_quotas, but it's removed at the end of _get_quotas, as you showed) | 13:00 |
| *** avishay has quit IRC | 13:00 | |
| *** avishay has joined #openstack-cinder | 13:01 | |
| dulek | Take a look into db.quota_class_get_all_by_name | 13:01 |
| dulek | This returns a dict with integers I think. | 13:01 |
| haypo | dulek: class quotas and quotas are different things. i'm interested by quota_reserve() which calls _get_quotas() | 13:02 |
| dulek | Then get_projects_quotas uses class_quotas.get(resource.name, | 13:02 |
| dulek | default_quotas[resource.name]) to produce a dict. | 13:02 |
| dulek | I understand, just going bottom-up. | 13:03 |
| *** krtaylor has quit IRC | 13:04 | |
| dulek | db.quota_class_get_all_by_name and db.quota_get_all_by_project return dicts of integers. | 13:04 |
| *** smoriya has quit IRC | 13:05 | |
| dulek | Then these are used to build quotas in get_project_quotas (cinder.quota#209-214) | 13:05 |
| dulek | So that's still dict. | 13:05 |
| *** fifieldt has joined #openstack-cinder | 13:06 | |
| dulek | And then get_project_quotas is used in _get_quotas | 13:06 |
| dulek | So v['limit'] there is an int. | 13:06 |
| *** jwcroppe has quit IRC | 13:06 | |
| haypo | dulek: oh, quota_get_all_by_project() returns the hard_limit attribute of quotas, not Quota instances | 13:07 |
| dulek | haypo: Exactly, that's what I wanted to show. :) | 13:07 |
| *** jwcroppe has joined #openstack-cinder | 13:07 | |
| haypo | dulek: ok. so it's more a bug in test_db_api.py, thanks :) | 13:07 |
| dulek | haypo: np | 13:08 |
| *** jwcroppe has quit IRC | 13:12 | |
| haypo | dulek: i prefer a bug in the test than a bug in the code ;) | 13:13 |
| *** zhenguo has quit IRC | 13:13 | |
| dulek | haypo: It would be very strange to have such big bug go unnoticed. | 13:14 |
| haypo | dulek: yes :) | 13:14 |
| *** krtaylor has joined #openstack-cinder | 13:17 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields https://review.openstack.org/183222 | 13:18 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix saving tz aware datetimes in Versioned Objects https://review.openstack.org/196071 | 13:18 |
| *** rakesh_mishra has joined #openstack-cinder | 13:18 | |
| *** rakesh_mishra has quit IRC | 13:19 | |
| *** rakesh_mishra has joined #openstack-cinder | 13:20 | |
| *** Zhongjun has joined #openstack-cinder | 13:20 | |
| *** avishay has quit IRC | 13:20 | |
| *** eharney has joined #openstack-cinder | 13:20 | |
| *** avishay has joined #openstack-cinder | 13:23 | |
| *** jwcroppe has joined #openstack-cinder | 13:24 | |
| *** julim has joined #openstack-cinder | 13:24 | |
| *** mriedem has joined #openstack-cinder | 13:30 | |
| *** edmondsw has quit IRC | 13:33 | |
| *** rmesta has joined #openstack-cinder | 13:37 | |
| *** rmesta has left #openstack-cinder | 13:38 | |
| *** afazekas__ has quit IRC | 13:38 | |
| *** thangp has joined #openstack-cinder | 13:43 | |
| *** mtanino has joined #openstack-cinder | 13:43 | |
| *** edmondsw has joined #openstack-cinder | 13:44 | |
| *** eharney has quit IRC | 13:51 | |
| *** jecarey has joined #openstack-cinder | 13:52 | |
| *** superdan is now known as dansmith | 13:57 | |
| *** boris-42 has joined #openstack-cinder | 13:59 | |
| *** DericHorn-HP has quit IRC | 13:59 | |
| *** aarefiev_home has quit IRC | 13:59 | |
| *** avishay_ has joined #openstack-cinder | 13:59 | |
| *** avishay has quit IRC | 13:59 | |
| *** DericHorn-HP has joined #openstack-cinder | 14:02 | |
| *** eharney has joined #openstack-cinder | 14:06 | |
| *** harlowja_at_home has joined #openstack-cinder | 14:11 | |
| *** dtynan has quit IRC | 14:15 | |
| *** dtynan has joined #openstack-cinder | 14:16 | |
| *** jecarey has quit IRC | 14:18 | |
| *** r-daneel has joined #openstack-cinder | 14:19 | |
| *** dims has quit IRC | 14:21 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 14:21 |
| dulek | thangp: Hi, can you look at https://review.openstack.org/#/c/195027/4/cinder/objects/cgsnapshot.py to tell if my comment there is valid? | 14:24 |
| *** dims has joined #openstack-cinder | 14:24 | |
| dulek | thangp: I've got a little confused when I realized that you don't make it possible to update volume in Snapshot's save method. | 14:24 |
| *** avishay_ has quit IRC | 14:25 | |
| thangp | dulek: sure | 14:25 |
| thangp | dulek: so you dont want to update another object in save() | 14:27 |
| thangp | dulek: if you want to update the other object, you have to use that obj's save() | 14:28 |
| thangp | dulek: it's not done because it would be messy, cascading saves for multiple objects | 14:29 |
| dulek | So I shouldn't use volume's save in snapshot save. | 14:29 |
| thangp | yup | 14:29 |
| dulek | I should modify volume and do save on it explicitly. | 14:29 |
| dulek | Hey, DTadrzak, sorry for confusing you! ;) | 14:30 |
| thangp | so you should do stuff on vol, then save, then refresh the snapshot | 14:30 |
| thangp | dulek: the save for cgsnapshot should raise an exception if it is trying to save the cggroup though | 14:32 |
| thangp | because we dont want to change consistencygroup changes in cgsnapshot save() | 14:32 |
| dulek | thangp: Thanks for explaingin! | 14:34 |
| thangp | dulek: np | 14:34 |
| openstackgerrit | Dave Chen proposed openstack/cinder: set/unset volume image metadata https://review.openstack.org/147726 | 14:37 |
| *** garthb has joined #openstack-cinder | 14:37 | |
| *** garthb_ has joined #openstack-cinder | 14:37 | |
| *** annegentle has joined #openstack-cinder | 14:37 | |
| *** annegentle has quit IRC | 14:38 | |
| *** annegentle has joined #openstack-cinder | 14:39 | |
| *** vincent_hou has joined #openstack-cinder | 14:40 | |
| vincent_hou | Hi folks. Anyone working on dell, storpool or infortrend driver here? | 14:41 |
| *** DericHorn-HP has quit IRC | 14:41 | |
| *** Apoorva has joined #openstack-cinder | 14:42 | |
| *** mildan has joined #openstack-cinder | 14:44 | |
| *** MIDENN_ has quit IRC | 14:45 | |
| jgriffith | avishay actually yes, but I didn't add that :) | 14:46 |
| *** shausy has quit IRC | 14:48 | |
| smcginnis | vincent_hou: Yep. Saw your ML post. Will do some testing after my next meeting to make sure it's OK. | 14:52 |
| smcginnis | vincent_hou: Looks fine, but I will verify. | 14:52 |
| *** pckizer_ is now known as pckize | 14:52 | |
| *** pckize is now known as pckizer | 14:52 | |
| vincent_hou | I am changing now. | 14:53 |
| vincent_hou | Some fixes in the test. | 14:53 |
| smcginnis | vincent_hou: OK, thanks. | 14:53 |
| vincent_hou | Just give a review when I upload the new one. | 14:53 |
| vincent_hou | Thx, buddy. | 14:54 |
| smcginnis | vincent_hou: Will do, on my list. Thanks Vincent! | 14:54 |
| jgriffith | geguileo: ping | 14:55 |
| geguileo | jgriffith: Hi | 14:55 |
| jgriffith | geguileo: hey, how's it going :) | 14:56 |
| jgriffith | geguileo: I was just looking at https://review.openstack.org/#/c/183465/ | 14:56 |
| geguileo | jgriffith: Not bad, and you? | 14:56 |
| jgriffith | geguileo: avishay pointed out that backport might be bad :( | 14:56 |
| jgriffith | geguileo: I'm good by the way... think this is the first time I've really pinged you on IRC :) | 14:56 |
| geguileo | jgriffith: Yep, first time :) | 14:56 |
| jgriffith | geguileo: Well... you've submitted a ton of GREAT stuff so finally I get to chat :) | 14:57 |
| *** mildan has quit IRC | 14:57 | |
| *** mdenny has joined #openstack-cinder | 14:57 | |
| geguileo | jgriffith: Yes that patch could create a problem for users who have misconfigurations | 14:57 |
| jgriffith | geguileo: Anyway... I think the addition of the target_helper.terminate_connection breaks things in Juno | 14:57 |
| geguileo | jbernard: Really? | 14:58 |
| jgriffith | geguileo: well... more precisely Juno doesn't have the defined target classes | 14:58 |
| *** pradipta has joined #openstack-cinder | 14:58 | |
| *** pckizer is now known as pck | 14:58 | |
| geguileo | jbernard: Sorry, that wasn't for you XD | 14:58 |
| geguileo | jgriffith: Really? | 14:58 |
| jbernard | eh? | 14:58 |
| geguileo | jbernard: Ignore me, please :) | 14:58 |
| jgriffith | geguileo: so that terminate_connection isn't actually defined anywhere I don't hink | 14:58 |
| jgriffith | think | 14:58 |
| jbernard | well yes, really i suppose | 14:58 |
| jgriffith | geguileo: I may be missing it, as I don't have an LIO env (let alone a Juno one) any longer | 14:58 |
| geguileo | jgriffith: I'll have to check | 14:59 |
| *** jecarey has joined #openstack-cinder | 14:59 | |
| harlowja_at_home | jgriffith, so u gonna get me a toyota truck now? | 15:00 |
| harlowja_at_home | ll | 15:00 |
| harlowja_at_home | lol | 15:00 |
| jgriffith | geguileo: cool... lemme know, if you don't have time I can try and dig into it. LIO on Uubnut is sooo hard though :) | 15:00 |
| jgriffith | harlowja_at_home: LOL | 15:00 |
| jgriffith | harlowja_at_home: that is the BEST top gear episode ever | 15:00 |
| harlowja_at_home | :-P | 15:00 |
| geguileo | jgriffith: Ok, I'll try it out and let you know | 15:00 |
| jgriffith | harlowja_at_home: and I tried to figure out a way to get that Hilux Diesel in the states for like a year | 15:00 |
| harlowja_at_home | burn it, drop it from buildings, damn thing won't die :-P | 15:00 |
| *** patrickeast has joined #openstack-cinder | 15:00 | |
| jgriffith | harlowja_at_home: spoiler alert "you can't" | 15:00 |
| harlowja_at_home | ha | 15:01 |
| jgriffith | harlowja_at_home: best you can do is by the mercedes D engine and drop it in yourself | 15:01 |
| jgriffith | harlowja_at_home: which I considered | 15:01 |
| harlowja_at_home | US diesel weirdo laws stopping that? | 15:01 |
| jgriffith | harlowja_at_home: but insted looked dropping a Cummins in my Ford :) | 15:01 |
| harlowja_at_home | my tractor is my girlfriend | 15:01 |
| jgriffith | harlowja_at_home: yeah, diesel laws in US | 15:01 |
| harlowja_at_home | ^ in country music voice | 15:01 |
| jgriffith | harlowja_at_home: but then some export issue | 15:02 |
| *** nkrinner has quit IRC | 15:02 | |
| jgriffith | harlowja_at_home: :) | 15:02 |
| harlowja_at_home | :) | 15:02 |
| * harlowja_at_home grew up in hick land, so its ok to say that stuff :-P | 15:02 | |
| * harlowja_at_home may or may not be a hick to :-P | 15:02 | |
| jgriffith | :) | 15:02 |
| jgriffith | Red red red red... red-neck | 15:03 |
| harlowja_at_home | bubble gum | 15:03 |
| jgriffith | But not the narrow minded stupid kind of red-neck | 15:03 |
| jgriffith | :) | 15:03 |
| harlowja_at_home | lol | 15:03 |
| harlowja_at_home | ya | 15:03 |
| harlowja_at_home | just the crazy other kind, ha | 15:03 |
| jgriffith | exactly! | 15:03 |
| jgriffith | There is a difference | 15:03 |
| harlowja_at_home | with er guns and er cars | 15:03 |
| harlowja_at_home | lol | 15:03 |
| harlowja_at_home | *yer | 15:03 |
| jgriffith | LOL | 15:03 |
| harlowja_at_home | and your computerssss | 15:04 |
| jgriffith | Puters | 15:04 |
| * harlowja_at_home actually my dad has a car-lift in his barn (no cows...) so always grew up around that stuff (he's a retired mech. enginner) | 15:04 | |
| jgriffith | Nice!!! | 15:05 |
| jgriffith | geguileo: thanks by the way :) | 15:06 |
| harlowja_at_home | https://www.flickr.com/photos/jshharlow/3056218725/in/album-72157601310382418/ (kids u not) | 15:06 |
| jgriffith | geguileo: Sorry, harlowja_at_home distracted me :) | 15:06 |
| geguileo | jgriffith: np :) | 15:07 |
| jgriffith | harlowja_at_home: Awesome! | 15:07 |
| harlowja_at_home | :-P | 15:07 |
| kashyap | harlowja_at_home: Just trolling: are you sure? Don't you want the nick to be: harlowja_at_home_no_really_I_am_at_home? :P | 15:08 |
| harlowja_at_home | lol | 15:08 |
| harlowja_at_home | kashyap, thats one of my fallback names, lol | 15:08 |
| harlowja_at_home | i think | 15:08 |
| harlowja_at_home | second choice 'harlowja_still_at_home' third choice 'harlow_really_at_home' | 15:08 |
| harlowja_at_home | lol | 15:08 |
| harlowja_at_home | ^ not kidding | 15:08 |
| kashyap | Sorry, couldn't resist not to say out loud. :-) | 15:09 |
| *** ociuhandu has quit IRC | 15:10 | |
| harlowja_at_home | jgriffith, https://www.flickr.com/photos/jshharlow/4136601590/in/album-72157622756899623/ (there u go), ha | 15:10 |
| * harlowja_at_home is the real deal dawg (or at least his parents are), ha | 15:10 | |
| *** lpetrut has quit IRC | 15:11 | |
| harlowja_at_home | full on country-folk, lol | 15:11 |
| jgriffith | harlowja_at_home: Rock on!! | 15:11 |
| harlowja_at_home | ha | 15:11 |
| jgriffith | harlowja_at_home: that's what I'm talking about | 15:11 |
| harlowja_at_home | :-P | 15:11 |
| jgriffith | harlowja_at_home: but if you were "really" country, you'd be like me when with a block and tackle and a come along lifting the tractor up by the rafters in the barn :) | 15:12 |
| jgriffith | harlowja_at_home: and then using old tree-stumps to brace it up LOL | 15:12 |
| *** avishay_ has joined #openstack-cinder | 15:12 | |
| * jgriffith wonders how he's still alive | 15:12 | |
| harlowja_at_home | ^ and that is how we lose jgriffith to death by squishing, lol | 15:12 |
| jgriffith | Exactly! | 15:12 |
| *** lpetrut has joined #openstack-cinder | 15:13 | |
| *** ociuhandu has joined #openstack-cinder | 15:13 | |
| harlowja_at_home | overall thats 10x more country-like though, agreed | 15:13 |
| harlowja_at_home | do it while intoxicated and 20x, lol | 15:13 |
| jgriffith | harlowja_at_home: or at least 10x more stupid!!! | 15:13 |
| harlowja_at_home | :) | 15:13 |
| *** jungleboyj has joined #openstack-cinder | 15:14 | |
| harlowja_at_home | ok, back to work folks, no more country bumpkin talk, lol | 15:14 |
| *** dannywilson has joined #openstack-cinder | 15:16 | |
| *** dannywilson has quit IRC | 15:18 | |
| *** dannywilson has joined #openstack-cinder | 15:18 | |
| jungleboyj | Does anyone know why we are no longer getting links to reviews in bugs when they are moved to 'In Progress'? | 15:18 |
| *** avishay_ has quit IRC | 15:19 | |
| *** ronis has quit IRC | 15:19 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 15:23 |
| openstackgerrit | Thang Pham proposed openstack/cinder: WIP: RPC and object versioning https://review.openstack.org/184404 | 15:23 |
| *** e0ne has joined #openstack-cinder | 15:23 | |
| *** DericHorn-HP has joined #openstack-cinder | 15:25 | |
| *** e0ne is now known as e0ne_ | 15:25 | |
| *** e0ne_ is now known as e0ne | 15:25 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 15:27 |
| openstackgerrit | Michal Dulko proposed openstack/cinder: WIP: Refactoring of manager's create_volume flow https://review.openstack.org/193167 | 15:27 |
| *** david-ly_ is now known as david-lyle | 15:27 | |
| *** anshul has quit IRC | 15:27 | |
| dulek | harlowja_at_home, jgriffith: Since you both seem to be in good mood this morning - can you take a look on https://review.openstack.org/#/c/193167? | 15:28 |
| dulek | harlowja_at_home, jgriffith: Some feedback if I'm even going in right direction on that would be great. :) | 15:28 |
| *** belmoreira has quit IRC | 15:29 | |
| openstackgerrit | Dave Chen proposed openstack/python-cinderclient: Add commands for modifying image metadata https://review.openstack.org/147077 | 15:30 |
| jgriffith | dulek: so am I completely wrong or is that really more "adding buld metadata create" as opposed to refactoring flow? | 15:30 |
| jgriffith | err... "bulk" | 15:30 |
| *** lpetrut has quit IRC | 15:31 | |
| dulek | jgriffith: That's for completing a TODO item there. I'm also removing unused parameters and making use of TaskFlow mechanism (not yet merged) instead of injecting information if volume was rescheduled into the Exception. | 15:31 |
| dulek | jgriffith: And... That's it I think. | 15:32 |
| jgriffith | dulek: yeah, looking at the dependency now :) | 15:32 |
| dulek | jgriffith: That's why I'm asking for a little help here. | 15:32 |
| patrickeast | hmm thats confusing, i’m using the cisco zone manager http://bit.ly/1FKv1Ju but getting errors saying its trying to use the brocade cli? http://bit.ly/1Jt8mck | 15:33 |
| patrickeast | hemnafk: ^ any ideas whats going on there? | 15:33 |
| *** hemnafk is now known as hemna | 15:33 | |
| hemna | mornin | 15:33 |
| hemna | what's up | 15:33 |
| Swanson | IHNJH,IJLS "death by squishing." | 15:33 |
| patrickeast | hemna: hey | 15:33 |
| *** vincent_hou_ has joined #openstack-cinder | 15:33 | |
| hemna | Cisco and the FCZM | 15:33 |
| patrickeast | hemna: just saw some errors on my ci system due to the zone manager, and is confused | 15:34 |
| hemna | um...yah, our experience, which isn't much has been bad w/ cisco | 15:34 |
| patrickeast | haha | 15:34 |
| hemna | ah yah, that bug | 15:34 |
| hemna | I think it's an open bug against Cisco already. | 15:34 |
| patrickeast | ah ok | 15:34 |
| jgriffith | dulek: can you help me understand how the CG stuff is working now in your patch? | 15:34 |
| patrickeast | guess i’ll go take a look | 15:35 |
| patrickeast | unless i can scrounge up a brocade switch for my testbed :D | 15:35 |
| *** vincent_hou has quit IRC | 15:35 | |
| jgriffith | dulek: I see you're note about them being unused, I may have missed a patch that changed that | 15:35 |
| *** vincent_hou_ is now known as vincent_hou | 15:35 | |
| jgriffith | Or maybe I saw it and just don't remember :) | 15:35 |
| dulek | jgriffith: So when reviewing CG stuff objects I've noticed that consistencygroup_id and cgsnapshot_id aren't passed to the driver. | 15:35 |
| hemna | patrickeast, I'm trying to find it | 15:36 |
| dulek | jgriffith: Maybe they are, but anyway - they are extracted from the volume db row. | 15:36 |
| dulek | API saves them there. | 15:37 |
| jgriffith | dulek: right... but I'm sort of confused how that works (or maybe it doesn't) becasue the scheduler needs to place on a host that support CG's | 15:37 |
| hemna | patrickeast, is this master ? | 15:37 |
| patrickeast | hemna: uhh… good question | 15:38 |
| jgriffith | dulek: not trying to rat-hole on your patch, just trying to figure out how this is working now :) | 15:38 |
| harlowja_at_home | dulek, looking at | 15:38 |
| harlowja_at_home | oh hey whats this taskflow thing, ha | 15:38 |
| dulek | jgriffith: Oh, no problem, let me look at the code to answer you. | 15:38 |
| patrickeast | hemna: yea https://review.openstack.org/#/c/180518/7 | 15:38 |
| patrickeast | hemna: was the review being tested | 15:38 |
| patrickeast | oh | 15:39 |
| patrickeast | wait | 15:39 |
| jgriffith | dulek: I'm looking as well :) it's still in the filter scheduler | 15:39 |
| hemna | hrmm | 15:39 |
| patrickeast | hemna: maybe thats a legit zone manager failure | 15:39 |
| harlowja_at_home | dulek, jgriffith and i are always in good moods :-P | 15:39 |
| patrickeast | just actually looked at what the review was | 15:39 |
| jgriffith | harlowja_at_home: +1 | 15:39 |
| dulek | jgriffith: Okay, so scheduler gets the consistencygroup_id. | 15:39 |
| hemna | patrickeast, I thought the brocade reviews were -2'd due to no CI reporting still | 15:39 |
| patrickeast | hemna: same | 15:40 |
| dulek | jgriffith: Because API passes it. | 15:40 |
| patrickeast | hemna: speaking of which… is there going to be a cisco ci? | 15:40 |
| hemna | patrickeast, lol | 15:40 |
| dulek | jgriffith: In API there's another codepath where there's direct call to c-vol - bypassing the scheduler. | 15:41 |
| patrickeast | hemna: or have i accidently taken that role with my system? | 15:41 |
| *** haypo has quit IRC | 15:41 | |
| hemna | patrickeast, well, there is supposed to be, but considering I haven't heard from the Cisco folks at all in a while.... | 15:41 |
| jgriffith | dulek: yuk | 15:41 |
| hemna | they still have bugs open that I assigned to them in Vancouver..... | 15:41 |
| patrickeast | ouch | 15:41 |
| hemna | patrickeast, https://bugs.launchpad.net/cinder/+bug/1426106 https://bugs.launchpad.net/cinder/+bug/1455140 https://bugs.launchpad.net/cinder/+bug/1438919 | 15:42 |
| openstack | Launchpad bug 1426106 in Cinder "Custom zone name prefix is not getting set for Cisco Driver" [Undecided,Confirmed] - Assigned to Midun Kumar (mneelame) | 15:42 |
| openstack | Launchpad bug 1455140 in Cinder "Cisco FCZM issue on attach syntax error on cli command" [Undecided,New] - Assigned to Al Lau (alau2) | 15:42 |
| openstack | Launchpad bug 1438919 in Cinder "CiscoFCSanLookupService.get_device_mapping_from_network method should not use zoning_vsan as the key of the device mapping dictionary" [Undecided,New] - Assigned to Al Lau (alau2) | 15:42 |
| jgriffith | dulek: but yeah, I see it now | 15:42 |
| hemna | so at this point.....it's only a matter of time before Cisco gets a removal patch | 15:42 |
| patrickeast | crap | 15:42 |
| *** harlowja_still_a has joined #openstack-cinder | 15:42 | |
| hemna | I'm tired of holding their hands | 15:42 |
| * patrickeast needs to find a new switch | 15:42 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Volume status management during migration https://review.openstack.org/186312 | 15:43 |
| *** laughterwym has quit IRC | 15:43 | |
| patrickeast | hemna: lemmie ask around a bit here… maybe one of us can look into it, at a minimum to just make our ci stop failing | 15:43 |
| jgriffith | dulek: so it's a strict requirement to use types that are associated with CG's | 15:43 |
| hemna | patrickeast, can you just remove the FCZM from the test chain for your array? | 15:44 |
| jgriffith | dulek: which explains (kinda) why that's not actually used later | 15:44 |
| hemna | patrickeast, just disable it ? and do open zone | 15:44 |
| vincent_hou | smcginnis: The patch is already there. | 15:44 |
| dulek | jgriffith: That would probably be it. | 15:44 |
| smcginnis | vincent_hou: Cool, just got back from my meeting. I'll grab it and try it out. | 15:44 |
| patrickeast | hemna: yea, we can do that too, but id rather be testing more what a customer would actually use | 15:44 |
| jgriffith | dulek: but that's very confusing IMO | 15:44 |
| patrickeast | maybe as a short term fix | 15:44 |
| jgriffith | dulek: :) | 15:45 |
| vincent_hou | OK | 15:45 |
| hemna | patrickeast, we don't have the FCZM in our CI chain. | 15:45 |
| jgriffith | dulek: so look at the create_what in the api | 15:45 |
| hemna | brb | 15:45 |
| jgriffith | dulek: your patch doesn't remove the consistencygroup info from the flow create piece | 15:45 |
| patrickeast | hemna: yea, i think we might be the only ones right now : ( | 15:46 |
| jgriffith | dulek: but it takes it out of the rpc pieces | 15:46 |
| patrickeast | which worries me a little bit | 15:46 |
| *** harlowja_at_home has quit IRC | 15:46 | |
| *** aarefiev_home has joined #openstack-cinder | 15:46 | |
| *** e0ne has quit IRC | 15:46 | |
| *** MentalRay has joined #openstack-cinder | 15:47 | |
| dulek | jgriffith: Hm... Why should it? I'm working on c-vol here, not c-api. | 15:48 |
| *** e0ne has joined #openstack-cinder | 15:48 | |
| *** annegentle has quit IRC | 15:48 | |
| jgriffith | dulek: so not saying it should :) | 15:48 |
| dulek | jgriffith: CG stuff is passed into c-api create_volume flow and sent to scheduler. | 15:48 |
| jgriffith | dulek: so the thing is IMHO flows/api/create_volume has become a bit confusing with all the if/else | 15:48 |
| jgriffith | dulek: so your change makes sense | 15:48 |
| *** annegentle has joined #openstack-cinder | 15:49 | |
| *** vincent_hou has quit IRC | 15:49 | |
| jgriffith | dulek: becasue where you removed it is the if not host/else | 15:49 |
| jgriffith | dulek: so we have a host and bypass the scheduler in that case as you pointed out earlier | 15:49 |
| *** vincent_hou has joined #openstack-cinder | 15:49 | |
| *** asselin_ has joined #openstack-cinder | 15:50 | |
| dulek | jgriffith: Yup.. | 15:50 |
| openstackgerrit | Shay Halsband proposed openstack/cinder: XtremIO driver fix array snapshot problem https://review.openstack.org/193954 | 15:52 |
| *** e0ne is now known as e0ne_ | 15:53 | |
| harlowja_still_a | DuncanT, having fun are we :-P | 15:53 |
| harlowja_still_a | stop scheduling people to come to your houses after your demolish them :-P | 15:53 |
| openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 15:53 |
| openstackgerrit | Thang Pham proposed openstack/cinder: WIP: RPC and object versioning https://review.openstack.org/184404 | 15:53 |
| dulek | jgriffith: So probably once volume object will get merged, we won't need pass even snapshot_id and all other stuff. Just plain Volume object. | 15:53 |
| dulek | jgriffith: Hah, talking about commit which thangp just updated. ;) | 15:54 |
| *** e0ne_ is now known as e0ne | 15:55 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: WIP: Refactoring of manager's create_volume flow https://review.openstack.org/193167 | 15:55 |
| *** lcurtis has joined #openstack-cinder | 15:55 | |
| dulek | Ah, there's merge conflict because of dependent change... | 15:56 |
| jgriffith | dulek: haha | 15:56 |
| *** lcurtis has quit IRC | 15:57 | |
| *** lcurtis has joined #openstack-cinder | 15:57 | |
| dulek | jgriffith: Okay, I've got to go now. I would be grateful if you've found some time to take a look at this code and see if you have more ideas to improve this flows.manager.create_volume module. :) | 15:58 |
| jgriffith | dulek: yeah, adding some comments now :) | 15:59 |
| harlowja_still_a | that code is the bestest | 15:59 |
| harlowja_still_a | :-/ | 15:59 |
| *** jistr_ has quit IRC | 15:59 | |
| harlowja_still_a | dulek, do u think https://review.openstack.org/#/c/185116/ would help ? or maybe not, at least could structure it without classes | 16:00 |
| harlowja_still_a | see https://review.openstack.org/#/c/185116/9/taskflow/examples/linear_decorations.py | 16:00 |
| DuncanT | harlowja_still_a: Scheduling people not to come to your house after it is demolished is easy when one secretary is doing the planning... when there are 20 doing the planning it gets far trickier... | 16:01 |
| harlowja_still_a | get better secreataries (in fact i need one, can u get me one) | 16:02 |
| DuncanT | harlowja_still_a: The need for parallelism and loose coupling is exactly why we want to improve the existing API | 16:02 |
| harlowja_still_a | your secretaries need to communicate better, if they have quartly/year reviews, u might want to mention that in the 'room for improvement' section | 16:03 |
| harlowja_still_a | :) | 16:03 |
| *** leeantho has joined #openstack-cinder | 16:04 | |
| DuncanT | I'm using cheap secretaries and understanding contractors, turns out if I give the contractors enough work they don't mind the occasional duff job | 16:04 |
| harlowja_still_a | damn cheapies | 16:04 |
| harlowja_still_a | lol | 16:04 |
| harlowja_still_a | use a different temp agency man | 16:05 |
| harlowja_still_a | lol | 16:05 |
| DuncanT | Expensive secretaries spend all their time chatting to each other and get no real work done | 16:05 |
| harlowja_still_a | lol | 16:05 |
| DuncanT | (the metaphor *will* continue to be beaten to make my point ;-) ) | 16:05 |
| harlowja_still_a | :) | 16:05 |
| * harlowja_still_a doesn't even have 1 secretary and u apparently have alot | 16:06 | |
| * harlowja_still_a feels left out | 16:06 | |
| harlowja_still_a | jgriffith, will u be my secretary? | 16:06 |
| harlowja_still_a | lol | 16:06 |
| *** markstur has quit IRC | 16:07 | |
| *** annegentle has quit IRC | 16:07 | |
| *** rwsu has joined #openstack-cinder | 16:08 | |
| *** MentalRay has quit IRC | 16:09 | |
| *** avishay_ has joined #openstack-cinder | 16:10 | |
| *** avishay_ is now known as avishay | 16:10 | |
| avishay | jgriffith: yoo | 16:10 |
| harlowja_still_a | DuncanT, so why do u think it would be so hard to say save somewhere a task-work-graph (or text file or whatever); and have each secretary try to mutate that graph/text file with there 'desired' operations, then either commit the new graph, or find that there desired operation conflicts with something that is undergoing/planned? | 16:12 |
| harlowja_still_a | seems like not impossible... | 16:12 |
| harlowja_still_a | maybe not simple, but not impossible | 16:12 |
| DuncanT | harlowja_still_a: HA | 16:12 |
| harlowja_still_a | *but thats life* | 16:12 |
| DuncanT | harlowja_still_a: And performance | 16:12 |
| *** markstur has joined #openstack-cinder | 16:12 | |
| harlowja_still_a | HA, thats not that hard, use a HA backend, performance, well get that going after u get the stuff working reliably no? i mean this doesn't imho seem crazy | 16:13 |
| DuncanT | harlowja_still_a: If a task fails then any future-task validation you've done already might now be wrong anyway, so you clients need to be able to retry tasks - might as well push all the retries on conflicting behaviour back to the user and keep the cinder code simle and robust | 16:14 |
| harlowja_still_a | databases do this stuff all the time afaik (query planners...) | 16:14 |
| *** DericHorn-HP has quit IRC | 16:14 | |
| harlowja_still_a | DuncanT, make the failure stuff part of that same graph and analyze it as well when planning new work | 16:15 |
| harlowja_still_a | avoiding conflicts even when things fail... | 16:15 |
| DuncanT | Query planners are damn hard to write, and even the really good ones still do dump things.... | 16:15 |
| DuncanT | One of the reasons noSQL can get better performance is by going for eventual consistency | 16:16 |
| DuncanT | Rather than guaranteed immediate consistency... we can (and IMO should) do the same thing with cinder | 16:16 |
| harlowja_still_a | sounds like we are running before we have past the baby stage and want to get to crawling first :-P | 16:17 |
| *** DericHorn-HP has joined #openstack-cinder | 16:17 | |
| DuncanT | Quite the opposite, you're the one talking about writing a graph reducing query engine... | 16:17 |
| harlowja_still_a | graph reducing execution planning engine :-P | 16:18 |
| harlowja_still_a | GREPE for short, hahaha | 16:18 |
| harlowja_still_a | *not related to grep | 16:18 |
| harlowja_still_a | lol | 16:18 |
| harlowja_still_a | anyways, just brainstorming, i don't see it as impossible, or that hard (aka, don't make it a GREPE at the start) | 16:19 |
| *** asselin_ has quit IRC | 16:20 | |
| DuncanT | Just put all tasks in a queue for every resource they touch, then when all strands of a task hit the front of the queues then it can be executed,,, if something (explicitly) goes away with tasks still in its queue then fail the task immediately and let the user decide what to do | 16:20 |
| harlowja_still_a | sure, thats fine to | 16:21 |
| DuncanT | I'd still like to know what is perceived as bad about the glance task interface, see what we can learn | 16:21 |
| harlowja_still_a | unsure | 16:21 |
| jgriffith | DuncanT: that queue proposal sounds vaguely familiar :) | 16:21 |
| *** beekneemech has joined #openstack-cinder | 16:21 | |
| DuncanT | I've heard mostly bad things about glance tasks, but very little detail | 16:22 |
| *** jordanP has quit IRC | 16:22 | |
| DuncanT | I'll see if I can find a few haters and get details | 16:22 |
| harlowja_still_a | i'm unsure, a co-worker is looking into it so i can poke him to | 16:22 |
| DuncanT | (atomic queues can be build on top of SQL using unique constraints quite easily... big advantage) | 16:22 |
| harlowja_still_a | he's trying to see whats missing (tempest stuff?) or whats working/not ... | 16:23 |
| harlowja_still_a | *in the glance task stuff | 16:23 |
| DuncanT | I'd like to hear what he thinks, please... I'll go grep my IRC logs and figure out who was hating on it, ask them too | 16:23 |
| *** bnemec has quit IRC | 16:23 | |
| harlowja_still_a | DuncanT, i think some of the hate was just about it needing integration tests (due to lack of time/people...) | 16:24 |
| harlowja_still_a | so thats why i'm getting some y! co-worker folks involved, to help... | 16:24 |
| jgriffith | avishay: halo | 16:24 |
| harlowja_still_a | clean it up, get integration tests ... (it also uses taskflow, so want to make sure its not to baddly off) | 16:24 |
| avishay | jgriffith: i think lio in juno is broken :( | 16:25 |
| jgriffith | avishay: yeah, so I think that backport was no-bueno | 16:25 |
| jgriffith | geguileo: is looking at it | 16:25 |
| avishay | jgriffith: the backport was fine - there is a missing commit somehow | 16:25 |
| jgriffith | avishay: well, it's not :) | 16:25 |
| avishay | jgriffith: i don't see this in juno - https://review.openstack.org/#/c/130399/4 | 16:25 |
| jgriffith | avishay: because my change was merged AFTER the target break out work | 16:25 |
| jgriffith | avishay: which is where that impl for LIO was | 16:26 |
| jgriffith | avishay: so the backport pulled in everything happy as can be, but didn't catch the fact that target_helper was now COMPLETELY different | 16:26 |
| avishay | jgriffith: gotcha, yeesh :) | 16:26 |
| jgriffith | avishay: yeah :( | 16:27 |
| avishay | jgriffith: is there any CI for LIO? | 16:27 |
| jgriffith | avishay: of course not | 16:27 |
| jgriffith | avishay: I proposed it be removed last summer | 16:27 |
| avishay | jgriffith: then it should be removed (i'm not sure if i'm kidding or not) | 16:27 |
| jgriffith | avishay: because of things like this, and the fact that it's quite difficult to even get it to run on Ubuntu | 16:27 |
| jgriffith | avishay: I agree with you 100% | 16:27 |
| jgriffith | avishay: you can argue it this time though, I'm not wasting my time again :) | 16:28 |
| *** rakesh_mishra has quit IRC | 16:28 | |
| jgriffith | avishay: I even tried to document installing/running on Ubuntu and logging bugs to get it up to speed so a CI could be turned on | 16:28 |
| *** Zhongjun has quit IRC | 16:28 | |
| jgriffith | but couldn't get a straight answer on FB vs non FB blah blah blah | 16:28 |
| *** _cjones_ has joined #openstack-cinder | 16:32 | |
| avishay | jgriffith: wow, wasted lots of time thinking it was stable | 16:34 |
| *** krtaylor has quit IRC | 16:35 | |
| jgriffith | avishay: it may be :) | 16:35 |
| jgriffith | avishay: I know RHEL makes it default, which is why that patch needed backported to begin with | 16:35 |
| avishay | jgriffith: no it's absolutely broken :) | 16:35 |
| jgriffith | avishay: it breaks EVERYBODY else | 16:35 |
| jgriffith | avishay: that was my conclusion on Ubuntu | 16:36 |
| jgriffith | avishay: and given it was added over a year ago seems crazy that it's still there | 16:36 |
| avishay | jgriffith: according to the CI rules it should be removed | 16:40 |
| jgriffith | avishay: +1 | 16:40 |
| avishay | jgriffith: you can't be blamed for a bad rebase on something with no checks | 16:40 |
| jgriffith | avishay: Well, I can, and likely will :) | 16:40 |
| jgriffith | but that's ok | 16:40 |
| avishay | jgriffith: well i don't blame you if it makes you feel better :) | 16:41 |
| jgriffith | avishay: it does :) | 16:41 |
| geguileo | jgriffith: Do you have that doc you mentioned you worked on to get LIO on Ubuntu working? | 16:41 |
| avishay | jgriffith: i'm off, thanks | 16:41 |
| jgriffith | geguileo: Oh boy... | 16:41 |
| geguileo | avishay: I don't blame him either, I blame myself for not checking it better :( | 16:41 |
| jgriffith | avishay: catch ya later | 16:41 |
| *** avishay has quit IRC | 16:41 | |
| jgriffith | geguileo: nah, not your fault either. AFAIK Rhel is the only platforms it even remotely works on anyway | 16:42 |
| jgriffith | geguileo: I'll see if I can find my notes | 16:43 |
| geguileo | jgriffith: I'd like to work on creating some CI that actually tests LIO, that's why I was asking about your doc for Ubuntu | 16:43 |
| jgriffith | geguileo: so a couple of problems I had... | 16:43 |
| geguileo | jgriffith: Thanks, that would be awesome | 16:43 |
| jgriffith | geguileo: I had to update the kernel on Ubuntu to even install the packages | 16:43 |
| jgriffith | geguileo: which for me was a deal breaker right there | 16:43 |
| *** _cjones_ has quit IRC | 16:43 | |
| *** MentalRay has joined #openstack-cinder | 16:43 | |
| jgriffith | geguileo: that I couldn't run it in the gate without a kernel package | 16:43 |
| *** _cjones_ has joined #openstack-cinder | 16:43 | |
| jgriffith | geguileo: although I suppose that's doable | 16:44 |
| geguileo | jgriffith: I'll try to see what I can do | 16:44 |
| jgriffith | geguileo: if nothing else I'm happy to run back through it again on the Ubuntu side and we can team up on it | 16:45 |
| geguileo | jgriffith: Ok, I'll start by installing an Ubuntu and see if I can get LIO running there | 16:46 |
| jgriffith | geguileo: awesome | 16:46 |
| *** harlowja_still_a has quit IRC | 16:47 | |
| jgriffith | geguileo: this may help: https://goo.gl/uJyJM4 | 16:47 |
| jgriffith | geguileo: although IMO it's crap that it needs vendor packages to work | 16:48 |
| geguileo | jgriffith: Thanks! | 16:48 |
| jgriffith | but my understanding from avirambh is that it is the best chance to work :) | 16:48 |
| geguileo | Maybe there's a workaround for that | 16:48 |
| jgriffith | geguileo: probably | 16:49 |
| geguileo | Good to know | 16:49 |
| geguileo | I'll start with that | 16:49 |
| *** DericHorn-HP has quit IRC | 16:49 | |
| *** patrickeast has quit IRC | 16:51 | |
| *** changbl has quit IRC | 16:53 | |
| *** DericHorn-HP has joined #openstack-cinder | 16:53 | |
| *** mutoulbj has joined #openstack-cinder | 16:56 | |
| *** bluex-pl has quit IRC | 16:59 | |
| *** e0ne has quit IRC | 16:59 | |
| *** krtaylor has joined #openstack-cinder | 17:04 | |
| *** mriedem has quit IRC | 17:05 | |
| *** vokt has joined #openstack-cinder | 17:06 | |
| *** ronis has joined #openstack-cinder | 17:06 | |
| *** shyama has joined #openstack-cinder | 17:11 | |
| *** annegentle has joined #openstack-cinder | 17:12 | |
| *** patrickeast has joined #openstack-cinder | 17:13 | |
| jgriffith | patrickeast: trying to get your patch loaded up BTW | 17:19 |
| jgriffith | patrickeast: should have feedback later today | 17:19 |
| patrickeast | jgriffith: sweet | 17:20 |
| patrickeast | jgriffith: thanks for helping with this | 17:20 |
| *** vincent_hou has quit IRC | 17:20 | |
| *** changbl has joined #openstack-cinder | 17:30 | |
| *** dontalton has joined #openstack-cinder | 17:32 | |
| *** xyang1 has joined #openstack-cinder | 17:33 | |
| *** sgotliv has quit IRC | 17:34 | |
| *** MentalRay has quit IRC | 17:42 | |
| *** chlong has quit IRC | 17:43 | |
| *** aarefiev_home has quit IRC | 17:48 | |
| *** dalgaaf has quit IRC | 17:48 | |
| *** annegentle has quit IRC | 17:49 | |
| *** annegentle has joined #openstack-cinder | 17:51 | |
| *** mriedem has joined #openstack-cinder | 17:52 | |
| jgriffith | patrickeast: I seem to be missing something | 17:56 |
| jgriffith | patrickeast: I've enabled the conf setting, but not getting the second/cache volume | 17:57 |
| jgriffith | patrickeast: also, wondering... would it be mo-betta to move this into the manager? | 17:57 |
| patrickeast | jgriffith: uhh yes | 17:57 |
| patrickeast | jgriffith: so you set the cache to enabled, and set the internal tenant settings? | 17:57 |
| jgriffith | nope, internal tenant is what I'm missing :) | 17:58 |
| patrickeast | jgriffith: if you grep for ‘IMG-CACHE’ in the log it should show what it was trying to do/where it failed | 17:58 |
| patrickeast | i left those shotgunned around while debugging stuff | 17:58 |
| *** aarefiev_home has joined #openstack-cinder | 17:58 | |
| patrickeast | jgriffith: i’ve been thinking how best to do it in the manager, and i’m not sure how to do it easily, we kind of need to do the cache stuff at the point in time where we are either going to download it or not in the flow | 17:59 |
| jgriffith | hmmm... | 17:59 |
| patrickeast | jgriffith: i refactored it a bunch of friday so most of the actual code lives under cinder/image/cache.py now | 17:59 |
| jgriffith | so I don't see IMG-CACHE in my logs at all :( | 17:59 |
| patrickeast | jgriffith: so its at least less stuff | 17:59 |
| patrickeast | jgriffith: o | 17:59 |
| patrickeast | jgriffith: thats odd | 17:59 |
| jgriffith | patrickeast: I've apparantly missed something... lemme try a rejoin | 18:00 |
| patrickeast | jgriffith: i have bene watching it via tail -f /opt/stack/logs/screen/screen-c-vol.log /opt/stack/logs/screen/screen-c-api.log | grep -i 'IMG-CACHE' | 18:00 |
| *** xyang has joined #openstack-cinder | 18:00 | |
| jgriffith | patrickeast: yeah, got it I think | 18:00 |
| jgriffith | patrickeast: ok, so how are you setting the account? I'm far too lazy to read the code :) | 18:01 |
| patrickeast | jgriffith: i added this to my default section http://paste.openstack.org/show/325473/ | 18:02 |
| patrickeast | in cinder.conf | 18:02 |
| patrickeast | and you need a user/project to match | 18:02 |
| jgriffith | patrickeast: cool, that expplains that :) | 18:02 |
| jgriffith | patrickeast: we should automate that :) | 18:02 |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 18:03 |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object https://review.openstack.org/163641 | 18:03 |
| patrickeast | jgriffith: yea thats on my todo list to investigate | 18:03 |
| jgriffith | :) | 18:03 |
| jgriffith | fun with keystone | 18:03 |
| *** markus_z has quit IRC | 18:04 | |
| xyang | jgriffith: hi, question for you. Why were consistencygroup_id and cgsnapshot_id all removed here? https://review.openstack.org/#/c/193167/ | 18:07 |
| jgriffith | xyang: hehe.. yeah, that's what I asked :) | 18:07 |
| jgriffith | xyang: so dulek pointed out they're not actually used | 18:08 |
| xyang | jgriffith: oh, ok. I thought you know what he was doing | 18:08 |
| jgriffith | xyang: it turns out if you look at the flow, it actually sets host explicitly and bypasses the scheduler | 18:08 |
| xyang | jgriffith: they are needed | 18:08 |
| *** pradipta has quit IRC | 18:08 | |
| patrickeast | xyang: somewhat related, are there tempest tests for cg? | 18:08 |
| jgriffith | patrickeast: no | 18:09 |
| jgriffith | patrickeast: because the ref has no concept of CG's | 18:09 |
| xyang | jgriffith: so he still needs snapshot_id, source volume id for create volume, correct? | 18:09 |
| patrickeast | jgriffith: ah right | 18:09 |
| jgriffith | xyang: yes... | 18:09 |
| xyang | jgriffith: then he need cg is and cg snapshot id for the same reason | 18:09 |
| jgriffith | xyang: so TBH that's why I asked him about it, the calls for CG get kinda wierd | 18:09 |
| xyang | jgriffith: those need to be passed to manager and then to the driver | 18:10 |
| jgriffith | xyang: so he's right WRT it being short circuited on the create | 18:10 |
| xyang | jgriffith: otherwise where do we get those? | 18:10 |
| jgriffith | xyang: because we get the host and do a direct call bypassing scheduler altogether | 18:10 |
| xyang | jgriffith: yes, create a empty CG goes thru scheduler | 18:11 |
| xyang | jgriffith: create a volume and add to CG will just use the existing host | 18:11 |
| xyang | jgriffith: create a cg snapshot will use the same host as the source cg | 18:11 |
| jgriffith | xyang: so the last two were the ones that I followed in his change | 18:11 |
| xyang | jgriffith: so same as snapshot_id, src_vol_id, image_id, | 18:11 |
| jgriffith | xyang: so just FYI, I was unsure that this would work and asked him about it | 18:12 |
| xyang | jgriffith: I don't think he tested it at all | 18:12 |
| jgriffith | xyang: I also think we need to put some comments in the code to explain how CG's are working | 18:12 |
| xyang | jgriffith: we can't create a volume and place it in a CG with this change | 18:12 |
| jgriffith | xyang: because we're relying on people like me to review and try and follow the code which isn't so good :) | 18:12 |
| xyang | jgriffith: sure, I can help with that | 18:12 |
| jgriffith | xyang: ok, so that's great you saw this then | 18:13 |
| jgriffith | xyang: I certainly would've required your review before I gave it a + | 18:13 |
| xyang | jgriffith: sure:) | 18:13 |
| xyang | jgriffith: so the CG code in scheduler is needed also because an empty CG doesn't have a host yet | 18:14 |
| *** earlephilhower has joined #openstack-cinder | 18:14 | |
| jgriffith | xyang: yeah, I see that here | 18:14 |
| xyang | jgriffith: ok | 18:14 |
| *** earlephilhower has quit IRC | 18:14 | |
| *** earlephilhower has joined #openstack-cinder | 18:14 | |
| *** mutoulbj has quit IRC | 18:24 | |
| *** openstackgerrit has quit IRC | 18:30 | |
| *** openstackgerrit has joined #openstack-cinder | 18:30 | |
| *** dtynan has quit IRC | 18:31 | |
| *** dtynan has joined #openstack-cinder | 18:32 | |
| *** ociuhandu has quit IRC | 18:34 | |
| *** IlyaG has joined #openstack-cinder | 18:36 | |
| *** IlyaG has quit IRC | 18:37 | |
| *** shyama has quit IRC | 18:40 | |
| *** afazekas_ has joined #openstack-cinder | 18:41 | |
| *** mutoulbj has joined #openstack-cinder | 18:43 | |
| *** krtaylor has quit IRC | 18:44 | |
| *** jdurgin has joined #openstack-cinder | 18:46 | |
| *** mutoulbj has quit IRC | 18:48 | |
| *** nikeshm has joined #openstack-cinder | 18:49 | |
| *** markvoelker_ has joined #openstack-cinder | 18:51 | |
| *** markvoelker has quit IRC | 18:52 | |
| *** Rockyg has joined #openstack-cinder | 18:55 | |
| *** markvoelker_ has quit IRC | 18:57 | |
| *** markvoelker has joined #openstack-cinder | 18:57 | |
| *** Apoorva has quit IRC | 19:04 | |
| *** Lee1092 has quit IRC | 19:05 | |
| *** Apoorva has joined #openstack-cinder | 19:06 | |
| *** lpetrut has joined #openstack-cinder | 19:12 | |
| *** boris-42 has quit IRC | 19:12 | |
| *** afazekas_ has quit IRC | 19:15 | |
| *** ociuhandu has joined #openstack-cinder | 19:19 | |
| *** scottda has joined #openstack-cinder | 19:25 | |
| *** ronis has quit IRC | 19:25 | |
| thangp | harlowja: ping | 19:31 |
| harlowja | pong | 19:31 |
| thangp | harlowja: I am getting a py34 error on my patch - http://logs.openstack.org/54/177054/40/check/gate-cinder-python34/5bcd306/console.html | 19:31 |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: Add support for consistency groups https://review.openstack.org/196818 | 19:32 |
| thangp | harlowja: it works with py27, but failed in py34 with taskflow.exceptions.StorageFailure: Storage backend internal error | 19:32 |
| thangp | harlowja: I can't explain it, wondering if you have any insight | 19:32 |
| harlowja | looks like some versionedobject stuff no? | 19:33 |
| harlowja | when taskflow is trying to compare equality (to determine if the variable should be retained) it looks like thats puking | 19:33 |
| thangp | harlowja: yeah, but nothing has really changed within the taskflow | 19:33 |
| harlowja | right | 19:33 |
| harlowja | but versioned objects might have some issue? | 19:33 |
| harlowja | http://logs.openstack.org/54/177054/40/check/gate-cinder-python34/5bcd306/console.html#_2015-06-29_16_33_17_810 | 19:34 |
| thangp | maybe | 19:34 |
| harlowja | it more looks like versionedobjects forget to check None somehow? | 19:34 |
| harlowja | before running 'return self.obj_to_primitive() == obj.obj_to_primitive()' | 19:34 |
| harlowja | *whatever that does | 19:34 |
| thangp | obj_to_primitive just converts the object to a primitive | 19:34 |
| thangp | like a dict | 19:35 |
| harlowja | like maybe it forget to check | 19:35 |
| harlowja | if obj is None: return False or somethign | 19:35 |
| thangp | the weird thing is it only fails on test_rbd | 19:35 |
| thangp | other ones pass | 19:35 |
| thangp | for py34 | 19:35 |
| *** dtynan has quit IRC | 19:35 | |
| harlowja | ya, my thinking is some versioned objects bug that should be fixed/reported | 19:36 |
| harlowja | def doesn't seem to be checking equality (or lack of equality) correctly? | 19:36 |
| harlowja | wanna poke dan smith on #openstack-oslo | 19:36 |
| harlowja | he might know | 19:36 |
| thangp | well...it looks like the obj is not even passed through correctly | 19:36 |
| *** dtynan has joined #openstack-cinder | 19:36 | |
| harlowja | idk, idk, if self.results != other.results: will compare against none | 19:37 |
| harlowja | *only one idk, ha | 19:37 |
| harlowja | since self.results starts off as None | 19:37 |
| harlowja | *lack of results* | 19:37 |
| thangp | i was wondering if there was anything related to the engine storage | 19:38 |
| harlowja | nope, not in this case imho | 19:38 |
| harlowja | https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L638 does seem wrong | 19:38 |
| harlowja | ^ seems to have forget to check types, check none ... | 19:39 |
| thangp | like obj isinstance of? | 19:39 |
| harlowja | ya, for example try http://paste.openstack.org/show/325732/ | 19:41 |
| harlowja | != will call into __eq__ | 19:41 |
| openstack | harlowja: Error: "=" is not a valid command. | 19:41 |
| harlowja | by magic | 19:41 |
| dims | thangp: please open a bug against oslo.versionedobjects in launchpad | 19:41 |
| harlowja | " != will call into __eq__ " | 19:41 |
| harlowja | which then barfss | 19:41 |
| dims | harlowja: want to do a g-r exclude of the version released today? 0.5.0 | 19:41 |
| harlowja | unsure | 19:42 |
| harlowja | probably? | 19:42 |
| thangp | harlowja: thanks, that makes sense | 19:43 |
| harlowja | so something is going on there | 19:43 |
| harlowja | but beyond me area of knowledge :-P | 19:44 |
| thangp | I'll open a bug, and see if dansmith knows | 19:44 |
| harlowja | thangp and interestingly this is the output from 2.7 | 19:44 |
| dansmith | thangp: asking about equality of objects? | 19:45 |
| harlowja | thingee eq called with None | 19:45 |
| harlowja | False | 19:45 |
| harlowja | True | 19:45 |
| *** annegentle has quit IRC | 19:45 | |
| harlowja | and on 3.4 | 19:45 |
| harlowja | thingee eq called with None | 19:45 |
| harlowja | False | 19:45 |
| harlowja | thingee eq called with None | 19:45 |
| harlowja | True | 19:45 |
| thangp | dansmith: yes | 19:45 |
| harlowja | sooo there is some differnce in how this works on 2.7 and 3.4 (when __eq__ is called vs when it isn't) | 19:45 |
| dansmith | thangp: we specifically don't want to declare a base object equality operator | 19:45 |
| thangp | dansmith: http://logs.openstack.org/54/177054/40/check/gate-cinder-python34/5bcd306/console.html#_2015-06-29_16_33_17_810 | 19:45 |
| *** hodos has joined #openstack-cinder | 19:45 | |
| dansmith | thangp: there are lots of reasons but they all center around the fact that equality can be defined in lots of different ways | 19:45 |
| harlowja | thangp interestingly i think in 3.4 they started to call __eq__ for != "when i guess __neq__ is declared but __eq__ is" | 19:46 |
| harlowja | *when __neq__ isn't declared | 19:46 |
| dansmith | thangp: for example, if you only have some attributes loaded, you can't really say whether two things are equal since you don't know the values of the unloaded bits | 19:46 |
| dansmith | thangp: in other cases, a.uuid == b.uuid might be the right comparison | 19:46 |
| thangp | harlowja: huh, odd | 19:46 |
| dansmith | thangp: so we decided not to define it at the bottom | 19:46 |
| harlowja | thangp i'm thinking thats why it is borking on 3.4 (due to that __neq__ and __eq__ change) | 19:47 |
| dansmith | thangp: oh my, I just noticed that we let that creep in! | 19:48 |
| dansmith | oh, no it's in a mixin | 19:48 |
| dansmith | whew :D | 19:48 |
| harlowja | dansmith it seems like != will call into that to | 19:48 |
| harlowja | on 3.4 at least | 19:48 |
| harlowja | which means if obj is something else (like None or "a" or ...") then it will puke on None.obj_to_primitive() (no attribute) | 19:49 |
| harlowja | which appears to have been happening | 19:49 |
| dansmith | harlowja: yeah, bug | 19:49 |
| harlowja | k | 19:49 |
| *** annegentle has joined #openstack-cinder | 19:50 | |
| thangp | dansmith, harlowja: i'll open a bug | 19:50 |
| dansmith | unless you want to go propose adding obj_to_primitive() to python's None :D | 19:50 |
| harlowja | :-P | 19:50 |
| *** lpetrut has quit IRC | 19:50 | |
| dansmith | thangp: thanks | 19:50 |
| harlowja | probably should just use https://docs.python.org/3/library/functools.html#functools.total_ordering or something | 19:50 |
| dims | thangp: dansmith: harlowja: an exclude is in place for now - https://review.openstack.org/#/c/196826/ - need to wait for that to merge | 19:51 |
| harlowja | k | 19:52 |
| Swanson | We need better driver class names than TransferVD and ManageableVD. | 19:57 |
| *** annegent_ has joined #openstack-cinder | 19:58 | |
| *** annegentle has quit IRC | 20:01 | |
| tbarron | Swanson: :-) | 20:05 |
| openstackgerrit | Tom Swanson proposed openstack/cinder: Dell SC: Add support for consistency groups https://review.openstack.org/196818 | 20:15 |
| *** Longgeek has quit IRC | 20:21 | |
| *** dontalton has quit IRC | 20:26 | |
| *** hodos|2 has joined #openstack-cinder | 20:28 | |
| *** annegent_ has quit IRC | 20:28 | |
| *** julim has quit IRC | 20:29 | |
| *** annegentle has joined #openstack-cinder | 20:29 | |
| *** jungleboyj has quit IRC | 20:30 | |
| *** vokt has quit IRC | 20:30 | |
| openstackgerrit | Thang Pham proposed openstack/cinder: Conversion to volume object https://review.openstack.org/177054 | 20:30 |
| openstackgerrit | Thang Pham proposed openstack/cinder: WIP: RPC and object versioning https://review.openstack.org/184404 | 20:30 |
| *** boris-42 has joined #openstack-cinder | 20:31 | |
| *** hodos has quit IRC | 20:31 | |
| *** krtaylor has joined #openstack-cinder | 20:38 | |
| *** krtaylor has quit IRC | 20:39 | |
| *** MentalRay has joined #openstack-cinder | 20:39 | |
| *** krtaylor has joined #openstack-cinder | 20:40 | |
| *** edmondsw has quit IRC | 20:43 | |
| *** annegentle has quit IRC | 20:46 | |
| *** MentalRay has quit IRC | 20:56 | |
| *** vokt has joined #openstack-cinder | 20:59 | |
| *** annegentle has joined #openstack-cinder | 21:05 | |
| *** Yogi1 has joined #openstack-cinder | 21:08 | |
| *** Rockyg has quit IRC | 21:09 | |
| *** MentalRay has joined #openstack-cinder | 21:12 | |
| *** Yogi1 has quit IRC | 21:12 | |
| *** krtaylor has quit IRC | 21:13 | |
| *** jungleboyj has joined #openstack-cinder | 21:20 | |
| *** Longgeek has joined #openstack-cinder | 21:22 | |
| *** r-daneel has quit IRC | 21:23 | |
| *** mriedem is now known as mriedem_away | 21:24 | |
| *** kjnelson has quit IRC | 21:26 | |
| *** thangp has quit IRC | 21:43 | |
| *** IanGovett has quit IRC | 21:45 | |
| *** eharney has quit IRC | 21:45 | |
| *** aarefiev_home has quit IRC | 21:45 | |
| *** krtaylor has joined #openstack-cinder | 21:52 | |
| *** rmesta1 has joined #openstack-cinder | 21:53 | |
| *** Longgeek has quit IRC | 21:56 | |
| *** Rockyg has joined #openstack-cinder | 22:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder: Updated from global requirements https://review.openstack.org/196888 | 22:10 |
| *** Rockyg has quit IRC | 22:12 | |
| *** Rockyg has joined #openstack-cinder | 22:13 | |
| *** daneyon has joined #openstack-cinder | 22:15 | |
| *** daneyon_ has joined #openstack-cinder | 22:16 | |
| *** jungleboyj has quit IRC | 22:17 | |
| *** daneyon has quit IRC | 22:20 | |
| *** tsekiyama has joined #openstack-cinder | 22:21 | |
| *** tsbot_ has joined #openstack-cinder | 22:22 | |
| *** annegentle has quit IRC | 22:22 | |
| *** annegentle has joined #openstack-cinder | 22:23 | |
| *** nikeshm has quit IRC | 22:24 | |
| *** MentalRay has quit IRC | 22:24 | |
| *** xyang has quit IRC | 22:24 | |
| *** xyang has joined #openstack-cinder | 22:24 | |
| openstackgerrit | xing-yang proposed openstack/cinder: Non-disruptive backup https://review.openstack.org/193937 | 22:25 |
| *** annegentle has quit IRC | 22:35 | |
| *** annegentle has joined #openstack-cinder | 22:50 | |
| *** dims_ has joined #openstack-cinder | 22:55 | |
| *** dims has quit IRC | 22:59 | |
| *** daneyon_ has quit IRC | 23:00 | |
| *** dims_ has quit IRC | 23:00 | |
| *** MentalRay has joined #openstack-cinder | 23:02 | |
| *** jecarey has quit IRC | 23:02 | |
| *** lcurtis has quit IRC | 23:03 | |
| *** xyang1 has quit IRC | 23:05 | |
| *** markvoelker has quit IRC | 23:13 | |
| *** annegentle has quit IRC | 23:13 | |
| *** rmesta1 has quit IRC | 23:14 | |
| *** vokt has quit IRC | 23:14 | |
| *** hodos|2 has quit IRC | 23:18 | |
| *** edmondsw has joined #openstack-cinder | 23:24 | |
| *** jasondotstar has joined #openstack-cinder | 23:31 | |
| *** boris-42 has quit IRC | 23:32 | |
| *** yamada-h has joined #openstack-cinder | 23:32 | |
| *** yamada-h has quit IRC | 23:37 | |
| *** jwcroppe_ has joined #openstack-cinder | 23:38 | |
| *** jwcroppe has quit IRC | 23:42 | |
| *** jwcroppe_ has quit IRC | 23:43 | |
| *** garthb__ has joined #openstack-cinder | 23:44 | |
| *** garthb_ has quit IRC | 23:48 | |
| *** garthb has quit IRC | 23:48 | |
| *** garthb__ has quit IRC | 23:49 | |
| *** jwcroppe has joined #openstack-cinder | 23:50 | |
| *** markvoelker has joined #openstack-cinder | 23:51 | |
| *** edmondsw has quit IRC | 23:51 | |
| *** Longgeek has joined #openstack-cinder | 23:54 | |
| *** laughterwym has joined #openstack-cinder | 23:54 | |
| *** smoriya has joined #openstack-cinder | 23:54 | |
| *** dannywil_ has joined #openstack-cinder | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!